Re: Review Request 57136: Pom.xml change in Workflow manager to fix the version of front end plugin to make it compatible with the maven version used in ambari

2017-02-28 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57136/#review167100 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 28, 2017

Re: Review Request 57120: Hive View 2.0 LogAggregator prints lots of warning logs.

2017-02-28 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57120/#review167066 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 28, 2017, 4

Re: Review Request 57126: HiveView2.0: Logs tab is always empty

2017-02-28 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57126/#review167065 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 28, 2017, 6

Re: Review Request 57124: Hive view 2.0 Fetch stats doesn't work when you point against LLAP

2017-02-28 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57124/#review167064 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 28, 2017, 5

Re: Review Request 57143: HiveView2.0 - settings not taking effect

2017-02-28 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57143/#review167060 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 28, 2017, 1

Re: Review Request 57130: Clicking save button keeps the dialog window open, When job is submitted, the dialog stays open

2017-02-28 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57130/#review167057 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 28, 2017, 9

Review Request 57141: Hive View 2.0: Code hints for query editor are not working

2017-02-28 Thread Pallav Kulshreshtha
, Pallav Kulshreshtha, and Rohit Choudhary. Bugs: AMBARI-19673 https://issues.apache.org/jira/browse/AMBARI-19673 Repository: ambari Description --- User should be able to see code hints and syntax colorization while typing hive queries. Diffs - contrib/views/hive20/src/main

Re: Review Request 57131: HiveView 2.0 : After download CSV, the pop-up persists

2017-02-28 Thread Pallav Kulshreshtha
/app/services/query.js 3bf10c0 contrib/views/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs ad44c5a Diff: https://reviews.apache.org/r/57131/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Review Request 57131: HiveView 2.0 : After download CSV, the pop-up persists

2017-02-28 Thread Pallav Kulshreshtha
/hive20/src/main/resources/ui/app/templates/queries/query/results.hbs ad44c5a Diff: https://reviews.apache.org/r/57131/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Review Request 57100: Select operators should not appear before fetch

2017-02-27 Thread Pallav Kulshreshtha
, Pallav Kulshreshtha

Re: Review Request 57041: DB selected is not persisted while switching between tabs, SavedQuery tab does not show preview, if the query is not executed before saving

2017-02-25 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57041/#review166816 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 24, 2017, 2

Re: Review Request 57019: HiveView2.0: No notifications for successful query which yields no output.

2017-02-24 Thread Pallav Kulshreshtha
/hive20/src/main/resources/ui/app/templates/queries/query/visual-explain.hbs 5b7e566 Diff: https://reviews.apache.org/r/57019/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Review Request 57036: Hive View 2.0: Service checks stopped working.

2017-02-24 Thread Pallav Kulshreshtha
Diff: https://reviews.apache.org/r/57036/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Review Request 57033: Hive 2: Compact Visual Explain Plan is not loading in firefox

2017-02-24 Thread Pallav Kulshreshtha
, Pallav Kulshreshtha

Re: Review Request 57019: HiveView2.0: No notifications for successful query which yields no output.

2017-02-23 Thread Pallav Kulshreshtha
/hive20/src/main/resources/ui/app/templates/queries/query/visual-explain.hbs ef441b5 Diff: https://reviews.apache.org/r/57019/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Review Request 57019: HiveView2.0: No notifications for successful query which yields no output.

2017-02-23 Thread Pallav Kulshreshtha
/query/visual-explain.hbs ef441b5 Diff: https://reviews.apache.org/r/57019/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56973: Hive view 2.0 : Hanging query - no cancel available

2017-02-22 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56973/#review166490 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 23, 2017, 7

Re: Review Request 56971: Changes/Overwrites to Bundles and Coordinators Show as Workflow, Not able to select text from worflow 'Definition' tab

2017-02-22 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56971/#review166489 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 23, 2017, 6

Re: Review Request 56972: Improper action node name after importing the asset

2017-02-22 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56972/#review166488 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 23, 2017, 6

Review Request 56965: Hive 2: "insert udf" opens empty drop down

2017-02-22 Thread Pallav Kulshreshtha
0/src/main/resources/ui/app/routes/queries/query.js 64f38ab contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 4fd3ce201 Diff: https://reviews.apache.org/r/56965/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56925: Hive2: Visual Explain - Eliminate "limit -1"

2017-02-22 Thread Pallav Kulshreshtha
/hive-explainer/renderer-force.js 2dfdc86 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js a332802 Diff: https://reviews.apache.org/r/56925/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Review Request 56925: Hive2: Visual Explain - Eliminate "limit -1"

2017-02-22 Thread Pallav Kulshreshtha
2dfdc86 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js a332802 Diff: https://reviews.apache.org/r/56925/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Review Request 56922: Hive2: Query in query editor is getting modified while navigating across different tabs

2017-02-21 Thread Pallav Kulshreshtha
/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56882: Unique Name not created automatically when designing workflow

2017-02-21 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56882/#review166169 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 21, 2017

Re: Review Request 56884: Hive 2: Visual Explain - Remove children in the JSON dump

2017-02-21 Thread Pallav Kulshreshtha
Diff: https://reviews.apache.org/r/56884/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Review Request 56884: Hive2: Visual Explain -Layout glitches of overlapping edges

2017-02-21 Thread Pallav Kulshreshtha
/hive20/src/main/resources/ui/app/templates/queries/query.hbs d62c781 contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 3dedd8f Diff: https://reviews.apache.org/r/56884/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Review Request 56870: HiveView2.0: Add new UDF is not working

2017-02-21 Thread Pallav Kulshreshtha
/56870/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56756: Hive View 2.0: Visual Explain-The operators are being shown out of order

2017-02-20 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56756/#review166080 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 20, 2017

Review Request 56839: Hive View 2: Results of one query reflected in other

2017-02-20 Thread Pallav Kulshreshtha
/main/resources/ui/config/environment.js 411ee99 Diff: https://reviews.apache.org/r/56839/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56604: Zeppelin UI to support proxy access via Knox in Ambari

2017-02-19 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56604/#review166055 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 13, 2017, 5

Re: Review Request 56606: Allow user to view Tez View after executing query

2017-02-16 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56606/#review165860 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 16, 2017, 2

Re: Review Request 56756: Hive View 2.0: Visual Explain-The operators are being shown out of order

2017-02-16 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56756/#review165849 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 16, 2017, 2

Re: Review Request 56704: Issue while resetting the coordinator

2017-02-15 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56704/#review165810 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 15, 2017

Review Request 56669: Ambari Views do not appear in full screen view

2017-02-14 Thread Pallav Kulshreshtha
/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56643: Hive View 2.0 upload table issues : char support, endline support and temp file deletion

2017-02-14 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56643/#review165518 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 14, 2017, 5

Re: Review Request 56647: AMBARI-20000.Workflow Manager optimising finding nodes

2017-02-14 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56647/#review165479 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 14, 2017, 9

Re: Review Request 56488: Hive2: Invalid query execution not handled properly

2017-02-13 Thread Pallav Kulshreshtha
/src/main/resources/ui/app/templates/queries/query.hbs 5b2b5c2 Diff: https://reviews.apache.org/r/56488/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56488: Hive2: xxx; never returns

2017-02-13 Thread Pallav Kulshreshtha
://reviews.apache.org/r/56488/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56488: Hive2: xxx; never returns

2017-02-13 Thread Pallav Kulshreshtha
--- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56606: Allow user to view Tez View after executing query

2017-02-13 Thread Pallav Kulshreshtha
blank lines. contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 536) <https://reviews.apache.org/r/56606/#comment237202> space - Pallav Kulshreshtha On Feb. 13, 2017, 6:52 p.m., venkat sairam wrote: > >

Re: Review Request 56572: Hive2. Visual Explain -Show additional info when you click on a box, i.e. can drill down to get more info on operators.

2017-02-11 Thread Pallav Kulshreshtha
---- On Feb. 11, 2017, 10:26 a.m., Pallav Kulshreshtha wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56572/ >

Re: Review Request 56483: HiveView2.0: DB panel shows up on Query result full screen

2017-02-11 Thread Pallav Kulshreshtha
in jobs, removed extra function in query service. - Pallav --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56483/#review164891 --------

Re: Review Request 56483: HiveView2.0: DB panel shows up on Query result full screen

2017-02-11 Thread Pallav Kulshreshtha
--- manuualy tested Thanks, Pallav Kulshreshtha

Review Request 56572: Hive2. Visual Explain -Show additional info when you click on a box, i.e. can drill down to get more info on operators.

2017-02-11 Thread Pallav Kulshreshtha
/components/visual-explain-detail.hbs PRE-CREATION contrib/views/hive20/src/main/resources/ui/app/templates/components/visual-explain.hbs 4238d43 Diff: https://reviews.apache.org/r/56572/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Review Request 56542: Hive View 2.0 - deleting a saved query is buggy

2017-02-10 Thread Pallav Kulshreshtha
://reviews.apache.org/r/56542/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56538: Hive view 2.0 upload table does not provide first row is header check box.

2017-02-10 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56538/#review165090 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 10, 2017, 9

Re: Review Request 56379: AMBARI-19418: Support setup queue priority in Ambari - Capacity scheduler view

2017-02-10 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56379/#review165085 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 10, 2017, 7

Review Request 56488: Hive2: xxx; never returns

2017-02-09 Thread Pallav Kulshreshtha
/resources/ui/app/templates/queries/query.hbs 8ee8e87 Diff: https://reviews.apache.org/r/56488/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56483: HiveView2.0: DB panel shows up on Query result full screen

2017-02-09 Thread Pallav Kulshreshtha
--- manuualy tested Thanks, Pallav Kulshreshtha

Review Request 56483: HiveView2.0: DB panel shows up on Query result full screen

2017-02-08 Thread Pallav Kulshreshtha
/services/query.js b484c74 contrib/views/hive20/src/main/resources/ui/app/styles/app.scss 4f73ef8 contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 8ee8e87 Diff: https://reviews.apache.org/r/56483/diff/ Testing --- manuualy tested Thanks, Pallav

Re: Review Request 56430: incorrect imports in hive-next view

2017-02-08 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56430/#review164849 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 8, 2017, 6

Re: Review Request 56443: HiveView2.0: Long table name spills out of table panel

2017-02-08 Thread Pallav Kulshreshtha
://reviews.apache.org/r/56443/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56443: HiveView2.0: Long table name spills out of table panel

2017-02-08 Thread Pallav Kulshreshtha
://reviews.apache.org/r/56443/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56443: HiveView2.0: Long table name spills out of table panel

2017-02-08 Thread Pallav Kulshreshtha
/views/hive20/src/main/resources/ui/app/templates/savedqueries.hbs 0ab6cfd Diff: https://reviews.apache.org/r/56443/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Review Request 56443: HiveView2.0: Long table name spills out of table panel

2017-02-08 Thread Pallav Kulshreshtha
/savedqueries.hbs 0ab6cfd Diff: https://reviews.apache.org/r/56443/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56383: AMBARI-19889:Workflow Manager Should be able to handle fork with single path.

2017-02-08 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56383/#review164663 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 7, 2017, 11

Re: Review Request 56345: Hive2 view UDF tab is blank always

2017-02-07 Thread Pallav Kulshreshtha
b776fd2 contrib/views/hive20/src/main/resources/ui/app/templates/udfs/new.hbs PRE-CREATION Diff: https://reviews.apache.org/r/56345/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Review Request 56384: Hive2: Query Runtime Prediction: Compact Visual Explain Plan

2017-02-07 Thread Pallav Kulshreshtha
://reviews.apache.org/r/56384/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56345: Hive2 view UDF tab is blank always

2017-02-06 Thread Pallav Kulshreshtha
b776fd2 contrib/views/hive20/src/main/resources/ui/app/templates/udfs/new.hbs PRE-CREATION Diff: https://reviews.apache.org/r/56345/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Review Request 56345: Hive2 view UDF tab is blank always

2017-02-06 Thread Pallav Kulshreshtha
/resources/ui/app/templates/udfs/new.hbs PRE-CREATION Diff: https://reviews.apache.org/r/56345/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56168: AMBARI-19819. Styling changes and spelling fixes

2017-02-01 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56168/#review163939 --- Ship it! Ship It! - Pallav Kulshreshtha On Feb. 1, 2017, 1

Re: Review Request 56084: Hive2: Results are not cleared on "execute"

2017-01-31 Thread Pallav Kulshreshtha
-table.hbs 180c43d contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 22838a4 Diff: https://reviews.apache.org/r/56084/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56084: Hive2: Results are not cleared on "execute"

2017-01-31 Thread Pallav Kulshreshtha
-table.hbs 4fe6f43 contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5cdc9b3 Diff: https://reviews.apache.org/r/56084/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56115: Hive2: Unreasonable response time from query exeuction in hive view

2017-01-31 Thread Pallav Kulshreshtha
/main/resources/ui/app/routes/queries/query.js 753b7f7 contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5cdc9b3 Diff: https://reviews.apache.org/r/56115/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Review Request 56115: Hive2: Unreasonable response time from query exeuction in hive view

2017-01-31 Thread Pallav Kulshreshtha
/query.js 753b7f7 contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5cdc9b3 Diff: https://reviews.apache.org/r/56115/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56078: Hive View 2.0: Table manager - DDL tab should show query as readonly in query editor

2017-01-30 Thread Pallav Kulshreshtha
/ui/app/templates/databases/database/tables/table/ddl.hbs cbbcdd0 Diff: https://reviews.apache.org/r/56078/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56078: Hive View 2.0: Table manager - DDL tab should show query as readonly in query editor

2017-01-30 Thread Pallav Kulshreshtha
/ui/app/templates/components/query-result-table.hbs 4fe6f43 contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5cdc9b3 Diff: https://reviews.apache.org/r/56078/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Review Request 56084: Hive2: Results are not cleared on "execute"

2017-01-30 Thread Pallav Kulshreshtha
/templates/components/query-result-table.hbs 4fe6f43 contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5cdc9b3 Diff: https://reviews.apache.org/r/56084/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Review Request 56078: Hive View 2.0: Table manager - DDL tab should show query as readonly in query editor

2017-01-30 Thread Pallav Kulshreshtha
/table/ddl.hbs cbbcdd0 Diff: https://reviews.apache.org/r/56078/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56075: Hive2: LOGS tab is more prominently displayed than RESULTS

2017-01-30 Thread Pallav Kulshreshtha
-result-table.hbs 4fe6f43 contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 5cdc9b3 Diff: https://reviews.apache.org/r/56075/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Review Request 56075: Hive2: LOGS tab is more prominently displayed than RESULTS

2017-01-30 Thread Pallav Kulshreshtha
/src/main/resources/ui/app/templates/queries/query.hbs 5cdc9b3 Diff: https://reviews.apache.org/r/56075/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56031: Hive2 View - Switching tabs after executing query loses state

2017-01-30 Thread Pallav Kulshreshtha
, Pallav Kulshreshtha

Review Request 56031: Hive2 View - Switching tabs after executing query loses state

2017-01-27 Thread Pallav Kulshreshtha
/hive20/src/main/resources/ui/app/routes/queries/query.js 2ecf967 Diff: https://reviews.apache.org/r/56031/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Review Request 56030: Hive View 2.0 execute button needs some feedback

2017-01-27 Thread Pallav Kulshreshtha
/hive20/src/main/resources/ui/app/styles/app.scss e178222 contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 9e9e542 Diff: https://reviews.apache.org/r/56030/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 56014: User preference like opened tabs/work in progress should not be available to a different user

2017-01-27 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56014/#review163262 --- Ship it! Ship It! - Pallav Kulshreshtha On Jan. 27, 2017, 1

Re: Review Request 55837: Hive View 2.0: Incorrect behaviour on select of database

2017-01-24 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55837/#review162906 --- Ship it! Ship It! - Pallav Kulshreshtha On Jan. 23, 2017

Re: Review Request 55836: Hive View 2.0: Editor should be stretchable by dragging

2017-01-24 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55836/#review162904 --- Ship it! Ship It! - Pallav Kulshreshtha On Jan. 23, 2017

Re: Review Request 55834: AMBARI-19669:Not able to add the settings for action nodes in firefox browser

2017-01-23 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55834/#review162625 --- Ship it! Ship It! - Pallav Kulshreshtha On Jan. 23, 2017, 9

Re: Review Request 55718: AMBARI-19624:Missing fields for workflow SLA

2017-01-23 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55718/#review162623 --- Ship it! Ship It! - Pallav Kulshreshtha On Jan. 20, 2017, 5

Re: Review Request 55757: AMBARI-19647. Issue while submitting workflow as its not able to register as a project

2017-01-22 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55757/#review162600 --- Ship it! Ship It! - Pallav Kulshreshtha On Jan. 20, 2017

Re: Review Request 55615: Hive View 2.0: Show query logs

2017-01-19 Thread Pallav Kulshreshtha
/ui/app/templates/queries/query.hbs 2138356 Diff: https://reviews.apache.org/r/55615/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 55615: Hive View 2.0: Show query logs

2017-01-19 Thread Pallav Kulshreshtha
/ui/app/templates/queries/query.hbs 2138356 Diff: https://reviews.apache.org/r/55615/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Review Request 55615: Hive View 2.0: Show query logs

2017-01-17 Thread Pallav Kulshreshtha
Diff: https://reviews.apache.org/r/55615/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Review Request 55573: Hive View 2.0: Export Query Result

2017-01-16 Thread Pallav Kulshreshtha
4bda978 contrib/views/hive20/src/main/resources/ui/app/templates/components/save-hdfs.hbs 5b53102 contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 120a045 Diff: https://reviews.apache.org/r/55573/diff/ Testing --- manually tested. Thanks, Pallav

Re: Review Request 55501: Hive View 2.0: Saving worksheet as saved query

2017-01-13 Thread Pallav Kulshreshtha
: https://reviews.apache.org/r/55501/diff/ Testing --- manually tested Thanks, Pallav Kulshreshtha

Re: Review Request 55501: Hive View 2.0: Saving worksheet as saved query

2017-01-13 Thread Pallav Kulshreshtha
: https://reviews.apache.org/r/55501/diff/ Testing --- manually tested Thanks, Pallav Kulshreshtha

Review Request 55501: Hive View 2.0: Saving worksheet as saved query

2017-01-13 Thread Pallav Kulshreshtha
/savedqueries.hbs b776fd2 Diff: https://reviews.apache.org/r/55501/diff/ Testing --- manually tested Thanks, Pallav Kulshreshtha

Re: Review Request 55378: AMBARI-19439:Warning message when user tries to close a designer tab.

2017-01-10 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55378/#review161072 --- Ship it! Ship It! - Pallav Kulshreshtha On Jan. 10, 2017

Re: Review Request 55371: AMBARI-19436: Need ability to upload a file in HDFS browser.

2017-01-10 Thread Pallav Kulshreshtha
/hdfs-directory-viewer/addon/components/directory-viewer.js (line 120) <https://reviews.apache.org/r/55371/#comment232313> length is calculated multiple times. It can be done in a variable and then make use of that variable. - Pallav Kulshreshtha On Jan. 10, 2017, 7:18 a.m., Padma P

Re: Review Request 55371: AMBARI-19436: Need ability to upload a file in HDFS browser.

2017-01-10 Thread Pallav Kulshreshtha
wer.js (line 102) <https://reviews.apache.org/r/55371/#comment232312> if/else condition can be changed to one liner code. - Pallav Kulshreshtha On Jan. 10, 2017, 7:18 a.m., Padma Priya N wrote: > > --- > This is an automatic

Re: Review Request 55338: Save workflows via save mechanism instead of submission button

2017-01-09 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55338/#review161039 --- Ship it! Ship It! - Pallav Kulshreshtha On Jan. 9, 2017, 11

Re: Review Request 55336: AMBARI-19420: Import from local file system doesn't work if the same file is selected again.

2017-01-09 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55336/#review161037 --- Ship it! Ship It! - Pallav Kulshreshtha On Jan. 9, 2017, 9

Review Request 55340: Hive View 2.0: Introduction of worksheets for query editor

2017-01-09 Thread Pallav Kulshreshtha
/query.hbs 69fc657 Diff: https://reviews.apache.org/r/55340/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

Re: Review Request 55167: AMBARI-19354 : Invalid message is shown after saving the workflow

2017-01-06 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55167/#review160700 --- Ship it! Ship It! - Pallav Kulshreshtha On Jan. 4, 2017, 9

Re: Review Request 55206: AMBARI-19385: Resolve variables in workflow if workflow path in coordinator contains variables.

2017-01-05 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55206/#review160680 --- Ship it! Ship It! - Pallav Kulshreshtha On Jan. 5, 2017, 12

Re: Review Request 55203: AMBARI-19380. Workflow Draft Save-Not working

2017-01-05 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55203/#review160577 --- Ship it! Ship It! - Pallav Kulshreshtha On Jan. 5, 2017, 10

Re: Review Request 55170: UI elements misalignment in dashboard screen of WFD

2017-01-05 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55170/#review160572 --- Ship it! Ship It! - Pallav Kulshreshtha On Jan. 4, 2017, 12

Re: Review Request 55133: AMBARI-19306: User is not able to validate/submit the workflow after browsing workflow path

2017-01-04 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55133/#review160564 --- Ship it! Ship It! - Pallav Kulshreshtha On Jan. 4, 2017, 7

Re: Review Request 55164: AMBARI-19352 : Designer should always pick latest version for an action node

2017-01-04 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55164/#review160562 --- Ship it! Ship It! - Pallav Kulshreshtha On Jan. 4, 2017, 8

Review Request 55137: Hive View 2.0.0: Add ability to expand the query editor and the result pane to take 100% height and width

2017-01-03 Thread Pallav Kulshreshtha
://reviews.apache.org/r/55137/diff/ Testing --- manually tested. Thanks, Pallav Kulshreshtha

<    1   2   3   4   >