Re: Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error

2017-03-01 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56980/#review167261 --- Ship it! Ship It! - Sebastian Toader On March 1, 2017, 12

Re: Review Request 57155: Increase Ranger/Atlas timeout (check znode)

2017-03-01 Thread Sebastian Toader
/package/scripts/setup_ranger_xml.py Lines 761 (patched) <https://reviews.apache.org/r/57155/#comment239398> Why wee need this if there is already a ```@retry``` annotation of the ```check_znode``` method? - Sebastian Toader On Feb. 28, 2017, 7:47 p.m., Oliver Szabo

Re: Review Request 57145: Services fail to start due to incorrect permissions on spnego.service.keytab

2017-02-28 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57145/#review167071 --- Ship it! Ship It! - Sebastian Toader On Feb. 28, 2017, 2:27

Re: Review Request 57080: Ambari should install the unlimited key JCE policy based on service requirements even if cluster is not Kerberized

2017-02-27 Thread Sebastian Toader
he whole syprep from config in a central way as well. The flags under cluster-env can be modified only either changing the Blueprint or changing the existing cluster-env config. The flags under cluster-env are rather for fine tuning the 'sysprep' once enabled. - Sebastian Toader

Re: Review Request 56987: TopologyRequest/TopologyLogicalRequest/TopologyHostRequest database inconsistency

2017-02-25 Thread Sebastian Toader
, Failures: 0, Errors: 0, Skipped: 39 Thanks, Sebastian Toader

Re: Review Request 57039: Restart Kafka broker failed after enabling kerberos with "kinit(v5): No such file or directory while getting initial credentials"

2017-02-24 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57039/#review166805 --- Ship it! Ship It! - Sebastian Toader On Feb. 24, 2017, 10

Re: Review Request 56987: TopologyRequest/TopologyLogicalRequest/TopologyHostRequest database inconsistency

2017-02-24 Thread Sebastian Toader
On Feb. 24, 2017, 5:27 p.m., Sebastian Toader wrote: > > Should any unit tests be updated? Existing unit tests passed fine with the change. Is there already a mechanism in Ambari that can be used to test if certain records are persisted within a transaction or not? - Seb

Re: Review Request 57040: Rebalance HDFS operation returns after the command is issued

2017-02-24 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57040/#review166721 --- Ship it! Ship It! - Sebastian Toader On Feb. 24, 2017, 5:18

Re: Review Request 56987: TopologyRequest/TopologyLogicalRequest/TopologyHostRequest database inconsistency

2017-02-24 Thread Sebastian Toader
/TopologyManager.java a26624e Diff: https://reviews.apache.org/r/56987/diff/ Testing --- Performed manual testing covering cluster creation using Blueprint and than cluster upscaling. Unit tests: Tests run: 4929, Failures: 0, Errors: 0, Skipped: 39 Thanks, Sebastian Toader

Re: Review Request 57039: Restart Kafka broker failed after enabling kerberos with "kinit(v5): No such file or directory while getting initial credentials"

2017-02-24 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57039/#review166710 --- Ship it! Ship It! - Sebastian Toader On Feb. 24, 2017, 3:19

Review Request 56987: TopologyRequest/TopologyLogicalRequest/TopologyHostRequest database inconsistency

2017-02-23 Thread Sebastian Toader
://reviews.apache.org/r/56987/diff/ Testing --- Performed manual testing covering cluster creation using Blueprint and than cluster upscaling. Unit tests: Tests run: 4929, Failures: 0, Errors: 0, Skipped: 39 Thanks, Sebastian Toader

Re: Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error

2017-02-23 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56980/#review166524 --- Ship it! Ship It! - Sebastian Toader On Feb. 23, 2017, 1:11

Re: Review Request 56800: Finalize Operations stage fails when Enabling Kerberos using the manual option

2017-02-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56800/#review166179 --- Ship it! Ship It! - Sebastian Toader On Feb. 17, 2017, 9:52

Re: Review Request 56783: Removing secure ACLs from Kafka znodes during dekerberization

2017-02-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56783/#review166155 --- Ship it! Ship It! - Sebastian Toader On Feb. 21, 2017, 1:03

Re: Review Request 56798: AMBARI-20070. Agent heartbeat loop stuck in subprocess.Popen

2017-02-19 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56798/#review166059 --- Ship it! Ship It! - Sebastian Toader On Feb. 17, 2017, 8:58

Re: Review Request 56783: Removing secure ACLs from Kafka znodes during dekerberization

2017-02-17 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56783/#review165939 --- Ship it! Ship It! - Sebastian Toader On Feb. 17, 2017, 4:16

Re: Review Request 56783: Removing secure ACLs from Kafka znodes during dekerberization

2017-02-17 Thread Sebastian Toader
/package/scripts/params.py (line 107) <https://reviews.apache.org/r/56783/#comment237788> If this list of znodes can not be retrieved from some kafka config than specify here the link to the document that lists the kafka znodes - Sebastian Toader On Feb. 17, 2017, 3:54 p.m., Attila

Re: Review Request 56766: Remove Entities Associated With clusterconfigmapping

2017-02-17 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56766/#review165934 --- Ship it! Ship It! - Sebastian Toader On Feb. 17, 2017, 2:09

Re: Review Request 56766: Remove Entities Associated With clusterconfigmapping

2017-02-17 Thread Sebastian Toader
ld add too much complexity and performance hit to the queries like ```ClusterConfigEntity.findEnabledConfigsByTypes``` ? - Sebastian Toader On Feb. 16, 2017, 10:12 p.m., Jonathan Hurley wrote: > > --- > This is an automatically g

Re: Review Request 56659: Add "Manage alert notifications" authorization

2017-02-15 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56659/#review165725 --- Ship it! Ship It! - Sebastian Toader On Feb. 15, 2017, 5:55

Re: Review Request 56713: Ambari server start returns prematurely before extracting views.

2017-02-15 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56713/#review165718 --- Ship it! Ship It! - Sebastian Toader On Feb. 15, 2017, 4:24

Re: Review Request 56685: Document security issue related to setting security.agent.hostname.validate to false

2017-02-15 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56685/#review165714 --- Ship it! Ship It! - Sebastian Toader On Feb. 15, 2017, 4:02

Re: Review Request 56685: Document security issue related to setting security.agent.hostname.validate to false

2017-02-14 Thread Sebastian Toader
/configuration/Configuration.java (line 513) <https://reviews.apache.org/r/56685/#comment237523> I searched for ```CVE-2014-3582``` on the web but couldn't find a detailed description of this vulnerability. Should a direct link be listed here that points to the detailed description. - Sebas

Re: Review Request 56659: Add "Manage alert notifications" authorization

2017-02-14 Thread Sebastian Toader
upgraded from 2.4 to 2.5 works as expected after the upgrade. - Sebastian Toader On Feb. 14, 2017, 6:07 p.m., Eugene Chekanskiy wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 56600: Default group permissions for the user home directories created by the post user creation script should be 'hdfs' instead of 'hadoop'

2017-02-13 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56600/#review165324 --- Ship it! Ship It! - Sebastian Toader On Feb. 13, 2017, 2:24

Re: Review Request 56545: AMBARI-19959. Allow skipping view extraction in ambari-server setup

2017-02-11 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56545/#review165235 --- Ship it! Ship It! - Sebastian Toader On Feb. 10, 2017, 3:21

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

2017-02-10 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56540/#review165119 --- Ship it! Ship It! - Sebastian Toader On Feb. 10, 2017, 1:21

Re: Review Request 56540: Implement new DB checks for Postgres to prevent cross-schema confusion

2017-02-10 Thread Sebastian Toader
/DatabaseConsistencyCheckHelper.java (line 657) <https://reviews.apache.org/r/56540/#comment236927> It would be useful to log the schema name that is first on the search path as well. - Sebastian Toader On Feb. 10, 2017, 1:21 p.m., Balázs Bence Sári

Re: Review Request 56491: Fix default value for storm.messaging.netty.max_retries parameters in Ambari

2017-02-10 Thread Sebastian Toader
> On Feb. 9, 2017, 6 p.m., Sebastian Toader wrote: > > Did the manual testing covered both Ambari upgrade and HDP upgrade > > scenarios to ensure that it works as expected? Also please include Jaimin > > Jetly to the list of reviewers in order to review the UI part.

Re: Review Request 56407: Upgrade: Package Install stuck in "Installing" state forever

2017-02-08 Thread Sebastian Toader
9 Thanks, Sebastian Toader

Review Request 56407: Upgrade: Package Install stuck in "Installing" state forever

2017-02-07 Thread Sebastian Toader
tested the upgrading of HDP 2.4 to HDP 2.5 with "install_packages" command failing on at least one agent. Unit testing: mvn test -DskipPythonTests -am -pl ambari-server Results : Tests run: 4906, Failures: 0, Errors: 0, Skipped: 39 Thanks, Sebastian Toader

Re: Review Request 56390: AMBARI-19895. Firewall check during ambari-server setup fails on CentOS7

2017-02-07 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56390/#review164569 --- Ship it! Ship It! - Sebastian Toader On Feb. 7, 2017, 5:24

Re: Review Request 56331: Updating yarn-env and hadoop-env templates with ZK secure options on stack upgrade

2017-02-07 Thread Sebastian Toader
t; HDFS ZKFC all capital. ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml (line 329) <https://reviews.apache.org/r/56331/#comment236240> HDFS ZKFC all capital. - Sebastian Toader On Feb. 7, 2017, 10:02 a.m., A

Re: Review Request 56331: Updating yarn-env and hadoop-env templates with ZK secure options on stack upgrade

2017-02-06 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56331/#review164357 --- Ship it! Ship It! - Sebastian Toader On Feb. 6, 2017, 5:26

Re: Review Request 56179: Add infra-solr-plugin for authorization (with Kerberos)

2017-02-06 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56179/#review164352 --- Ship it! Ship It! - Sebastian Toader On Feb. 6, 2017, 3:59

Re: Review Request 56179: Add infra-solr-plugin for authorization (with Kerberos)

2017-02-05 Thread Sebastian Toader
For example the principals can be overriden through custom kerberos descriptors thus this hard coded user list would not apply anymore. - Sebastian Toader On Feb. 4, 2017, 6:31 p.m., Oliver Szabo wrote: > > --- > This is an aut

Re: Review Request 56282: AMBARI-19867. Grafana install fails if custom directory's parent does not exist

2017-02-03 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56282/#review164129 --- Ship it! Ship It! - Sebastian Toader On Feb. 3, 2017, 6:13

Re: Review Request 56225: AMBARI-19846. ambari-agent.out filled with KeyError

2017-02-03 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56225/#review164110 --- Ship it! Ship It! - Sebastian Toader On Feb. 3, 2017, 11:39

Re: Review Request 56179: Add infra-solr-plugin for authorization (with Kerberos)

2017-02-02 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56179/#review163992 --- Ship it! Ship It! - Sebastian Toader On Feb. 2, 2017, 5:23

Re: Review Request 56225: AMBARI-19846. ambari-agent.out filled with KeyError

2017-02-02 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56225/#review163969 --- Ship it! Ship It! - Sebastian Toader On Feb. 2, 2017, 2:36

Re: Review Request 56179: Add infra-solr-plugin for authorization (with Kerberos)

2017-02-02 Thread Sebastian Toader
ssion is given. Authorisation enforced based only on the service name and not the fully qualified principal could lead to security breach. - Sebastian Toader On Feb. 1, 2017, 9:46 p.m., Oliver Szabo wrote: > > --- > This is an

Re: Review Request 56175: Setup correct authentication and authorization mechanism between Yarn Registry and Zookeeper

2017-02-01 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56175/#review163823 --- Ship it! Ship It! - Sebastian Toader On Feb. 1, 2017, 5:09

Re: Review Request 56173: AMBARI-19816. Agent heartbeat lost due to dead service check process

2017-02-01 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56173/#review163815 --- Ship it! Ship It! - Sebastian Toader On Feb. 1, 2017, 4:11

Re: Review Request 56133: AMBARI-19802. Debug: agent randomly losing heartbeat with the server

2017-02-01 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56133/#review163795 --- Ship it! - Sebastian Toader On Jan. 31, 2017, 7:49 p.m

Re: Review Request 56133: AMBARI-19802. Debug: agent randomly losing heartbeat with the server

2017-01-31 Thread Sebastian Toader
How often will this log at INFO level? ambari-agent/src/main/python/ambari_agent/Controller.py (line 477) <https://reviews.apache.org/r/56133/#comment235301> How often will this log on INFO level? - Sebastian Toader On Jan. 31, 2017, 7:49 p.m., Attila Doroszlai wrote: >

Re: Review Request 56022: Content of yarn-env.sh on host is not same as in the downloaded config file from Ambari UI

2017-01-31 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56022/#review163656 --- Ship it! Ship It! - Sebastian Toader On Jan. 31, 2017, 2:43

Re: Review Request 56076: AMBARI-19775. ActionQueue thread may exit due to IOError in statusCommandResultQueue.empty()

2017-01-30 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56076/#review163511 --- Ship it! Ship It! - Sebastian Toader On Jan. 30, 2017, 2:04

Review Request 56064: Format ZKFC commands failing while enabling NameNode HA

2017-01-29 Thread Sebastian Toader
] [INFO] Ambari Server . SUCCESS [2:25.628s] [INFO] [INFO] BUILD SUCCESS ``` Thanks, Sebastian Toader

Re: Review Request 56054: Inconsistent auth-to-local rules processing during Kerberos authentication

2017-01-28 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56054/#review163406 --- Ship it! Ship It! - Sebastian Toader On Jan. 28, 2017, 6:16

Re: Review Request 56022: Content of yarn-env.sh on host is not same as in the downloaded config file from Ambari UI

2017-01-27 Thread Sebastian Toader
-- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56022/ > --- > > (Updated Jan. 27, 2017, 7:24 p.m.) > > > Review request for Ambari, La

Re: Review Request 56022: Content of yarn-env.sh on host is not same as in the downloaded config file from Ambari UI

2017-01-27 Thread Sebastian Toader
Jan. 27, 2017, 7:24 p.m.) > > > Review request for Ambari, Laszlo Puskas, Robert Levas, and Sebastian Toader. > > > Bugs: AMBARI-19683 > https://issues.apache.org/jira/browse/AMBARI-19683 > > > Repository: ambari > > > Description > --- >

Re: Review Request 55987: Post user creation hook script creates user home dirs as the configured hdfs_user

2017-01-27 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55987/#review163282 --- Ship it! Ship It! - Sebastian Toader On Jan. 27, 2017, 5:12

Re: Review Request 56021: AMBARI-19743. Agent registration fails with non-root agent user

2017-01-27 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56021/#review163267 --- Ship it! Ship It! - Sebastian Toader On Jan. 27, 2017, 3:38

Re: Review Request 55987: Post user creation hook script creates user home dirs as the configured hdfs_user

2017-01-26 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55987/#review163142 --- Ship it! Ship It! - Sebastian Toader On Jan. 26, 2017, 6:03

Re: Review Request 55985: Atlas deployment via Ambari should configure Zookeeper ACLs and Auth scheme

2017-01-26 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55985/#review163136 --- Ship it! Ship It! - Sebastian Toader On Jan. 26, 2017, 5:38

Re: Review Request 55985: Atlas deployment via Ambari should configure Zookeeper ACLs and Auth scheme

2017-01-26 Thread Sebastian Toader
/package/scripts/params.py (line 84) <https://reviews.apache.org/r/55985/#comment234578> Is it application-properties or atlas-application.properties - Sebastian Toader On Jan. 26, 2017, 5:38 p.m., Attila Magyar wrote: > > --

Re: Review Request 55983: AMBARI-19712. Cluster creation fails due to database exception

2017-01-26 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55983/#review163123 --- Ship it! Ship It! - Sebastian Toader On Jan. 26, 2017, 2:31

Re: Review Request 55883: Post user creation hook - input csv generated with READ permissions

2017-01-24 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55883/#review162823 --- Ship it! Ship It! - Sebastian Toader On Jan. 24, 2017, 4:12

Re: Review Request 55882: LDAP regression in Ambari 2.4: Login alias is not resolved during authentication

2017-01-24 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55882/#review162811 --- Ship it! Ship It! - Sebastian Toader On Jan. 24, 2017, 3:16

Re: Review Request 55833: Supporting zookeeper security only from HDP 2.6

2017-01-24 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55833/#review162804 --- Ship it! Ship It! - Sebastian Toader On Jan. 24, 2017, 2

Re: Review Request 55821: Log Search: support credential store api (part 1)

2017-01-23 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55821/#review162626 --- Ship it! Ship It! - Sebastian Toader On Jan. 22, 2017, 7:57

Re: Review Request 55833: Supporting zookeeper security only from HDP 2.6

2017-01-23 Thread Sebastian Toader
/stack_features.json (line 26) <https://reviews.apache.org/r/55833/#comment233972> Maybe the description should be more explicit. eg. "Protect ZNodes with SASL acl in secure clusters" - Sebastian Toader On Jan. 23, 2017, 10:29 a.m., Att

Re: Review Request 55823: Log Search: Add basic auth support to Swagger UI

2017-01-22 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55823/#review162605 --- Ship it! Ship It! - Sebastian Toader On Jan. 23, 2017, 12

Re: Review Request 55822: Log Search: Snapshot tour fix & configurable CORS filter

2017-01-22 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55822/#review162603 --- Ship it! Ship It! - Sebastian Toader On Jan. 22, 2017, 10

Re: Review Request 55821: Log Search: support credential store api (part 1)

2017-01-22 Thread Sebastian Toader
/apache/ambari/logfeeder/util/SSLUtil.java (line 129) <https://reviews.apache.org/r/55821/#comment233970> Isn't this an error that should be signaled wuth an Exception since the password file is provided? - Sebastian Toader On Jan. 22, 2017, 7:57 p.m., Oliver

Re: Review Request 55818: Unknown attributes should not be allowed in quick link filter definitions

2017-01-21 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55818/#review162566 --- Ship it! Ship It! - Sebastian Toader On Jan. 21, 2017, 6:04

Re: Review Request 55777: Update quicklink.json files in stack definitions with authenticated/sso features

2017-01-20 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55777/#review162467 --- Ship it! Ship It! - Sebastian Toader On Jan. 20, 2017, 7:30

Re: Review Request 55764: Ldap sync fails when there are special characters in distinguished names

2017-01-20 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55764/#review162432 --- Ship it! Ship It! - Sebastian Toader On Jan. 20, 2017, 2:42

Re: Review Request 55762: Ambari db-cleanup tool fixed

2017-01-20 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55762/#review162418 --- Ship it! Ship It! - Sebastian Toader On Jan. 20, 2017, 2:17

Re: Review Request 55680: On secure NN HA clusters ZKFC connects to zookeeper securely

2017-01-20 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55680/#review162417 --- Ship it! Ship It! - Sebastian Toader On Jan. 20, 2017, 12

Re: Review Request 55643: Blueprint installation should accept quick link profile

2017-01-19 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55643/#review162341 --- Ship it! Ship It! - Sebastian Toader On Jan. 19, 2017, 8:49

Re: Review Request 55724: AMBARI-19629. Move schemaTool invocation out of configure() to hive_metastore start()

2017-01-19 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55724/#review162326 --- Ship it! Ship It! - Sebastian Toader On Jan. 19, 2017, 6:59

Re: Review Request 55680: On secure NN HA clusters ZKFC connects to zookeeper securely

2017-01-19 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55680/#review162278 --- Ship it! Ship It! - Sebastian Toader On Jan. 19, 2017, 1:39

Re: Review Request 55643: Blueprint installation should accept quick link profile

2017-01-19 Thread Sebastian Toader
/ambari/server/utils/TimeSource.java (lines 1 - 30) <https://reviews.apache.org/r/55643/#comment233595> This abstraction doesn't seem to be necessary. You should be able to mock System.currentTimeMillis() in tests. - Sebastian Toader On Jan. 17, 2017, 10:30 p.m., Balázs Bence

Re: Review Request 55680: On secure NN HA clusters ZKFC connects to zookeeper securely

2017-01-18 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55680/#review162153 --- Ship it! Ship It! - Sebastian Toader On Jan. 18, 2017, 6:18

Re: Review Request 55680: On secure NN HA clusters ZKFC connects to zookeeper securely

2017-01-18 Thread Sebastian Toader
-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py (line 392) <https://reviews.apache.org/r/55680/#comment233389> Not the ```cluster``` but the ```NameNode``` - Sebastian Toader On Jan. 18, 2017, 4:58 p.m., Laszlo Puskas

Re: Review Request 55617: AMBARI-19585. Client config tags may not be saved by agent

2017-01-17 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55617/#review161872 --- Ship it! Ship It! - Sebastian Toader On Jan. 17, 2017, 2:28

Re: Review Request 55574: Setup the correct authentication and authorization between ZooKeeper and oozie

2017-01-16 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55574/#review161779 --- Ship it! Ship It! - Sebastian Toader On Jan. 16, 2017, 8:07

Re: Review Request 55513: Use common property for principal name prefix to help with customization of unique principal names

2017-01-16 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55513/#review161749 --- Ship it! Ship It! - Sebastian Toader On Jan. 13, 2017, 7:14

Re: Review Request 55575: Ambari trunk build failing due to checkstyle

2017-01-16 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55575/#review161732 --- Ship it! Ship It! - Sebastian Toader On Jan. 16, 2017, 3:14

Review Request 55569: Log Namenode formatting output into ambari-agent command logs

2017-01-16 Thread Sebastian Toader
d and blueprint (NN non-HA and HA). Unit tests: mvn test -Drat.skip=true -Dcheckstyle.skip -DskipSurefireTests OK -- Total run:1159 Total errors:0 Total failures:0 OK Thanks, Sebastian Toader

Re: Review Request 55513: Use common property for principal name prefix to help with customization of unique principal names

2017-01-16 Thread Sebastian Toader
users to change the ```principal_suffix``` later? - Sebastian Toader On Jan. 13, 2017, 7:14 p.m., Robert Levas wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Review Request 55494: Ambari agents not recovering from heart beat lost state immediately after successful re-registering with server

2017-01-13 Thread Sebastian Toader
. SUCCESS [1:45.492s] [INFO] Ambari Agent .. SUCCESS [25.860s] [INFO] [INFO] BUILD SUCCESS Thanks, Sebastian Toader

Re: Review Request 55016: AMBARI-19293. Component install and after-install should not run in parallel

2017-01-11 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55016/#review161356 --- Ship it! Ship It! - Sebastian Toader On Jan. 11, 2017, 11

Re: Review Request 55425: Setup the correct authentication and authorization between Hive/Hcatalog and ZooKeeper

2017-01-11 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55425/#review161246 --- Ship it! Ship It! - Sebastian Toader On Jan. 11, 2017, 3:24

Re: Review Request 55414: AMBARI-19458. Compile error in RoleGraphTest

2017-01-11 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55414/#review161207 --- Ship it! Ship It! - Sebastian Toader On Jan. 11, 2017, 11

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-10 Thread Sebastian Toader
/controller/AmbariManagementControllerImpl.java (line 242) <https://reviews.apache.org/r/55342/#comment232308> Document what "QuickLinksProfile" identify - Sebastian Toader On Jan. 9, 2017, 4:07 p.m., Balázs

Re: Review Request 55016: AMBARI-19293. Component install and after-install should not run in parallel

2017-01-09 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55016/#review160887 --- Ship it! Ship It! - Sebastian Toader On Jan. 9, 2017, 11:51

Re: Review Request 55250: AMBARI-19384. Wrong placeholder in REST metrics error message

2017-01-09 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55250/#review160883 --- Ship it! Ship It! - Sebastian Toader On Jan. 9, 2017, 11:53

Re: Review Request 55325: Ambari agents remain in heartbeat lost state after ambari server restart

2017-01-09 Thread Sebastian Toader
checking that all agents reconnect fine and continues executing status commands 2. Restarting agents Unit tests: --- Ran 452 tests in 107.184s Thanks, Sebastian Toader

Re: Review Request 55282: AMBARI-19405. Allow running a subset of Python unit tests in ambari-agent.

2017-01-08 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55282/#review160833 --- Ship it! Ship It! - Sebastian Toader On Jan. 6, 2017, 10:59

Review Request 55325: Ambari agents remain in heartbeat lost state after ambari server restart

2017-01-08 Thread Sebastian Toader
and checking that all agents reconnect fine and continues executing status commands 2. Restarting agents Unit tests: --- Ran 452 tests in 107.184s Thanks, Sebastian Toader

Re: Review Request 55308: AMBARI-19414. Cannot install Accumulo via blueprint with default settings

2017-01-08 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55308/#review160832 --- Ship it! Ship It! - Sebastian Toader On Jan. 7, 2017, 10:34

Re: Review Request 55277: AMBARI-19392. Status command executor may use obsolete settings

2017-01-06 Thread Sebastian Toader
(verify that `agent.auto.cache.update=false` setting from server is applied in status command executor child process). ambari-agent unit tests: -- Ran 452 tests in 101.627s OK Thanks, Sebastian Toader

Review Request 55277: AMBARI-19392. Status command executor may use obsolete settings

2017-01-06 Thread Sebastian Toader
: -- Ran 452 tests in 101.627s OK Thanks, Sebastian Toader

Re: Review Request 55178: Investigate Changing the Default Container Policy in JPA From Vector to ArrayList

2017-01-04 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55178/#review160525 --- Ship it! Ship It! - Sebastian Toader On Jan. 4, 2017, 5:56

Re: Review Request 55171: Setup correct authentication and authorization mechanism between Yarn and Zookeeper

2017-01-04 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55171/#review160495 --- Ship it! Ship It! - Sebastian Toader On Jan. 4, 2017, 4:10

Re: Review Request 55171: Setup correct authentication and authorization mechanism between Yarn and Zookeeper

2017-01-04 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55171/#review160486 --- Ship it! Ship It! - Sebastian Toader On Jan. 4, 2017, 1:42

Re: Review Request 55016: AMBARI-19293. Component install and after-install should not run in parallel

2016-12-28 Thread Sebastian Toader
tically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55016/ > --- > > (Updated Dec. 23, 2016, 7:05 p.m.) > > > Review request for Ambari, Andrew Onischuk, Balázs Bence Sári, Jonathan > Hurley, Laszlo Puskas, an

Re: Review Request 54891: Create quick links profile evaluator

2016-12-23 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54891/#review160100 --- Ship it! Ship It! - Sebastian Toader On Dec. 23, 2016, 8:54

<    1   2   3   4   5   6   >