Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

2016-06-27 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/#review139568 --- Ship it! Ship It! - Robert Levas On June 27, 2016, 9:36

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

2016-06-27 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/ --- (Updated June 27, 2016, 1:36 p.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

2016-06-27 Thread Oliver Szabo
> On June 27, 2016, 12:42 p.m., Robert Levas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariLdapBindAuthenticator.java, > > line 109 > > > > > > Why are we checking for

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

2016-06-27 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/#review139560 --- Fix it, then Ship it! Ship It!

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

2016-06-27 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/#review139557 --- Ship it! Ship It! - Sandor Magyari On June 27, 2016, 11:59

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

2016-06-27 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/ --- (Updated June 27, 2016, 11:59 a.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

2016-06-27 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/ --- (Updated June 27, 2016, 9:47 a.m.) Review request for Ambari, Daniel Gergely,

Re: Review Request 49253: LDAP sync: force to use uid and cn in patterns to check a member is a dn or not

2016-06-27 Thread Daniel Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49253/#review139544 --- Ship it!