Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-11 Thread Balázs Bence Sári
> On Jan. 11, 2017, 4:28 p.m., Attila Doroszlai wrote: > > ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java, > > line 113 > > > > > > Somehow this comment doesn't seem

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-11 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55342/ --- (Updated Jan. 11, 2017, 5:27 p.m.) Review request for Ambari, Attila

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-11 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55342/#review161258 ---

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-11 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55342/#review161236 --- Ship it! Ship It! - Laszlo Puskas On Jan. 9, 2017, 3:07

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-11 Thread Balázs Bence Sári
> On Jan. 11, 2017, 12:13 p.m., Laszlo Puskas wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java, > > line 5529 > > > > > > The factory could be

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-11 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55342/#review161216 ---

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-10 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55342/#review161070 --- Ship it! Ship It! - Sandor Magyari On Jan. 9, 2017, 3:07

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-10 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55342/#review161045 --- Ship it!

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-09 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55342/ --- (Updated Jan. 9, 2017, 3:07 p.m.) Review request for Ambari, Attila Doroszlai,

Re: Review Request 55342: Modify quick link resource provider to consider filters and return visibility.

2017-01-09 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55342/ --- (Updated Jan. 9, 2017, 3 p.m.) Review request for Ambari, Attila Doroszlai,