Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-06-06 Thread yao lei
> On 六月 1, 2017, 1:03 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > > Lines 2708 (patched) > > > > > > Maybe make this a little clearer: >

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-06-06 Thread Jonathan Hurley
> On June 1, 2017, 9:03 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > > Lines 2708 (patched) > > > > > > Maybe make this a little clearer:

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-06-05 Thread yao lei
> On 六月 5, 2017, 6:21 p.m., Nate Cole wrote: > > Ship It! Thanks for your review - yao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59440/#review176931

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-06-05 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59440/#review176931 --- Ship it! Ship It! - Nate Cole On June 1, 2017, 9:31 p.m.,

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-06-01 Thread yao lei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59440/ --- (Updated 六月 2, 2017, 1:31 a.m.) Review request for Ambari, Alejandro

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-06-01 Thread yao lei
> On 六月 1, 2017, 1:03 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > > Lines 2708 (patched) > > > > > > Maybe make this a little clearer: >

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-06-01 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59440/#review176608 --- Ship it!

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-06-01 Thread yao lei
> On 六月 1, 2017, 12:10 p.m., Tim Thorpe wrote: > > Ship It! Thanks a lot - yao --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59440/#review176601

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-06-01 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59440/#review176601 --- Ship it! Ship It! - Tim Thorpe On June 1, 2017, 1:37 a.m.,

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-05-30 Thread yao lei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59440/ --- (Updated May 31, 2017, 4:35 a.m.) Review request for Ambari, Alejandro

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-05-30 Thread yao lei
> On May 30, 2017, 3:28 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AlertScriptDispatcher.java > > Lines 83-86 (patched) > > > > > > This should be

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-05-30 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59440/#review176309 --- Fix it, then Ship it!

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-05-25 Thread yao lei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59440/ --- (Updated 五月 25, 2017, 6:02 a.m.) Review request for Ambari, Alejandro