Re: Review Request 44769: Config recommendations for installed services are getting cleared out

2016-03-15 Thread bhuvnesh chaudhary
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44769/#review123759 --- Ship it! Ship It! - bhuvnesh chaudhary On March 14, 2016, 3:

Re: Review Request 44769: Config recommendations for installed services are getting cleared out

2016-03-14 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44769/#review123470 --- Ship it! Ship It! - Alexandr Antonenko On March 14, 2016, 3:

Re: Review Request 44769: Config recommendations for installed services are getting cleared out

2016-03-14 Thread Goutam Tadi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44769/#review123469 --- Ship it! Ship It! - Goutam Tadi On March 14, 2016, 3:59 p.m.

Re: Review Request 44769: Config recommendations for installed services are getting cleared out

2016-03-14 Thread Goutam Tadi
> On March 14, 2016, 4:09 p.m., Goutam Tadi wrote: > > ambari-web/app/mixins/common/configs/enhanced_configs.js, line 192 > > > > > > How about ```for each ``` instead of ``` for ``` ? > > Alexandr Antonenko wrote:

Re: Review Request 44769: Config recommendations for installed services are getting cleared out

2016-03-14 Thread Alexandr Antonenko
> On March 14, 2016, 4:09 p.m., Goutam Tadi wrote: > > ambari-web/app/mixins/common/configs/enhanced_configs.js, line 192 > > > > > > How about ```for each ``` instead of ``` for ``` ? Any advantages that we will ge

Re: Review Request 44769: Config recommendations for installed services are getting cleared out

2016-03-14 Thread Goutam Tadi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44769/#review123438 --- ambari-web/app/mixins/common/configs/enhanced_configs.js (line 19

Review Request 44769: Config recommendations for installed services are getting cleared out

2016-03-13 Thread Lav Jain
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44769/ --- Review request for Ambari, Andriy Babiichuk, Alexandr Antonenko, Andrii Tkach, a