Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45979/#review128523 --- Ship it! Ship It! - Alejandro Fernandez On April 11, 2016, 4

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

> On April 12, 2016, 6:30 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java, > > line 56 > > > > > > Can we remove the default

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45979/#review128494 --- ambari-server/src/main/java/org/apache/ambari/server/controller/l

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45979/#review128464 --- Ship it! Ship It! - Jayush Luniya On April 11, 2016, 4:27 p.

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

> On April 12, 2016, 4:25 p.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/LoggingService.java, > > line 188 > > > > > > Can we file JIRAs for the TODOs? Hi Jayush,

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

> On April 12, 2016, 4:39 p.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LoggingResourceProvider.java, > > line 113 > > > > > > This doesnt seem to be used an

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45979/#review128457 --- ambari-server/src/main/java/org/apache/ambari/server/controller/i

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45979/#review128450 --- ambari-server/src/main/java/org/apache/ambari/server/api/services

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45979/#review128389 --- Ship it! Ship It! - Sebastian Toader On April 11, 2016, 6:27

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

> On April 12, 2016, 9:24 a.m., Sebastian Toader wrote: > > Hi Sebastian, Thanks for the review comments. Please see my replies below. Thanks, Bob > On April 12, 2016, 9:24 a.m., Sebastian Toader wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingReq

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45979/#review128352 --- ambari-server/src/main/java/org/apache/ambari/server/controller/l

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

> On April 11, 2016, 9:10 p.m., Alejandro Fernandez wrote: > > Hi Alejandro, Thanks for the review comments. Please see my responses below, which ended up in a separate post, rather than a comment reply. Thanks - Robert --- This is

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45979/#review128252 --- ambari-server/src/main/java/org/apache/ambari/server/controller/l

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45979/#review128247 --- ambari-server/src/main/java/org/apache/ambari/server/controller/l

Re: Review Request 45979: AMBARI-15807: REST API for Logsearch

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45979/ --- (Updated April 11, 2016, 4:27 p.m.) Review request for Ambari, Alejandro Fernan