Re: Review Request 46147: Fix for NullPointerException in LoggingSearchPropertyProvider

2016-04-13 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46147/ --- (Updated April 13, 2016, 3:51 p.m.) Review request for Ambari, Jonathan Hurley,

Re: Review Request 46147: Fix for NullPointerException in LoggingSearchPropertyProvider

2016-04-13 Thread Robert Nettleton
> On April 13, 2016, 2:53 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java, > > line 128 > > > > > > Does this cause an empt

Re: Review Request 46147: Fix for NullPointerException in LoggingSearchPropertyProvider

2016-04-13 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46147/#review128684 --- Ship it! Minor question on returned resources when no service i

Re: Review Request 46147: Fix for NullPointerException in LoggingSearchPropertyProvider

2016-04-13 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46147/#review128676 --- Ship it! Ship It! - Oliver Szabo On April 13, 2016, 2:28 p.m

Re: Review Request 46147: Fix for NullPointerException in LoggingSearchPropertyProvider

2016-04-13 Thread Sumit Mohanty
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46147/#review128675 --- Ship it! Ship It! - Sumit Mohanty On April 13, 2016, 2:28 p.

Review Request 46147: Fix for NullPointerException in LoggingSearchPropertyProvider

2016-04-13 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46147/ --- Review request for Ambari, Jonathan Hurley, Oliver Szabo, and Sumit Mohanty. Bu