Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-08-21 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61043/#review183359 --- Ship it! Ship It! - Balázs Bence Sári On Aug. 17, 2017,

Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-08-17 Thread Chandana Mirashi
com> Cc: Chandana Mirashi <cmir...@us.ibm.com>, Alejandro Fernandez <afernan...@hortonworks.com>, Ambari <reviews@ambari.apache.org> Date: 08/17/2017 02:45 PM Subject: Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox Sent by:

Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-08-17 Thread Sid Wagle
> On July 28, 2017, 2:41 p.m., Balázs Bence Sári wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java > > Lines 67 (patched) > > > > > > Why not boolean? > > Chandana Mirashi

Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-08-17 Thread Chandana Mirashi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61043/ --- (Updated Aug. 17, 2017, 9:40 p.m.) Review request for Ambari, Balázs Bence

Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-08-04 Thread Chandana Mirashi
> On July 28, 2017, 2:41 p.m., Balázs Bence Sári wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java > > Lines 67 (patched) > > > > > > Why not boolean? I followed similar

Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-07-28 Thread Balázs Bence Sári
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61043/#review181664 ---

Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-07-24 Thread Chandana Mirashi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61043/ --- (Updated July 25, 2017, 12:53 a.m.) Review request for Ambari, Balázs Bence

Re: Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-07-24 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61043/#review181235 --- Ship it! It looks good to me. It is similar to the change set

Review Request 61043: AMBARI-21325: Quicklink support through Knox

2017-07-21 Thread Chandana Mirashi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61043/ --- Review request for Ambari, Balázs Bence Sári, Juanjo Marron, and Sid Wagle.