Re: Review Request 64089: Make Ambari LDAP configuration API consistent with existing API

2017-11-29 Thread Robert Levas
> On Nov. 28, 2017, 9:34 a.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/RootServiceComponentConfigurationService.java > > Lines 97-99 (patched) > > > > > > Nit: we've

Re: Review Request 64089: Make Ambari LDAP configuration API consistent with existing API

2017-11-29 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64089/ --- (Updated Nov. 29, 2017, 2:16 p.m.) Review request for Ambari, Attila Magyar,

Re: Review Request 64089: Make Ambari LDAP configuration API consistent with existing API

2017-11-29 Thread Robert Levas
> On Nov. 28, 2017, 4:45 a.m., Attila Magyar wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariServerConfigurationHandler.java > > Lines 52 (patched) > > > > > > Do we need

Re: Review Request 64089: Make Ambari LDAP configuration API consistent with existing API

2017-11-28 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64089/#review192033 --- Ship it! Ship It! - Jonathan Hurley On Nov. 27, 2017, 3:52

Re: Review Request 64089: Make Ambari LDAP configuration API consistent with existing API

2017-11-28 Thread Robert Levas
> On Nov. 28, 2017, 4:45 a.m., Attila Magyar wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariServerConfigurationHandler.java > > Lines 52 (patched) > > > > > > Do we need

Re: Review Request 64089: Make Ambari LDAP configuration API consistent with existing API

2017-11-28 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64089/#review192031 --- Ship it!

Re: Review Request 64089: Make Ambari LDAP configuration API consistent with existing API

2017-11-28 Thread Nate Cole
> On Nov. 28, 2017, 4:45 a.m., Attila Magyar wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariServerConfigurationHandler.java > > Lines 52 (patched) > > > > > > Do we need

Re: Review Request 64089: Make Ambari LDAP configuration API consistent with existing API

2017-11-28 Thread Eugene Chekanskiy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64089/#review192023 --- Ship it! Ship It! - Eugene Chekanskiy On Nov. 27, 2017,

Re: Review Request 64089: Make Ambari LDAP configuration API consistent with existing API

2017-11-28 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64089/#review192005 ---

Re: Review Request 64089: Make Ambari LDAP configuration API consistent with existing API

2017-11-27 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64089/ --- (Updated Nov. 27, 2017, 3:52 p.m.) Review request for Ambari, Attila Magyar,