Review Request 50377: Update Atlas Metadata server security status for the new version

2016-07-23 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50377/
---

Review request for Ambari, Alejandro Fernandez and Robert Levas.


Bugs: AMBARI-17869
https://issues.apache.org/jira/browse/AMBARI-17869


Repository: ambari


Description
---

Add support for new properties to detect security status


Diffs
-

  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py
 f18809f 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 3797cf3 

Diff: https://reviews.apache.org/r/50377/diff/


Testing
---

Manually ran UT and tested on a kerberized cluster. UTs pass.


Thanks,

Sumit Mohanty

Review Request 50373: Fix xml KERBEROS/1.10.3-10/configuration/kerberos-env.xml

2016-07-23 Thread Ajit Kumar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50373/
---

Review request for Ambari, Andriy Babiichuk, Aleksandr Kovalenko, and Sumit 
Mohanty.


Bugs: AMBARI-17867
https://issues.apache.org/jira/browse/AMBARI-17867


Repository: ambari


Description
---

Fix KERBEROS/1.10.3-10/configuration/kerberos-env.xml which has bad xml element 
"host" at line number 89. This is breaking build 
https://builds.apache.org/job/Ambari-trunk-Commit/5372
Unit test failing:
org.apache.ambari.server.state.ServicePropertiesTest.validatePropertySchemaOfServiceXMLs

org.apache.ambari.server.AmbariException: File 
/Users/ajit.kumar/workspace/ambari/ambari-server/target/test-classes/TestAmbaryServer.samples/../../../src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
 didn't pass the validation. Error message is : cvc-complex-type.2.4.a: Invalid 
content was found starting with element 'type'. One of '{maximum, minimum, 
unit, delete, empty-value-valid, ui-only-property, read-only, 
editable-only-at-install, show-property-name, increment-step, entries, hidden, 
entries_editable, selection-cardinality, property-file-name, 
property-file-type}' is expected.

at 
org.apache.ambari.server.stack.StackManager.validateAllPropertyXmlsInFolderRecursively(StackManager.java:452)
at 
org.apache.ambari.server.state.ServicePropertiesTest.validatePropertySchemaOfServiceXMLs(ServicePropertiesTest.java:48)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at 
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
at 
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
at 
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
at 
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
at 
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
at org.junit.runner.JUnitCore.run(JUnitCore.java:157)
at 
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:119)
at 
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:42)
at 
com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:234)
at 
com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:74)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at 
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at 
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)


Diffs
-

  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
 0e219a4 

Diff: https://reviews.apache.org/r/50373/diff/


Testing
---


Thanks,

Ajit Kumar

Re: Review Request 50337: AMBARI-17854 Config changes for Ranger HA in kerberos env

2016-07-23 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50337/#review143315
---




ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
 (line 72)


In that case should it be in 
HDP/2.5/services/RANGER/configurations/ranger-admin-site.xml?


- Sumit Mohanty


On July 22, 2016, 2:52 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50337/
> ---
> 
> (Updated July 22, 2016, 2:52 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Robert Levas, 
> Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17854
> https://issues.apache.org/jira/browse/AMBARI-17854
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Setting default value for ranger.spnego.kerberos.principal as *
> Use only /spengo keytab under 
> ranger-admin-site.xml/ranger.spnego.kerberos.keytab
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
>  477df7a 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> 94c681d 
> 
> Diff: https://reviews.apache.org/r/50337/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger installation in kerberos env
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 50337: AMBARI-17854 Config changes for Ranger HA in kerberos env

2016-07-23 Thread Sumit Mohanty 


> On July 23, 2016, 2:34 p.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml,
> >  line 72
> > 
> >
> > In that case should it be in 
> > HDP/2.5/services/RANGER/configurations/ranger-admin-site.xml?

You can ignore. Reaized that starting HDP-2.5, it extends RANGER 0.6.0


- Sumit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50337/#review143315
---


On July 22, 2016, 2:52 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50337/
> ---
> 
> (Updated July 22, 2016, 2:52 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Robert Levas, 
> Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17854
> https://issues.apache.org/jira/browse/AMBARI-17854
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Setting default value for ranger.spnego.kerberos.principal as *
> Use only /spengo keytab under 
> ranger-admin-site.xml/ranger.spnego.kerberos.keytab
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
>  477df7a 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> 94c681d 
> 
> Diff: https://reviews.apache.org/r/50337/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger installation in kerberos env
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 50337: AMBARI-17854 Config changes for Ranger HA in kerberos env

2016-07-23 Thread Mugdha Varadkar 


> On July 22, 2016, 5:54 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml,
> >  line 72
> > 
> >
> > What should happen to existing clusters with Ranger that are Kerberized?

This is new property in stack 2.5


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50337/#review143245
---


On July 22, 2016, 2:52 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50337/
> ---
> 
> (Updated July 22, 2016, 2:52 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Robert Levas, 
> Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17854
> https://issues.apache.org/jira/browse/AMBARI-17854
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Setting default value for ranger.spnego.kerberos.principal as *
> Use only /spengo keytab under 
> ranger-admin-site.xml/ranger.spnego.kerberos.keytab
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
>  477df7a 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> 94c681d 
> 
> Diff: https://reviews.apache.org/r/50337/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger installation in kerberos env
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 50373: Fix xml KERBEROS/1.10.3-10/configuration/kerberos-env.xml

2016-07-23 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50373/#review143316
---


Ship it!




Good catch.

- Sumit Mohanty


On July 23, 2016, 7:25 a.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50373/
> ---
> 
> (Updated July 23, 2016, 7:25 a.m.)
> 
> 
> Review request for Ambari, Andriy Babiichuk, Aleksandr Kovalenko, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-17867
> https://issues.apache.org/jira/browse/AMBARI-17867
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix KERBEROS/1.10.3-10/configuration/kerberos-env.xml which has bad xml 
> element "host" at line number 89. This is breaking build 
> https://builds.apache.org/job/Ambari-trunk-Commit/5372
> Unit test failing:
> org.apache.ambari.server.state.ServicePropertiesTest.validatePropertySchemaOfServiceXMLs
> 
> org.apache.ambari.server.AmbariException: File 
> /Users/ajit.kumar/workspace/ambari/ambari-server/target/test-classes/TestAmbaryServer.samples/../../../src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  didn't pass the validation. Error message is : cvc-complex-type.2.4.a: 
> Invalid content was found starting with element 'type'. One of '{maximum, 
> minimum, unit, delete, empty-value-valid, ui-only-property, read-only, 
> editable-only-at-install, show-property-name, increment-step, entries, 
> hidden, entries_editable, selection-cardinality, property-file-name, 
> property-file-type}' is expected.
> 
>   at 
> org.apache.ambari.server.stack.StackManager.validateAllPropertyXmlsInFolderRecursively(StackManager.java:452)
>   at 
> org.apache.ambari.server.state.ServicePropertiesTest.validatePropertySchemaOfServiceXMLs(ServicePropertiesTest.java:48)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:45)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:42)
>   at 
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:263)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:68)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:47)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:231)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:60)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:229)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:50)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:222)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:300)
>   at org.junit.runner.JUnitCore.run(JUnitCore.java:157)
>   at 
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:119)
>   at 
> com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:42)
>   at 
> com.intellij.rt.execution.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:234)
>   at 
> com.intellij.rt.execution.junit.JUnitStarter.main(JUnitStarter.java:74)
>   at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:497)
>   at com.intellij.rt.execution.application.AppMain.main(AppMain.java:144)
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  0e219a4 
> 
> Diff: https://reviews.apache.org/r/50373/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>

Re: Review Request 50376: Regenerate the Ranger keytab step is shown at wrong time

2016-07-23 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50376/#review143320
---


Ship it!




Ship It!

- Jonathan Hurley


On July 23, 2016, 2:05 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50376/
> ---
> 
> (Updated July 23, 2016, 2:05 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-17868
> https://issues.apache.org/jira/browse/AMBARI-17868
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The Ranger Regenerate Keytab step should be shown before Finalize to allow 
> the user to pause the upgrade and actually do that.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 4d5fd07 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> ca60120 
> 
> Diff: https://reviews.apache.org/r/50376/diff/
> 
> 
> Testing
> ---
> 
> Upgrade Pack change only.  Manual testing to make sure the message appears at 
> the end of RU, and that the keytabs can be regenerated when pausing the 
> Upgrade.
> 
> Automated shows failures not related to UP change.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Review Request 50376: Regenerate the Ranger keytab step is shown at wrong time

2016-07-23 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50376/
---

Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-17868
https://issues.apache.org/jira/browse/AMBARI-17868


Repository: ambari


Description
---

The Ranger Regenerate Keytab step should be shown before Finalize to allow the 
user to pause the upgrade and actually do that.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
4d5fd07 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
ca60120 

Diff: https://reviews.apache.org/r/50376/diff/


Testing
---

Upgrade Pack change only.  Manual testing to make sure the message appears at 
the end of RU, and that the keytabs can be regenerated when pausing the Upgrade.

Automated shows failures not related to UP change.


Thanks,

Nate Cole