Re: Review Request 52649: Create Component to Repo Version associations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52649/#review151877 ---

Review Request 52630: Improve package handling in Microsoft R Server Mpack

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52630/ --- Review request for Ambari, Attila Doroszlai, Jayush Luniya, Sandor Magyari, and

Re: Review Request 52630: Improve package handling in Microsoft R Server Mpack

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52630/#review151788 --- Ship it! Ship It! - Sebastian Toader On Oct. 7, 2016, 3:29

Re: Review Request 52646: Remove Unnecessary Locks Inside Of Service Business Object Implementations

> On Oct. 7, 2016, 4:07 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java, > > line 447 > > > > > > Do we still need to explcitly refresh even though there is no

Re: Review Request 52646: Remove Unnecessary Locks Inside Of Service Business Object Implementations

> On Oct. 7, 2016, 4:13 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/host/HostImpl.java, > > line 966 > > > > > > Shouldn't we target removing the explicit refresh calls as

Review Request 52654: At "Add Service Wizard", when the installation is going on, if I click the close (X) on the wizard, the service will only get INSTALLED not STARTED.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52654/ --- Review request for Ambari, Jaimin Jetly, Zhe (Joe) Wang, Richard Zang, Xi Wang,

Re: Review Request 52430: Include an option to download the saved query in hive view

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52430/#review151812 --- Ship it! Ship It! - DIPAYAN BHOWMICK On Oct. 7, 2016, 4:33

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

> On Oct. 7, 2016, 8:06 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/logging/LockProfileDelegate.java, > > line 81 > > > > > > Missing a space here, line 85, and 94 after

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52636/#review151837 --- Fix it, then Ship it!

Re: Review Request 52430: Include an option to download the saved query in hive view

> On Oct. 7, 2016, 4:41 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! Hi Dipayan...thank you for reviewing the code.Can you please help in pushing the code? - Anita --- This is an automatically generated e-mail. To reply, visit:

Review Request 52636: Implement instrumented Lock for profiling/logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52636/ --- Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Sandor Magyari, and

Re: Review Request 52646: Remove Unnecessary Locks Inside Of Service Business Object Implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52646/#review151846 ---

Re: Review Request 52430: Include an option to download the saved query in hive view

> On Oct. 7, 2016, 4:41 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! > > Anita Jebaraj wrote: > Hi Dipayan...thank you for reviewing the code.Can you please help in > pushing the code? Push it into trunk, branch-2.5 - DIPAYAN ---

Re: Review Request 52646: Remove Unnecessary Locks Inside Of Service Business Object Implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52646/#review151868 ---

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52636/#review151839 ---

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

> On Oct. 7, 2016, 2:06 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/logging/LockFactory.java, > > line 35 > > > > > > Add javadoc for how this will be used. All methods

Re: Review Request 52646: Remove Unnecessary Locks Inside Of Service Business Object Implementations

> On Oct. 7, 2016, 3:12 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/HostComponentStateDAO.java, > > lines 178-187 > > > > > > The DAO should not be in the business

Re: Review Request 52646: Remove Unnecessary Locks Inside Of Service Business Object Implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52646/#review151862 --- Ship it! Ship It! - Nate Cole On Oct. 7, 2016, 3:04 p.m.,

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

> On Oct. 7, 2016, 7:39 p.m., Nate Cole wrote: > > This code is breaking tests, and has been reverted from trunk. Please fix > > the tests, and also fix the formatting. Ambari is standardized on two > > space tabs. DependencyConditionInfo is a undocumented and unformatted > > class. In

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

> On Oct. 7, 2016, 8:53 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/logging/LockFactory.java, > > line 50 > > > > > > There should be a default prefix What should be the

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52636/#review151841 --- Can you explain when the lock information is dumped? I would have

Re: Review Request 51815: Introduce conditional dependencies in stack defition to handle blueprint validation gracefully

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51815/#review151861 --- This code is breaking tests, and has been reverted from trunk.

Re: Review Request 52646: Remove Unnecessary Locks Inside Of Service Business Object Implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52646/#review151869 ---

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52636/#review151833 --- Fix it, then Ship it!

Review Request 52646: Remove Unnecessary Locks Inside Of Service Business Object Implementations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52646/ --- Review request for Ambari, Nate Cole, Robert Levas, and Sid Wagle. Bugs:

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

> On Oct. 7, 2016, 8:53 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/logging/DelegatingLock.java, > > line 24 > > > > > > What is this class actually doing? It's just

Re: Review Request 52636: Implement instrumented Lock for profiling/logging

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52636/ --- (Updated Oct. 7, 2016, 10:21 p.m.) Review request for Ambari, Jonathan Hurley,

Review Request 52649: Create Component to Repo Version associations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52649/ --- Review request for Ambari, Alejandro Fernandez and Jonathan Hurley. Bugs:

Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

> On Oct. 7, 2016, 10:39 p.m., Swapan Shridhar wrote: > > ambari-server/src/main/resources/common-services/DRUID/0.9.2/configuration/druid-broker.xml, > > line 67 > > > > > > In case you want to show bytes as unit

Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50803/#review151889 --- Fix it, then Ship it! Please remove 2.6 non-druid related

Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50803/#review151901 ---

Re: Review Request 52553: Fix regression issues for logsearch refactor

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52553/#review151780 --- Ship it! Ship It! - Miklos Gergely On Oct. 5, 2016, 2:21

Re: Review Request 52602: BP format does not generate property oozie.service.JPAService.jdbc.url

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52602/#review151765 --- Ship it! Ship It! - Sebastian Toader On Oct. 6, 2016, 10:48

Review Request 52629: Microsoft R Server management pack should support for Redhat 7

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52629/ --- Review request for Ambari, Attila Doroszlai, Jayush Luniya, Sandor Magyari, and

Re: Review Request 52629: Microsoft R Server management pack should support for Redhat 7

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52629/#review151785 --- Ship it! Ship It! - Sebastian Toader On Oct. 7, 2016, 3:18

Re: Review Request 50803: [Ambari-19781] Integrate Druid With Ambari

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50803/ --- (Updated Oct. 8, 2016, 3:05 a.m.) Review request for Ambari, Renjith Kamath