Re: Review Request 59701: AMBARI-21154 : Add JAAS config properties for Atlas Hive hook in HiveCli to use kerberos ticket-cache

2017-06-06 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59701/#review177146 ---

Review Request 59828: Ability to anonymize data during log processing

2017-06-06 Thread Miklos Gergely
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59828/ --- Review request for Ambari, Oliver Szabo and Robert Nettleton. Bugs:

Review Request 59835: Agent Host Disk Usage Alert Hardcodes the Stack Directory

2017-06-06 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59835/ --- Review request for Ambari and Vitalyi Brodetskyi. Bugs: AMBARI-21182

Re: Review Request 59828: Ability to anonymize data during log processing

2017-06-06 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59828/#review177007 --- Ship it! Ship It! - Oliver Szabo On June 6, 2017, 8:55

Re: Review Request 59835: Agent Host Disk Usage Alert Hardcodes the Stack Directory

2017-06-06 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59835/#review177020 --- Ship it! Ship It! - Dmytro Grinenko On June 6, 2017, 10:45

Re: Review Request 59818: Component command changes must include version numbers for all services

2017-06-06 Thread Jonathan Hurley
> On June 6, 2017, 8:11 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > > Lines 547-549 (patched) > > > > > > Any opinion about skipping components

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-06-06 Thread Jonathan Hurley
> On June 1, 2017, 9:03 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > > Lines 2708 (patched) > > > > > > Maybe make this a little clearer:

Re: Review Request 59440: Part One: Specify the script directly in alert target for script-based alert dispatchers

2017-06-06 Thread yao lei
> On 六月 1, 2017, 1:03 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java > > Lines 2708 (patched) > > > > > > Maybe make this a little clearer: >

Re: Review Request 59701: AMBARI-21154 : Add JAAS config properties for Atlas Hive hook in HiveCli to use kerberos ticket-cache

2017-06-06 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59701/#review177045 --- Ship it! Ship It! - Robert Levas On June 1, 2017, 1:04

Re: Review Request 59727: AMBARI-21161 Able to safe guard Ambari server against circular dependencies in role command order

2017-06-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59727/#review177107 --- Ship it! Ship It! - Alejandro Fernandez On June 6, 2017,

Review Request 59870: Part Two: Specify the script directly in alert target for script-based alert dispatchers

2017-06-06 Thread yao lei
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59870/ --- Review request for Ambari, Alexandr Antonenko, Richard Zang, and Yusaku Sako.

Re: Review Request 59818: Component command changes must include version numbers for all services

2017-06-06 Thread Nate Cole
> On June 6, 2017, 8:11 a.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java > > Lines 527-530 (patched) > > > > > > Maybe add some doc since many won't

Review Request 59838: Stack advisor needs to recommend dependency for slaves and masters

2017-06-06 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59838/ --- Review request for Ambari, Alejandro Fernandez, Di Li, Jaimin Jetly, Jonathan

Re: Review Request 59818: Component command changes must include version numbers for all services

2017-06-06 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59818/#review177023 --- Ship it!

Re: Review Request 59394: Race condition: webhdfs call mkdir /tmp/druid-indexing before /tmp making tmp not writable.

2017-06-06 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59394/#review177018 --- Ship it! Ship It! - Dmytro Grinenko On May 19, 2017, 9:54

Review Request 59839: AMBARI-20884. Compilation error due to import from relocated package

2017-06-06 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59839/ --- Review request for Ambari, Jonathan Hurley and Sebastian Toader. Bugs:

Re: Review Request 59839: AMBARI-20884. Compilation error due to import from relocated package

2017-06-06 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59839/#review177032 --- Ship it! Ship It! - Sebastian Toader On June 6, 2017, 3:11

Re: Review Request 59839: AMBARI-20884. Compilation error due to import from relocated package

2017-06-06 Thread Sandor Magyari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59839/#review177034 --- Ship it! Ship It! - Sandor Magyari On June 6, 2017, 1:20

Re: Review Request 59818: Component command changes must include version numbers for all services

2017-06-06 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59818/#review177035 --- Ship it! Ship It! - Dmitro Lisnichenko On June 6, 2017,

Review Request 59846: Get rid deprecated jdk install in the Dockerfile of Log Search

2017-06-06 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59846/ --- Review request for Ambari, Miklos Gergely and Robert Nettleton. Bugs: trunk

Re: Review Request 59838: Stack advisor needs to recommend dependency for slaves and masters

2017-06-06 Thread Tim Thorpe
> On June 6, 2017, 5:38 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/stack_advisor.py > > Lines 759 (patched) > > > > > > Can you provide an example of why this has to be sorted? Hi

Re: Review Request 59838: Stack advisor needs to recommend dependency for slaves and masters

2017-06-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59838/#review177055 --- ambari-server/src/main/resources/stacks/stack_advisor.py Lines

Re: Review Request 59149: Add Kerberos HTTP SPNEGO authentication support to Hadoop/hbase/kafka/storm sinks

2017-06-06 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59149/#review177062 --- Ship it! Ship It! - Robert Levas On June 1, 2017, 2:52

Re: Review Request 59701: AMBARI-21154 : Add JAAS config properties for Atlas Hive hook in HiveCli to use kerberos ticket-cache

2017-06-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59701/#review177049 --- Ship it! Ship It! - Alejandro Fernandez On June 1, 2017,

Review Request 59851: Configuration Symlink Is Incorrect After Stack Distribution

2017-06-06 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59851/ --- Review request for Ambari, Dmitro Lisnichenko and Nate Cole. Bugs:

Re: Review Request 59851: Configuration Symlink Is Incorrect After Stack Distribution

2017-06-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59851/#review177073 --- Ship it! Ship It! - Alejandro Fernandez On June 6, 2017,

Re: Review Request 59846: Get rid deprecated jdk install in the Dockerfile of Log Search

2017-06-06 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59846/#review177067 --- Ship it! Ship It! - Robert Nettleton On June 6, 2017, 5:14

Re: Review Request 59838: Stack advisor needs to recommend dependency for slaves and masters

2017-06-06 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59838/#review177072 --- Ship it! Ship It! - Alejandro Fernandez On June 6, 2017,

Re: Review Request 59727: AMBARI-21161 Able to safe guard Ambari server against circular dependencies in role command order

2017-06-06 Thread Alejandro Fernandez
> On June 1, 2017, 8:58 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraph.java > > Lines 342 (patched) > > > > > > Btw, this will only find cycles

Re: Review Request 59727: AMBARI-21161 Able to safe guard Ambari server against circular dependencies in role command order

2017-06-06 Thread Di Li
> On June 1, 2017, 8:58 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraph.java > > Lines 342 (patched) > > > > > > Btw, this will only find cycles

Re: Review Request 59727: AMBARI-21161 Able to safe guard Ambari server against circular dependencies in role command order

2017-06-06 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59727/ --- (Updated June 6, 2017, 7:02 p.m.) Review request for Ambari and Tim Thorpe.

Re: Review Request 59095: AMBARI-20967 - Remove Zookeeper as a required service from HDFS

2017-06-06 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59095/ --- (Updated June 6, 2017, 8:16 p.m.) Review request for Ambari, Alejandro

Re: Review Request 59838: Stack advisor needs to recommend dependency for slaves and masters

2017-06-06 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59838/#review177078 --- Ship it! Ship It! - Di Li On June 6, 2017, 11:33 a.m., Tim

Re: Review Request 59727: AMBARI-21161 Able to safe guard Ambari server against circular dependencies in role command order

2017-06-06 Thread Di Li
> On June 1, 2017, 8:58 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stageplanner/RoleGraph.java > > Lines 342 (patched) > > > > > > Btw, this will only find cycles

Re: Review Request 59727: AMBARI-21161 Able to safe guard Ambari server against circular dependencies in role command order

2017-06-06 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59727/ --- (Updated June 6, 2017, 8:23 p.m.) Review request for Ambari and Tim Thorpe.