Re: Review Request 59756: Delete view privileges from the Groups page

2017-06-27 Thread Sangeeta Ravindran
> On June 27, 2017, 12:24 p.m., Sangeeta Ravindran wrote: > > Ship It! > > Anita Jebaraj wrote: > Hi Sangeeta, can you please help in pushing the changes? Done. You can close this review. - Sangeeta --- This is an automatically

Re: Review Request 60475: Upgrades Must Track To/From Repository Versions Instead of Strings

2017-06-27 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60475/#review179019 --- ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql

Re: Review Request 60475: Upgrades Must Track To/From Repository Versions Instead of Strings

2017-06-27 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60475/ --- (Updated June 27, 2017, 3:32 p.m.) Review request for Ambari, Attila

Re: Review Request 60477: AMBARI-21350. Create a cross stack upgrade pack in Ambari

2017-06-27 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60477/#review179021 ---

Re: Review Request 60477: AMBARI-21350. Create a cross stack upgrade pack in Ambari

2017-06-27 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60477/#review179022 ---

Re: Review Request 60431: Cleanup relevant Kerberos identities when a component is removed

2017-06-27 Thread Robert Levas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60431/#review179008 --- Fix it, then Ship it! Ship It!

Re: Review Request 60477: AMBARI-21350. Create a cross stack upgrade pack in Ambari

2017-06-27 Thread Jonathan Hurley
> On June 27, 2017, 3:35 p.m., Di Li wrote: > > ambari-server/src/main/resources/stacks/BigInsights/upgrades/config-upgrade.xml > > Lines 1 (patched) > > > > > > Should we even allow the auto config updates during EU

Re: Review Request 60477: AMBARI-21350. Create a cross stack upgrade pack in Ambari

2017-06-27 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60477/#review179020 --- Interesting ... you can place an upgrade at the stack level

Re: Review Request 60475: Upgrades Must Track To/From Repository Versions Instead of Strings

2017-06-27 Thread Jonathan Hurley
> On June 27, 2017, 3:33 p.m., Attila Doroszlai wrote: > > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql > > Line 831 (original), 831 (patched) > > > > > > Should be `NUMBER(19)` ZOMG - good eye!

Re: Review Request 60475: Upgrades Must Track To/From Repository Versions Instead of Strings

2017-06-27 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60475/ --- (Updated June 27, 2017, 3:41 p.m.) Review request for Ambari, Attila

Review Request 60489: Typo in stack advisor error message for yarn and mr queue config issues

2017-06-27 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60489/ --- Review request for Ambari, Di Li and Tim Thorpe. Bugs: AMBARI-21274

Re: Review Request 60477: AMBARI-21350. Create a cross stack upgrade pack in Ambari

2017-06-27 Thread Sid Wagle
> On June 27, 2017, 7:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/BigInsights/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > > Lines 875-881 (patched) > > > > > > I think we need buy-in

Re: Review Request 60477: AMBARI-21350. Create a cross stack upgrade pack in Ambari

2017-06-27 Thread Alejandro Fernandez
> On June 27, 2017, 7:37 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/stacks/BigInsights/upgrades/nonrolling-upgrade-to-hdp-2.6.xml > > Lines 20 (patched) > > > > > > Please add the

Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

2017-06-27 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60481/ --- Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, Jonathan

Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

2017-06-27 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60480/ --- Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko, Jonathan

Re: Review Request 60475: Upgrades Must Track To/From Repository Versions Instead of Strings

2017-06-27 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60475/#review179033 --- Ship it! Ship It! - Sid Wagle On June 27, 2017, 7:41 p.m.,

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

2017-06-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60480/#review179034 --- Ship it! Ship It! - Alejandro Fernandez On June 27, 2017,

Re: Review Request 60477: AMBARI-21350. Create a cross stack upgrade pack in Ambari

2017-06-27 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60477/#review179041 --- Ship it! Ship It! - Sid Wagle On June 27, 2017, 8:26 p.m.,

Re: Review Request 60365: Config update API should not need to have a unique tag, BE can auto add the tag when it is missing

2017-06-27 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60365/#review178991 --- Ship it! Ship It! - Sid Wagle On June 27, 2017, 4:08 p.m.,

Re: Review Request 59756: Delete view privileges from the Groups page

2017-06-27 Thread Anita Jebaraj
> On June 27, 2017, 12:24 p.m., Sangeeta Ravindran wrote: > > Ship It! Hi Sangeeta, can you please help in pushing the changes? - Anita --- This is an automatically generated e-mail. To reply, visit:

Review Request 60488: Ability to delete a view instance from view instance list

2017-06-27 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60488/ --- Review request for Ambari, Alexandr Antonenko and Di Li. Bugs: AMBARI-21360

Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

2017-06-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60481/#review179050 --- Ship it! Ship It! - Alejandro Fernandez On June 27, 2017,

Re: Review Request 60480: AMBARI-21351 Add Support For MariaDB to Python Scripts

2017-06-27 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60480/#review179055 --- Ship it! Ship It! - Tim Thorpe On June 27, 2017, 8:08 p.m.,

Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

2017-06-27 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60481/#review179056 --- Ship it! Ship It! - Tim Thorpe On June 27, 2017, 9:02 p.m.,

Re: Review Request 60481: AMBARI-21359 Add JavaVersionCheck check

2017-06-27 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60481/#review179058 --- just to notice this change (can be related for this):

Re: Review Request 60249: AMBARI-21234 Ambari rack awareness for Kafka

2017-06-27 Thread Ambud Sharma
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60249/ --- (Updated June 27, 2017, 11:10 p.m.) Review request for Ambari and Alejandro

Re: Review Request 59756: Delete view privileges from the Groups page

2017-06-27 Thread Alexandr Antonenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59756/#review178957 --- Ship it! Ship It! - Alexandr Antonenko On June 2, 2017,

Re: Review Request 60459: Workflow Manager view build failure

2017-06-27 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60459/#review178965 --- Ship it! Ship It! - Pallav Kulshreshtha On June 27, 2017,

Re: Review Request 60365: Config update API should not need to have a unique tag, BE can auto add the tag when it is missing

2017-06-27 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60365/ --- (Updated Червень 27, 2017, 4:08 після полудня) Review request for Ambari,

Re: Review Request 60365: Config update API should not need to have a unique tag, BE can auto add the tag when it is missing

2017-06-27 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60365/#review178985 --- Ship it! Ship It! - Myroslav Papirkovskyy On Червень 27,

Review Request 60475: Upgrades Must Track To/From Repository Versions Instead of Strings

2017-06-27 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60475/ --- Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, and Sid Wagle.

Re: Review Request 60455: Styling Issues with newly implemented workflow manager file browser

2017-06-27 Thread belliraj hb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60455/#review178962 --- Ship it! Ship It! - belliraj hb On June 27, 2017, 6:47

Review Request 60455: Styling Issues with newly implemented workflow manager file browser

2017-06-27 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60455/ --- Review request for Ambari, belliraj hb, Nitiraj Rathore, Padma Priya N, Pallav

Re: Review Request 60459: Workflow Manager view build failure

2017-06-27 Thread belliraj hb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60459/#review178967 --- Ship it! Ship It! - belliraj hb On June 27, 2017, 9:22

Re: Review Request 60455: Styling Issues with newly implemented workflow manager file browser

2017-06-27 Thread Padma Priya N
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60455/#review178963 --- Ship it! Ship It! - Padma Priya N On June 27, 2017, 6:47

Review Request 60459: Workflow Manager view build failure

2017-06-27 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60459/ --- Review request for Ambari, belliraj hb, Nitiraj Rathore, Padma Priya N, Pallav

Re: Review Request 60431: Cleanup relevant Kerberos identities when a component is removed

2017-06-27 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60431/#review178966 --- Ship it! Ship It! - Sebastian Toader On June 26, 2017, 6:23

Review Request 60463: Apply KerberosInterpreter related changes in Ambari

2017-06-27 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60463/ --- Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN

Re: Review Request 60431: Cleanup relevant Kerberos identities when a component is removed

2017-06-27 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60431/ --- (Updated June 27, 2017, 12:35 p.m.) Review request for Ambari, Balázs Bence

Review Request 60460: AMBARI-21058 HDP 3.0 - Changing common service version for Ranger & Ranger Kms

2017-06-27 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60460/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, and Jayush Luniya.

Re: Review Request 60431: Cleanup relevant Kerberos identities when a component is removed

2017-06-27 Thread Attila Magyar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60431/ --- (Updated June 27, 2017, 11:20 a.m.) Review request for Ambari, Balázs Bence

Re: Review Request 59756: Delete view privileges from the Groups page

2017-06-27 Thread Sangeeta Ravindran
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59756/#review178979 --- Ship it! Ship It! - Sangeeta Ravindran On June 2, 2017,

Review Request 60464: Pausing An Upgrade In Progress Does Not Resume PENDING Tasks

2017-06-27 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60464/ --- Review request for Ambari, Jonathan Hurley and Nate Cole. Bugs: AMBARI-21298

Re: Review Request 60464: Cannot install Datanode/AppTimeLine server from ambari 3.0

2017-06-27 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60464/#review178981 --- Ship it! Ship It! - Jonathan Hurley On June 27, 2017, 8:19

Re: Review Request 60463: Apply KerberosInterpreter related changes in Ambari

2017-06-27 Thread venkat sairam
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60463/#review178974 --- Ship it! Ship It! - venkat sairam On June 27, 2017, 11:20

Re: Review Request 60463: Apply KerberosInterpreter related changes in Ambari

2017-06-27 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60463/#review178972 --- Ship it! Ship It! - Gaurav Nagar On June 27, 2017, 11:20

Re: Review Request 60464: Cannot install Datanode/AppTimeLine server from ambari 3.0

2017-06-27 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60464/ --- (Updated June 27, 2017, 3:19 p.m.) Review request for Ambari, Jonathan Hurley

Re: Review Request 60475: Upgrades Must Track To/From Repository Versions Instead of Strings

2017-06-27 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60475/#review179061 --- Ship it! Ship It! - Alejandro Fernandez On June 27, 2017,