Re: Review Request 64594: AMBARI-22649. Library for querying clusterSettings and stackSettings for its contents in command*.json

2017-12-17 Thread Swapan Shridhar
> On Dec. 16, 2017, 12:49 p.m., Attila Doroszlai wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_settings.py > > Lines 32-88 (patched) > > > > > > Most of these 2 functions are

Re: Review Request 64667: Livy server fails to start during downgrade due to absence of 'conf' directory

2017-12-17 Thread Dmitro Lisnichenko
> On Dec. 16, 2017, 10:35 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > > Lines 160-164 (patched) > > > > > > We should not hard code this into

Review Request 64670: AMBARI-22660. Fix unit tests failing due to ServiceGroup issues

2017-12-17 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64670/ --- Review request for Ambari, Balázs Bence Sári, Dmytro Sen, Jayush Luniya,

Re: Review Request 64594: AMBARI-22649. Library for querying clusterSettings and stackSettings for its contents in command*.json

2017-12-17 Thread Swapan Shridhar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64594/ --- (Updated Dec. 17, 2017, 8:11 a.m.) Review request for Ambari, Attila

Re: Review Request 64594: AMBARI-22649. Library for querying clusterSettings and stackSettings for its contents in command*.json

2017-12-17 Thread Attila Doroszlai
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64594/#review194031 --- Fix it, then Ship it! I've [attached a small unit

Re: Review Request 64667: Livy server fails to start during downgrade due to absence of 'conf' directory

2017-12-17 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64667/#review194033 --- Fix it, then Ship it!

Re: Review Request 64667: Livy server fails to start during downgrade due to absence of 'conf' directory

2017-12-17 Thread Jonathan Hurley
> On Dec. 17, 2017, 2:14 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/resources/custom_actions/scripts/install_packages.py > > Lines 155 (patched) > > > > > > OK - let's just make this a little less

Re: Review Request 64660: Rafactor: Package Log Search and Log Feeder into jars + cleanup start scripts

2017-12-17 Thread Krisztian Kasa
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64660/#review194039 --- Ship it! Ship It! - Krisztian Kasa On Dec. 16, 2017, 1:27