Re: Review Request 45980: If initial NN start runs into problem while communicating with JN, restart does not work

2016-04-09 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45980/#review128010
---


Ship it!




Ship It!

- Sid Wagle


On April 9, 2016, 4:46 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45980/
> ---
> 
> (Updated April 9, 2016, 4:46 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen and Sid Wagle.
> 
> 
> Bugs: AMBARI-15789
> https://issues.apache.org/jira/browse/AMBARI-15789
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
>  70e27a5 
> 
> Diff: https://reviews.apache.org/r/45980/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 45980: If initial NN start runs into problem while communicating with JN, restart does not work

2016-04-09 Thread Sumit Mohanty 


> On April 9, 2016, 4:15 p.m., Sid Wagle wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py,
> >  line 322
> > 
> >
> > Shouldn't the same logic apply for HA scenario ?
> 
> Andrew Onischuk wrote:
> The code you pointed to is never used.

The if-else section is bit longer than needed but we are now checking for error 
only for HA. Did you mean should it be done in non-HA as well?

The format_namenode() code needs some clean up. It does not seem that we use 
"force=true" anywhere.


- Sumit


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45980/#review127988
---


On April 9, 2016, 4:46 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45980/
> ---
> 
> (Updated April 9, 2016, 4:46 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen and Sid Wagle.
> 
> 
> Bugs: AMBARI-15789
> https://issues.apache.org/jira/browse/AMBARI-15789
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
>  70e27a5 
> 
> Diff: https://reviews.apache.org/r/45980/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 45980: If initial NN start runs into problem while communicating with JN, restart does not work

2016-04-09 Thread Andrew Onischuk 


> On April 9, 2016, 4:15 p.m., Sid Wagle wrote:
> > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py,
> >  line 322
> > 
> >
> > Shouldn't the same logic apply for HA scenario ?

The code you pointed to is never used.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45980/#review127988
---


On April 9, 2016, 4:46 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45980/
> ---
> 
> (Updated April 9, 2016, 4:46 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen and Sid Wagle.
> 
> 
> Bugs: AMBARI-15789
> https://issues.apache.org/jira/browse/AMBARI-15789
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> .
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
>  70e27a5 
> 
> Diff: https://reviews.apache.org/r/45980/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-09 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45972/#review127987
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 89)


Will this not always be true? What is the expected value of status to go in 
to the if condition



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 183)


--loglevel is probably default set to INFO. Do we need to pass that in 
explicitly?



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 240)


On which host should these directories be created? It seems to be needed on 
all hosts where llap is running - at least based on the name.

Also, we should be using the Directory construct to create the directories.



ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 (line 477)


Change the default to /hadoop/llap/local


- Sumit Mohanty


On April 9, 2016, 7:30 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45972/
> ---
> 
> (Updated April 9, 2016, 7:30 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Robert Levas, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15785
> https://issues.apache.org/jira/browse/AMBARI-15785
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HiveServerInteractive. Kerberos Support. 
> 
> - Needs to have hive keytabs on all nodemanagers.
> - Hive Server Interactive needs same keytabs as HiveServer and Metastore.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  055296b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  c7d57c0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  5830a52 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 9050092 
> 
> Diff: https://reviews.apache.org/r/45972/diff/
> 
> 
> Testing
> ---
> 
> - Partially done.
> - Currently blocked by : https://hortonworks.jira.com/browse/BUG-55791
> - 
> - Python UT : PASSES.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 45980: If initial NN start runs into problem while communicating with JN, restart does not work

2016-04-09 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45980/#review127973
---


Ship it!




Ship It!

- Dmytro Sen


On Апрель 9, 2016, 12:34 п.п., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45980/
> ---
> 
> (Updated Апрель 9, 2016, 12:34 п.п.)
> 
> 
> Review request for Ambari and Dmytro Sen.
> 
> 
> Bugs: AMBARI-15789
> https://issues.apache.org/jira/browse/AMBARI-15789
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
>  70e27a5 
> 
> Diff: https://reviews.apache.org/r/45980/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 45980: If initial NN start runs into problem while communicating with JN, restart does not work

2016-04-09 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45980/
---

Review request for Ambari and Dmytro Sen.


Bugs: AMBARI-15789
https://issues.apache.org/jira/browse/AMBARI-15789


Repository: ambari


Description
---


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_namenode.py
 70e27a5 

Diff: https://reviews.apache.org/r/45980/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 45892: Initial commit for LogSearch service definition

2016-04-09 Thread Oliver Szabo 


> On April 8, 2016, 6:08 p.m., Alejandro Fernandez wrote:
> > This is a pretty massive patch. Please allow some time for the community to 
> > review.
> 
> Jayush Luniya wrote:
> Can the patch be broken down in more granular chunks?
> 
> Oliver Szabo wrote:
> most of it is a move (the logsearch module), so its pretty big anyway. 
> but i can send you a link to check the commits
> 
> Jayush Luniya wrote:
> I understand we need to commit the logsearch module in one shot, but we 
> can break this down into following steps atleast
> 
> 1. ambari-logsearch/ commit without the project being built (i.e. no 
> changes to ambari/pom.xml to build the project by default).
> 2. Ambari Core changes (JAVA code changes, resource_management changes 
> and add to ambari/pom.xml)
> 3. ambari-logsearch common-service service definition and HDP stack 
> definition changes
> 
> Oliver Szabo wrote:
> ok, now its late for me, tomorrow i will create 2 another review (about 
> java and stack definition part)

I created the separated commits: (only difference that you mentioned the first 
logsearch module commit contains root pom.xml changes)
https://reviews.apache.org/r/45978/
https://reviews.apache.org/r/45979/

https://github.com/apache/ambari/tree/branch-dev-logsearch


- Oliver


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45892/#review127828
---


On April 8, 2016, 6 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45892/
> ---
> 
> (Updated April 8, 2016, 6 p.m.)
> 
> 
> Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit 
> Mohanty.
> 
> 
> Bugs: AMBARI-15679
> https://issues.apache.org/jira/browse/AMBARI-15679
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> description is found in the issue: 
> https://issues.apache.org/jira/browse/AMBARI-15679
> 
> this patch for review board not contains the 
> ambari/ambari-logsearch/ambari-logearch-portal/src/main/webapps/libs folder 
> because that is too big (12 MB)
> 
> The real patch on the apache jira can be applied with: git apply --binary 
> 
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
>  df46ce0 
>   ambari-logsearch/README.md PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-appender/.gitignore PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-appender/build.properties PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-appender/build.xml PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-appender/pom.xml PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-appender/src/main/java/org/apache/ambari/logsearch/appender/LogsearchAppender.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-appender/src/main/java/org/apache/ambari/logsearch/appender/LogsearchConversion.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-appender/src/main/java/org/apache/ambari/logsearch/appender/VBase.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-appender/src/main/java/org/apache/ambari/logsearch/appender/VOutput.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-appender/src/test/java/org/apache/ambari/logsearch/appender/AppTest.java
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-appender/src/test/resources/log4j.properties
>  PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/pom.xml PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/control
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/postinst
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/postrm
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/posttrm
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/preinst
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/prerm
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/logfeeder/control
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/logfeeder/postinst
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/logfeeder/postrm
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/logfeeder/posttrm
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/logfeeder/preinst
>  PRE-CREATION 
>   
> ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/logfeeder/prerm
>

Review Request 45979: AMBARI-15679: REST API for Logsearch

2016-04-09 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45979/
---

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, 
Robert Nettleton, Sumit Mohanty, Sebastian Toader, and Yusaku Sako.


Bugs: AMBARI-15679
https://issues.apache.org/jira/browse/AMBARI-15679


Repository: ambari


Description
---

Logsearch support was splitted into 3 different commits: 
https://github.com/apache/ambari/tree/branch-dev-logsearch
- integrate logsearch module
- ambari server REST implementation for logsearch
- stack definition

This one is the REST implementation. (by Robert Nettleton)


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/LoggingResourceDefinition.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 c711bed 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/ClusterService.java
 371411d 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/LoggingService.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
 f24da8d 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
 ca491f2 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/LoggingResourceProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/HostComponentLoggingInfo.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogFileDefinitionInfo.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogFileType.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogLineResult.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogQueryResponse.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelper.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactory.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperImpl.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
 63af4c4 
  ambari-server/src/main/resources/key_properties.json 46a6cf9 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LogLineResultTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LogQueryResponseTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingRequestHelperFactoryImplTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProviderTest.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/45979/diff/


Testing
---

Testing done.


Thanks,

Oliver Szabo

Review Request 45978: AMBARI-15679: Stack definition for Logsearch

2016-04-09 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45978/
---

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin Jetly, 
Robert Nettleton, Sumit Mohanty, Sebastian Toader, and Yusaku Sako.


Bugs: AMBARI-15679
https://issues.apache.org/jira/browse/AMBARI-15679


Repository: ambari


Description
---

Logsearch support was splitted into 3 different commits: 
https://github.com/apache/ambari/tree/branch-dev-logsearch
- integrate logsearch module
- ambari server REST implementation for logsearch
- stack definition

This one is the stack definition.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
 df46ce0 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/alerts.json 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-site.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-audit_logs-solrconfig.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-service_logs-solrconfig.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-site.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-xml.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logfeeder.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_solr.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/solr.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/status_params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/global.config.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/grok-patterns.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-accumulo.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ambari.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-ams.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-atlas.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-falcon.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hbase.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hdfs.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hive.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-kafka.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-knox.json.j2
 PRE-CREATION

Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-09 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45972/
---

Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Robert Levas, and 
Sumit Mohanty.


Bugs: AMBARI-15785
https://issues.apache.org/jira/browse/AMBARI-15785


Repository: ambari


Description
---

HiveServerInteractive. Kerberos Support. 

- Needs to have hive keytabs on all nodemanagers.
- Hive Server Interactive needs same keytabs as HiveServer and Metastore.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 055296b 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 c7d57c0 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 5830a52 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
9050092 

Diff: https://reviews.apache.org/r/45972/diff/


Testing
---

- Partially done.
- Currently blocked by : https://hortonworks.jira.com/browse/BUG-55791
- 
- Python UT : PASSES.


Thanks,

Swapan Shridhar