----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45972/#review127987 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 89) <https://reviews.apache.org/r/45972/#comment191383> Will this not always be true? What is the expected value of status to go in to the if condition ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 183) <https://reviews.apache.org/r/45972/#comment191384> --loglevel is probably default set to INFO. Do we need to pass that in explicitly? ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py (line 240) <https://reviews.apache.org/r/45972/#comment191385> On which host should these directories be created? It seems to be needed on all hosts where llap is running - at least based on the name. Also, we should be using the Directory construct to create the directories. ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml (line 477) <https://reviews.apache.org/r/45972/#comment191386> Change the default to /hadoop/llap/local - Sumit Mohanty On April 9, 2016, 7:30 a.m., Swapan Shridhar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45972/ > ----------------------------------------------------------- > > (Updated April 9, 2016, 7:30 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Robert Levas, > and Sumit Mohanty. > > > Bugs: AMBARI-15785 > https://issues.apache.org/jira/browse/AMBARI-15785 > > > Repository: ambari > > > Description > ------- > > HiveServerInteractive. Kerberos Support. > > - Needs to have hive keytabs on all nodemanagers. > - Hive Server Interactive needs same keytabs as HiveServer and Metastore. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py > 055296b > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > c7d57c0 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml > 5830a52 > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 9050092 > > Diff: https://reviews.apache.org/r/45972/diff/ > > > Testing > ------- > > - Partially done. > - Currently blocked by : https://hortonworks.jira.com/browse/BUG-55791 > - > - Python UT : PASSES. > > > Thanks, > > Swapan Shridhar > >
