Re: Review Request 46002: Ambari installation failing in RHEL7 during setup

2016-04-10 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46002/#review128069
---


Ship it!




Ship It!

- Sumit Mohanty


On April 11, 2016, 5:29 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46002/
> ---
> 
> (Updated April 11, 2016, 5:29 a.m.)
> 
> 
> Review request for Ambari and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-15797
> https://issues.apache.org/jira/browse/AMBARI-15797
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This single VM cluster is available for few more hours.
> 
> 
> 
> 
> 172.22.89.190 smb2-1.novalocalsmb2-1
> 
> 
> **Error during setup**
> 
> 
> 
> About to start PostgreSQL
> Configuring local database...
> Connecting to local database...done.
> Configuring PostgreSQL...
> ERROR: Exiting with exit code 4.
> REASON: Redirecting to /bin/systemctl reload  postgresql.service
> Failed to issue method call: Access denied
> 
> [root@smb2-1 ~]# ambari-server start
> Using python  /usr/bin/python
> Starting ambari-server
> ERROR: Exiting with exit code 1.
> REASON: Unable to detect a system user for Ambari Server.
> - If this is a new setup, then run the "ambari-server setup" command to 
> create the user
> - If this is an upgrade of an existing setup, run the "ambari-server 
> upgrade" command.
> Refer to the Ambari documentation for more information on setup and 
> upgrade.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 
> 754873f 
> 
> Diff: https://reviews.apache.org/r/46002/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-10 Thread Swapan Shridhar 


> On April 11, 2016, 5:18 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py,
> >  line 137
> > 
> >
> > why the check for params.current_version to be not None?

Fixed. Doesn't make sense there.


> On April 11, 2016, 5:18 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py,
> >  line 184
> > 
> >
> > Do not hard code path to folder .slider/keytabs/hive - hive. The 
> > setup_security() method is using {params.hive_user}. Use the same here as 
> > well.

Done.


> On April 11, 2016, 5:18 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py,
> >  line 504
> > 
> >
> > Remove the variable llap_local_dir

Removed. Not required till we decide on creating LLAP related work dirs.


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45972/#review128067
---


On April 11, 2016, 5:03 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45972/
> ---
> 
> (Updated April 11, 2016, 5:03 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Robert Levas, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15785
> https://issues.apache.org/jira/browse/AMBARI-15785
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HiveServerInteractive. Kerberos Support. 
> 
> - Needs to have hive keytabs on all nodemanagers.
> - Hive Server Interactive needs same keytabs as HiveServer and Metastore.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  055296b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  c7d57c0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  5830a52 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> a3009ee 
> 
> Diff: https://reviews.apache.org/r/45972/diff/
> 
> 
> Testing
> ---
> 
> - Partially done.
> - Python UT : PASSES.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Review Request 46002: Ambari installation failing in RHEL7 during setup

2016-04-10 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46002/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-15797
https://issues.apache.org/jira/browse/AMBARI-15797


Repository: ambari


Description
---

This single VM cluster is available for few more hours.




172.22.89.190   smb2-1.novalocalsmb2-1


**Error during setup**



About to start PostgreSQL
Configuring local database...
Connecting to local database...done.
Configuring PostgreSQL...
ERROR: Exiting with exit code 4.
REASON: Redirecting to /bin/systemctl reload  postgresql.service
Failed to issue method call: Access denied

[root@smb2-1 ~]# ambari-server start
Using python  /usr/bin/python
Starting ambari-server
ERROR: Exiting with exit code 1.
REASON: Unable to detect a system user for Ambari Server.
- If this is a new setup, then run the "ambari-server setup" command to 
create the user
- If this is an upgrade of an existing setup, run the "ambari-server 
upgrade" command.
Refer to the Ambari documentation for more information on setup and upgrade.


Diffs
-

  ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py 754873f 

Diff: https://reviews.apache.org/r/46002/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-10 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45972/
---

(Updated April 11, 2016, 5:03 a.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Robert Levas, and 
Sumit Mohanty.


Changes
---

Removed '/hadoop/llap/local' di creation for Kerberized cluster.


Bugs: AMBARI-15785
https://issues.apache.org/jira/browse/AMBARI-15785


Repository: ambari


Description
---

HiveServerInteractive. Kerberos Support. 

- Needs to have hive keytabs on all nodemanagers.
- Hive Server Interactive needs same keytabs as HiveServer and Metastore.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 055296b 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 c7d57c0 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 5830a52 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
a3009ee 

Diff: https://reviews.apache.org/r/45972/diff/


Testing
---

- Partially done.
- Python UT : PASSES.


Thanks,

Swapan Shridhar

Review Request 46001: Exception seen in ambari-agent during restart.

2016-04-10 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46001/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-15796
https://issues.apache.org/jira/browse/AMBARI-15796


Repository: ambari


Description
---

agent restart  
Restarting ambari-agent  
Verifying Python version compatibility...  
Using python /usr/bin/python  
Found ambari-agent PID: 9941  
Stopping ambari-agent  
*Traceback (most recent call last):  
File "/usr/lib/python2.6/site-packages/ambari_agent/main.py", line 343, in
  
logger.exception("Exiting with exception:" + e)  
TypeError: cannot concatenate 'str' and 'exceptions.Exception' objects*  
Removing PID file at /var/run/ambari-agent/ambari-agent.pid


Diffs
-

  ambari-agent/src/main/python/ambari_agent/main.py b146ba8 

Diff: https://reviews.apache.org/r/46001/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 46000: Parallel execution should only be allowed on commands that have auto retry enabled

2016-04-10 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46000/
---

Review request for Ambari, Sandor Magyari and Sebastian Toader.


Bugs: AMBARI-15795
https://issues.apache.org/jira/browse/AMBARI-15795


Repository: ambari


Description
---

Parallel execution should only be allowed on commands that have auto retry 
enabled


Diffs
-

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py 4d4103e 
  ambari-agent/src/test/python/ambari_agent/TestActionQueue.py 466c3a8 

Diff: https://reviews.apache.org/r/46000/diff/


Testing
---

mvn test against ambari-agent passed. New unit tests added.


Thanks,

Sumit Mohanty

Re: Review Request 45998: HIVE service_check doesn't work properly

2016-04-10 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45998/#review128064
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
 (line 59)


/tmp/show_db.post.txt is this a path in local filesystem?

If yes, we should use agent tmp_dir, because some users has non-executable 
tmp.

You will have to get it from params.tmp_dir and pass it into script.


- Andrew Onischuk


On April 11, 2016, 3:07 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45998/
> ---
> 
> (Updated April 11, 2016, 3:07 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In templetonSmoke.sh, there are
> 1) unnecessary `exit 0`
> 2) lack of redirect `>` command
> 3) unassigned variable
> 
> we should correct them all to check the HIVE service properly.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
>  dd00e02 
> 
> Diff: https://reviews.apache.org/r/45998/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 45998: HIVE service_check doesn't work properly

2016-04-10 Thread Andrew Onischuk 


> On April 11, 2016, 4:21 a.m., Andrew Onischuk wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh,
> >  line 84
> > 
> >
> > I wonder where this $destdir variable comes from

or was it not working at all?


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45998/#review128062
---


On April 11, 2016, 3:07 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45998/
> ---
> 
> (Updated April 11, 2016, 3:07 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In templetonSmoke.sh, there are
> 1) unnecessary `exit 0`
> 2) lack of redirect `>` command
> 3) unassigned variable
> 
> we should correct them all to check the HIVE service properly.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
>  dd00e02 
> 
> Diff: https://reviews.apache.org/r/45998/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 45998: HIVE service_check doesn't work properly

2016-04-10 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45998/#review128062
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
 (line 81)


I wonder where this $destdir variable comes from


- Andrew Onischuk


On April 11, 2016, 3:07 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45998/
> ---
> 
> (Updated April 11, 2016, 3:07 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, and Nate Cole.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In templetonSmoke.sh, there are
> 1) unnecessary `exit 0`
> 2) lack of redirect `>` command
> 3) unassigned variable
> 
> we should correct them all to check the HIVE service properly.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/files/templetonSmoke.sh
>  dd00e02 
> 
> Diff: https://reviews.apache.org/r/45998/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test and manual test with HDP2.4 and Ambari 2.2.1.0
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>