Review Request 47579: Spark2 service definition for Ambari

[Saisai Shao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47579/
---

Review request for Ambari, Jayush Luniya and Sumit Mohanty.


Bugs: AMBARI-16753
https://issues.apache.org/jira/browse/AMBARI-16753


Repository: ambari


Description
---

Add Spark2 service definition for Ambari


Diffs
-

  ambari-server/src/main/resources/common-services/SPARK2/2.0.0/alerts.json 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-defaults.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-hive-site-override.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-log4j-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-metrics-properties.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-fairscheduler.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-thrift-sparkconf.xml
 PRE-CREATION 
  ambari-server/src/main/resources/common-services/SPARK2/2.0.0/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/common-services/SPARK2/2.0.0/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/job_history_server.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/service_check.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/setup_spark.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_client.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_service.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/spark_thrift_server.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/status_params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/SPARK2/2.0.0/quicklinks/quicklinks.json
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/SPARK2/metainfo.xml 
PRE-CREATION 

Diff: https://reviews.apache.org/r/47579/diff/


Testing
---

Local manual test


Thanks,

Saisai Shao

Re: Review Request 47573: Next button is disabled on assign master page in Add Hawq Standby wizard

[bhuvnesh chaudhary]

> On May 19, 2016, 4:22 a.m., Alexander Denissov wrote:
> > ambari-web/app/views/main/admin/highAvailability/hawq/addStandby/wizard_view.js,
> >  line 64
> > 
> >
> > does this single fix solves both issues ?

The host is considered as invalid if this parameter is not set. (recently 
changed behavior)
This fix will not mark the host as invalid if its not in maintenance due to 
which next button remains enabled
not sure which second issue you are referring ?


- bhuvnesh


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47573/#review133872
---


On May 19, 2016, 1:29 a.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47573/
> ---
> 
> (Updated May 19, 2016, 1:29 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16754
> https://issues.apache.org/jira/browse/AMBARI-16754
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Next button is disabled on assign master page in Add Hawq Standby wizard. 
> Host maintenance state is not propageted from the wizard view to the 
> underlying controllers.
> 
> 
> Diffs
> -
> 
>   
> ambari-web/app/views/main/admin/highAvailability/hawq/addStandby/wizard_view.js
>  def93f3 
> 
> Diff: https://reviews.apache.org/r/47573/diff/
> 
> 
> Testing
> ---
> 
> yes.
> 
> 
>   27821 tests complete (31 seconds)
>   154 tests pending
>   [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:32 min
> [INFO] Finished at: 2016-05-18T18:26:48-07:00
> [INFO] Final Memory: 14M/339M
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Re: Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU

[Mugdha Varadkar]

> On May 18, 2016, 6:14 p.m., Alejandro Fernandez wrote:
> > ambari-common/src/main/python/resource_management/libraries/script/script.py,
> >  line 661
> > 
> >
> > No need to check for None.
> > 
> > Is there already a Jira to track the fix for the pid for Ranger?

https://issues.apache.org/jira/browse/AMBARI-16756


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/#review133779
---


On May 18, 2016, 11:59 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47529/
> ---
> 
> (Updated May 18, 2016, 11:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16727
> https://issues.apache.org/jira/browse/AMBARI-16727
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding sleep time of 15 seconds after execution of stop command as Ranger 
> Admin process requires time to stop. Once the logic for pid is available from 
> Ranger code, will update the code.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> cbf313e 
>   ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 
> 98a0b38 
> 
> Diff: https://reviews.apache.org/r/47529/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger on centos 6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 47573: Next button is disabled on assign master page in Add Hawq Standby wizard

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47573/#review133872
---




ambari-web/app/views/main/admin/highAvailability/hawq/addStandby/wizard_view.js 
(line 64)


does this single fix solves both issues ?


- Alexander Denissov


On May 19, 2016, 1:29 a.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47573/
> ---
> 
> (Updated May 19, 2016, 1:29 a.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16754
> https://issues.apache.org/jira/browse/AMBARI-16754
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Next button is disabled on assign master page in Add Hawq Standby wizard. 
> Host maintenance state is not propageted from the wizard view to the 
> underlying controllers.
> 
> 
> Diffs
> -
> 
>   
> ambari-web/app/views/main/admin/highAvailability/hawq/addStandby/wizard_view.js
>  def93f3 
> 
> Diff: https://reviews.apache.org/r/47573/diff/
> 
> 
> Testing
> ---
> 
> yes.
> 
> 
>   27821 tests complete (31 seconds)
>   154 tests pending
>   [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:32 min
> [INFO] Finished at: 2016-05-18T18:26:48-07:00
> [INFO] Final Memory: 14M/339M
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Re: Review Request 47573: Next button is disabled on assign master page in Add Hawq Standby wizard

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47573/#review133864
---




ambari-web/app/views/main/admin/highAvailability/hawq/addStandby/wizard_view.js 
(line 64)


Is this something new that applies only to trunk and branch-2.4?


- Matt


On May 18, 2016, 6:29 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47573/
> ---
> 
> (Updated May 18, 2016, 6:29 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16754
> https://issues.apache.org/jira/browse/AMBARI-16754
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Next button is disabled on assign master page in Add Hawq Standby wizard. 
> Host maintenance state is not propageted from the wizard view to the 
> underlying controllers.
> 
> 
> Diffs
> -
> 
>   
> ambari-web/app/views/main/admin/highAvailability/hawq/addStandby/wizard_view.js
>  def93f3 
> 
> Diff: https://reviews.apache.org/r/47573/diff/
> 
> 
> Testing
> ---
> 
> yes.
> 
> 
>   27821 tests complete (31 seconds)
>   154 tests pending
>   [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 01:32 min
> [INFO] Finished at: 2016-05-18T18:26:48-07:00
> [INFO] Final Memory: 14M/339M
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Re: Review Request 47555: AMBARI-16749: Auto-start services: Ambari agent should set auto_start_only to True when recovery_type is AUTO_START

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47555/#review133861
---


Ship it!




Ship It!

- Sumit Mohanty


On May 18, 2016, 9:56 p.m., Nahappan Somasundaram wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47555/
> ---
> 
> (Updated May 18, 2016, 9:56 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-16749
> https://issues.apache.org/jira/browse/AMBARI-16749
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> AMBARI-16749: Auto-start services: Ambari agent should set auto_start_only to 
> True when recovery_type is AUTO_START
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/RecoveryManager.py 
> 9cce7f39a19268e3e1aa92bb9b757abfa31d92de 
> 
> Diff: https://reviews.apache.org/r/47555/diff/
> 
> 
> Testing
> ---
> 
> ** 1. mvn clean install **
> 
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Ambari Main ... SUCCESS [9.211s]
> [INFO] Apache Ambari Project POM . SUCCESS [0.038s]
> [INFO] Ambari Web  SUCCESS [25.368s]
> [INFO] Ambari Views .. SUCCESS [1.094s]
> [INFO] Ambari Admin View . SUCCESS [35.815s]
> [INFO] ambari-metrics  SUCCESS [0.228s]
> [INFO] Ambari Metrics Common . SUCCESS [0.559s]
> [INFO] Ambari Metrics Hadoop Sink  SUCCESS [1.193s]
> [INFO] Ambari Metrics Flume Sink . SUCCESS [0.579s]
> [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.640s]
> [INFO] Ambari Metrics Storm Sink . SUCCESS [1.595s]
> [INFO] Ambari Metrics Collector .. SUCCESS [6.998s]
> [INFO] Ambari Metrics Monitor  SUCCESS [1.837s]
> [INFO] Ambari Metrics Grafana  SUCCESS [1.277s]
> [INFO] Ambari Metrics Assembly ... SUCCESS [1:19.640s]
> [INFO] Ambari Server . SUCCESS [2:25.535s]
> [INFO] Ambari Functional Tests ... SUCCESS [2.519s]
> [INFO] Ambari Agent .. SUCCESS [23.870s]
> [INFO] Ambari Client . SUCCESS [0.069s]
> [INFO] Ambari Python Client .. SUCCESS [0.969s]
> [INFO] Ambari Groovy Client .. SUCCESS [2.226s]
> [INFO] Ambari Shell .. SUCCESS [0.049s]
> [INFO] Ambari Python Shell ... SUCCESS [0.723s]
> [INFO] Ambari Groovy Shell ... SUCCESS [0.870s]
> [INFO] ambari-logsearch .. SUCCESS [0.224s]
> [INFO] Ambari Logsearch Appender . SUCCESS [0.182s]
> [INFO] Ambari Logsearch Solr Client .. SUCCESS [1.046s]
> [INFO] Ambari Logsearch Portal ... SUCCESS [5.797s]
> [INFO] Ambari Logsearch Log Feeder ... SUCCESS [2.081s]
> [INFO] Ambari Logsearch Assembly . SUCCESS [0.068s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 5:54.479s
> [INFO] Finished at: Wed May 18 14:55:04 PDT 2016
> [INFO] Final Memory: 288M/1187M
> [INFO] 
> 
> 
> ** 2. mvn test -DskipSurefireTests **
> 
> --
> Total run:1016
> Total errors:0
> Total failures:0
> OK
> INFO: AMBARI_SERVER_LIB is not set, using default /usr/lib/ambari-server
> AMBARI-16749: Auto-start services: Ambari agent should set auto_start_only to 
> True when recovery_type is AUTO_START
> INFO: Return code from stack upgrade command, retcode = 0
> StackAdvisor implementation for stack HDP1, version 2.0.6 was not found
> Returning DefaultStackAdvisor implementation
> StackAdvisor implementation for stack XYZ, version 1.0.0 was loaded
> StackAdvisor implementation for stack XYZ, version 1.0.1 was loaded
> Returning XYZ101StackAdvisor implementation
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] 

Re: Review Request 47564: Activate HAWQSTANDBY fails on retry

[Lav Jain]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47564/#review133857
---




ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py (line 197)


You may want to take this opportunity to refactor the test code.

ExecuteScript can be a separate function with command passed in as 
parameter.

Similarily, common.stop_component can be refactored into a separate 
function with both test_stop_default and test_activate_hawq_standby calling it.

If you want to go one step further, create a base class of 
TestHawqCommon(RMFTestCase) that defines the corresponding routines in 
common.py with TestHawqStandby(TestHawqCommon).

assertResourceCalled can be defined using functools.partial


- Lav Jain


On May 18, 2016, 11:28 p.m., Matt wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47564/
> ---
> 
> (Updated May 18, 2016, 11:28 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav 
> Jain.
> 
> 
> Bugs: AMBARI-16750
> https://issues.apache.org/jira/browse/AMBARI-16750
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If wizard failed on the Activate Standby step, retrying the step would cause 
> a failure, because the master hosts have been switched already in the 
> configuration.
> Resolution: Before retrying the command, rewrite the configuration with 
> current topology.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
>  45dcff0 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py e247d28 
> 
> Diff: https://reviews.apache.org/r/47564/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> Added unit test.
> 
> test_hawq_master_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_segment_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_hawq_standby_critical 
> (test_alert_component_status.TestAlertComponentStatus) ... ok
> test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_missing_configs (test_alert_component_status.TestAlertComponentStatus) 
> ... ok
> test_exception_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
> handlers could be found for logger "ambari_alerts"
> ok
> test_missing_configs 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_slave_file 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_successful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_empty_db_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_unsuccessful_registration_status_plural 
> (test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
> test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... 
> ok
> test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
> test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
> test_install_default (test_hawqmaster.TestHawqMaster) ... ok
> test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Remove HAWQ Standby ... 2016-05-18 16:27:14,657 - Removing 
> HAWQ Standby Master ...
> ok
> test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
> Run custom command Resync HAWQ Standby ... 2016-05-18 16:27:14,661 - HAWQ 
> Standby Master Re-Sync started in fast mode...
> ok
> test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
> Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
> Kerberized ... 2016-05-18 16:27:14,666 - Executing HAWQ Check ...
> ok
> test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
> Running 

Review Request 47573: Next button is disabled on assign master page in Add Hawq Standby wizard

[bhuvnesh chaudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47573/
---

Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
Diachenko.


Bugs: AMBARI-16754
https://issues.apache.org/jira/browse/AMBARI-16754


Repository: ambari


Description
---

Next button is disabled on assign master page in Add Hawq Standby wizard. 
Host maintenance state is not propageted from the wizard view to the underlying 
controllers.


Diffs
-

  
ambari-web/app/views/main/admin/highAvailability/hawq/addStandby/wizard_view.js 
def93f3 

Diff: https://reviews.apache.org/r/47573/diff/


Testing
---

yes.


  27821 tests complete (31 seconds)
  154 tests pending
  [INFO] 

[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 01:32 min
[INFO] Finished at: 2016-05-18T18:26:48-07:00
[INFO] Final Memory: 14M/339M


Thanks,

bhuvnesh chaudhary

Re: Review Request 47560: clean up import * for Kerberos service scripts in common-services

[Juanjo Marron]

> On May 18, 2016, 10:16 p.m., Alejandro Fernandez wrote:
> > Ship It!

Can someone please ship this patch for me? I do not have committer privileges


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47560/#review133823
---


On May 18, 2016, 10:14 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47560/
> ---
> 
> (Updated May 18, 2016, 10:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16645
> https://issues.apache.org/jira/browse/AMBARI-16645
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for Hive service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
>  e06b13f 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  906d521 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/service_check.py
>  7c09171 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/status_params.py
>  bbae4a3 
> 
> Diff: https://reviews.apache.org/r/47560/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> Kerberos client installation 
> 
> Hadoop QA added a comment - 7 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12803967/AMBARI-16645.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6885//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6885//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47477: clean up import * for HDFS service scripts in common-services

[Juanjo Marron]

> On May 18, 2016, 5:24 p.m., Alejandro Fernandez wrote:
> > Ship It!

Can someone please ship this patch for me? I do not have committer privileges


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47477/#review133767
---


On May 18, 2016, 4:49 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47477/
> ---
> 
> (Updated May 18, 2016, 4:49 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16362
> https://issues.apache.org/jira/browse/AMBARI-16362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for HDFS service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  79c32e4 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py
>  1264284 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
>  d9b76b8 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_datanode.py
>  a22fb99 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py
>  500ed15 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
>  9c5a124 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  b37f413 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_windows.py
>  da00985 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py
>  737ae04 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
>  30eee07 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
>  ceee738 
> 
> Diff: https://reviews.apache.org/r/47477/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> HDFS fresh installation and service check
> Hadoop QA:
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12803107/AMBARI-16362.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6870//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6870//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47475: clean up import * for Hive service scripts in common-services

[Juanjo Marron]

> On May 18, 2016, 10:35 p.m., Matt wrote:
> > Ship It!

Can someone please ship this patch for me? I do not have committer privileges


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47475/#review133824
---


On May 18, 2016, 4:48 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47475/
> ---
> 
> (Updated May 18, 2016, 4:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16189
> https://issues.apache.org/jira/browse/AMBARI-16189
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for Hive service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat.py
>  45dcbe7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
>  b37698e 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py
>  07b4095 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
>  da49450 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  e8532da 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  d0dd9bb 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py
>  851dc02 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py
>  8b98ed1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_users.py
>  c023548 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_utils.py
>  5006b56 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_windows.py
>  880fdb5 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/service_check.py
>  f7304f7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
>  3acbc7b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
>  34687c4 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py
>  c24db4c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
>  8e80d48 
> 
> Diff: https://reviews.apache.org/r/47475/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> HIVE fresh installation and service check
> 
> 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6869
> 
> 
> Hadoop QA added a comment - 8 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12802696/AMBARI-16189.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6869//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6869//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47541: clean up import * for HBase service scripts in common-services

[Juanjo Marron]

> On May 18, 2016, 10:35 p.m., Matt wrote:
> > Ship It!

Can someone please ship this patch for me? I do not have committer privileges


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47541/#review133825
---


On May 18, 2016, 4:41 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47541/
> ---
> 
> (Updated May 18, 2016, 4:41 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16408
> https://issues.apache.org/jira/browse/AMBARI-16408
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for Hive service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  d2f28f5 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
>  f35a570 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_decommission.py
>  022465a 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
>  840411f 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
>  4001912 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py
>  a6904f6 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_upgrade.py
>  2dc9883 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_windows.py
>  7d634cb 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py
>  6ecb58e 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/upgrade.py
>  b1a19e6 
> 
> Diff: https://reviews.apache.org/r/47541/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> Hbase fresh installation and service check
> 
> Hadoop QA added a comment - 2 hours ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12803349/AMBARI-16408.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6878//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6878//console
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 43126: Ambari Upgrade should clean older RCA Database tables

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43126/#review133850
---


Ship it!




Ship It!

- Jayush Luniya


On May 16, 2016, 9:28 p.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43126/
> ---
> 
> (Updated May 16, 2016, 9:28 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-16692
> https://issues.apache.org/jira/browse/AMBARI-16692
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> RCA Database tables is not used anymore. This older, un-necessary data causes 
> many Ambari DB queries to return more slowly than necessary. If the database 
> gets large enough, it can have significant impact on the way ambari-server 
> functions.
> The Ambari Server upgrade process should detect the presence of these older, 
> deprecated tables, and automate the process of cleaning up this data.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  3547ad3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  f36e640 
> 
> Diff: https://reviews.apache.org/r/43126/diff/
> 
> 
> Testing
> ---
> 
> Unit test
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>

Re: Review Request 47570: Recommend value for hawq_rm_memory_limit_perseg for HAWQ

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47570/#review133849
---


Ship it!




Ship It!

- Matt


On May 18, 2016, 5:19 p.m., bhuvnesh chaudhary wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47570/
> ---
> 
> (Updated May 18, 2016, 5:19 p.m.)
> 
> 
> Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
> Diachenko.
> 
> 
> Bugs: AMBARI-16745
> https://issues.apache.org/jira/browse/AMBARI-16745
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Recommend value for hawq_rm_memory_limit_perseg for HAWQ. Below is the 
> recommendation basis.
> vm.overcommit_memory recommedation existing
> 1) If RAM >=32 then 2 else 1
> 
> For recommendation % for memory based on the size of cluster
> RAM = RAM / 2 if vm.overcommit == 2 else 1
> 1) If HAWQ Segment Hosts has RAM <= 64 GB, allocate 75%
> 2) If HAWQ Segment Hosts has 64 < RAM <= 512, allocate 85% 
> 3) If HAWQ Segment Hosts has 512 < RAM, allocate 95%
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py
>  276dd3a 
>   ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 
> 50f3a1f 
> 
> Diff: https://reviews.apache.org/r/47570/diff/
> 
> 
> Testing
> ---
> 
> yes. 
> 
> 
> test_getServiceConfigurationRecommendations 
> (test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok
> 
> 
> --
> Ran 51 tests in 0.317s
> 
> OK
> 
> 
> Thanks,
> 
> bhuvnesh chaudhary
> 
>

Review Request 47570: Recommend value for hawq_rm_memory_limit_perseg for HAWQ

[bhuvnesh chaudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47570/
---

Review request for Ambari, Alexander Denissov, jun aoki, Matt, and Oleksandr 
Diachenko.


Bugs: AMBARI-16745
https://issues.apache.org/jira/browse/AMBARI-16745


Repository: ambari


Description
---

Recommend value for hawq_rm_memory_limit_perseg for HAWQ. Below is the 
recommendation basis.
vm.overcommit_memory recommedation existing
1) If RAM >=32 then 2 else 1

For recommendation % for memory based on the size of cluster
RAM = RAM / 2 if vm.overcommit == 2 else 1
1) If HAWQ Segment Hosts has RAM <= 64 GB, allocate 75%
2) If HAWQ Segment Hosts has 64 < RAM <= 512, allocate 85% 
3) If HAWQ Segment Hosts has 512 < RAM, allocate 95%


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
276dd3a 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_service_advisor.py 50f3a1f 

Diff: https://reviews.apache.org/r/47570/diff/


Testing
---

yes. 


test_getServiceConfigurationRecommendations 
(test_service_advisor.TestHAWQ200ServiceAdvisor) ... ok


--
Ran 51 tests in 0.317s

OK


Thanks,

bhuvnesh chaudhary

Re: Review Request 47539: View display name spills to next line for HUETOAMBARI_MIGRATION

[Sangeeta Ravindran]

> On May 18, 2016, 4:01 p.m., Alexandr Antonenko wrote:
> > Ship It!

Thanks, can you please help push the fix.


- Sangeeta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47539/#review133757
---


On May 18, 2016, 3:59 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47539/
> ---
> 
> (Updated May 18, 2016, 3:59 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and DIPAYAN BHOWMICK.
> 
> 
> Bugs: AMBARI-16404
> https://issues.apache.org/jira/browse/AMBARI-16404
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the latest trunk code, the HUETOAMBARI_MIGRATION view name  spills over 
> to the next line.
> 
> Fix involves changing the css class for the view name column to col-sm-4 and 
> changing css class for first column of view instance row to 
> col-sm-3;padding-left-30
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
>  906eef5 
> 
> Diff: https://reviews.apache.org/r/47539/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Review Request 47564: Activate HAWQSTANDBY fails on retry

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47564/
---

Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, and Lav Jain.


Bugs: AMBARI-16750
https://issues.apache.org/jira/browse/AMBARI-16750


Repository: ambari


Description
---

If wizard failed on the Activate Standby step, retrying the step would cause a 
failure, because the master hosts have been switched already in the 
configuration.
Resolution: Before retrying the command, rewrite the configuration with current 
topology.


Diffs
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/package/scripts/hawqstandby.py
 45dcff0 
  ambari-server/src/test/python/stacks/2.3/HAWQ/test_hawqstandby.py e247d28 

Diff: https://reviews.apache.org/r/47564/diff/


Testing
---

Manually Tested.

Added unit test.

test_hawq_master_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_master_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_segment_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_segment_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_hawq_standby_critical 
(test_alert_component_status.TestAlertComponentStatus) ... ok
test_hawq_standby_ok (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_missing_configs (test_alert_component_status.TestAlertComponentStatus) ... 
ok
test_exception_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... No 
handlers could be found for logger "ambari_alerts"
ok
test_missing_configs 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_slave_file 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_successful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_empty_db_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_unsuccessful_registration_status_plural 
(test_alert_segment_registration_status.TestAlertRegistrationStatus) ... ok
test_missing_configs (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_no_standby_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_none_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_configured_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_not_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronized_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_synchronizing_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_unknown_state (test_alert_sync_status.TestAlertSyncStatus) ... ok
test_configure_default (test_hawqmaster.TestHawqMaster) ... ok
test_install_default (test_hawqmaster.TestHawqMaster) ... ok
test_remove_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Remove HAWQ Standby ... 2016-05-18 16:27:14,657 - Removing 
HAWQ Standby Master ...
ok
test_resync_hawq_standby (test_hawqmaster.TestHawqMaster)
Run custom command Resync HAWQ Standby ... 2016-05-18 16:27:14,661 - HAWQ 
Standby Master Re-Sync started in fast mode...
ok
test_run_hawq_check_case1 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 1: Non HDFS-HA, Standalone Resource Management, Not 
Kerberized ... 2016-05-18 16:27:14,666 - Executing HAWQ Check ...
ok
test_run_hawq_check_case10 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 10: HDFS-HA, YARN Resource Management Non YARN_HA, 
Kerberized ... 2016-05-18 16:27:14,674 - Executing HAWQ Check ...
ok
test_run_hawq_check_case11 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 11: HDFS-HA, YARN Resource Management YARN_HA, Not 
Kerberized ... 2016-05-18 16:27:14,681 - Executing HAWQ Check ...
ok
test_run_hawq_check_case12 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 12: HDFS-HA, YARN Resource Management YARN_HA, 
Kerberized ... 2016-05-18 16:27:14,688 - Executing HAWQ Check ...
ok
test_run_hawq_check_case2 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 2: Non HDFS-HA, Standalone Resource Management, 
Kerberized ... 2016-05-18 16:27:14,694 - Executing HAWQ Check ...
ok
test_run_hawq_check_case3 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 3: Non HDFS-HA, YARN Resource Management Non YARN_HA, 
Not Kerberized ... 2016-05-18 16:27:14,700 - Executing HAWQ Check ...
ok
test_run_hawq_check_case4 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check Case 4: Non HDFS-HA, YARN Resource Management Non YARN_HA, 
Kerberized ... 2016-05-18 16:27:14,707 - Executing HAWQ Check ...
ok
test_run_hawq_check_case5 (test_hawqmaster.TestHawqMaster)
Running HAWQ Check 

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

[Jayush Luniya]

> On May 17, 2016, 5:39 p.m., Jayush Luniya wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java,
> >  line 844
> > 
> >
> > The after tag is overloaded. Meaning it could mean insert this service 
> > after another service in some place and in some places it could mean insert 
> > this  group after another group. I am wondering if there would be a case 
> > where we would need a combination (example: Create a new group that is not 
> > in the stack upgrade pack and add 2 new services to this group in a 
> > specific order). 
> > 
> > Instead of leaving the  tag to interpretation, why not be 
> > explicit as ,  etc. That way we can 
> > support combinations
> 
> Jayush Luniya wrote:
> Example:
> 
> 
>   CORE_MASTERS
>   
> MY_MASTER_1
>   
> 
> 
> 
> 
>   CORE_MASTERS
>   MY_SERVICE_1  
>   
> MY_MASTER_2
>   
> 
>  
>  Alterative
> 
>
>   CORE_MASTERS
>   
> MY_MASTER_1
>   
> 
> 
> 
> 
>   CORE_MASTERS
>   
> MY_SERVICE_1  
> MY_MASTER_2
>   
> 
> 
> Tim Thorpe wrote:
> With custom services they should just be able to create two new groups 
> rather than try to combine them into one.  If there really is a need for the 
> a new group that spans multiple services, then it is probably a candidate for 
> inclusion in the main upgrade xml.  You can even include an empty group in 
> the main upgrade xml like:
> 
> 

RE: If there really is a need for the a new group that spans multiple services, 
then it is probably a candidate for inclusion in the main upgrade xml.
Well these services are add-on services meaning say not part of HDP stack 
itself (example: HAWQ and PFX add-on services on HDP stack). So putting them in 
stack upgrade pack wouldnt be right. 

Yes these can be in 2 separate groups, but that would be because of this 
restriction.

Besides its also confusing when we overload the same property element. For 
example the group name in upgrade pack could be the service name itself like 
below, so  STORM could mean after service STORM or after group 
STORM :) 

https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml#L356-L364

  true
  
NIMBUS
SUPERVISOR
STORM_UI_SERVER
DRPC_SERVER
  



- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review133556
---


On May 18, 2016, 6:26 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45169/
> ---
> 
> (Updated May 18, 2016, 6:26 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush 
> Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-15388
> https://issues.apache.org/jira/browse/AMBARI-15388
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the upgrade is defined as a series of xml files specific to the 
> current stack version and the target stack version. Each upgrade xml defines 
> the overall sequence of the upgrade and what needs to be done for each 
> service. It would both easier to maintain and easier to add new services, if 
> the services themselves could specify what should be done during their 
> upgrade.
> 
> There are two ways to make these changes, the alternate approach would be to 
> only make the java changes and not split the upgrade xml files.  This would 
> still allow new services to add themselves into the upgrade.  The benefit of 
> this is that for the stack services you only have one upgrade xml file.  The 
> problem with that is it is easier for a particular service to have 
> unintentional changes between upgrade xml files.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  7f7a49e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  8a7b42b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> f781574 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java
>  13d5047 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 5a18b3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  88f6e19 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 

Re: Review Request 47475: clean up import * for Hive service scripts in common-services

[Juanjo Marron]

> On May 18, 2016, 5:25 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py,
> >  line 27
> > 
> >
> > How was this working before?

Python was importing it from functions in general, but I think it is a good 
practice to be more specific

There are plenty of exmaples in the.py common-services code. Other working 
example is: 
from resource_management.libraries.functions import Direction
where Direction is actually defined in from 
resource_management.libraries.functions.constants


Thanks for the review Alex


- Juanjo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47475/#review133768
---


On May 18, 2016, 4:48 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47475/
> ---
> 
> (Updated May 18, 2016, 4:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16189
> https://issues.apache.org/jira/browse/AMBARI-16189
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for Hive service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat.py
>  45dcbe7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
>  b37698e 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py
>  07b4095 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
>  da49450 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  e8532da 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  d0dd9bb 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py
>  851dc02 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py
>  8b98ed1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_users.py
>  c023548 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_utils.py
>  5006b56 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_windows.py
>  880fdb5 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/service_check.py
>  f7304f7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
>  3acbc7b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
>  34687c4 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py
>  c24db4c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
>  8e80d48 
> 
> Diff: https://reviews.apache.org/r/47475/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> HIVE fresh installation and service check
> 
> 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6869
> 
> 
> Hadoop QA added a comment - 8 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12802696/AMBARI-16189.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6869//testReport/
> Console output: 
> 

Re: Review Request 47477: clean up import * for HDFS service scripts in common-services

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47477/#review133827
---


Ship it!




Ship It!

- Matt


On May 18, 2016, 9:49 a.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47477/
> ---
> 
> (Updated May 18, 2016, 9:49 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16362
> https://issues.apache.org/jira/browse/AMBARI-16362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for HDFS service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  79c32e4 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py
>  1264284 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
>  d9b76b8 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_datanode.py
>  a22fb99 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py
>  500ed15 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
>  9c5a124 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  b37f413 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_windows.py
>  da00985 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py
>  737ae04 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
>  30eee07 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
>  ceee738 
> 
> Diff: https://reviews.apache.org/r/47477/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> HDFS fresh installation and service check
> Hadoop QA:
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12803107/AMBARI-16362.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6870//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6870//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47541: clean up import * for HBase service scripts in common-services

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47541/#review133825
---


Ship it!




Ship It!

- Matt


On May 18, 2016, 9:41 a.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47541/
> ---
> 
> (Updated May 18, 2016, 9:41 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16408
> https://issues.apache.org/jira/browse/AMBARI-16408
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for Hive service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  d2f28f5 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
>  f35a570 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_decommission.py
>  022465a 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
>  840411f 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
>  4001912 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py
>  a6904f6 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_upgrade.py
>  2dc9883 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_windows.py
>  7d634cb 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py
>  6ecb58e 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/upgrade.py
>  b1a19e6 
> 
> Diff: https://reviews.apache.org/r/47541/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> Hbase fresh installation and service check
> 
> Hadoop QA added a comment - 2 hours ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12803349/AMBARI-16408.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6878//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6878//console
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47560: clean up import * for Kerberos service scripts in common-services

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47560/#review133823
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 18, 2016, 10:14 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47560/
> ---
> 
> (Updated May 18, 2016, 10:14 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16645
> https://issues.apache.org/jira/browse/AMBARI-16645
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for Hive service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
>  e06b13f 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/params.py
>  906d521 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/service_check.py
>  7c09171 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/status_params.py
>  bbae4a3 
> 
> Diff: https://reviews.apache.org/r/47560/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> Kerberos client installation 
> 
> Hadoop QA added a comment - 7 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12803967/AMBARI-16645.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6885//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6885//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47523: AMBARI-16725 Alert type = RECOVERY does not have connection timeout

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47523/#review133822
---


Ship it!




Ship It!

- Richard Zang


On May 18, 2016, 6:10 a.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47523/
> ---
> 
> (Updated May 18, 2016, 6:10 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Richard Zang, Xi 
> Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16725
> https://issues.apache.org/jira/browse/AMBARI-16725
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> RECOVERY alert types do not have a connection timeout, therefore, this should 
> not be shown in the UI (and not have an error because it's blank).
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/alerts/definition_configs_controller.js 
> 617f7cc 
> 
> Diff: https://reviews.apache.org/r/47523/diff/
> 
> 
> Testing
> ---
> 
> Local ambari-web test passed.
> 27819 tests complete (24 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 47514: Kerberos wizard gets reset and does not remember selections/data entered in previous step when you click on Back

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47514/#review133814
---


Ship it!




Ship It!

- Alexandr Antonenko


On May 18, 2016, 7:05 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47514/
> ---
> 
> (Updated May 18, 2016, 7:05 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-15951
> https://issues.apache.org/jira/browse/AMBARI-15951
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Navigate to Admin->Kerberos. Click on Enable Kerberos.
> 2. In the wizard, select Existing Active Directory for e.g.
> 3. Check all the pre-requisites.
> 4. Click on Next to get to the Configure Kerberos page.
> 5. Click on Back.
> 6. The type of KDC radio button gets reset to Existing MIT KDC.
> 7. Same thing happens if you Navigate to Install and Test Kerberos Client 
> page and navigate back to the second or first page of the wizard.
> 
> Expected results:
> Like other wizards such as Add Service Wizard, the wizard should remember 
> selections/data when navigating back in the wizard.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 7f561dd 
>   ambari-web/app/views/main/admin/kerberos/step1_view.js 2e7c4cf 
>   ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js 
> fda2ab4 
> 
> Diff: https://reviews.apache.org/r/47514/diff/
> 
> 
> Testing
> ---
> 
> Ran mvn test
> 27719 tests complete (32 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 47288: AMBARI-16225. Storm Ambari view should work with Firefox 25

[Srimanth Gunturi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47288/#review133800
---


Ship it!




Ship It!

- Srimanth Gunturi


On May 17, 2016, 5:51 a.m., Sriharsha Chintalapani wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47288/
> ---
> 
> (Updated May 17, 2016, 5:51 a.m.)
> 
> 
> Review request for Ambari and Srimanth Gunturi.
> 
> 
> Bugs: AMBARI-16225
> https://issues.apache.org/jira/browse/AMBARI-16225
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Storm Ambari view should work with Firefox 25
> 
> 
> Diffs
> -
> 
>   
> contrib/views/storm/src/main/resources/scripts/collections/BaseCollection.js 
> 29b1ce9 
>   contrib/views/storm/src/main/resources/scripts/components/Breadcrumbs.jsx 
> 75c2fa9 
>   contrib/views/storm/src/main/resources/scripts/components/Modal.jsx e37b734 
>   contrib/views/storm/src/main/resources/scripts/components/RadialChart.jsx 
> f28b08a 
>   contrib/views/storm/src/main/resources/scripts/components/SpoutGraph.jsx 
> cec4c85 
>   contrib/views/storm/src/main/resources/scripts/components/Table.jsx 3b0ad50 
>   contrib/views/storm/src/main/resources/scripts/components/TopologyGraph.jsx 
> e74a251 
>   contrib/views/storm/src/main/resources/scripts/containers/NimbusSummary.jsx 
> ee901b9 
>   
> contrib/views/storm/src/main/resources/scripts/containers/SupervisorSummary.jsx
>  e403b86 
>   
> contrib/views/storm/src/main/resources/scripts/containers/TopologyConfiguration.jsx
>  dd2ad64 
>   
> contrib/views/storm/src/main/resources/scripts/containers/TopologyDetailGraph.jsx
>  64fdee1 
>   
> contrib/views/storm/src/main/resources/scripts/containers/TopologyListing.jsx 
> 9ce19f0 
>   contrib/views/storm/src/main/resources/scripts/modules/Table/Pagination.jsx 
> 41a763c 
>   contrib/views/storm/src/main/resources/scripts/router/Router.js 24fc1e0 
>   
> contrib/views/storm/src/main/resources/scripts/views/ComponentDetailView.jsx 
> 14f7527 
>   contrib/views/storm/src/main/resources/scripts/views/ProfilingView.jsx 
> eb9d0d1 
>   contrib/views/storm/src/main/resources/scripts/views/RebalanceView.jsx 
> 96f01a6 
>   contrib/views/storm/src/main/resources/scripts/views/TopologyDetailView.jsx 
> bf66903 
> 
> Diff: https://reviews.apache.org/r/47288/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Sriharsha Chintalapani
> 
>

Re: Review Request 47456: Takeover config merge should handle AMS hbase configs

[Srimanth Gunturi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47456/#review133796
---


Ship it!




Ship It!

- Srimanth Gunturi


On May 18, 2016, 3:06 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47456/
> ---
> 
> (Updated May 18, 2016, 3:06 p.m.)
> 
> 
> Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-16703
> https://issues.apache.org/jira/browse/AMBARI-16703
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> hbase-site conflicts between cluster and AMS.
> 
> Hard code the config path as /etc/ams-hbase/conf to be AMS HBase configs.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/scripts/takeover_config_merge.py f940f27 
>   ambari-server/src/main/resources/scripts/takeover_files_mapping.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/47456/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 47514: Kerberos wizard gets reset and does not remember selections/data entered in previous step when you click on Back

[Anita Jebaraj]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47514/
---

(Updated May 18, 2016, 7:05 p.m.)


Review request for Ambari, Alexandr Antonenko and Di Li.


Changes
---

Made the changes suggested by Alex, changed to setEach


Bugs: AMBARI-15951
https://issues.apache.org/jira/browse/AMBARI-15951


Repository: ambari


Description
---

1. Navigate to Admin->Kerberos. Click on Enable Kerberos.
2. In the wizard, select Existing Active Directory for e.g.
3. Check all the pre-requisites.
4. Click on Next to get to the Configure Kerberos page.
5. Click on Back.
6. The type of KDC radio button gets reset to Existing MIT KDC.
7. Same thing happens if you Navigate to Install and Test Kerberos Client page 
and navigate back to the second or first page of the wizard.

Expected results:
Like other wizards such as Add Service Wizard, the wizard should remember 
selections/data when navigating back in the wizard.


Diffs (updated)
-

  ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 7f561dd 
  ambari-web/app/views/main/admin/kerberos/step1_view.js 2e7c4cf 
  ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js 
fda2ab4 

Diff: https://reviews.apache.org/r/47514/diff/


Testing
---

Ran mvn test
27719 tests complete (32 seconds)
154 tests pending


Thanks,

Anita Jebaraj

Re: Review Request 47488: Ambari copies jdbc driver jar into hadoop/lib and haoop-yarn/lib

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47488/
---

(Updated Травень 18, 2016, 7:16 після полудня)


Review request for Ambari, Andrew Onischuk, Mugdha Varadkar, and Sumit Mohanty.


Bugs: AMBARI-16716
https://issues.apache.org/jira/browse/AMBARI-16716


Repository: ambari


Description
---

PROBLEM:
Ambari copies the jdbc driver (be it mysql or oracle) into 
/usr/hdp/xxx/hadoop/lib and /usr/hdp/xxx/hadoop-yarn/lib, this can cause 
problem for hive and other components, as user updates the jar inside 
/usr/hdp/xx/hive/lib, but those on the hadoop and yarn lib are also in the 
classpath.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin.py
 3eb8591 
  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
 d653000 
  ambari-server/conf/unix/ambari.properties 239a731 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 bf11bf6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
 bb58670 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 5e51f5f 
  ambari-server/src/main/python/ambari_server/serverSetup.py 217d988 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 32a36a7 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
 1e860d9 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 784da9c 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py
 f660562 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 30ffc8f 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
 d0dd9bb 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
 daf0301 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 9f5d799 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py
 7515e9b 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 37bd77c 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py
 3a3ecfe 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 d1268a1 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
 64e2060 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 d69339e 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
 3060353 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 75924c5 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py
 408418c 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py
 fe208de 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py
 5ec5525 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py
 c33d9da 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py
 658e69f 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py
 799447b 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 9fc0971 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
 1dd85e9 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 3306cf2 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/setup_ranger_yarn.py
 1f61d41 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
 8fc1a64 

Diff: https://reviews.apache.org/r/47488/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 47513: AMBARI-16723 Stack id needs to be handled differently according to its source

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47513/#review133787
---


Ship it!




Ship It!

- Jaimin Jetly


On May 18, 2016, 6:24 p.m., Zhe (Joe) Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47513/
> ---
> 
> (Updated May 18, 2016, 6:24 p.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly, Nate Cole, Richard Zang, Xi Wang, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-16723
> https://issues.apache.org/jira/browse/AMBARI-16723
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> For default stacks, stack id contains stack name and stack version, while for 
> others, it should be "stack + "-" + stack_version + "-" + vdf_version"
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/installer.js 421f2dc 
>   ambari-web/app/mappers/stack_mapper.js 473c466 
> 
> Diff: https://reviews.apache.org/r/47513/diff/
> 
> 
> Testing
> ---
> 
> Local ambari-web test passed.
> 27819 tests complete (23 seconds)
> 154 tests pending
> Manual testing done.
> 
> 
> Thanks,
> 
> Zhe (Joe) Wang
> 
>

Re: Review Request 47535: Splitting command output or component's .out before logging to ambari-agent log

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47535/#review133784
---




ambari-common/src/main/python/ambari_commons/str_utils.py (line 85)


Deoes the last fragment also need a newline?


- Alejandro Fernandez


On May 18, 2016, 1:37 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47535/
> ---
> 
> (Updated May 18, 2016, 1:37 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-16732
> https://issues.apache.org/jira/browse/AMBARI-16732
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 85389f9 
>   ambari-common/src/main/python/ambari_commons/str_utils.py 83fc29d 
> 
> Diff: https://reviews.apache.org/r/47535/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/
---

(Updated May 18, 2016, 6:26 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, 
and Nate Cole.


Changes
---

Fixing issue exposed by UpgradeResourceProviderHDP22Test.  Switched the target 
version in src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_15388.xml 
to 2.4


Bugs: AMBARI-15388
https://issues.apache.org/jira/browse/AMBARI-15388


Repository: ambari


Description
---

Currently the upgrade is defined as a series of xml files specific to the 
current stack version and the target stack version. Each upgrade xml defines 
the overall sequence of the upgrade and what needs to be done for each service. 
It would both easier to maintain and easier to add new services, if the 
services themselves could specify what should be done during their upgrade.

There are two ways to make these changes, the alternate approach would be to 
only make the java changes and not split the upgrade xml files.  This would 
still allow new services to add themselves into the upgrade.  The benefit of 
this is that for the stack services you only have one upgrade xml file.  The 
problem with that is it is easier for a particular service to have 
unintentional changes between upgrade xml files.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
 7f7a49e 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
 8a7b42b 
  ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
f781574 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 
13d5047 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
5a18b3f 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
 88f6e19 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
43cefb9 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
 b860731 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
 3325469 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
 67d7fdb 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java
 5cda422 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
6b74af0 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
9fb2bba 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
1e040e6 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
e3bc7a3 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
6e27da6 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
d755516 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerMiscTest.java
 dda1e7a 
  
ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
 15be8b4 
  
ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/upgrades/HDP/2.2.0/upgrade_test_15388.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_15388.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/metainfo.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/repos/hdp.json
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/repos/repoinfo.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/repos/version-2.2.0.4-123.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/role_command_order.json
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/services/HDFS/metainfo.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/services/HDFS/upgrades/HDP/2.2.0/upgrade_test_15388.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/upgrades/config-upgrade.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/upgrades/upgrade_test_15388.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/45169/diff/


Testing
---

Manual testing so far.  I have the code read the upgrade xml and all of its 
service specific xml files, built the upgrade pack and then write the full 
upgrade xml to disk and then compare the results to the original upgrade xml.

This review is mostly for the design doc which is attached to the JIRA.  Not 
sure how to create a review board with a design doc instead of a patch file.


Thanks,

Tim Thorpe

Re: Review Request 47513: AMBARI-16723 Stack id needs to be handled differently according to its source

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47513/
---

(Updated May 18, 2016, 6:24 p.m.)


Review request for Ambari, Jaimin Jetly, Nate Cole, Richard Zang, Xi Wang, and 
Yusaku Sako.


Bugs: AMBARI-16723
https://issues.apache.org/jira/browse/AMBARI-16723


Repository: ambari


Description
---

For default stacks, stack id contains stack name and stack version, while for 
others, it should be "stack + "-" + stack_version + "-" + vdf_version"


Diffs (updated)
-

  ambari-web/app/controllers/installer.js 421f2dc 
  ambari-web/app/mappers/stack_mapper.js 473c466 

Diff: https://reviews.apache.org/r/47513/diff/


Testing
---

Local ambari-web test passed.
27819 tests complete (23 seconds)
154 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang

Re: Review Request 46950: AMBARI-16231: mapreduce.jobhistory.http.policy & mapreduce.jobhistory.webapp.https.address property are not respected

[Vishal Ghugare]

> On May 18, 2016, 1:40 a.m., Dmytro Sen wrote:
> > Ship It!

Thank you so much Dmytro! I would really appreciate if you can commit these 
changes on my behalf to trunk ( I am not a committer).Thanks again.


- Vishal


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46950/#review133710
---


On May 17, 2016, 11:25 a.m., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46950/
> ---
> 
> (Updated May 17, 2016, 11:25 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen and Sid Wagle.
> 
> 
> Bugs: AMBARI-16231
> https://issues.apache.org/jira/browse/AMBARI-16231
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari 2.2:
> Configure SSL for MapReduce by setting these properties in mapred-site.xml
> mapreduce.jobhistory.http.policy=HTTPS_ONLY
> mapreduce.jobhistory.webapp.https.address=host:https_port
> These properties are not respected and as a result JMX uses http protocol 
> instead of https.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  55e49d9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
>  a5700a9 
> 
> Diff: https://reviews.apache.org/r/46950/diff/
> 
> 
> Testing
> ---
> 
> One new test added to JMXHostProviderTest
> 
> 
> Thanks,
> 
> Vishal Ghugare
> 
>

Re: Review Request 47459: ADLS as default FS is not supported for any views

[Chris Nauroth]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47459/#review133776
---




contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/ValidatorUtils.java
 (line 32)


This isn't directly related to this patch, but you might want to be aware 
that there are other schemes for S3-backed file system implementations.  In 
addition to "s3", Hadoop also has "s3n" and "s3a".  There are more details here:

http://hadoop.apache.org/docs/r2.7.2/hadoop-aws/tools/hadoop-aws/index.html



contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
 (line 268)


It looks like Ambari is relying on the scheme name to detect the default 
file system.  This pattern is already in place in the `configureWASB` method.  
Just FYI, Hadoop supports configuration flexibility so that a different scheme 
name maps to the file system implementation.  For example, someone could 
theoretically configure "myadl" to map to the `AdlFileSystem` class, and then 
this detection logic wouldn't work.  This is an edge case though and probably 
not something that needs to be addressed within the scope of this patch.


- Chris Nauroth


On May 17, 2016, 2:58 p.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47459/
> ---
> 
> (Updated May 17, 2016, 2:58 p.m.)
> 
> 
> Review request for Ambari, Chris Nauroth, DIPAYAN BHOWMICK, Nitiraj Rathore, 
> Pallav Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16706
> https://issues.apache.org/jira/browse/AMBARI-16706
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added adl related properties
> 
> 
> Diffs
> -
> 
>   contrib/views/utils/pom.xml c15afad 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/ambari/ValidatorUtils.java
>  c936355 
>   
> contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java
>  8b45cd6 
> 
> Diff: https://reviews.apache.org/r/47459/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/#review133779
---




ambari-common/src/main/python/resource_management/libraries/script/script.py 
(line 661)


No need to check for None.

Is there already a Jira to track the fix for the pid for Ranger?


- Alejandro Fernandez


On May 18, 2016, 11:59 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47529/
> ---
> 
> (Updated May 18, 2016, 11:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16727
> https://issues.apache.org/jira/browse/AMBARI-16727
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding sleep time of 15 seconds after execution of stop command as Ranger 
> Admin process requires time to stop. Once the logic for pid is available from 
> Ranger code, will update the code.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> cbf313e 
>   ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 
> 98a0b38 
> 
> Diff: https://reviews.apache.org/r/47529/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger on centos 6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 47531: Ambari APIs should allow using case insensitive host names

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47531/#review133773
---



Which use cases were tested? E.g.,

1. Add a host with name foo
2. Attempt to readd a host with name FOO (should not allow this).
3. Query the host components of a host with name Foo
4. Delete a host with name fOO (should allow this)

For the deletion, can use two different APIs,
DELETE api/v1/clusters/$cluster_name/hosts/$name
DELETE api/v1/hosts/$name

I also remember that in MasterHostResolver.java we compared some hostnames, and 
it should be case-insensitive.

- Alejandro Fernandez


On May 18, 2016, 10 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47531/
> ---
> 
> (Updated May 18, 2016, 10 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Nate Cole, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari stores all hostnames in lower-case irrespective of the case in name 
> associated with the host. While this is OK for internal usage it causes 
> confusion to the users or the tools that look up hostname using standard 
> commands such as"hostname -f".
> The API should be modified to allow hostnames in case insensitive fashion. 
> E.g.
> api/v1/hosts/HostA and api/v1/hosts/hosta both should point to the same host
> calls that user filter where they specify hostnames should also allow case 
> insensitive comparison
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java
>  3af90ba 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  9c864b6 
> 
> Diff: https://reviews.apache.org/r/47531/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 47545: Rename atlas lineage configurations

[Tom Beerbower]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47545/
---

Review request for Ambari, Erik Bergenholtz and John Speidel.


Bugs: AMBARI-16730
https://issues.apache.org/jira/browse/AMBARI-16730


Repository: ambari


Description
---

As part of ATLAS-713, the following changes are required in atlas configuration 
that is set by Ambari:

1 atlas.lineage.hive.table.schema.query.Table renamed to 
atlas.lineage.schema.query.Table
2 atlas.lineage.hive.table.schema.query.hive_table renamed to 
atlas.lineage.schema.query.hive_table
3 delete unused lineage configs


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml
 2dab35a 

Diff: https://reviews.apache.org/r/47545/diff/


Testing
---

manual test Atlas install

mvn clean test


Thanks,

Tom Beerbower

Re: Review Request 47541: clean up import * for HBase service scripts in common-services

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47541/#review133772
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 18, 2016, 4:41 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47541/
> ---
> 
> (Updated May 18, 2016, 4:41 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16408
> https://issues.apache.org/jira/browse/AMBARI-16408
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for Hive service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase.py
>  d2f28f5 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_client.py
>  f35a570 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_decommission.py
>  022465a 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_master.py
>  840411f 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_regionserver.py
>  4001912 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_service.py
>  a6904f6 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/hbase_upgrade.py
>  2dc9883 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_windows.py
>  7d634cb 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/service_check.py
>  6ecb58e 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/upgrade.py
>  b1a19e6 
> 
> Diff: https://reviews.apache.org/r/47541/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> Hbase fresh installation and service check
> 
> Hadoop QA added a comment - 2 hours ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12803349/AMBARI-16408.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6878//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6878//console
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Review Request 47544: Storm REST metrics are not available when ui.port is changed

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47544/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-16742
https://issues.apache.org/jira/browse/AMBARI-16742


Repository: ambari


Description
---

**STR**:  
Change storm-site/ui.port

**Result**:  
Some metrics are unavailable in the Storm summary


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProvider.java
 c579705 
  ambari-server/src/main/resources/common-services/STORM/0.10.0/metrics.json 
3d0fdd3 
  ambari-server/src/main/resources/common-services/STORM/0.9.3/metrics.json 
2b46faf 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProviderTest.java
 de3bc82 

Diff: https://reviews.apache.org/r/47544/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 47475: clean up import * for Hive service scripts in common-services

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47475/#review133769
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 18, 2016, 4:48 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47475/
> ---
> 
> (Updated May 18, 2016, 4:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16189
> https://issues.apache.org/jira/browse/AMBARI-16189
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for Hive service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat.py
>  45dcbe7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
>  b37698e 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py
>  07b4095 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
>  da49450 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  e8532da 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
>  d0dd9bb 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py
>  851dc02 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py
>  8b98ed1 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_users.py
>  c023548 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_utils.py
>  5006b56 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_windows.py
>  880fdb5 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/service_check.py
>  f7304f7 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
>  3acbc7b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
>  34687c4 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py
>  c24db4c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
>  8e80d48 
> 
> Diff: https://reviews.apache.org/r/47475/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> HIVE fresh installation and service check
> 
> 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6869
> 
> 
> Hadoop QA added a comment - 8 minutes ago
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12802696/AMBARI-16189.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6869//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6869//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47477: clean up import * for HDFS service scripts in common-services

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47477/#review133767
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 18, 2016, 4:49 p.m., Juanjo  Marron wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47477/
> ---
> 
> (Updated May 18, 2016, 4:49 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.
> 
> 
> Bugs: AMBARI-16362
> https://issues.apache.org/jira/browse/AMBARI-16362
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Python code at at common-services level used generic imports form 
> resource_management (from resource_management import *)
> Ideally, for easier code tracking and performance, these import should be 
> more specific, such as: 
> from resource_management.libraries.script.script import Script
> from resource_management.core.resources.system import Directory
> This patch cleans up import * from resource_management for HDFS service 
> scripts in common-services
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
>  79c32e4 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py
>  1264284 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
>  d9b76b8 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_datanode.py
>  a22fb99 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py
>  500ed15 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
>  9c5a124 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
>  b37f413 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_windows.py
>  da00985 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py
>  737ae04 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
>  30eee07 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
>  ceee738 
> 
> Diff: https://reviews.apache.org/r/47477/diff/
> 
> 
> Testing
> ---
> 
> Pass mvn clean test -DskipSurefireTests
> HDFS fresh installation and service check
> Hadoop QA:
> -1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12803107/AMBARI-16362.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> -1 tests included. The patch doesn't appear to include any new or modified 
> tests.
> Please justify why no new tests are needed for this patch.
> Also please list what manual steps were performed to verify this patch.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in ambari-server.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6870//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/6870//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Juanjo  Marron
> 
>

Re: Review Request 47018: [preview] "ambari-server upgrade" shouldn't automatically add stack configs

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47018/
---

(Updated May 18, 2016, 8:11 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Nate Cole, and 
Sumit Mohanty.


Changes
---

As of now, a bit stuck trying to write correct path finding at 
ServicePropertiesTest .


Bugs: AMBARI-16272
https://issues.apache.org/jira/browse/AMBARI-16272


Repository: ambari


Description (updated)
---

Today, "ambari-server upgrade" will automatically add stack configs.
However, it also causes problems when default properties or properties with 
default value such as "localhost" end up being added.

This led to many bugs. E.g., cluster with NameNode HA shouldn't automatically 
add dfs.namenode.secondary.http-address

This logic today will even add new config types. E.g., add ranger-env even 
though Ranger is not installed. If the customer then upgrades the stack from 
HDP 2.2 to 2.3, and then adds Ranger, they can get the wrong configs.
If we change this behavior, it's good to do so in a major release such as 2.4

We add required xml tags/attributes to properties:

  prop_name
  prop_val
  
  



Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 fb3ae69 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackManager.java 
8a352bd 
  ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
854dd0b 
  ambari-server/src/main/java/org/apache/ambari/server/state/PropertyInfo.java 
34b3ba1 
  
ambari-server/src/main/java/org/apache/ambari/server/state/PropertyUpgradeBehavior.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
 2e857ed 
  ambari-server/src/main/resources/property-schema.xsd PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderHDP22Test.java
 a4a3108 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
 8f53f6a 
  
ambari-server/src/test/java/org/apache/ambari/server/state/PropertyInfoTest.java
 b11c5d8 
  
ambari-server/src/test/java/org/apache/ambari/server/state/ServicePropertiesTest.java
 PRE-CREATION 
  ambari-server/src/test/resources/propertiesFile.xsd PRE-CREATION 
  script.sh PRE-CREATION 

Diff: https://reviews.apache.org/r/47018/diff/


Testing
---

patch preview for now. Feedback is welcome


Thanks,

Dmitro Lisnichenko

Re: Review Request 47477: clean up import * for HDFS service scripts in common-services

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47477/
---

(Updated May 18, 2016, 4:49 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.


Bugs: AMBARI-16362
https://issues.apache.org/jira/browse/AMBARI-16362


Repository: ambari


Description
---

Python code at at common-services level used generic imports form 
resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This patch cleans up import * from resource_management for HDFS service scripts 
in common-services


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/datanode.py
 79c32e4 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py
 1264284 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_client.py
 d9b76b8 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_datanode.py
 a22fb99 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs_snamenode.py
 500ed15 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/journalnode.py
 9c5a124 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/namenode.py
 b37f413 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_windows.py
 da00985 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py
 737ae04 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/snamenode.py
 30eee07 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/utils.py
 ceee738 

Diff: https://reviews.apache.org/r/47477/diff/


Testing
---

Pass mvn clean test -DskipSurefireTests
HDFS fresh installation and service check
Hadoop QA:
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12803107/AMBARI-16362.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6870//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6870//console
This message is automatically generated.


Thanks,

Juanjo  Marron

Re: Review Request 47475: clean up import * for Hive service scripts in common-services

[Juanjo Marron]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47475/
---

(Updated May 18, 2016, 4:48 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, and Matt.


Bugs: AMBARI-16189
https://issues.apache.org/jira/browse/AMBARI-16189


Repository: ambari


Description
---

Python code at at common-services level used generic imports form 
resource_management (from resource_management import *)
Ideally, for easier code tracking and performance, these import should be more 
specific, such as: 
from resource_management.libraries.script.script import Script
from resource_management.core.resources.system import Directory
This patch cleans up import * from resource_management for Hive service scripts 
in common-services


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat.py
 45dcbe7 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_client.py
 b37698e 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hcat_service_check.py
 07b4095 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_client.py
 da49450 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 e8532da 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
 d0dd9bb 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_server.py
 851dc02 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_service.py
 8b98ed1 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_users.py
 c023548 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/mysql_utils.py
 5006b56 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_windows.py
 880fdb5 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/service_check.py
 f7304f7 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat.py
 3acbc7b 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_server.py
 34687c4 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service.py
 c24db4c 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/webhcat_service_check.py
 8e80d48 

Diff: https://reviews.apache.org/r/47475/diff/


Testing
---

Pass mvn clean test -DskipSurefireTests
HIVE fresh installation and service check


https://builds.apache.org/job/Ambari-trunk-test-patch/6869


Hadoop QA added a comment - 8 minutes ago
-1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12802696/AMBARI-16189.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified 
tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in ambari-server.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6869//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/6869//console
This message is automatically generated.


Thanks,

Juanjo  Marron

Review Request 47540: [Hive View]Unavailable Column Search should throw 'No Match' message

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47540/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.


Bugs: AMBARI-16738
https://issues.apache.org/jira/browse/AMBARI-16738


Repository: ambari


Description
---

Added a boolean variable for showing 'no columns match' alert.


Diffs
-

  
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/databases.js 
b76bca3 
  contrib/views/hive/src/main/resources/ui/hive-web/app/initializers/i18n.js 
d2f6aaf 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/databases-search-results.hbs
 007d9ca 

Diff: https://reviews.apache.org/r/47540/diff/


Testing
---

manually tested


Thanks,

Pallav Kulshreshtha

Re: Review Request 47480: AMBARI-16714: Pull 'Groups' txt shown on Alert details filters from the messages.js file

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47480/#review133758
---


Ship it!




Ship It!

- Alexandr Antonenko


On May 17, 2016, 6:17 p.m., Di Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47480/
> ---
> 
> (Updated May 17, 2016, 6:17 p.m.)
> 
> 
> Review request for Ambari and Alexandr Antonenko.
> 
> 
> Bugs: AMBARI-16714
> https://issues.apache.org/jira/browse/AMBARI-16714
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Pull 'Groups' txt shown on Alert details filters from the messages.js file, 
> it's currently a hardcoded label in the view code.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/main/alert_definitions_view.js b65b8cf 
> 
> Diff: https://reviews.apache.org/r/47480/diff/
> 
> 
> Testing
> ---
> 
> Manually patch a trunk cluster with UI change, verify the label is displayed 
> correctly.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Re: Review Request 47539: View display name spills to next line for HUETOAMBARI_MIGRATION

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47539/#review133757
---


Ship it!




Ship It!

- Alexandr Antonenko


On May 18, 2016, 3:59 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47539/
> ---
> 
> (Updated May 18, 2016, 3:59 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and DIPAYAN BHOWMICK.
> 
> 
> Bugs: AMBARI-16404
> https://issues.apache.org/jira/browse/AMBARI-16404
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the latest trunk code, the HUETOAMBARI_MIGRATION view name  spills over 
> to the next line.
> 
> Fix involves changing the css class for the view name column to col-sm-4 and 
> changing css class for first column of view instance row to 
> col-sm-3;padding-left-30
> 
> 
> Diffs
> -
> 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
>  906eef5 
> 
> Diff: https://reviews.apache.org/r/47539/diff/
> 
> 
> Testing
> ---
> 
> Manual testing.
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Review Request 47539: View display name spills to next line for HUETOAMBARI_MIGRATION

[Sangeeta Ravindran]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47539/
---

Review request for Ambari, Alexandr Antonenko and DIPAYAN BHOWMICK.


Bugs: AMBARI-16404
https://issues.apache.org/jira/browse/AMBARI-16404


Repository: ambari


Description
---

With the latest trunk code, the HUETOAMBARI_MIGRATION view name  spills over to 
the next line.

Fix involves changing the css class for the view name column to col-sm-4 and 
changing css class for first column of view instance row to 
col-sm-3;padding-left-30


Diffs
-

  
ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/listTable.html
 906eef5 

Diff: https://reviews.apache.org/r/47539/diff/


Testing
---

Manual testing.


Thanks,

Sangeeta Ravindran

Re: Review Request 47538: HDFS data disk mount point permissions

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47538/#review133752
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On May 18, 2016, 6:23 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47538/
> ---
> 
> (Updated May 18, 2016, 6:23 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-16735
> https://issues.apache.org/jira/browse/AMBARI-16735
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> You can't change the ownership of the datanode data mount points to
> hdfs:hadoop before beginning the installation as the user and group won't
> exist, they're created by the rpm's deployed by ambari.
> 
> You could create the user/group yourself and then set the ownership but that
> kind of defeats the purpose of having ambari and the agents to perform that
> task for you.
> 
> Would be nice if Ambari could chmod dfs.datanode.data.dir during install.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/resource_management/TestDatanodeHelper.py 
> 4a1a1ba 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/dfs_datanode_helper.py
>  33e7b41 
> 
> Diff: https://reviews.apache.org/r/47538/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 47514: Kerberos wizard gets reset and does not remember selections/data entered in previous step when you click on Back

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47514/#review133754
---




ambari-web/app/controllers/main/admin/kerberos/step1_controller.js (line 130)


Please use setEach

options.forEach(function (option) {
  option.preConditions.setEach('checked', false)
})


- Alexandr Antonenko


On May 18, 2016, 5:21 a.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47514/
> ---
> 
> (Updated May 18, 2016, 5:21 a.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Di Li.
> 
> 
> Bugs: AMBARI-15951
> https://issues.apache.org/jira/browse/AMBARI-15951
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Navigate to Admin->Kerberos. Click on Enable Kerberos.
> 2. In the wizard, select Existing Active Directory for e.g.
> 3. Check all the pre-requisites.
> 4. Click on Next to get to the Configure Kerberos page.
> 5. Click on Back.
> 6. The type of KDC radio button gets reset to Existing MIT KDC.
> 7. Same thing happens if you Navigate to Install and Test Kerberos Client 
> page and navigate back to the second or first page of the wizard.
> 
> Expected results:
> Like other wizards such as Add Service Wizard, the wizard should remember 
> selections/data when navigating back in the wizard.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/main/admin/kerberos/step1_controller.js 7f561dd 
>   ambari-web/app/views/main/admin/kerberos/step1_view.js 2e7c4cf 
>   ambari-web/test/controllers/main/admin/kerberos/step1_controller_test.js 
> 280f923 
> 
> Diff: https://reviews.apache.org/r/47514/diff/
> 
> 
> Testing
> ---
> 
> Ran mvn test
> 27719 tests complete (32 seconds)
> 154 tests pending
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Review Request 47538: HDFS data disk mount point permissions

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47538/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-16735
https://issues.apache.org/jira/browse/AMBARI-16735


Repository: ambari


Description
---

You can't change the ownership of the datanode data mount points to
hdfs:hadoop before beginning the installation as the user and group won't
exist, they're created by the rpm's deployed by ambari.

You could create the user/group yourself and then set the ownership but that
kind of defeats the purpose of having ambari and the agents to perform that
task for you.

Would be nice if Ambari could chmod dfs.datanode.data.dir during install.


Diffs
-

  ambari-agent/src/test/python/resource_management/TestDatanodeHelper.py 
4a1a1ba 
  
ambari-common/src/main/python/resource_management/libraries/functions/dfs_datanode_helper.py
 33e7b41 

Diff: https://reviews.apache.org/r/47538/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 47537: View log files should pickup ambari-server log directory path

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47537/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-16734
https://issues.apache.org/jira/browse/AMBARI-16734


Repository: ambari


Description
---

Earlier : views had to hardcode the log directory as the variable 
ambari.log.dir was not available inside view.log4j.properties file.

In this patch : view.log4j.properties of view can now use all the ambari 
properties including ambari.log.dir of ambari's log4j.properties


Diffs
-

  ambari-server/src/main/java/org/apache/ambari/server/view/ViewRegistry.java 
6d4ef82 

Diff: https://reviews.apache.org/r/47537/diff/


Testing
---

manual testing done.


Thanks,

Nitiraj Rathore

Re: Review Request 47456: Takeover config merge should handle AMS hbase configs

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47456/
---

(Updated May 18, 2016, 3:06 p.m.)


Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.


Bugs: AMBARI-16703
https://issues.apache.org/jira/browse/AMBARI-16703


Repository: ambari


Description
---

hbase-site conflicts between cluster and AMS.

Hard code the config path as /etc/ams-hbase/conf to be AMS HBase configs.


Diffs (updated)
-

  ambari-server/src/main/resources/scripts/takeover_config_merge.py f940f27 
  ambari-server/src/main/resources/scripts/takeover_files_mapping.json 
PRE-CREATION 

Diff: https://reviews.apache.org/r/47456/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 47456: Takeover config merge should handle AMS hbase configs

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47456/
---

(Updated May 18, 2016, 2:58 p.m.)


Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi.


Bugs: AMBARI-16703
https://issues.apache.org/jira/browse/AMBARI-16703


Repository: ambari


Description
---

hbase-site conflicts between cluster and AMS.

Hard code the config path as /etc/ams-hbase/conf to be AMS HBase configs.


Diffs (updated)
-

  ambari-server/src/main/resources/scripts/takeover_config_merge.py f940f27 
  ambari-server/src/main/resources/scripts/takeover_files_mapping.json 
PRE-CREATION 

Diff: https://reviews.apache.org/r/47456/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 47488: Ambari copies jdbc driver jar into hadoop/lib and haoop-yarn/lib

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47488/
---

(Updated Травень 18, 2016, 2:56 після полудня)


Review request for Ambari, Andrew Onischuk, Mugdha Varadkar, and Sumit Mohanty.


Bugs: AMBARI-16716
https://issues.apache.org/jira/browse/AMBARI-16716


Repository: ambari


Description
---

PROBLEM:
Ambari copies the jdbc driver (be it mysql or oracle) into 
/usr/hdp/xxx/hadoop/lib and /usr/hdp/xxx/hadoop-yarn/lib, this can cause 
problem for hive and other components, as user updates the jar inside 
/usr/hdp/xx/hive/lib, but those on the hadoop and yarn lib are also in the 
classpath.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin.py
 3eb8591 
  
ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py
 d653000 
  ambari-server/conf/unix/ambari.properties 239a731 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 bf11bf6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
 bb58670 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 5e51f5f 
  ambari-server/src/main/python/ambari_server/serverSetup.py 217d988 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py
 32a36a7 
  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/setup_ranger_hbase.py
 1e860d9 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/params_linux.py
 784da9c 
  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/setup_ranger_hdfs.py
 f660562 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 30ffc8f 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service.py
 d0dd9bb 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
 daf0301 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 9f5d799 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/setup_ranger_hive.py
 7515e9b 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py
 37bd77c 
  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/setup_ranger_kafka.py
 3a3ecfe 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py
 d1268a1 
  
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/setup_ranger_knox.py
 64e2060 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py
 d69339e 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
 3060353 
  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 75924c5 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py
 658e69f 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py
 799447b 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 9fc0971 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/setup_ranger_storm.py
 1dd85e9 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 3306cf2 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/setup_ranger_yarn.py
 1f61d41 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
 8fc1a64 

Diff: https://reviews.apache.org/r/47488/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

[Nate Cole]

> On May 17, 2016, 10:30 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java,
> >  lines 890-892
> > 
> >
> > Really need to throw here or just log it and continue; ?
> 
> Tim Thorpe wrote:
> When the StackManager encounters errors while reading the stack, it 
> almost always ends up throwing an exception and ambari-server fails to start. 
>  I'm ok with just logging the issue for this and other errors but then you 
> could think that everything is fine with the service specific upgrade xml 
> unless you dig through the log.
> 
> Nate Cole wrote:
> That's true, but in this case you aren't bound by reading the stack per 
> se, you're acting on the applicability of an XML element.  This is happening 
> in mergeServiceCheckGrouping, implying you're only considering 
> ServiceCheckGroupings anyway.
> 
> If we actually used XSD (I have a future work-item for that) then sure, 
> that could cause failure of stack.  But in this case, I think a simple no-op 
> continue; is fine.
> 
> Tim Thorpe wrote:
> Jayush suggested that I needed to make sure when merging groups that all 
> the groups were of the same type.  So this applies to regular Grouping, 
> ClusterGrouping, ServiceCheckGrouping, etc...
> 
>   List list = allGroupMap.get(group.name);
>   if (list.size() > 0) {
> Grouping first = list.get(0);
> if (!first.getClass().equals(group.getClass())) {
>   throw new AmbariException("Expected class: " + 
> first.getClass() + " instead of " + group.getClass());
> }
>   }
>   allGroupMap.get(group.name).add(group);
> 
> Basically with the above code, the logging would never occur when merging 
> ServiceCheckGroupings.  Do you think the above code should just log as well 
> or is it more critical because it applies to groups other than 
> ServiceCheckGroupings?

Is that a bit restrictive?  It means you can't add a ServiceCheckGrouping right 
after a "regular" Grouping?  I might be missing the point.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review133533
---


On May 18, 2016, 9:19 a.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45169/
> ---
> 
> (Updated May 18, 2016, 9:19 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush 
> Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-15388
> https://issues.apache.org/jira/browse/AMBARI-15388
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the upgrade is defined as a series of xml files specific to the 
> current stack version and the target stack version. Each upgrade xml defines 
> the overall sequence of the upgrade and what needs to be done for each 
> service. It would both easier to maintain and easier to add new services, if 
> the services themselves could specify what should be done during their 
> upgrade.
> 
> There are two ways to make these changes, the alternate approach would be to 
> only make the java changes and not split the upgrade xml files.  This would 
> still allow new services to add themselves into the upgrade.  The benefit of 
> this is that for the stack services you only have one upgrade xml file.  The 
> problem with that is it is easier for a particular service to have 
> unintentional changes between upgrade xml files.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  7f7a49e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  8a7b42b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> f781574 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java
>  13d5047 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 5a18b3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  88f6e19 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 43cefb9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
>  b860731 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
>  3325469 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
>  67d7fdb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java
>  5cda422 
>   

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

[Tim Thorpe]

> On May 17, 2016, 2:30 p.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java,
> >  lines 890-892
> > 
> >
> > Really need to throw here or just log it and continue; ?
> 
> Tim Thorpe wrote:
> When the StackManager encounters errors while reading the stack, it 
> almost always ends up throwing an exception and ambari-server fails to start. 
>  I'm ok with just logging the issue for this and other errors but then you 
> could think that everything is fine with the service specific upgrade xml 
> unless you dig through the log.
> 
> Nate Cole wrote:
> That's true, but in this case you aren't bound by reading the stack per 
> se, you're acting on the applicability of an XML element.  This is happening 
> in mergeServiceCheckGrouping, implying you're only considering 
> ServiceCheckGroupings anyway.
> 
> If we actually used XSD (I have a future work-item for that) then sure, 
> that could cause failure of stack.  But in this case, I think a simple no-op 
> continue; is fine.

Jayush suggested that I needed to make sure when merging groups that all the 
groups were of the same type.  So this applies to regular Grouping, 
ClusterGrouping, ServiceCheckGrouping, etc...

  List list = allGroupMap.get(group.name);
  if (list.size() > 0) {
Grouping first = list.get(0);
if (!first.getClass().equals(group.getClass())) {
  throw new AmbariException("Expected class: " + first.getClass() + 
" instead of " + group.getClass());
}
  }
  allGroupMap.get(group.name).add(group);

Basically with the above code, the logging would never occur when merging 
ServiceCheckGroupings.  Do you think the above code should just log as well or 
is it more critical because it applies to groups other than 
ServiceCheckGroupings?


- Tim


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review133533
---


On May 18, 2016, 1:19 p.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45169/
> ---
> 
> (Updated May 18, 2016, 1:19 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush 
> Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-15388
> https://issues.apache.org/jira/browse/AMBARI-15388
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the upgrade is defined as a series of xml files specific to the 
> current stack version and the target stack version. Each upgrade xml defines 
> the overall sequence of the upgrade and what needs to be done for each 
> service. It would both easier to maintain and easier to add new services, if 
> the services themselves could specify what should be done during their 
> upgrade.
> 
> There are two ways to make these changes, the alternate approach would be to 
> only make the java changes and not split the upgrade xml files.  This would 
> still allow new services to add themselves into the upgrade.  The benefit of 
> this is that for the stack services you only have one upgrade xml file.  The 
> problem with that is it is easier for a particular service to have 
> unintentional changes between upgrade xml files.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  7f7a49e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  8a7b42b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> f781574 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java
>  13d5047 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 5a18b3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  88f6e19 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 43cefb9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
>  b860731 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
>  3325469 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
>  67d7fdb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java
>  5cda422 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 6b74af0 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 9fb2bba 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

[Nate Cole]

> On May 17, 2016, 10:30 a.m., Nate Cole wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java,
> >  lines 890-892
> > 
> >
> > Really need to throw here or just log it and continue; ?
> 
> Tim Thorpe wrote:
> When the StackManager encounters errors while reading the stack, it 
> almost always ends up throwing an exception and ambari-server fails to start. 
>  I'm ok with just logging the issue for this and other errors but then you 
> could think that everything is fine with the service specific upgrade xml 
> unless you dig through the log.

That's true, but in this case you aren't bound by reading the stack per se, 
you're acting on the applicability of an XML element.  This is happening in 
mergeServiceCheckGrouping, implying you're only considering 
ServiceCheckGroupings anyway.

If we actually used XSD (I have a future work-item for that) then sure, that 
could cause failure of stack.  But in this case, I think a simple no-op 
continue; is fine.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/#review133533
---


On May 18, 2016, 9:19 a.m., Tim Thorpe wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45169/
> ---
> 
> (Updated May 18, 2016, 9:19 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush 
> Luniya, and Nate Cole.
> 
> 
> Bugs: AMBARI-15388
> https://issues.apache.org/jira/browse/AMBARI-15388
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently the upgrade is defined as a series of xml files specific to the 
> current stack version and the target stack version. Each upgrade xml defines 
> the overall sequence of the upgrade and what needs to be done for each 
> service. It would both easier to maintain and easier to add new services, if 
> the services themselves could specify what should be done during their 
> upgrade.
> 
> There are two ways to make these changes, the alternate approach would be to 
> only make the java changes and not split the upgrade xml files.  This would 
> still allow new services to add themselves into the upgrade.  The benefit of 
> this is that for the stack services you only have one upgrade xml file.  The 
> problem with that is it is easier for a particular service to have 
> unintentional changes between upgrade xml files.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
>  7f7a49e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
>  8a7b42b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
> f781574 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java
>  13d5047 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 5a18b3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
>  88f6e19 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
> 43cefb9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
>  b860731 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
>  3325469 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
>  67d7fdb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java
>  5cda422 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 6b74af0 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> 9fb2bba 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 1e040e6 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> e3bc7a3 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> 6e27da6 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> d755516 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerMiscTest.java
>  dda1e7a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
>  15be8b4 
>   
> ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/upgrades/HDP/2.2.0/upgrade_test_15388.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_15388.xml
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/metainfo.xml
>  PRE-CREATION 
>   
> 

Review Request 47535: Splitting command output or component's .out before logging to ambari-agent log

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47535/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-16732
https://issues.apache.org/jira/browse/AMBARI-16732


Repository: ambari


Description
---


Diffs
-

  ambari-agent/src/main/python/ambari_agent/ActionQueue.py 85389f9 
  ambari-common/src/main/python/ambari_commons/str_utils.py 83fc29d 

Diff: https://reviews.apache.org/r/47535/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 47535: Splitting command output or component's .out before logging to ambari-agent log

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47535/#review133733
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On May 18, 2016, 4:37 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47535/
> ---
> 
> (Updated May 18, 2016, 4:37 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-16732
> https://issues.apache.org/jira/browse/AMBARI-16732
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/ActionQueue.py 85389f9 
>   ambari-common/src/main/python/ambari_commons/str_utils.py 83fc29d 
> 
> Diff: https://reviews.apache.org/r/47535/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 47498: Knox Gateway Uses Wrong Keystore After Upgrade

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47498/#review133731
---


Ship it!




Ship It!

- Nate Cole


On May 17, 2016, 6:35 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47498/
> ---
> 
> (Updated May 17, 2016, 6:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-16717
> https://issues.apache.org/jira/browse/AMBARI-16717
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When upgrading Knox, the {{data}} directory and its security artifacts are 
> not copied over to the "versioned" data directory. This causes the 
> {{gateway.jks}} keystore to be automatically re-generated. If the 
> installation was using a custom keystore/certificate, then this will cause 
> connections to be rejected after a successful startup. 
> 
> {code:title=Knox 2.2 -> 2.3.0.0}
> /usr/hdp/current/knox-server/data -> /var/lib/knox/data
> {code}
> 
> {code:title=Knox 2.3.2.0+}
> /usr/hdp/current/knox-server/data -> /var/lib/knox/data-2.3.2.0-1234
> {code}
> 
> As a result, after upgrading the {{/var/lib/knox/data-2.3.2.0-1234}} does not 
> contain any of the security artifacts from the prior version.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server_upgrade.py
>  8eca96c 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
>  4d72463 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_upgrade.py
>  64c0032 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
>  e5e4103 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py
>  63949f8 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  fcce418 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
>  28d2991 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml
>  5f0c6aa 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
>  cf79368 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  fab12c8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  1887414 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  469f2e7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  56cd6d0 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 6b74af0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  29ebeff 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  7d67f8e 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> e3bc7a3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  5616cb4 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> d755516 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 
> ef97d20 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 6dfb609 
>   ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py fbc55ca 
> 
> Diff: https://reviews.apache.org/r/47498/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> Verified that an upgrade copies the data directory and that Knox starts up on 
> the custom keystore.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 45169: AMBARI-15388 - Upgrade XML should be pushed down as much as possible to the services

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45169/
---

(Updated May 18, 2016, 1:19 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Jayush Luniya, 
and Nate Cole.


Changes
---

The new patch still has the following remaining items that need answers:

1) It still throws exceptions rather than logging issues.  This is consistent 
with how the StackManager deals with things in the stack that don't work.  
Waiting for Nate's response on the issue he opened.

2) The after tag still is multi purpose.  It orders a new group among the 
original groups and a new stage/priority/service among the existing ones in an 
original group.  The only unsupported use cases is to add a new group in a 
service upgrade xml file that will be added to in another service's upgrade xml 
file.  The correct approach would be to use different groups OR to add the 
group in the stack upgrade xml file.  Waiting for Jayush's response on that.


Bugs: AMBARI-15388
https://issues.apache.org/jira/browse/AMBARI-15388


Repository: ambari


Description
---

Currently the upgrade is defined as a series of xml files specific to the 
current stack version and the target stack version. Each upgrade xml defines 
the overall sequence of the upgrade and what needs to be done for each service. 
It would both easier to maintain and easier to add new services, if the 
services themselves could specify what should be done during their upgrade.

There are two ways to make these changes, the alternate approach would be to 
only make the java changes and not split the upgrade xml files.  This would 
still allow new services to add themselves into the upgrade.  The benefit of 
this is that for the stack services you only have one upgrade xml file.  The 
problem with that is it is easier for a particular service to have 
unintentional changes between upgrade xml files.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java
 7f7a49e 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java
 8a7b42b 
  ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java 
f781574 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackDirectory.java 
13d5047 
  ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
5a18b3f 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java
 88f6e19 
  ambari-server/src/main/java/org/apache/ambari/server/state/ServiceInfo.java 
43cefb9 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/UpgradePack.java
 b860731 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ClusterGrouping.java
 3325469 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/Grouping.java
 67d7fdb 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/upgrade/ServiceCheckGrouping.java
 5cda422 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
6b74af0 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
9fb2bba 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
1e040e6 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
e3bc7a3 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
6e27da6 
  ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
d755516 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/StackManagerMiscTest.java
 dda1e7a 
  
ambari-server/src/test/java/org/apache/ambari/server/state/stack/UpgradePackTest.java
 15be8b4 
  
ambari-server/src/test/resources/stacks/HDP/2.0.5/services/HDFS/upgrades/HDP/2.2.0/upgrade_test_15388.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks/HDP/2.2.0/upgrades/upgrade_test_15388.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/metainfo.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/repos/hdp.json
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/repos/repoinfo.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/repos/version-2.2.0.4-123.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/role_command_order.json
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/services/HDFS/metainfo.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/services/HDFS/upgrades/HDP/2.2.0/upgrade_test_15388.xml
 PRE-CREATION 
  
ambari-server/src/test/resources/stacks_with_upgrade_cycle/HDP/2.2.0/upgrades/config-upgrade.xml
 PRE-CREATION 
  

Re: Review Request 47498: Knox Gateway Uses Wrong Keystore After Upgrade

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47498/#review133728
---




ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py
 (lines 89 - 90)


This is an odd statement - typically would be os.path.join({stack_root}, 
{upgrade_from_version}, 'knox', 'data', '.')

Also, target_data_dir could use os.path.join.


- Nate Cole


On May 17, 2016, 6:35 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47498/
> ---
> 
> (Updated May 17, 2016, 6:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Nate Cole.
> 
> 
> Bugs: AMBARI-16717
> https://issues.apache.org/jira/browse/AMBARI-16717
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When upgrading Knox, the {{data}} directory and its security artifacts are 
> not copied over to the "versioned" data directory. This causes the 
> {{gateway.jks}} keystore to be automatically re-generated. If the 
> installation was using a custom keystore/certificate, then this will cause 
> connections to be rejected after a successful startup. 
> 
> {code:title=Knox 2.2 -> 2.3.0.0}
> /usr/hdp/current/knox-server/data -> /var/lib/knox/data
> {code}
> 
> {code:title=Knox 2.3.2.0+}
> /usr/hdp/current/knox-server/data -> /var/lib/knox/data-2.3.2.0-1234
> {code}
> 
> As a result, after upgrading the {{/var/lib/knox/data-2.3.2.0-1234}} does not 
> contain any of the security artifacts from the prior version.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon_server_upgrade.py
>  8eca96c 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_handler.py
>  4d72463 
>   
> ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/flume_upgrade.py
>  64c0032 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox_gateway.py
>  e5e4103 
>   
> ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/upgrade.py
>  63949f8 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server.py
>  fcce418 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_server_upgrade.py
>  28d2991 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.2.xml
>  5f0c6aa 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.3.xml
>  cf79368 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/upgrades/nonrolling-upgrade-2.4.xml
>  fab12c8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml
>  1887414 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml
>  469f2e7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  56cd6d0 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 
> 6b74af0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.4.xml
>  29ebeff 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  7d67f8e 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 
> e3bc7a3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.5.xml
>  5616cb4 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.5.xml 
> d755516 
>   ambari-server/src/test/python/stacks/2.0.6/OOZIE/test_oozie_server.py 
> ef97d20 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 6dfb609 
>   ambari-server/src/test/python/stacks/2.2/KNOX/test_knox_gateway.py fbc55ca 
> 
> Diff: https://reviews.apache.org/r/47498/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> Verified that an upgrade copies the data directory and that Knox starts up on 
> the custom keystore.
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/#review133726
---


Ship it!




Ship It!

- Andrew Onischuk


On May 18, 2016, 11:59 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47529/
> ---
> 
> (Updated May 18, 2016, 11:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16727
> https://issues.apache.org/jira/browse/AMBARI-16727
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding sleep time of 15 seconds after execution of stop command as Ranger 
> Admin process requires time to stop. Once the logic for pid is available from 
> Ranger code, will update the code.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/script/script.py 
> cbf313e 
>   ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 
> 98a0b38 
> 
> Diff: https://reviews.apache.org/r/47529/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger on centos 6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/
---

(Updated May 18, 2016, 11:59 a.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam Borad, 
Jayush Luniya, and Velmurugan Periasamy.


Changes
---

Address Andrew Onishuk comment For adding service_name=="RANGER" check in 
script.py for calling self.status(env)


Bugs: AMBARI-16727
https://issues.apache.org/jira/browse/AMBARI-16727


Repository: ambari


Description
---

Adding sleep time of 15 seconds after execution of stop command as Ranger Admin 
process requires time to stop. Once the logic for pid is available from Ranger 
code, will update the code.


Diffs (updated)
-

  ambari-common/src/main/python/resource_management/libraries/script/script.py 
cbf313e 
  ambari-server/src/test/python/stacks/2.2/RANGER/test_ranger_usersync.py 
98a0b38 

Diff: https://reviews.apache.org/r/47529/diff/


Testing
---

Tested Ranger on centos 6


Thanks,

Mugdha Varadkar

Re: Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU

[Andrew Onischuk]

> On May 18, 2016, 10:27 a.m., Andrew Onischuk wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py,
> >  line 56
> > 
> >
> > Can we monitor self.status until the stop is done. Or skip the check in 
> > script.py.
> > 
> > This we be a major slownload for 'Stop all' considering it takes ~40s 
> > as of now.

Another solution is to skip that check in script.py if service_name=="RANGER". 
If that is acceptable to stop afterwards Ambari stop command.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/#review133721
---


On May 18, 2016, 10:22 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47529/
> ---
> 
> (Updated May 18, 2016, 10:22 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16727
> https://issues.apache.org/jira/browse/AMBARI-16727
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding sleep time of 15 seconds after execution of stop command as Ranger 
> Admin process requires time to stop. Once the logic for pid is available from 
> Ranger code, will update the code.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
>  1ffbbde 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  c015367 
> 
> Diff: https://reviews.apache.org/r/47529/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger on centos 6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/#review133721
---




ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
 (line 56)


Can we monitor self.status until the stop is done. Or skip the check in 
script.py.

This we be a major slownload for 'Stop all' considering it takes ~40s as of 
now.


- Andrew Onischuk


On May 18, 2016, 10:22 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47529/
> ---
> 
> (Updated May 18, 2016, 10:22 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam 
> Borad, Jayush Luniya, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16727
> https://issues.apache.org/jira/browse/AMBARI-16727
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Adding sleep time of 15 seconds after execution of stop command as Ranger 
> Admin process requires time to stop. Once the logic for pid is available from 
> Ranger code, will update the code.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
>  1ffbbde 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
>  c015367 
> 
> Diff: https://reviews.apache.org/r/47529/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger on centos 6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Review Request 47529: AMBARI-16727 Add sleep time after stop of Ranger Admin for better handling of EU

[Mugdha Varadkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47529/
---

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam Borad, 
Jayush Luniya, and Velmurugan Periasamy.


Bugs: AMBARI-16727
https://issues.apache.org/jira/browse/AMBARI-16727


Repository: ambari


Description
---

Adding sleep time of 15 seconds after execution of stop command as Ranger Admin 
process requires time to stop. Once the logic for pid is available from Ranger 
code, will update the code.


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
 1ffbbde 
  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py
 c015367 

Diff: https://reviews.apache.org/r/47529/diff/


Testing
---

Tested Ranger on centos 6


Thanks,

Mugdha Varadkar

Review Request 47531: Ambari APIs should allow using case insensitive host names

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47531/
---

Review request for Ambari, Dmytro Sen, Nate Cole, Sumit Mohanty, and Sid Wagle.


Repository: ambari


Description
---

Ambari stores all hostnames in lower-case irrespective of the case in name 
associated with the host. While this is OK for internal usage it causes 
confusion to the users or the tools that look up hostname using standard 
commands such as"hostname -f".
The API should be modified to allow hostnames in case insensitive fashion. E.g.
api/v1/hosts/HostA and api/v1/hosts/hosta both should point to the same host
calls that user filter where they specify hostnames should also allow case 
insensitive comparison


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/predicate/QueryParser.java
 3af90ba 
  
ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
 9c864b6 

Diff: https://reviews.apache.org/r/47531/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 47428: Changes to Phoenix QueryServer Kerberos configuration

[Robert Levas]

> On May 18, 2016, 5:13 a.m., Robert Levas wrote:
> > Ship It!

We should also have jhurly and/or ncole review as well to get more eyes on this.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47428/#review133713
---


On May 17, 2016, 11:09 p.m., Josh Elser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47428/
> ---
> 
> (Updated May 17, 2016, 11:09 p.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-16171
> https://issues.apache.org/jira/browse/AMBARI-16171
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The up-coming version of Phoenix will contain some new functionality to 
> support Kerberos authentication of clients via SPNEGO with the Phoenix Query 
> Server (PQS).
> 
> Presently, Ambari will configure PQS to use the hbase service keytab which 
> will result in the SPNEGO authentication failing as the RFC requires that the 
> "primary" component of the Kerberos principal for the server is "HTTP". Thus, 
> we need to ensure that we switch PQS over to use the spnego.service.keytab as 
> the keytab and "HTTP/_HOST@REALM" as the principal.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  2e857ed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  41f538e 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
>  c9536f8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  20fa50f 
> 
> Diff: https://reviews.apache.org/r/47428/diff/
> 
> 
> Testing
> ---
> 
> Unit testing, still working through a "real" Ambari upgrade
> 
> 
> Thanks,
> 
> Josh Elser
> 
>

Re: Review Request 47428: Changes to Phoenix QueryServer Kerberos configuration

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47428/#review133713
---


Ship it!




Ship It!

- Robert Levas


On May 17, 2016, 11:09 p.m., Josh Elser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47428/
> ---
> 
> (Updated May 17, 2016, 11:09 p.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-16171
> https://issues.apache.org/jira/browse/AMBARI-16171
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The up-coming version of Phoenix will contain some new functionality to 
> support Kerberos authentication of clients via SPNEGO with the Phoenix Query 
> Server (PQS).
> 
> Presently, Ambari will configure PQS to use the hbase service keytab which 
> will result in the SPNEGO authentication failing as the RFC requires that the 
> "primary" component of the Kerberos principal for the server is "HTTP". Thus, 
> we need to ensure that we switch PQS over to use the spnego.service.keytab as 
> the keytab and "HTTP/_HOST@REALM" as the principal.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java
>  2e857ed 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  41f538e 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
>  c9536f8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java
>  20fa50f 
> 
> Diff: https://reviews.apache.org/r/47428/diff/
> 
> 
> Testing
> ---
> 
> Unit testing, still working through a "real" Ambari upgrade
> 
> 
> Thanks,
> 
> Josh Elser
> 
>

Re: Review Request 46950: AMBARI-16231: mapreduce.jobhistory.http.policy & mapreduce.jobhistory.webapp.https.address property are not respected

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46950/#review133710
---


Ship it!




Ship It!

- Dmytro Sen


On Май 17, 2016, 6:25 п.п., Vishal Ghugare wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46950/
> ---
> 
> (Updated Май 17, 2016, 6:25 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen and Sid Wagle.
> 
> 
> Bugs: AMBARI-16231
> https://issues.apache.org/jira/browse/AMBARI-16231
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari 2.2:
> Configure SSL for MapReduce by setting these properties in mapred-site.xml
> mapreduce.jobhistory.http.policy=HTTPS_ONLY
> mapreduce.jobhistory.webapp.https.address=host:https_port
> These properties are not respected and as a result JMX uses http protocol 
> instead of https.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractProviderModule.java
>  55e49d9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/JMXHostProviderTest.java
>  a5700a9 
> 
> Diff: https://reviews.apache.org/r/46950/diff/
> 
> 
> Testing
> ---
> 
> One new test added to JMXHostProviderTest
> 
> 
> Thanks,
> 
> Vishal Ghugare
> 
>

Review Request 47527: Hive view : Upload Table- marks column as INT since first 6 rows have INT values.

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47527/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
and Ashwin Rajeev.


Bugs: AMBARI-16418
https://issues.apache.org/jira/browse/AMBARI-16418


Repository: ambari


Description
---

Earlier : datatype of a column was decided based on maximum number of occurence 
of a datatype, even if other values do not have same datatype.

In this patch : even if 1 of the value in the preview rows do not conform to a 
datatype then it is rejected.


Diffs
-

  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/UploadService.java
 b6b000a 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/DataParser.java
 7eae679 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/IParser.java
 6056e73 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/ParseUtils.java
 a17346f 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/Parser.java
 1644c13 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/csv/CSVParser.java
 56cff58 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/json/JSONParser.java
 1d61798 
  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/uploads/parsers/xml/XMLParser.java
 74bf272 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/CSVParserTest.java
 fb4c4da 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserCSVTest.java
 99f758b 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserJSONTest.java
 79166bb 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/DataParserXMLTest.java
 4199257 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/JsonParserTest.java
 38ed225 
  
contrib/views/hive/src/test/java/org/apache/ambari/view/hive/resources/upload/XMLParserTest.java
 d048a62 

Diff: https://reviews.apache.org/r/47527/diff/


Testing
---

extra test cases added for this algorithm of detection of datatype. existing 
test cases changed to conform new algorithm.


Thanks,

Nitiraj Rathore

Review Request 47526: Hive View : History tab in hive view does not show recent jobs

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47526/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav 
Kulshreshtha.


Bugs: AMBARI-16675
https://issues.apache.org/jira/browse/AMBARI-16675


Repository: ambari


Description
---

Earliar : hive jobs with referrer only as 'job' were being shown in history 

In this patch : all the jobs including sample, explain, visual explain will be 
shown which was the cause for recent jobs not showning.


Diffs
-

  
contrib/views/hive/src/main/java/org/apache/ambari/view/hive/resources/jobs/Aggregator.java
 e646fd7 
  contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/index.js 
9584508 
  contrib/views/hive/src/main/resources/ui/hive-web/app/routes/history.js 
848bee8 

Diff: https://reviews.apache.org/r/47526/diff/


Testing
---

manual testing done.


Thanks,

Nitiraj Rathore

Review Request 47525: Hive View : Upload table still shows file name after the upload is done

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47525/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav 
Kulshreshtha.


Bugs: AMBARI-16726
https://issues.apache.org/jira/browse/AMBARI-16726


Repository: ambari


Description
---

Earlier : The UI does not get cleared properly after the upload. It still shows 
file name.

In this patch : the UI will no longer show the old file name if the upload is 
successfull.


Diffs
-

  
contrib/views/hive/src/main/resources/ui/hive-web/app/components/file-upload.js 
1cd05ae 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
 361de7b 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
 eb95292 

Diff: https://reviews.apache.org/r/47525/diff/


Testing
---

manual testing done.


Thanks,

Nitiraj Rathore

Review Request 47524: Hive view : For Upload Table, 'default' DB should be selected by default

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47524/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Pallav 
Kulshreshtha.


Bugs: AMBARI-16429
https://issues.apache.org/jira/browse/AMBARI-16429


Repository: ambari


Description
---

Earlier : first db in the list was selected or was kept empty.

In this patch : 'default' hive db will be selected.


Diffs
-

  
contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/upload-table.js
 361de7b 
  
contrib/views/hive/src/main/resources/ui/hive-web/app/templates/upload-table.hbs
 eb95292 

Diff: https://reviews.apache.org/r/47524/diff/


Testing
---

Manual testing done.


Thanks,

Nitiraj Rathore

Review Request 47523: AMBARI-16725 Alert type = RECOVERY does not have connection timeout

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47523/
---

Review request for Ambari, Jaimin Jetly, Jonathan Hurley, Richard Zang, Xi 
Wang, and Yusaku Sako.


Bugs: AMBARI-16725
https://issues.apache.org/jira/browse/AMBARI-16725


Repository: ambari


Description
---

RECOVERY alert types do not have a connection timeout, therefore, this should 
not be shown in the UI (and not have an error because it's blank).


Diffs
-

  ambari-web/app/controllers/main/alerts/definition_configs_controller.js 
617f7cc 

Diff: https://reviews.apache.org/r/47523/diff/


Testing
---

Local ambari-web test passed.
27819 tests complete (24 seconds)
154 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang

Re: Review Request 47517: AMBARI-16724 Allow customizing Connection Timeout for METRIC Alerts

[Zhe (Joe) Wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47517/
---

(Updated May 18, 2016, 6:09 a.m.)


Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-16724
https://issues.apache.org/jira/browse/AMBARI-16724


Repository: ambari


Description
---

METRIC alert types have a connection timeout in their definition but that value 
is not exposed in the Ambari Web UI (like WEB alerts are).
 "uri" : {
"http" : "{{ams-hbase-site/hbase.master.info.port}}",
"default_port" : 61310.0,
"connection_timeout" : 5.0
  }
 
Include exposing the Connection Timeout critical threshold in Ambari Web for 
METRIC alert types.


Diffs
-

  ambari-web/app/controllers/main/alerts/definition_configs_controller.js 
617f7cc 
  
ambari-web/test/controllers/main/alerts/definitions_configs_controller_test.js 
f3cf28c 

Diff: https://reviews.apache.org/r/47517/diff/


Testing
---

Modified unit test.
Local ambari-web test passed.
27819 tests complete (24 seconds)
154 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang