Re: Review Request 48044: Provide context for hdp-select failures during ambari component install

2016-05-30 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48044/#review135565
---




ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
 (line 129)


We should also add the following commands:

ls -la /usr/hdp/current
hdp-select


- Sumit Mohanty


On May 30, 2016, 2:34 p.m., Laszlo Puskas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48044/
> ---
> 
> (Updated May 30, 2016, 2:34 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16952
> https://issues.apache.org/jira/browse/AMBARI-16952
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In case the hdp-select command fails during a service / component 
> installation there's no contextual information about the cause of the failure.
> This issue is for logging information about the machine on which the 
> hdp-select command fails.
> This solution wraps hdp-select command calls in a try/catch block and logs 
> failure / hdp installationrelated information.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/hdp_select.py
>  9a3201e 
> 
> Diff: https://reviews.apache.org/r/48044/diff/
> 
> 
> Testing
> ---
> 
> Manual testing underway.
> 
> 
> Thanks,
> 
> Laszlo Puskas
> 
>

Review Request 48043: Zeppelin Ambari view : UI broken when service is not running

2016-05-30 Thread Renjith Kamath 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48043/
---

Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
Luniya, Pallav Kulshreshtha, Rohit Choudhary, and Sumit Mohanty.


Bugs: AMBARI-16957
https://issues.apache.org/jira/browse/AMBARI-16957


Repository: ambari


Description
---

add service check in zeppelin view


Diffs
-

  contrib/views/zeppelin/pom.xml 3d0161c 
  
contrib/views/zeppelin/src/main/java/org/apache/ambari/view/zeppelin/ZeppelinServiceCheck.java
 PRE-CREATION 
  contrib/views/zeppelin/src/main/resources/WEB-INF/index.jsp 9247b8b 
  contrib/views/zeppelin/src/main/resources/WEB-INF/web.xml cb0bcd9 

Diff: https://reviews.apache.org/r/48043/diff/


Testing
---

tested on CentOS 6.4


Thanks,

Renjith Kamath

Re: Review Request 48042: Allow setting log level, and java opts for hive interactive/llap

2016-05-30 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48042/#review135512
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Травень 30, 2016, 1:33 після полудня, Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48042/
> ---
> 
> (Updated Травень 30, 2016, 1:33 після полудня)
> 
> 
> Review request for Ambari, Andrew Onischuk and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-16955
> https://issues.apache.org/jira/browse/AMBARI-16955
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Users should be able to control the log level for the daemons, and java args 
> for the daemon.
> 
> Both of these are likely to be text input boxes, which feed into hive 
> --service llap. There's no explicit ocnfiguration in hive-site.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  2fb8f0b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  4d85d4b 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml
>  e5b532c 
> 
> Diff: https://reviews.apache.org/r/48042/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Review Request 48036: Service name shown instead of Host name on popup

2016-05-30 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48036/
---

Review request for Ambari, Jonathan Hurley and Nate Cole.


Bugs: AMBARI-16953
https://issues.apache.org/jira/browse/AMBARI-16953


Repository: ambari


Description
---

STR:
# Deploy ambari with HDP2.2
# Register and install HDP2.5
# Click "Upgrade"
# Look at the Rolling Upgrade checks
Result: Service name SECONDARY_NAMENODE shown instead of Host name on popup


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/checks/SecondaryNamenodeDeletedCheck.java
 4893098 

Diff: https://reviews.apache.org/r/48036/diff/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 48032: Not able to save custom config in view config

2016-05-30 Thread Ashwin Rajeev 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48032/#review135506
---


Ship it!




Ship It!

- Ashwin Rajeev


On May 30, 2016, 8:55 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48032/
> ---
> 
> (Updated May 30, 2016, 8:55 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16948
> https://issues.apache.org/jira/browse/AMBARI-16948
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added Nullpointer check for cluster_handle field.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
>  bdb1087 
> 
> Diff: https://reviews.apache.org/r/48032/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47985: Fix for AMBARI-16939, upgrade from 2.2.0 to 2.4.0 on Ubuntu 14.04 / MySQL.

2016-05-30 Thread Balázs Bence Sári 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47985/
---

(Updated May 30, 2016, 12:46 p.m.)


Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Oliver 
Szabo, Sandor Magyari, and Sebastian Toader.


Changes
---

fixed comments


Bugs: AMBARI-16939
https://issues.apache.org/jira/browse/AMBARI-16939


Repository: ambari


Description
---

Some 2.2.0 installations carry old (pre Ambari 1.5) FK constraint names in 
their DB schema. Upgrade script knows the constraints under a different name so 
can't drop them. Fix tries to drop the constraint with both their old and new 
names.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
 dbbf477 

Diff: https://reviews.apache.org/r/47985/diff/


Testing
---

- Run all unit tests in ambari-server, all passed
- Manually tested upgrading a 2.2.0 cluster having the old constraint names to 
2.4
- Manually tested upgrading a 2.2.0 cluster having the new constraint names to 
2.4


Thanks,

Balázs Bence Sári

Re: Review Request 47985: Fix for AMBARI-16939, upgrade from 2.2.0 to 2.4.0 on Ubuntu 14.04 / MySQL.

2016-05-30 Thread Balázs Bence Sári 


> On May 29, 2016, 7:53 p.m., Sandor Magyari wrote:
> > Ship It!
> 
> Sandor Magyari wrote:
> Could you please add a small unit test.

Looks like upgrades on the servicecomponentdesiredstate table are intentionally 
skipped in unit tests. Plese see UpgradeCatalog240Test.java, comment in line 
182 (in version 87b0a24 of the file).


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47985/#review135442
---


On May 27, 2016, 8:54 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47985/
> ---
> 
> (Updated May 27, 2016, 8:54 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Oliver 
> Szabo, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16939
> https://issues.apache.org/jira/browse/AMBARI-16939
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some 2.2.0 installations carry old (pre Ambari 1.5) FK constraint names in 
> their DB schema. Upgrade script knows the constraints under a different name 
> so can't drop them. Fix tries to drop the constraint with both their old and 
> new names.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  dbbf477 
> 
> Diff: https://reviews.apache.org/r/47985/diff/
> 
> 
> Testing
> ---
> 
> - Run all unit tests in ambari-server, all passed
> - Manually tested upgrading a 2.2.0 cluster having the old constraint names 
> to 2.4
> - Manually tested upgrading a 2.2.0 cluster having the new constraint names 
> to 2.4
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 48035: Upgrade Log Search SOLR to 5.5.1

2016-05-30 Thread Miklos Gergely 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48035/#review135503
---


Ship it!




Ship It!

- Miklos Gergely


On May 30, 2016, 12:04 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48035/
> ---
> 
> (Updated May 30, 2016, 12:04 p.m.)
> 
> 
> Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Nettleton, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-16951
> https://issues.apache.org/jira/browse/AMBARI-16951
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Upgrade SOLR version from 5.5.0 to 5.5.1 (contains some SOLR bug fixes)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/pom.xml ae108e3 
> 
> Diff: https://reviews.apache.org/r/48035/diff/
> 
> 
> Testing
> ---
> 
> In progress..
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 47985: Fix for AMBARI-16939, upgrade from 2.2.0 to 2.4.0 on Ubuntu 14.04 / MySQL.

2016-05-30 Thread Sandor Magyari 


> On May 29, 2016, 7:53 p.m., Sandor Magyari wrote:
> > Ship It!

Could you please add a small unit test.


- Sandor


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47985/#review135442
---


On May 27, 2016, 8:54 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47985/
> ---
> 
> (Updated May 27, 2016, 8:54 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, Oliver 
> Szabo, Sandor Magyari, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16939
> https://issues.apache.org/jira/browse/AMBARI-16939
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Some 2.2.0 installations carry old (pre Ambari 1.5) FK constraint names in 
> their DB schema. Upgrade script knows the constraints under a different name 
> so can't drop them. Fix tries to drop the constraint with both their old and 
> new names.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java
>  dbbf477 
> 
> Diff: https://reviews.apache.org/r/47985/diff/
> 
> 
> Testing
> ---
> 
> - Run all unit tests in ambari-server, all passed
> - Manually tested upgrading a 2.2.0 cluster having the old constraint names 
> to 2.4
> - Manually tested upgrading a 2.2.0 cluster having the new constraint names 
> to 2.4
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Review Request 48035: Upgrade Log Search SOLR to 5.5.1

2016-05-30 Thread Oliver Szabo 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48035/
---

Review request for Ambari, Don Bosco Durai, Miklos Gergely, Robert Nettleton, 
and Sumit Mohanty.


Bugs: AMBARI-16951
https://issues.apache.org/jira/browse/AMBARI-16951


Repository: ambari


Description
---

Upgrade SOLR version from 5.5.0 to 5.5.1 (contains some SOLR bug fixes)


Diffs
-

  ambari-logsearch/pom.xml ae108e3 

Diff: https://reviews.apache.org/r/48035/diff/


Testing
---

In progress..


Thanks,

Oliver Szabo

Re: Review Request 47995: Cluster install wizard hangs and cannot proceed if Knox is the only service selected for install

2016-05-30 Thread Alexandr Antonenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47995/#review135496
---



committed to trunk and branch-2.4

- Alexandr Antonenko


On May 28, 2016, 5:16 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47995/
> ---
> 
> (Updated May 28, 2016, 5:16 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Andrii Tkach.
> 
> 
> Bugs: AMBARI-16941
> https://issues.apache.org/jira/browse/AMBARI-16941
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Open Cluster Install Wizard and select Knox as the only service to install.
> 2. On step6 of the wizard (Assign Slaves and Clients), you cannot click on 
> Next and proceed because of an error in the javascript code.
> 3. The javascript error is as follows:
> 4. TypeError: h.warnMessages is undefined
>   
> app.js (line 38401, col 49)
> TypeError: h.warnMessages is undefined
>   
> 
> ...eturn this.get('hosts').some(function(h) { return h.warnMessages.length > 
> 0; })
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step6_controller.js 6090f74 
>   ambari-web/test/controllers/wizard/step6_test.js 56b9e96 
> 
> Diff: https://reviews.apache.org/r/47995/diff/
> 
> 
> Testing
> ---
> 
> Manual test
> Added testcases to test anyHostErrors and anyHostWarnings methods.
> mvn test ran clean
> 
>  27862 tests complete (44 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 47995: Cluster install wizard hangs and cannot proceed if Knox is the only service selected for install

2016-05-30 Thread Andrii Tkach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47995/#review135491
---


Ship it!




Ship It!

- Andrii Tkach


On May 28, 2016, 5:16 p.m., Sangeeta Ravindran wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47995/
> ---
> 
> (Updated May 28, 2016, 5:16 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Andrii Tkach.
> 
> 
> Bugs: AMBARI-16941
> https://issues.apache.org/jira/browse/AMBARI-16941
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1. Open Cluster Install Wizard and select Knox as the only service to install.
> 2. On step6 of the wizard (Assign Slaves and Clients), you cannot click on 
> Next and proceed because of an error in the javascript code.
> 3. The javascript error is as follows:
> 4. TypeError: h.warnMessages is undefined
>   
> app.js (line 38401, col 49)
> TypeError: h.warnMessages is undefined
>   
> 
> ...eturn this.get('hosts').some(function(h) { return h.warnMessages.length > 
> 0; })
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step6_controller.js 6090f74 
>   ambari-web/test/controllers/wizard/step6_test.js 56b9e96 
> 
> Diff: https://reviews.apache.org/r/47995/diff/
> 
> 
> Testing
> ---
> 
> Manual test
> Added testcases to test anyHostErrors and anyHostWarnings methods.
> mvn test ran clean
> 
>  27862 tests complete (44 seconds)
>   154 tests pending
> 
> 
> Thanks,
> 
> Sangeeta Ravindran
> 
>

Re: Review Request 48032: Not able to save custom config in view config

2016-05-30 Thread Rohit Choudhary 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48032/#review135485
---


Ship it!




Ship It!

- Rohit Choudhary


On May 30, 2016, 8:55 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48032/
> ---
> 
> (Updated May 30, 2016, 8:55 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-16948
> https://issues.apache.org/jira/browse/AMBARI-16948
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Added Nullpointer check for cluster_handle field.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ViewInstanceResourceProvider.java
>  bdb1087 
> 
> Diff: https://reviews.apache.org/r/48032/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 47880: AMBARI-16890 Updating Ambari configs changes for latest Ranger configs

2016-05-30 Thread Mugdha Varadkar 


> On May 26, 2016, 5:16 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py,
> >  line 300
> > 
> >
> > Why default hdfs and hive users? If they are missing, that's a serious 
> > problem

Removed default and using stack_advisor recommendation to get hdfs and hive 
user if services are installed.


> On May 26, 2016, 5:16 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py, 
> > line 596
> > 
> >
> > Will this always be https?

Yes


> On May 26, 2016, 5:16 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml,
> >  line 124
> > 
> >
> > This config definition is not needed since it already exists in the 2.5 
> > config pack.

config pack location is changed from this commit: 
https://github.com/apache/ambari/commit/1209a706dda1646bfeabc8059eb460b56aae1d6f
config-upgrade.xml is present inside folder(2.3/2.4) from where we are 
upgrading to 2.5


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47880/#review135014
---


On May 30, 2016, 9:26 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47880/
> ---
> 
> (Updated May 30, 2016, 9:26 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16890
> https://issues.apache.org/jira/browse/AMBARI-16890
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changes include:
> 
> - Enable Ranger SSO property as a checkbox
> - Populate query param originalUrl
> 
> - Deleted below properties from ranger-admin-site.xml latest stack and also 
> during upgrade.
>   ranger.sso.cookiename
>   ranger.sso.query.param.originalurl
> 
> - Adding below new properties to ranger-admin-site.xml:
>   ranger.kms.service.user.hdfs – default value "hdfs"
>   ranger.kms.service.user.hive – default value "hive"
> 
> - Updating default value for below properties in latest stack:
>   ranger.ldap.ad.user.searchfilter (sAMAccountName={0})
>   ranger.ldap.user.searchfilter(uid={0})
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-site.xml
>  daab4ec 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml
>  b358f27 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
>  91d8093 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml
>  c1ffeb6 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 79314f5 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 1130d9a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  4362fe0 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 0e0ea1d 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> b68354f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  5ccb153 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> bc45be6 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 658e6aa 
>   ambari-web/app/data/HDP2.3/site_properties.js e04d060 
> 
> Diff: https://reviews.apache.org/r/47880/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger installation on centos 6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 47880: AMBARI-16890 Updating Ambari configs changes for latest Ranger configs

2016-05-30 Thread Mugdha Varadkar 


> On May 26, 2016, 5:17 p.m., Srimanth Gunturi wrote:
> > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py,
> >  line 301
> > 
> >
> > Path should be prefixed by '/' just like the line above?

Removed default and using stack_advisor recommendation to get hdfs and hive 
user if services are installed.


- Mugdha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47880/#review135013
---


On May 30, 2016, 9:26 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47880/
> ---
> 
> (Updated May 30, 2016, 9:26 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-16890
> https://issues.apache.org/jira/browse/AMBARI-16890
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Changes include:
> 
> - Enable Ranger SSO property as a checkbox
> - Populate query param originalUrl
> 
> - Deleted below properties from ranger-admin-site.xml latest stack and also 
> during upgrade.
>   ranger.sso.cookiename
>   ranger.sso.query.param.originalurl
> 
> - Adding below new properties to ranger-admin-site.xml:
>   ranger.kms.service.user.hdfs – default value "hdfs"
>   ranger.kms.service.user.hive – default value "hive"
> 
> - Updating default value for below properties in latest stack:
>   ranger.ldap.ad.user.searchfilter (sAMAccountName={0})
>   ranger.ldap.user.searchfilter(uid={0})
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-site.xml
>  daab4ec 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml
>  b358f27 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
>  91d8093 
>   
> ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml
>  c1ffeb6 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 79314f5 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
> 1130d9a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  4362fe0 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 0e0ea1d 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
> b68354f 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  5ccb153 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> bc45be6 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 658e6aa 
>   ambari-web/app/data/HDP2.3/site_properties.js e04d060 
> 
> Diff: https://reviews.apache.org/r/47880/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger installation on centos 6
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 47880: AMBARI-16890 Updating Ambari configs changes for latest Ranger configs

2016-05-30 Thread Mugdha Varadkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47880/
---

(Updated May 30, 2016, 9:26 a.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy.


Bugs: AMBARI-16890
https://issues.apache.org/jira/browse/AMBARI-16890


Repository: ambari


Description
---

Changes include:

- Enable Ranger SSO property as a checkbox
- Populate query param originalUrl

- Deleted below properties from ranger-admin-site.xml latest stack and also 
during upgrade.
  ranger.sso.cookiename
  ranger.sso.query.param.originalurl

- Adding below new properties to ranger-admin-site.xml:
  ranger.kms.service.user.hdfs – default value "hdfs"
  ranger.kms.service.user.hive – default value "hive"

- Updating default value for below properties in latest stack:
  ranger.ldap.ad.user.searchfilter (sAMAccountName={0})
  ranger.ldap.user.searchfilter(uid={0})


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-site.xml
 daab4ec 
  
ambari-server/src/main/resources/common-services/RANGER/0.5.0/configuration/ranger-admin-site.xml
 b358f27 
  
ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
 91d8093 
  
ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml
 c1ffeb6 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
79314f5 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml 
1130d9a 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 4362fe0 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
0e0ea1d 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 
b68354f 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 5ccb153 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
bc45be6 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
658e6aa 
  ambari-web/app/data/HDP2.3/site_properties.js e04d060 

Diff: https://reviews.apache.org/r/47880/diff/


Testing
---

Tested Ranger installation on centos 6


Thanks,

Mugdha Varadkar

Re: Review Request 48030: AMBARI-16946 Storm Metrics Sink has high chance to discard some datapoints

2016-05-30 Thread Jungtaek Lim 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48030/
---

(Updated 5 30, 2016, 8:21 오전)


Review request for Ambari, Sriharsha Chintalapani and Sid Wagle.


Bugs: AMBARI-16946
https://issues.apache.org/jira/browse/AMBARI-16946


Repository: ambari


Description
---

There's a mismatch between TimelineMetricsCache and Storm metrics unit, while 
TimelineMetricsCache considers "metric name + timestamp" to be unique but Storm 
is not.

For example, assume that bolt B has task T1, T2 and B has registered metrics 
M1. It's possible for metrics sink to receive (T1, M1) and (T2, M1) with same 
timestamp TS1 (in TaskInfo, not current time), and received later will be 
discarded from TimelineMetricsCache.

If we want to have unique metric point of Storm, we should use "topology name + 
component name + task id + metric name" to metric name so that "metric name + 
timestamp" will be unique.

There're other issues I would like to address, too.

- Currently, hostname is written to hostname of the machine which runs metrics 
sink. Since TaskInfo has hostname of the machine which runs task, we're better 
to use this.
- Unit of timestamp of TaskInfo is second, while Storm Metrics Sink uses this 
as millisecond, resulting in timestamp flaw, and malfunction of cache eviction. 
It should be multiplied by 1000.
- 'component name' is not unique across the cluster, so it's not fit for app 
id. 'topology name' is unique so proper value of app id is topology name.

Consideration: Hostname for determining 'write shard' is set to hostname of the 
machine which runs metrics sink. Since I don't know read also be sharded, I'm 
not sure it's safe to use TaskInfo's hostname to hostname of TimelineMetric. 
Please review carefully regarding this.


Diffs
-

  
ambari-metrics/ambari-metrics-storm-sink/src/main/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSink.java
 02f5598 
  
ambari-metrics/ambari-metrics-storm-sink/src/test/java/org/apache/hadoop/metrics2/sink/storm/StormTimelineMetricsSinkTest.java
 8171a4d 

Diff: https://reviews.apache.org/r/48030/diff/


Testing
---

I tested this only ambari-metrics module since changeset is not related on 
other modules.

[INFO] 
[INFO] Reactor Summary:
[INFO]
[INFO] ambari-metrics . SUCCESS [  0.896 s]
[INFO] Ambari Metrics Common .. SUCCESS [ 13.386 s]
[INFO] Ambari Metrics Hadoop Sink . SUCCESS [  5.085 s]
[INFO] Ambari Metrics Flume Sink .. SUCCESS [  6.827 s]
[INFO] Ambari Metrics Kafka Sink .. SUCCESS [  4.190 s]
[INFO] Ambari Metrics Storm Sink .. SUCCESS [  1.384 s]
[INFO] Ambari Metrics Collector ... SUCCESS [04:06 min]
[INFO] Ambari Metrics Monitor . SUCCESS [  3.556 s]
[INFO] Ambari Metrics Grafana . SUCCESS [01:03 min]
[INFO] Ambari Metrics Assembly  SUCCESS [  3.567 s]
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 05:48 min
[INFO] Finished at: 2016-05-30T16:46:07+09:00
[INFO] Final Memory: 78M/1038M
[INFO] 

In fact, I tried to run `mvn test` from ambari root directory but build is 
failing from ambari-web.

```
> fsevents@0.2.1 install 
> /Users/jlim/WorkArea/JavaProjects/ambari/ambari-web/node_modules/chokidar/node_modules/fsevents
> node-gyp rebuild
...
npm WARN install:fsevents fsevents@0.2.1 install: `node-gyp rebuild`
npm WARN install:fsevents Exit status 1
```

No luck on `npm install`, too.


Thanks,

Jungtaek Lim

Re: Review Request 47976: LDAP sync cannot handle if the member attribute value is not DN or id

2016-05-30 Thread Daniel Gergely 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47976/#review135472
---


Ship it!




Ship It!

- Daniel Gergely


On máj. 27, 2016, 8:14 du, Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47976/
> ---
> 
> (Updated máj. 27, 2016, 8:14 du)
> 
> 
> Review request for Ambari, Daniel Gergely, Robert Levas, Robert Nettleton, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-16875
> https://issues.apache.org/jira/browse/AMBARI-16875
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> In some rare cases, member attribute value for a group/user can be 
> constructed. (not baseDN/uid, sometimes ldap proxies does that)
> 
> Added 2 feature to fix these problems (to manipulate queries that are used 
> during sync):
> 
> 2.1.) use regexp to get the useful informations from a custom member 
> attribute value: (for groups/users)
> "authentication.ldap.sync.userMemberReplacePattern"
> "authentication.ldap.sync.groupMemberReplacePattern"
> 
> e.g.:
> member:

Review Request 48027: Files View : Table row overlaps if group name is long

2016-05-30 Thread Pallav Kulshreshtha 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48027/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, and Nitiraj Rathore.


Bugs: AMBARI-16947
https://issues.apache.org/jira/browse/AMBARI-16947


Repository: ambari


Description
---

- Restricted file group to 10 character and file owner to 20 character. It will 
show the complete string on hover.


Diffs
-

  
contrib/views/files/src/main/resources/ui/app/templates/components/file-row.hbs 
a631335 

Diff: https://reviews.apache.org/r/48027/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha