date:20160718

Re: Review Request 50140: AMBARI-17771 : Update alert definition for Ranger Admin after kerberos changes

2016-07-18 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50140/#review142687
---




ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
 (line 65)


This should never be null. If it was null, then m_clusters above it would 
also be null and you'd get a NPE even before here.



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
 (lines 79 - 87)


Out of curiousity, would it be easier to just read the values from the JSON 
file directly? That way you don't have to duplicate it here?



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
 (line 91)


It already exists, so you can just call merge() on it.



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
 (line 103)


Remove and log instead.



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
 (lines 106 - 107)


This can't happen.



ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigActionTest.java
 (lines 82 - 83)


If this test class is in the same package, you should be able to access 
these directly.


- Jonathan Hurley


On July 18, 2016, 11:45 a.m., Gautam Borad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50140/
> ---
> 
> (Updated July 18, 2016, 11:45 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Mahadev 
> Konar, Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: AMBARI-17771
> https://issues.apache.org/jira/browse/AMBARI-17771
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update alert definition URI after stack is updated.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
>  7be5a1915c00853b2817b815124752063222d59d 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 47d9fdb999ef6e7051bd339502e98d30b7c53fc2 
>   
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
>  2daa9b8907aa8159829b40007ec2ae81ffcdb29c 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> dd7a87f72d1cbbbc9db6027af6c61292743a133a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigActionTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/resources/stacks/HDP/2.5.0/services/RANGER/alerts.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50140/diff/
> 
> 
> Testing
> ---
> 
> Tested on a centos 6 cluster after upgrade and checked that the alert works 
> fine for Ranger Admin.
> 
> 
> Thanks,
> 
> Gautam Borad
> 
>

Re: Review Request 50101: Cluster user role is permitted to install packages using API

2016-07-18 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50101/#review142686
---


Ship it!




Ship It!

- Jonathan Hurley


On July 15, 2016, 8:31 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50101/
> ---
> 
> (Updated July 15, 2016, 8:31 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, 
> and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17740
> https://issues.apache.org/jira/browse/AMBARI-17740
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With "Cluster User" role, submitting "install packages" API call goes 
> through, even though it should be blocked
> 
> ```
> #curl -u cu:1234 -H "X-Requested-By: ambari" -i -X  POST 
> http://ambari-server:8080/api/v1/clusters/cl1/stack_versions -d 
> '{"ClusterStackVersions":{"stack":"HDP","version":"2.3","repository_version":"2.3.0.0"}}'
> HTTP/1.1 202 Accepted
> Date: Wed, 29 Jun 2016 05:55:16 GMT
> X-Frame-Options: DENY
> X-XSS-Protection: 1; mode=block
> Set-Cookie: AMBARISESSIONID=11njwu8py6m511511liub068vj;Path=/;HttpOnly
> Expires: Thu, 01 Jan 1970 00:00:00 GMT
> User: cu
> Content-Type: text/plain
> Vary: Accept-Encoding, User-Agent
> Content-Length: 136
> Server: Jetty(9.2.11.v20150529)
> 
> {
>   "href" : "http://ambari-server:8080/api/v1/clusters/cl1/requests/36;,
>   "Requests" : {
> "id" : 36,
> "status" : "Accepted"
>   }
> }
> ```
> 
> Role of the user "cu"
> ```
> {
>   "href" : "http://ambari-server:8080/api/v1/users/cu/privileges/7;,
>   "PrivilegeInfo" : {
> "cluster_name" : "cl1",
> "permission_label" : "Cluster User",
> "permission_name" : "CLUSTER.USER",
> "principal_name" : "cu",
> "principal_type" : "USER",
> "privilege_id" : 7,
> "type" : "CLUSTER",
> "user_name" : "cu"
>   }
> }
> ```
> 
> # Solution
> Protect access to this API by allowing only users with the 
> `AMBARI.MANAGE_STACK_VERSIONS` authorization to create, update, and delete 
> stack versions.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  c11cd81 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  a438edb 
> 
> Diff: https://reviews.apache.org/r/50101/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Local test results: 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:12:52.071s
> [INFO] Finished at: Fri Jul 15 19:27:40 EDT 2016
> [INFO] Final Memory: 62M/1889M
> [INFO] 
> 
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 50150: Kerberos-related configs are not applied before INSTALL command is built on add service

2016-07-18 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50150/#review142685
---


Ship it!




Ship It!

- Jonathan Hurley


On July 18, 2016, 8:09 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50150/
> ---
> 
> (Updated July 18, 2016, 8:09 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate 
> Cole.
> 
> 
> Bugs: AMBARI-17772
> https://issues.apache.org/jira/browse/AMBARI-17772
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Kerberos-related configs are not applied before INSTALL command is built on 
> add service.  
> 
> This occurs when new services and components are added to an existing cluster 
> where Kerberos is enabled. Due to the order of when command detail (JSON) 
> structures are built and when service configurations are set, 
> Kerberos-related configurations will not be available for new services.  This 
> is a regression created by the patch for AMBARI-17629.
> 
> *Solution*
> Ensure that Kerberos-related configuration updates are applied before the 
> INSTALL command details are created.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  b2a3761 
> 
> Diff: https://reviews.apache.org/r/50150/diff/
> 
> 
> Testing
> ---
> 
> Manually tested in UI and Blueprint installations
> 
> # Local test results: PENDING
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Review Request 50178: AMBARI-17783: Add falcon to as oozie admin user for 2.5

2016-07-18 Thread Venkat Ranganathan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50178/
---

Review request for Ambari, Alejandro Fernandez and Swapan Shridhar.


Bugs: AMBARI-17783
https://issues.apache.org/jira/browse/AMBARI-17783


Repository: ambari


Description
---

When Falcon is installed witn Oozie in HDP2.5, make falcon an admin user in 
Oozie


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
0e455e9 

Diff: https://reviews.apache.org/r/50178/diff/


Testing
---

Implemented the changes in stack_advisor and ran a test to make sure the 
configuration changes for admin user is forced


Thanks,

Venkat Ranganathan

Review Request 50173: AMBARI-17753 Add some of value-attributes to property files in ZOOKEEPER

2016-07-18 Thread Masahiro Tanaka


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50173/
---

Review request for Ambari, Dmitro Lisnichenko, Jayush Luniya, and Sid Wagle.


Bugs: AMBARI-17753
https://issues.apache.org/jira/browse/AMBARI-17753


Repository: ambari


Description
---

Some of the property files in ZOOKEEPER lack value-attributes.
It would be nice to have value-attributes on most of the properties. If so, we 
can notice careless mistakes in Ambari Server WebUI.


Diffs
-

  
ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zoo.cfg.xml
 99421c0 
  
ambari-server/src/test/resources/stacks/HDP/2.0.5/services/ZOOKEEPER/configuration/zoo.cfg.xml
 41cb645 

Diff: https://reviews.apache.org/r/50173/diff/


Testing
---

mvn clean test
See screenshot on JIRA


Thanks,

Masahiro Tanaka

Review Request 50171: AMBARI-17722 Add some of value-attributes to property files in TEZ

2016-07-18 Thread Masahiro Tanaka


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50171/
---

Review request for Ambari, Dmitriy Lyubimov, Jayush Luniya, and Sid Wagle.


Bugs: AMBARI-17722
https://issues.apache.org/jira/browse/AMBARI-17722


Repository: ambari


Description
---

Some of the property files in TEZ lack value-attributes.
It would be nice to have value-attributes on most of the properties. If so, we 
can notice a careless mistakes in Ambari Server WebUI.


Diffs
-

  
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/configuration/tez-site.xml
 e7a851c 
  
ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/TEZ/configuration/tez-site.xml
 704022c 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/TEZ/configuration/tez-site.xml
 d865579 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/TEZ/configuration/tez-site.xml
 8c2c6cf 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/TEZ/configuration/tez-site.xml
 382025e 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/TEZ/configuration/tez-site.xml
 d719322 

Diff: https://reviews.apache.org/r/50171/diff/


Testing
---

mvn clean test
See screenshot on JIRA


Thanks,

Masahiro Tanaka

Review Request 50170: AMBARI-17749 Typo "rather then" in spark-default.conf

2016-07-18 Thread Masahiro Tanaka


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50170/
---

Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, and Yusaku Sako.


Bugs: AMBARI-17749
https://issues.apache.org/jira/browse/AMBARI-17749


Repository: ambari


Description
---

There is a typo in Spark config description. See attached screenshot.


Diffs
-

  
ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-defaults.xml
 c53dcd7 
  
ambari-server/src/main/resources/common-services/SPARK/1.5.2/configuration/spark-thrift-sparkconf.xml
 67120d3 

Diff: https://reviews.apache.org/r/50170/diff/


Testing
---

mvn clean test


Thanks,

Masahiro Tanaka

Re: Review Request 50150: Kerberos-related configs are not applied before INSTALL command is built on add service

2016-07-18 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50150/
---

(Updated July 18, 2016, 8:09 p.m.)


Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, and Nate Cole.


Bugs: AMBARI-17772
https://issues.apache.org/jira/browse/AMBARI-17772


Repository: ambari


Description
---

Kerberos-related configs are not applied before INSTALL command is built on add 
service.  

This occurs when new services and components are added to an existing cluster 
where Kerberos is enabled. Due to the order of when command detail (JSON) 
structures are built and when service configurations are set, Kerberos-related 
configurations will not be available for new services.  This is a regression 
created by the patch for AMBARI-17629.

*Solution*
Ensure that Kerberos-related configuration updates are applied before the 
INSTALL command details are created.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 b2a3761 

Diff: https://reviews.apache.org/r/50150/diff/


Testing
---

Manually tested in UI and Blueprint installations

# Local test results: PENDING

# Jenkins test results: PENDING


Thanks,

Robert Levas

Review Request 50169: Atlas hooks for Hive, Falcon, Storm missing atlas.jaas.KafkaClient.option.principal & atlas.jaas.KafkaClient.option.keytab

2016-07-18 Thread Alejandro Fernandez


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50169/
---

Review request for Ambari, Dmytro Grinenko, Nahappan Somasundaram, and Sumit 
Mohanty.


Bugs: AMBARI-17780
https://issues.apache.org/jira/browse/AMBARI-17780


Repository: ambari


Description
---

In HDP 2.5, the following config files are missing two properties when the 
cluster is Kerberized.

Files:
hive-atlas-application.properties
storm-atlas-application.properties
falconm-atlas-application.properties

Properties:
atlas.jaas.KafkaClient.option.principal
atlas.jaas.KafkaClient.option.keytab


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/setup_atlas_hook.py
 947d441 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/BlueprintConfigurationProcessor.java
 939e232 
  
ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py
 e4d2392 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params.py
 f2d01fc 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 6f8d588 
  
ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/params_linux.py
 5bca720 
  
ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py
 591e548 
  ambari-server/src/main/resources/common-services/STORM/1.0.1/kerberos.json 
5a9f24c 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
6081a04 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json 
b5ec1c9 

Diff: https://reviews.apache.org/r/50169/diff/


Testing
---

Verified with HDP 2.5 and Kerberizing the cluster with Atlas, Storm, Hive, 
Falcon, Sqoop

Python unit tests passed,
Total run:1019
Total errors:0
Total failures:0
OK


Thanks,

Alejandro Fernandez

Re: Review Request 50167: AMBARI-17779 : Fix enable/disable normalizer issue in AMS

2016-07-18 Thread Aravindan Vijayan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50167/
---

(Updated July 18, 2016, 11:59 p.m.)


Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-17779
https://issues.apache.org/jira/browse/AMBARI-17779


Repository: ambari


Description
---

Following set of changes are being done for this patch.
1. Fix bug in AMS that does not allow hbase normalizer config to be disabled 
for AMS tables.
2. Fix issue in default TopN behavior for point in time queries
3. Exclude unneeded phoenix jars and test jars from AMS collector and hbase lib 
directories, during rpm assembly.


Diffs
-

  ambari-metrics/ambari-metrics-assembly/pom.xml ea180f5 
  ambari-metrics/ambari-metrics-timelineservice/pom.xml a0e4adf 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
 dd1ae3f 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 16ebcd9 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
 7c6e7f4 

Diff: https://reviews.apache.org/r/50167/diff/


Testing (updated)
---

Unit tests pass. 
Manual testing done.


Thanks,

Aravindan Vijayan

Re: Review Request 50167: AMBARI-17779 : Fix enable/disable normalizer issue in AMS

2016-07-18 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50167/#review142664
---


Ship it!




Ship It!

- Sid Wagle


On July 18, 2016, 11:10 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50167/
> ---
> 
> (Updated July 18, 2016, 11:10 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17779
> https://issues.apache.org/jira/browse/AMBARI-17779
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Following set of changes are being done for this patch.
> 1. Fix bug in AMS that does not allow hbase normalizer config to be disabled 
> for AMS tables.
> 2. Fix issue in default TopN behavior for point in time queries
> 3. Exclude unneeded phoenix jars and test jars from AMS collector and hbase 
> lib directories, during rpm assembly.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-assembly/pom.xml ea180f5 
>   ambari-metrics/ambari-metrics-timelineservice/pom.xml a0e4adf 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  dd1ae3f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  16ebcd9 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
>  7c6e7f4 
> 
> Diff: https://reviews.apache.org/r/50167/diff/
> 
> 
> Testing
> ---
> 
> Unit tests pass. 
> Manual testing of (2) and (3) done.
> Manual testing of (1) pending.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Review Request 50167: AMBARI-17779 : Fix enable/disable normalizer issue in AMS

2016-07-18 Thread Aravindan Vijayan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50167/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-17779
https://issues.apache.org/jira/browse/AMBARI-17779


Repository: ambari


Description
---

Following set of changes are being done for this patch.
1. Fix bug in AMS that does not allow hbase normalizer config to be disabled 
for AMS tables.
2. Fix issue in default TopN behavior for point in time queries
3. Exclude unneeded phoenix jars and test jars from AMS collector and hbase lib 
directories, during rpm assembly.


Diffs
-

  ambari-metrics/ambari-metrics-assembly/pom.xml ea180f5 
  ambari-metrics/ambari-metrics-timelineservice/pom.xml a0e4adf 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
 dd1ae3f 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
 16ebcd9 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/ITPhoenixHBaseAccessor.java
 7c6e7f4 

Diff: https://reviews.apache.org/r/50167/diff/


Testing
---

Unit tests pass. 
Manual testing of (2) and (3) done.
Manual testing of (1) pending.


Thanks,

Aravindan Vijayan

Re: Review Request 50159: HiveServer interactive stop should wait for 30 second before sending hard kill command

2016-07-18 Thread Sumit Mohanty


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50159/#review142661
---


Ship it!




Ship It!

- Sumit Mohanty


On July 18, 2016, 9:37 p.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50159/
> ---
> 
> (Updated July 18, 2016, 9:37 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-17776
> https://issues.apache.org/jira/browse/AMBARI-17776
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HiveServer interactive stop should wait for 30 second before sending hard 
> kill command
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
>  1edcdca 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 2a0674d 
> 
> Diff: https://reviews.apache.org/r/50159/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 2016-07-18 20:41:53,026 - Execute['! (ls /var/run/hive/hive-interactive.pid 
> >/dev/null 2>&1 && ps -p 541 >/dev/null 2>&1)'] {'tries': 10, 'try_sleep': 3}
> 2016-07-18 20:41:53,059 - Retrying after 3 seconds. Reason: Execution of '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1)' returned 1. 
> 2016-07-18 20:41:56,082 - Retrying after 3 seconds. Reason: Execution of '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1)' returned 1. 
> 2016-07-18 20:41:59,103 - Retrying after 3 seconds. Reason: Execution of '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1)' returned 1. 
> 2016-07-18 20:42:02,126 - Retrying after 3 seconds. Reason: Execution of '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1)' returned 1. 
> 2016-07-18 20:42:05,150 - Retrying after 3 seconds. Reason: Execution of '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1)' returned 1. 
> 2016-07-18 20:42:08,171 - Retrying after 3 seconds. Reason: Execution of '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1)' returned 1. 
> 2016-07-18 20:42:11,195 - Retrying after 3 seconds. Reason: Execution of '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1)' returned 1. 
> 2016-07-18 20:42:14,217 - Retrying after 3 seconds. Reason: Execution of '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1)' returned 1. 
> 2016-07-18 20:42:17,240 - Retrying after 3 seconds. Reason: Execution of '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1)' returned 1. 
> 2016-07-18 20:42:20,262 - Execute['ambari-sudo.sh kill -9 541'] {'not_if': '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1) '}
> 2016-07-18 20:42:20,298 - Execute['! (ls /var/run/hive/hive-interactive.pid 
> >/dev/null 2>&1 && ps -p 541 >/dev/null 2>&1)'] {'tries': 20, 'try_sleep': 3}
> 2016-07-18 20:42:20,316 - Retrying after 3 seconds. Reason: Execution of '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1)' returned 1. 
> 2016-07-18 20:42:23,338 - File['/var/run/hive/hive-interactive.pid'] 
> {'action': ['delete']}
> 2016-07-18 20:42:23,338 - Deleting File['/var/run/hive/hive-interactive.pid']
> 2016-07-18 20:42:23,338 - Stopping LLAP
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>

Re: Review Request 50159: HiveServer interactive stop should wait for 30 second before sending hard kill command

2016-07-18 Thread Swapan Shridhar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50159/#review142656
---


Ship it!




Ship It!

- Swapan Shridhar


On July 18, 2016, 9:37 p.m., Ajit Kumar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50159/
> ---
> 
> (Updated July 18, 2016, 9:37 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Sumit Mohanty, and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-17776
> https://issues.apache.org/jira/browse/AMBARI-17776
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HiveServer interactive stop should wait for 30 second before sending hard 
> kill command
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
>  1edcdca 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> 2a0674d 
> 
> Diff: https://reviews.apache.org/r/50159/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 2016-07-18 20:41:53,026 - Execute['! (ls /var/run/hive/hive-interactive.pid 
> >/dev/null 2>&1 && ps -p 541 >/dev/null 2>&1)'] {'tries': 10, 'try_sleep': 3}
> 2016-07-18 20:41:53,059 - Retrying after 3 seconds. Reason: Execution of '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1)' returned 1. 
> 2016-07-18 20:41:56,082 - Retrying after 3 seconds. Reason: Execution of '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1)' returned 1. 
> 2016-07-18 20:41:59,103 - Retrying after 3 seconds. Reason: Execution of '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1)' returned 1. 
> 2016-07-18 20:42:02,126 - Retrying after 3 seconds. Reason: Execution of '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1)' returned 1. 
> 2016-07-18 20:42:05,150 - Retrying after 3 seconds. Reason: Execution of '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1)' returned 1. 
> 2016-07-18 20:42:08,171 - Retrying after 3 seconds. Reason: Execution of '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1)' returned 1. 
> 2016-07-18 20:42:11,195 - Retrying after 3 seconds. Reason: Execution of '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1)' returned 1. 
> 2016-07-18 20:42:14,217 - Retrying after 3 seconds. Reason: Execution of '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1)' returned 1. 
> 2016-07-18 20:42:17,240 - Retrying after 3 seconds. Reason: Execution of '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1)' returned 1. 
> 2016-07-18 20:42:20,262 - Execute['ambari-sudo.sh kill -9 541'] {'not_if': '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1) '}
> 2016-07-18 20:42:20,298 - Execute['! (ls /var/run/hive/hive-interactive.pid 
> >/dev/null 2>&1 && ps -p 541 >/dev/null 2>&1)'] {'tries': 20, 'try_sleep': 3}
> 2016-07-18 20:42:20,316 - Retrying after 3 seconds. Reason: Execution of '! 
> (ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 
> >/dev/null 2>&1)' returned 1. 
> 2016-07-18 20:42:23,338 - File['/var/run/hive/hive-interactive.pid'] 
> {'action': ['delete']}
> 2016-07-18 20:42:23,338 - Deleting File['/var/run/hive/hive-interactive.pid']
> 2016-07-18 20:42:23,338 - Stopping LLAP
> 
> 
> Thanks,
> 
> Ajit Kumar
> 
>

Review Request 50165: AMBARI-17777 Unexpected behavior on Select Version page

2016-07-18 Thread Zhe (Joe) Wang


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50165/
---

Review request for Ambari, Jaimin Jetly, Richard Zang, Vivek Ratnavel 
Subramanian, Xi Wang, and Yusaku Sako.


Bugs: AMBARI-1
https://issues.apache.org/jira/browse/AMBARI-1


Repository: ambari


Description
---

STR:
# Go to SelectVersion page
# Clear any input with Base URL (for ex. ubuntu14)
# Click on next button

Expected: input has now red borders and warning message appears below 
"Attention: All repo URLs are required before you can proceed."

Actually: Next button became to disabled state. Next page wasn't loaded.


Diffs
-

  ambari-web/app/controllers/installer.js 037e555 
  ambari-web/app/models/operating_system.js c2588fe 

Diff: https://reviews.apache.org/r/50165/diff/


Testing
---

Local ambari-web test passed.
29285 tests complete (25 seconds)
154 tests pending
Manual testing done.


Thanks,

Zhe (Joe) Wang

Re: Review Request 50097: HAWQ install should recommend required values for HDFS properties

2016-07-18 Thread Alexander Denissov


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50097/
---

(Updated July 18, 2016, 10:01 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Lav Jain, and 
Matt.


Changes
---

rebased against latest


Bugs: AMBARI-17719
https://issues.apache.org/jira/browse/AMBARI-17719


Repository: ambari


Description
---

HAWQ install should recommend required values for HDFS properties


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HAWQ/2.0.0/service_advisor.py 
feb3d52 
  ambari-server/src/main/resources/stacks/stack_advisor.py fb30f4d 
  ambari-server/src/test/python/common-services/HAWQ/test_service_advisor.py 
780370d 

Diff: https://reviews.apache.org/r/50097/diff/


Testing
---

Tested manually, updated unit tests.


Thanks,

Alexander Denissov

Re: Review Request 49891: Restart indicator is not shown after modifying the configs

2016-07-18 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49891/#review142643
---




ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
(line 133)


Have you considered using a ConcurrentHashMap instead?


With these changes do we still need STALE_CONFIGS_CACHE_EXPIRATION_TIME ? This 
expiration itself was a workaround for similar/same issue.

- Sid Wagle


On July 15, 2016, 10:26 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49891/
> ---
> 
> (Updated July 15, 2016, 10:26 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17651
> https://issues.apache.org/jira/browse/AMBARI-17651
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Restart indicator is not shown after modifying the configs.
> Test case modified the hdfs config 'Namenode new generation size'. But still 
> after saving the configuration, restart icon is not shown.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/annotations/TransactionalLock.java
>  5934f5a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  94a8fe0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
>  d4e3828 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 46a3f3e 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
> 92ec843 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  fdb997b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  666111b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java
>  dc8017a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
>  0ff143c 
> 
> Diff: https://reviews.apache.org/r/49891/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Review Request 50159: HiveServer interactive stop should wait for 30 second before sending hard kill command

2016-07-18 Thread Ajit Kumar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50159/
---

Review request for Ambari, Jayush Luniya and Sumit Mohanty.


Bugs: AMBARI-17776
https://issues.apache.org/jira/browse/AMBARI-17776


Repository: ambari


Description
---

HiveServer interactive stop should wait for 30 second before sending hard kill 
command


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_service_interactive.py
 1edcdca 
  ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 2a0674d 

Diff: https://reviews.apache.org/r/50159/diff/


Testing
---

Manually tested.

2016-07-18 20:41:53,026 - Execute['! (ls /var/run/hive/hive-interactive.pid 
>/dev/null 2>&1 && ps -p 541 >/dev/null 2>&1)'] {'tries': 10, 'try_sleep': 3}
2016-07-18 20:41:53,059 - Retrying after 3 seconds. Reason: Execution of '! (ls 
/var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null 
2>&1)' returned 1. 
2016-07-18 20:41:56,082 - Retrying after 3 seconds. Reason: Execution of '! (ls 
/var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null 
2>&1)' returned 1. 
2016-07-18 20:41:59,103 - Retrying after 3 seconds. Reason: Execution of '! (ls 
/var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null 
2>&1)' returned 1. 
2016-07-18 20:42:02,126 - Retrying after 3 seconds. Reason: Execution of '! (ls 
/var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null 
2>&1)' returned 1. 
2016-07-18 20:42:05,150 - Retrying after 3 seconds. Reason: Execution of '! (ls 
/var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null 
2>&1)' returned 1. 
2016-07-18 20:42:08,171 - Retrying after 3 seconds. Reason: Execution of '! (ls 
/var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null 
2>&1)' returned 1. 
2016-07-18 20:42:11,195 - Retrying after 3 seconds. Reason: Execution of '! (ls 
/var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null 
2>&1)' returned 1. 
2016-07-18 20:42:14,217 - Retrying after 3 seconds. Reason: Execution of '! (ls 
/var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null 
2>&1)' returned 1. 
2016-07-18 20:42:17,240 - Retrying after 3 seconds. Reason: Execution of '! (ls 
/var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null 
2>&1)' returned 1. 
2016-07-18 20:42:20,262 - Execute['ambari-sudo.sh kill -9 541'] {'not_if': '! 
(ls /var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null 
2>&1) '}
2016-07-18 20:42:20,298 - Execute['! (ls /var/run/hive/hive-interactive.pid 
>/dev/null 2>&1 && ps -p 541 >/dev/null 2>&1)'] {'tries': 20, 'try_sleep': 3}
2016-07-18 20:42:20,316 - Retrying after 3 seconds. Reason: Execution of '! (ls 
/var/run/hive/hive-interactive.pid >/dev/null 2>&1 && ps -p 541 >/dev/null 
2>&1)' returned 1. 
2016-07-18 20:42:23,338 - File['/var/run/hive/hive-interactive.pid'] {'action': 
['delete']}
2016-07-18 20:42:23,338 - Deleting File['/var/run/hive/hive-interactive.pid']
2016-07-18 20:42:23,338 - Stopping LLAP


Thanks,

Ajit Kumar

Re: Review Request 50153: NFS_GATEWAY version reports incorrect in DB after EU

2016-07-18 Thread Jonathan Hurley


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50153/#review142632
---


Ship it!




Ship It!

- Jonathan Hurley


On July 18, 2016, 4:05 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50153/
> ---
> 
> (Updated July 18, 2016, 4:05 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-17773
> https://issues.apache.org/jira/browse/AMBARI-17773
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> For some reason, NFS_GATEWAY was defined as not-advertising-version, when 
> hdp-select has been supporting this since 2.3.0.0.  Mark it as such, and add 
> NFS_GATEWAY to 2.[3|4]->2.[4|5] RU Upgrade Packs.  Those EU Upgrade Packs 
> already had NFS_GATEWAY defined.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml 
> f19110e 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
> b139d2e 
>   ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
> 09007a6 
>   ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
> a9336bb 
> 
> Diff: https://reviews.apache.org/r/50153/diff/
> 
> 
> Testing
> ---
> 
> Manual testing to confirm both RU and EU address NFS_GATEWAY and update the 
> DB correctly.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 50087: Ambari should have a script to add new repository and service to existing stack

2016-07-18 Thread Lav Jain


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50087/
---

(Updated July 18, 2016, 8:51 p.m.)


Review request for Ambari, Alexander Denissov, Jayush Luniya, Matt, and Tim 
Thorpe.


Bugs: AMBARI-17717
https://issues.apache.org/jira/browse/AMBARI-17717


Repository: ambari


Description
---

Ambari should have a script that users can run to add a custom service and 
repository to the stack or an existing cluster.

```
Lavs-MacBook-Pro:scripts ljain$ ./add_common_service.py -h
Usage: add_common_service.py [options]

Options:
  -h, --helpshow this help message and exit
  -u USER, --user=USER  Ambari login username (Required)
  -p PASSWORD, --password=PASSWORD
Ambari login password. Providing password through
command line is not recommended. The script prompts
for the password.
  -t STACK, --stack=STACK
Stack Name and Version to be added (Required).(Eg:
HDP-2.4 or HDP-2.5)
  -s SERVICE, --service=SERVICE
Service Name and Version to be added.(Eg: HAWQ/2.0.0
or PXF/3.0.0)
  -r REPOURL, --repourl=REPOURL
Repository URL which points to the rpm packages
  -i REPOID, --repoid=REPOID
Repository ID of the new repository
  -o OSTYPE, --ostype=OSTYPE
OS for the new repository (Eg: redhat6)
```


Diffs (updated)
-

  ambari-server/src/main/resources/scripts/add_common_service.py PRE-CREATION 

Diff: https://reviews.apache.org/r/50087/diff/


Testing
---

Tested manually with various combinations


Thanks,

Lav Jain

Review Request 50157: HST agent logs not parsed

2016-07-18 Thread Oliver Szabo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50157/
---

Review request for Ambari, Miklos Gergely, Robert Nettleton, and Sumit Mohanty.


Bugs: AMBARI-17774
https://issues.apache.org/jira/browse/AMBARI-17774


Repository: ambari


Description
---

hst agent logs are not parsed. I guess that could be because in some point the 
pattern is changed.


Diffs
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/input.config-hst.json.j2
 6c216f4 

Diff: https://reviews.apache.org/r/50157/diff/


Testing
---

Total run:1020
Total errors:0
Total failures:0


Thanks,

Oliver Szabo

Re: Review Request 50153: NFS_GATEWAY version reports incorrect in DB after EU

2016-07-18 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50153/
---

(Updated July 18, 2016, 4:05 p.m.)


Review request for Ambari, Alejandro Fernandez and Jonathan Hurley.


Bugs: AMBARI-17773
https://issues.apache.org/jira/browse/AMBARI-17773


Repository: ambari


Description (updated)
---

For some reason, NFS_GATEWAY was defined as not-advertising-version, when 
hdp-select has been supporting this since 2.3.0.0.  Mark it as such, and add 
NFS_GATEWAY to 2.[3|4]->2.[4|5] RU Upgrade Packs.  Those EU Upgrade Packs 
already had NFS_GATEWAY defined.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/metainfo.xml 
f19110e 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 
b139d2e 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
09007a6 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
a9336bb 

Diff: https://reviews.apache.org/r/50153/diff/


Testing
---

Manual testing to confirm both RU and EU address NFS_GATEWAY and update the DB 
correctly.


Thanks,

Nate Cole

Re: Review Request 50121: AMBARI-17763 Populating Ranger Tagsync principal/keytab using stack advisor

2016-07-18 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50121/#review142617
---


Ship it!




Ship It!

- Robert Levas


On July 18, 2016, 3:43 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50121/
> ---
> 
> (Updated July 18, 2016, 3:43 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Robert Levas, Sumit Mohanty, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17763
> https://issues.apache.org/jira/browse/AMBARI-17763
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> atlas.jaas.KafkaClient.option.keyTab and 
> atlas.jaas.KafkaClient.option.principal properties are needed in 
> tagsync-application-properties.xml when kerberos is enabled. These properties 
> should have Ranger Tagsync principal/keytab.
> 
> To achieve this changing the implementation from macro to stack advisor
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> 564c57b 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> db3614f 
> 
> Diff: https://reviews.apache.org/r/50121/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger installation along with Atlas.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 50121: AMBARI-17763 Populating Ranger Tagsync principal/keytab using stack advisor

2016-07-18 Thread Mugdha Varadkar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50121/
---

(Updated July 18, 2016, 7:43 p.m.)


Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
Robert Levas, Sumit Mohanty, Srimanth Gunturi, and Velmurugan Periasamy.


Bugs: AMBARI-17763
https://issues.apache.org/jira/browse/AMBARI-17763


Repository: ambari


Description
---

atlas.jaas.KafkaClient.option.keyTab and 
atlas.jaas.KafkaClient.option.principal properties are needed in 
tagsync-application-properties.xml when kerberos is enabled. These properties 
should have Ranger Tagsync principal/keytab.

To achieve this changing the implementation from macro to stack advisor


Diffs (updated)
-

  ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
564c57b 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
db3614f 

Diff: https://reviews.apache.org/r/50121/diff/


Testing
---

Tested Ranger installation along with Atlas.


Thanks,

Mugdha Varadkar

Re: Review Request 50101: Cluster user role is permitted to install packages using API

2016-07-18 Thread Nate Cole


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50101/#review142585
---


Ship it!




Ship It!

- Nate Cole


On July 15, 2016, 8:31 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50101/
> ---
> 
> (Updated July 15, 2016, 8:31 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Myroslav Papirkovskyy, Nate Cole, 
> and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-17740
> https://issues.apache.org/jira/browse/AMBARI-17740
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With "Cluster User" role, submitting "install packages" API call goes 
> through, even though it should be blocked
> 
> ```
> #curl -u cu:1234 -H "X-Requested-By: ambari" -i -X  POST 
> http://ambari-server:8080/api/v1/clusters/cl1/stack_versions -d 
> '{"ClusterStackVersions":{"stack":"HDP","version":"2.3","repository_version":"2.3.0.0"}}'
> HTTP/1.1 202 Accepted
> Date: Wed, 29 Jun 2016 05:55:16 GMT
> X-Frame-Options: DENY
> X-XSS-Protection: 1; mode=block
> Set-Cookie: AMBARISESSIONID=11njwu8py6m511511liub068vj;Path=/;HttpOnly
> Expires: Thu, 01 Jan 1970 00:00:00 GMT
> User: cu
> Content-Type: text/plain
> Vary: Accept-Encoding, User-Agent
> Content-Length: 136
> Server: Jetty(9.2.11.v20150529)
> 
> {
>   "href" : "http://ambari-server:8080/api/v1/clusters/cl1/requests/36;,
>   "Requests" : {
> "id" : 36,
> "status" : "Accepted"
>   }
> }
> ```
> 
> Role of the user "cu"
> ```
> {
>   "href" : "http://ambari-server:8080/api/v1/users/cu/privileges/7;,
>   "PrivilegeInfo" : {
> "cluster_name" : "cl1",
> "permission_label" : "Cluster User",
> "permission_name" : "CLUSTER.USER",
> "principal_name" : "cu",
> "principal_type" : "USER",
> "privilege_id" : 7,
> "type" : "CLUSTER",
> "user_name" : "cu"
>   }
> }
> ```
> 
> # Solution
> Protect access to this API by allowing only users with the 
> `AMBARI.MANAGE_STACK_VERSIONS` authorization to create, update, and delete 
> stack versions.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  c11cd81 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProviderTest.java
>  a438edb 
> 
> Diff: https://reviews.apache.org/r/50101/diff/
> 
> 
> Testing
> ---
> 
> Manually tested
> 
> # Local test results: 
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 1:12:52.071s
> [INFO] Finished at: Fri Jul 15 19:27:40 EDT 2016
> [INFO] Final Memory: 62M/1889M
> [INFO] 
> 
> 
> # Jenkins test results: PENDING
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 49891: Restart indicator is not shown after modifying the configs

2016-07-18 Thread Sid Wagle


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49891/#review142569
---




ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
(line 75)


Important to docuemnt why this is needed.



ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
(line 503)


Remianing comment about why it is on a separate thread is still relevant.


- Sid Wagle


On July 15, 2016, 10:26 a.m., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49891/
> ---
> 
> (Updated July 15, 2016, 10:26 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17651
> https://issues.apache.org/jira/browse/AMBARI-17651
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Restart indicator is not shown after modifying the configs.
> Test case modified the hdfs config 'Namenode new generation size'. But still 
> after saving the configuration, restart icon is not shown.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/annotations/TransactionalLock.java
>  5934f5a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  94a8fe0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
>  d4e3828 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 46a3f3e 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
> 92ec843 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  fdb997b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  666111b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java
>  dc8017a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
>  0ff143c 
> 
> Diff: https://reviews.apache.org/r/49891/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 50121: AMBARI-17763 Populating Ranger Tagsync principal/keytab using stack advisor

2016-07-18 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50121/#review142568
---


Ship it!




Ship It!

- Robert Levas


On July 18, 2016, 4:49 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50121/
> ---
> 
> (Updated July 18, 2016, 4:49 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
> Robert Levas, Sumit Mohanty, Srimanth Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17763
> https://issues.apache.org/jira/browse/AMBARI-17763
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> atlas.jaas.KafkaClient.option.keyTab and 
> atlas.jaas.KafkaClient.option.principal properties are needed in 
> tagsync-application-properties.xml when kerberos is enabled. These properties 
> should have Ranger Tagsync principal/keytab.
> 
> To achieve this changing the implementation from macro to stack advisor
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
> 91a0032 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> b84910a 
> 
> Diff: https://reviews.apache.org/r/50121/diff/
> 
> 
> Testing
> ---
> 
> Tested Ranger installation along with Atlas.
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Review Request 50140: AMBARI-17771 : Update alert definition for Ranger Admin after kerberos changes

2016-07-18 Thread Gautam Borad


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50140/
---

Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Mahadev Konar, 
Sumit Mohanty, Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan Periasamy.


Bugs: AMBARI-17771
https://issues.apache.org/jira/browse/AMBARI-17771


Repository: ambari


Description
---

Update alert definition URI after stack is updated.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigAction.java
 PRE-CREATION 
  
ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
 7be5a1915c00853b2817b815124752063222d59d 
  ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 
47d9fdb999ef6e7051bd339502e98d30b7c53fc2 
  
ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
 2daa9b8907aa8159829b40007ec2ae81ffcdb29c 
  ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 
dd7a87f72d1cbbbc9db6027af6c61292743a133a 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerWebAlertConfigActionTest.java
 PRE-CREATION 
  ambari-server/src/test/resources/stacks/HDP/2.5.0/services/RANGER/alerts.json 
PRE-CREATION 

Diff: https://reviews.apache.org/r/50140/diff/


Testing
---

Tested on a centos 6 cluster after upgrade and checked that the alert works 
fine for Ranger Admin.


Thanks,

Gautam Borad

Re: Review Request 50132: AMBARI-17767 Ranger UserSync stopped after EU from 2.2.9 to 2.4.2 with SSLHandshakeException

2016-07-18 Thread Gautam Borad


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50132/#review142565
---


Ship it!




Ship It!

- Gautam Borad


On July 18, 2016, 1:02 p.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50132/
> ---
> 
> (Updated July 18, 2016, 1:02 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Gautam Borad, Srimanth 
> Gunturi, and Velmurugan Periasamy.
> 
> 
> Bugs: AMBARI-17767
> https://issues.apache.org/jira/browse/AMBARI-17767
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps to reproduce:
> - Deploy 2.2.9 cluster with Ambari 2.2.1.1
> - Upgrade Ambari to 2.4.0.0
> - Perform Express Upgrade (EU) to 2.4.2.0 and let it complete
> - Observed that after EU, Ranger Usersync reports as down
> 
> Analysis:
> For HDP 2.2 usersync process was started with root user and from HDP-2.3 
> onwards we support usersync process start for non-root user.
> Usersync process didn't started due /var/log/ranger/usersync/auth.log: 
> Permission denied, which still had root permission after upgrade.
> 
> Solution:
> Need to give recursive file-level ownership for log path 
> /var/log/ranger/usersync
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
>  7079626 
>   ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_usersync.py 
> 7b6e782 
> 
> Diff: https://reviews.apache.org/r/50132/diff/
> 
> 
> Testing
> ---
> 
> Tested EU from 2.2.9 to 2.4.2.0
> 
> Running tests for stack:2.5 service:RANGER
> test_configure_default (test_ranger_admin.TestRangerAdmin) ... ok
> test_configure_secured (test_ranger_admin.TestRangerAdmin) ... ok
> test_start_default (test_ranger_admin.TestRangerAdmin) ... ok
> test_start_secured (test_ranger_admin.TestRangerAdmin) ... ok
> test_stop_default (test_ranger_admin.TestRangerAdmin) ... ok
> test_configure_default (test_ranger_usersync.TestRangerUsersync) ... ok
> test_configure_secured (test_ranger_usersync.TestRangerUsersync) ... ok
> test_start_default (test_ranger_usersync.TestRangerUsersync) ... ok
> test_stop_default (test_ranger_usersync.TestRangerUsersync) ... ok
> test_configure_default (test_ranger_tagsync.TestRangerTagsync) ... ok
> test_configure_secured (test_ranger_tagsync.TestRangerTagsync) ... ok
> test_start_default (test_ranger_tagsync.TestRangerTagsync) ... ok
> test_stop_default (test_ranger_tagsync.TestRangerTagsync) ... ok
> 
> --
> Ran 13 tests in 0.408s
> 
> OK
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Review Request 50139: HDFS Service Check failure on Wireencrypted clusters with Ambari2400+HDP2.4.2.0

2016-07-18 Thread Dmytro Sen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50139/
---

Review request for Ambari, Dmitro Lisnichenko and Myroslav Papirkovskyy.


Bugs: AMBARI-17770
https://issues.apache.org/jira/browse/AMBARI-17770


Repository: ambari


Description
---

Deployed secure cluster with Ambari2400 + HDP2.4.2.0 public repo.
Enable NNHA
Enable wireencryption
HDFS Service check fails with the below error


Traceback (most recent call last):
  File 
"/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py",
 line 146, in 
HdfsServiceCheck().execute()
  File 
"/usr/lib/python2.6/site-packages/resource_management/libraries/script/script.py",
 line 280, in execute
method(env)
  File 
"/var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py",
 line 98, in service_check
user=params.smoke_user
  File "/usr/lib/python2.6/site-packages/resource_management/core/base.py", 
line 155, in __init__
self.env.run()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 160, in run
self.run_action(resource, action)
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/environment.py", 
line 124, in run_action
provider_action()
  File 
"/usr/lib/python2.6/site-packages/resource_management/core/providers/system.py",
 line 273, in action_run
tries=self.resource.tries, try_sleep=self.resource.try_sleep)
  File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
line 71, in inner
result = function(command, **kwargs)
  File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
line 93, in checked_call
tries=tries, try_sleep=try_sleep)
  File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
line 141, in _call_wrapper
result = _call(command, **kwargs_copy)
  File "/usr/lib/python2.6/site-packages/resource_management/core/shell.py", 
line 294, in _call
raise Fail(err_msg)
resource_management.core.exceptions.Fail: Execution of 'ambari-python-wrap 
/var/lib/ambari-agent/tmp/checkWebUI.py '  returned 1. Cannot access WEB UI on:


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/files/checkWebUI.py
 aa60ffc 

Diff: https://reviews.apache.org/r/50139/diff/


Testing
---

Unit tests


Thanks,

Dmytro Sen

Review Request 50135: Oozie can not be set up with external DB

2016-07-18 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50135/
---

Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.


Bugs: AMBARI-17768
https://issues.apache.org/jira/browse/AMBARI-17768


Repository: ambari


Description
---

# setup oozie db mysql
# Oozie can not be started
{code}
resource_management.core.exceptions.Fail: Execution of 
'/usr/jdk64/jdk1.8.0_60/bin/java -cp 
/usr/lib/ambari-agent/DBConnectionVerification.jar:/usr/hdp/current/oozie-server/libext/mysql-connector-java.jar
 org.apache.ambari.server.DBConnectionVerification 
'jdbc:mysql://c6403.ambari.apache.org/ooziedb' oozieuser [PROTECTED] 
com.mysql.jdbc.Driver' returned 1. Error: Could not find or load main class 
org.apache.ambari.server.DBConnectionVerification
{code}
{code}ll /var/lib/ambari-agent/tmp/DBConnectionVerification.jar
-rw-r- 1 root root 1931 Jul 15 17:58 
/var/lib/ambari-agent/tmp/DBConnectionVerification.jar
{code}
user oozie have no permission


Diffs
-

  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
 d5164fe 

Diff: https://reviews.apache.org/r/50135/diff/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 50135: Oozie can not be set up with external DB

2016-07-18 Thread Dmytro Sen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50135/#review142559
---


Ship it!




Ship It!

- Dmytro Sen


On Июль 18, 2016, 2:13 п.п., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50135/
> ---
> 
> (Updated Июль 18, 2016, 2:13 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-17768
> https://issues.apache.org/jira/browse/AMBARI-17768
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> # setup oozie db mysql
> # Oozie can not be started
> {code}
> resource_management.core.exceptions.Fail: Execution of 
> '/usr/jdk64/jdk1.8.0_60/bin/java -cp 
> /usr/lib/ambari-agent/DBConnectionVerification.jar:/usr/hdp/current/oozie-server/libext/mysql-connector-java.jar
>  org.apache.ambari.server.DBConnectionVerification 
> 'jdbc:mysql://c6403.ambari.apache.org/ooziedb' oozieuser [PROTECTED] 
> com.mysql.jdbc.Driver' returned 1. Error: Could not find or load main class 
> org.apache.ambari.server.DBConnectionVerification
> {code}
> {code}ll /var/lib/ambari-agent/tmp/DBConnectionVerification.jar
> -rw-r- 1 root root 1931 Jul 15 17:58 
> /var/lib/ambari-agent/tmp/DBConnectionVerification.jar
> {code}
> user oozie have no permission
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
>  d5164fe 
> 
> Diff: https://reviews.apache.org/r/50135/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Re: Review Request 50069: Docker based dev environment for Log Search

2016-07-18 Thread Miklos Gergely


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50069/#review142558
---


Ship it!




Ship It!

- Miklos Gergely


On July 18, 2016, 1:28 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50069/
> ---
> 
> (Updated July 18, 2016, 1:28 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Dharmesh Makwana, Miklos Gergely, 
> Nate Cole, Robert Nettleton, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-17723
> https://issues.apache.org/jira/browse/AMBARI-17723
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add abillity to setup a qucik dev env for docker with debug capabilities.
> Goals:
> - setup an env quickly without Ambari (logsearch + logfeeder + solr)
> - later create integration test framework based on that (junit/jbehave 
> managed containers, pinging solr for results etc.)
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/README.md 04fdf2f 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java
>  15dd5c9 
>   
> ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
>  43d908e 
>   ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh dba85fa 
>   ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh ca587d5 
>   ambari-logsearch/docker/.gitignore PRE-CREATION 
>   ambari-logsearch/docker/Dockerfile PRE-CREATION 
>   ambari-logsearch/docker/bin/start.sh PRE-CREATION 
>   ambari-logsearch/docker/logsearch-docker.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/logfeeder/log4j.xml PRE-CREATION 
>   ambari-logsearch/docker/test-config/logfeeder/logfeeder-env.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/logfeeder/logfeeder.properties 
> PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/global.config.json 
> PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-logsearch.json
>  PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-zookeeper.json
>  PRE-CREATION 
>   
> ambari-logsearch/docker/test-config/logfeeder/shipper-conf/output.config.json 
> PRE-CREATION 
>   ambari-logsearch/docker/test-config/logsearch/log4j.xml PRE-CREATION 
>   ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/logsearch/logsearch.properties 
> PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/log4j.properties PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/solr-env.sh PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/solr.xml PRE-CREATION 
>   ambari-logsearch/docker/test-config/solr/zoo.cfg PRE-CREATION 
>   ambari-logsearch/docker/test-logs/logsearch/logsearch-test-log.json 
> PRE-CREATION 
>   ambari-logsearch/docker/test-logs/zookeeper/zookeeper-test-log.txt 
> PRE-CREATION 
>   ambari-logsearch/pom.xml 81da0f2 
> 
> Diff: https://reviews.apache.org/r/50069/diff/
> 
> 
> Testing
> ---
> 
> From Apache jenkins:
> ++1 overall. Here are the results of testing the latest attachment 
> http://issues.apache.org/jira/secure/attachment/12818065/AMBARI-17723.patch
> against trunk revision .
> +1 @author. The patch does not contain any @author tags.
> +1 tests included. The patch appears to include 16 new or modified test files.
> +1 javac. The applied patch does not increase the total number of javac 
> compiler warnings.
> +1 release audit. The applied patch does not increase the total number of 
> release audit warnings.
> +1 core tests. The patch passed unit tests in 
> ambari-logsearch/ambari-logsearch-logfeeder 
> ambari-logsearch/ambari-logsearch-portal.
> Test results: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7855//testReport/
> Console output: 
> https://builds.apache.org/job/Ambari-trunk-test-patch/7855//console
> This message is automatically generated.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 50136: property_description is null for some properties in config page

2016-07-18 Thread Dmytro Sen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50136/#review142557
---


Ship it!




Ship It!

- Dmytro Sen


On Июль 18, 2016, 1:53 п.п., Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50136/
> ---
> 
> (Updated Июль 18, 2016, 1:53 п.п.)
> 
> 
> Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-17769
> https://issues.apache.org/jira/browse/AMBARI-17769
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Please see the below proeprties where property_description is missing or is 
> null("property_description" : null)
> "property_name" : "hadoop.security.key.provider.path",
> "property_name" : "nfs.exports.allowed.hosts",
> "property_name" : "capacity-scheduler",
> "property_name" : "yarn.nodemanager.aux-services.spark2_shuffle.classpath",
> "property_name" : "yarn.nodemanager.aux-services.spark_shuffle.classpath",
> "property_name" : "yarn.resourcemanager.scheduler.monitor.enable",
> "property_name" : "yarn.scheduler.capacity.resource-calculator",
> "property_name" : 
> "yarn.timeline-service.entity-group-fs-store.cleaner-interval-seconds",
> "property_name" : 
> "yarn.timeline-service.entity-group-fs-store.retain-seconds",
> "property_name" : 
> "yarn.timeline-service.entity-group-fs-store.scan-interval-seconds",
> "property_name" : "yarn.timeline-service.entity-group-fs-store.summary-store"
> "property_name" : "yarn.timeline-service.recovery.enabled",
> You can see the same in this 
> [log|http://qelog.hortonworks.com/log/nat-d7-xtgs-ambari-config-8/test-logs/ambari-config/artifacts/screenshots/com.hw.ambari.ui.tests.monitoring.services_page.TestPropertyFilterOnServicesConfigs/checkPropertyFilterOnServicesPage/_30_4_25_20_Incorrect_filter_work_with_keyword_and_OverriddenPropertiesfalse_/test_logs/test_TestPropertyFilterOnServicesConfigs_debug.log]
>   file from artifacts link
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/core-site.xml
>  fdb7ce3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hdfs-site.xml
>  adcd9c8 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/capacity-scheduler.xml
>  90e64b0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml
>  2d545d7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/services/YARN/configuration/capacity-scheduler.xml
>  2ce0d25 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/services/YARN/configuration/yarn-site.xml
>  0eb515c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hdfs-site.xml
>  d221143 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-site.xml
>  463f80e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/configuration/capacity-scheduler.xml
>  adfa4af 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/configuration/yarn-site.xml
>  f1b73dc 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HDFS/configuration/core-site.xml
>  fb46b74 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HDFS/configuration/hdfs-site.xml
>  caa977f 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/YARN/configuration/capacity-scheduler.xml
>  6a957c0 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/YARN/configuration/yarn-site.xml
>  62c5693 
>   
> ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HDFS/configuration/hdfs-site.xml
>  41590b6 
>   
> ambari-server/src/main/resources/stacks/PHD/3.0/services/HDFS/configuration/core-site.xml
>  ab67a5b 
>   
> ambari-server/src/main/resources/stacks/PHD/3.0/services/HDFS/configuration/hdfs-site.xml
>  df2c591 
> 
> Diff: https://reviews.apache.org/r/50136/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Review Request 50136: property_description is null for some properties in config page

2016-07-18 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50136/
---

Review request for Ambari, Dmytro Sen and Myroslav Papirkovskyy.


Bugs: AMBARI-17769
https://issues.apache.org/jira/browse/AMBARI-17769


Repository: ambari


Description
---

Please see the below proeprties where property_description is missing or is 
null("property_description" : null)
"property_name" : "hadoop.security.key.provider.path",
"property_name" : "nfs.exports.allowed.hosts",
"property_name" : "capacity-scheduler",
"property_name" : "yarn.nodemanager.aux-services.spark2_shuffle.classpath",
"property_name" : "yarn.nodemanager.aux-services.spark_shuffle.classpath",
"property_name" : "yarn.resourcemanager.scheduler.monitor.enable",
"property_name" : "yarn.scheduler.capacity.resource-calculator",
"property_name" : 
"yarn.timeline-service.entity-group-fs-store.cleaner-interval-seconds",
"property_name" : "yarn.timeline-service.entity-group-fs-store.retain-seconds",
"property_name" : 
"yarn.timeline-service.entity-group-fs-store.scan-interval-seconds",
"property_name" : "yarn.timeline-service.entity-group-fs-store.summary-store"
"property_name" : "yarn.timeline-service.recovery.enabled",
You can see the same in this 
[log|http://qelog.hortonworks.com/log/nat-d7-xtgs-ambari-config-8/test-logs/ambari-config/artifacts/screenshots/com.hw.ambari.ui.tests.monitoring.services_page.TestPropertyFilterOnServicesConfigs/checkPropertyFilterOnServicesPage/_30_4_25_20_Incorrect_filter_work_with_keyword_and_OverriddenPropertiesfalse_/test_logs/test_TestPropertyFilterOnServicesConfigs_debug.log]
  file from artifacts link


Diffs
-

  
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/core-site.xml
 fdb7ce3 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/HDFS/configuration/hdfs-site.xml
 adcd9c8 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/capacity-scheduler.xml
 90e64b0 
  
ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/configuration/yarn-site.xml
 2d545d7 
  
ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/services/YARN/configuration/capacity-scheduler.xml
 2ce0d25 
  
ambari-server/src/main/resources/stacks/HDP/2.3.GlusterFS/services/YARN/configuration/yarn-site.xml
 0eb515c 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/HDFS/configuration/hdfs-site.xml
 d221143 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-site.xml
 463f80e 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/configuration/capacity-scheduler.xml
 adfa4af 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/configuration/yarn-site.xml
 f1b73dc 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HDFS/configuration/core-site.xml
 fb46b74 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/HDFS/configuration/hdfs-site.xml
 caa977f 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/YARN/configuration/capacity-scheduler.xml
 6a957c0 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/YARN/configuration/yarn-site.xml
 62c5693 
  
ambari-server/src/main/resources/stacks/HDPWIN/2.3/services/HDFS/configuration/hdfs-site.xml
 41590b6 
  
ambari-server/src/main/resources/stacks/PHD/3.0/services/HDFS/configuration/core-site.xml
 ab67a5b 
  
ambari-server/src/main/resources/stacks/PHD/3.0/services/HDFS/configuration/hdfs-site.xml
 df2c591 

Diff: https://reviews.apache.org/r/50136/diff/


Testing
---

mvn clean test


Thanks,

Dmitro Lisnichenko

Re: Review Request 50069: Docker based dev environment for Log Search

2016-07-18 Thread Oliver Szabo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50069/
---

(Updated July 18, 2016, 1:28 p.m.)


Review request for Ambari, Jonathan Hurley, Dharmesh Makwana, Miklos Gergely, 
Nate Cole, Robert Nettleton, Sumit Mohanty, and Sebastian Toader.


Changes
---

small fixes


Bugs: AMBARI-17723
https://issues.apache.org/jira/browse/AMBARI-17723


Repository: ambari


Description
---

Add abillity to setup a qucik dev env for docker with debug capabilities.
Goals:
- setup an env quickly without Ambari (logsearch + logfeeder + solr)
- later create integration test framework based on that (junit/jbehave managed 
containers, pinging solr for results etc.)


Diffs (updated)
-

  ambari-logsearch/README.md 04fdf2f 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java
 15dd5c9 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
 43d908e 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh dba85fa 
  ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh ca587d5 
  ambari-logsearch/docker/.gitignore PRE-CREATION 
  ambari-logsearch/docker/Dockerfile PRE-CREATION 
  ambari-logsearch/docker/bin/start.sh PRE-CREATION 
  ambari-logsearch/docker/logsearch-docker.sh PRE-CREATION 
  ambari-logsearch/docker/test-config/logfeeder/log4j.xml PRE-CREATION 
  ambari-logsearch/docker/test-config/logfeeder/logfeeder-env.sh PRE-CREATION 
  ambari-logsearch/docker/test-config/logfeeder/logfeeder.properties 
PRE-CREATION 
  ambari-logsearch/docker/test-config/logfeeder/shipper-conf/global.config.json 
PRE-CREATION 
  
ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-logsearch.json
 PRE-CREATION 
  
ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-zookeeper.json
 PRE-CREATION 
  ambari-logsearch/docker/test-config/logfeeder/shipper-conf/output.config.json 
PRE-CREATION 
  ambari-logsearch/docker/test-config/logsearch/log4j.xml PRE-CREATION 
  ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh PRE-CREATION 
  ambari-logsearch/docker/test-config/logsearch/logsearch.properties 
PRE-CREATION 
  ambari-logsearch/docker/test-config/solr/log4j.properties PRE-CREATION 
  ambari-logsearch/docker/test-config/solr/solr-env.sh PRE-CREATION 
  ambari-logsearch/docker/test-config/solr/solr.xml PRE-CREATION 
  ambari-logsearch/docker/test-config/solr/zoo.cfg PRE-CREATION 
  ambari-logsearch/docker/test-logs/logsearch/logsearch-test-log.json 
PRE-CREATION 
  ambari-logsearch/docker/test-logs/zookeeper/zookeeper-test-log.txt 
PRE-CREATION 
  ambari-logsearch/pom.xml 81da0f2 

Diff: https://reviews.apache.org/r/50069/diff/


Testing
---

>From Apache jenkins:
++1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12818065/AMBARI-17723.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 16 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in 
ambari-logsearch/ambari-logsearch-logfeeder 
ambari-logsearch/ambari-logsearch-portal.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7855//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7855//console
This message is automatically generated.


Thanks,

Oliver Szabo

Review Request 50132: AMBARI-17767 Ranger UserSync stopped after EU from 2.2.9 to 2.4.2 with SSLHandshakeException

2016-07-18 Thread Mugdha Varadkar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50132/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Srimanth Gunturi, 
and Velmurugan Periasamy.


Bugs: AMBARI-17767
https://issues.apache.org/jira/browse/AMBARI-17767


Repository: ambari


Description
---

Steps to reproduce:
- Deploy 2.2.9 cluster with Ambari 2.2.1.1
- Upgrade Ambari to 2.4.0.0
- Perform Express Upgrade (EU) to 2.4.2.0 and let it complete
- Observed that after EU, Ranger Usersync reports as down

Analysis:
For HDP 2.2 usersync process was started with root user and from HDP-2.3 
onwards we support usersync process start for non-root user.
Usersync process didn't started due /var/log/ranger/usersync/auth.log: 
Permission denied, which still had root permission after upgrade.

Solution:
Need to give recursive file-level ownership for log path 
/var/log/ranger/usersync


Diffs
-

  
ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py
 7079626 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_usersync.py 
7b6e782 

Diff: https://reviews.apache.org/r/50132/diff/


Testing
---

Tested EU from 2.2.9 to 2.4.2.0

Running tests for stack:2.5 service:RANGER
test_configure_default (test_ranger_admin.TestRangerAdmin) ... ok
test_configure_secured (test_ranger_admin.TestRangerAdmin) ... ok
test_start_default (test_ranger_admin.TestRangerAdmin) ... ok
test_start_secured (test_ranger_admin.TestRangerAdmin) ... ok
test_stop_default (test_ranger_admin.TestRangerAdmin) ... ok
test_configure_default (test_ranger_usersync.TestRangerUsersync) ... ok
test_configure_secured (test_ranger_usersync.TestRangerUsersync) ... ok
test_start_default (test_ranger_usersync.TestRangerUsersync) ... ok
test_stop_default (test_ranger_usersync.TestRangerUsersync) ... ok
test_configure_default (test_ranger_tagsync.TestRangerTagsync) ... ok
test_configure_secured (test_ranger_tagsync.TestRangerTagsync) ... ok
test_start_default (test_ranger_tagsync.TestRangerTagsync) ... ok
test_stop_default (test_ranger_tagsync.TestRangerTagsync) ... ok

--
Ran 13 tests in 0.408s

OK


Thanks,

Mugdha Varadkar

Re: Review Request 50129: Hive View : Clicking on History button in saved search does not show history page

2016-07-18 Thread Pallav Kulshreshtha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50129/#review142550
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On July 18, 2016, 10:26 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50129/
> ---
> 
> (Updated July 18, 2016, 10:26 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17765
> https://issues.apache.org/jira/browse/AMBARI-17765
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed the simple javascript exception.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/history.js
>  ca6233c 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/history.js 
> ca6233c 
> 
> Diff: https://reviews.apache.org/r/50129/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 50129: Hive View : Clicking on History button in saved search does not show history page

2016-07-18 Thread Gaurav Nagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50129/#review142549
---


Ship it!




Ship It!

- Gaurav Nagar


On July 18, 2016, 10:26 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50129/
> ---
> 
> (Updated July 18, 2016, 10:26 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17765
> https://issues.apache.org/jira/browse/AMBARI-17765
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fixed the simple javascript exception.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/history.js
>  ca6233c 
>   
> contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/history.js 
> ca6233c 
> 
> Diff: https://reviews.apache.org/r/50129/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 49750: Upload table using Hive view will fail if Hive database is created with Location option

2016-07-18 Thread Pallav Kulshreshtha


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49750/#review142548
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On July 7, 2016, 11:32 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49750/
> ---
> 
> (Updated July 7, 2016, 11:32 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17605
> https://issues.apache.org/jira/browse/AMBARI-17605
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : the hive view takes up property hive.metastore.warehouse.dir for 
> location of temporary table. 
> 
> In this patch : Now it will use query describe formatted for finding the 
> actual location of temporary table.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/client/DDLDelegator.java
>  20b91f1 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/client/DDLDelegatorImpl.java
>  0171626 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/browser/HiveBrowserService.java
>  0da49c4 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
>  18da1ff 
> 
> Diff: https://reviews.apache.org/r/49750/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 50047: Kafka listeners property does not show SASL_PLAINTEXT protocol when Kerberos is enabled

2016-07-18 Thread Robert Levas


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50047/#review142546
---




ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
(line 18)


This is redundant...

`kafka-broker/listeners` = `kafka-broker/listeners`


- Robert Levas


On July 14, 2016, 5:08 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50047/
> ---
> 
> (Updated July 14, 2016, 5:08 p.m.)
> 
> 
> Review request for Ambari, Di Li and Robert Levas.
> 
> 
> Bugs: AMBARI-17694
> https://issues.apache.org/jira/browse/AMBARI-17694
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When kerberos is enabled, the protocol for listeners in 
> /etc/kafka/conf/server.properties is updated from PLAINTEXT to PLAINTEXTSASL, 
> even though the Ambari UI shows otherwise
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka.py
>  33275f9 
>   ambari-server/src/main/resources/common-services/KAFKA/0.9.0/kerberos.json 
> 2b1c01b 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 2a2a3a3 
>   ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 
> a6baeea 
> 
> Diff: https://reviews.apache.org/r/50047/diff/
> 
> 
> Testing
> ---
> 
> Added 1 new test case,
>  Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 50130: ZOOKEEPER_SERVER START is failed after upgrade from 2.1.1 to 2.4.0.0 and making adding ZK server

2016-07-18 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50130/#review142544
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On July 18, 2016, 1:37 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50130/
> ---
> 
> (Updated July 18, 2016, 1:37 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko and Myroslav Papirkovskyy.
> 
> 
> Bugs: AMBARI-17766
> https://issues.apache.org/jira/browse/AMBARI-17766
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR: 
> 1) Install old version regarding environment 
> 2) Enable AD security 
> 3) Make ambari only upgrade 
> 4) Disable security 
> 5) Add new Node 
> 6) Add ZK server on added node. 
> 7)Try to start Added ZK server
> Actual result:
> ZOOKEEPER_SERVER START is failed after upgrade from 2.1.1 to 2.4.0.0 and 
> making adding ZK server
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
> 990c314 
> 
> Diff: https://reviews.apache.org/r/50130/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 50069: Docker based dev environment for Log Search

2016-07-18 Thread Oliver Szabo


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50069/
---

(Updated July 18, 2016, 10:44 a.m.)


Review request for Ambari, Jonathan Hurley, Dharmesh Makwana, Miklos Gergely, 
Nate Cole, Robert Nettleton, Sumit Mohanty, and Sebastian Toader.


Changes
---

- rename logsearch docker script


Bugs: AMBARI-17723
https://issues.apache.org/jira/browse/AMBARI-17723


Repository: ambari


Description
---

Add abillity to setup a qucik dev env for docker with debug capabilities.
Goals:
- setup an env quickly without Ambari (logsearch + logfeeder + solr)
- later create integration test framework based on that (junit/jbehave managed 
containers, pinging solr for results etc.)


Diffs (updated)
-

  ambari-logsearch/README.md 04fdf2f 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeederUtil.java
 15dd5c9 
  
ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/output/OutputSolr.java
 43d908e 
  ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh dba85fa 
  ambari-logsearch/ambari-logsearch-portal/src/main/scripts/run.sh ca587d5 
  ambari-logsearch/docker/.gitignore PRE-CREATION 
  ambari-logsearch/docker/Dockerfile PRE-CREATION 
  ambari-logsearch/docker/bin/start.sh PRE-CREATION 
  ambari-logsearch/docker/logsearch-docker.sh PRE-CREATION 
  ambari-logsearch/docker/test-config/logfeeder/log4j.xml PRE-CREATION 
  ambari-logsearch/docker/test-config/logfeeder/logfeeder-env.sh PRE-CREATION 
  ambari-logsearch/docker/test-config/logfeeder/logfeeder.properties 
PRE-CREATION 
  ambari-logsearch/docker/test-config/logfeeder/shipper-conf/global.config.json 
PRE-CREATION 
  
ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-logsearch.json
 PRE-CREATION 
  
ambari-logsearch/docker/test-config/logfeeder/shipper-conf/input.config-zookeeper.json
 PRE-CREATION 
  ambari-logsearch/docker/test-config/logfeeder/shipper-conf/output.config.json 
PRE-CREATION 
  ambari-logsearch/docker/test-config/logsearch/log4j.xml PRE-CREATION 
  ambari-logsearch/docker/test-config/logsearch/logsearch-env.sh PRE-CREATION 
  ambari-logsearch/docker/test-config/logsearch/logsearch.properties 
PRE-CREATION 
  ambari-logsearch/docker/test-config/solr/log4j.properties PRE-CREATION 
  ambari-logsearch/docker/test-config/solr/solr-env.sh PRE-CREATION 
  ambari-logsearch/docker/test-config/solr/solr.xml PRE-CREATION 
  ambari-logsearch/docker/test-config/solr/zoo.cfg PRE-CREATION 
  ambari-logsearch/docker/test-logs/logsearch/logsearch-test-log.json 
PRE-CREATION 
  ambari-logsearch/docker/test-logs/zookeeper/zookeeper-test-log.txt 
PRE-CREATION 
  ambari-logsearch/pom.xml 81da0f2 

Diff: https://reviews.apache.org/r/50069/diff/


Testing
---

>From Apache jenkins:
++1 overall. Here are the results of testing the latest attachment 
http://issues.apache.org/jira/secure/attachment/12818065/AMBARI-17723.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 16 new or modified test files.
+1 javac. The applied patch does not increase the total number of javac 
compiler warnings.
+1 release audit. The applied patch does not increase the total number of 
release audit warnings.
+1 core tests. The patch passed unit tests in 
ambari-logsearch/ambari-logsearch-logfeeder 
ambari-logsearch/ambari-logsearch-portal.
Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7855//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/7855//console
This message is automatically generated.


Thanks,

Oliver Szabo

Re: Review Request 49891: Restart indicator is not shown after modifying the configs

2016-07-18 Thread Myroslav Papirkovskyy


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49891/#review142542
---


Ship it!




Ship It!

- Myroslav Papirkovskyy


On Липень 15, 2016, 1:26 після полудня, Dmitro Lisnichenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49891/
> ---
> 
> (Updated Липень 15, 2016, 1:26 після полудня)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Myroslav 
> Papirkovskyy, and Sid Wagle.
> 
> 
> Bugs: AMBARI-17651
> https://issues.apache.org/jira/browse/AMBARI-17651
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Restart indicator is not shown after modifying the configs.
> Test case modified the hdfs config 'Namenode new generation size'. But still 
> after saving the configuration, restart icon is not shown.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/annotations/TransactionalLock.java
>  5934f5a 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  94a8fe0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProvider.java
>  d4e3828 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java 
> 46a3f3e 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ConfigImpl.java 
> 92ec843 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  fdb997b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/svccomphost/ServiceComponentHostImpl.java
>  666111b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ConfigGroupResourceProviderTest.java
>  dc8017a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/ConfigHelperTest.java
>  0ff143c 
> 
> Diff: https://reviews.apache.org/r/49891/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Dmitro Lisnichenko
> 
>

Review Request 50130: ZOOKEEPER_SERVER START is failed after upgrade from 2.1.1 to 2.4.0.0 and making adding ZK server

2016-07-18 Thread Dmytro Sen


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50130/
---

Review request for Ambari, Dmitro Lisnichenko and Myroslav Papirkovskyy.


Bugs: AMBARI-17766
https://issues.apache.org/jira/browse/AMBARI-17766


Repository: ambari


Description
---

STR: 
1) Install old version regarding environment 
2) Enable AD security 
3) Make ambari only upgrade 
4) Disable security 
5) Add new Node 
6) Add ZK server on added node. 
7)Try to start Added ZK server
Actual result:
ZOOKEEPER_SERVER START is failed after upgrade from 2.1.1 to 2.4.0.0 and making 
adding ZK server


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 
990c314 

Diff: https://reviews.apache.org/r/50130/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Review Request 50129: Hive View : Clicking on History button in saved search does not show history page

2016-07-18 Thread Nitiraj Rathore


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50129/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-17765
https://issues.apache.org/jira/browse/AMBARI-17765


Repository: ambari


Description
---

Fixed the simple javascript exception.


Diffs
-

  
contrib/views/hive-next/src/main/resources/ui/hive-web/app/controllers/history.js
 ca6233c 
  contrib/views/hive/src/main/resources/ui/hive-web/app/controllers/history.js 
ca6233c 

Diff: https://reviews.apache.org/r/50129/diff/


Testing
---

manual testing done.


Thanks,

Nitiraj Rathore

Re: Review Request 49750: Upload table using Hive view will fail if Hive database is created with Location option

2016-07-18 Thread Ashwin Rajeev


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49750/#review142540
---


Ship it!




Ship It!

- Ashwin Rajeev


On July 7, 2016, 11:32 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49750/
> ---
> 
> (Updated July 7, 2016, 11:32 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17605
> https://issues.apache.org/jira/browse/AMBARI-17605
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : the hive view takes up property hive.metastore.warehouse.dir for 
> location of temporary table. 
> 
> In this patch : Now it will use query describe formatted for finding the 
> actual location of temporary table.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/client/DDLDelegator.java
>  20b91f1 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/client/DDLDelegatorImpl.java
>  0171626 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/browser/HiveBrowserService.java
>  0da49c4 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
>  18da1ff 
> 
> Diff: https://reviews.apache.org/r/49750/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 50122: Oozie service check failed after deployment

2016-07-18 Thread Dmitro Lisnichenko


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50122/#review142539
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On July 18, 2016, 11:55 a.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50122/
> ---
> 
> (Updated July 18, 2016, 11:55 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-17764
> https://issues.apache.org/jira/browse/AMBARI-17764
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> After deployment Oozie service check is failing
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py 
> ee37fe0 
>   ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py 
> 1feeed2 
>   ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py 
> 1232d97 
>   ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py 
> 91acb91 
> 
> Diff: https://reviews.apache.org/r/50122/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 49750: Upload table using Hive view will fail if Hive database is created with Location option

2016-07-18 Thread Gaurav Nagar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49750/#review142537
---


Ship it!




Ship It!

- Gaurav Nagar


On July 7, 2016, 11:32 a.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49750/
> ---
> 
> (Updated July 7, 2016, 11:32 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-17605
> https://issues.apache.org/jira/browse/AMBARI-17605
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : the hive view takes up property hive.metastore.warehouse.dir for 
> location of temporary table. 
> 
> In this patch : Now it will use query describe formatted for finding the 
> actual location of temporary table.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/client/DDLDelegator.java
>  20b91f1 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/client/DDLDelegatorImpl.java
>  0171626 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/browser/HiveBrowserService.java
>  0da49c4 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
>  18da1ff 
> 
> Diff: https://reviews.apache.org/r/49750/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Review Request 50121: AMBARI-17763 Populating Ranger Tagsync principal/keytab using stack advisor

2016-07-18 Thread Mugdha Varadkar


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50121/
---

Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, 
Robert Levas, Sumit Mohanty, Srimanth Gunturi, and Velmurugan Periasamy.


Bugs: AMBARI-17763
https://issues.apache.org/jira/browse/AMBARI-17763


Repository: ambari


Description
---

atlas.jaas.KafkaClient.option.keyTab and 
atlas.jaas.KafkaClient.option.principal properties are needed in 
tagsync-application-properties.xml when kerberos is enabled. These properties 
should have Ranger Tagsync principal/keytab.

To achieve this changing the implementation from macro to stack advisor


Diffs
-

  ambari-server/src/main/resources/common-services/RANGER/0.6.0/kerberos.json 
91a0032 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
b84910a 

Diff: https://reviews.apache.org/r/50121/diff/


Testing
---

Tested Ranger installation along with Atlas.


Thanks,

Mugdha Varadkar

50 matches

Mail list logo