Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

[ping wang]

> On 十二月 22, 2016, 4:04 p.m., Di Li wrote:
> > ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml,
> >  line 22
> > 
> >
> > Why not use spark_conf placeholder and calculate the full patch in one 
> > shot, than having to calculate the spark home then concatenate the /conf

I thought spark_home is more common than spark_conf. But yes, it will be better 
to directly show spark_conf. 
Upload the new diff file. Thanks Di.


- ping


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review159973
---


On 十二月 23, 2016, 11:58 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated 十二月 23, 2016, 11:58 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 54891: Create quick links profile evaluator

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54891/#review160101
---


Ship it!




Ship It!

- Attila Doroszlai


On Dec. 23, 2016, 8:59 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54891/
> ---
> 
> (Updated Dec. 23, 2016, 8:59 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Jayush Luniya, Laszlo Puskas, 
> Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19244
> https://issues.apache.org/jira/browse/AMBARI-19244
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Profile evaluator is a class that takes a quick links profile as input and 
> can decide on the visibility of quicklinks based on the received profile.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
>  72ad764 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java
>  5124241 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java
>  7ef0259 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java
>  1711628 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/PropertyFilter.java
>  7b5eba0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java
>  1a1488b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
>  c1f3c86 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java
>  600872f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java
>  190e61b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java
>  5f93475 
>   ambari-server/src/test/resources/child_quicklinks_with_properties.json 
> 36cd4f3 
>   ambari-server/src/test/resources/example_quicklinks_profile.json 028d011 
>   ambari-server/src/test/resources/inconsistent_quicklinks_profile.json 
> e5bc310 
>   ambari-server/src/test/resources/parent_quicklinks_with_properties.json 
> a315f3f 
> 
> Diff: https://reviews.apache.org/r/54891/diff/
> 
> 
> Testing
> ---
> 
> Wrote new unit tests. Run the ambari-server test suite. Failures are 
> irrelevant.
> 
> Failed tests:
>   DataStoreImplTest.testFind:524 expected: DS_DataStoreImplTest$TestEntity_1> but was: DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testRemove:473 expected: DS_DataStoreImplTest$TestEntity_1> but was: DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update:355 expected: DS_DataStoreImplTest$TestEntity_1> but was: DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update_longStringValue:424
>   Expectation failure on verify:
> DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
> Tests in error:
>   KerberosCheckerTest.testCheckFailed »  Unexpected exception, 
> expected   KerberosCheckerTest.testCheckPassed:62 » ClassCast class 
> sun.security.provider...
>   AmbariBasicAuthenticationFilterTest.testOnSuccessfulAuthentication:99 » 
> Linkage
> 
> Tests run: 4136, Failures: 4, Errors: 3, Skipped: 31
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Re: Review Request 54891: Create quick links profile evaluator

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54891/
---

(Updated Dec. 23, 2016, 7:59 p.m.)


Review request for Ambari, Attila Magyar, Jayush Luniya, Laszlo Puskas, Sandor 
Magyari, Sumit Mohanty, and Sebastian Toader.


Bugs: AMBARI-19244
https://issues.apache.org/jira/browse/AMBARI-19244


Repository: ambari


Description
---

Profile evaluator is a class that takes a quick links profile as input and can 
decide on the visibility of quicklinks based on the received profile.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 
72ad764 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java
 5124241 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java
 7ef0259 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java
 1711628 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/PropertyFilter.java
 7b5eba0 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java
 1a1488b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
 c1f3c86 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java
 600872f 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java
 190e61b 
  
ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java
 5f93475 
  ambari-server/src/test/resources/child_quicklinks_with_properties.json 
36cd4f3 
  ambari-server/src/test/resources/example_quicklinks_profile.json 028d011 
  ambari-server/src/test/resources/inconsistent_quicklinks_profile.json e5bc310 
  ambari-server/src/test/resources/parent_quicklinks_with_properties.json 
a315f3f 

Diff: https://reviews.apache.org/r/54891/diff/


Testing
---

Wrote new unit tests. Run the ambari-server test suite. Failures are irrelevant.

Failed tests:
  DataStoreImplTest.testFind:524 expected: but was:
  DataStoreImplTest.testRemove:473 expected: but was:
  DataStoreImplTest.testStore_update:355 expected: but was:
  DataStoreImplTest.testStore_update_longStringValue:424
  Expectation failure on verify:
DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
Tests in error:
  KerberosCheckerTest.testCheckFailed »  Unexpected exception, 
expected

Re: Review Request 54891: Create quick links profile evaluator

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54891/
---

(Updated Dec. 23, 2016, 7:54 p.m.)


Review request for Ambari, Attila Magyar, Jayush Luniya, Laszlo Puskas, Sandor 
Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
---

Fixed import order, deleted .hash file


Bugs: AMBARI-19244
https://issues.apache.org/jira/browse/AMBARI-19244


Repository: ambari


Description
---

Profile evaluator is a class that takes a quick links profile as input and can 
decide on the visibility of quicklinks based on the received profile.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java 
72ad764 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java
 5124241 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java
 7ef0259 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java
 1711628 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/PropertyFilter.java
 7b5eba0 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java
 1a1488b 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
 c1f3c86 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java
 600872f 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java
 190e61b 
  
ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java
 5f93475 
  ambari-server/src/test/resources/child_quicklinks_with_properties.json 
36cd4f3 
  ambari-server/src/test/resources/example_quicklinks_profile.json 028d011 
  ambari-server/src/test/resources/inconsistent_quicklinks_profile.json e5bc310 
  ambari-server/src/test/resources/parent_quicklinks_with_properties.json 
a315f3f 

Diff: https://reviews.apache.org/r/54891/diff/


Testing
---

Wrote new unit tests. Run the ambari-server test suite. Failures are irrelevant.

Failed tests:
  DataStoreImplTest.testFind:524 expected: but was:
  DataStoreImplTest.testRemove:473 expected: but was:
  DataStoreImplTest.testStore_update:355 expected: but was:
  DataStoreImplTest.testStore_update_longStringValue:424
  Expectation failure on verify:
DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
Tests in error:
  KerberosCheckerTest.testCheckFailed »  Unexpected exception, 
expected

Re: Review Request 55018: Fix hive-site.xml and hive-env.sh permissions for /etc/hive/conf (client) folder from 600 to 644.

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55018/#review160099
---


Ship it!




Ship It!

- Jonathan Hurley


On Dec. 23, 2016, 1:30 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55018/
> ---
> 
> (Updated Dec. 23, 2016, 1:30 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Myroslav Papirkovskyy, Sumit Mohanty, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-19119
> https://issues.apache.org/jira/browse/AMBARI-19119
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As part of change for AMBARI-19005, permissions for hive-site.xml and 
> hive-env.sh files in conf folder were also getting set as 600, whereas they 
> are expected to stay 644 (earlier it was 644).
> Adding fix for that.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  6344ed7 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py 1a7256f 
> 
> Diff: https://reviews.apache.org/r/55018/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55018: Fix hive-site.xml and hive-env.sh permissions for /etc/hive/conf (client) folder from 600 to 644.

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55018/#review160095
---


Ship it!




Ship It!

- Dmytro Grinenko


On Dec. 23, 2016, 6:30 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55018/
> ---
> 
> (Updated Dec. 23, 2016, 6:30 p.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Myroslav Papirkovskyy, Sumit Mohanty, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-19119
> https://issues.apache.org/jira/browse/AMBARI-19119
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As part of change for AMBARI-19005, permissions for hive-site.xml and 
> hive-env.sh files in conf folder were also getting set as 600, whereas they 
> are expected to stay 644 (earlier it was 644).
> Adding fix for that.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  6344ed7 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py 1a7256f 
> 
> Diff: https://reviews.apache.org/r/55018/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55002: 'conf.server' dir for HIVE1 and HIVE2 should have 700 permission and files in it should have 600 permission.

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55002/#review160094
---


Ship it!




Ship It!

- Dmytro Sen


On Дек. 23, 2016, 5:29 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55002/
> ---
> 
> (Updated Дек. 23, 2016, 5:29 п.п.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-19005
> https://issues.apache.org/jira/browse/AMBARI-19005
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Observed an issue that affects earlier releases of HIVE as well. The 
> conf.server directory has hive-site.xml with metastore server password in it.
> That directory is only populated on machines with hs2/metastore (the good 
> part).
> But the permissions of that directory and the files in it are not restricted, 
> it should be set to 700 (directory) and 600 (files). Currently, it is set to 
> 755 and 644 for dir and files.
> I believe intention of creating separate directory was to restrict 
> permissions to only the user hive.
> I see this problem in ambari installed HDP 2.5 cluster and HDP 2.2 and 2.3 
> sandboxes, so it seems to affect the corresponding ambari versions as well.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  ffc996c 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  af2a05d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py b96437d 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
> 799ee39 
>   ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 8b866d6 
>   ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 
> 5ee09f6 
>   ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py 
> e00668a 
> 
> Diff: https://reviews.apache.org/r/55002/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55002: 'conf.server' dir for HIVE1 and HIVE2 should have 700 permission and files in it should have 600 permission.

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55002/
---

(Updated Гру. 23, 2016, 5:29 після полудня)


Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, and 
Sid Wagle.


Bugs: AMBARI-19005
https://issues.apache.org/jira/browse/AMBARI-19005


Repository: ambari


Description
---

Observed an issue that affects earlier releases of HIVE as well. The 
conf.server directory has hive-site.xml with metastore server password in it.
That directory is only populated on machines with hs2/metastore (the good part).
But the permissions of that directory and the files in it are not restricted, 
it should be set to 700 (directory) and 600 (files). Currently, it is set to 
755 and 644 for dir and files.
I believe intention of creating separate directory was to restrict permissions 
to only the user hive.
I see this problem in ambari installed HDP 2.5 cluster and HDP 2.2 and 2.3 
sandboxes, so it seems to affect the corresponding ambari versions as well.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 ffc996c 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 af2a05d 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_client.py b96437d 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_metastore.py 
799ee39 
  ambari-server/src/test/python/stacks/2.0.6/HIVE/test_hive_server.py 8b866d6 
  ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py 5ee09f6 
  ambari-server/src/test/python/stacks/2.5/HIVE/test_hive_server_int.py e00668a 

Diff: https://reviews.apache.org/r/55002/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Review Request 55016: AMBARI-19293. Component install and after-install should not run in parallel

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55016/
---

Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, and Sebastian 
Toader.


Bugs: AMBARI-19293
https://issues.apache.org/jira/browse/AMBARI-19293


Repository: ambari


Description
---

* Perform TEZ `configure` step with lock (will add other services later).
* Use service-specific locks in after-install hook to decrease contention


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
 ce00f0c6f69f255690f1ab9528bea6cee184a73e 
  
ambari-server/src/main/resources/common-services/TEZ/0.4.0.2.1/package/scripts/tez_client.py
 8018f0f960322aac196caf3915a0a944e7765d8e 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py
 ed34217757540278a8730d58797cc47536e58874 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/shared_initialization.py
 e9f22834b5479330a6f00ca69991cc690780b3c3 
  ambari-server/src/test/python/stacks/2.2/common/test_conf_select.py 
d445d741ba4225a33e2a763eed6dfcf8394dceb6 

Diff: https://reviews.apache.org/r/55016/diff/


Testing
---

Manual test (still in progress):

* install cluster via blueprint with parallel execution disabled (this is the 
default)
* install cluster via blueprint with parallel execution enabled (needs packages 
pre-installed and users pre-created)

Unit tests:

```
$ mvn -am -pl ambari-agent,ambari-server -DskipSurefireTests clean test
...
[INFO] --- exec-maven-plugin:1.2.1:exec (python-test) @ ambari-server ---
...
Total run:1160
Total errors:0
Total failures:0
OK
...
[INFO] --- exec-maven-plugin:1.2.1:exec (python-test) @ ambari-agent ---
...
Ran 451 tests in 15.344s

OK
...
[INFO] Reactor Summary:
[INFO]
[INFO] Ambari Main ... SUCCESS [6.650s]
[INFO] Apache Ambari Project POM . SUCCESS [0.027s]
[INFO] Ambari Views .. SUCCESS [2.355s]
[INFO] utility ... SUCCESS [1.182s]
[INFO] ambari-metrics  SUCCESS [0.315s]
[INFO] Ambari Metrics Common . SUCCESS [0.730s]
[INFO] Ambari Server . SUCCESS [1:38.241s]
[INFO] Ambari Agent .. SUCCESS [17.247s]
[INFO] 
[INFO] BUILD SUCCESS
```


Thanks,

Attila Doroszlai

Re: Review Request 55015: Background Operations popup: no name for operations

[Oleg Nechiporenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55015/#review160093
---


Ship it!




Ship It!

- Oleg Nechiporenko


On Dec. 23, 2016, 4:46 p.m., Aleksandr Kovalenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55015/
> ---
> 
> (Updated Dec. 23, 2016, 4:46 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko and Oleg Nechiporenko.
> 
> 
> Bugs: AMBARI-19294
> https://issues.apache.org/jira/browse/AMBARI-19294
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Background Operations popup: no name for operations
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/global/background_operations_controller.js 
> 3a011f5 
>   ambari-web/test/controllers/global/background_operations_test.js 323f090 
> 
> Diff: https://reviews.apache.org/r/55015/diff/
> 
> 
> Testing
> ---
> 
> 19829 passing (22s)
>   153 pending
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>

Re: Review Request 55009: HDFS Service check fails if previous active NN is down

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55009/#review160090
---


Ship it!




Ship It!

- Di Li


On Dec. 23, 2016, 7:14 a.m., Weiwei Yang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55009/
> ---
> 
> (Updated Dec. 23, 2016, 7:14 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19289
> https://issues.apache.org/jira/browse/AMBARI-19289
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> On a HA cluster, I manually stop the active NN, standby takes over and 
> becomes to be active, HDFS is healthy. However hdfs service check fails.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py
>  737ae04 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 
> bbc1b3a 
> 
> Diff: https://reviews.apache.org/r/55009/diff/
> 
> 
> Testing
> ---
> 
> HA cluster
> 
> 1. Both NN started
> 2. Shutdown active
> 3. Shutdown standby
> 4. Both NN started and manually put NN in safemode
> 
> Non-HA cluster
> 
> 1. NN started
> 2. NN started and manually put NN in safemode
> 3. NN stopped
> 
> 
> Thanks,
> 
> Weiwei Yang
> 
>

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/#review160089
---




ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 (line 70)


I don't think spark_home is being used by Oozie Python script. Can this be 
shorten to spark_conf = format("{stack_root}/current/spark-client/conf")


- Di Li


On Dec. 23, 2016, 11:58 a.m., ping wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54970/
> ---
> 
> (Updated Dec. 23, 2016, 11:58 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Di Li.
> 
> 
> Bugs: AMBARI-19250
> https://issues.apache.org/jira/browse/AMBARI-19250
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Change default Spark configuration property in Oozie configuration settings 
> to valid value
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
>  a2d725c 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
>  cdb6972 
> 
> Diff: https://reviews.apache.org/r/54970/diff/
> 
> 
> Testing
> ---
> 
> I have tested the fix by:
> 1) copy the changed files into ambari host and restart ambari-server
> 2) delete oozie service and then add it back
> 3) check the property value is point to the spark configuration directory 
> correctly
> 
> 
> Thanks,
> 
> ping wang
> 
>

Re: Review Request 54958: Single API to download all client configs

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54958/#review160087
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 (line 479)


Do you need to prefix the executeCommands with `this` ?



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 (line 483)


Same as above ... remove `this`



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 (lines 485 - 496)


Since this is one big if/else, can you calcuate the file name in here and 
then instantiate the TarUtils once outside of it?


- Jonathan Hurley


On Dec. 22, 2016, 7:57 p.m., Jaimin Jetly wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54958/
> ---
> 
> (Updated Dec. 22, 2016, 7:57 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, Sumit Mohanty, and Sid 
> Wagle.
> 
> 
> Bugs: AMBARI-19275
> https://issues.apache.org/jira/browse/AMBARI-19275
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently there is an API to download compressed config files for a host 
> component
> 
> Scope of this ticket is to extend this functionality to do following:
> # Download all client config files for a host via single API
> # Download all client config files of a service via single API. some services 
> have more than one client
> # Download all client config files for cluster
> 
> Apart from extending the functionalty of API, an additional change has been 
> made to the behavior of the existing API that looked to be like a bug
> Without this patch Downloading client config files for a service component 
> used to fetch first host component and create config files as present on that 
> host component (host desired configs overlaid on cluster desired configs)
> Instead with a change in this patch when download client config is made on a 
> service component then config files with only cluster base configs will be 
> created for downoad.
> 
> 
> Diffs
> -
> 
>   ambari-server/pom.xml ceec39c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ComponentService.java
>  ded2596 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/HostComponentService.java
>  bc9bb30 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  d2f7934 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  020a454 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/ComponentServiceTest.java
>  cb3c2a7 
>   
> ambari-server/src/test/java/org/apache/ambari/server/api/services/HostComponentServiceTest.java
>  f67d961 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProviderTest.java
>  cb88ae1 
> 
> Diff: https://reviews.apache.org/r/54958/diff/
> 
> 
> Testing
> ---
> 
> Tested manually on a cluster
> Added validation to existing unit tests
> Executed all unit tests on dev machine and checked there is no regression
> Jenkins QA job for 1st revision of the patch compltedt successsfully
> Jenkins QA job for 2nd revision of the patch in progress...
> 
> 
> Thanks,
> 
> Jaimin Jetly
> 
>

Re: Review Request 54936: Zookeeper and RM connection is not secure

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54936/#review160086
---


Ship it!




Ship It!

- Robert Levas


On Dec. 22, 2016, 3:53 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54936/
> ---
> 
> (Updated Dec. 22, 2016, 3:53 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Eugene 
> Chekanskiy, Laszlo Puskas, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19269
> https://issues.apache.org/jira/browse/AMBARI-19269
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I modified the kerberization/dekerberization process of YARN RM
> based on 
> https://docs.google.com/document/d/1IEAVBFU2QMhKP5It4_u7L1UtP_QRBTHUk9cOuHjK8AU/
> 
> - yarn.resourcemanager.zk-acl is set to sasl:rm:rwcda when kerberos is 
> enabled (kerberos.json) 
> - jaas file is added to YARN_OPTS with the correct principal and keytab when 
> kerberos is enabled
> - ACL is reverted to world:anyone:crdwa when disabling kerberos
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json 
> 4093431 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  0496995 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
>  6a7eea7 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  f5acb11 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/templates/yarn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 
> e690204 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py
>  cdadc80 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/resourcemanager.py
>  e053fe6 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/yarn.py
>  70ed5b3 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/templates/yarn_jaas.conf.j2
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 
> 2fdce8a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json
>  b02b3e9 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json 
> 0d67e59 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
> e690204 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> bea3f81 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 
> 466b0f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 4abf2c9 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 
> 7b5ce18 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 3719fe5 
> 
> Diff: https://reviews.apache.org/r/54936/diff/
> 
> 
> Testing
> ---
> 
> Manual testing:
>  - created a cluster with YARN + HDFS + ZooKeeper
>  - enabled kerberos
>  - check that the acl on /rmstore/ZKRMStateRoot is set to sasl
>  - disabled kerberos
>  - checked that the acl on /rmstore/ZKRMStateRoot is 'world,'anyone
>  - Enabled YARN RM HA mode, repeated the above test
> 
> Tests:
> Ambari server:
> Tests run: 4782, Failures: 0, Errors: 0, Skipped: 37
> 
> Python tests:
> Total run:1146
> Total errors:0
> Total failures:0
> 
> Ambari agent:
> Ran 447 tests in 22.056s
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 54989: HOU pre-checks indicate HA as a requirement

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54989/#review160085
---


Ship it!




Ship It!

- Robert Levas


On Dec. 22, 2016, 3:03 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54989/
> ---
> 
> (Updated Dec. 22, 2016, 3:03 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-19285
> https://issues.apache.org/jira/browse/AMBARI-19285
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Host Ordered Upgrades do not require the cluster services to be installed in 
> HA mode. However, when executing:
> 
> {code}
> GET 
> api/v1/clusters/c1/rolling_upgrades_check?fields=*/repository_version=2.5.3.0-37/upgrade_type=HOST_ORDERED"
> {code}
> 
> HA-only upgrade checks (like Secondary NameNode Removal and NameNode HA) are 
> running and failing.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  3fc8650 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  45497b5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java
>  18fb2ad 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
>  455a92d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ConfigurationMergeCheck.java
>  dd1385b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HardcodedStackVersionPropertiesCheck.java
>  11d6676 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
> b75e923 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheck.java
>  6289ff5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveNotRollingWarning.java
>  5e44c7c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostMaintenanceModeCheck.java
>  88d9de6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsHeartbeatCheck.java
>  1f1980f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
>  eaedd3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
>  620c651 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java
>  52546d2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/PreviousUpgradeCompleted.java
>  a77ad9f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
>  5e2db33 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
>  b77e1d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java
>  18a5bde 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  d4c7894 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/StormRestAPIDeletedCheck.java
>  90eea97 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/StormShutdownWarning.java
>  3ed7a27 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheck.java 
> 9e43560 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckRegistry.java
>  b770dd5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java
>  050d43e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-ordered-upgrade.xml
>  64c79a8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
>  2bcd482 
> 
> Diff: https://reviews.apache.org/r/54989/diff/
> 
> 
> Testing
> ---
> 
> Results :
> 
> Tests run: 4813, Failures: 0, Errors: 0, Skipped: 37
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 28:15 min
> [INFO] Finished at: 2016-12-22T15:00:07-05:00
> [INFO] Final Memory: 59M/678M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 54903: BE changes needed for SNMP Ambari MIB support

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54903/
---

(Updated Дек. 23, 2016, 2:46 п.п.)


Review request for Ambari, Aravindan Vijayan, Jonathan Hurley, and Sid Wagle.


Bugs: AMBARI-19257
https://issues.apache.org/jira/browse/AMBARI-19257


Repository: ambari


Description
---

Replace 
SNMPv2-SMI::enterprises.18060.16.1.1.1.6 = STRING: "CRITICAL"
with
SNMPv2-SMI::enterprises.18060.16.1.1.1.6 = INTEGER: 3


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcher.java
 62ef31a 
  ambari-server/src/main/java/org/apache/ambari/server/state/AlertState.java 
3bb70e2 
  
ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcherTest.java
 6cf4990 

Diff: https://reviews.apache.org/r/54903/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Re: Review Request 54930: Remove Spark dependency from Zeppelin service def

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54930/#review160083
---


Ship it!




Ship It!

- Sumit Mohanty


On Dec. 21, 2016, 7:28 a.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54930/
> ---
> 
> (Updated Dec. 21, 2016, 7:28 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19263
> https://issues.apache.org/jira/browse/AMBARI-19263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove Spark dependency from Zeppelin service def
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
>  382e913 
> 
> Diff: https://reviews.apache.org/r/54930/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on CentOS 6
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 54977: Zeppelin Notebook Component is not able start after reboot

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54977/#review160082
---


Ship it!




Ship It!

- Sumit Mohanty


On Dec. 22, 2016, 12:55 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54977/
> ---
> 
> (Updated Dec. 22, 2016, 12:55 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19264
> https://issues.apache.org/jira/browse/AMBARI-19264
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - intermittently fails to start the service when /var/run/zeppelin dir is not 
> present.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  39941f7 
> 
> Diff: https://reviews.apache.org/r/54977/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 54857: Refactor Ambari service def configurations for Zeppelin

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54857/#review160081
---




ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
 (line 104)


What will happen after Ambari upgrade? An installed cluster will have the 
config stored in zeppelin-env that is in the DB. After upgrade the content will 
be read from the new config types. As long as there is no user edit I assume it 
will just work fine. Can you test it once?


- Sumit Mohanty


On Dec. 19, 2016, 9:59 a.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54857/
> ---
> 
> (Updated Dec. 19, 2016, 9:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17470
> https://issues.apache.org/jira/browse/AMBARI-17470
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Move shiro.ini and log4j.properties out of zeppelin-env configuration.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  2beac97 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-shiro-ini.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
>  382e913 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  5ee6147 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ZEPPELIN/configuration/zeppelin-env.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54857/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on CentOS 6.6
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 54778: Separate general Log Search env properties from Log Search Portal properties

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54778/
---

(Updated Dec. 23, 2016, 1:03 p.m.)


Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.


Changes
---

rename the property groups to logseach-env / logsearch-common-env


Bugs: AMBARI-19209
https://issues.apache.org/jira/browse/AMBARI-19209


Repository: ambari


Description
---

Some properties in logsearch-env are affecting both the portal and the feeders, 
while others affect only the portal. The latter should be separated into a 
logsearch-portal-env, so logfeeders will be restarted only if those properties 
are changed which affect the whole service.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
 aba638a 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-common-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
 8691d35 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
6921a8e 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 4d751ba 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json
 2858825 
  ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py 
3789a16 
  ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py 6317376 

Diff: https://reviews.apache.org/r/54778/diff/


Testing
---

Tested on local cluster


Thanks,

Miklos Gergely

Re: Review Request 55000: Perf: Deploy 3000 Agent cluster and find perf bugs. Part 4

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55000/#review160076
---


Ship it!




Ship It!

- Dmytro Grinenko


On Dec. 23, 2016, 12:22 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55000/
> ---
> 
> (Updated Dec. 23, 2016, 12:22 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-19058
> https://issues.apache.org/jira/browse/AMBARI-19058
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1) Fixed problem with too low packet size in mysql.
> 2) Fixed problem with too short time to leave for kerberos ticket.
> 
> 
> Diffs
> -
> 
>   contrib/utils/perf/deploy-gce-perf-cluster.py 73c353e 
> 
> Diff: https://reviews.apache.org/r/55000/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55002: 'conf.server' dir for HIVE1 and HIVE2 should have 700 permission and files in it should have 600 permission.

[Dmytro Grinenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55002/#review160077
---


Ship it!




Ship It!

- Dmytro Grinenko


On Dec. 23, 2016, 12:35 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55002/
> ---
> 
> (Updated Dec. 23, 2016, 12:35 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-19005
> https://issues.apache.org/jira/browse/AMBARI-19005
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Observed an issue that affects earlier releases of HIVE as well. The 
> conf.server directory has hive-site.xml with metastore server password in it.
> That directory is only populated on machines with hs2/metastore (the good 
> part).
> But the permissions of that directory and the files in it are not restricted, 
> it should be set to 700 (directory) and 600 (files). Currently, it is set to 
> 755 and 644 for dir and files.
> I believe intention of creating separate directory was to restrict 
> permissions to only the user hive.
> I see this problem in ambari installed HDP 2.5 cluster and HDP 2.2 and 2.3 
> sandboxes, so it seems to affect the corresponding ambari versions as well.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  792aac3 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  298db2a 
> 
> Diff: https://reviews.apache.org/r/55002/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55000: Perf: Deploy 3000 Agent cluster and find perf bugs. Part 4

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55000/#review160075
---


Ship it!




Ship It!

- Dmytro Sen


On Дек. 23, 2016, 12:22 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55000/
> ---
> 
> (Updated Дек. 23, 2016, 12:22 п.п.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-19058
> https://issues.apache.org/jira/browse/AMBARI-19058
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1) Fixed problem with too low packet size in mysql.
> 2) Fixed problem with too short time to leave for kerberos ticket.
> 
> 
> Diffs
> -
> 
>   contrib/utils/perf/deploy-gce-perf-cluster.py 73c353e 
> 
> Diff: https://reviews.apache.org/r/55000/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 55002: 'conf.server' dir for HIVE1 and HIVE2 should have 700 permission and files in it should have 600 permission.

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55002/#review160074
---


Ship it!




Ship It!

- Dmytro Sen


On Дек. 23, 2016, 12:35 п.п., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55002/
> ---
> 
> (Updated Дек. 23, 2016, 12:35 п.п.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, 
> and Sid Wagle.
> 
> 
> Bugs: AMBARI-19005
> https://issues.apache.org/jira/browse/AMBARI-19005
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Observed an issue that affects earlier releases of HIVE as well. The 
> conf.server directory has hive-site.xml with metastore server password in it.
> That directory is only populated on machines with hs2/metastore (the good 
> part).
> But the permissions of that directory and the files in it are not restricted, 
> it should be set to 700 (directory) and 600 (files). Currently, it is set to 
> 755 and 644 for dir and files.
> I believe intention of creating separate directory was to restrict 
> permissions to only the user hive.
> I see this problem in ambari installed HDP 2.5 cluster and HDP 2.2 and 2.3 
> sandboxes, so it seems to affect the corresponding ambari versions as well.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
>  792aac3 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
>  298db2a 
> 
> Diff: https://reviews.apache.org/r/55002/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 55002: 'conf.server' dir for HIVE1 and HIVE2 should have 700 permission and files in it should have 600 permission.

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55002/
---

Review request for Ambari, Alejandro Fernandez, Dmytro Sen, Sumit Mohanty, and 
Sid Wagle.


Bugs: AMBARI-19005
https://issues.apache.org/jira/browse/AMBARI-19005


Repository: ambari


Description
---

Observed an issue that affects earlier releases of HIVE as well. The 
conf.server directory has hive-site.xml with metastore server password in it.
That directory is only populated on machines with hs2/metastore (the good part).
But the permissions of that directory and the files in it are not restricted, 
it should be set to 700 (directory) and 600 (files). Currently, it is set to 
755 and 644 for dir and files.
I believe intention of creating separate directory was to restrict permissions 
to only the user hive.
I see this problem in ambari installed HDP 2.5 cluster and HDP 2.2 and 2.3 
sandboxes, so it seems to affect the corresponding ambari versions as well.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py
 792aac3 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py
 298db2a 

Diff: https://reviews.apache.org/r/55002/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 54989: HOU pre-checks indicate HA as a requirement

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54989/#review160073
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Dec. 22, 2016, 10:03 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54989/
> ---
> 
> (Updated Dec. 22, 2016, 10:03 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-19285
> https://issues.apache.org/jira/browse/AMBARI-19285
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Host Ordered Upgrades do not require the cluster services to be installed in 
> HA mode. However, when executing:
> 
> {code}
> GET 
> api/v1/clusters/c1/rolling_upgrades_check?fields=*/repository_version=2.5.3.0-37/upgrade_type=HOST_ORDERED"
> {code}
> 
> HA-only upgrade checks (like Secondary NameNode Removal and NameNode HA) are 
> running and failing.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  3fc8650 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/CheckDescription.java
>  45497b5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ClientRetryPropertyCheck.java
>  18fb2ad 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
>  455a92d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ConfigurationMergeCheck.java
>  dd1385b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HardcodedStackVersionPropertiesCheck.java
>  11d6676 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HealthCheck.java 
> b75e923 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveDynamicServiceDiscoveryCheck.java
>  6289ff5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HiveNotRollingWarning.java
>  5e44c7c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostMaintenanceModeCheck.java
>  88d9de6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsHeartbeatCheck.java
>  1f1980f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
>  eaedd3f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
>  620c651 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/InstallPackagesCheck.java
>  52546d2 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/PreviousUpgradeCompleted.java
>  a77ad9f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
>  5e2db33 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
>  b77e1d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesMaintenanceModeCheck.java
>  18a5bde 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  d4c7894 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/StormRestAPIDeletedCheck.java
>  90eea97 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/StormShutdownWarning.java
>  3ed7a27 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheck.java 
> 9e43560 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/UpgradeCheckRegistry.java
>  b770dd5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/VersionMismatchCheck.java
>  050d43e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/host-ordered-upgrade.xml
>  64c79a8 
>   
> ambari-server/src/test/java/org/apache/ambari/server/checks/AbstractCheckDescriptorTest.java
>  2bcd482 
> 
> Diff: https://reviews.apache.org/r/54989/diff/
> 
> 
> Testing
> ---
> 
> Results :
> 
> Tests run: 4813, Failures: 0, Errors: 0, Skipped: 37
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 28:15 min
> [INFO] Finished at: 2016-12-22T15:00:07-05:00
> [INFO] Final Memory: 59M/678M
> [INFO] 
> 
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 55014: AMBARI-19292: Asset Manager/Asset Upload/Asset import from DB

[Madhan Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55014/
---

Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav 
Kulshreshtha.


Bugs: AMBARI-19292
https://issues.apache.org/jira/browse/AMBARI-19292


Repository: ambari


Description
---

Manage Assets.
-User should be able to list his assets.
-users should be able to delete his asset.
Export Asset.
-user should be able to select action node and export by giving name and 
description.
Import Asset
-User should be able to browse all assets and select one to be imported either 
on transition or on the current action node.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/asset-config.js 
PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/components/asset-list.js 
PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/components/asset-manager.js 
PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/designer-workspace.js
 6cbc3dd 
  contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
50c7592 
  
contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-actions.js
 55f86af 
  contrib/views/wfmanager/src/main/resources/ui/app/services/asset-manager.js 
PRE-CREATION 
  contrib/views/wfmanager/src/main/resources/ui/app/styles/app.less 6296a64 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-config.hbs
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-list.hbs
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/asset-manager.hbs
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/designer-workspace.hbs
 20e5b35 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/flow-designer.hbs
 101f861 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/workflow-actions.hbs
 50a87d8 
  contrib/views/wfmanager/src/main/resources/ui/bower.json 7fc1736 
  contrib/views/wfmanager/src/main/resources/ui/ember-cli-build.js 5dfb87c 
  
contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/asset-config-test.js
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/asset-list-test.js
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/asset-manager-test.js
 PRE-CREATION 
  
contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/asset-manager-test.js
 PRE-CREATION 

Diff: https://reviews.apache.org/r/55014/diff/


Testing
---

Manual


Thanks,

Madhan Reddy

Re: Review Request 54970: AMBARI-19250 Change default Spark configuration property in Oozie configuration settings to valid value

[ping wang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54970/
---

(Updated 十二月 23, 2016, 11:58 a.m.)


Review request for Ambari, Alejandro Fernandez and Di Li.


Bugs: AMBARI-19250
https://issues.apache.org/jira/browse/AMBARI-19250


Repository: ambari


Description
---

Change default Spark configuration property in Oozie configuration settings to 
valid value


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py
 a2d725c 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.2.5/configuration/oozie-site.xml
 cdb6972 

Diff: https://reviews.apache.org/r/54970/diff/


Testing
---

I have tested the fix by:
1) copy the changed files into ambari host and restart ambari-server
2) delete oozie service and then add it back
3) check the property value is point to the spark configuration directory 
correctly


Thanks,

ping wang

Re: Review Request 54939: AMBARI-19270. Log successful agent cache update at info level

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54939/#review160070
---


Ship it!




Ship It!

- Balázs Bence Sári


On Dec. 21, 2016, 3:42 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54939/
> ---
> 
> (Updated Dec. 21, 2016, 3:42 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-19270
> https://issues.apache.org/jira/browse/AMBARI-19270
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Sample output:
> 
> ```
> INFO 2016-12-21 14:52:44,542 FileCache.py:170 - Updated directory 
> /var/lib/ambari-agent/cache/host_scripts
> INFO 2016-12-21 14:52:44,921 FileCache.py:170 - Updated directory 
> /var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks
> INFO 2016-12-21 14:52:44,944 FileCache.py:170 - Updated directory 
> /var/lib/ambari-agent/cache/common-services/YARN/3.0.0/package
> INFO 2016-12-21 14:55:23,562 FileCache.py:170 - Updated directory 
> /var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package
> INFO 2016-12-21 14:55:35,236 FileCache.py:170 - Updated directory 
> /var/lib/ambari-agent/cache/common-services/TEZ/0.4.0.2.1/package
> INFO 2016-12-21 14:55:59,220 FileCache.py:170 - Updated directory 
> /var/lib/ambari-agent/cache/common-services/ZOOKEEPER/3.4.5/package
> INFO 2016-12-21 15:10:04,535 FileCache.py:170 - Updated directory 
> /var/lib/ambari-agent/cache/common-services/SQOOP/1.4.4.2.0/package
> ```
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/FileCache.py 
> a9ea8f6de1c30ee59002a3a22a044797b66abb17 
> 
> Diff: https://reviews.apache.org/r/54939/diff/
> 
> 
> Testing
> ---
> 
> Tested manually: create cluster; add service.
> 
> Unit tests:
> 
> ```
> $ mvn -am -pl ambari-agent clean test
> ...
> Ran 451 tests in 15.364s
> 
> OK
> ...
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
> approved: 151 licence.
> ...
> [INFO] Ambari Agent .. SUCCESS [20.857s]
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Review Request 55012: AMBARI-19291: User should be shown proper error message in file browser page

[Madhan Reddy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55012/
---

Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav 
Kulshreshtha.


Bugs: AMBARI-19291
https://issues.apache.org/jira/browse/AMBARI-19291


Repository: ambari


Description
---

User should be shown proper error message when user tries to navigate to a hdfs 
folder and he doesn't have access on that folder.
Steps to reproduce :
1) Try to import workflow from HDFS .
2) In the file browser, click on a folder on which user doesn't have permission
3) Though api 
/api/v1/views/Workflow%20Manager/versions/1.0.0/instances/WFD/resources/proxy/fileServices/fileops/listdir?path=%2Ftmp%2Fhive
 fails with appropriate error, UI keeps on loading.
UI should handle this error and show appropriate message to the user.


Diffs
-

  contrib/views/wfmanager/src/main/resources/ui/app/components/hdfs-browser.js 
c9be41a 
  
contrib/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs
 437640d 

Diff: https://reviews.apache.org/r/55012/diff/


Testing
---

Manual


Thanks,

Madhan Reddy

Re: Review Request 54895: AMBARI-19256:Asset support Rest API

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54895/#review160064
---


Ship it!




Ship It!

- Gaurav Nagar


On Dec. 21, 2016, 8:57 a.m., belliraj hb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54895/
> ---
> 
> (Updated Dec. 21, 2016, 8:57 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Nitiraj Rathore, and Pallav 
> Kulshreshtha.
> 
> 
> Bugs: AMBARI-19256
> https://issues.apache.org/jira/browse/AMBARI-19256
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add rest API support for storing and retrieving assets from ambari view db.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/AssetDefinitionRefType.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/Constants.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/EntityStatus.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieDelegate.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieProxyImpersonator.java
>  08a166d 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/OozieUtils.java
>  f002102 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/ServiceFormattedException.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/WorkflowFilesService.java
>  01bde47 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetDefinitionRepo.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetRepo.java
>  1390ec0 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetResource.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/AssetService.java
>  648a89f 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/model/ActionAsset.java
>  8eb6081 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/model/ActionAssetDefinition.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/assets/model/AssetDefintion.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/model/APIResult.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/model/BaseModel.java
>  553ce24 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/model/Indexed.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/model/Paging.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/model/When.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/repo/BaseRepo.java
>  PRE-CREATION 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowManagerService.java
>  4c88454 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsManagerResource.java
>  17a3296 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/WorkflowsRepo.java
>  978c059 
>   
> contrib/views/wfmanager/src/main/java/org/apache/oozie/ambari/view/workflowmanager/model/Workflow.java
>  ad5f48b 
>   contrib/views/wfmanager/src/main/resources/view.xml bfa1253 
> 
> Diff: https://reviews.apache.org/r/54895/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> belliraj hb
> 
>

Re: Review Request 55011: Apply changes in Ambari after ZEPPELIN-1489 in zeppelin

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55011/#review160063
---


Ship it!




Ship It!

- Gaurav Nagar


On Dec. 23, 2016, 10:10 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55011/
> ---
> 
> (Updated Dec. 23, 2016, 10:10 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19290
> https://issues.apache.org/jira/browse/AMBARI-19290
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Apply changes in Ambari after ZEPPELIN-1489 in zeppelin
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  39941f7 
> 
> Diff: https://reviews.apache.org/r/55011/diff/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Re: Review Request 55011: Apply changes in Ambari after ZEPPELIN-1489 in zeppelin

[Rohit Choudhary]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55011/#review160062
---


Ship it!




Ship It!

- Rohit Choudhary


On Dec. 23, 2016, 10:10 a.m., Prabhjyot Singh wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55011/
> ---
> 
> (Updated Dec. 23, 2016, 10:10 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav 
> Nagar, Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and 
> Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19290
> https://issues.apache.org/jira/browse/AMBARI-19290
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Apply changes in Ambari after ZEPPELIN-1489 in zeppelin
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  39941f7 
> 
> Diff: https://reviews.apache.org/r/55011/diff/
> 
> 
> Testing
> ---
> 
> Manually on CentOS 6
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>

Review Request 55011: Apply changes in Ambari after ZEPPELIN-1489 in zeppelin

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55011/
---

Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Gaurav Nagar, 
Jayush Luniya, Nitiraj Rathore, Rohit Choudhary, Renjith Kamath, and Sumit 
Mohanty.


Bugs: AMBARI-19290
https://issues.apache.org/jira/browse/AMBARI-19290


Repository: ambari


Description
---

Apply changes in Ambari after ZEPPELIN-1489 in zeppelin


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
 39941f7 

Diff: https://reviews.apache.org/r/55011/diff/


Testing
---

Manually on CentOS 6


Thanks,

Prabhjyot Singh

Re: Review Request 54857: Refactor Ambari service def configurations for Zeppelin

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54857/#review160055
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Dec. 19, 2016, 9:59 a.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54857/
> ---
> 
> (Updated Dec. 19, 2016, 9:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17470
> https://issues.apache.org/jira/browse/AMBARI-17470
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Move shiro.ini and log4j.properties out of zeppelin-env configuration.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  2beac97 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-shiro-ini.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
>  382e913 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  5ee6147 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ZEPPELIN/configuration/zeppelin-env.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54857/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on CentOS 6.6
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 54977: Zeppelin Notebook Component is not able start after reboot

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54977/#review160056
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Dec. 22, 2016, 12:55 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54977/
> ---
> 
> (Updated Dec. 22, 2016, 12:55 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19264
> https://issues.apache.org/jira/browse/AMBARI-19264
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - intermittently fails to start the service when /var/run/zeppelin dir is not 
> present.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  39941f7 
> 
> Diff: https://reviews.apache.org/r/54977/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 54930: Remove Spark dependency from Zeppelin service def

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54930/#review160054
---


Ship it!




Ship It!

- Pallav Kulshreshtha


On Dec. 21, 2016, 7:28 a.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54930/
> ---
> 
> (Updated Dec. 21, 2016, 7:28 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19263
> https://issues.apache.org/jira/browse/AMBARI-19263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove Spark dependency from Zeppelin service def
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
>  382e913 
> 
> Diff: https://reviews.apache.org/r/54930/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on CentOS 6
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 54305: Hive view history tab does not list queries, if there are large number of queries

[Prabhjyot Singh]

> On Dec. 23, 2016, 9:10 a.m., Prabhjyot Singh wrote:
> > Ship It!

fix it and Ship  it!


- Prabhjyot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54305/#review160051
---


On Dec. 2, 2016, 12:24 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54305/
> ---
> 
> (Updated Dec. 2, 2016, 12:24 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-19062
> https://issues.apache.org/jira/browse/AMBARI-19062
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : ATS calls for each job was taking time.
> In this patch : remove ATS calls as now the view will store correct status in 
> the view tables itself
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/Aggregator.java
>  99faeca 
> 
> Diff: https://reviews.apache.org/r/54305/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 54857: Refactor Ambari service def configurations for Zeppelin

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54857/#review160052
---


Ship it!




Ship It!

- Gaurav Nagar


On Dec. 19, 2016, 9:59 a.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54857/
> ---
> 
> (Updated Dec. 19, 2016, 9:59 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-17470
> https://issues.apache.org/jira/browse/AMBARI-17470
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Move shiro.ini and log4j.properties out of zeppelin-env configuration.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml
>  2beac97 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-log4j-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-shiro-ini.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
>  382e913 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/params.py
>  5ee6147 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/ZEPPELIN/configuration/zeppelin-env.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54857/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on CentOS 6.6
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 54305: Hive view history tab does not list queries, if there are large number of queries

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54305/#review160051
---


Ship it!




Ship It!

- Prabhjyot Singh


On Dec. 2, 2016, 12:24 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54305/
> ---
> 
> (Updated Dec. 2, 2016, 12:24 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-19062
> https://issues.apache.org/jira/browse/AMBARI-19062
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : ATS calls for each job was taking time.
> In this patch : remove ATS calls as now the view will store correct status in 
> the view tables itself
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/Aggregator.java
>  99faeca 
> 
> Diff: https://reviews.apache.org/r/54305/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 54305: Hive view history tab does not list queries, if there are large number of queries

[Prabhjyot Singh]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54305/#review160050
---




contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/Aggregator.java
 (line 208)


can you move .append(")") out of this if block.


- Prabhjyot Singh


On Dec. 2, 2016, 12:24 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54305/
> ---
> 
> (Updated Dec. 2, 2016, 12:24 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-19062
> https://issues.apache.org/jira/browse/AMBARI-19062
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Earlier : ATS calls for each job was taking time.
> In this patch : remove ATS calls as now the view will store correct status in 
> the view tables itself
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/jobs/Aggregator.java
>  99faeca 
> 
> Diff: https://reviews.apache.org/r/54305/diff/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 54977: Zeppelin Notebook Component is not able start after reboot

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54977/#review160049
---


Ship it!




Ship It!

- Gaurav Nagar


On Dec. 22, 2016, 12:55 p.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54977/
> ---
> 
> (Updated Dec. 22, 2016, 12:55 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19264
> https://issues.apache.org/jira/browse/AMBARI-19264
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - intermittently fails to start the service when /var/run/zeppelin dir is not 
> present.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/package/scripts/master.py
>  39941f7 
> 
> Diff: https://reviews.apache.org/r/54977/diff/
> 
> 
> Testing
> ---
> 
> manually tested on CentOS
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 54930: Remove Spark dependency from Zeppelin service def

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54930/#review160048
---


Ship it!




Ship It!

- Gaurav Nagar


On Dec. 21, 2016, 7:28 a.m., Renjith Kamath wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54930/
> ---
> 
> (Updated Dec. 21, 2016, 7:28 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush 
> Luniya, Prabhjyot Singh, Rohit Choudhary, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19263
> https://issues.apache.org/jira/browse/AMBARI-19263
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove Spark dependency from Zeppelin service def
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/metainfo.xml
>  382e913 
> 
> Diff: https://reviews.apache.org/r/54930/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on CentOS 6
> 
> 
> Thanks,
> 
> Renjith Kamath
> 
>

Re: Review Request 54939: AMBARI-19270. Log successful agent cache update at info level

[Laszlo Puskas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54939/#review160047
---


Ship it!




Ship It!

- Laszlo Puskas


On Dec. 21, 2016, 3:42 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54939/
> ---
> 
> (Updated Dec. 21, 2016, 3:42 p.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-19270
> https://issues.apache.org/jira/browse/AMBARI-19270
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Sample output:
> 
> ```
> INFO 2016-12-21 14:52:44,542 FileCache.py:170 - Updated directory 
> /var/lib/ambari-agent/cache/host_scripts
> INFO 2016-12-21 14:52:44,921 FileCache.py:170 - Updated directory 
> /var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks
> INFO 2016-12-21 14:52:44,944 FileCache.py:170 - Updated directory 
> /var/lib/ambari-agent/cache/common-services/YARN/3.0.0/package
> INFO 2016-12-21 14:55:23,562 FileCache.py:170 - Updated directory 
> /var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package
> INFO 2016-12-21 14:55:35,236 FileCache.py:170 - Updated directory 
> /var/lib/ambari-agent/cache/common-services/TEZ/0.4.0.2.1/package
> INFO 2016-12-21 14:55:59,220 FileCache.py:170 - Updated directory 
> /var/lib/ambari-agent/cache/common-services/ZOOKEEPER/3.4.5/package
> INFO 2016-12-21 15:10:04,535 FileCache.py:170 - Updated directory 
> /var/lib/ambari-agent/cache/common-services/SQOOP/1.4.4.2.0/package
> ```
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/FileCache.py 
> a9ea8f6de1c30ee59002a3a22a044797b66abb17 
> 
> Diff: https://reviews.apache.org/r/54939/diff/
> 
> 
> Testing
> ---
> 
> Tested manually: create cluster; add service.
> 
> Unit tests:
> 
> ```
> $ mvn -am -pl ambari-agent clean test
> ...
> Ran 451 tests in 15.364s
> 
> OK
> ...
> [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
> approved: 151 licence.
> ...
> [INFO] Ambari Agent .. SUCCESS [20.857s]
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 54936: Zookeeper and RM connection is not secure

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54936/#review160045
---


Ship it!




Ship It!

- Sebastian Toader


On Dec. 22, 2016, 9:53 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54936/
> ---
> 
> (Updated Dec. 22, 2016, 9:53 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Eugene 
> Chekanskiy, Laszlo Puskas, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19269
> https://issues.apache.org/jira/browse/AMBARI-19269
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> I modified the kerberization/dekerberization process of YARN RM
> based on 
> https://docs.google.com/document/d/1IEAVBFU2QMhKP5It4_u7L1UtP_QRBTHUk9cOuHjK8AU/
> 
> - yarn.resourcemanager.zk-acl is set to sasl:rm:rwcda when kerberos is 
> enabled (kerberos.json) 
> - jaas file is added to YARN_OPTS with the correct principal and keytab when 
> kerberos is enabled
> - ACL is reverted to world:anyone:crdwa when disabling kerberos
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json 
> 4093431 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  0496995 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
>  6a7eea7 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  f5acb11 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/templates/yarn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 
> e690204 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py
>  cdadc80 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/resourcemanager.py
>  e053fe6 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/yarn.py
>  70ed5b3 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/templates/yarn_jaas.conf.j2
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 
> 2fdce8a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json
>  b02b3e9 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json 
> 0d67e59 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
> e690204 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> bea3f81 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 
> 466b0f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 4abf2c9 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 
> 7b5ce18 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 3719fe5 
> 
> Diff: https://reviews.apache.org/r/54936/diff/
> 
> 
> Testing
> ---
> 
> Manual testing:
>  - created a cluster with YARN + HDFS + ZooKeeper
>  - enabled kerberos
>  - check that the acl on /rmstore/ZKRMStateRoot is set to sasl
>  - disabled kerberos
>  - checked that the acl on /rmstore/ZKRMStateRoot is 'world,'anyone
>  - Enabled YARN RM HA mode, repeated the above test
> 
> Tests:
> Ambari server:
> Tests run: 4782, Failures: 0, Errors: 0, Skipped: 37
> 
> Python tests:
> Total run:1146
> Total errors:0
> Total failures:0
> 
> Ambari agent:
> Ran 447 tests in 22.056s
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 54891: Create quick links profile evaluator

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54891/#review160044
---


Ship it!




Ship It!

- Sebastian Toader


On Dec. 21, 2016, 8 p.m., Balázs Bence Sári wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54891/
> ---
> 
> (Updated Dec. 21, 2016, 8 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Jayush Luniya, Laszlo Puskas, 
> Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19244
> https://issues.apache.org/jira/browse/AMBARI-19244
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Profile evaluator is a class that takes a quick links profile as input and 
> can decide on the visibility of quicklinks based on the received profile.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
>  72ad764 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java
>  5124241 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java
>  7ef0259 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java
>  1711628 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/PropertyFilter.java
>  7b5eba0 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java
>  1a1488b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
>  c1f3c86 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java
>  600872f 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java
>  190e61b 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java
>  0644027 
>   
> ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_common_services/HIVE/0.11.0.2.0.5.0/package/.hash
>  9550dab 
>   
> ambari-server/src/test/resources/TestAmbaryServer.samples/dummy_stack/HIVE/package/.hash
>  9550dab 
>   ambari-server/src/test/resources/child_quicklinks_with_properties.json 
> 36cd4f3 
>   ambari-server/src/test/resources/example_quicklinks_profile.json 028d011 
>   ambari-server/src/test/resources/inconsistent_quicklinks_profile.json 
> e5bc310 
>   ambari-server/src/test/resources/parent_quicklinks_with_properties.json 
> a315f3f 
> 
> Diff: https://reviews.apache.org/r/54891/diff/
> 
> 
> Testing
> ---
> 
> Wrote new unit tests. Run the ambari-server test suite. Failures are 
> irrelevant.
> 
> Failed tests:
>   DataStoreImplTest.testFind:524 expected: DS_DataStoreImplTest$TestEntity_1> but was: DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testRemove:473 expected: DS_DataStoreImplTest$TestEntity_1> but was: DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update:355 expected: DS_DataStoreImplTest$TestEntity_1> but was: DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update_longStringValue:424
>   Expectation failure on verify:
> DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
> Tests in error:
>   KerberosCheckerTest.testCheckFailed »  Unexpected exception, 
> expected   KerberosCheckerTest.testCheckPassed:62 » ClassCast class 
> sun.security.provider...
>   AmbariBasicAuthenticationFilterTest.testOnSuccessfulAuthentication:99 » 
> Linkage
> 
> Tests run: 4136, Failures: 4, Errors: 3, Skipped: 31
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>