Re: Review Request 57124: Hive view 2.0 Fetch stats doesn't work when you point against LLAP

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57124/#review167024
---


Ship it!




Ship It!

- Nitiraj Rathore


On Feb. 28, 2017, 5:32 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57124/
> ---
> 
> (Updated Feb. 28, 2017, 5:32 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20223
> https://issues.apache.org/jira/browse/AMBARI-20223
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> For fetching stats we are using old query syntax that wont work in Hive 2.0. 
> Changed the query to newer syntax.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AlterTableQueryGenerator.java
>  b119f6a 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java
>  902d959 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/FetchColumnStatsQueryGenerator.java
>  73b3698 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java
>  42cec0a 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGenerator.java
>  3406b80 
>   
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AlterTableQueryGeneratorTest.java
>  35ea416 
>   
> contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGeneratorSpecTest.groovy
>  cce9e6c 
> 
> Diff: https://reviews.apache.org/r/57124/diff/
> 
> 
> Testing
> ---
> 
> Manually Tested.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Review Request 57126: HiveView2.0: Logs tab is always empty

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57126/
---

Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-20224
https://issues.apache.org/jira/browse/AMBARI-20224


Repository: ambari


Description
---

Remove extra '/' from url


Diffs
-

  contrib/views/hive20/src/main/resources/ui/app/adapters/query.js f878230 

Diff: https://reviews.apache.org/r/57126/diff/


Testing
---

Manually Tested


Thanks,

Gaurav Nagar

Review Request 57124: Hive view 2.0 Fetch stats doesn't work when you point against LLAP

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57124/
---

Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-20223
https://issues.apache.org/jira/browse/AMBARI-20223


Repository: ambari


Description
---

For fetching stats we are using old query syntax that wont work in Hive 2.0. 
Changed the query to newer syntax.


Diffs
-

  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AlterTableQueryGenerator.java
 b119f6a 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/AnalyzeTableQueryGenerator.java
 902d959 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/FetchColumnStatsQueryGenerator.java
 73b3698 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/InsertFromQueryGenerator.java
 42cec0a 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGenerator.java
 3406b80 
  
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/AlterTableQueryGeneratorTest.java
 35ea416 
  
contrib/views/hive20/src/test/java/org/apache/ambari/view/hive20/internal/query/generators/RenameTableQueryGeneratorSpecTest.groovy
 cce9e6c 

Diff: https://reviews.apache.org/r/57124/diff/


Testing
---

Manually Tested.


Thanks,

Gaurav Nagar

Re: Review Request 57120: Hive View 2.0 LogAggregator prints lots of warning logs.

[Ashwin Rajeev]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57120/#review167007
---


Ship it!




Ship It!

- Ashwin Rajeev


On Feb. 28, 2017, 4:55 a.m., Gaurav Nagar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57120/
> ---
> 
> (Updated Feb. 28, 2017, 4:55 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
> 
> 
> Bugs: AMBARI-20222
> https://issues.apache.org/jira/browse/AMBARI-20222
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Stopping the statement executor after query end or failure.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/JdbcConnector.java
>  d6d5d51 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/HiveViewImpl.java
>  aee7d03 
>   
> contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java
>  61f0b66 
> 
> Diff: https://reviews.apache.org/r/57120/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Gaurav Nagar
> 
>

Re: Review Request 57100: Select operators should not appear before fetch

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57100/#review167004
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 27, 2017, 7:29 p.m., Pallav Kulshreshtha wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57100/
> ---
> 
> (Updated Feb. 27, 2017, 7:29 p.m.)
> 
> 
> Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
> Nitiraj Rathore, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-20215
> https://issues.apache.org/jira/browse/AMBARI-20215
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> modified logic to show select node.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js
>  a252498 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js
>  196a514 
>   
> contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js
>  01d6000 
> 
> Diff: https://reviews.apache.org/r/57100/diff/
> 
> 
> Testing
> ---
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Review Request 57120: Hive View 2.0 LogAggregator prints lots of warning logs.

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57120/
---

Review request for Ambari, DIPAYAN BHOWMICK, Nitiraj Rathore, Pallav 
Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.


Bugs: AMBARI-20222
https://issues.apache.org/jira/browse/AMBARI-20222


Repository: ambari


Description
---

Stopping the statement executor after query end or failure.


Diffs
-

  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/actor/JdbcConnector.java
 d6d5d51 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/HiveViewImpl.java
 aee7d03 
  
contrib/views/hive20/src/main/java/org/apache/ambari/view/hive20/actor/JdbcConnector.java
 61f0b66 

Diff: https://reviews.apache.org/r/57120/diff/


Testing
---

Manually tested.


Thanks,

Gaurav Nagar

Re: Review Request 57062: AMBARI-20194 - Enable/Disable UI objects related to managing alert targets based on user's privileges

[Richard Zang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57062/
---

(Updated Feb. 28, 2017, 3:55 a.m.)


Review request for Ambari, Jaimin Jetly and Yusaku Sako.


Changes
---

A follow up fix to make sure UI shows correctly after logout and login with 
user with different role. Remove old 'isOperator' based restrictions on modal 
UI items since we are already enforcing RBAC on the pull down action list.


Bugs: AMBARI-20194
https://issues.apache.org/jira/browse/AMBARI-20194


Repository: ambari


Description
---

Enabled manage alert notification option based on user's privileges


Diffs
-

  
ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js 
a397b7b 

Diff: https://reviews.apache.org/r/57062/diff/


Testing
---

Manually tested on live cluster.
All unit tests passed.


File Attachments (updated)


AMBARI-20194-fix1.patch
  
https://reviews.apache.org/media/uploaded/files/2017/02/28/be236f3c-50bd-4f66-a41b-895c0dbba006__AMBARI-20194-fix1.patch


Thanks,

Richard Zang

Re: Review Request 57062: AMBARI-20194 - Enable/Disable UI objects related to managing alert targets based on user's privileges

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57062/#review166985
---


Ship it!




Ship It!

- Jaimin Jetly


On Feb. 25, 2017, 4:34 a.m., Richard Zang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57062/
> ---
> 
> (Updated Feb. 25, 2017, 4:34 a.m.)
> 
> 
> Review request for Ambari, Jaimin Jetly and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20194
> https://issues.apache.org/jira/browse/AMBARI-20194
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enabled manage alert notification option based on user's privileges
> 
> 
> Diffs
> -
> 
>   
> ambari-web/app/controllers/main/alerts/alert_definitions_actions_controller.js
>  a397b7b 
> 
> Diff: https://reviews.apache.org/r/57062/diff/
> 
> 
> Testing
> ---
> 
> Manually tested on live cluster.
> All unit tests passed.
> 
> 
> Thanks,
> 
> Richard Zang
> 
>

Re: Review Request 57116: Parameterize the Startup Web Server Timeout Default Value

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57116/#review166981
---


Ship it!




Ship It!

- Sumit Mohanty


On Feb. 28, 2017, 1:18 a.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57116/
> ---
> 
> (Updated Feb. 28, 2017, 1:18 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-20220
> https://issues.apache.org/jira/browse/AMBARI-20220
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The {{ambari-server start}} and {{ambari-server restart}} commands are 
> currently hard coded to wait a maximum of 50 seconds for the Jetty server to 
> bind to port 8080 (or whatever the configured port is).
> 
> Under normal circumstances, this value should be fine. However, since Jetty 
> loads classes from views, the more views which are installed increases the 
> total load time before Jetty binds to the server port.
> 
> Although this a general problem with the architecture of Views, it's still 
> valuable to have this startup property configurable.
> 
> ```
> ambari-server restart --debug
> Using python  /usr/bin/python
> Restarting ambari-server
> Waiting for server stop...
> Ambari Server stopped
> Ambari Server running with administrator privileges.
> Organizing resource files at /var/lib/ambari-server/resources...
> Ambari database consistency check started...
> Server PID at: /var/run/ambari-server/ambari-server.pid
> Server out at: /var/log/ambari-server/ambari-server.out
> Server log at: /var/log/ambari-server/ambari-server.log
> Waiting for server 
> start
> DB configs consistency check found warnings. See 
> /var/log/ambari-server/ambari-server-check-database.log for more details.
> ERROR: Exiting with exit code 1.
> REASON: Server not yet listening on http port 8080 after 50 seconds. Exiting.
> ```
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md ae2d549 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  e1df5bd 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py c771b1e 
>   ambari-server/src/main/python/ambari_server_main.py 66678b0 
>   ambari-server/src/test/python/TestAmbariServer.py 0f704f9 
> 
> Diff: https://reviews.apache.org/r/57116/diff/
> 
> 
> Testing
> ---
> 
> --
> Total run:1191
> Total errors:0
> Total failures:0
> OK
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 52.742 s
> [INFO] Finished at: 2017-02-27T20:16:22-05:00
> [INFO] Final Memory: 18M/310M
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 57116: Parameterize the Startup Web Server Timeout Default Value

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57116/
---

Review request for Ambari, Dmitro Lisnichenko, Nate Cole, and Sumit Mohanty.


Bugs: AMBARI-20220
https://issues.apache.org/jira/browse/AMBARI-20220


Repository: ambari


Description
---

The {{ambari-server start}} and {{ambari-server restart}} commands are 
currently hard coded to wait a maximum of 50 seconds for the Jetty server to 
bind to port 8080 (or whatever the configured port is).

Under normal circumstances, this value should be fine. However, since Jetty 
loads classes from views, the more views which are installed increases the 
total load time before Jetty binds to the server port.

Although this a general problem with the architecture of Views, it's still 
valuable to have this startup property configurable.

```
ambari-server restart --debug
Using python  /usr/bin/python
Restarting ambari-server
Waiting for server stop...
Ambari Server stopped
Ambari Server running with administrator privileges.
Organizing resource files at /var/lib/ambari-server/resources...
Ambari database consistency check started...
Server PID at: /var/run/ambari-server/ambari-server.pid
Server out at: /var/log/ambari-server/ambari-server.out
Server log at: /var/log/ambari-server/ambari-server.log
Waiting for server 
start
DB configs consistency check found warnings. See 
/var/log/ambari-server/ambari-server-check-database.log for more details.
ERROR: Exiting with exit code 1.
REASON: Server not yet listening on http port 8080 after 50 seconds. Exiting.
```


Diffs
-

  ambari-server/docs/configuration/index.md ae2d549 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 e1df5bd 
  ambari-server/src/main/python/ambari_server/serverConfiguration.py c771b1e 
  ambari-server/src/main/python/ambari_server_main.py 66678b0 
  ambari-server/src/test/python/TestAmbariServer.py 0f704f9 

Diff: https://reviews.apache.org/r/57116/diff/


Testing
---

--
Total run:1191
Total errors:0
Total failures:0
OK
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 52.742 s
[INFO] Finished at: 2017-02-27T20:16:22-05:00
[INFO] Final Memory: 18M/310M


Thanks,

Jonathan Hurley

Re: Review Request 57115: AMBARI-20219 : Grafana Start Failed on HDF cluster

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57115/#review166978
---


Ship it!




Ship It!

- Jayush Luniya


On Feb. 28, 2017, 12:46 a.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57115/
> ---
> 
> (Updated Feb. 28, 2017, 12:46 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20219
> https://issues.apache.org/jira/browse/AMBARI-20219
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Start All failed with Grafana start command failure, even though Grafana 
> Server started up fine.
> 
> Current wait time for Grafana pid creation is 5 seconds, which may not be 
> sufficient on slower systems. Increaed wait time to 20 sec, with periodic 
> checks every 2 seconds.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana 
> 8a8ac8f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  cc751c0 
> 
> Diff: https://reviews.apache.org/r/57115/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Re: Review Request 57115: AMBARI-20219 : Grafana Start Failed on HDF cluster

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57115/#review166977
---


Ship it!




Ship It!

- Sid Wagle


On Feb. 28, 2017, 12:46 a.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57115/
> ---
> 
> (Updated Feb. 28, 2017, 12:46 a.m.)
> 
> 
> Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20219
> https://issues.apache.org/jira/browse/AMBARI-20219
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Start All failed with Grafana start command failure, even though Grafana 
> Server started up fine.
> 
> Current wait time for Grafana pid creation is 5 seconds, which may not be 
> sufficient on slower systems. Increaed wait time to 20 sec, with periodic 
> checks every 2 seconds.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana 
> 8a8ac8f 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  cc751c0 
> 
> Diff: https://reviews.apache.org/r/57115/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Aravindan Vijayan
> 
>

Review Request 57115: AMBARI-20219 : Grafana Start Failed on HDF cluster

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57115/
---

Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-20219
https://issues.apache.org/jira/browse/AMBARI-20219


Repository: ambari


Description
---

Start All failed with Grafana start command failure, even though Grafana Server 
started up fine.

Current wait time for Grafana pid creation is 5 seconds, which may not be 
sufficient on slower systems. Increaed wait time to 20 sec, with periodic 
checks every 2 seconds.


Diffs
-

  ambari-metrics/ambari-metrics-grafana/conf/unix/ambari-metrics-grafana 
8a8ac8f 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
 cc751c0 

Diff: https://reviews.apache.org/r/57115/diff/


Testing
---

Manually tested.


Thanks,

Aravindan Vijayan

Re: Review Request 57113: Jars clean up

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57113/#review166960
---


Ship it!




Ship It!

- Sumit Mohanty


On Feb. 27, 2017, 11:06 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57113/
> ---
> 
> (Updated Feb. 27, 2017, 11:06 p.m.)
> 
> 
> Review request for Ambari, Robert Levas, Sumit Mohanty, and Sid Wagle.
> 
> 
> Bugs: AMBARI-20218
> https://issues.apache.org/jira/browse/AMBARI-20218
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Do clean up.
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml 825987b 
>   ambari-agent/src/packages/tarball/all.xml e88d3bc 
>   ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink.xml 35e0b47 
>   
> ambari-metrics/ambari-metrics-flume-sink/src/main/assemblies/jar-with-common.xml
>  cef956c 
>   
> ambari-metrics/ambari-metrics-hadoop-sink/src/main/assemblies/jar-with-common.xml
>  058a8bb 
>   
> ambari-metrics/ambari-metrics-kafka-sink/src/main/assemblies/jar-with-common.xml
>  7eb9774 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/assemblies/simulator.xml
>  b582096 
>   ambari-server/src/main/assemblies/server.xml 29739cd 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py d5d3baa 
> 
> Diff: https://reviews.apache.org/r/57113/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 57113: Jars clean up

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57113/
---

Review request for Ambari, Robert Levas, Sumit Mohanty, and Sid Wagle.


Bugs: AMBARI-20218
https://issues.apache.org/jira/browse/AMBARI-20218


Repository: ambari


Description
---

Do clean up.


Diffs
-

  ambari-agent/pom.xml 825987b 
  ambari-agent/src/packages/tarball/all.xml e88d3bc 
  ambari-metrics/ambari-metrics-assembly/src/main/assembly/sink.xml 35e0b47 
  
ambari-metrics/ambari-metrics-flume-sink/src/main/assemblies/jar-with-common.xml
 cef956c 
  
ambari-metrics/ambari-metrics-hadoop-sink/src/main/assemblies/jar-with-common.xml
 058a8bb 
  
ambari-metrics/ambari-metrics-kafka-sink/src/main/assemblies/jar-with-common.xml
 7eb9774 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/assemblies/simulator.xml 
b582096 
  ambari-server/src/main/assemblies/server.xml 29739cd 
  ambari-server/src/main/python/ambari_server/serverConfiguration.py d5d3baa 

Diff: https://reviews.apache.org/r/57113/diff/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 57089: HDP 3.0 support for Slider with configs, kerberos, widgets, metrics, quicklinks, and themes

[Jayush Luniya]

> On Feb. 27, 2017, 6:43 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/3.0/services/SLIDER/metainfo.xml,
> >  line 24
> > 
> >
> > This should be a brand new version of Slider.
> > It needs to contain a flattening of the configs from all of the older 
> > stacks, kerberos.json, widgets.json, etc.

It would be nice if we can build a tool to do the flattening so that we can use 
it for other services. We already have code that does the configs merge etc, we 
just want to export this out to create the merged service definition.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57089/#review166906
---


On Feb. 27, 2017, 1:24 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57089/
> ---
> 
> (Updated Feb. 27, 2017, 1:24 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sid Wagle, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-19835
> https://issues.apache.org/jira/browse/AMBARI-19835
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDP 3.0 support for Slider with configs, kerberos, widgets, metrics, 
> quicklinks, and themes
> Flatten from HDP 2.0.6 - 2.6 into common-services, and reference in HDP 3.0
> In HDP 3.0, we have created a new stack definition that does not inherit from 
> other stacks, in order to reduce the complexity of having to analyze older 
> stacks.
> This means that we need to create a service definition (metainfo.xml, 
> configs, kerberos, widgets, metrics, quicklinks, and themes) that is 
> equivalent to what is inherit and deleted from all of the previous stacks.
> A merge needs to account for additions, overrides, and deletions.
> metainfo.xml and configs perform a merge of older versions
> kerberos.json always seems to override the previous file
> Because the bits for this service may not yet be available in the HDP 3.0 
> repo, 
> the task is to ensure that /api/v1/stacks/HDP/versions/2.6/services/SLIDER 
> (which uses inheritance) is equivalent to the flattening of 
> /api/v1/stacks/HDP/versions/3.0/services/SLIDER .
> Please take a look at how this was done for ZK, HDFS, and YARN/MR.
> This means that you will not be able to actually install the service for now, 
> but can still perform validation during the Install Wizard that the correct 
> components and configs show up.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/SLIDER/metainfo.xml 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/57089/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 57096: Remove HDP version check in KAFKA service

[Alejandro Fernandez]

> On Feb. 27, 2017, 6:41 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json,
> >  line 25
> > 
> >
> > This is also needed in HDP 3.0
> 
> Madhuvanthi Radhakrishnan wrote:
> I have added this change in 
> ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.json
>  and attached a trunk patch to the apache jira.
> 
> Jayush Luniya wrote:
> @Alejandro, 
> For HDP-3.0 what is going to be the min HDP version from which we will be 
> upgrading? We should look at all the places where we have stack-version 
> specific logic and do a code cleanup to remove these if-else blocks.

@Jayush, that's yet to be determined. For now, we just need to keep the code 
changes in sync.


- Alejandro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57096/#review166905
---


On Feb. 27, 2017, 7:10 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57096/
> ---
> 
> (Updated Feb. 27, 2017, 7:10 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20212
> https://issues.apache.org/jira/browse/AMBARI-20212
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove HDP version check in KAFKA service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  015e150 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  bc2e7a7 
> 
> Diff: https://reviews.apache.org/r/57096/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57096: Remove HDP version check in KAFKA service

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57096/#review166926
---




ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 (line 25)


Can you add this to 
ambari/ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.jsonas
 well?


- Jayush Luniya


On Feb. 27, 2017, 7:10 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57096/
> ---
> 
> (Updated Feb. 27, 2017, 7:10 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20212
> https://issues.apache.org/jira/browse/AMBARI-20212
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove HDP version check in KAFKA service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  015e150 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  bc2e7a7 
> 
> Diff: https://reviews.apache.org/r/57096/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57096: Remove HDP version check in KAFKA service

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57096/#review166929
---


Ship it!




Ship It!

- Jayush Luniya


On Feb. 27, 2017, 7:10 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57096/
> ---
> 
> (Updated Feb. 27, 2017, 7:10 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20212
> https://issues.apache.org/jira/browse/AMBARI-20212
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove HDP version check in KAFKA service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  015e150 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  bc2e7a7 
> 
> Diff: https://reviews.apache.org/r/57096/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57096: Remove HDP version check in KAFKA service

[Jayush Luniya]

> On Feb. 27, 2017, 6:41 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json,
> >  line 25
> > 
> >
> > This is also needed in HDP 3.0
> 
> Madhuvanthi Radhakrishnan wrote:
> I have added this change in 
> ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.json
>  and attached a trunk patch to the apache jira.

@Alejandro, 
For HDP-3.0 what is going to be the min HDP version from which we will be 
upgrading? We should look at all the places where we have stack-version 
specific logic and do a code cleanup to remove these if-else blocks.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57096/#review166905
---


On Feb. 27, 2017, 7:10 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57096/
> ---
> 
> (Updated Feb. 27, 2017, 7:10 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20212
> https://issues.apache.org/jira/browse/AMBARI-20212
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove HDP version check in KAFKA service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  015e150 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  bc2e7a7 
> 
> Diff: https://reviews.apache.org/r/57096/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Review Request 57100: Select operators should not appear before fetch

[Pallav Kulshreshtha]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57100/
---

Review request for Ambari, Abhishek Kumar, DIPAYAN BHOWMICK, Gaurav Nagar, 
Nitiraj Rathore, Rohit Choudhary, and venkat sairam.


Bugs: AMBARI-20215
https://issues.apache.org/jira/browse/AMBARI-20215


Repository: ambari


Description
---

modified logic to show select node.


Diffs
-

  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/processor.js
 a252498 
  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/renderer.js 
196a514 
  
contrib/views/hive20/src/main/resources/ui/app/utils/hive-explainer/transformer.js
 01d6000 

Diff: https://reviews.apache.org/r/57100/diff/


Testing
---

manually tested.


Thanks,

Pallav Kulshreshtha

Re: Review Request 57080: Ambari should install the unlimited key JCE policy based on service requirements even if cluster is not Kerberized

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57080/#review166922
---


Ship it!




Ship It!

- Alejandro Fernandez


On Feb. 27, 2017, 6:56 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57080/
> ---
> 
> (Updated Feb. 27, 2017, 6:56 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Attila Magyar, Andrew 
> Onischuk, Balázs Bence Sári, Eugene Chekanskiy, Laszlo Puskas, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-20196
> https://issues.apache.org/jira/browse/AMBARI-20196
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari should install the unlimited key JCE policy based on service 
> requirements even if cluster is not Kerberized. For example, if a service 
> needs the unlimited key JCE policy for an encryption task not related to 
> Kerberos.
> 
> On a similar note, the unlimited key JCE policy is not being distributed to 
> the agents if Kerberos is enabled using the "manual" option - as opposed to 
> integrating with an existing KDC.
> 
> On a related note, Ambari Server host automatically unpacks JCE unlimited 
> during "ambari-server setup" (unless custom JDK is used).
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml 074e051 
>   ambari-agent/src/main/java/org/apache/ambari/tools/jce/JcePolicyInfo.java 
> PRE-CREATION 
>   
> ambari-common/src/main/python/resource_management/core/resources/jcepolicyinfo.py
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  c80ebe6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  7cb7fce 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
>  51d9847 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> 409bcae 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UnlimitedKeyJCERequirement.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py
>  ddc8063 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
>  5db62c5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  3f74aa7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py
>  f21e4b1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  29c88b4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  9783aa4 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/configuration/cluster-env.xml 
> 3af8f08 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/hook.py
>  f21e4b1 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/params.py
>  455710b 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/shared_initialization.py
>  5dce8e0 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_client.py
>  2ab700d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
>  6e37ded 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json 
> fa4cc9d 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py
>  30561ac 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
> 444fae6 
> 
> Diff: https://reviews.apache.org/r/57080/diff/
> 
> 
> Testing
> ---
> 
> Manually tested with various versions of Java - Oracle 1.7. Oracle 1.8, and 
> OpenJDK 1.8.
> 
> # Local test results:
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 28:49.548s
> [INFO] Finished at: Mon Feb 27 12:50:22 EST 2017
> [INFO] Final Memory: 70M/613M
> [INFO] 
> 
> ```
> 
> # Jenkins test results:
> ```
> {color:green}+1 overall{color}.  Here are the results of testing the latest 
> attachment
>   
> http://issues.apache.org/jira/secure/attachment/12854862/AMBARI-20196_trunk_01.patch
>   against trunk revision .
> 
> {color:green}+1 @author{color}.  The patch does not contain any @author 
> tags.
> 
> {color:green}+1 tests included{color}.  The patch appears to include 4 
> new or modified test files.
> 
> {color:green}+1 javac{color}.  The applied patch does not 

Re: Review Request 57096: Remove HDP version check in KAFKA service

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57096/#review166915
---


Ship it!




Ship It!

- Sumit Mohanty


On Feb. 27, 2017, 7:10 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57096/
> ---
> 
> (Updated Feb. 27, 2017, 7:10 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20212
> https://issues.apache.org/jira/browse/AMBARI-20212
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove HDP version check in KAFKA service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  015e150 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  bc2e7a7 
> 
> Diff: https://reviews.apache.org/r/57096/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57096: Remove HDP version check in KAFKA service

[Madhuvanthi Radhakrishnan]

> On Feb. 27, 2017, 6:41 p.m., Alejandro Fernandez wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json,
> >  line 25
> > 
> >
> > This is also needed in HDP 3.0

I have added this change in 
ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.json 
and attached a trunk patch to the apache jira.


- Madhuvanthi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57096/#review166905
---


On Feb. 27, 2017, 6:34 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57096/
> ---
> 
> (Updated Feb. 27, 2017, 6:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20212
> https://issues.apache.org/jira/browse/AMBARI-20212
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove HDP version check in KAFKA service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  015e150 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  bc2e7a7 
> 
> Diff: https://reviews.apache.org/r/57096/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57098: Strange UI behavior on editing property

[Denys Buzhor]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57098/#review166911
---


Ship it!




Ship It!

- Denys Buzhor


On Feb. 27, 2017, 6:52 p.m., Aleksandr Kovalenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57098/
> ---
> 
> (Updated Feb. 27, 2017, 6:52 p.m.)
> 
> 
> Review request for Ambari and Denys Buzhor.
> 
> 
> Bugs: AMBARI-20214
> https://issues.apache.org/jira/browse/AMBARI-20214
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> When editing YARN Capacity Scheduler property and on UI shows "There is 1 
> configuration change in 1 service" page starts to scroll down infinitely, 
> which makes impossibly to use page comfortable.
> Browser: Win64 Chrome Version 58.0.3018.3 (Official Build)
> 
> 
> Diffs
> -
> 
>   ambari-web/app/styles/config_history_flow.less e3fe0e7 
>   ambari-web/app/views/main/service/info/configs.js cd64a8b 
> 
> Diff: https://reviews.apache.org/r/57098/diff/
> 
> 
> Testing
> ---
> 
> 20520 passing (27s)
>   153 pending
> 
> 
> Thanks,
> 
> Aleksandr Kovalenko
> 
>

Re: Review Request 57080: Ambari should install the unlimited key JCE policy based on service requirements even if cluster is not Kerberized

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57080/
---

(Updated Feb. 27, 2017, 1:56 p.m.)


Review request for Ambari, Alejandro Fernandez, Attila Magyar, Andrew Onischuk, 
Balázs Bence Sári, Eugene Chekanskiy, Laszlo Puskas, and Sebastian Toader.


Bugs: AMBARI-20196
https://issues.apache.org/jira/browse/AMBARI-20196


Repository: ambari


Description
---

Ambari should install the unlimited key JCE policy based on service 
requirements even if cluster is not Kerberized. For example, if a service needs 
the unlimited key JCE policy for an encryption task not related to Kerberos.

On a similar note, the unlimited key JCE policy is not being distributed to the 
agents if Kerberos is enabled using the "manual" option - as opposed to 
integrating with an existing KDC.

On a related note, Ambari Server host automatically unpacks JCE unlimited 
during "ambari-server setup" (unless custom JDK is used).


Diffs (updated)
-

  ambari-agent/pom.xml 074e051 
  ambari-agent/src/main/java/org/apache/ambari/tools/jce/JcePolicyInfo.java 
PRE-CREATION 
  
ambari-common/src/main/python/resource_management/core/resources/jcepolicyinfo.py
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 c80ebe6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 7cb7fce 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java 
51d9847 
  ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
409bcae 
  
ambari-server/src/main/java/org/apache/ambari/server/state/UnlimitedKeyJCERequirement.java
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py
 ddc8063 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
 5db62c5 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
3f74aa7 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py
 f21e4b1 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 29c88b4 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
 9783aa4 
  ambari-server/src/main/resources/stacks/HDP/3.0/configuration/cluster-env.xml 
3af8f08 
  
ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/hook.py
 f21e4b1 
  
ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/params.py
 455710b 
  
ambari-server/src/main/resources/stacks/HDP/3.0/hooks/before-START/scripts/shared_initialization.py
 5dce8e0 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_client.py
 2ab700d 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
 6e37ded 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json 
fa4cc9d 
  
ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py
 30561ac 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
444fae6 

Diff: https://reviews.apache.org/r/57080/diff/


Testing
---

Manually tested with various versions of Java - Oracle 1.7. Oracle 1.8, and 
OpenJDK 1.8.

# Local test results:
```
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 28:49.548s
[INFO] Finished at: Mon Feb 27 12:50:22 EST 2017
[INFO] Final Memory: 70M/613M
[INFO] 
```

# Jenkins test results:
```
{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment
  
http://issues.apache.org/jira/secure/attachment/12854862/AMBARI-20196_trunk_01.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
ambari-agent ambari-server.

Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/10767//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/10767//console
```


Thanks,

Robert Levas

Review Request 57098: Strange UI behavior on editing property

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57098/
---

Review request for Ambari and Denys Buzhor.


Bugs: AMBARI-20214
https://issues.apache.org/jira/browse/AMBARI-20214


Repository: ambari


Description
---

When editing YARN Capacity Scheduler property and on UI shows "There is 1 
configuration change in 1 service" page starts to scroll down infinitely, which 
makes impossibly to use page comfortable.
Browser: Win64 Chrome Version 58.0.3018.3 (Official Build)


Diffs
-

  ambari-web/app/styles/config_history_flow.less e3fe0e7 
  ambari-web/app/views/main/service/info/configs.js cd64a8b 

Diff: https://reviews.apache.org/r/57098/diff/


Testing
---

20520 passing (27s)
  153 pending


Thanks,

Aleksandr Kovalenko

Re: Review Request 57089: HDP 3.0 support for Slider with configs, kerberos, widgets, metrics, quicklinks, and themes

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57089/#review166906
---




ambari-server/src/main/resources/stacks/HDP/3.0/services/SLIDER/metainfo.xml 
(line 24)


This should be a brand new version of Slider.
It needs to contain a flattening of the configs from all of the older 
stacks, kerberos.json, widgets.json, etc.


- Alejandro Fernandez


On Feb. 27, 2017, 1:24 p.m., Dmytro Sen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57089/
> ---
> 
> (Updated Feb. 27, 2017, 1:24 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Sid Wagle, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-19835
> https://issues.apache.org/jira/browse/AMBARI-19835
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDP 3.0 support for Slider with configs, kerberos, widgets, metrics, 
> quicklinks, and themes
> Flatten from HDP 2.0.6 - 2.6 into common-services, and reference in HDP 3.0
> In HDP 3.0, we have created a new stack definition that does not inherit from 
> other stacks, in order to reduce the complexity of having to analyze older 
> stacks.
> This means that we need to create a service definition (metainfo.xml, 
> configs, kerberos, widgets, metrics, quicklinks, and themes) that is 
> equivalent to what is inherit and deleted from all of the previous stacks.
> A merge needs to account for additions, overrides, and deletions.
> metainfo.xml and configs perform a merge of older versions
> kerberos.json always seems to override the previous file
> Because the bits for this service may not yet be available in the HDP 3.0 
> repo, 
> the task is to ensure that /api/v1/stacks/HDP/versions/2.6/services/SLIDER 
> (which uses inheritance) is equivalent to the flattening of 
> /api/v1/stacks/HDP/versions/3.0/services/SLIDER .
> Please take a look at how this was done for ZK, HDFS, and YARN/MR.
> This means that you will not be able to actually install the service for now, 
> but can still perform validation during the Install Wizard that the correct 
> components and configs show up.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/SLIDER/metainfo.xml 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/57089/diff/
> 
> 
> Testing
> ---
> 
> Unit tests passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Re: Review Request 57080: Ambari should install the unlimited key JCE policy based on service requirements even if cluster is not Kerberized

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57080/
---

(Updated Feb. 27, 2017, 1:42 p.m.)


Review request for Ambari, Alejandro Fernandez, Attila Magyar, Andrew Onischuk, 
Balázs Bence Sári, Eugene Chekanskiy, Laszlo Puskas, and Sebastian Toader.


Bugs: AMBARI-20196
https://issues.apache.org/jira/browse/AMBARI-20196


Repository: ambari


Description
---

Ambari should install the unlimited key JCE policy based on service 
requirements even if cluster is not Kerberized. For example, if a service needs 
the unlimited key JCE policy for an encryption task not related to Kerberos.

On a similar note, the unlimited key JCE policy is not being distributed to the 
agents if Kerberos is enabled using the "manual" option - as opposed to 
integrating with an existing KDC.

On a related note, Ambari Server host automatically unpacks JCE unlimited 
during "ambari-server setup" (unless custom JDK is used).


Diffs (updated)
-

  ambari-agent/pom.xml 074e051 
  ambari-agent/src/main/java/org/apache/ambari/tools/jce/JcePolicyInfo.java 
PRE-CREATION 
  
ambari-common/src/main/python/resource_management/core/resources/jcepolicyinfo.py
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 c80ebe6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 7cb7fce 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java 
51d9847 
  ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
409bcae 
  
ambari-server/src/main/java/org/apache/ambari/server/state/UnlimitedKeyJCERequirement.java
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py
 ddc8063 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
 5db62c5 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
3f74aa7 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py
 f21e4b1 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 29c88b4 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
 9783aa4 
  ambari-server/src/main/resources/stacks/HDP/3.0/configuration/cluster-env.xml 
3af8f08 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_client.py
 2ab700d 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
 6e37ded 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json 
fa4cc9d 
  
ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py
 30561ac 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
444fae6 

Diff: https://reviews.apache.org/r/57080/diff/


Testing
---

Manually tested with various versions of Java - Oracle 1.7. Oracle 1.8, and 
OpenJDK 1.8.

# Local test results:
```
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 28:49.548s
[INFO] Finished at: Mon Feb 27 12:50:22 EST 2017
[INFO] Final Memory: 70M/613M
[INFO] 
```

# Jenkins test results:
```
{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment
  
http://issues.apache.org/jira/secure/attachment/12854862/AMBARI-20196_trunk_01.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
ambari-agent ambari-server.

Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/10767//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/10767//console
```


Thanks,

Robert Levas

Re: Review Request 57096: Remove HDP version check in KAFKA service

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57096/#review166905
---




ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 (line 25)


This is also needed in HDP 3.0


- Alejandro Fernandez


On Feb. 27, 2017, 6:34 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57096/
> ---
> 
> (Updated Feb. 27, 2017, 6:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20212
> https://issues.apache.org/jira/browse/AMBARI-20212
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove HDP version check in KAFKA service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  015e150 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  bc2e7a7 
> 
> Diff: https://reviews.apache.org/r/57096/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Re: Review Request 57087: HDFS service check fails after Stopping one Namenode in HA cluste

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57087/#review166902
---




ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py
 


Please make the same change in HDFS 3.0.0.3.0


- Alejandro Fernandez


On Feb. 27, 2017, 4:19 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57087/
> ---
> 
> (Updated Feb. 27, 2017, 4:19 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20032
> https://issues.apache.org/jira/browse/AMBARI-20032
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDFS service check fails after Stopping one Namenode in HA cluster.
> Stop the active Namenode and run HDFS service check, it fails.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py
>  dffa077 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 
> bbc1b3a 
> 
> Diff: https://reviews.apache.org/r/57087/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 57096: Remove HDP version check in KAFKA service

[Sumit Mohanty]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57096/#review166904
---




ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
 (line 25)


Can we remove the import too?


- Sumit Mohanty


On Feb. 27, 2017, 6:34 p.m., Madhuvanthi Radhakrishnan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57096/
> ---
> 
> (Updated Feb. 27, 2017, 6:34 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez and Jayush Luniya.
> 
> 
> Bugs: AMBARI-20212
> https://issues.apache.org/jira/browse/AMBARI-20212
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Remove HDP version check in KAFKA service
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
>  015e150 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
>  bc2e7a7 
> 
> Diff: https://reviews.apache.org/r/57096/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Madhuvanthi Radhakrishnan
> 
>

Review Request 57096: Remove HDP version check in KAFKA service

[Madhuvanthi Radhakrishnan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57096/
---

Review request for Ambari, Alejandro Fernandez and Jayush Luniya.


Bugs: AMBARI-20212
https://issues.apache.org/jira/browse/AMBARI-20212


Repository: ambari


Description
---

Remove HDP version check in KAFKA service


Diffs
-

  
ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/kafka_broker.py
 015e150 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json
 bc2e7a7 

Diff: https://reviews.apache.org/r/57096/diff/


Testing
---


Thanks,

Madhuvanthi Radhakrishnan

Re: Review Request 57092: [BE] "refresh yarn queue" takes 20 minutes to fail, instead it should fail after a fixed numbers of the attempts within 2 minutes

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57092/#review166903
---




ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
 (line 107)


The same change is needed in YARN 3.0.0.3.0


- Alejandro Fernandez


On Feb. 27, 2017, 2:07 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57092/
> ---
> 
> (Updated Feb. 27, 2017, 2:07 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-20210
> https://issues.apache.org/jira/browse/AMBARI-20210
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While yarn service is stopped, "refresh queue" call will trigger command to
> post refresh call for the yarn with infinite amount of retry amount, which
> blocks us queue processing.
> 
> We should allow to kill this command after certain amount of time, to
> implement fast fail feature.
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/resource_management/core/signal_utils.py 
> 1f0dfe7 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
>  03b66a5 
> 
> Diff: https://reviews.apache.org/r/57092/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 57080: Ambari should install the unlimited key JCE policy based on service requirements even if cluster is not Kerberized

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57080/#review166901
---




ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
(line 129)


This config is also needed in HDP 3.0


- Alejandro Fernandez


On Feb. 27, 2017, 5:54 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57080/
> ---
> 
> (Updated Feb. 27, 2017, 5:54 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Attila Magyar, Andrew 
> Onischuk, Balázs Bence Sári, Eugene Chekanskiy, Laszlo Puskas, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-20196
> https://issues.apache.org/jira/browse/AMBARI-20196
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari should install the unlimited key JCE policy based on service 
> requirements even if cluster is not Kerberized. For example, if a service 
> needs the unlimited key JCE policy for an encryption task not related to 
> Kerberos.
> 
> On a similar note, the unlimited key JCE policy is not being distributed to 
> the agents if Kerberos is enabled using the "manual" option - as opposed to 
> integrating with an existing KDC.
> 
> On a related note, Ambari Server host automatically unpacks JCE unlimited 
> during "ambari-server setup" (unless custom JDK is used).
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml 074e051 
>   ambari-agent/src/main/java/org/apache/ambari/tools/jce/JcePolicyInfo.java 
> PRE-CREATION 
>   
> ambari-common/src/main/python/resource_management/core/resources/jcepolicyinfo.py
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  c80ebe6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  7cb7fce 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
>  51d9847 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> 409bcae 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UnlimitedKeyJCERequirement.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py
>  ddc8063 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
>  5db62c5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml
>  3f74aa7 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py
>  f21e4b1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  29c88b4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  9783aa4 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_client.py
>  2ab700d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
>  6e37ded 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json 
> fa4cc9d 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py
>  30561ac 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
> 444fae6 
> 
> Diff: https://reviews.apache.org/r/57080/diff/
> 
> 
> Testing
> ---
> 
> Manually tested with various versions of Java - Oracle 1.7. Oracle 1.8, and 
> OpenJDK 1.8.
> 
> # Local test results:
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 28:49.548s
> [INFO] Finished at: Mon Feb 27 12:50:22 EST 2017
> [INFO] Final Memory: 70M/613M
> [INFO] 
> 
> ```
> 
> # Jenkins test results:
> ```
> {color:green}+1 overall{color}.  Here are the results of testing the latest 
> attachment
>   
> http://issues.apache.org/jira/secure/attachment/12854862/AMBARI-20196_trunk_01.patch
>   against trunk revision .
> 
> {color:green}+1 @author{color}.  The patch does not contain any @author 
> tags.
> 
> {color:green}+1 tests included{color}.  The patch appears to include 4 
> new or modified test files.
> 
> {color:green}+1 javac{color}.  The applied patch does not increase the 
> total number of javac compiler warnings.
> 
> {color:green}+1 release audit{color}.  The applied patch does not 
> increase the total number of release audit warnings.
> 
> {color:green}+1 core tests{color}.  The patch passed unit 

Re: Review Request 57080: Ambari should install the unlimited key JCE policy based on service requirements even if cluster is not Kerberized

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57080/
---

(Updated Feb. 27, 2017, 12:54 p.m.)


Review request for Ambari, Alejandro Fernandez, Attila Magyar, Andrew Onischuk, 
Balázs Bence Sári, Eugene Chekanskiy, Laszlo Puskas, and Sebastian Toader.


Bugs: AMBARI-20196
https://issues.apache.org/jira/browse/AMBARI-20196


Repository: ambari


Description
---

Ambari should install the unlimited key JCE policy based on service 
requirements even if cluster is not Kerberized. For example, if a service needs 
the unlimited key JCE policy for an encryption task not related to Kerberos.

On a similar note, the unlimited key JCE policy is not being distributed to the 
agents if Kerberos is enabled using the "manual" option - as opposed to 
integrating with an existing KDC.

On a related note, Ambari Server host automatically unpacks JCE unlimited 
during "ambari-server setup" (unless custom JDK is used).


Diffs
-

  ambari-agent/pom.xml 074e051 
  ambari-agent/src/main/java/org/apache/ambari/tools/jce/JcePolicyInfo.java 
PRE-CREATION 
  
ambari-common/src/main/python/resource_management/core/resources/jcepolicyinfo.py
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 c80ebe6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 7cb7fce 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java 
51d9847 
  ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
409bcae 
  
ambari-server/src/main/java/org/apache/ambari/server/state/UnlimitedKeyJCERequirement.java
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py
 ddc8063 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
 5db62c5 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
3f74aa7 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py
 f21e4b1 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 29c88b4 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
 9783aa4 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_client.py
 2ab700d 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
 6e37ded 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json 
fa4cc9d 
  
ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py
 30561ac 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
444fae6 

Diff: https://reviews.apache.org/r/57080/diff/


Testing (updated)
---

Manually tested with various versions of Java - Oracle 1.7. Oracle 1.8, and 
OpenJDK 1.8.

# Local test results:
```
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 28:49.548s
[INFO] Finished at: Mon Feb 27 12:50:22 EST 2017
[INFO] Final Memory: 70M/613M
[INFO] 
```

# Jenkins test results:
```
{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment
  
http://issues.apache.org/jira/secure/attachment/12854862/AMBARI-20196_trunk_01.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
ambari-agent ambari-server.

Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/10767//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/10767//console
```


Thanks,

Robert Levas

Re: Review Request 57080: Ambari should install the unlimited key JCE policy based on service requirements even if cluster is not Kerberized

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57080/
---

(Updated Feb. 27, 2017, 12:21 p.m.)


Review request for Ambari, Alejandro Fernandez, Attila Magyar, Andrew Onischuk, 
Balázs Bence Sári, Eugene Chekanskiy, Laszlo Puskas, and Sebastian Toader.


Bugs: AMBARI-20196
https://issues.apache.org/jira/browse/AMBARI-20196


Repository: ambari


Description
---

Ambari should install the unlimited key JCE policy based on service 
requirements even if cluster is not Kerberized. For example, if a service needs 
the unlimited key JCE policy for an encryption task not related to Kerberos.

On a similar note, the unlimited key JCE policy is not being distributed to the 
agents if Kerberos is enabled using the "manual" option - as opposed to 
integrating with an existing KDC.

On a related note, Ambari Server host automatically unpacks JCE unlimited 
during "ambari-server setup" (unless custom JDK is used).


Diffs (updated)
-

  ambari-agent/pom.xml 074e051 
  ambari-agent/src/main/java/org/apache/ambari/tools/jce/JcePolicyInfo.java 
PRE-CREATION 
  
ambari-common/src/main/python/resource_management/core/resources/jcepolicyinfo.py
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 c80ebe6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 7cb7fce 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java 
51d9847 
  ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
409bcae 
  
ambari-server/src/main/java/org/apache/ambari/server/state/UnlimitedKeyJCERequirement.java
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py
 ddc8063 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
 5db62c5 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/configuration/cluster-env.xml 
3f74aa7 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py
 f21e4b1 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 29c88b4 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
 9783aa4 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_client.py
 2ab700d 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
 6e37ded 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json 
fa4cc9d 
  
ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py
 30561ac 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
444fae6 

Diff: https://reviews.apache.org/r/57080/diff/


Testing
---

Manually tested with various versions of Java - Oracle 1.7. Oracle 1.8, and 
OpenJDK 1.8.

# Local test results:
```
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 24:35.838s
[INFO] Finished at: Mon Feb 27 05:33:33 EST 2017
[INFO] Final Memory: 93M/596M
[INFO] 
```

# Jenkins test results:
```
{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment
  
http://issues.apache.org/jira/secure/attachment/12854862/AMBARI-20196_trunk_01.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
ambari-agent ambari-server.

Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/10767//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/10767//console
```


Thanks,

Robert Levas

Re: Review Request 57087: HDFS service check fails after Stopping one Namenode in HA cluste

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57087/#review166891
---


Ship it!




Ship It!

- Robert Levas


On Feb. 27, 2017, 11:19 a.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57087/
> ---
> 
> (Updated Feb. 27, 2017, 11:19 a.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20032
> https://issues.apache.org/jira/browse/AMBARI-20032
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDFS service check fails after Stopping one Namenode in HA cluster.
> Stop the active Namenode and run HDFS service check, it fails.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py
>  dffa077 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 
> bbc1b3a 
> 
> Diff: https://reviews.apache.org/r/57087/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 57087: HDFS service check fails after Stopping one Namenode in HA cluste

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57087/#review166888
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Feb. 27, 2017, 6:19 p.m., Eugene Chekanskiy wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57087/
> ---
> 
> (Updated Feb. 27, 2017, 6:19 p.m.)
> 
> 
> Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
> Brodetskyi.
> 
> 
> Bugs: AMBARI-20032
> https://issues.apache.org/jira/browse/AMBARI-20032
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDFS service check fails after Stopping one Namenode in HA cluster.
> Stop the active Namenode and run HDFS service check, it fails.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py
>  dffa077 
>   ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py 
> bbc1b3a 
> 
> Diff: https://reviews.apache.org/r/57087/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Eugene Chekanskiy
> 
>

Re: Review Request 57087: HDFS service check fails after Stopping one Namenode in HA cluste

[Eugene Chekanskiy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57087/
---

(Updated Feb. 27, 2017, 4:19 p.m.)


Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-20032
https://issues.apache.org/jira/browse/AMBARI-20032


Repository: ambari


Description
---

HDFS service check fails after Stopping one Namenode in HA cluster.
Stop the active Namenode and run HDFS service check, it fails.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py
 dffa077 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py bbc1b3a 

Diff: https://reviews.apache.org/r/57087/diff/


Testing
---

mvn clean test


Thanks,

Eugene Chekanskiy

Re: Review Request 57060: HostCleaup.py throws exception and exits when hostcheck_custom_actions.result not present

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57060/#review166885
---




ambari-agent/src/main/python/ambari_agent/HostCleanup.py (line 687)


The script should fail instead of continuing on by skipping the majority of 
the function and still report "Clean-up completed".

hostcheck result custom action file is required as it's corresponding to 
the check host operation submitted by the Ambari web UI during Host 
registration step.

Current behavior is a hard fail, but I think it's still the correct 
behavior nontheless.


- Di Li


On Feb. 25, 2017, 3 a.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57060/
> ---
> 
> (Updated Feb. 25, 2017, 3 a.m.)
> 
> 
> Review request for Ambari, Di Li and Jonathan Hurley.
> 
> 
> Bugs: AMBARI-20192
> https://issues.apache.org/jira/browse/AMBARI-20192
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HostCleanup script throws following exception and exits when 
> hostcheck_custom_actions.result not present
> [root@tsar1 ~]# /usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py
> You have elected to remove all users as well. If it is not intended then use 
> option --skip "users". Do you want to continue [y/n] (y)y
> Host Check results not found. There is no 
> /var/lib/ambari-agent/data/hostcheck_custom_actions.result. Do you want to 
> run host checks [y/n] (y)n
> Traceback (most recent call last):
> File "/usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py", line 
> 705, in 
> main()
> File "/usr/lib/python2.6/site-packages/ambari_agent/HostCleanup.py", line 
> 689, in main
> with open(hostcheckfileca, "rb") as f2:
> IOError: [Errno 2] No such file or directory: 
> '/var/lib/ambari-agent/data/hostcheck_custom_actions.result'
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/main/python/ambari_agent/HostCleanup.py 7ee3b1c 
> 
> Diff: https://reviews.apache.org/r/57060/diff/
> 
> 
> Testing
> ---
> 
> Manually tested. Cleanup completed successfully when no 
> hostcheck_custom_actions.result file was present
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error

[Balázs Bence Sári]

> On Feb. 27, 2017, 2:39 p.m., Balázs Bence Sári wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java,
> >  line 232
> > 
> >
> > What does the comment mean?
> 
> Attila Magyar wrote:
> We don't cache keytab files that belong to servie principals. The error 
> should be added only if the principal is a non service principal (cache 
> should have been existed) but there is no cached keytab file

Now that the condition has been inverted it is in line with the comment.


- Balázs Bence


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56980/#review166868
---


On Feb. 27, 2017, 2:58 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56980/
> ---
> 
> (Updated Feb. 27, 2017, 2:58 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20140
> https://issues.apache.org/jira/browse/AMBARI-20140
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Spark2 and Spark1 shares the same principal name. This casuses a problem when 
> adding Spark2 to a kerberized cluster with Spark1. Ambari doesn't publish the 
> keytab to Spark2 because it thinks it already exists.
> 
> I extended the existing conditional to take the existence of the destination 
> keytab file into consideration.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
>  b968383 
> 
> Diff: https://reviews.apache.org/r/56980/diff/
> 
> 
> Testing
> ---
> 
> - Created a cluster with Spark
> - Enabled Kerberos
> - Added Spark2
> - Checked if Spark2 started successfully and the exitence of 
> /etc/security/keytabs/spark2.headless.keytab
> 
> 
> Existing tests ran without failure.
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error

[Attila Magyar]

> On Feb. 27, 2017, 2:39 p.m., Balázs Bence Sári wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java,
> >  line 232
> > 
> >
> > What does the comment mean?

We don't cache keytab files that belong to servie principals. The error should 
be added only if the principal is a non service principal (cache should have 
been existed) but there is no cached keytab file


- Attila


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56980/#review166868
---


On Feb. 27, 2017, 2:58 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56980/
> ---
> 
> (Updated Feb. 27, 2017, 2:58 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20140
> https://issues.apache.org/jira/browse/AMBARI-20140
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Spark2 and Spark1 shares the same principal name. This casuses a problem when 
> adding Spark2 to a kerberized cluster with Spark1. Ambari doesn't publish the 
> keytab to Spark2 because it thinks it already exists.
> 
> I extended the existing conditional to take the existence of the destination 
> keytab file into consideration.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
>  b968383 
> 
> Diff: https://reviews.apache.org/r/56980/diff/
> 
> 
> Testing
> ---
> 
> - Created a cluster with Spark
> - Enabled Kerberos
> - Added Spark2
> - Checked if Spark2 started successfully and the exitence of 
> /etc/security/keytabs/spark2.headless.keytab
> 
> 
> Existing tests ran without failure.
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56980/
---

(Updated Feb. 27, 2017, 2:58 p.m.)


Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, 
and Sebastian Toader.


Changes
---

inverted conditional


Bugs: AMBARI-20140
https://issues.apache.org/jira/browse/AMBARI-20140


Repository: ambari


Description
---

Spark2 and Spark1 shares the same principal name. This casuses a problem when 
adding Spark2 to a kerberized cluster with Spark1. Ambari doesn't publish the 
keytab to Spark2 because it thinks it already exists.

I extended the existing conditional to take the existence of the destination 
keytab file into consideration.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
 b968383 

Diff: https://reviews.apache.org/r/56980/diff/


Testing
---

- Created a cluster with Spark
- Enabled Kerberos
- Added Spark2
- Checked if Spark2 started successfully and the exitence of 
/etc/security/keytabs/spark2.headless.keytab


Existing tests ran without failure.


Thanks,

Attila Magyar

Re: Review Request 57095: UI asking user to "refresh yarn queue" on stopped yarn service, which results to infinite refresh time as yarn is stopped

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57095/#review166875
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Фев. 27, 2017, 2:57 п.п., Andriy Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57095/
> ---
> 
> (Updated Фев. 27, 2017, 2:57 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-20211
> https://issues.apache.org/jira/browse/AMBARI-20211
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> - Deploy cluster
> - Stop all services
> - edit yarn capacity scheduler
> - follow next instructions
> 
> Result:
> Modal popup with recommendation to refresh YARN queue is displayed even if 
> ResourceManager is not runing so that this command can't be executed.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
> f52d1af 
>   
> ambari-web/test/mixins/main/service/configs/component_actions_by_configs_test.js
>  1a93a26 
> 
> Diff: https://reviews.apache.org/r/57095/diff/
> 
> 
> Testing
> ---
> 
> 20520 passing (19s)
>   153 pending
> 
> 
> Thanks,
> 
> Andriy Babiichuk
> 
>

Review Request 57095: UI asking user to "refresh yarn queue" on stopped yarn service, which results to infinite refresh time as yarn is stopped

[Andriy Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57095/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-20211
https://issues.apache.org/jira/browse/AMBARI-20211


Repository: ambari


Description
---

STR:
- Deploy cluster
- Stop all services
- edit yarn capacity scheduler
- follow next instructions

Result:
Modal popup with recommendation to refresh YARN queue is displayed even if 
ResourceManager is not runing so that this command can't be executed.


Diffs
-

  ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js 
f52d1af 
  
ambari-web/test/mixins/main/service/configs/component_actions_by_configs_test.js
 1a93a26 

Diff: https://reviews.apache.org/r/57095/diff/


Testing
---

20520 passing (19s)
  153 pending


Thanks,

Andriy Babiichuk

Re: Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error

[Balázs Bence Sári]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56980/#review166868
---




ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
 (line 232)


What does the comment mean?


- Balázs Bence Sári


On Feb. 27, 2017, 2:14 p.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56980/
> ---
> 
> (Updated Feb. 27, 2017, 2:14 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20140
> https://issues.apache.org/jira/browse/AMBARI-20140
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Spark2 and Spark1 shares the same principal name. This casuses a problem when 
> adding Spark2 to a kerberized cluster with Spark1. Ambari doesn't publish the 
> keytab to Spark2 because it thinks it already exists.
> 
> I extended the existing conditional to take the existence of the destination 
> keytab file into consideration.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
>  5d6ccc0 
> 
> Diff: https://reviews.apache.org/r/56980/diff/
> 
> 
> Testing
> ---
> 
> - Created a cluster with Spark
> - Enabled Kerberos
> - Added Spark2
> - Checked if Spark2 started successfully and the exitence of 
> /etc/security/keytabs/spark2.headless.keytab
> 
> 
> Existing tests ran without failure.
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 57080: Ambari should install the unlimited key JCE policy based on service requirements even if cluster is not Kerberized

[Robert Levas]

> On Feb. 27, 2017, 5:45 a.m., Sebastian Toader wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java,
> >  line 2445
> > 
> >
> > There is a typo in the comment

I dont see the typo.  The comment may seem redundant though.  It's states that 
if a coponent requires the unlimited key JCE policy when Keberos is enabled, 
than the unlimited key JCE policy is to be requred when Kerberos is enabled... 
otherwize is is not required.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57080/#review166846
---


On Feb. 27, 2017, 7:01 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57080/
> ---
> 
> (Updated Feb. 27, 2017, 7:01 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Attila Magyar, Andrew 
> Onischuk, Balázs Bence Sári, Eugene Chekanskiy, Laszlo Puskas, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-20196
> https://issues.apache.org/jira/browse/AMBARI-20196
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari should install the unlimited key JCE policy based on service 
> requirements even if cluster is not Kerberized. For example, if a service 
> needs the unlimited key JCE policy for an encryption task not related to 
> Kerberos.
> 
> On a similar note, the unlimited key JCE policy is not being distributed to 
> the agents if Kerberos is enabled using the "manual" option - as opposed to 
> integrating with an existing KDC.
> 
> On a related note, Ambari Server host automatically unpacks JCE unlimited 
> during "ambari-server setup" (unless custom JDK is used).
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml 074e051 
>   ambari-agent/src/main/java/org/apache/ambari/tools/jce/JcePolicyInfo.java 
> PRE-CREATION 
>   
> ambari-common/src/main/python/resource_management/core/resources/jcepolicyinfo.py
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  c80ebe6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  7cb7fce 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
>  51d9847 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> 409bcae 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UnlimitedKeyJCERequirement.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py
>  ddc8063 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
>  5db62c5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py
>  f21e4b1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  29c88b4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  9783aa4 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_client.py
>  2ab700d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
>  6e37ded 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json 
> fa4cc9d 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py
>  30561ac 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
> 444fae6 
> 
> Diff: https://reviews.apache.org/r/57080/diff/
> 
> 
> Testing
> ---
> 
> Manually tested with various versions of Java - Oracle 1.7. Oracle 1.8, and 
> OpenJDK 1.8.
> 
> # Local test results:
> ```
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> [INFO] Total time: 24:35.838s
> [INFO] Finished at: Mon Feb 27 05:33:33 EST 2017
> [INFO] Final Memory: 93M/596M
> [INFO] 
> 
> ```
> 
> # Jenkins test results:
> ```
> {color:green}+1 overall{color}.  Here are the results of testing the latest 
> attachment
>   
> http://issues.apache.org/jira/secure/attachment/12854862/AMBARI-20196_trunk_01.patch
>   against trunk revision .
> 
> {color:green}+1 @author{color}.  The patch does not contain any @author 
> tags.
> 
> {color:green}+1 tests included{color}.  The patch appears to include 4 
> new or modified test files.
> 
> {color:green}+1 javac{color}.  The applied 

Re: Review Request 56980: Adding spark2 to a kerberized cluster with spark1 fails with keytab file does not exist error

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56980/
---

(Updated Feb. 27, 2017, 2:14 p.m.)


Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Robert Levas, 
and Sebastian Toader.


Changes
---

service principals are not cached, ignore if cachedKeytabPath is null


Bugs: AMBARI-20140
https://issues.apache.org/jira/browse/AMBARI-20140


Repository: ambari


Description
---

Spark2 and Spark1 shares the same principal name. This casuses a problem when 
adding Spark2 to a kerberized cluster with Spark1. Ambari doesn't publish the 
keytab to Spark2 because it thinks it already exists.

I extended the existing conditional to take the existence of the destination 
keytab file into consideration.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreateKeytabFilesServerAction.java
 5d6ccc0 

Diff: https://reviews.apache.org/r/56980/diff/


Testing
---

- Created a cluster with Spark
- Enabled Kerberos
- Added Spark2
- Checked if Spark2 started successfully and the exitence of 
/etc/security/keytabs/spark2.headless.keytab


Existing tests ran without failure.


Thanks,

Attila Magyar

Re: Review Request 57092: [BE] "refresh yarn queue" takes 20 minutes to fail, instead it should fail after a fixed numbers of the attempts within 2 minutes

[Andrew Onischuk]

> On Feb. 27, 2017, 2:09 p.m., Dmitro Lisnichenko wrote:
> > ambari-common/src/main/python/resource_management/core/signal_utils.py, 
> > line 26
> > 
> >
> > looks like unused import

it is used on line 68 of the file.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57092/#review166864
---


On Feb. 27, 2017, 2:07 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57092/
> ---
> 
> (Updated Feb. 27, 2017, 2:07 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-20210
> https://issues.apache.org/jira/browse/AMBARI-20210
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While yarn service is stopped, "refresh queue" call will trigger command to
> post refresh call for the yarn with infinite amount of retry amount, which
> blocks us queue processing.
> 
> We should allow to kill this command after certain amount of time, to
> implement fast fail feature.
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/resource_management/core/signal_utils.py 
> 1f0dfe7 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
>  03b66a5 
> 
> Diff: https://reviews.apache.org/r/57092/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 57092: [BE] "refresh yarn queue" takes 20 minutes to fail, instead it should fail after a fixed numbers of the attempts within 2 minutes

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57092/#review166864
---


Fix it, then Ship it!





ambari-common/src/main/python/resource_management/core/signal_utils.py (line 26)


looks like unused import


- Dmitro Lisnichenko


On Feb. 27, 2017, 4:07 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57092/
> ---
> 
> (Updated Feb. 27, 2017, 4:07 p.m.)
> 
> 
> Review request for Ambari and Dmitro Lisnichenko.
> 
> 
> Bugs: AMBARI-20210
> https://issues.apache.org/jira/browse/AMBARI-20210
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> While yarn service is stopped, "refresh queue" call will trigger command to
> post refresh call for the yarn with infinite amount of retry amount, which
> blocks us queue processing.
> 
> We should allow to kill this command after certain amount of time, to
> implement fast fail feature.
> 
> 
> Diffs
> -
> 
>   ambari-common/src/main/python/resource_management/core/signal_utils.py 
> 1f0dfe7 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
>  03b66a5 
> 
> Diff: https://reviews.apache.org/r/57092/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 57092: [BE] "refresh yarn queue" takes 20 minutes to fail, instead it should fail after a fixed numbers of the attempts within 2 minutes

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57092/
---

Review request for Ambari and Dmitro Lisnichenko.


Bugs: AMBARI-20210
https://issues.apache.org/jira/browse/AMBARI-20210


Repository: ambari


Description
---

While yarn service is stopped, "refresh queue" call will trigger command to
post refresh call for the yarn with infinite amount of retry amount, which
blocks us queue processing.

We should allow to kill this command after certain amount of time, to
implement fast fail feature.


Diffs
-

  ambari-common/src/main/python/resource_management/core/signal_utils.py 
1f0dfe7 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service.py
 03b66a5 

Diff: https://reviews.apache.org/r/57092/diff/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 57089: HDP 3.0 support for Slider with configs, kerberos, widgets, metrics, quicklinks, and themes

[Dmytro Sen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57089/
---

Review request for Ambari, Alejandro Fernandez, Sid Wagle, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-19835
https://issues.apache.org/jira/browse/AMBARI-19835


Repository: ambari


Description
---

HDP 3.0 support for Slider with configs, kerberos, widgets, metrics, 
quicklinks, and themes
Flatten from HDP 2.0.6 - 2.6 into common-services, and reference in HDP 3.0
In HDP 3.0, we have created a new stack definition that does not inherit from 
other stacks, in order to reduce the complexity of having to analyze older 
stacks.
This means that we need to create a service definition (metainfo.xml, configs, 
kerberos, widgets, metrics, quicklinks, and themes) that is equivalent to what 
is inherit and deleted from all of the previous stacks.
A merge needs to account for additions, overrides, and deletions.
metainfo.xml and configs perform a merge of older versions
kerberos.json always seems to override the previous file
Because the bits for this service may not yet be available in the HDP 3.0 repo, 
the task is to ensure that /api/v1/stacks/HDP/versions/2.6/services/SLIDER 
(which uses inheritance) is equivalent to the flattening of 
/api/v1/stacks/HDP/versions/3.0/services/SLIDER .
Please take a look at how this was done for ZK, HDFS, and YARN/MR.
This means that you will not be able to actually install the service for now, 
but can still perform validation during the Install Wizard that the correct 
components and configs show up.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/3.0/services/SLIDER/metainfo.xml 
PRE-CREATION 

Diff: https://reviews.apache.org/r/57089/diff/


Testing
---

Unit tests passed


Thanks,

Dmytro Sen

Review Request 57087: HDFS service check fails after Stopping one Namenode in HA cluste

[Eugene Chekanskiy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57087/
---

Review request for Ambari, Dmitro Lisnichenko, Robert Levas, and Vitalyi 
Brodetskyi.


Bugs: AMBARI-20032
https://issues.apache.org/jira/browse/AMBARI-20032


Repository: ambari


Description
---

HDFS service check fails after Stopping one Namenode in HA cluster.
Stop the active Namenode and run HDFS service check, it fails.


Diffs
-

  
ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/service_check.py
 dffa077 
  ambari-server/src/test/python/stacks/2.0.6/HDFS/test_service_check.py bbc1b3a 

Diff: https://reviews.apache.org/r/57087/diff/


Testing
---

mvn clean test


Thanks,

Eugene Chekanskiy

Re: Review Request 57079: All the workflow details are getting logged in UI console log

[Gaurav Nagar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57079/#review166855
---


Ship it!




Ship It!

- Gaurav Nagar


On Feb. 27, 2017, 10:04 a.m., belliraj hb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57079/
> ---
> 
> (Updated Feb. 27, 2017, 10:04 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Pallav Kulshreshtha, and Rohit 
> Choudhary.
> 
> 
> Bugs: AMBARI-20132
> https://issues.apache.org/jira/browse/AMBARI-20132
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> All console logs are removed. duplicate methods are removed.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> 61d9f35e72 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 8597d72c23 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 
> 00dedbb5ba 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
> f65931738c 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 
> 01da55bbc5 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/sqoop-action.js 
> 67ba85aabe 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js
>  e19646df5f 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/action-type-resolver.js
>  8cbcfafa91 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-generator.js
>  f2dcef931e 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-generator.js
>  4c8d16f2c4 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js
>  bc61f1079d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js
>  75ceecbe46 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js 
> e05b782b26 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/schema-versions.js 
> 67605ae4a6 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js 
> ae566f29e3 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js
>  fa7a8b8f92 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 
> be8d8de780 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/routes/design/proj-manager-tab.js
>  685b49c90b 
>   contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 
> b9ea770ae5 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js
>  c377eccf02 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 
> 7ad4361b9e 
> 
> Diff: https://reviews.apache.org/r/57079/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> belliraj hb
> 
>

Re: Review Request 57080: Ambari should install the unlimited key JCE policy based on service requirements even if cluster is not Kerberized

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57080/
---

(Updated Feb. 27, 2017, 7:01 a.m.)


Review request for Ambari, Alejandro Fernandez, Attila Magyar, Andrew Onischuk, 
Balázs Bence Sári, Eugene Chekanskiy, Laszlo Puskas, and Sebastian Toader.


Bugs: AMBARI-20196
https://issues.apache.org/jira/browse/AMBARI-20196


Repository: ambari


Description
---

Ambari should install the unlimited key JCE policy based on service 
requirements even if cluster is not Kerberized. For example, if a service needs 
the unlimited key JCE policy for an encryption task not related to Kerberos.

On a similar note, the unlimited key JCE policy is not being distributed to the 
agents if Kerberos is enabled using the "manual" option - as opposed to 
integrating with an existing KDC.

On a related note, Ambari Server host automatically unpacks JCE unlimited 
during "ambari-server setup" (unless custom JDK is used).


Diffs
-

  ambari-agent/pom.xml 074e051 
  ambari-agent/src/main/java/org/apache/ambari/tools/jce/JcePolicyInfo.java 
PRE-CREATION 
  
ambari-common/src/main/python/resource_management/core/resources/jcepolicyinfo.py
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 c80ebe6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 7cb7fce 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java 
51d9847 
  ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
409bcae 
  
ambari-server/src/main/java/org/apache/ambari/server/state/UnlimitedKeyJCERequirement.java
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py
 ddc8063 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
 5db62c5 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py
 f21e4b1 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 29c88b4 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
 9783aa4 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_client.py
 2ab700d 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
 6e37ded 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json 
fa4cc9d 
  
ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py
 30561ac 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
444fae6 

Diff: https://reviews.apache.org/r/57080/diff/


Testing (updated)
---

Manually tested with various versions of Java - Oracle 1.7. Oracle 1.8, and 
OpenJDK 1.8.

# Local test results:
```
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 24:35.838s
[INFO] Finished at: Mon Feb 27 05:33:33 EST 2017
[INFO] Final Memory: 93M/596M
[INFO] 
```

# Jenkins test results:
```
{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment
  
http://issues.apache.org/jira/secure/attachment/12854862/AMBARI-20196_trunk_01.patch
  against trunk revision .

{color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

{color:green}+1 tests included{color}.  The patch appears to include 4 new 
or modified test files.

{color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

{color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

{color:green}+1 core tests{color}.  The patch passed unit tests in 
ambari-agent ambari-server.

Test results: 
https://builds.apache.org/job/Ambari-trunk-test-patch/10767//testReport/
Console output: 
https://builds.apache.org/job/Ambari-trunk-test-patch/10767//console
```


Thanks,

Robert Levas

Re: Review Request 57081: Not able to delete custom property

[Denys Buzhor]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57081/#review166848
---


Ship it!




Ship It!

- Denys Buzhor


On Feb. 27, 2017, 10:52 a.m., Oleg Nechiporenko wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57081/
> ---
> 
> (Updated Feb. 27, 2017, 10:52 a.m.)
> 
> 
> Review request for Ambari and Denys Buzhor.
> 
> 
> Bugs: ambari-20147
> https://issues.apache.org/jira/browse/ambari-20147
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Steps to reproduce the issue:
> 1. Under Hive service , Create a custom Group called "hive-group1"
> 2. Add a property say "hive.mv.files.thread"
> 3. save the configurations
> 4. Again go to hive configurations, select hive-group1 group and then try to 
> delete the configuration by clicking "-" , it does nothing - in console fails 
> with JS error as
> Uncaught TypeError: Cannot read property 'without' of null
> at Class.removeOverride (app.js:185869)
> at handler (vendor.js:21227)
> at HTMLAnchorElement. (vendor.js:13019)
> at HTMLDivElement.dispatch (vendor.js:126)
> at HTMLDivElement.i (vendor.js:126)
> 
> 
> Diffs
> -
> 
>   ambari-web/app/mixins/common/configs/configs_comparator.js b619aca 
>   ambari-web/app/views/common/configs/overriddenPropertyRow_view.js 86e9c60 
> 
> Diff: https://reviews.apache.org/r/57081/diff/
> 
> 
> Testing
> ---
> 
> 20490 passing (23s)
>   153 pending
> 
> 
> Thanks,
> 
> Oleg Nechiporenko
> 
>

Review Request 57081: Not able to delete custom property

[Oleg Nechiporenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57081/
---

Review request for Ambari and Denys Buzhor.


Bugs: ambari-20147
https://issues.apache.org/jira/browse/ambari-20147


Repository: ambari


Description
---

Steps to reproduce the issue:
1. Under Hive service , Create a custom Group called "hive-group1"
2. Add a property say "hive.mv.files.thread"
3. save the configurations
4. Again go to hive configurations, select hive-group1 group and then try to 
delete the configuration by clicking "-" , it does nothing - in console fails 
with JS error as
Uncaught TypeError: Cannot read property 'without' of null
at Class.removeOverride (app.js:185869)
at handler (vendor.js:21227)
at HTMLAnchorElement. (vendor.js:13019)
at HTMLDivElement.dispatch (vendor.js:126)
at HTMLDivElement.i (vendor.js:126)


Diffs
-

  ambari-web/app/mixins/common/configs/configs_comparator.js b619aca 
  ambari-web/app/views/common/configs/overriddenPropertyRow_view.js 86e9c60 

Diff: https://reviews.apache.org/r/57081/diff/


Testing
---

20490 passing (23s)
  153 pending


Thanks,

Oleg Nechiporenko

Re: Review Request 57080: Ambari should install the unlimited key JCE policy based on service requirements even if cluster is not Kerberized

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57080/#review166846
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 (line 2445)


There is a typo in the comment



ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 (lines 42 - 44)


I think it's better to
```
sysprep_skip_setup_jce = False
if host_sys_prepped:
sysprep_skip_setup_jce = 
default("/configurations/cluster-env/sysprep_skip_setup_jce", False)
```

as this allows enabling disabling the whole syprep from config in a central 
way as well. The flags under cluster-env can be modified only either changing 
the Blueprint or changing the existing cluster-env config. The flags under 
cluster-env are rather for fine tuning the 'sysprep' once enabled.


- Sebastian Toader


On Feb. 27, 2017, 11:08 a.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57080/
> ---
> 
> (Updated Feb. 27, 2017, 11:08 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Attila Magyar, Andrew 
> Onischuk, Balázs Bence Sári, Eugene Chekanskiy, Laszlo Puskas, and Sebastian 
> Toader.
> 
> 
> Bugs: AMBARI-20196
> https://issues.apache.org/jira/browse/AMBARI-20196
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari should install the unlimited key JCE policy based on service 
> requirements even if cluster is not Kerberized. For example, if a service 
> needs the unlimited key JCE policy for an encryption task not related to 
> Kerberos.
> 
> On a similar note, the unlimited key JCE policy is not being distributed to 
> the agents if Kerberos is enabled using the "manual" option - as opposed to 
> integrating with an existing KDC.
> 
> On a related note, Ambari Server host automatically unpacks JCE unlimited 
> during "ambari-server setup" (unless custom JDK is used).
> 
> 
> Diffs
> -
> 
>   ambari-agent/pom.xml 074e051 
>   ambari-agent/src/main/java/org/apache/ambari/tools/jce/JcePolicyInfo.java 
> PRE-CREATION 
>   
> ambari-common/src/main/python/resource_management/core/resources/jcepolicyinfo.py
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  c80ebe6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  7cb7fce 
>   
> ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java
>  51d9847 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
> 409bcae 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UnlimitedKeyJCERequirement.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py
>  ddc8063 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
>  5db62c5 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py
>  f21e4b1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
>  29c88b4 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
>  9783aa4 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_client.py
>  2ab700d 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
>  6e37ded 
>   ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json 
> fa4cc9d 
>   
> ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py
>  30561ac 
>   ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
> 444fae6 
> 
> Diff: https://reviews.apache.org/r/57080/diff/
> 
> 
> Testing
> ---
> 
> Manually tested with various versions of Java - Oracle 1.7. Oracle 1.8, and 
> OpenJDK 1.8.
> 
> 
> Thanks,
> 
> Robert Levas
> 
>

Re: Review Request 57079: All the workflow details are getting logged in UI console log

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57079/#review166845
---


Ship it!




Ship It!

- Nitiraj Rathore


On Feb. 27, 2017, 10:04 a.m., belliraj hb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57079/
> ---
> 
> (Updated Feb. 27, 2017, 10:04 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Pallav Kulshreshtha, and Rohit 
> Choudhary.
> 
> 
> Bugs: AMBARI-20132
> https://issues.apache.org/jira/browse/AMBARI-20132
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> All console logs are removed. duplicate methods are removed.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> 61d9f35e72 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 8597d72c23 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 
> 00dedbb5ba 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
> f65931738c 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 
> 01da55bbc5 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/sqoop-action.js 
> 67ba85aabe 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js
>  e19646df5f 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/action-type-resolver.js
>  8cbcfafa91 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-generator.js
>  f2dcef931e 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-generator.js
>  4c8d16f2c4 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js
>  bc61f1079d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js
>  75ceecbe46 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js 
> e05b782b26 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/schema-versions.js 
> 67605ae4a6 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js 
> ae566f29e3 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js
>  fa7a8b8f92 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 
> be8d8de780 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/routes/design/proj-manager-tab.js
>  685b49c90b 
>   contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 
> b9ea770ae5 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js
>  c377eccf02 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 
> 7ad4361b9e 
> 
> Diff: https://reviews.apache.org/r/57079/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> belliraj hb
> 
>

Re: Review Request 57079: All the workflow details are getting logged in UI console log

[belliraj hb]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57079/#review166843
---


Ship it!




Ship It!

- belliraj hb


On Feb. 27, 2017, 10:04 a.m., belliraj hb wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57079/
> ---
> 
> (Updated Feb. 27, 2017, 10:04 a.m.)
> 
> 
> Review request for Ambari, Gaurav Nagar, Pallav Kulshreshtha, and Rohit 
> Choudhary.
> 
> 
> Bugs: AMBARI-20132
> https://issues.apache.org/jira/browse/AMBARI-20132
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> All console logs are removed. duplicate methods are removed.
> 
> 
> Diffs
> -
> 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/coord-config.js 
> 61d9f35e72 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js 
> 8597d72c23 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-config.js 
> 00dedbb5ba 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js 
> f65931738c 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/save-wf.js 
> 01da55bbc5 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/sqoop-action.js 
> 67ba85aabe 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-action-editor.js
>  e19646df5f 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/action-type-resolver.js
>  8cbcfafa91 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/bundle/bundle-xml-generator.js
>  f2dcef931e 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-generator.js
>  4c8d16f2c4 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/coordinator/coordinator-xml-importer.js
>  bc61f1079d 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-flow-renderer.js
>  75ceecbe46 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/cytoscape-style.js 
> e05b782b26 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/schema-versions.js 
> 67605ae4a6 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js 
> ae566f29e3 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-json-importer.js
>  fa7a8b8f92 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 
> be8d8de780 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/routes/design/proj-manager-tab.js
>  685b49c90b 
>   contrib/views/wfmanager/src/main/resources/ui/app/routes/index.js 
> b9ea770ae5 
>   
> contrib/views/wfmanager/src/main/resources/ui/app/services/workspace-manager.js
>  c377eccf02 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 
> 7ad4361b9e 
> 
> Diff: https://reviews.apache.org/r/57079/diff/
> 
> 
> Testing
> ---
> 
> Manual
> 
> 
> Thanks,
> 
> belliraj hb
> 
>

Review Request 57080: Ambari should install the unlimited key JCE policy based on service requirements even if cluster is not Kerberized

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57080/
---

Review request for Ambari, Alejandro Fernandez, Attila Magyar, Andrew Onischuk, 
Balázs Bence Sári, Eugene Chekanskiy, Laszlo Puskas, and Sebastian Toader.


Bugs: AMBARI-20196
https://issues.apache.org/jira/browse/AMBARI-20196


Repository: ambari


Description
---

Ambari should install the unlimited key JCE policy based on service 
requirements even if cluster is not Kerberized. For example, if a service needs 
the unlimited key JCE policy for an encryption task not related to Kerberos.

On a similar note, the unlimited key JCE policy is not being distributed to the 
agents if Kerberos is enabled using the "manual" option - as opposed to 
integrating with an existing KDC.

On a related note, Ambari Server host automatically unpacks JCE unlimited 
during "ambari-server setup" (unless custom JDK is used).


Diffs
-

  ambari-agent/pom.xml 074e051 
  ambari-agent/src/main/java/org/apache/ambari/tools/jce/JcePolicyInfo.java 
PRE-CREATION 
  
ambari-common/src/main/python/resource_management/core/resources/jcepolicyinfo.py
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 c80ebe6 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 7cb7fce 
  
ambari-server/src/main/java/org/apache/ambari/server/stack/ComponentModule.java 
51d9847 
  ambari-server/src/main/java/org/apache/ambari/server/state/ComponentInfo.java 
409bcae 
  
ambari-server/src/main/java/org/apache/ambari/server/state/UnlimitedKeyJCERequirement.java
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_client.py
 ddc8063 
  
ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/package/scripts/kerberos_common.py
 5db62c5 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/hook.py
 f21e4b1 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py
 29c88b4 
  
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/shared_initialization.py
 9783aa4 
  
ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/package/scripts/kerberos_client.py
 2ab700d 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/ComponentModuleTest.java
 6e37ded 
  ambari-server/src/test/python/stacks/2.0.6/configs/secured_no_jce_name.json 
fa4cc9d 
  
ambari-server/src/test/python/stacks/2.0.6/hooks/before-START/test_before_start.py
 30561ac 
  ambari-server/src/test/python/stacks/2.2/KERBEROS/test_kerberos_client.py 
444fae6 

Diff: https://reviews.apache.org/r/57080/diff/


Testing
---

Manually tested with various versions of Java - Oracle 1.7. Oracle 1.8, and 
OpenJDK 1.8.


Thanks,

Robert Levas