Review Request 59382: Regex pattern for version number in Register Version UI should depend on stack's version dir

2017-05-18 Thread Sangeeta Ravindran 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59382/
---

Review request for Ambari, Alexandr Antonenko and Di Li.


Bugs: AMBARI-21052
https://issues.apache.org/jira/browse/AMBARI-21052


Repository: ambari


Description
---

In the Register Version UI, the regex pattern for Version Number is currently 
hardcoded to $scope.subversionPattern = /^\d+\.\d+(-\d+)?$/ requiring two 
digits to be entered to make it a valid 4 digit stack version. If the stack 
version dir has three digits, Register Version UI throws an error mystack-x.x.x 
Invalid. The regex pattern should be based on the number of digits supplied by 
the stack's version dir and should not be harcoded.


Diffs (updated)
-

  
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js
 69c35c0 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/i18n.config.js 
fd2c6e5 
  ambari-admin/src/main/resources/ui/admin-web/app/scripts/services/Stack.js 
b496987 
  
ambari-admin/src/main/resources/ui/admin-web/app/views/stackVersions/stackVersionPage.html
 fe08802 
  
ambari-admin/src/main/resources/ui/admin-web/test/unit/controllers/stackVersions/StackVersionsCreateCtrl_test.js
 81d3441 


Diff: https://reviews.apache.org/r/59382/diff/1/


Testing (updated)
---

Manual Testing.
I updated the test case because $scope.subversionPattern has been removed as 
part of this fix.


Thanks,

Sangeeta Ravindran

Re: Review Request 59312: Log Search use POJOs for input configuration

2017-05-18 Thread Miklos Gergely 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59312/
---

(Updated May 19, 2017, 12:19 a.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
---

Added wrappers for REST API call for input config


Bugs: AMBARI-21033
https://issues.apache.org/jira/browse/AMBARI-21033


Repository: ambari


Description
---

Instead of parsing the input configuration jsons in logfeeder the configuration 
api should return POJOs with the input and filter descriptions


Diffs (updated)
-

  ambari-logsearch/ambari-logsearch-config-api/pom.xml 72fcc80 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/InputConfigMonitor.java
 29a82a6 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfig.java
 07921d0 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/LogSearchConfigFactory.java
 6ef4b90 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/Conditions.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/Fields.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/FilterDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/FilterGrokDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/FilterJsonDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/FilterKeyValueDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputConfig.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputFileBaseDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputFileDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/InputS3FileDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapDateDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapFieldCopyDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapFieldDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapFieldNameDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/MapFieldValueDescriptor.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/main/java/org/apache/ambari/logsearch/config/api/model/inputconfig/PostMapValues.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass1.java
 fc3fe5b 
  
ambari-logsearch/ambari-logsearch-config-api/src/test/java/org/apache/ambari/logsearch/config/api/LogSearchConfigClass2.java
 346edb3 
  ambari-logsearch/ambari-logsearch-config-zookeeper/pom.xml 2c59a4a 
  
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/LogSearchConfigZK.java
 5e22374 
  
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/ConditionsImpl.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/FieldsImpl.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/FilterAdapter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/FilterDescriptorImpl.java

Review Request 59381: HDP 3.0 TP - create Service Advisor for Oozie

2017-05-18 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59381/
---

Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-21064
https://issues.apache.org/jira/browse/AMBARI-21064


Repository: ambari


Description
---

create Service Advisor for Oozie


Diffs
-

  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/service_advisor.py
 PRE-CREATION 


Diff: https://reviews.apache.org/r/59381/diff/1/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Review Request 59373: Address config-groups while exporting blueprint from UI

2017-05-18 Thread Amruta Borkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59373/
---

Review request for Ambari, Alexandr Antonenko, Di Li, Robert Nettleton, and 
Sangeeta Ravindran.


Bugs: AMBARI-21050
https://issues.apache.org/jira/browse/AMBARI-21050


Repository: ambari


Description
---

Exported blueprint should include config-group changes, which should be 
exported as host-group level configuration. New host-group will be created for 
host having unique config-group.


Diffs
-

  ambari-web/app/controllers/wizard/step8_controller.js 7e318e0e62 
  ambari-web/test/controllers/wizard/step8_test.js 1a3214e263 


Diff: https://reviews.apache.org/r/59373/diff/1/


Testing
---

Tested manually. Updated test cases.


File Attachments


exported blueprint
  
https://reviews.apache.org/media/uploaded/files/2017/05/18/a01c8336-2e84-4c73-af54-c7ba60e7acb3__blueprint_expUI.json
exported cluster template
  
https://reviews.apache.org/media/uploaded/files/2017/05/18/ee8f7e71-fea9-42ba-bcd1-9afc1a8654d6__clustertemplate_expUI.json


Thanks,

Amruta Borkar

Re: Review Request 59369: Reduce Dependency on Cluster Desired Stack ID

2017-05-18 Thread Nate Cole 


> On May 18, 2017, 12:13 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
> > Lines 1126 (patched)
> > 
> >
> > Can you annotate this method declaration as being temporary? It should 
> > eventually not be needed, right?

This was added because we do the same checking on both the validation and the 
processing.  I had missed code in one of the spots and had enough.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59369/#review175390
---


On May 18, 2017, 9:56 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59369/
> ---
> 
> (Updated May 18, 2017, 9:56 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21059
> https://issues.apache.org/jira/browse/AMBARI-21059
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the advent of {{PATCH}} and {{CLUSTER}} upgrades, there is no longer the 
> notion of a cluster being bound to a specific stack. Instead, the stack ID is 
> being pushed down to the service and component level.
> 
> Currently, upgrades tries to set the cluster desired stack ID on 
> finalization. Eventually there will be a complete decouple of the cluster 
> from a singular stack id.  This jira covers a majority of cases in code.  
> Until configs are refactored, we can't remove the associated stack id in its 
> entirety.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java
>  1d5ba0e9e9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  36015282ea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  a77ed75c99 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  17e1f9c138 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  c655c6286f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  2fc1787e17 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
>  70a061cc79 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
>  1e87319d84 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
>  a4cea3105f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
>  a55a1481d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
>  4ccdc0a3d9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  273bdaac68 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java
>  d8dba96094 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  9fb77e8d6b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  397c1c29e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  96bab85b47 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  a4f59a58eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  8a5731bcbe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java
>  66c1a93081 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  4ad01a54a7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  9ca8ddc369 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
>  24ef41a767 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  664ba42f34 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java
>  8972ca220f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  c3691bfa88 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
>  c69d00ba46 
>   
>

Re: Review Request 59369: Reduce Dependency on Cluster Desired Stack ID

2017-05-18 Thread Nate Cole 


> On May 18, 2017, 12:13 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryAction.java
> > Lines 200-202 (original), 194-195 (patched)
> > 
> >
> > Just making sure this returns the same value. One doesn't return the 
> > name and the other the display name, right?

I hate this code.  We should never use _just_ the component name.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59369/#review175390
---


On May 18, 2017, 9:56 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59369/
> ---
> 
> (Updated May 18, 2017, 9:56 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21059
> https://issues.apache.org/jira/browse/AMBARI-21059
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the advent of {{PATCH}} and {{CLUSTER}} upgrades, there is no longer the 
> notion of a cluster being bound to a specific stack. Instead, the stack ID is 
> being pushed down to the service and component level.
> 
> Currently, upgrades tries to set the cluster desired stack ID on 
> finalization. Eventually there will be a complete decouple of the cluster 
> from a singular stack id.  This jira covers a majority of cases in code.  
> Until configs are refactored, we can't remove the associated stack id in its 
> entirety.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java
>  1d5ba0e9e9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  36015282ea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  a77ed75c99 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  17e1f9c138 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  c655c6286f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  2fc1787e17 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
>  70a061cc79 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
>  1e87319d84 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
>  a4cea3105f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
>  a55a1481d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
>  4ccdc0a3d9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  273bdaac68 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java
>  d8dba96094 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  9fb77e8d6b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  397c1c29e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  96bab85b47 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  a4f59a58eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  8a5731bcbe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java
>  66c1a93081 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  4ad01a54a7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  9ca8ddc369 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
>  24ef41a767 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  664ba42f34 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java
>  8972ca220f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  c3691bfa88 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
>  c69d00ba46 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
>

Re: Review Request 59369: Reduce Dependency on Cluster Desired Stack ID

2017-05-18 Thread Nate Cole 


> On May 18, 2017, 12:13 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
> > Lines 224-230 (original), 225-237 (patched)
> > 
> >
> > I think I changed this already in my commit. We shouldn't be used stack 
> > ID to find the repos; we should just get them all.

I'll pull and see how this was changed.


> On May 18, 2017, 12:13 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java
> > Lines 216-227 (patched)
> > 
> >
> > This seems temporary since it can't guarantee uniqueness? Can we mark 
> > this with an annotation to remove it later on?

Yep.  If all we have is version, then it's all we can go on.  This was to 
workaround what the UI was providing, but once we have the id, well, we have it.


> On May 18, 2017, 12:13 p.m., Jonathan Hurley wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java
> > Lines 777-783 (patched)
> > 
> >
> > In our world, this seems OK since for every service's stack, there 
> > should only be 1 entry. (Like 2.5 for ZK and 2.6 for Storm) ...
> > 
> > But in the multiverse of multi-everything, this could return values for 
> > ZK on 2.5 and ZK on 2.6 if both services are deployed concurrently.
> > 
> > Maybe just mark this as needing attention from multi-everything people?

I'll mark it.  One would hope that many ZK would be deployed, but we'd be 
getting them from a Service Group, which should only be one stack.  In that 
world, I would hope that cluster.getServices() isn't the way to get a handle to 
the service.


- Nate


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59369/#review175390
---


On May 18, 2017, 9:56 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59369/
> ---
> 
> (Updated May 18, 2017, 9:56 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21059
> https://issues.apache.org/jira/browse/AMBARI-21059
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the advent of {{PATCH}} and {{CLUSTER}} upgrades, there is no longer the 
> notion of a cluster being bound to a specific stack. Instead, the stack ID is 
> being pushed down to the service and component level.
> 
> Currently, upgrades tries to set the cluster desired stack ID on 
> finalization. Eventually there will be a complete decouple of the cluster 
> from a singular stack id.  This jira covers a majority of cases in code.  
> Until configs are refactored, we can't remove the associated stack id in its 
> entirety.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java
>  1d5ba0e9e9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  36015282ea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  a77ed75c99 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  17e1f9c138 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  c655c6286f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  2fc1787e17 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
>  70a061cc79 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
>  1e87319d84 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
>  a4cea3105f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
>  a55a1481d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
>  4ccdc0a3d9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  273bdaac68 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java
>  d8dba96094 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  9fb77e8d6b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  397c1c29e1 
>   
>

Re: Review Request 59371: HDP 3.0 TP - create service definition for Oozie with configs, kerberos, widgets, etc

2017-05-18 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59371/#review175394
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 18, 2017, 4:21 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59371/
> ---
> 
> (Updated May 18, 2017, 4:21 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-21060
> https://issues.apache.org/jira/browse/AMBARI-21060
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> create service definition for Oozie with configs, kerberos, widgets, etc
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/configuration/oozie-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/configuration/oozie-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/configuration/oozie-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/kerberos.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/alerts/alert_check_oozie_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/files/oozieSmoke2.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/files/prepareOozieHdfsDirectories.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/files/wrap_ooziedb.sh
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/check_oozie_server_status.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/oozie.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/oozie_client.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/oozie_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/oozie_server_upgrade.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/oozie_service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/params_linux.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/params_windows.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/templates/adminusers.txt.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/templates/input.config-oozie.json.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/templates/oozie-log4j.properties.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/templates/oozie.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/templates/zkmigrator_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/role_command_order.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/themes/theme.json
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/3.0/services/OOZIE/metainfo.xml 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59371/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Review Request 59371: HDP 3.0 TP - create service definition for Oozie with configs, kerberos, widgets, etc

2017-05-18 Thread Vitalyi Brodetskyi 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59371/
---

Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-21060
https://issues.apache.org/jira/browse/AMBARI-21060


Repository: ambari


Description
---

create service definition for Oozie with configs, kerberos, widgets, etc


Diffs
-

  ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/alerts.json 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/configuration/oozie-env.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/configuration/oozie-log4j.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/configuration/oozie-site.xml
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/metainfo.xml 
PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/alerts/alert_check_oozie_server.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/files/oozieSmoke2.sh
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/files/prepareOozieHdfsDirectories.sh
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/files/wrap_ooziedb.sh
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/check_oozie_server_status.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/oozie.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/oozie_client.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/oozie_server.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/oozie_server_upgrade.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/oozie_service.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/params_linux.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/params_windows.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/service_check.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/scripts/status_params.py
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/templates/adminusers.txt.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/templates/input.config-oozie.json.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/templates/oozie-log4j.properties.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/templates/oozie.conf.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/package/templates/zkmigrator_jaas.conf.j2
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/quicklinks/quicklinks.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/role_command_order.json
 PRE-CREATION 
  
ambari-server/src/main/resources/common-services/OOZIE/4.2.0.3.0/themes/theme.json
 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/3.0/services/OOZIE/metainfo.xml 
PRE-CREATION 


Diff: https://reviews.apache.org/r/59371/diff/1/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Re: Review Request 59369: Reduce Dependency on Cluster Desired Stack ID

2017-05-18 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59369/#review175390
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
Lines 224-230 (original), 225-237 (patched)


I think I changed this already in my commit. We shouldn't be used stack ID 
to find the repos; we should just get them all.



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
Lines 446-454 (original), 431-441 (patched)


Is this already being set by lines 431? Maybe just grab the reference once?



ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
Lines 1126 (patched)


Can you annotate this method declaration as being temporary? It should 
eventually not be needed, right?



ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java
Lines 216-227 (patched)


This seems temporary since it can't guarantee uniqueness? Can we mark this 
with an annotation to remove it later on?



ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AutoSkipFailedSummaryAction.java
Lines 200-202 (original), 194-195 (patched)


Just making sure this returns the same value. One doesn't return the name 
and the other the display name, right?



ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java
Lines 777-783 (patched)


In our world, this seems OK since for every service's stack, there should 
only be 1 entry. (Like 2.5 for ZK and 2.6 for Storm) ...

But in the multiverse of multi-everything, this could return values for ZK 
on 2.5 and ZK on 2.6 if both services are deployed concurrently.

Maybe just mark this as needing attention from multi-everything people?


- Jonathan Hurley


On May 18, 2017, 9:56 a.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59369/
> ---
> 
> (Updated May 18, 2017, 9:56 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21059
> https://issues.apache.org/jira/browse/AMBARI-21059
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the advent of {{PATCH}} and {{CLUSTER}} upgrades, there is no longer the 
> notion of a cluster being bound to a specific stack. Instead, the stack ID is 
> being pushed down to the service and component level.
> 
> Currently, upgrades tries to set the cluster desired stack ID on 
> finalization. Eventually there will be a complete decouple of the cluster 
> from a singular stack id.  This jira covers a majority of cases in code.  
> Until configs are refactored, we can't remove the associated stack id in its 
> entirety.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java
>  1d5ba0e9e9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  36015282ea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  a77ed75c99 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  17e1f9c138 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  c655c6286f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  2fc1787e17 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
>  70a061cc79 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
>  1e87319d84 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
>  a4cea3105f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
>  a55a1481d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
>  4ccdc0a3d9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  273bdaac68 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java
>  d8dba96094 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  9fb77e8d6b 
>   
>

Re: Review Request 59329: Atlas web UI inaccessible after adding Atlas service on upgraded cluster with Hive because /etc/atlas/conf symlink was created ahead of time

2017-05-18 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59329/
---

(Updated May 18, 2017, 3:48 p.m.)


Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and Sumit 
Mohanty.


Bugs: AMBARI-21039
https://issues.apache.org/jira/browse/AMBARI-21039


Repository: ambari


Description
---

STR:
*Install Ambari 2.4.3 with HDP 2.5.3.0
*Include ZK, HDFS, MR, YARN, Hive (plus Pig, Tez, Slider), Kafka, Ambari Infra
*Install bits for HDP 2.5.5.0
*Perform EU
*Add Atlas as a service

There will be an alert for "Metadata Server Web UI" being inaccessible because 
/etc/atlas/conf/solr/ will contain the wrong configs after the upgrade.
This happens because installing Hive will also create artifacts in 
/usr/hdp/$version/atlas for the hooks, so when the bits are installed, it 
mistakenly creates /etc/atlas/conf as a broken symlink to 
/usr/hdp/current/atlas-client/conf (which doesn't exist yet). Because the 
symlink is broken to begin with, then adding Atlas for the first time does not 
populate the correct solr configs.

This is a regression of AMBARI-18368, now that /usr/hdp/current/atlas-client 
exists as a valid symlink even though Atlas is not actually


Diffs
-

  
ambari-common/src/main/python/resource_management/libraries/functions/conf_select.py
 8d54053 


Diff: https://reviews.apache.org/r/59329/diff/1/


Testing
---

Verified on live cluster.


Thanks,

Alejandro Fernandez

Re: Review Request 59369: Reduce Dependency on Cluster Desired Stack ID

2017-05-18 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59369/#review175387
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On May 18, 2017, 4:56 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59369/
> ---
> 
> (Updated May 18, 2017, 4:56 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21059
> https://issues.apache.org/jira/browse/AMBARI-21059
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the advent of {{PATCH}} and {{CLUSTER}} upgrades, there is no longer the 
> notion of a cluster being bound to a specific stack. Instead, the stack ID is 
> being pushed down to the service and component level.
> 
> Currently, upgrades tries to set the cluster desired stack ID on 
> finalization. Eventually there will be a complete decouple of the cluster 
> from a singular stack id.  This jira covers a majority of cases in code.  
> Until configs are refactored, we can't remove the associated stack id in its 
> entirety.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java
>  1d5ba0e9e9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  36015282ea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  a77ed75c99 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  17e1f9c138 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  c655c6286f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  2fc1787e17 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
>  70a061cc79 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
>  1e87319d84 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
>  a4cea3105f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
>  a55a1481d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
>  4ccdc0a3d9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  273bdaac68 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java
>  d8dba96094 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  9fb77e8d6b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  397c1c29e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  96bab85b47 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  a4f59a58eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  8a5731bcbe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java
>  66c1a93081 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  4ad01a54a7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  9ca8ddc369 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
>  24ef41a767 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  664ba42f34 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java
>  8972ca220f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  c3691bfa88 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
>  c69d00ba46 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
>  c4c2ddcbae 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java
>  264ba030f7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java
>  d44515cdb4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java
>  89d4004f4f 
>   
>

Re: Review Request 59364: AMBARI-21053 Reverting Beacon stack advisor recommendation

2017-05-18 Thread Mugdha Varadkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59364/
---

(Updated May 18, 2017, 3:03 p.m.)


Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, 
Xi Wang, and Yusaku Sako.


Changes
---

Updating correct jira ID


Summary (updated)
-

AMBARI-21053 Reverting Beacon stack advisor recommendation


Bugs: AMBARI-21053
https://issues.apache.org/jira/browse/AMBARI-21053


Repository: ambari


Description
---

Beacon is an add-on-service installed via management pack. For services 
installed via mpack need to use service advisor recommendation, which should be 
provided in mpack.

Because of the stack_advisor code available, service_advisor.py code logic from 
mpack is not getting executed.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
488562b 


Diff: https://reviews.apache.org/r/59364/diff/1/


Testing
---

Ran 273 tests in 7.202s

OK
--
Total run:1171
Total errors:0
Total failures:0
OK


Thanks,

Mugdha Varadkar

Re: Review Request 59364: AMBARI-20762 Reverting Beacon stack advisor recommendation

2017-05-18 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59364/#review175377
---


Ship it!




Ship It!

- Sumit Mohanty


On May 18, 2017, 10:54 a.m., Mugdha Varadkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59364/
> ---
> 
> (Updated May 18, 2017, 10:54 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, 
> Xi Wang, and Yusaku Sako.
> 
> 
> Bugs: AMBARI-20762
> https://issues.apache.org/jira/browse/AMBARI-20762
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Beacon is an add-on-service installed via management pack. For services 
> installed via mpack need to use service advisor recommendation, which should 
> be provided in mpack.
> 
> Because of the stack_advisor code available, service_advisor.py code logic 
> from mpack is not getting executed.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
> 488562b 
> 
> 
> Diff: https://reviews.apache.org/r/59364/diff/1/
> 
> 
> Testing
> ---
> 
> Ran 273 tests in 7.202s
> 
> OK
> --
> Total run:1171
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Mugdha Varadkar
> 
>

Re: Review Request 59367: Run execution commands sent to /user/commands

2017-05-18 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59367/
---

(Updated May 18, 2017, 1:58 p.m.)


Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-21056
https://issues.apache.org/jira/browse/AMBARI-21056


Repository: ambari


Description (updated)
---

.


Diffs (updated)
-

  ambari-agent/conf/unix/ambari-agent.ini 441a01d 
  ambari-agent/src/main/python/ambari_agent/ActionQueue.py 1eda5c2 
  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py fe48870 
  ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py 7a97f3f 
  ambari-agent/src/main/python/ambari_agent/CommandStatusReporter.py 
PRE-CREATION 
  ambari-agent/src/main/python/ambari_agent/ComponentStatusExecutor.py a3798c6 
  ambari-agent/src/main/python/ambari_agent/Constants.py 3fbb485 
  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
8b8a8f9 
  ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 57748a0 
  ambari-agent/src/main/python/ambari_agent/InitializerModule.py e1b4ed7 
  ambari-agent/src/main/python/ambari_agent/PythonExecutor.py ea6f895 
  ambari-agent/src/main/python/ambari_agent/listeners/CommandsEventListener.py 
PRE-CREATION 
  
ambari-agent/src/main/python/ambari_agent/listeners/ConfigurationEventListener.py
 722ec3c 
  ambari-agent/src/main/python/ambari_agent/listeners/__init__.py 2b7e9bc 
  ambari-agent/src/main/python/ambari_agent/main.py 29eb926 
  ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py cab8fe1 
  
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/execution_commands.json
 bf54b97 


Diff: https://reviews.apache.org/r/59367/diff/2/

Changes: https://reviews.apache.org/r/59367/diff/1-2/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 59369: Reduce Dependency on Cluster Desired Stack ID

2017-05-18 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59369/
---

Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
Jonathan Hurley.


Bugs: AMBARI-21059
https://issues.apache.org/jira/browse/AMBARI-21059


Repository: ambari


Description
---

With the advent of {{PATCH}} and {{CLUSTER}} upgrades, there is no longer the 
notion of a cluster being bound to a specific stack. Instead, the stack ID is 
being pushed down to the service and component level.

Currently, upgrades tries to set the cluster desired stack ID on finalization. 
Eventually there will be a complete decouple of the cluster from a singular 
stack id.  This jira covers a majority of cases in code.  Until configs are 
refactored, we can't remove the associated stack id in its entirety.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java
 1d5ba0e9e9 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
 36015282ea 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
 a77ed75c99 
  
ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
 17e1f9c138 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
 c655c6286f 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
 2fc1787e17 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
 70a061cc79 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
 1e87319d84 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
 a4cea3105f 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
 a55a1481d6 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
 4ccdc0a3d9 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
 273bdaac68 
  
ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java
 d8dba96094 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
 9fb77e8d6b 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 397c1c29e1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
 96bab85b47 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 a4f59a58eb 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
 8a5731bcbe 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java
 66c1a93081 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 4ad01a54a7 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
 9ca8ddc369 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
 24ef41a767 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
 664ba42f34 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java
 8972ca220f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
 c3691bfa88 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
 c69d00ba46 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
 c4c2ddcbae 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java
 264ba030f7 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java
 d44515cdb4 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HDFSServiceCalculatedState.java
 89d4004f4f 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HiveServiceCalculatedState.java
 0643c94ce1 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/OozieServiceCalculatedState.java
 4d0cf92c87 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/YARNServiceCalculatedState.java
 24c460226c 
  
ambari-server/src/main/java/org/apache/ambari/server/metadata/RoleCommandOrder.java
 40ec0a1e80 
  
ambari-server/src/main/java/org/apache/ambari/server/orm/dao/RepositoryVersionDAO.java
 a2472b6a8c

Review Request 59367: Run execution commands sent to /user/commands

2017-05-18 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59367/
---

Review request for Ambari, Alejandro Fernandez, Myroslav Papirkovskyy, and Sid 
Wagle.


Bugs: AMBARI-21056
https://issues.apache.org/jira/browse/AMBARI-21056


Repository: ambari


Description
---


Diffs
-

  ambari-agent/conf/unix/ambari-agent.ini 441a01d 
  ambari-agent/src/main/python/ambari_agent/ActionQueue.py 1eda5c2 
  ambari-agent/src/main/python/ambari_agent/AmbariConfig.py fe48870 
  ambari-agent/src/main/python/ambari_agent/CommandStatusDict.py 7a97f3f 
  ambari-agent/src/main/python/ambari_agent/CommandStatusReporter.py 
PRE-CREATION 
  ambari-agent/src/main/python/ambari_agent/ComponentStatusExecutor.py a3798c6 
  ambari-agent/src/main/python/ambari_agent/Constants.py 3fbb485 
  ambari-agent/src/main/python/ambari_agent/CustomServiceOrchestrator.py 
8b8a8f9 
  ambari-agent/src/main/python/ambari_agent/HeartbeatThread.py 57748a0 
  ambari-agent/src/main/python/ambari_agent/InitializerModule.py e1b4ed7 
  ambari-agent/src/main/python/ambari_agent/PythonExecutor.py ea6f895 
  ambari-agent/src/main/python/ambari_agent/listeners/CommandsEventListener.py 
PRE-CREATION 
  ambari-agent/src/main/python/ambari_agent/listeners/__init__.py 2b7e9bc 
  ambari-agent/src/main/python/ambari_agent/main.py 29eb926 
  ambari-agent/src/test/python/ambari_agent/TestAgentStompResponses.py cab8fe1 
  
ambari-agent/src/test/python/ambari_agent/dummy_files/stomp/execution_commands.json
 bf54b97 


Diff: https://reviews.apache.org/r/59367/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 59345: Iterative Fixes For Patch/Service Upgrade Development

2017-05-18 Thread Dmitro Lisnichenko 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59345/#review175366
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On May 17, 2017, 9:56 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59345/
> ---
> 
> (Updated May 17, 2017, 9:56 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-21047
> https://issues.apache.org/jira/browse/AMBARI-21047
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Commit a melting pot of minor fixes to allow patch/service upgrade 
> development to move foward.
> 
> - Some unit test failures
> - Downgrade of a {{STANDARD}} repository creates incorrect history
> - Removal of command properties no longer used
> - Exposing stacks for all repositories in the stacks view
> - Disabling {{ru_set_all}} since it's wrong and fails (and may not be 
> necessary anymore)
> - Removal of some dead code
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/decorator.py
>  b5b804d674 
>   
> ambari-funtest/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_nonrolling_new_stack.xml
>  ad6174c560 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  a4f59a58eb 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  9ca8ddc369 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  c3691bfa88 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/AbstractUpgradeServerAction.java
>  4942f275b6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FinalizeUpgradeAction.java
>  c4e073cd44 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/UpdateDesiredStackAction.java
>  657cb07636 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 9098cf1da8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/UpgradeContext.java
>  db58d27629 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  281523a660 
>   ambari-server/src/main/resources/custom_actions/scripts/ru_set_all.py 
> a7732d97f1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/AmbariManagementControllerImplTest.java
>  4170342c77 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/ComponentVersionCheckActionTest.java
>  738ad1fc6a 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
>  2bc2c13f76 
>   ambari-server/src/test/python/custom_actions/test_ru_set_all.py e1a89a8999 
>   
> ambari-server/src/test/resources/stacks/HDP/2.1.1/upgrades/upgrade_nonrolling_new_stack.xml
>  9d53714665 
> 
> 
> Diff: https://reviews.apache.org/r/59345/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Review Request 59365: Add ppc as a new OS for User.

2017-05-18 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59365/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-21054
https://issues.apache.org/jira/browse/AMBARI-21054


Repository: ambari


Description
---

Add ppc as a new OS for User.

As centos 6 - there should be a centos6-ppc for ppc users.


Diffs
-

  ambari-common/src/main/python/ambari_commons/os_check.py b430c86 
  ambari-common/src/main/python/ambari_commons/resources/os_family.json 859ce56 
  ambari-common/src/main/python/resource_management/core/providers/__init__.py 
21ae0d5 
  
ambari-common/src/main/python/resource_management/libraries/providers/__init__.py
 bd7c98a 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 01f93b4 
  
ambari-server/src/main/java/org/apache/ambari/server/state/stack/OsFamily.java 
1300172 
  ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml 81a70a5 


Diff: https://reviews.apache.org/r/59365/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 59364: AMBARI-20762 Reverting Beacon stack advisor recommendation

2017-05-18 Thread Mugdha Varadkar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59364/
---

Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Sumit Mohanty, 
Xi Wang, and Yusaku Sako.


Bugs: AMBARI-20762
https://issues.apache.org/jira/browse/AMBARI-20762


Repository: ambari


Description
---

Beacon is an add-on-service installed via management pack. For services 
installed via mpack need to use service advisor recommendation, which should be 
provided in mpack.

Because of the stack_advisor code available, service_advisor.py code logic from 
mpack is not getting executed.


Diffs
-

  ambari-server/src/main/resources/stacks/HDP/2.6/services/stack_advisor.py 
488562b 


Diff: https://reviews.apache.org/r/59364/diff/1/


Testing
---

Ran 273 tests in 7.202s

OK
--
Total run:1171
Total errors:0
Total failures:0
OK


Thanks,

Mugdha Varadkar

Re: Review Request 59149: Add Kerberos HTTP SPNEGO authentication support to Hadoop/hbase/kafka/storm sinks

2017-05-18 Thread Dmytro Sen 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59149/#review175364
---



Please check if changes from ambari-server/src/main/resources/stacks/HDP/* need 
to be duplicated for services that has been flattened for stack 3.0

- Dmytro Sen


On Май 13, 2017, 8:56 п.п., Qin Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59149/
> ---
> 
> (Updated Май 13, 2017, 8:56 п.п.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, Robert Levas, and 
> Sid Wagle.
> 
> 
> Bugs: AMBARI-19369
> https://issues.apache.org/jira/browse/AMBARI-19369
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This is a subtask of AMBARI-14384 "Ambari Metrics doesn't use SPNEGO to 
> authenticate".
> 
> In a Kerberos enabled cluster with SPNEGO enabled on Hadoop APIs, Ambari 
> Metrics Collector web-console will be Kerberos HTTP SPNEGO enabled too. But 
> Hadoop/hbase/kafka/storm sinks, clients of Ambari Metrics Collector, 
> currently do not support Kerberos HTTP SPNEGO authentication.
> 
> e.g., 
> /var/log/hadoop-yarn/yarn/yarn-yarn-timelineserver-.log:
> 2016-12-16 22:25:29,471 INFO timeline.HadoopTimelineMetricsSink 
> (AbstractTimelineMetricsSink.java:emitMetricsJson(169)) - Unable to POST 
> metrics to collector, http://metrics-collector:6188/ws/v1/timeline/metrics, 
> statusCode = 401
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-common/pom.xml 62ae75f 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java
>  2c6fae2 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AppCookieManager.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/AppCookieManagerTest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
>  db36db8 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hbase_master_jaas.conf.j2
>  a93c36c 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/hbase_regionserver_jaas.conf.j2
>  7097481 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hbase_master_jaas.conf.j2
>  a93c36c 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/templates/hbase_regionserver_jaas.conf.j2
>  7097481 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/scripts/hdfs.py
>  d9b62e2 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_dn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_jn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/templates/hdfs_nn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/scripts/hdfs.py
>  d9b62e2 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/templates/hdfs_dn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/templates/hdfs_jn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/package/templates/hdfs_nn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka-env.xml
>  91af58e 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/configuration/kafka_jaas_conf.xml
>  fdde8f2 
>   
> ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/templates/kafka_jaas.conf.j2
>  56c558d 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/storm_yaml_utils.py
>  9d78e71 
>   
> ambari-server/src/main/resources/common-services/STORM/0.9.1/package/templates/storm_jaas.conf.j2
>  c22cb51 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  3579fcb 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  2e1b208 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/templates/mapred_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/templates/yarn_ats_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/templates/yarn_jaas.conf.j2
>  483c815 
>   
>

Re: Review Request 59281: Integrate BlueprintService and subresources with swagger

2017-05-18 Thread Balázs Bence Sári 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59281/
---

(Updated May 18, 2017, 9:27 a.m.)


Review request for Ambari, Attila Doroszlai, Jaimin Jetly, Oliver Szabo, Sumit 
Mohanty, and Sebastian Toader.


Changes
---

Review comments fixed


Bugs: AMBARI-21026
https://issues.apache.org/jira/browse/AMBARI-21026


Repository: ambari


Description
---

Documented the Blueprint API. Kerberos descriptor in Blueprint schema is not 
elaborated.


Diffs (updated)
-

  
ambari-server/src/main/java/org/apache/ambari/server/api/services/BaseService.java
 2808911 
  
ambari-server/src/main/java/org/apache/ambari/server/api/services/BlueprintService.java
 8159ea4 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/BlueprintSwagger.java
 PRE-CREATION 


Diff: https://reviews.apache.org/r/59281/diff/2/

Changes: https://reviews.apache.org/r/59281/diff/1-2/


Testing
---

All unit tests for ambari-server pass, except 
ServicePropertiesTest.validatePropertySchemaOfServiceXMLs, which fails due to 
AMBARI-20443.


Thanks,

Balázs Bence Sári