Review Request 59563: Log Search REST API validate input configurations and log level filters

[Miklos Gergely]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59563/
---

Review request for Ambari, Oliver Szabo and Robert Nettleton.


Bugs: AMBARI-21119
https://issues.apache.org/jira/browse/AMBARI-21119


Repository: ambari


Description
---

Log Search server REST API should validate that the received input 
configuration / log level filter is in the valid format.


Diffs
-

  
ambari-logsearch/ambari-logsearch-config-zookeeper/src/main/java/org/apache/ambari/logsearch/config/zookeeper/model/inputconfig/impl/MapFieldNameDescriptorImpl.java
 333cb67 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/manager/ShipperConfigManager.java
 44d91a9 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerConditions.java
 9cd9710 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerFields.java
 5f570da 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerFilter.java
 0190c01 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerFilterDeserializer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerFilterGrok.java
 a8c4a7a 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerFilterJson.java
 3c0ed17 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerFilterKeyValue.java
 dcee25d 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerInput.java
 fe83fe4 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerInputConfig.java
 e3dc0d1 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerInputDeserializer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerInputFile.java
 5c547ad 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerInputFileBase.java
 df21d0d 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerInputS3File.java
 8e9acf0 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilter.java
 2a00802 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerLogLevelFilterMap.java
 3088db1 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerMapDate.java
 dcacceb 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerMapFieldCopy.java
 b0bea83 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerMapFieldName.java
 000b29d 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerMapFieldValue.java
 6152de5 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerPostMapValues.java
 5f361c9 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/model/common/LSServerPostMapValuesDeserializer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-server/src/main/java/org/apache/ambari/logsearch/rest/ShipperConfigResource.java
 a7d99c9 


Diff: https://reviews.apache.org/r/59563/diff/1/


Testing
---

Tested in local docker environment.


Thanks,

Miklos Gergely

Re: Review Request 59532: Add Confirmation pop up for 'Generate Blueprint' button

[Sangeeta Ravindran]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59532/#review176025
---


Ship it!




Ship It!

- Sangeeta Ravindran


On May 24, 2017, 10:43 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59532/
> ---
> 
> (Updated May 24, 2017, 10:43 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-21104
> https://issues.apache.org/jira/browse/AMBARI-21104
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Confirmation pop up for 'Generate Blueprint' button.
> Notify user that two files will be downloaded and provide information on how 
> to use those files.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step8_controller.js f2b4ca77c9 
>   ambari-web/app/messages.js 0c15a1935e 
>   ambari-web/app/templates/wizard/step8.hbs 907b3d4bbf 
> 
> 
> Diff: https://reviews.apache.org/r/59532/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually. Attached image of the Confirmation box.
> 
> 
> File Attachments
> 
> 
> Confirmation pop up
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/24/b708ef1d-6a7f-4525-9dee-ecb11ab6d5fa__Snip20170524_9.png
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 59485: Edit notifications options are always grey but can click and open a popup

[yao lei]

> On 五月 23, 2017, 11:41 a.m., Alexandr Antonenko wrote:
> > Ship It!
> 
> yao lei wrote:
> Thanks for your review

Hi Alexandr Antonenko,
Would you please commit this patch if you are free?
Thanks.


- yao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59485/#review175785
---


On 五月 23, 2017, 8:10 a.m., yao lei wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59485/
> ---
> 
> (Updated 五月 23, 2017, 8:10 a.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Zhe (Joe) Wang, Richard Zang, 
> and Yusaku Sako.
> 
> 
> Bugs: AMBARI-21097
> https://issues.apache.org/jira/browse/AMBARI-21097
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> 1.Open Alerts / Actions / Manage Alert Notifications
> 2.Create an alert notification named test
> 3.Select the created notification and click gear icon, you will find 
> Edit/Duplicate items are always grey but you can click and open a popup.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/mappers/alert_notification_mapper.js 037c418 
>   ambari-web/app/models/alerts/alert_notification.js c2d7570 
> 
> 
> Diff: https://reviews.apache.org/r/59485/diff/1/
> 
> 
> Testing
> ---
> 
> 1.cd ambari-web  & mvn test
> 30383 passing (34s)
> 157 pending
> 
> 2.Tested in a cluster
> 
> 
> Thanks,
> 
> yao lei
> 
>

Re: Review Request 59532: Add Confirmation pop up for 'Generate Blueprint' button

[Amruta Borkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59532/
---

(Updated May 24, 2017, 10:43 p.m.)


Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran.


Bugs: AMBARI-21104
https://issues.apache.org/jira/browse/AMBARI-21104


Repository: ambari


Description
---

Add Confirmation pop up for 'Generate Blueprint' button.
Notify user that two files will be downloaded and provide information on how to 
use those files.


Diffs
-

  ambari-web/app/controllers/wizard/step8_controller.js f2b4ca77c9 
  ambari-web/app/messages.js 0c15a1935e 
  ambari-web/app/templates/wizard/step8.hbs 907b3d4bbf 


Diff: https://reviews.apache.org/r/59532/diff/2/


Testing
---

Tested manually. Attached image of the Confirmation box.


File Attachments (updated)


Confirmation pop up
  
https://reviews.apache.org/media/uploaded/files/2017/05/24/b708ef1d-6a7f-4525-9dee-ecb11ab6d5fa__Snip20170524_9.png


Thanks,

Amruta Borkar

Re: Review Request 59418: Add ability to sink Raw metrics to external system via Http

[Sid Wagle]

> On May 24, 2017, 10:36 p.m., Aravindan Vijayan wrote:
> > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/sink/ExternalMetricsSink.java
> > Lines 47 (patched)
> > 
> >
> > Does this have to be Collection? I see that in the 
> > CacheManager, we populate only a single TimelineMetrics object and send as 
> > a Singleton List.

Actually I do not recollect why this was a collection, I preserved the same 
contract as the write to Phoenix.


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59418/#review176007
---


On May 19, 2017, 8:43 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59418/
> ---
> 
> (Updated May 19, 2017, 8:43 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21079
> https://issues.apache.org/jira/browse/AMBARI-21079
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Define interface to add MetricsSources to AMS
> - Define sink interfaces
> - Add caching layer to allow flush interval to be different from sink 
> interval.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-common/pom.xml 62ae75f 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsEhCacheSizeOfEngine.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java
>  1ca9c33 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  f984253 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  3b2a119 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  023465b 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregator.java
>  ba16b43 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TimelineMetricMetadataManager.java
>  f904ebe 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/sink/DefaultFSSinkProvider.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/sink/ExternalMetricsSink.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/sink/ExternalSinkProvider.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/sink/HttpSinkProvider.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/DefaultInternalMetricsSourceProvider.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/InternalMetricsSource.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/InternalSourceProvider.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/RawMetricsSource.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/cache/InternalMetricCacheKey.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/cache/InternalMetricCacheValue.java
>  PRE-CREATION 
>   
> 

Re: Review Request 59418: Add ability to sink Raw metrics to external system via Http

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59418/#review176010
---


Ship it!




Ship It!

- Aravindan Vijayan


On May 19, 2017, 8:43 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59418/
> ---
> 
> (Updated May 19, 2017, 8:43 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21079
> https://issues.apache.org/jira/browse/AMBARI-21079
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Define interface to add MetricsSources to AMS
> - Define sink interfaces
> - Add caching layer to allow flush interval to be different from sink 
> interval.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-common/pom.xml 62ae75f 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsEhCacheSizeOfEngine.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java
>  1ca9c33 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  f984253 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  3b2a119 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  023465b 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregator.java
>  ba16b43 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TimelineMetricMetadataManager.java
>  f904ebe 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/sink/DefaultFSSinkProvider.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/sink/ExternalMetricsSink.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/sink/ExternalSinkProvider.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/sink/HttpSinkProvider.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/DefaultInternalMetricsSourceProvider.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/InternalMetricsSource.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/InternalSourceProvider.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/RawMetricsSource.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/cache/InternalMetricCacheKey.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/cache/InternalMetricCacheValue.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/cache/InternalMetricsCache.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/cache/InternalMetricsCacheProvider.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/cache/InternalMetricsCacheSizeOfEngine.java
>  PRE-CREATION 
>   
> 

Re: Review Request 59418: Add ability to sink Raw metrics to external system via Http

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59418/#review176007
---




ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/sink/ExternalMetricsSink.java
Lines 47 (patched)


Does this have to be Collection? I see that in the 
CacheManager, we populate only a single TimelineMetrics object and send as a 
Singleton List.


- Aravindan Vijayan


On May 19, 2017, 8:43 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59418/
> ---
> 
> (Updated May 19, 2017, 8:43 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-21079
> https://issues.apache.org/jira/browse/AMBARI-21079
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> - Define interface to add MetricsSources to AMS
> - Define sink interfaces
> - Add caching layer to allow flush interval to be different from sink 
> interval.
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-common/pom.xml 62ae75f 
>   
> ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/cache/TimelineMetricsEhCacheSizeOfEngine.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/ApplicationHistoryServer.java
>  1ca9c33 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricStore.java
>  f984253 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
>  3b2a119 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  023465b 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/aggregators/TimelineMetricClusterAggregator.java
>  ba16b43 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TimelineMetricMetadataManager.java
>  f904ebe 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/sink/DefaultFSSinkProvider.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/sink/ExternalMetricsSink.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/sink/ExternalSinkProvider.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/sink/HttpSinkProvider.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/DefaultInternalMetricsSourceProvider.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/InternalMetricsSource.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/InternalSourceProvider.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/RawMetricsSource.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/cache/InternalMetricCacheKey.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/cache/InternalMetricCacheValue.java
>  PRE-CREATION 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/source/cache/InternalMetricsCache.java
>  PRE-CREATION 
>   
> 

Re: Review Request 59532: Add Confirmation pop up for 'Generate Blueprint' button

[Amruta Borkar]

> On May 24, 2017, 8:24 p.m., Di Li wrote:
> > ambari-web/app/messages.js
> > Lines 974 (patched)
> > 
> >
> > Can we update the msg to the following (I removed details on how bp 
> > register rest call), where  is dynamically replaced by the cluster name 
> > the user typed in on the UI ?
> > 
> > ... ...
> > You will be downloading blueprint.json and clustertemplate.json to your 
> > local machine.
> > 
> > You can use them to deploy a cluster via AMBARI REST API. 
> > Update clustertemplate.json with a custom cluster name if you do not 
> > want to use .
> > 
> > If you want to use custom repo URLs, make sure to update them via 
> > Ambari REST API before deploying the cluster.

Hello Di, 
Please review the updated patch.


- Amruta


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59532/#review175987
---


On May 24, 2017, 10:17 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59532/
> ---
> 
> (Updated May 24, 2017, 10:17 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-21104
> https://issues.apache.org/jira/browse/AMBARI-21104
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Confirmation pop up for 'Generate Blueprint' button.
> Notify user that two files will be downloaded and provide information on how 
> to use those files.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step8_controller.js f2b4ca77c9 
>   ambari-web/app/messages.js 0c15a1935e 
>   ambari-web/app/templates/wizard/step8.hbs 907b3d4bbf 
> 
> 
> Diff: https://reviews.apache.org/r/59532/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually. Attached image of the Confirmation box.
> 
> 
> File Attachments
> 
> 
> Generate_blueprint_confirmation
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/24/0c9086f1-b97b-4c2e-ac6b-d0666df7dfa0__Generate_blueprint_confirmation.png
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 59532: Add Confirmation pop up for 'Generate Blueprint' button

[Amruta Borkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59532/
---

(Updated May 24, 2017, 10:17 p.m.)


Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran.


Bugs: AMBARI-21104
https://issues.apache.org/jira/browse/AMBARI-21104


Repository: ambari


Description
---

Add Confirmation pop up for 'Generate Blueprint' button.
Notify user that two files will be downloaded and provide information on how to 
use those files.


Diffs (updated)
-

  ambari-web/app/controllers/wizard/step8_controller.js f2b4ca77c9 
  ambari-web/app/messages.js 0c15a1935e 
  ambari-web/app/templates/wizard/step8.hbs 907b3d4bbf 


Diff: https://reviews.apache.org/r/59532/diff/2/

Changes: https://reviews.apache.org/r/59532/diff/1-2/


Testing
---

Tested manually. Attached image of the Confirmation box.


File Attachments


Generate_blueprint_confirmation
  
https://reviews.apache.org/media/uploaded/files/2017/05/24/0c9086f1-b97b-4c2e-ac6b-d0666df7dfa0__Generate_blueprint_confirmation.png


Thanks,

Amruta Borkar

Re: Review Request 59503: Create custom admin user during ambari server setup

[Anita Jebaraj]

> On May 24, 2017, 3:37 p.m., Robert Levas wrote:
> > This update will create a security issue.  We need to ensure that an admin 
> > user is only created once via this script.  This should occur during the 
> > *first* call to `ambari-server setup` - which is expected to be done by a 
> > system administrator - ideally `root`.  After that, `ambari-server` may be 
> > exectued by another user, if an alternate user is set to execute Ambari. 
> > 
> > If a non-administrative user can execute `ambari-server setup` and that 
> > user is allowed to set or update users in the Ambari database (without 
> > first being authenticated by Ambari), then users other than Ambari 
> > Administrators can effectively manage Ambari users. We should not allow 
> > this to happen.
> > 
> > I think that if we want to allow this feature, we need to first query the 
> > Ambari database to see if there is already a user with administrator 
> > privileges.  If not, then the setup script should be allowed to create the 
> > first Ambari Administrator account. If one exists, than the setup script 
> > should not be allowed to create new or update existing users in the 
> > database. Because `org.apache.ambari.server.controller.CreateUserHelper` is 
> > an executable class, the check needs to be done there to ensure OS-level 
> > users with the ability to read this class do not gain the ability to create 
> > (and possibly update) Ambari user accounts while by-passing needed 
> > authorization checks.

Thank you Robert for your suggestions, 

I have modified the implementation so for the first time the ambari-server 
setup is run the admin user gets created and the create.admin.flag is set to 
true in ambari.properties. If the class CreateUserHelper is executed, it looks 
if admin user exists and it fails there, so the users cannot be 
modified/created just by executing the class later. Even if the 
create.admin.flag in ambari.properties is switched to false and ambari-server 
setup is run, new admin user cannot be created, since it looks for existing 
admin users and it fails with the message "User cannot be created, Admin user 
already exists, login to Ambari UI to create/modify users"


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59503/#review175942
---


On May 24, 2017, 8:40 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59503/
> ---
> 
> (Updated May 24, 2017, 8:40 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, 
> Robert Levas, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21083
> https://issues.apache.org/jira/browse/AMBARI-21083
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Provide the ability to create custom admin user during ambari server setup, 
> so that the user will have the option to either create the admin user with 
> the username/password of their preference or can use the default username.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/configuration/index.md ff9ce54 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  114046f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/authorization/Users.java
>  9cdde8f 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 
>   ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59503/diff/3/
> 
> 
> Testing
> ---
> 
> Added 1 test case
> 
> 
> Ran mvn test
> 
> 
> File Attachments
> 
> 
> custom_admin.PNG
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 59532: Add Confirmation pop up for 'Generate Blueprint' button

[Di Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59532/#review175987
---




ambari-web/app/messages.js
Lines 974 (patched)


Can we update the msg to the following (I removed details on how bp 
register rest call), where  is dynamically replaced by the cluster name the 
user typed in on the UI ?

... ...
You will be downloading blueprint.json and clustertemplate.json to your 
local machine.

You can use them to deploy a cluster via AMBARI REST API. 
Update clustertemplate.json with a custom cluster name if you do not want 
to use .

If you want to use custom repo URLs, make sure to update them via Ambari 
REST API before deploying the cluster.


- Di Li


On May 24, 2017, 7:30 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59532/
> ---
> 
> (Updated May 24, 2017, 7:30 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-21104
> https://issues.apache.org/jira/browse/AMBARI-21104
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add Confirmation pop up for 'Generate Blueprint' button.
> Notify user that two files will be downloaded and provide information on how 
> to use those files.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 
> f2b4ca77c9260ba123fdc165d680100f15641c22 
>   ambari-web/app/messages.js 0c15a1935e5109689678e46eea01bfde532ce0e7 
>   ambari-web/app/templates/wizard/step8.hbs 
> 907b3d4bbfc859020f553b282452dd5f62cb9725 
> 
> 
> Diff: https://reviews.apache.org/r/59532/diff/1/
> 
> 
> Testing
> ---
> 
> Tested manually. Attached image of the Confirmation box.
> 
> 
> File Attachments
> 
> 
> Generate_blueprint_confirmation
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/24/0c9086f1-b97b-4c2e-ac6b-d0666df7dfa0__Generate_blueprint_confirmation.png
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Review Request 59532: Add Confirmation pop up for 'Generate Blueprint' button

[Amruta Borkar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59532/
---

Review request for Ambari, Alexandr Antonenko, Di Li, and Sangeeta Ravindran.


Bugs: AMBARI-21104
https://issues.apache.org/jira/browse/AMBARI-21104


Repository: ambari


Description
---

Add Confirmation pop up for 'Generate Blueprint' button.
Notify user that two files will be downloaded and provide information on how to 
use those files.


Diffs
-

  ambari-web/app/controllers/wizard/step8_controller.js 
f2b4ca77c9260ba123fdc165d680100f15641c22 
  ambari-web/app/messages.js 0c15a1935e5109689678e46eea01bfde532ce0e7 
  ambari-web/app/templates/wizard/step8.hbs 
907b3d4bbfc859020f553b282452dd5f62cb9725 


Diff: https://reviews.apache.org/r/59532/diff/1/


Testing
---

Tested manually. Attached image of the Confirmation box.


File Attachments


Generate_blueprint_confirmation
  
https://reviews.apache.org/media/uploaded/files/2017/05/24/0c9086f1-b97b-4c2e-ac6b-d0666df7dfa0__Generate_blueprint_confirmation.png


Thanks,

Amruta Borkar

Re: Review Request 59535: Setting yarn.node-labels.fs-store.root-dir to a "path" changes the permission of the "root path"

[Mahadev Konar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59535/#review175975
---


Ship it!




Ship It!

- Mahadev Konar


On May 24, 2017, 6:55 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59535/
> ---
> 
> (Updated May 24, 2017, 6:55 p.m.)
> 
> 
> Review request for Ambari and Mahadev Konar.
> 
> 
> Bugs: AMBARI-21116
> https://issues.apache.org/jira/browse/AMBARI-21116
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1\. Set the following configs to run nodeLabels test via Ambari Rest Call
> 
> 
> 
> 
>  yarnProperties = {'yarn.acl.enable': 'true',
>   'yarn.node-labels.enabled' : "True",
>   'yarn.node-labels.fs-store.root-dir': 
> NODE_LABEL_STORE_DIR,
>   'yarn.admin.acl': yarn_user + ',' + qa_user}
> 
> 
> where NODE_LABEL_STORE_DIR = "/tmp/node-labels"  
> 2Restart ResourceManager and NodeManagers via ambari  
> 3\. After running these commands, /tmp directory's permission changes to  
> [drwx-- - yarn hadoop]BUG/drwx-
> -+++-+yarn+++hadoop) from [drwxrwxrwx - hdfs hadoop 
> drwxrwxrwx+++-+hdfs+++hadoop) causing other tests to
> fail since it cannot access /tmp
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  3e5c51d 
> 
> 
> Diff: https://reviews.apache.org/r/59535/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 59535: Setting yarn.node-labels.fs-store.root-dir to a "path" changes the permission of the "root path"

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59535/#review175973
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Травень 24, 2017, 6:43 після полудня, Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59535/
> ---
> 
> (Updated Травень 24, 2017, 6:43 після полудня)
> 
> 
> Review request for Ambari and Mahadev Konar.
> 
> 
> Bugs: AMBARI-21115
> https://issues.apache.org/jira/browse/AMBARI-21115
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> 1\. Set the following configs to run nodeLabels test via Ambari Rest Call
> 
> 
> 
> 
>  yarnProperties = {'yarn.acl.enable': 'true',
>   'yarn.node-labels.enabled' : "True",
>   'yarn.node-labels.fs-store.root-dir': 
> NODE_LABEL_STORE_DIR,
>   'yarn.admin.acl': yarn_user + ',' + qa_user}
> 
> 
> where NODE_LABEL_STORE_DIR = "/tmp/node-labels"  
> 2Restart ResourceManager and NodeManagers via ambari  
> 3\. After running these commands, /tmp directory's permission changes to  
> [drwx-- - yarn hadoop]BUG/drwx-
> -+++-+yarn+++hadoop) from [drwxrwxrwx - hdfs hadoop 
> drwxrwxrwx+++-+hdfs+++hadoop) causing other tests to
> fail since it cannot access /tmp
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  3e5c51d 
> 
> 
> Diff: https://reviews.apache.org/r/59535/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 59535: Setting yarn.node-labels.fs-store.root-dir to a "path" changes the permission of the "root path"

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59535/
---

(Updated May 24, 2017, 6:55 p.m.)


Review request for Ambari and Mahadev Konar.


Bugs: AMBARI-21116
https://issues.apache.org/jira/browse/AMBARI-21116


Repository: ambari


Description
---

1\. Set the following configs to run nodeLabels test via Ambari Rest Call




 yarnProperties = {'yarn.acl.enable': 'true',
  'yarn.node-labels.enabled' : "True",
  'yarn.node-labels.fs-store.root-dir': 
NODE_LABEL_STORE_DIR,
  'yarn.admin.acl': yarn_user + ',' + qa_user}


where NODE_LABEL_STORE_DIR = "/tmp/node-labels"  
2Restart ResourceManager and NodeManagers via ambari  
3\. After running these commands, /tmp directory's permission changes to  
[drwx-- - yarn hadoop]BUG/drwx-
-+++-+yarn+++hadoop) from [drwxrwxrwx - hdfs hadoop 
drwxrwxrwx+++-+hdfs+++hadoop) causing other tests to
fail since it cannot access /tmp


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
 3e5c51d 


Diff: https://reviews.apache.org/r/59535/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 59534: Fix Unit Test Failures From Prior Patch/Service Upgrade Commits

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59534/#review175972
---


Ship it!




Ship It!

- Nate Cole


On May 24, 2017, 2:30 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59534/
> ---
> 
> (Updated May 24, 2017, 2:30 p.m.)
> 
> 
> Review request for Ambari and Nate Cole.
> 
> 
> Bugs: AMBARI-21114
> https://issues.apache.org/jira/browse/AMBARI-21114
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The following unit tests are failing in the patch upgrade feature branch:
> 
> ```
> Failed tests:
>   
> StackUpgradeConfigurationMergeTest.testMergedConfigurationsDoNotAddExplicitelyRemovedProperties:261
>  Nothing captured yet
>   UpgradeResourceProviderTest.testCreateResourcesWithAutoSkipAll:430 
> expected:<[Updating configuration zookeeper-newconfig]> but was:<[Skipping 
> Configuration Task hdp_2_1_1_zookeeper_new_config_type]>
>   UpgradeResourceProviderTest.testCreateResourcesWithAutoSkipFailures:333 
> expected:<[Updating configuration zookeeper-newconfig]> but was:<[Skipping 
> Configuration Task hdp_2_1_1_zookeeper_new_config_type]>
>   
> UpgradeResourceProviderTest.testCreateResourcesWithAutoSkipManualVerification:383
>  expected:<[Updating configuration zookeeper-newconfig]> but was:<[Skipping 
> Configuration Task hdp_2_1_1_zookeeper_new_config_type]>
>   
> UpgradeResourceProviderTest.testUpdateSkipFailures:1328->testCreateResourcesWithAutoSkipFailures:333
>  expected:<[Updating configuration zookeeper-newconfig]> but was:<[Skipping 
> Configuration Task hdp_2_1_1_zookeeper_new_config_type]>
>   UpgradeResourceProviderTest.testUpgradeHistory:1622 Implement me!
>   UpgradeActionTest.testExpressUpgradeUpdateDesiredStackAction:455 null
>   UpgradeActionTest.testFinalizeDowngradeAcrossStacks:742 
> expected:<[COMPLET]ED> but was:<[FAIL]ED>
>   
> UpgradeActionTest.testFinalizeDowngradeWhenDidNotFinalizePreviousUpgrade:535 
> expected:<[FAIL]ED> but was:<[COMPLET]ED>
>   UpgradeActionTest.testFinalizeUpgradeAcrossStacks:665 
> expected:<[COMPLET]ED> but was:<[FAIL]ED>
>   UpgradeActionTest.testFinalizeUpgradeWithClusterStateInconsistencies:832 
> expected:<[COMPLET]ED> but was:<[FAIL]ED>
>   UpgradeHelperTest.testCompleteUpgradeOrchestration:377 expected:<[Service 
> Check Zk]> but was:<[Completing ZooKeeper1 Server2 on 192.168.64.1]>
>   UpgradeHelperTest.testPartialUpgradeOrchestration:312 expected:<3> but 
> was:<0>
>   UpgradeHelperTest.testServiceCheckUpgradeStages:1073 expected:<6> but 
> was:<7>
> 
> Tests in error:
>   UpgradeResourceProviderTest.testCreatePartialDowngrade:649 » NoSuchElement
>   UpgradeResourceProviderTest.testMergeConfigurations:1201 » IllegalState 
> missin...
>   
> ComponentVersionCheckActionTest.testMixedComponentVersions:341->createNewRepoVersion:273
>  » Ambari
>   
> UpgradeActionTest.testFinalizeUpgrade:548->createUpgradeClusterTargetRepo:303 
> » Ambari
>   
> UpgradeActionTest.testFinalizeWithHostsAlreadyCurrent:589->createUpgradeClusterTargetRepo:303
>  » Ambari
>   UpgradeHelperTest.testHostGroupingOrchestration:2133 » IllegalState missing 
> be...
>   UpgradeHelperTest.testOrchestrationNoServerSideOnDowngrade:1851 » 
> IllegalState
>   UpgradeHelperTest.testResolverBadJmx:1713 » IllegalState missing behavior 
> defi...
>   UpgradeHelperTest.testResolverCaseInsensitive:1644 » IllegalState missing 
> beha...
>   UpgradeHelperTest.testResolverWithFailedUpgrade:1569 » IllegalState missing 
> be...
>   UpgradeHelperTest.testUpgradeOrchestrationWithHostsInMM:465 » IllegalState 
> mis...
> ```
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/api/generated/index.html 1771346e3a 
>   ambari-server/docs/api/generated/swagger.json f7dbb6bd0e 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
>  04773bcfb3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
>  f306d69e58 
> 
> 
> Diff: https://reviews.apache.org/r/59534/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>

Re: Review Request 59491: AMBARI-19149. Code cleanup: identical catch blocks

[Nate Cole]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59491/#review175970
---


Ship it!




Ship It!

- Nate Cole


On May 23, 2017, 12:35 p.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59491/
> ---
> 
> (Updated May 23, 2017, 12:35 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-19149
> https://issues.apache.org/jira/browse/AMBARI-19149
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Utilize 
> [multi-catch](http://docs.oracle.com/javase/7/docs/technotes/guides/language/catch-multiple.html),
>  available since Java 7
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/ServiceComponentHostEventWrapper.java
>  83bee656cc1e4f9014bfe396eafe371e242bae26 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/handlers/UpdateHandler.java
>  7f6a484431c62277b6296b55075e2901489a633e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/query/render/ClusterBlueprintRenderer.java
>  31cb0618de7743dc74378f75bbfeb3a8965b1994 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/DatabaseConsistencyCheckHelper.java
>  7c40c8396cda807a6a01cda6b085d6b32f510b6e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  9bc7f4a8686d128d0f51c764359cb8c41eff1b35 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  4ad01a54a742db090a2cb9d7b7b04c688cd33fa4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  f8016a5f418e56c13bcd38ca1bdb3fadd7a2257f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDependencyResourceProvider.java
>  bc7492cc35221cad740a71fb55d14e5b329b42fd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/helpers/ScriptRunner.java
>  1afd638d347e19d4fdb98696d7a6ffd29a9abd31 
>   
> ambari-server/src/main/java/org/apache/ambari/server/scheduler/ExecutionScheduleManager.java
>  cab467fd4701589ab488b9f50315aa576483757e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/encryption/AESEncryptor.java
>  400cdafafba8bcb3c41efb76ac8e7aac40eda5d1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/security/encryption/MasterKeyServiceImpl.java
>  1d6b73d9a573d53961d6be3f5639d2e0ebedd0ea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java
>  cd191744311e7f84fa580ddae1ef77ca7d934c27 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/IPAKerberosOperationHandler.java
>  5923b7249739c18c27077679ce0e2d9aa91b0271 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java
>  eea5071819627f5e94322ed7954851354d0693df 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/ClusterConfigurationRequest.java
>  ed25aea3d4f46b45df9698eb7655e60230377688 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/TopologyManager.java
>  14bc446a7ceb05a1d1eca2fb9a06b5b216ab38e9 
>   ambari-server/src/main/java/org/apache/ambari/server/utils/HTTPUtils.java 
> 850a40ba2af9d8d15f345af5c23e38018664dc13 
>   
> ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java
>  a4408de6affc43a9dd7d9fe879a4f925e1cd5e22 
>   
> ambari-server/src/test/java/org/apache/ambari/server/agent/LocalAgentSimulator.java
>  892a1f571a1135fa83e5736310b83107b2b5612e 
> 
> 
> Diff: https://reviews.apache.org/r/59491/diff/1/
> 
> 
> Testing
> ---
> 
> ```
> Tests run: 4981, Failures: 0, Errors: 0, Skipped: 39
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Review Request 59535: Setting yarn.node-labels.fs-store.root-dir to a "path" changes the permission of the "root path"

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59535/
---

Review request for Ambari and Mahadev Konar.


Bugs: AMBARI-21115
https://issues.apache.org/jira/browse/AMBARI-21115


Repository: ambari


Description
---

1\. Set the following configs to run nodeLabels test via Ambari Rest Call




 yarnProperties = {'yarn.acl.enable': 'true',
  'yarn.node-labels.enabled' : "True",
  'yarn.node-labels.fs-store.root-dir': 
NODE_LABEL_STORE_DIR,
  'yarn.admin.acl': yarn_user + ',' + qa_user}


where NODE_LABEL_STORE_DIR = "/tmp/node-labels"  
2Restart ResourceManager and NodeManagers via ambari  
3\. After running these commands, /tmp directory's permission changes to  
[drwx-- - yarn hadoop]BUG/drwx-
-+++-+yarn+++hadoop) from [drwxrwxrwx - hdfs hadoop 
drwxrwxrwx+++-+hdfs+++hadoop) causing other tests to
fail since it cannot access /tmp


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
 3e5c51d 


Diff: https://reviews.apache.org/r/59535/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Review Request 59534: Fix Unit Test Failures From Prior Patch/Service Upgrade Commits

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59534/
---

Review request for Ambari and Nate Cole.


Bugs: AMBARI-21114
https://issues.apache.org/jira/browse/AMBARI-21114


Repository: ambari


Description
---

The following unit tests are failing in the patch upgrade feature branch:

```
Failed tests:
  
StackUpgradeConfigurationMergeTest.testMergedConfigurationsDoNotAddExplicitelyRemovedProperties:261
 Nothing captured yet
  UpgradeResourceProviderTest.testCreateResourcesWithAutoSkipAll:430 
expected:<[Updating configuration zookeeper-newconfig]> but was:<[Skipping 
Configuration Task hdp_2_1_1_zookeeper_new_config_type]>
  UpgradeResourceProviderTest.testCreateResourcesWithAutoSkipFailures:333 
expected:<[Updating configuration zookeeper-newconfig]> but was:<[Skipping 
Configuration Task hdp_2_1_1_zookeeper_new_config_type]>
  
UpgradeResourceProviderTest.testCreateResourcesWithAutoSkipManualVerification:383
 expected:<[Updating configuration zookeeper-newconfig]> but was:<[Skipping 
Configuration Task hdp_2_1_1_zookeeper_new_config_type]>
  
UpgradeResourceProviderTest.testUpdateSkipFailures:1328->testCreateResourcesWithAutoSkipFailures:333
 expected:<[Updating configuration zookeeper-newconfig]> but was:<[Skipping 
Configuration Task hdp_2_1_1_zookeeper_new_config_type]>
  UpgradeResourceProviderTest.testUpgradeHistory:1622 Implement me!
  UpgradeActionTest.testExpressUpgradeUpdateDesiredStackAction:455 null
  UpgradeActionTest.testFinalizeDowngradeAcrossStacks:742 
expected:<[COMPLET]ED> but was:<[FAIL]ED>
  UpgradeActionTest.testFinalizeDowngradeWhenDidNotFinalizePreviousUpgrade:535 
expected:<[FAIL]ED> but was:<[COMPLET]ED>
  UpgradeActionTest.testFinalizeUpgradeAcrossStacks:665 expected:<[COMPLET]ED> 
but was:<[FAIL]ED>
  UpgradeActionTest.testFinalizeUpgradeWithClusterStateInconsistencies:832 
expected:<[COMPLET]ED> but was:<[FAIL]ED>
  UpgradeHelperTest.testCompleteUpgradeOrchestration:377 expected:<[Service 
Check Zk]> but was:<[Completing ZooKeeper1 Server2 on 192.168.64.1]>
  UpgradeHelperTest.testPartialUpgradeOrchestration:312 expected:<3> but was:<0>
  UpgradeHelperTest.testServiceCheckUpgradeStages:1073 expected:<6> but was:<7>

Tests in error:
  UpgradeResourceProviderTest.testCreatePartialDowngrade:649 » NoSuchElement
  UpgradeResourceProviderTest.testMergeConfigurations:1201 » IllegalState 
missin...
  
ComponentVersionCheckActionTest.testMixedComponentVersions:341->createNewRepoVersion:273
 » Ambari
  UpgradeActionTest.testFinalizeUpgrade:548->createUpgradeClusterTargetRepo:303 
» Ambari
  
UpgradeActionTest.testFinalizeWithHostsAlreadyCurrent:589->createUpgradeClusterTargetRepo:303
 » Ambari
  UpgradeHelperTest.testHostGroupingOrchestration:2133 » IllegalState missing 
be...
  UpgradeHelperTest.testOrchestrationNoServerSideOnDowngrade:1851 » IllegalState
  UpgradeHelperTest.testResolverBadJmx:1713 » IllegalState missing behavior 
defi...
  UpgradeHelperTest.testResolverCaseInsensitive:1644 » IllegalState missing 
beha...
  UpgradeHelperTest.testResolverWithFailedUpgrade:1569 » IllegalState missing 
be...
  UpgradeHelperTest.testUpgradeOrchestrationWithHostsInMM:465 » IllegalState 
mis...
```


Diffs
-

  ambari-server/docs/api/generated/index.html 1771346e3a 
  ambari-server/docs/api/generated/swagger.json f7dbb6bd0e 
  
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/UpgradeResourceProviderTest.java
 04773bcfb3 
  
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/UpgradeActionTest.java
 f306d69e58 


Diff: https://reviews.apache.org/r/59534/diff/1/


Testing
---


Thanks,

Jonathan Hurley

Re: Review Request 59522: ambari-server setup fails with default postgres

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59522/#review175958
---


Fix it, then Ship it!





ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py
Lines 63 (patched)


Why not make this 1 second sleep and 30 tries?


- Sid Wagle


On May 24, 2017, 10:09 a.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59522/
> ---
> 
> (Updated May 24, 2017, 10:09 a.m.)
> 
> 
> Review request for Ambari and Sid Wagle.
> 
> 
> Bugs: AMBARI-21110
> https://issues.apache.org/jira/browse/AMBARI-21110
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Thisis the first run with oracle12. Initially infra sets up Ambari with
> default postgres and later on ambari setup happens with Oracle12. But now the
> first setup with default postgres is failing with below error
> 
> 
> 
> 
> root@172.27.24.11 "ambari-server setup 
> --java-home=/base/tools/jdk1.8.0_112 -s"
> 2017-05-22 10:57:54.032 Using python  /usr/bin/python
> 2017-05-22 10:57:54.032 Setup ambari-server
> 2017-05-22 10:58:14.299 Checking SELinux...
> 2017-05-22 10:58:14.299 SELinux status is 'disabled'
> 2017-05-22 10:58:14.299 Customize user account for ambari-server daemon 
> [y/n] (n)? 
> 2017-05-22 10:58:14.299 Adjusting ambari-server permissions and 
> ownership...
> 2017-05-22 10:58:14.299 Checking firewall status...
> 2017-05-22 10:58:14.299 FATAL: Could not load 
> /lib/modules/3.10.0-327.13.1.el7.x86_64/modules.dep: No such file or directory
> 2017-05-22 10:58:14.299 iptables v1.4.7: can't initialize iptables table 
> `nat': Permission denied (you must be root)
> 2017-05-22 10:58:14.299 Perhaps iptables or your kernel needs to be 
> upgraded.
> 2017-05-22 10:58:14.299 FATAL: Could not load 
> /lib/modules/3.10.0-327.13.1.el7.x86_64/modules.dep: No such file or directory
> 2017-05-22 10:58:14.299 iptables v1.4.7: can't initialize iptables table 
> `filter': Permission denied (you must be root)
> 2017-05-22 10:58:14.299 Perhaps iptables or your kernel needs to be 
> upgraded.
> 2017-05-22 10:58:14.299 WARNING: iptables is running. Confirm the 
> necessary Ambari ports are accessible. Refer to the Ambari documentation for 
> more details on ports.
> 2017-05-22 10:58:14.299 OK to continue [y/n] (y)? 
> 2017-05-22 10:58:14.299 Checking JDK...
> 2017-05-22 10:58:14.299 WARNING: JAVA_HOME /base/tools/jdk1.8.0_112 must 
> be valid on ALL hosts
> 2017-05-22 10:58:14.299 WARNING: JCE Policy files are required for 
> configuring Kerberos security. If you plan to use Kerberos,please make sure 
> JCE Unlimited Strength Jurisdiction Policy Files are valid on all hosts.
> 2017-05-22 10:58:14.299 Completing setup...
> 2017-05-22 10:58:14.299 Configuring database...
> 2017-05-22 10:58:14.299 Enter advanced database configuration [y/n] (n)? 
> 2017-05-22 10:58:14.299 Configuring database...
> 2017-05-22 10:58:14.299 Default properties detected. Using built-in 
> database.
> 2017-05-22 10:58:14.299 Configuring ambari database...
> 2017-05-22 10:58:14.299 Checking PostgreSQL...
> 2017-05-22 10:58:14.299 Running initdb: This may take up to a minute.
> 2017-05-22 10:58:14.299 Initializing database: [  OK  ]
> 2017-05-22 10:58:14.299 
> 2017-05-22 10:58:14.299 About to start PostgreSQL
> 2017-05-22 10:58:14.299 Configuring local database...
> 2017-05-22 10:58:14.299 Configuring PostgreSQL...
> 2017-05-22 10:58:14.299 Creating schema and user...
> 2017-05-22 10:58:14.299 ERROR: Failed to execute 
> command:['ambari-sudo.sh', 'su', 'postgres', '-', '--command=psql -f 
> /var/lib/ambari-server/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql -v 
> username=\'"ambari"\' -v password="\'bigdata\'" -v dbname="ambari"']
> 2017-05-22 10:58:14.299 ERROR: stderr:could not change directory to 
> "/root"
> 2017-05-22 10:58:14.299 psql: could not connect to server: No such file 
> or directory
> 2017-05-22 10:58:14.299   Is the server running locally and accepting
> 2017-05-22 10:58:14.299   connections on Unix domain socket 
> "/tmp/.s.PGSQL.5432"?
> 2017-05-22 10:58:14.299 
> 2017-05-22 10:58:14.299 ERROR: stdout:
> 2017-05-22 10:58:14.299 failed to execute queries ...retrying (1)
> 2017-05-22 10:58:14.299 Creating schema and user...
> 2017-05-22 10:58:14.299 ERROR: Failed to execute 
> command:['ambari-sudo.sh', 'su', 'postgres', '-', '--command=psql -f 
> /var/lib/ambari-server/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql -v 
> username=\'"ambari"\' -v 

Re: Review Request 59496: Enable opening views in a new tab

[Anita Jebaraj]

> On May 24, 2017, 4:31 p.m., Sangeeta Ravindran wrote:
> > Ship It!

Hi Sangeeta, can you please help pushing the changes?


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59496/#review175952
---


On May 23, 2017, 6:58 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59496/
> ---
> 
> (Updated May 23, 2017, 6:58 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, DIPAYAN BHOWMICK, 
> Pallav Kulshreshtha, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-21095
> https://issues.apache.org/jira/browse/AMBARI-21095
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enable views to be opened in a new tab instead of being opened in the same 
> tab, this would help in going between the different tabs to look for 
> information or for config updates in the services.
> 
> 
> Diffs
> -
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/index.html 32f9ba7 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html 
> b6ec61d 
>   ambari-web/app/controllers/main/views_controller.js 398cdd8 
>   ambari-web/app/models/view_instance.js d438640 
>   ambari-web/test/controllers/main/views_controller_test.js 0ab7654 
>   ambari-web/test/models/view_instance_test.js 0e977e3 
> 
> 
> Diff: https://reviews.apache.org/r/59496/diff/1/
> 
> 
> Testing
> ---
> 
> Modified the test cases,
> 
> Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 59527: HDP 3.0 TP - create Service Advisor for Zeppelin

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59527/#review175953
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 24, 2017, 1:43 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59527/
> ---
> 
> (Updated May 24, 2017, 1:43 p.m.)
> 
> 
> Review request for Ambari and Alejandro Fernandez.
> 
> 
> Bugs: AMBARI-21112
> https://issues.apache.org/jira/browse/AMBARI-21112
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> create Service Advisor for Zeppelin
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/service_advisor.py
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59527/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 59496: Enable opening views in a new tab

[Sangeeta Ravindran]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59496/#review175952
---


Ship it!




Ship It!

- Sangeeta Ravindran


On May 23, 2017, 6:58 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59496/
> ---
> 
> (Updated May 23, 2017, 6:58 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, DIPAYAN BHOWMICK, 
> Pallav Kulshreshtha, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-21095
> https://issues.apache.org/jira/browse/AMBARI-21095
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enable views to be opened in a new tab instead of being opened in the same 
> tab, this would help in going between the different tabs to look for 
> information or for config updates in the services.
> 
> 
> Diffs
> -
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/index.html 32f9ba7 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html 
> b6ec61d 
>   ambari-web/app/controllers/main/views_controller.js 398cdd8 
>   ambari-web/app/models/view_instance.js d438640 
>   ambari-web/test/controllers/main/views_controller_test.js 0ab7654 
>   ambari-web/test/models/view_instance_test.js 0e977e3 
> 
> 
> Diff: https://reviews.apache.org/r/59496/diff/1/
> 
> 
> Testing
> ---
> 
> Modified the test cases,
> 
> Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 59520: Custom RM principal causes zookeeper HA state store to be inaccessible

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59520/#review175949
---


Ship it!




Ship It!

- Alejandro Fernandez


On May 24, 2017, 9:32 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59520/
> ---
> 
> (Updated May 24, 2017, 9:32 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Robert Levas, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20877
> https://issues.apache.org/jira/browse/AMBARI-20877
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDP 2.6 stack introduced settings for ACLs on the Yarn Resource Manager HA 
> state store. In `yarn-site/yarn.resourcemanager.zk-acl` the ACL user is set 
> to `rm`.
> If this user name does not match the primary component of the Yarn RM 
> Kerberos principal in `yarn-site/yarn.resourcemanager.principal`, then Yarn 
> is unable to access the state store and RM will stop immediately after start.
> During the Kerberos wizard there needs to be a check to see if these settings 
> are out of sync. Or, the zk-acl setting needs to somehow reference the 
> principal and extract the primary root through a variable.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/resource_management/TestSecurityCommons.py 
> 870ca92 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py
>  9ceeea7 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  3579fcb 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 
> ae4db4f 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py
>  66194ed 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/kerberos.json 
> ae4db4f 
> 
> 
> Diff: https://reviews.apache.org/r/59520/diff/1/
> 
> 
> Testing
> ---
> 
> - Create a cluster with yarn, hdfs
> - enabled kerberos using custom principal names
> - checked custom principal names in hadoop.registry.system.accounts and 
> yarn.resourcemanager.zk-acl properties in yarn config
> 
> 
> Tests: PENDING
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 59520: Custom RM principal causes zookeeper HA state store to be inaccessible

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59520/#review175943
---


Fix it, then Ship it!




Ship It!


ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py
Lines 288 (patched)


Can you add docs to this?


- Robert Levas


On May 24, 2017, 5:32 a.m., Attila Magyar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59520/
> ---
> 
> (Updated May 24, 2017, 5:32 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Robert Levas, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20877
> https://issues.apache.org/jira/browse/AMBARI-20877
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HDP 2.6 stack introduced settings for ACLs on the Yarn Resource Manager HA 
> state store. In `yarn-site/yarn.resourcemanager.zk-acl` the ACL user is set 
> to `rm`.
> If this user name does not match the primary component of the Yarn RM 
> Kerberos principal in `yarn-site/yarn.resourcemanager.principal`, then Yarn 
> is unable to access the state store and RM will stop immediately after start.
> During the Kerberos wizard there needs to be a check to see if these settings 
> are out of sync. Or, the zk-acl setting needs to somehow reference the 
> principal and extract the primary root through a variable.
> 
> 
> Diffs
> -
> 
>   ambari-agent/src/test/python/resource_management/TestSecurityCommons.py 
> 870ca92 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py
>  9ceeea7 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  3579fcb 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 
> ae4db4f 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py
>  66194ed 
>   ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/kerberos.json 
> ae4db4f 
> 
> 
> Diff: https://reviews.apache.org/r/59520/diff/1/
> 
> 
> Testing
> ---
> 
> - Create a cluster with yarn, hdfs
> - enabled kerberos using custom principal names
> - checked custom principal names in hadoop.registry.system.accounts and 
> yarn.resourcemanager.zk-acl properties in yarn config
> 
> 
> Tests: PENDING
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Re: Review Request 59503: Create custom admin user during ambari server setup

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59503/#review175942
---



This update will create a security issue.  We need to ensure that an admin user 
is only created once via this script.  This should occur during the *first* 
call to `ambari-server setup` - which is expected to be done by a system 
administrator - ideally `root`.  After that, `ambari-server` may be exectued by 
another user, if an alternate user is set to execute Ambari. 

If a non-administrative user can execute `ambari-server setup` and that user is 
allowed to set or update users in the Ambari database (without first being 
authenticated by Ambari), then users other than Ambari Administrators can 
effectively manage Ambari users. We should not allow this to happen.

I think that if we want to allow this feature, we need to first query the 
Ambari database to see if there is already a user with administrator 
privileges.  If not, then the setup script should be allowed to create the 
first Ambari Administrator account. If one exists, than the setup script should 
not be allowed to create new or update existing users in the database. Because 
`org.apache.ambari.server.controller.CreateUserHelper` is an executable class, 
the check needs to be done there to ensure OS-level users with the ability to 
read this class do not gain the ability to create (and possibly update) Ambari 
user accounts while by-passing needed authorization checks.

- Robert Levas


On May 23, 2017, 7:26 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59503/
> ---
> 
> (Updated May 23, 2017, 7:26 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, 
> Robert Levas, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21083
> https://issues.apache.org/jira/browse/AMBARI-21083
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Provide the ability to create custom admin user during ambari server setup, 
> so that the user will have the option to either create the admin user with 
> the username/password of their preference or can use the default username.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  114046f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java
>  PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 
>   ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59503/diff/2/
> 
> 
> Testing
> ---
> 
> Added 1 test case
> 
> 
> Ran mvn test
> 
> 
> File Attachments
> 
> 
> custom_admin.PNG
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 59526: Unable to upload table via Ambari Hive view if user does not have permission on default database

[venkat sairam]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59526/#review175938
---


Ship it!




Ship It!

- venkat sairam


On May 24, 2017, 1:36 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59526/
> ---
> 
> (Updated May 24, 2017, 1:36 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-21108
> https://issues.apache.org/jira/browse/AMBARI-21108
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive view 1.5 was using default DB for use statement in upload table feature. 
> corrected it to use selected database
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
>  a979dc9478 
> 
> 
> Diff: https://reviews.apache.org/r/59526/diff/1/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 59526: Unable to upload table via Ambari Hive view if user does not have permission on default database

[DIPAYAN BHOWMICK]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59526/#review175934
---


Ship it!




Ship It!

- DIPAYAN BHOWMICK


On May 24, 2017, 1:36 p.m., Nitiraj Rathore wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59526/
> ---
> 
> (Updated May 24, 2017, 1:36 p.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav 
> Kulshreshtha, Rohit Choudhary, and venkat sairam.
> 
> 
> Bugs: AMBARI-21108
> https://issues.apache.org/jira/browse/AMBARI-21108
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Hive view 1.5 was using default DB for use statement in upload table feature. 
> corrected it to use selected database
> 
> 
> Diffs
> -
> 
>   
> contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
>  a979dc9478 
> 
> 
> Diff: https://reviews.apache.org/r/59526/diff/1/
> 
> 
> Testing
> ---
> 
> manual testing done.
> 
> 
> Thanks,
> 
> Nitiraj Rathore
> 
>

Re: Review Request 59503: Create custom admin user during ambari server setup

[Anita Jebaraj]

> On May 24, 2017, 1:51 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> > Lines 351-356 (patched)
> > 
> >
> > Is this necessary?  It seems like the option is only releated to setup, 
> > not for normal runtime.
> 
> Anita Jebaraj wrote:
> yes it is only used during setup, but I added it here to be included in 
> the index.md, please let me know if it is not required
> 
> Robert Levas wrote:
> I don't think that this is necessary. That index.md file is documentation 
> for the properties that go in the ambari.properites file. Since the value for 
> this is only used during Ambari setup, it will not need to be set as a 
> configuration option and ambari.properties.

I am using this property as a flag in ambari.properties, the prompt to create 
custom admin user will be given only the first time of setup if the flag is set 
to true then the  admin user is created and the prompt is not required again


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59503/#review175924
---


On May 23, 2017, 11:26 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59503/
> ---
> 
> (Updated May 23, 2017, 11:26 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, 
> Robert Levas, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21083
> https://issues.apache.org/jira/browse/AMBARI-21083
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Provide the ability to create custom admin user during ambari server setup, 
> so that the user will have the option to either create the admin user with 
> the username/password of their preference or can use the default username.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  114046f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java
>  PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 
>   ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59503/diff/2/
> 
> 
> Testing
> ---
> 
> Added 1 test case
> 
> 
> Ran mvn test
> 
> 
> File Attachments
> 
> 
> custom_admin.PNG
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 59503: Create custom admin user during ambari server setup

[Robert Levas]

> On May 24, 2017, 9:51 a.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> > Lines 351-356 (patched)
> > 
> >
> > Is this necessary?  It seems like the option is only releated to setup, 
> > not for normal runtime.
> 
> Anita Jebaraj wrote:
> yes it is only used during setup, but I added it here to be included in 
> the index.md, please let me know if it is not required

I don't think that this is necessary. That index.md file is documentation for 
the properties that go in the ambari.properites file. Since the value for this 
is only used during Ambari setup, it will not need to be set as a configuration 
option and ambari.properties.


- Robert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59503/#review175924
---


On May 23, 2017, 7:26 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59503/
> ---
> 
> (Updated May 23, 2017, 7:26 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, 
> Robert Levas, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21083
> https://issues.apache.org/jira/browse/AMBARI-21083
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Provide the ability to create custom admin user during ambari server setup, 
> so that the user will have the option to either create the admin user with 
> the username/password of their preference or can use the default username.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  114046f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java
>  PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 
>   ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59503/diff/2/
> 
> 
> Testing
> ---
> 
> Added 1 test case
> 
> 
> Ran mvn test
> 
> 
> File Attachments
> 
> 
> custom_admin.PNG
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 59503: Create custom admin user during ambari server setup

[Anita Jebaraj]

> On May 24, 2017, 1:51 p.m., Robert Levas wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
> > Lines 351-356 (patched)
> > 
> >
> > Is this necessary?  It seems like the option is only releated to setup, 
> > not for normal runtime.

yes it is only used during setup, but I added it here to be included in the 
index.md, please let me know if it is not required


- Anita


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59503/#review175924
---


On May 23, 2017, 11:26 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59503/
> ---
> 
> (Updated May 23, 2017, 11:26 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, 
> Robert Levas, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21083
> https://issues.apache.org/jira/browse/AMBARI-21083
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Provide the ability to create custom admin user during ambari server setup, 
> so that the user will have the option to either create the admin user with 
> the username/password of their preference or can use the default username.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  114046f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java
>  PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 
>   ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59503/diff/2/
> 
> 
> Testing
> ---
> 
> Added 1 test case
> 
> 
> Ran mvn test
> 
> 
> File Attachments
> 
> 
> custom_admin.PNG
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 59503: Create custom admin user during ambari server setup

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59503/#review175924
---




ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
Lines 351-356 (patched)


Is this necessary?  It seems like the option is only releated to setup, not 
for normal runtime.


- Robert Levas


On May 23, 2017, 7:26 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59503/
> ---
> 
> (Updated May 23, 2017, 7:26 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, 
> Robert Levas, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21083
> https://issues.apache.org/jira/browse/AMBARI-21083
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Provide the ability to create custom admin user during ambari server setup, 
> so that the user will have the option to either create the admin user with 
> the username/password of their preference or can use the default username.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  114046f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java
>  PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 
>   ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59503/diff/2/
> 
> 
> Testing
> ---
> 
> Added 1 test case
> 
> 
> Ran mvn test
> 
> 
> File Attachments
> 
> 
> custom_admin.PNG
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Review Request 59527: HDP 3.0 TP - create Service Advisor for Zeppelin

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59527/
---

Review request for Ambari and Alejandro Fernandez.


Bugs: AMBARI-21112
https://issues.apache.org/jira/browse/AMBARI-21112


Repository: ambari


Description
---

create Service Advisor for Zeppelin


Diffs
-

  
ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/service_advisor.py
 PRE-CREATION 


Diff: https://reviews.apache.org/r/59527/diff/1/


Testing
---

mvn clean test


Thanks,

Vitalyi Brodetskyi

Review Request 59526: Unable to upload table via Ambari Hive view if user does not have permission on default database

[Nitiraj Rathore]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59526/
---

Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav Kulshreshtha, 
Rohit Choudhary, and venkat sairam.


Bugs: AMBARI-21108
https://issues.apache.org/jira/browse/AMBARI-21108


Repository: ambari


Description
---

Hive view 1.5 was using default DB for use statement in upload table feature. 
corrected it to use selected database


Diffs
-

  
contrib/views/hive-next/src/main/java/org/apache/ambari/view/hive2/resources/uploads/UploadService.java
 a979dc9478 


Diff: https://reviews.apache.org/r/59526/diff/1/


Testing
---

manual testing done.


Thanks,

Nitiraj Rathore

Re: Review Request 59503: Create custom admin user during ambari server setup

[Tim Thorpe]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59503/#review175918
---


Ship it!




Ship It!

- Tim Thorpe


On May 23, 2017, 11:26 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59503/
> ---
> 
> (Updated May 23, 2017, 11:26 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Di Li, Jonathan Hurley, 
> Robert Levas, and Tim Thorpe.
> 
> 
> Bugs: AMBARI-21083
> https://issues.apache.org/jira/browse/AMBARI-21083
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Provide the ability to create custom admin user during ambari server setup, 
> so that the user will have the option to either create the admin user with 
> the username/password of their preference or can use the default username.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  114046f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/CreateUserHelper.java
>  PRE-CREATION 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 4780338 
>   ambari-server/src/main/python/ambari_server/serverSetup.py c6de088 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 15670f3 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql 7e41399 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 4d0274f 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql cc933fa 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 5fc14d4 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql 12e66f9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/CreateUserHelperTest.java
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/59503/diff/2/
> 
> 
> Testing
> ---
> 
> Added 1 test case
> 
> 
> Ran mvn test
> 
> 
> File Attachments
> 
> 
> custom_admin.PNG
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/23/53d168bc-6c83-4acf-ae9b-74bf3fa005d3__custom_admin.PNG
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 59369: Reduce Dependency on Cluster Desired Stack ID

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59369/#review175917
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On May 23, 2017, 9:44 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59369/
> ---
> 
> (Updated May 23, 2017, 9:44 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Dmitro Lisnichenko, and 
> Jonathan Hurley.
> 
> 
> Bugs: AMBARI-21059
> https://issues.apache.org/jira/browse/AMBARI-21059
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> With the advent of {{PATCH}} and {{CLUSTER}} upgrades, there is no longer the 
> notion of a cluster being bound to a specific stack. Instead, the stack ID is 
> being pushed down to the service and component level.
> 
> Currently, upgrades tries to set the cluster desired stack ID on 
> finalization. Eventually there will be a complete decouple of the cluster 
> from a singular stack id.  This jira covers a majority of cases in code.  
> Until configs are refactored, we can't remove the associated stack id in its 
> entirety.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/annotations/ExperimentalFeature.java
>  1d5ba0e9e9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/actionmanager/Stage.java 
> 574afa1c86 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartBeatHandler.java
>  36015282ea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatMonitor.java
>  a77ed75c99 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/HeartbeatProcessor.java
>  17e1f9c138 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  c655c6286f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java
>  2fc1787e17 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ComponentsInstallationCheck.java
>  70a061cc79 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsMasterMaintenanceCheck.java
>  1e87319d84 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/HostsRepositoryVersionCheck.java
>  a4cea3105f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/RangerPasswordCheck.java
>  a55a1481d6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServiceCheckValidityCheck.java
>  4ccdc0a3d9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/ServicesUpCheck.java
>  273bdaac68 
>   
> ambari-server/src/main/java/org/apache/ambari/server/checks/YarnTimelineServerStatePreservingCheck.java
>  d8dba96094 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariActionExecutionHelper.java
>  9fb77e8d6b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  397c1c29e1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  96bab85b47 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  e373f81f6b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/KerberosHelperImpl.java
>  8a5731bcbe 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceRequest.java
>  66c1a93081 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  4ad01a54a7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClusterStackVersionResourceProvider.java
>  6447888dde 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java
>  24ef41a767 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceResourceProvider.java
>  664ba42f34 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackDefinedPropertyProvider.java
>  8972ca220f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/UpgradeResourceProvider.java
>  6027ce76f6 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LoggingSearchPropertyProvider.java
>  c69d00ba46 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/timeline/AMSPropertyProvider.java
>  c4c2ddcbae 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/DefaultServiceCalculatedState.java
>  264ba030f7 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/state/HBaseServiceCalculatedState.java
>  d44515cdb4 
>   
> 

Review Request 59522: ambari-server setup fails with default postgres

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59522/
---

Review request for Ambari and Sid Wagle.


Bugs: AMBARI-21110
https://issues.apache.org/jira/browse/AMBARI-21110


Repository: ambari


Description
---

Thisis the first run with oracle12. Initially infra sets up Ambari with
default postgres and later on ambari setup happens with Oracle12. But now the
first setup with default postgres is failing with below error




root@172.27.24.11 "ambari-server setup --java-home=/base/tools/jdk1.8.0_112 
-s"
2017-05-22 10:57:54.032 Using python  /usr/bin/python
2017-05-22 10:57:54.032 Setup ambari-server
2017-05-22 10:58:14.299 Checking SELinux...
2017-05-22 10:58:14.299 SELinux status is 'disabled'
2017-05-22 10:58:14.299 Customize user account for ambari-server daemon 
[y/n] (n)? 
2017-05-22 10:58:14.299 Adjusting ambari-server permissions and ownership...
2017-05-22 10:58:14.299 Checking firewall status...
2017-05-22 10:58:14.299 FATAL: Could not load 
/lib/modules/3.10.0-327.13.1.el7.x86_64/modules.dep: No such file or directory
2017-05-22 10:58:14.299 iptables v1.4.7: can't initialize iptables table 
`nat': Permission denied (you must be root)
2017-05-22 10:58:14.299 Perhaps iptables or your kernel needs to be 
upgraded.
2017-05-22 10:58:14.299 FATAL: Could not load 
/lib/modules/3.10.0-327.13.1.el7.x86_64/modules.dep: No such file or directory
2017-05-22 10:58:14.299 iptables v1.4.7: can't initialize iptables table 
`filter': Permission denied (you must be root)
2017-05-22 10:58:14.299 Perhaps iptables or your kernel needs to be 
upgraded.
2017-05-22 10:58:14.299 WARNING: iptables is running. Confirm the necessary 
Ambari ports are accessible. Refer to the Ambari documentation for more details 
on ports.
2017-05-22 10:58:14.299 OK to continue [y/n] (y)? 
2017-05-22 10:58:14.299 Checking JDK...
2017-05-22 10:58:14.299 WARNING: JAVA_HOME /base/tools/jdk1.8.0_112 must be 
valid on ALL hosts
2017-05-22 10:58:14.299 WARNING: JCE Policy files are required for 
configuring Kerberos security. If you plan to use Kerberos,please make sure JCE 
Unlimited Strength Jurisdiction Policy Files are valid on all hosts.
2017-05-22 10:58:14.299 Completing setup...
2017-05-22 10:58:14.299 Configuring database...
2017-05-22 10:58:14.299 Enter advanced database configuration [y/n] (n)? 
2017-05-22 10:58:14.299 Configuring database...
2017-05-22 10:58:14.299 Default properties detected. Using built-in 
database.
2017-05-22 10:58:14.299 Configuring ambari database...
2017-05-22 10:58:14.299 Checking PostgreSQL...
2017-05-22 10:58:14.299 Running initdb: This may take up to a minute.
2017-05-22 10:58:14.299 Initializing database: [  OK  ]
2017-05-22 10:58:14.299 
2017-05-22 10:58:14.299 About to start PostgreSQL
2017-05-22 10:58:14.299 Configuring local database...
2017-05-22 10:58:14.299 Configuring PostgreSQL...
2017-05-22 10:58:14.299 Creating schema and user...
2017-05-22 10:58:14.299 ERROR: Failed to execute command:['ambari-sudo.sh', 
'su', 'postgres', '-', '--command=psql -f 
/var/lib/ambari-server/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql -v 
username=\'"ambari"\' -v password="\'bigdata\'" -v dbname="ambari"']
2017-05-22 10:58:14.299 ERROR: stderr:could not change directory to "/root"
2017-05-22 10:58:14.299 psql: could not connect to server: No such file or 
directory
2017-05-22 10:58:14.299 Is the server running locally and accepting
2017-05-22 10:58:14.299 connections on Unix domain socket 
"/tmp/.s.PGSQL.5432"?
2017-05-22 10:58:14.299 
2017-05-22 10:58:14.299 ERROR: stdout:
2017-05-22 10:58:14.299 failed to execute queries ...retrying (1)
2017-05-22 10:58:14.299 Creating schema and user...
2017-05-22 10:58:14.299 ERROR: Failed to execute command:['ambari-sudo.sh', 
'su', 'postgres', '-', '--command=psql -f 
/var/lib/ambari-server/resources/Ambari-DDL-Postgres-EMBEDDED-CREATE.sql -v 
username=\'"ambari"\' -v password="\'bigdata\'" -v dbname="ambari"']
2017-05-22 10:58:14.299 ERROR: stderr:could not change directory to "/root"
2017-05-22 10:58:14.299 psql: could not connect to server: No such file or 
directory
2017-05-22 10:58:14.299 Is the server running locally and accepting
2017-05-22 10:58:14.299 connections on Unix domain socket 
"/tmp/.s.PGSQL.5432"?
2017-05-22 10:58:14.299 
2017-05-22 10:58:14.299 ERROR: stdout:
2017-05-22 10:58:14.299 failed to execute queries ...retrying (2)
2017-05-22 10:58:14.299 Creating schema and user...
2017-05-22 10:58:14.299 ERROR: Exiting with exit code 2. 
2017-05-22 10:58:14.299 REASON: Running database init script failed. 
Exiting.
2017-05-22 10:58:14.353 Set 

Review Request 59520: Custom RM principal causes zookeeper HA state store to be inaccessible

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59520/
---

Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Robert Levas, and 
Sebastian Toader.


Bugs: AMBARI-20877
https://issues.apache.org/jira/browse/AMBARI-20877


Repository: ambari


Description
---

HDP 2.6 stack introduced settings for ACLs on the Yarn Resource Manager HA 
state store. In `yarn-site/yarn.resourcemanager.zk-acl` the ACL user is set to 
`rm`.
If this user name does not match the primary component of the Yarn RM Kerberos 
principal in `yarn-site/yarn.resourcemanager.principal`, then Yarn is unable to 
access the state store and RM will stop immediately after start.
During the Kerberos wizard there needs to be a check to see if these settings 
are out of sync. Or, the zk-acl setting needs to somehow reference the 
principal and extract the primary root through a variable.


Diffs
-

  ambari-agent/src/test/python/resource_management/TestSecurityCommons.py 
870ca92 
  
ambari-common/src/main/python/resource_management/libraries/functions/security_commons.py
 9ceeea7 
  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
 3579fcb 
  ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 
ae4db4f 
  
ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py
 66194ed 
  ambari-server/src/main/resources/stacks/HDP/2.6/services/YARN/kerberos.json 
ae4db4f 


Diff: https://reviews.apache.org/r/59520/diff/1/


Testing
---

- Create a cluster with yarn, hdfs
- enabled kerberos using custom principal names
- checked custom principal names in hadoop.registry.system.accounts and 
yarn.resourcemanager.zk-acl properties in yarn config


Tests: PENDING


Thanks,

Attila Magyar

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

[Alexandr Antonenko]

> On May 19, 2017, 8:28 a.m., Alexandr Antonenko wrote:
> > Ship It!
> 
> Amruta Borkar wrote:
> Hello Alexandr,
> Could you please help me push this to trunk?

committed to trunk


- Alexandr


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59373/#review175476
---


On May 19, 2017, 5:01 p.m., Amruta Borkar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59373/
> ---
> 
> (Updated May 19, 2017, 5:01 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, Robert Nettleton, and 
> Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-21050
> https://issues.apache.org/jira/browse/AMBARI-21050
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Exported blueprint should include config-group changes, which should be 
> exported as host-group level configuration. New host-group will be created 
> for host having unique config-group.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/controllers/wizard/step8_controller.js 7e318e0e62 
>   ambari-web/test/controllers/wizard/step8_test.js 1a3214e263 
> 
> 
> Diff: https://reviews.apache.org/r/59373/diff/2/
> 
> 
> Testing
> ---
> 
> Tested manually. Updated test cases.
> 
> 
> File Attachments
> 
> 
> exported blueprint
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/18/a01c8336-2e84-4c73-af54-c7ba60e7acb3__blueprint_expUI.json
> exported cluster template
>   
> https://reviews.apache.org/media/uploaded/files/2017/05/18/ee8f7e71-fea9-42ba-bcd1-9afc1a8654d6__clustertemplate_expUI.json
> 
> 
> Thanks,
> 
> Amruta Borkar
> 
>

Re: Review Request 59496: Enable opening views in a new tab

[Alexandr Antonenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59496/#review175912
---


Ship it!




Ship It!

- Alexandr Antonenko


On May 23, 2017, 6:58 p.m., Anita Jebaraj wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59496/
> ---
> 
> (Updated May 23, 2017, 6:58 p.m.)
> 
> 
> Review request for Ambari, Alexandr Antonenko, Di Li, DIPAYAN BHOWMICK, 
> Pallav Kulshreshtha, and Sangeeta Ravindran.
> 
> 
> Bugs: AMBARI-21095
> https://issues.apache.org/jira/browse/AMBARI-21095
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Enable views to be opened in a new tab instead of being opened in the same 
> tab, this would help in going between the different tabs to look for 
> information or for config updates in the services.
> 
> 
> Diffs
> -
> 
>   ambari-admin/src/main/resources/ui/admin-web/app/index.html 32f9ba7 
>   
> ambari-admin/src/main/resources/ui/admin-web/app/views/ambariViews/edit.html 
> b6ec61d 
>   ambari-web/app/controllers/main/views_controller.js 398cdd8 
>   ambari-web/app/models/view_instance.js d438640 
>   ambari-web/test/controllers/main/views_controller_test.js 0ab7654 
>   ambari-web/test/models/view_instance_test.js 0e977e3 
> 
> 
> Diff: https://reviews.apache.org/r/59496/diff/1/
> 
> 
> Testing
> ---
> 
> Modified the test cases,
> 
> Ran mvn test
> 
> 
> Thanks,
> 
> Anita Jebaraj
> 
>

Re: Review Request 59514: AMBARI-20970. Integrate StackService with Swagger - addendum: fix XML property names

[Jaimin Jetly]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59514/#review175904
---


Ship it!




Ship It!

- Jaimin Jetly


On May 24, 2017, 6:15 a.m., Attila Doroszlai wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59514/
> ---
> 
> (Updated May 24, 2017, 6:15 a.m.)
> 
> 
> Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jonathan Hurley, 
> and Sebastian Toader.
> 
> 
> Bugs: AMBARI-20970
> https://issues.apache.org/jira/browse/AMBARI-20970
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update constants, use only for JSON where names are different
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
>  4137115b14ea195581313f9d33cc4f038ef3d163 
> 
> 
> Diff: https://reviews.apache.org/r/59514/diff/1/
> 
> 
> Testing
> ---
> 
> Installed cluster via Ambari Web.
> 
> Unit tests:
> 
> ```
> Tests run: 4981, Failures: 0, Errors: 0, Skipped: 39
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Re: Review Request 59514: AMBARI-20970. Integrate StackService with Swagger - addendum: fix XML property names

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59514/
---

(Updated May 24, 2017, 8:15 a.m.)


Review request for Ambari, Balázs Bence Sári, Jaimin Jetly, Jonathan Hurley, 
and Sebastian Toader.


Bugs: AMBARI-20970
https://issues.apache.org/jira/browse/AMBARI-20970


Repository: ambari


Description
---

Update constants, use only for JSON where names are different


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/state/ValueAttributesInfo.java
 4137115b14ea195581313f9d33cc4f038ef3d163 


Diff: https://reviews.apache.org/r/59514/diff/1/


Testing (updated)
---

Installed cluster via Ambari Web.

Unit tests:

```
Tests run: 4981, Failures: 0, Errors: 0, Skipped: 39
```


Thanks,

Attila Doroszlai