Re: Review Request 57583: HDFS Bytes Written and HDFS Bytes Read maybe not correct

2017-09-14 Thread zhangxiaolu zhangxiaolu
> On 六月 9, 2017, 11:57 a.m., Dmytro Sen wrote: > > Ship It! > > zhangxiaolu zhangxiaolu wrote: > thank you for reviewing this patch. Could you be so kind as to commit the > patch for me please? Thanks in advance > > Dmytro Sen wrote: > Can't apply the patch on trunk. Could you update

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

2017-09-14 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61994/#review185458 --- Ship it! Ship It! - Jayush Luniya On Sept. 14, 2017, 10:47

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

2017-09-14 Thread Vitalyi Brodetskyi
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61994/ --- (Updated Вер. 14, 2017, 10:47 після полудня) Review request for Ambari, Jayush

Re: Review Request 61510: AMBARI-21686 : Implement a test driver that provides a set of metric series with different kinds of metric behavior

2017-09-14 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61510/#review185454 --- Ship it! Ship It! - Sid Wagle On Aug. 8, 2017, 10:14 p.m.,

Re: Review Request 62290: Validate kerberos.json files to ensure they meet the expected schema

2017-09-14 Thread Robert Levas
> On Sept. 14, 2017, 8:40 a.m., Jonathan Hurley wrote: > > That's a lot of validation! I'm curious though - did you happen to look at > > something like http://json-schema.org/ instead of doing it explicitely in > > each descriptor class? > > Laszlo Puskas wrote: > +1 > > Robert Levas

Re: Review Request 62290: Validate kerberos.json files to ensure they meet the expected schema

2017-09-14 Thread Jonathan Hurley
> On Sept. 14, 2017, 8:40 a.m., Jonathan Hurley wrote: > > That's a lot of validation! I'm curious though - did you happen to look at > > something like http://json-schema.org/ instead of doing it explicitely in > > each descriptor class? > > Laszlo Puskas wrote: > +1 > > Robert Levas

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

2017-09-14 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61994/#review185437 ---

Re: Review Request 62290: Validate kerberos.json files to ensure they meet the expected schema

2017-09-14 Thread Robert Levas
> On Sept. 14, 2017, 8:40 a.m., Jonathan Hurley wrote: > > That's a lot of validation! I'm curious though - did you happen to look at > > something like http://json-schema.org/ instead of doing it explicitely in > > each descriptor class? > > Laszlo Puskas wrote: > +1 I tried to do this

Re: Review Request 62329: Fix broken zeppelin python unit test

2017-09-14 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62329/ --- (Updated Sept. 14, 2017, 9:56 p.m.) Review request for Ambari, Attila

Re: Review Request 62331: Cluster provision should allow repo version and repo version id be null to allow default stack version deployment

2017-09-14 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62331/#review185419 --- Ship it! Ship It! - Jonathan Hurley On Sept. 14, 2017,

Re: Review Request 62330: Ambari schema upgrade from any version older than 2.5.1 fails due to incorrect version check

2017-09-14 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62330/ --- (Updated Sept. 14, 2017, 6:58 p.m.) Review request for Ambari, Jonathan Hurley

Re: Review Request 62329: Fix broken zeppelin python unit test

2017-09-14 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62329/#review185417 --- Ship it! Ship It! - Jonathan Hurley On Sept. 14, 2017, 8:27

Re: Review Request 62331: Cluster provision should allow repo version and repo version id be null to allow default stack version deployment

2017-09-14 Thread Robert Nettleton
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62331/#review185415 --- Ship it! Ship It! - Robert Nettleton On Sept. 14, 2017,

Re: Review Request 62331: Cluster provision should allow repo version and repo version id be null to allow default stack version deployment

2017-09-14 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62331/#review185412 --- Ship it! Ship It! - Dmytro Grinenko On Sept. 14, 2017, 3:13

Review Request 62331: Cluster provision should allow repo version and repo version id be null to allow default stack version deployment

2017-09-14 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62331/ --- Review request for Ambari, Dmytro Grinenko and Jonathan Hurley. Bugs:

Re: Review Request 62330: Ambari schema upgrade from any version older than 2.5.1 fails due to incorrect version check

2017-09-14 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62330/#review185410 --- Ship it! Ship It! - Nate Cole On Sept. 14, 2017, 9:43 a.m.,

Re: Review Request 62242: AMBARI-21933 UI: Implement breadcrumbs in Background Operations modal

2017-09-14 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62242/#review185409 --- Committed to trunk. Please close this review. - Jonathan Hurley

Re: Review Request 62242: AMBARI-21933 UI: Implement breadcrumbs in Background Operations modal

2017-09-14 Thread Denys Buzhor
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62242/#review185408 --- Ship it! Ship It! - Denys Buzhor On Sept. 13, 2017, 6:31

Re: Review Request 62242: AMBARI-21933 UI: Implement breadcrumbs in Background Operations modal

2017-09-14 Thread Oleg Nechiporenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62242/#review185407 --- Ship it! Ship It! - Oleg Nechiporenko On Sept. 13, 2017,

Review Request 62330: Ambari schema upgrade from any version older than 2.5.1 fails due to incorrect version check

2017-09-14 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62330/ --- Review request for Ambari, Jonathan Hurley and Nate Cole. Bugs: AMBARI-21940

Re: Review Request 62290: Validate kerberos.json files to ensure they meet the expected schema

2017-09-14 Thread Laszlo Puskas
> On Sept. 14, 2017, 12:40 p.m., Jonathan Hurley wrote: > > That's a lot of validation! I'm curious though - did you happen to look at > > something like http://json-schema.org/ instead of doing it explicitely in > > each descriptor class? +1 - Laszlo

Re: Review Request 62290: Validate kerberos.json files to ensure they meet the expected schema

2017-09-14 Thread Laszlo Puskas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62290/#review185405 --- Ship it! Ship It! - Laszlo Puskas On Sept. 13, 2017, 7:52

Re: Review Request 62329: Fix broken zeppelin python unit test

2017-09-14 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62329/#review185404 --- Ship it! Ship It! - Gaurav Nagar On Sept. 14, 2017, 12:27

Re: Review Request 62290: Validate kerberos.json files to ensure they meet the expected schema

2017-09-14 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62290/#review185399 --- Ship it! That's a lot of validation! I'm curious though - did

Review Request 62329: Fix broken zeppelin python unit test

2017-09-14 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62329/ --- Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN

Re: Review Request 62290: Validate kerberos.json files to ensure they meet the expected schema

2017-09-14 Thread Sebastian Toader
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62290/#review185398 --- Ship it! Ship It! - Sebastian Toader On Sept. 13, 2017,

Re: Review Request 62289: Package Installation is failing If Patch-VDF contain service that is not installed in the cluster

2017-09-14 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62289/#review185391 --- Ship it! Ship It! - Dmitro Lisnichenko On Sept. 13, 2017,

Re: Review Request 62289: Package Installation is failing If Patch-VDF contain service that is not installed in the cluster

2017-09-14 Thread Dmitro Lisnichenko
> On Sept. 14, 2017, 2 p.m., Dmitro Lisnichenko wrote: > > Ship It! my bad - Dmitro --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62289/#review185391

Re: Review Request 62205: Make Ambari changes for external-conf

2017-09-14 Thread Pallav Kulshreshtha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62205/#review185386 --- Ship it! Ship It! - Pallav Kulshreshtha On Sept. 9, 2017,

Re: Review Request 62205: Make Ambari changes for external-conf

2017-09-14 Thread Gaurav Nagar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62205/#review185385 --- Ship it! Ship It! - Gaurav Nagar On Sept. 9, 2017, 5:15

Re: Review Request 62155: Add 0.7.x stack definition for Zeppelin

2017-09-14 Thread Prabhjyot Singh
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62155/ --- (Updated Sept. 14, 2017, 2 p.m.) Review request for Ambari, Attila Doroszlai,

Re: Review Request 62324: AMBARI-21955: Port Storm View from React.js to Vue.js

2017-09-14 Thread Sanket Shah
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62324/ --- (Updated Sept. 14, 2017, 7:11 a.m.) Review request for Ambari, DIPAYAN