Re: Review Request 63477: AMBARI-22348 : Metric Definition Service V1 Implementation.

2017-11-01 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63477/
---

(Updated Nov. 1, 2017, 10:37 p.m.)


Review request for Ambari, Jayush Luniya and Sid Wagle.


Changes
---

Fixed review issues.


Bugs: AMBARI-22348
https://issues.apache.org/jira/browse/AMBARI-22348


Repository: ambari


Description
---

Initial implementation for
. Confuguration Handling for the AD Service
. Model classes for Anomalies, Metric Definition, Metric Key etc.
. Seasonality Handling
. Metric Definition Service
. Unit testing


Diffs (updated)
-

  ambari-metrics/ambari-metrics-anomaly-detection-service/pom.xml 554d026 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/java/org/apache/ambari/metrics/adservice/prototype/common/StatisticUtils.java
 7f0aed3 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/java/org/apache/ambari/metrics/adservice/prototype/core/MetricSparkConsumer.java
 e8257e5 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/java/org/apache/ambari/metrics/adservice/prototype/core/PointInTimeADSystem.java
 0a2271a 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/java/org/apache/ambari/metrics/adservice/prototype/core/TrendADSystem.java
 f5ec83a 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/java/org/apache/ambari/metrics/adservice/prototype/methods/MetricAnomaly.java
 251603b 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/java/org/apache/ambari/metrics/adservice/prototype/methods/hsdev/HsdevTechnique.java
 6facc99 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/java/org/apache/ambari/metrics/adservice/prototype/methods/kstest/KSTechnique.java
 4727c6f 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/java/org/apache/ambari/metrics/adservice/prototype/testing/utilities/MetricAnomalyTester.java
 d079e66 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/resources/config.yml
 9ca9e95 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionApp.scala
 b7f217e 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppConfig.scala
 9e6cc6d 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppModule.scala
 338c97b 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/ADServiceConfiguration.scala
 248c74e 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/PhoenixQueryConstants.scala
 17173ec 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/Range.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/Season.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/SeasonType.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/TimeRange.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/AdServiceConfiguration.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/HBaseConfiguration.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/MetricCollectorConfiguration.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/MetricManagerServiceConfiguration.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/AdMetadataStoreAccessor.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/AdMetadataStoreConstants.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/PhoenixAnomalyStoreAccessor.scala
 6f33e56 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/PhoenixQueryConstants.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metadata/ADMetadataProvider.scala
 PRE-CREATION

Re: Review Request 63477: AMBARI-22348 : Metric Definition Service V1 Implementation.

2017-11-01 Thread Sid Wagle 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63477/#review189837
---


Fix it, then Ship it!





ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/resources/config.yml
Lines 27 (patched)


/etc/ams-adservice, similar to others?



ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppConfig.scala
Lines 25 (patched)


Make sure imports are properly alligned based on project rules.



ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppConfig.scala
Lines 39 (patched)


Why var?



ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/HBaseConfiguration.scala
Lines 26 (patched)


Why var?



ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/MetricManagerServiceConfiguration.scala
Lines 36 (patched)


Is setter needed?



ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/AdMetadataStoreAccessor.scala
Lines 30 (patched)


This behavior should be left upto the impl and not a part of trait behavior



ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/PhoenixAnomalyStoreAccessor.scala
Lines 81 (patched)


Convoluted naming convention.



ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/AMSMetadataProvider.scala
Lines 32 (patched)


Rename to ADMetadataProvider



ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/AMSMetadataProvider.scala
Lines 34 (patched)


Prefer immutables here.



ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/AMSMetadataProvider.scala
Lines 54 (patched)


Unused?



ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/MetricManagerServiceImpl.scala
Lines 29 (patched)


Immutable should be preferred !



ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/MetricManagerServiceImpl.scala
Lines 62 (patched)


Service initialization should not make a blocking http call rather fail 
late when API call is made. Log error when failing.



ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/HBaseTimelineMetricsService.java
Lines 469 (patched)


formatting.


- Sid Wagle


On Nov. 1, 2017, 9:21 p.m., Aravindan Vijayan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63477/
> ---
> 
> (Updated Nov. 1, 2017, 9:21 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sid Wagle.
> 
> 
> Bugs: AMBARI-22348
> https://issues.apache.org/jira/browse/AMBARI-22348
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Initial implementation for
> . Confuguration Handling for the AD Service
> . Model classes for Anomalies, Metric Definition, Metric Key etc.
> . Seasonality Handling
> . Metric Definition Service
> . Unit testing
> 
> 
> Diffs
> -
> 
>   ambari-metrics/ambari-metrics-anomaly-detection-service/pom.xml 554d026 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/resources/config.yml
>  9ca9e95 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppConfig.scala
>  9e6cc6d 
>   
> ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/ADServiceConfiguration.scala
>  248c74e 
>   
>

Re: Review Request 63477: AMBARI-22348 : Metric Definition Service V1 Implementation.

2017-11-01 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63477/
---

(Updated Nov. 1, 2017, 9:21 p.m.)


Review request for Ambari, Jayush Luniya and Sid Wagle.


Bugs: AMBARI-22348
https://issues.apache.org/jira/browse/AMBARI-22348


Repository: ambari


Description
---

Initial implementation for
. Confuguration Handling for the AD Service
. Model classes for Anomalies, Metric Definition, Metric Key etc.
. Seasonality Handling
. Metric Definition Service
. Unit testing


Diffs (updated)
-

  ambari-metrics/ambari-metrics-anomaly-detection-service/pom.xml 554d026 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/resources/config.yml
 9ca9e95 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppConfig.scala
 9e6cc6d 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/ADServiceConfiguration.scala
 248c74e 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/PhoenixQueryConstants.scala
 17173ec 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/Range.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/Season.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/SeasonType.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/SeasonalityHandler.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/TimeRange.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/AdServiceConfiguration.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/HBaseConfiguration.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/MetricCollectorConfiguration.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/MetricManagerServiceConfiguration.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/AdMetadataStoreAccessor.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/AdMetadataStoreConstants.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/PhoenixAnomalyStoreAccessor.scala
 6f33e56 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/PhoenixQueryConstants.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/AMSMetadataProvider.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/InputMetricDefinitionParser.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/MetricDefinition.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/MetricKey.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/MetricManagerService.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/MetricManagerServiceImpl.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/MetricMetadataProvider.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/MetricSourceDefinition.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/MetricSourceDefinitionType.scala
 PRE-CREATION

Review Request 63477: AMBARI-22348 : Metric Definition Service V1 Implementation.

2017-11-01 Thread Aravindan Vijayan 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63477/
---

Review request for Ambari, Jayush Luniya and Sid Wagle.


Bugs: AMBARI-22348
https://issues.apache.org/jira/browse/AMBARI-22348


Repository: ambari


Description
---

Initial implementation for
. Confuguration Handling for the AD Service
. Model classes for Anomalies, Metric Definition, Metric Key etc.
. Seasonality Handling
. Metric Definition Service
. Unit testing


Diffs
-

  ambari-metrics/ambari-metrics-anomaly-detection-service/pom.xml 554d026 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/resources/config.yml
 9ca9e95 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/app/AnomalyDetectionAppConfig.scala
 9e6cc6d 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/ADServiceConfiguration.scala
 248c74e 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/PhoenixQueryConstants.scala
 17173ec 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/Range.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/Season.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/SeasonType.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/SeasonalityHandler.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/common/TimeRange.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/AdServiceConfiguration.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/HBaseConfiguration.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/MetricCollectorConfiguration.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/configuration/MetricManagerServiceConfiguration.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/AdMetadataStoreAccessor.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/AdMetadataStoreConstants.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/PhoenixAnomalyStoreAccessor.scala
 6f33e56 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/db/PhoenixQueryConstants.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/AMSMetadataProvider.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/InputMetricDefinitionParser.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/MetricDefinition.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/MetricKey.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/MetricManagerService.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/MetricManagerServiceImpl.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/MetricMetadataProvider.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/MetricSourceDefinition.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/metricmanager/MetricSourceDefinitionType.scala
 PRE-CREATION 
  
ambari-metrics/ambari-metrics-anomaly-detection-service/src/main/scala/org/apache/ambari/metrics/adservice/model/AnomalyDetectionMethod.scala
 PRE-CREATION

Re: Review Request 63205: AMBARI-22198. Implement read only API for getting stack level settings.

2017-11-01 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63205/#review189819
---


Ship it!




Ship It!

- Jayush Luniya


On Oct. 25, 2017, 6:44 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63205/
> ---
> 
> (Updated Oct. 25, 2017, 6:44 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan.
> 
> 
> Bugs: AMBARI-22198
> https://issues.apache.org/jira/browse/AMBARI-22198
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> This JIRA work assumes the following things to be present in the stack (3.0 
> onwards) coming from the mpack (as there is no inheritance in stacks, given 
> the flat stack structure coming from mpacks):
> 
> - **settings.xml** file in 
> **/var/lib/ambari-server/resources/stacks///configuration**
> 
> - **stack_features.json**, **stack_packages.json** and **stack_tools.json** 
> present in 
> **/var/lib/ambari-server/resources/stacks///properties/**
>  directory.
> 
> 
> Above work is done as part of JIRA : AMBARI-22285
> 
> 
> --
> 
> 
> **Work done in this Review Request:**
> 
> - Implement the new read only 
> http://:/api/v1/stacks//versions//settings 
> API.
> It serves the following settings : **stack_features**, **stack_name**, 
> **stack_packages**, **stack_root** and **stack_tools**.
> 
> - Renaming of files for Cluster Settings related code (work done in  
> AMBARI-22196).
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  737b9b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RootStackSettingsResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  1c0a555 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RootClusterSettingService.java
>  d77b347 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/StacksService.java
>  aef7fc1 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
>  ce61497 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  8a038cc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3117186 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  b8c1674 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootStackSettingsResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  6a76fff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManager.java
>  4cb6cd9 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/ResourceLevelClusterSettingManagerFactory.java
>  fcda654 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManager.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/resources/RootLevelSettingsManagerFactory.java
>  PRE-CREATION 
>   ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java 
> 878415b 
>   ambari-server/src/main/java/org/apache/ambari/server/state/StackInfo.java 
> 07d28ce 
>   ambari-server/src/main/resources/stacks/HDP/3.0/configuration/settings.xml 
> PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63205/diff/4/
> 
> 
> Testing
> ---
> 
> **Testing on 2.6 stack** (stack version in general has no effect on what we 
> are testing here)
> 
> 
> - **GET http://:/api/v1/stacks/HDP/versions/2.6/settings**
> 
> 
> {
>   "href" : "http://:/api/v1/stacks/HDP/versions/2.6/settings",
>   "items" : [
> {
>   "href" : 
> "http://:/api/v1/stacks/HDP/versions/2.6/settings/stack_features",
>   "StackSettingsInfo" : {
> "property_name" : "stack_features",
> "stack_name" : "HDP",
> "stack_version" : "2.6"
>   }
> },
> {
>   "href" : 
> "http://:/api/v1/stacks/HDP/versions/2.6/settings/stack_name",
>   "StackSettingsInfo" : {
> "property_name" : "stack_name",
> "stack_name" : "HDP",
> "stack_version" : "2.6"
>   }
> },
> {
>   "href" : 
> "http://:/api/v1/stacks/HDP/versions/2.6/settings/stack_packages",
>   "StackSettingsInfo" : {
> "property_name" : "stack_packages",
> "stack_name" : "HDP",
> "stack_version" : "2.6"
>   }
> },
> {
>   "href" : 
>

Re: Review Request 63441: Remove Slider from Ambari stack definition of HDP 3.0

2017-11-01 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63441/#review189818
---



This will break HIVE LLAP as it uses slider. Please don't make any changes to 
HDP-3.0 stack for now.

- Jayush Luniya


On Oct. 31, 2017, 1:35 p.m., Miklos Gergely wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63441/
> ---
> 
> (Updated Oct. 31, 2017, 1:35 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-22340
> https://issues.apache.org/jira/browse/AMBARI-22340
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Slider is no longer a service on it's own in HDP 3.0, it is a part of YARN. 
> So it should be removed from the stack definition.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/2.1.0.3.0/metainfo.xml 
> db490c9 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/configuration/slider-client.xml
>  adeba58 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/configuration/slider-env.xml
>  ce06a18 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/configuration/slider-log4j.xml
>  cd9b2a4 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/kerberos.json
>  8f07b42 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/metainfo.xml
>  168a2df 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/files/hbaseSmokeVerify.sh
>  5c320c0 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/__init__.py
>  5561e10 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/params.py
>  c03329c 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/params_linux.py
>  350be45 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/params_windows.py
>  fd2f358 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/service_check.py
>  8582b5e 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/slider.py
>  83c5629 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/scripts/slider_client.py
>  45c7785 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/package/templates/storm-slider-env.sh.j2
>  8022a4b 
>   
> ambari-server/src/main/resources/common-services/SLIDER/0.91.0.3.0/service_advisor.py
>  5614868 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/metainfo.xml 
> 061587d 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/SLIDER/metainfo.xml 
> 23f558d 
> 
> 
> Diff: https://reviews.apache.org/r/63441/diff/1/
> 
> 
> Testing
> ---
> 
> Tested on local vagrant cluster
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Re: Review Request 63457: Add service dependencies

2017-11-01 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63457/#review189815
---


Ship it!




Ship It!

- Jayush Luniya


On Nov. 1, 2017, 12:20 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63457/
> ---
> 
> (Updated Nov. 1, 2017, 12:20 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22345
> https://issues.apache.org/jira/browse/AMBARI-22345
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> API:
> {code}
> POST 
> http://SERVER:8080/api/v2/clusters/{cluster-id}/servicegroups/{sgId}/services
> 
> Request
> 
> {
>   "ServiceInfo" : {
> "service_name" : "{service-name}",
> "service_display_name" : "{service-display-name}",
> "service_version" : "{service-version}",
> "stack_id" : "{stack-id}",
> "hosting_platform" : "Ambari|Yarn"
>   }
>   "dependencies" : [
>   {
> "ServiceInfo" : {
>   "service_id" : "{dependent-service-id}",
>   "cluster_id" : "{dependent-cluster-id}",
>   "service_group_id" : "{dependent-service-group-id}",
>}
>   }
> ]
> }
> {code}
> 
> DB:
> Add table {{servicedependencies}}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  737b9b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceDependencyResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceResourceDefinition.java
>  8255674 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceKey.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
>  cb0ad20 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3117186 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  f75a7d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  b8c1674 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  cfab185 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceDependencyResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  6a76fff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterServiceEntity.java
>  9fca099 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 8fd878e 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
> b9ab79f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceFactory.java
>  b48d825 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> 167e4ca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  1e4d81f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  0434728 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c 
> 
> 
> Diff: https://reviews.apache.org/r/63457/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 63457: Add service dependencies

2017-11-01 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63457/#review189814
---




ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
Lines 172 (patched)


Similar feedback for using id as primary key as in the case of 
servicegroupdependencies. Please address those in a follow up commit.


- Jayush Luniya


On Nov. 1, 2017, 12:20 a.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63457/
> ---
> 
> (Updated Nov. 1, 2017, 12:20 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Swapan Shridhar.
> 
> 
> Bugs: AMBARI-22345
> https://issues.apache.org/jira/browse/AMBARI-22345
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> API:
> {code}
> POST 
> http://SERVER:8080/api/v2/clusters/{cluster-id}/servicegroups/{sgId}/services
> 
> Request
> 
> {
>   "ServiceInfo" : {
> "service_name" : "{service-name}",
> "service_display_name" : "{service-display-name}",
> "service_version" : "{service-version}",
> "stack_id" : "{stack-id}",
> "hosting_platform" : "Ambari|Yarn"
>   }
>   "dependencies" : [
>   {
> "ServiceInfo" : {
>   "service_id" : "{dependent-service-id}",
>   "cluster_id" : "{dependent-cluster-id}",
>   "service_group_id" : "{dependent-service-group-id}",
>}
>   }
> ]
> }
> {code}
> 
> DB:
> Add table {{servicedependencies}}
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  737b9b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceDependencyResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceResourceDefinition.java
>  8255674 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceKey.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceService.java
>  cb0ad20 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3117186 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  f75a7d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceDependencyResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  b8c1674 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  cfab185 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceDependencyResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  6a76fff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ClusterServiceEntity.java
>  9fca099 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 8fd878e 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Service.java 
> b9ab79f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceFactory.java
>  b48d825 
>   ambari-server/src/main/java/org/apache/ambari/server/state/ServiceImpl.java 
> 167e4ca 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  1e4d81f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  0434728 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c 
> 
> 
> Diff: https://reviews.apache.org/r/63457/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 63051: Add service group dependencies

2017-11-01 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63051/#review189813
---


Ship it!




Go ahead and commit this patch and make the suggested changes in a separate 
patch.

- Jayush Luniya


On Oct. 25, 2017, 11:18 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63051/
> ---
> 
> (Updated Oct. 25, 2017, 11:18 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22249
> https://issues.apache.org/jira/browse/AMBARI-22249
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add table servicegroupdependencies
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  737b9b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupDependencyResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupResourceDefinition.java
>  13bdd7b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java
>  1e2eaf4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3117186 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  f75a7d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  b8c1674 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  cfab185 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
>  2e935af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  6a76fff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java
>  7f8facb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 8fd878e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 
> 9850462 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java
>  7146bdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
>  735a946 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  1e4d81f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  0434728 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c 
> 
> 
> Diff: https://reviews.apache.org/r/63051/diff/8/
> 
> 
> Testing
> ---
> 
> Will fix tests after patch approve
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 63051: Add service group dependencies

2017-11-01 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63051/#review189812
---




ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
Lines 162 (patched)


Add an id column to the table as primary key (i.e. dependency_id)



ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql
Lines 167 (patched)


Make this as unique constraint rather than primary key and add "id" as 
primary key. See alerts tables for example

CREATE TABLE alert_group (
  group_id BIGINT NOT NULL,
  cluster_id BIGINT NOT NULL,
  group_name VARCHAR(255) NOT NULL,
  is_default SMALLINT NOT NULL DEFAULT 0,
  service_name VARCHAR(255),
  CONSTRAINT PK_alert_group PRIMARY KEY (group_id),
  CONSTRAINT uni_alert_group_name UNIQUE(cluster_id,group_name)
);


- Jayush Luniya


On Oct. 25, 2017, 11:18 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63051/
> ---
> 
> (Updated Oct. 25, 2017, 11:18 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22249
> https://issues.apache.org/jira/browse/AMBARI-22249
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add table servicegroupdependencies
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  737b9b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupDependencyResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupResourceDefinition.java
>  13bdd7b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java
>  1e2eaf4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3117186 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  f75a7d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  b8c1674 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  cfab185 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
>  2e935af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  6a76fff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java
>  7f8facb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 8fd878e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 
> 9850462 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java
>  7146bdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
>  735a946 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  1e4d81f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  0434728 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c 
> 
> 
> Diff: https://reviews.apache.org/r/63051/diff/8/
> 
> 
> Testing
> ---
> 
> Will fix tests after patch approve
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 63051: Add service group dependencies

2017-11-01 Thread Jayush Luniya 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63051/#review189810
---



[~vbrodetskyi]
Generally this API looks good. If we make the API to use dependency_id instead 
of dependency_service_group_name as key we can potentially support 
cross-cluster mappings. You can either make this change in this iteration or 
make the change in a separate patch.

{code}
GET /api/v1/clusters/fff/servicegroups/core/dependencies/1
{
  "ServiceGroupDependencyInfo" : {
"cluster_id" : 2,
"cluster_name" : "fff",
"service_group_id" : 2,
"service_group_name" : "core",
"dependency_id" : 1,
"dependency_cluster_id" : 2,
"dependency_cluster_name" : "fff",
"dependency_service_group_id" : 5,
"dependency_service_group_name" : "test2"
  }
}
{code}

- Jayush Luniya


On Oct. 25, 2017, 11:18 p.m., Vitalyi Brodetskyi wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63051/
> ---
> 
> (Updated Oct. 25, 2017, 11:18 p.m.)
> 
> 
> Review request for Ambari, Jayush Luniya, Myroslav Papirkovskyy, and Swapan 
> Shridhar.
> 
> 
> Bugs: AMBARI-22249
> https://issues.apache.org/jira/browse/AMBARI-22249
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Add table servicegroupdependencies
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  737b9b4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupDependencyResourceDefinition.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ServiceGroupResourceDefinition.java
>  13bdd7b 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupKey.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ServiceGroupService.java
>  1e2eaf4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  3117186 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  f75a7d5 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyRequest.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ServiceGroupDependencyResponse.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  b8c1674 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/DefaultProviderModule.java
>  cfab185 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupDependencyResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java
>  2e935af 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  6a76fff 
>   
> ambari-server/src/main/java/org/apache/ambari/server/orm/entities/ServiceGroupEntity.java
>  7f8facb 
>   ambari-server/src/main/java/org/apache/ambari/server/state/Cluster.java 
> 8fd878e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroup.java 
> 9850462 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupFactory.java
>  7146bdf 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/ServiceGroupImpl.java
>  735a946 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/cluster/ClusterImpl.java
>  1e4d81f 
>   
> ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java
>  0434728 
>   ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql b8c0a42 
>   ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql c56e486 
>   ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 8917d48 
>   ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql f48bcd6 
>   ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql e7c5c72 
>   ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql f87af4c 
> 
> 
> Diff: https://reviews.apache.org/r/63051/diff/8/
> 
> 
> Testing
> ---
> 
> Will fix tests after patch approve
> 
> 
> Thanks,
> 
> Vitalyi Brodetskyi
> 
>

Re: Review Request 63450: Improve KDC integration

2017-11-01 Thread Robert Nettleton 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63450/#review189799
---


Ship it!




Ship It!

- Robert Nettleton


On Oct. 31, 2017, 9:03 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63450/
> ---
> 
> (Updated Oct. 31, 2017, 9:03 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Laszlo Puskas, Nate Cole, Robert Nettleton, and 
> Sebastian Toader.
> 
> 
> Bugs: AMBARI-22293
> https://issues.apache.org/jira/browse/AMBARI-22293
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Improve KDC integration by making the interfaces more consistent with each 
> other.
> 
> #Notes:
> - When using the MIT KDC or IPA options, the `kerberos-env/admin_server_host` 
> value *must be the fully qualified domain name* (FQDN) of the host were the 
> KDC administrator service is. 
> - When connecting to the MIT KDC and IPA server, a username a password is not 
> used to authenticate using the kadmin utility.  A Kerberos ticket is first 
> acquired and that is used for authentication.
> - When creating Kerberos identities using the MIT KDC and IPA handlers, the 
> Ambari-generated password is not used.  All password's for principals in the 
> MIT KDC and IP server are generated randomly by the KDC.
> - Removed `kerberos-env/set_password_expiry` and 
> `kerberos-env/password_chat_timeout` properties since they are no longer 
> needed
> - Changed `kerberos-env/groups` to `kerberos-env/ipa_user_groups` to be more 
> explicit in how the property is used.
> - The setPassword implementation for the MIT KDC and IPA handlers do nothing 
> except check to see if the relevant principal exists. This is to maintain 
> backward compatibility with previous implementations.
> 
> 
> Diffs
> -
> 
>   ambari-server/docs/security/kerberos/kerberos_service.md 65e312b866 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandler.java
>  f7d6060710 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/CreatePrincipalsServerAction.java
>  1c0853b98e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java
>  2b3a0ca40d 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/IPAKerberosOperationHandler.java
>  9a6a07e4d3 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KDCKerberosOperationHandler.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandler.java
>  8749f81068 
>   
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
>  0997f650f8 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog300.java
>  bfe2a1346e 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-10/configuration/kerberos-env.xml
>  0a081215ec 
>   
> ambari-server/src/main/resources/common-services/KERBEROS/1.10.3-30/configuration/kerberos-env.xml
>  0a081215ec 
>   
> ambari-server/src/main/resources/stacks/PERF/1.0/services/KERBEROS/configuration/kerberos-env.xml
>  66e81dbb00 
>   
> ambari-server/src/test/java/org/apache/ambari/server/controller/KerberosHelperTest.java
>  7ed52d2782 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/ADKerberosOperationHandlerTest.java
>  483cc0aed2 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/IPAKerberosOperationHandlerTest.java
>  f2a09bafb9 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KDCKerberosOperationHandlerTest.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosOperationHandlerTest.java
>  88c841c3a1 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/KerberosServerActionTest.java
>  a43db4d12c 
>   
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java
>  04d03bebb5 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog300Test.java
>  25e9dbf739 
>   ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-secured.json 
> 288d155c47 
>   ambari-server/src/test/python/stacks/2.5/configs/ranger-kms-secured.json 
> f7f054a0db 
>   ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-secured.json 
> 38b59061b4 
>   ambari-server/src/test/resources/PreconfigureActionTest_cluster_config.json 
> 2a744c70be 
>

Review Request 63464: Beeline connection hangs for longer time when connection to HS2 with metastore DB down

2017-11-01 Thread Andrew Onischuk 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63464/
---

Review request for Ambari and Vitalyi Brodetskyi.


Bugs: AMBARI-22346
https://issues.apache.org/jira/browse/AMBARI-22346


Repository: ambari


Description
---

PROBLEM:  
beeline connection to HS2 hangs when hive metastore Database is down.  
Issue seen on HDP 2.5.3 and 2.6 version clusters, same test on HDP 2.4.2
beeline doesn't hangs.

BUSINESS IMPACT:  
Ambari spawning multiple beeline processes thats hanging causes unnecessary
memory usage, resulting in master service failures.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/alerts/alert_hive_thrift_port.py
 3560bf82f5 


Diff: https://reviews.apache.org/r/63464/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk