Re: Review Request 63138: Update Spark2 log4j default settings to latest

[Swapan Shridhar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63138/#review191125
---


Ship it!




Ship It!

- Swapan Shridhar


On Oct. 19, 2017, 5:59 a.m., Saisai Shao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63138/
> ---
> 
> (Updated Oct. 19, 2017, 5:59 a.m.)
> 
> 
> Review request for Ambari, Jayush Luniya and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-22260
> https://issues.apache.org/jira/browse/AMBARI-22260
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Update Ambari Spark2 log4j related configurations.
> 
> 
> Diffs
> -
> 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/config-upgrade.xml 
> d138d6017c 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml
>  8012c90b0b 
>   ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml 
> 7c43948ba3 
>   
> ambari-server/src/main/resources/stacks/HDP/2.6/services/SPARK2/configuration/spark2-log4j-properties.xml
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/63138/diff/1/
> 
> 
> Testing
> ---
> 
> Manually verification on refresh install of HDP 2.6 and upgrade from HDP 2.5.
> 
> 
> Thanks,
> 
> Saisai Shao
> 
>

Re: Review Request 63847: AMBARI-22445. Warn the user appropriately for default MySQL server install for Hive

[Ishan Bhatt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63847/#review191101
---


Ship it!




Ship It!

- Ishan Bhatt


On Nov. 15, 2017, 7:19 p.m., Vivek Ratnavel Subramanian wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63847/
> ---
> 
> (Updated Nov. 15, 2017, 7:19 p.m.)
> 
> 
> Review request for Ambari, Ishan Bhatt and Yusaku Sako.
> 
> 
> Bugs: AMBARI-22445
> https://issues.apache.org/jira/browse/AMBARI-22445
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The mysql connector license is not compatible with Ambari's license and 
> Ambari no longer auto installs mysql-connector after AMBARI-22369. Warn the 
> user appropriately to install and setup mysql-connector to be used by Hive.
> 
> 
> Diffs
> -
> 
>   ambari-web/app/views/common/controls_view.js f03e5c0 
>   ambari-web/test/views/common/controls_view_test.js c5c5338 
> 
> 
> Diff: https://reviews.apache.org/r/63847/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested.
> Ambari-web unit tests pass
>   30518 passing (27s)
>   157 pending
> 
> 
> Thanks,
> 
> Vivek Ratnavel Subramanian
> 
>

Review Request 63847: AMBARI-22445. Warn the user appropriately for default MySQL server install for Hive

[Vivek Ratnavel Subramanian]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63847/
---

Review request for Ambari, Ishan Bhatt and Yusaku Sako.


Bugs: AMBARI-22445
https://issues.apache.org/jira/browse/AMBARI-22445


Repository: ambari


Description
---

The mysql connector license is not compatible with Ambari's license and Ambari 
no longer auto installs mysql-connector after AMBARI-22369. Warn the user 
appropriately to install and setup mysql-connector to be used by Hive.


Diffs
-

  ambari-web/app/views/common/controls_view.js f03e5c0 
  ambari-web/test/views/common/controls_view_test.js c5c5338 


Diff: https://reviews.apache.org/r/63847/diff/1/


Testing
---

Manually tested.
Ambari-web unit tests pass
  30518 passing (27s)
  157 pending


Thanks,

Vivek Ratnavel Subramanian

Re: Review Request 63838: ambari-server setup should surface GPL software agreement

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63838/#review191077
---


Fix it, then Ship it!





ambari-server/src/main/python/ambari-server.py
Lines 516 (patched)


Rename to be more explicit based o nthe realtime board: 
--enable-lzo-under-gpl-license


- Sid Wagle


On Nov. 15, 2017, 2:34 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63838/
> ---
> 
> (Updated Nov. 15, 2017, 2:34 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
> 
> 
> Bugs: AMBARI-22453
> https://issues.apache.org/jira/browse/AMBARI-22453
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Ask the user if they are okay with installing GPL license software
>   * Surface the license agreement subtext, for now use placeholder
>   * Save the result in ambari.properties
>   * The user selection should be available through API for the client and 
> also stack scripts
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  91df506478 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  0bd6af6611 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d8712f2c75 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  0b048ad089 
>   ambari-server/src/main/python/ambari-server.py 60c60052cc 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 
> c7ac13476f 
>   ambari-server/src/main/python/ambari_server/serverSetup.py c1643f2621 
> 
> 
> Diff: https://reviews.apache.org/r/63838/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 63805: Make Ambari configuration API consistent with existing API.

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63805/#review191071
---


Ship it!




Ship It!

- Jonathan Hurley


On Nov. 14, 2017, 2:47 p.m., Robert Levas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63805/
> ---
> 
> (Updated Nov. 14, 2017, 2:47 p.m.)
> 
> 
> Review request for Ambari, Attila Magyar, Balázs Bence Sári, Eugene 
> Chekanskiy, Jonathan Hurley, Nate Cole, and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22418
> https://issues.apache.org/jira/browse/AMBARI-22418
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Make Ambari configuration API consistent with existing API. 
> 
> The current API entry point (as of AMBARI-21307) is 
> {{/api/v1/ambariconfigs}}. This should be more inline with the existing entry 
> point for Ambari server related data...  
> {{/api/v1/services/AMBARI/components/AMBARI_SERVER}}.  
> 
> The new API entry point for Ambari server related configuration data should 
> be {{/api/v1/services/AMBARI/components/AMBARI_SERVER/configurations}}.
> 
> See https://issues.apache.org/jira/browse/AMBARI-22418 for details about the 
> new entryoint.
> 
> *NOTE*: This patch contains a fix for a stack advisor issue that was 
> introduce in the patch for https://issues.apache.org/jira/browse/AMBARI-22347.
> 
> *NOTE*: Many changes are due to moving `RootServiceResponseFactory.Services` 
> from an inner class to `RootService` and 
> `RootServiceResponseFactory.Components` from an inner class to 
> `RootComponent`.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/ResourceInstanceFactoryImpl.java
>  f5fb6e9900 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RootServiceComponentResourceDefinition.java
>  e8cb570c56 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationRequestSwagger.java
>  2dca9f55f4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationResponseSwagger.java
>  c55ac1dd60 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariConfigurationService.java
>  86ed666f41 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java
>  46ee65abea 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RootServiceComponentConfigurationService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/RootServiceService.java
>  5afb7dc90c 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/AmbariConfiguration.java
>  e9f0b1e1a4 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigurationRequest.java
>  2e478c4329 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/ldap/LdapConfigurationService.java
>  00c13f6cfa 
>   
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
>  91edf867ae 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ControllerModule.java
>  1425e1bd32 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/MaintenanceStateHelper.java
>  d9a585f630 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/ResourceProviderFactory.java
>  711ae10f7e 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootComponent.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootService.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/RootServiceResponseFactory.java
>  ad9ed202dc 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AbstractControllerResourceProvider.java
>  1dc0841d19 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/AmbariConfigurationResourceProvider.java
>  a24400dffd 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentConfigurationResourceProvider.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentPropertyProvider.java
>  433c1fae90 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/RootServiceComponentResourceProvider.java
>  3925aebdae 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java
>  78353735ac 
>   
> ambari-server/src/main/java/org/apache/ambari/server/events/listeners/alerts/AlertReceivedListener.java
>  266c7e81c1 
>   
> 

Re: Review Request 63839: Ambari Logsearch Web unit tests are sometimes failing

[Aleksandr Kovalenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63839/#review191069
---


Ship it!




Ship It!

- Aleksandr Kovalenko


On Ноя. 15, 2017, 3:41 п.п., Andrii Babiichuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63839/
> ---
> 
> (Updated Ноя. 15, 2017, 3:41 п.п.)
> 
> 
> Review request for Ambari and Aleksandr Kovalenko.
> 
> 
> Bugs: AMBARI-22455
> https://issues.apache.org/jira/browse/AMBARI-22455
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Ambari Logsearch Web unit tests fail on CI builds:
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/ambari-logsearch-web/src/app/services/auth.service.spec.ts 
> a465c10 
> 
> 
> Diff: https://reviews.apache.org/r/63839/diff/1/
> 
> 
> Testing
> ---
> 
> Executed 206 of 206 SUCCESS (8.096 secs / 8.004 secs)
> 
> 
> Thanks,
> 
> Andrii Babiichuk
> 
>

Review Request 63839: Ambari Logsearch Web unit tests are sometimes failing

[Andrii Babiichuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63839/
---

Review request for Ambari and Aleksandr Kovalenko.


Bugs: AMBARI-22455
https://issues.apache.org/jira/browse/AMBARI-22455


Repository: ambari


Description
---

Ambari Logsearch Web unit tests fail on CI builds:


Diffs
-

  ambari-logsearch/ambari-logsearch-web/src/app/services/auth.service.spec.ts 
a465c10 


Diff: https://reviews.apache.org/r/63839/diff/1/


Testing
---

Executed 206 of 206 SUCCESS (8.096 secs / 8.004 secs)


Thanks,

Andrii Babiichuk

Re: Review Request 63838: ambari-server setup should surface GPL software agreement

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63838/#review191067
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
Lines 734-735 (patched)


I'd prefer type `Boolean` (and possibly default value of `Boolean.FALSE`).



ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
Lines 5332 (patched)


Looks like this would throw NPE if the property `gpl.license.accepted` is 
not present in `ambari.properties`.  How about using `Boolean.valueOf(String)`?


- Attila Doroszlai


On Nov. 15, 2017, 3:34 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63838/
> ---
> 
> (Updated Nov. 15, 2017, 3:34 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
> 
> 
> Bugs: AMBARI-22453
> https://issues.apache.org/jira/browse/AMBARI-22453
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Ask the user if they are okay with installing GPL license software
>   * Surface the license agreement subtext, for now use placeholder
>   * Save the result in ambari.properties
>   * The user selection should be available through API for the client and 
> also stack scripts
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  91df506478 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  0bd6af6611 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d8712f2c75 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  0b048ad089 
>   ambari-server/src/main/python/ambari-server.py 60c60052cc 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 
> c7ac13476f 
>   ambari-server/src/main/python/ambari_server/serverSetup.py c1643f2621 
> 
> 
> Diff: https://reviews.apache.org/r/63838/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Re: Review Request 63832: Reference Log Feeder IDE/maven dev setup in README.md

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63832/#review191065
---


Ship it!




Ship It!

- Robert Nettleton


On Nov. 15, 2017, 11:35 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63832/
> ---
> 
> (Updated Nov. 15, 2017, 11:35 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Krisztian Kasa, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22450
> https://issues.apache.org/jira/browse/AMBARI-22450
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> small patch to reference logfeeder reamdme in the parent readme
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/README.md 33952a2 
> 
> 
> Diff: https://reviews.apache.org/r/63832/diff/1/
> 
> 
> Testing
> ---
> 
> not required.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63838: ambari-server setup should surface GPL software agreement

[Robert Nettleton]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63838/#review191064
---


Fix it, then Ship it!




Overall, the patch looks fine, just a minor javadoc issue that should be 
addressed. 

Thanks.


ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
Lines 729 (patched)


Minor issue:  This javadoc comment doesn't reflect the actual property 
being added.  This just looks like a copy and paste error, but is probably 
worth fixing for the sake of clarity.


- Robert Nettleton


On Nov. 15, 2017, 2:34 p.m., Andrew Onischuk wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63838/
> ---
> 
> (Updated Nov. 15, 2017, 2:34 p.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.
> 
> 
> Bugs: AMBARI-22453
> https://issues.apache.org/jira/browse/AMBARI-22453
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> * Ask the user if they are okay with installing GPL license software
>   * Surface the license agreement subtext, for now use placeholder
>   * Save the result in ambari.properties
>   * The user selection should be available through API for the client and 
> also stack scripts
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
>  91df506478 
>   
> ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
>  0bd6af6611 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
>  d8712f2c75 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
>  0b048ad089 
>   ambari-server/src/main/python/ambari-server.py 60c60052cc 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py 
> c7ac13476f 
>   ambari-server/src/main/python/ambari_server/serverSetup.py c1643f2621 
> 
> 
> Diff: https://reviews.apache.org/r/63838/diff/1/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>

Review Request 63838: ambari-server setup should surface GPL software agreement

[Andrew Onischuk]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63838/
---

Review request for Ambari, Myroslav Papirkovskyy and Sid Wagle.


Bugs: AMBARI-22453
https://issues.apache.org/jira/browse/AMBARI-22453


Repository: ambari


Description
---

* Ask the user if they are okay with installing GPL license software
  * Surface the license agreement subtext, for now use placeholder
  * Save the result in ambari.properties
  * The user selection should be available through API for the client and also 
stack scripts


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/agent/ExecutionCommand.java
 91df506478 
  
ambari-server/src/main/java/org/apache/ambari/server/configuration/Configuration.java
 0bd6af6611 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariCustomCommandExecutionHelper.java
 d8712f2c75 
  
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ClientConfigResourceProvider.java
 0b048ad089 
  ambari-server/src/main/python/ambari-server.py 60c60052cc 
  ambari-server/src/main/python/ambari_server/serverConfiguration.py c7ac13476f 
  ambari-server/src/main/python/ambari_server/serverSetup.py c1643f2621 


Diff: https://reviews.apache.org/r/63838/diff/1/


Testing
---

mvn clean test


Thanks,

Andrew Onischuk

Re: Review Request 63807: Add Native Libraries To Tez Tarball

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63807/
---

(Updated Nov. 15, 2017, 9:07 a.m.)


Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.


Bugs: AMBARI-22444
https://issues.apache.org/jira/browse/AMBARI-22444


Repository: ambari


Description
---

As part of the investigation for getting patch upgrades working in Ambari 
2.6.1, it was determined that the Tez tarball will need to have the hadoop 
native libraries added to it so that they can be detected from the tarball.

STR:
- Install ZK, MapR, Tez, Yarn, Hive
- Enable a non-LZO codec, like Snappy
- Patch Hive to a new version
- Change the following properties in {{tez-site}}:
-- tez.am.launch.env = LD_LIBRARY=./tezlib/lib/native
-- tez.task.launch.env = LD_LIBRARY=./tezlib/lib/native

When Hive commands run, they will attempt to load the native snappy libraries 
from the Tez tarball and will fail with:
{code}
Caused by: java.io.IOException: Unable to get CompressorType for codec 
(org.apache.hadoop.io.compress.SnappyCodec). This is most likely due to missing 
native libraries for the codec.
at 
org.apache.tez.runtime.library.common.sort.impl.ExternalSorter.(ExternalSorter.java:217)
{code}

In order to fix this, the Tez tarball should include the native hadoop 
libraries as well:
{code}
??? tez
?   ??? lib
?   ?   ??? native
?   ?   ?   ??? libhadoop.a
?   ?   ?   ??? libhadoop.so -> libhadoop.so.1.0.0
?   ?   ?   ??? libhadoop.so.1.0.0
?   ?   ?   ??? libhadooppipes.a
?   ?   ?   ??? libhadooputils.a
?   ?   ?   ??? libhdfs.a
?   ?   ?   ??? libhdfs.so -> libhdfs.so.0.0.0
?   ?   ?   ??? libhdfs.so.0.0.0
?   ?   ?   ??? libsnappy.so -> libsnappy.so.1.1.4
?   ?   ?   ??? libsnappy.so.1 -> libsnappy.so.1.1.4
?   ?   ?   ??? libsnappy.so.1.1.4
{code}


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
 03b6213ac4 
  
ambari-common/src/main/python/resource_management/libraries/functions/tar_archive.py
 c682c3e24a 


Diff: https://reviews.apache.org/r/63807/diff/2/

Changes: https://reviews.apache.org/r/63807/diff/1-2/


Testing
---

Manual testing to ensure the file is created and uploaded.

UNIT TESTS PENDING...


Thanks,

Jonathan Hurley

Re: Review Request 63822: Oozie Jobs on Hive Fail With Missing Tarball

[Jonathan Hurley]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63822/#review191059
---


Ship it!




Ship It!

- Jonathan Hurley


On Nov. 14, 2017, 8:57 p.m., Nate Cole wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63822/
> ---
> 
> (Updated Nov. 14, 2017, 8:57 p.m.)
> 
> 
> Review request for Ambari and Jonathan Hurley.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> STR:
> - Install an HDP 2.6.3.0 cluster with Oozie, HIve, MapR, Yarn, ZK, HDFS
> - Patch only Oozie to a new version, such as 2.6.3.1-1
> - Attempt to run an Oozie job on Hive
> 
> The workflow job will fail with:
> {code}
> org.apache.oozie.action.ActionExecutorException: JA008: File does not exist: 
> hdfs://jhurley-pu-1.openstacklocal:8020/hdp/apps/2.6.3.1-1/mapreduce/mapreduce.tar.gz
>   at 
> org.apache.oozie.action.ActionExecutor.convertExceptionHelper(ActionExecutor.java:457)
>   at 
> org.apache.oozie.action.ActionExecutor.convertException(ActionExecutor.java:441)
>   at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.submitLauncher(JavaActionExecutor.java:1211)
>   at 
> org.apache.oozie.action.hadoop.JavaActionExecutor.start(JavaActionExecutor.java:1382)
>   at 
> org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:234)
>   at 
> org.apache.oozie.command.wf.ActionStartXCommand.execute(ActionStartXCommand.java:65)
>   at org.apache.oozie.command.XCommand.call(XCommand.java:287)
>   at 
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:331)
>   at 
> org.apache.oozie.service.CallableQueueService$CompositeCallable.call(CallableQueueService.java:260)
>   at java.util.concurrent.FutureTask.run(FutureTask.java:266)
>   at 
> org.apache.oozie.service.CallableQueueService$CallableWrapper.run(CallableQueueService.java:178)
>   at 
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
>   at 
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
>   at java.lang.Thread.run(Thread.java:745)
> {code}
> 
> This is because Oozie appears to be trying to use a version of the MapReduce 
> tarball which matches its version. However, since it does not ship its 
> version, it cannot find it.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_packages.json
>  68e6bf806c 
> 
> 
> Diff: https://reviews.apache.org/r/63822/diff/1/
> 
> 
> Testing
> ---
> 
> Manual.  Follow STR, then ran an oozie-on-hive job to confirm results.
> 
> 
> No automated tests, as they exist already.
> 
> 
> Thanks,
> 
> Nate Cole
> 
>

Re: Review Request 63832: Reference Log Feeder IDE/maven dev setup in README.md

[Krisztian Kasa]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63832/#review191057
---


Ship it!




Ship It!

- Krisztian Kasa


On Nov. 15, 2017, 11:35 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63832/
> ---
> 
> (Updated Nov. 15, 2017, 11:35 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Krisztian Kasa, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22450
> https://issues.apache.org/jira/browse/AMBARI-22450
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> small patch to reference logfeeder reamdme in the parent readme
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/README.md 33952a2 
> 
> 
> Diff: https://reviews.apache.org/r/63832/diff/1/
> 
> 
> Testing
> ---
> 
> not required.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63832: Reference Log Feeder IDE/maven dev setup in README.md

[Attila Magyar]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63832/#review191049
---


Ship it!




Ship It!

- Attila Magyar


On Nov. 15, 2017, 11:35 a.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63832/
> ---
> 
> (Updated Nov. 15, 2017, 11:35 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Krisztian Kasa, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22450
> https://issues.apache.org/jira/browse/AMBARI-22450
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> small patch to reference logfeeder reamdme in the parent readme
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/README.md 33952a2 
> 
> 
> Diff: https://reviews.apache.org/r/63832/diff/1/
> 
> 
> Testing
> ---
> 
> not required.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Re: Review Request 63832: Reference Log Feeder IDE/maven dev setup in README.md

[Attila Doroszlai]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63832/#review191048
---


Ship it!




Ship It!

- Attila Doroszlai


On Nov. 15, 2017, 12:35 p.m., Oliver Szabo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63832/
> ---
> 
> (Updated Nov. 15, 2017, 12:35 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Krisztian Kasa, 
> and Robert Nettleton.
> 
> 
> Bugs: AMBARI-22450
> https://issues.apache.org/jira/browse/AMBARI-22450
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> small patch to reference logfeeder reamdme in the parent readme
> 
> 
> Diffs
> -
> 
>   ambari-logsearch/README.md 33952a2 
> 
> 
> Diff: https://reviews.apache.org/r/63832/diff/1/
> 
> 
> Testing
> ---
> 
> not required.
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>

Review Request 63832: Reference Log Feeder IDE/maven dev setup in README.md

[Oliver Szabo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63832/
---

Review request for Ambari, Attila Doroszlai, Attila Magyar, Krisztian Kasa, and 
Robert Nettleton.


Bugs: AMBARI-22450
https://issues.apache.org/jira/browse/AMBARI-22450


Repository: ambari


Description
---

small patch to reference logfeeder reamdme in the parent readme


Diffs
-

  ambari-logsearch/README.md 33952a2 


Diff: https://reviews.apache.org/r/63832/diff/1/


Testing
---

not required.


Thanks,

Oliver Szabo

Re: Review Request 63807: Add Native Libraries To Tez Tarball

[Dmitro Lisnichenko]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63807/#review191046
---


Ship it!




Ship It!

- Dmitro Lisnichenko


On Nov. 14, 2017, 11:21 p.m., Jonathan Hurley wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63807/
> ---
> 
> (Updated Nov. 14, 2017, 11:21 p.m.)
> 
> 
> Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.
> 
> 
> Bugs: AMBARI-22444
> https://issues.apache.org/jira/browse/AMBARI-22444
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> As part of the investigation for getting patch upgrades working in Ambari 
> 2.6.1, it was determined that the Tez tarball will need to have the hadoop 
> native libraries added to it so that they can be detected from the tarball.
> 
> STR:
> - Install ZK, MapR, Tez, Yarn, Hive
> - Enable a non-LZO codec, like Snappy
> - Patch Hive to a new version
> - Change the following properties in {{tez-site}}:
> -- tez.am.launch.env = LD_LIBRARY=./tezlib/lib/native
> -- tez.task.launch.env = LD_LIBRARY=./tezlib/lib/native
> 
> When Hive commands run, they will attempt to load the native snappy libraries 
> from the Tez tarball and will fail with:
> {code}
> Caused by: java.io.IOException: Unable to get CompressorType for codec 
> (org.apache.hadoop.io.compress.SnappyCodec). This is most likely due to 
> missing native libraries for the codec.
>   at 
> org.apache.tez.runtime.library.common.sort.impl.ExternalSorter.(ExternalSorter.java:217)
> {code}
> 
> In order to fix this, the Tez tarball should include the native hadoop 
> libraries as well:
> {code}
> ??? tez
> ?   ??? lib
> ?   ?   ??? native
> ?   ?   ?   ??? libhadoop.a
> ?   ?   ?   ??? libhadoop.so -> libhadoop.so.1.0.0
> ?   ?   ?   ??? libhadoop.so.1.0.0
> ?   ?   ?   ??? libhadooppipes.a
> ?   ?   ?   ??? libhadooputils.a
> ?   ?   ?   ??? libhdfs.a
> ?   ?   ?   ??? libhdfs.so -> libhdfs.so.0.0.0
> ?   ?   ?   ??? libhdfs.so.0.0.0
> ?   ?   ?   ??? libsnappy.so -> libsnappy.so.1.1.4
> ?   ?   ?   ??? libsnappy.so.1 -> libsnappy.so.1.1.4
> ?   ?   ?   ??? libsnappy.so.1.1.4
> {code}
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py
>  03b6213ac4 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/tar_archive.py
>  c682c3e24a 
> 
> 
> Diff: https://reviews.apache.org/r/63807/diff/1/
> 
> 
> Testing
> ---
> 
> Manual testing to ensure the file is created and uploaded.
> 
> UNIT TESTS PENDING...
> 
> 
> Thanks,
> 
> Jonathan Hurley
> 
>