Re: Review Request 64349: LogFeeder: filter objects for wildcard input paths need to be cloned

2017-12-05 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64349/#review192963 --- Ship it! Ok good for now. This area definitely seems like it

Re: Review Request 64349: LogFeeder: filter objects for wildcard input paths need to be cloned

2017-12-05 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64349/#review192930 ---

Re: Review Request 64349: LogFeeder: filter objects for wildcard input paths need to be cloned

2017-12-05 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64349/ --- (Updated Dec. 5, 2017, 8:50 p.m.) Review request for Ambari, Krisztian Kasa,

Re: Review Request 64311: AMBARI-22574 Failed to restart services on PPC cluster post Ambari upgrade for IOP/HDP migration

2017-12-05 Thread Di Li
> On Dec. 5, 2017, 1:01 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog261.java > > Lines 154 (patched) > > > > > > We really shouldn't be hardcoding

Review Request 64349: LogFeeder: filters for wildcard input paths need to be cloned

2017-12-05 Thread Oliver Szabo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64349/ --- Review request for Ambari, Krisztian Kasa, Miklos Gergely, and Robert Nettleton.

Re: Review Request 64311: AMBARI-22574 Failed to restart services on PPC cluster post Ambari upgrade for IOP/HDP migration

2017-12-05 Thread Dmytro Grinenko
> On Dec. 5, 2017, 1:01 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog261.java > > Lines 154 (patched) > > > > > > We really shouldn't be hardcoding

Re: Review Request 64311: AMBARI-22574 Failed to restart services on PPC cluster post Ambari upgrade for IOP/HDP migration

2017-12-05 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64311/ --- (Updated Dec. 5, 2017, 7:11 p.m.) Review request for Ambari, Jonathan Hurley

Re: Review Request 64311: AMBARI-22574 Failed to restart services on PPC cluster post Ambari upgrade for IOP/HDP migration

2017-12-05 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64311/#review192899 --- Ship it!

Re: Review Request 64348: Pig service check failed after PU with LzoCodec CNF

2017-12-05 Thread Dmytro Grinenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64348/#review192898 --- Ship it! Ship It! - Dmytro Grinenko On Dec. 5, 2017, 6:33

Re: Review Request 64346: Jetty Session Timeout Is Overridden By Views Initialization. (mpapirkovskyy)

2017-12-05 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64346/#review192896 --- Ship it! Ship It! - Jonathan Hurley On Dec. 5, 2017, 12:46

Re: Review Request 64346: Jetty Session Timeout Is Overridden By Views Initialization. (mpapirkovskyy)

2017-12-05 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64346/#review192897 --- Ship it! Ship It! - Jonathan Hurley On Dec. 5, 2017, 12:46

Review Request 64348: Pig service check failed after PU with LzoCodec CNF

2017-12-05 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64348/ --- Review request for Ambari, Dmytro Grinenko, Dmitro Lisnichenko, and Nate Cole.

Re: Review Request 64344: AMBARI-22589 Ambari web UI stack version page is empty due to NPE when target stack does not contain all services from the current stack

2017-12-05 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64344/ --- (Updated Dec. 5, 2017, 6:28 p.m.) Review request for Ambari, Alexandr

Re: Review Request 64311: AMBARI-22574 Failed to restart services on PPC cluster post Ambari upgrade for IOP/HDP migration

2017-12-05 Thread Tim Thorpe
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64311/#review192887 --- Ship it! Ship It! - Tim Thorpe On Dec. 5, 2017, 5:39 p.m.,

Review Request 64346: Jetty Session Timeout Is Overridden By Views Initialization. (mpapirkovskyy)

2017-12-05 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64346/ --- Review request for Ambari, Jonathan Hurley and Sid Wagle. Bugs: AMBARI-22597

Re: Review Request 64311: AMBARI-22574 Failed to restart services on PPC cluster post Ambari upgrade for IOP/HDP migration

2017-12-05 Thread Di Li
> On Dec. 5, 2017, 1:01 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog261.java > > Lines 154 (patched) > > > > > > We really shouldn't be hardcoding

Re: Review Request 64311: AMBARI-22574 Failed to restart services on PPC cluster post Ambari upgrade for IOP/HDP migration

2017-12-05 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64311/ --- (Updated Dec. 5, 2017, 5:39 p.m.) Review request for Ambari, Jonathan Hurley

Re: Review Request 64340: Livy server start fails during EU with 'Address already in use' error

2017-12-05 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64340/ --- (Updated Dec. 5, 2017, 7:29 p.m.) Review request for Ambari, Dmytro Grinenko,

Re: Review Request 64315: Hive Client restart fails: hadooplzo package not present in iop repos

2017-12-05 Thread Sid Wagle
> On Dec. 5, 2017, 4:56 p.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/lzo_utils.py > > Lines 72 (patched) > > > > > > Maybe also logger.info "This stack does

Re: Review Request 64315: Hive Client restart fails: hadooplzo package not present in iop repos

2017-12-05 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64315/#review192882 --- Ship it! 2 small nits

Re: Review Request 64340: PREVIEW - Livy server start fails during EU with 'Address already in use' error

2017-12-05 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64340/#review192881 --- Ship it! Ship It! - Jonathan Hurley On Dec. 5, 2017, 10:04

Re: Review Request 64315: Hive Client restart fails: hadooplzo package not present in iop repos

2017-12-05 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64315/ --- (Updated Dec. 5, 2017, 4:51 p.m.) Review request for Ambari, Aravindan Vijayan

Review Request 64344: AMBARI-22589 Ambari web UI stack version page is empty due to NPE when target stack does not contain all services from the current stack

2017-12-05 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64344/ --- Review request for Ambari, Alexandr Antonenko and Sangeeta Ravindran. Bugs:

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-12-05 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192874 --- Ship it! Ship It! - Sid Wagle On Dec. 5, 2017, 11:04 a.m.,

Re: Review Request 64340: PREVIEW - Livy server start fails during EU with 'Address already in use' error

2017-12-05 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64340/#review192871 --- Ship it! Ship It! - Nate Cole On Dec. 5, 2017, 10:04 a.m.,

Review Request 64340: PREVIEW - Livy server start fails during EU with 'Address already in use' error

2017-12-05 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64340/ --- Review request for Ambari, Dmytro Grinenko, Jonathan Hurley, and Nate Cole.

Re: Review Request 64311: AMBARI-22574 Failed to restart services on PPC cluster post Ambari upgrade for IOP/HDP migration

2017-12-05 Thread Tim Thorpe
> On Dec. 5, 2017, 1:01 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog261.java > > Lines 154 (patched) > > > > > > We really shouldn't be hardcoding

Re: Review Request 64316: Messages for some services during PU package installation indicate circular dependency

2017-12-05 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64316/#review192866 --- Ship it! Ship It! - Nate Cole On Dec. 4, 2017, 5:13 p.m.,

Re: Review Request 64311: AMBARI-22574 Failed to restart services on PPC cluster post Ambari upgrade for IOP/HDP migration

2017-12-05 Thread Di Li
> On Dec. 5, 2017, 1:01 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog261.java > > Lines 154 (patched) > > > > > > We really shouldn't be hardcoding

Re: Review Request 64311: AMBARI-22574 Failed to restart services on PPC cluster post Ambari upgrade for IOP/HDP migration

2017-12-05 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64311/#review192856 ---

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-12-05 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/#review192843 --- The main difference between this patch and previous is in

Re: Review Request 64209: Need to address HDP-GPL repo update after user accepts license in post-install scenario

2017-12-05 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64209/ --- (Updated Dec. 5, 2017, 11:04 a.m.) Review request for Ambari, Attila

Re: Review Request 64316: Messages for some services during PU package installation indicate circular dependency

2017-12-05 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64316/#review192837 --- Ship it! Ship It! - Dmitro Lisnichenko On Dec. 5, 2017,

Re: Review Request 64242: AMBARI-22476: Modify bootstrap API to pass Ambari repo URL from UI and retrieve Host OS types

2017-12-05 Thread Sonia Garudi
> On Dec. 4, 2017, 4:20 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/bootstrap/SshHostInfo.java > > Lines 130-132 (patched) > > > > > > How many URLs are we talking about here. If