Re: Review Request 57493: Ambari Metrics Grafana Datasource plugin does not work when configured with a reverse proxy with subpath

2017-03-11 Thread Prajwal Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57493/#review168713 --- Ship it! Ship It! - Prajwal Rao On March 10, 2017, 2:57 a.m

Re: Review Request 49173: AMBARI-17416: AMS-Grafana: show 'alias' when there's no datapoint available

2016-07-05 Thread Prajwal Rao
> On June 24, 2016, 4:54 p.m., Prajwal Rao wrote: > > ambari-metrics/ambari-metrics-grafana/ambari-metrics/datasource.js, lines > > 128-133 > > <https://reviews.apache.org/r/49173/diff/1/?file=1428948#file1428948line128> > > > > All g

Re: Review Request 49173: AMBARI-17416: AMS-Grafana: show 'alias' when there's no datapoint available

2016-06-24 Thread Prajwal Rao
HBase-Users have legend hidden. We do need to handle this on aggregate level dashboards and graphs, and I already have a separate fix for that. - Prajwal Rao On June 24, 2016, 1:42 a.m., Jungtaek Lim wrote: > > --- > Thi

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-22 Thread Prajwal Rao
> On June 22, 2016, 6:32 a.m., Prajwal Rao wrote: > > Ship It! Datasource changes look good to me. - Prajwal --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48395/#rev

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-22 Thread Prajwal Rao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48395/#review139022 --- Ship it! Ship It! - Prajwal Rao On June 22, 2016, 2:09 a.m

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-21 Thread Prajwal Rao
ar to $scope.trasnform. - Prajwal Rao On June 21, 2016, 3:06 a.m., Jungtaek Lim wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request 48395: AMBARI-17027: Metrics Collector API: Introduce basic series aggregation functions

2016-06-15 Thread Prajwal Rao
/queryCtrl.js (line 40) <https://reviews.apache.org/r/48395/#comment202973> There seems to be no way to disable Series Aggregation. We need to have a "none" option, and "sum" shouldn't be set as the default option. - Prajwal Rao On June 10, 2016, 12:5