---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61582/#review183381
---
Ship it!
Ship It!
- Sid Wagle
On Aug. 21, 2017, 8:01 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61786/#review183346
---
Ship it!
No 4.2.5 chnaged needed?
- Sid Wagle
On Aug. 21
the issue?
- Sid Wagle
On Aug. 21, 2017, 2:18 p.m., Vitalyi Brodetskyi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
>
> (Updated Aug. 17, 2017, 9:40 p.m.)
>
>
> Review request for Ambari, Balázs Bence Sári, Juanjo Marron, and Sid Wagle.
>
>
> Bugs: AMBARI-21325
> https://issues.apache.org/jira/browse/AMBARI-21325
>
>
> Repository: ambari
>
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60981/#review183158
---
Ship it!
Ship It!
- Sid Wagle
On Aug. 17, 2017, 10:31 a.m
/ambari/server/state/cluster/ClusterImpl.java
Lines 1803 (patched)
<https://reviews.apache.org/r/61582/#comment258609>
Can you add comment why we need this, we should mention a TODO to find
reason for this workaround.
- Sid Wagle
On Aug. 10, 2017, 9:41 p.m., Vitalyi Brodetskyi
-21695-2.patch
https://reviews.apache.org/media/uploaded/files/2017/08/09/addb12dc-661d-480c-9526-c5c13a7a5566__AMBARI-21695-2.patch
Thanks,
Sid Wagle
.patch
Thanks,
Sid Wagle
Diff: https://reviews.apache.org/r/61542/diff/2/
Changes: https://reviews.apache.org/r/61542/diff/1-2/
Testing
---
UpgradeActionTest unit tests are green.
Thanks,
Sid Wagle
eviews.apache.org/r/61481/#review182326
-------
On Aug. 7, 2017, 10:47 p.m., Sid Wagle wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61481/
>
: https://reviews.apache.org/r/61481/diff/3-4/
Testing
---
Unit test pass.
Manual verification in progress.
Thanks,
Sid Wagle
: https://reviews.apache.org/r/61481/diff/2-3/
Testing
---
Unit test pass.
Manual verification in progress.
Thanks,
Sid Wagle
/2/
Changes: https://reviews.apache.org/r/61481/diff/1-2/
Testing
---
Unit test pass.
Manual verification in progress.
Thanks,
Sid Wagle
,
Sid Wagle
/src/test/java/org/apache/ambari/server/controller/utilities/DatabaseCheckerTest.java
3f73657
Diff: https://reviews.apache.org/r/61422/diff/1/
Testing
---
Verified manually.
Unit test added.
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61386/#review182033
---
Ship it!
Ship It!
- Sid Wagle
On Aug. 2, 2017, 8:20 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61273/#review182009
---
Ship it!
Ship It!
- Sid Wagle
On Aug. 2, 2017, 3:08 p.m
/package/scripts/params_linux.py
Line 248 (original), 248 (patched)
<https://reviews.apache.org/r/61273/#comment257813>
The description only mentions the HDFS issue but changes are done for YARN.
Is the RM behavior the same as NN?
- Sid Wagle
On Aug. 2, 2017, 3:08 p.m., Dmytro Sen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61203/#review181846
---
Ship it!
Ship It!
- Sid Wagle
On July 31, 2017, 4:25 p.m
/
Testing
---
Manually verified.
Thanks,
Sid Wagle
ambari-server/src/main/resources/stacks/BigInsights/4.2/upgrades/nonrolling-upgrade-to-hdp-2.6.xml
5532248
Diff: https://reviews.apache.org/r/61235/diff/1/
Testing
---
Manually verified.
Thanks,
Sid Wagle
> On July 28, 2017, 5:17 a.m., Sid Wagle wrote:
> > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/availability/MetricCollectorHAController.java
> > Lines 137 (patched)
> > <https://re
/ambari/server/serveraction/upgrades/FixAuthToLocalMappingActionTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/61168/diff/7/
Changes: https://reviews.apache.org/r/61168/diff/6-7/
Testing
---
Manually verified.
Thanks,
Sid Wagle
estart to get otu of.
- Sid Wagle
On July 28, 2017, 4:50 a.m., Aravindan Vijayan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
Diff: https://reviews.apache.org/r/61168/diff/6/
Changes: https://reviews.apache.org/r/61168/diff/5-6/
Testing
---
Manually verified.
Thanks,
Sid Wagle
verified.
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61107/#review181629
---
Ship it!
Ship It!
- Sid Wagle
On July 28, 2017, 12:08 a.m
/FixAuthToLocalMappingActionTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/61168/diff/4/
Changes: https://reviews.apache.org/r/61168/diff/3-4/
Testing
---
Manually verified.
Thanks,
Sid Wagle
: https://reviews.apache.org/r/61168/diff/3/
Testing (updated)
---
Manually verified.
Thanks,
Sid Wagle
Diff: https://reviews.apache.org/r/61168/diff/3/
Changes: https://reviews.apache.org/r/61168/diff/2-3/
Testing
---
Pending manual test.
Thanks,
Sid Wagle
mail. To reply, visit:
https://reviews.apache.org/r/61168/#review181606
---
On July 27, 2017, 6:58 p.m., Sid Wagle wrote:
>
> ---
> This is an automatically generated e-mail. T
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61177/#review181576
---
Ship it!
Ship It!
- Sid Wagle
On July 27, 2017, 1:26 p.m
484e459
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixAuthToLocalMappingActionTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/61168/diff/2/
Changes: https://reviews.apache.org/r/61168/diff/1-2/
Testing
---
Pending manual test.
Thanks,
Sid Wagle
ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixAuthToLocalMappingActionTest.java
PRE-CREATION
Diff: https://reviews.apache.org/r/61168/diff/1/
Testing
---
Pending manual test.
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61129/#review181414
---
Ship it!
Ship It!
- Sid Wagle
On July 26, 2017, 12:17 a.m
/internal/RequestResourceProvider.java
Lines 455 (patched)
<https://reviews.apache.org/r/61074/#comment256722>
This looks like a hack to me. Can we have the validation check for
existence of the resource filter in the params? Can that be done with minimal
extra code?
- Sid Wagle
On J
> On July 21, 2017, 9:02 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/PreUpgradeCheckResourceProvider.java
> > Lines 174 (patched)
> > <https://reviews.apache.org/r/61045/diff/1/?file=1780845#file1780845line176>
es 174 (patched)
<https://reviews.apache.org/r/61045/#comment256589>
Does this means a change on the client side? Description text suggests that
both old and new methods are supported.
- Sid Wagle
On July 21, 2017, 6:58 p.m., Jonathan
> On July 20, 2017, 6:55 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
> > Lines 3367 (patched)
> > <https://reviews.apache.org/r/60999/diff/1/?file=1780283#file1780283line3367>
>
in 7.116s
OK
--
Total run:1162
Total errors:0
Total failures:0
OK
Thanks,
Sid Wagle
:
--
Ran 274 tests in 7.116s
OK
--
Total run:1162
Total errors:0
Total failures:0
OK
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61012/#review181084
---
Ship it!
Ship It!
- Sid Wagle
On July 20, 2017, 11:15 p.m
roller/AmbariManagementControllerImpl.java
Lines 3661 (patched)
<https://reviews.apache.org/r/60999/#comment256507>
Can we call this something more meaningful than temp2 ?
- Sid Wagle
On July 20, 2017, 2:49 p.m., Dmytro Sen wrote:
>
> ---
> Thi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61000/#review181061
---
Ship it!
Ship It!
- Sid Wagle
On July 20, 2017, 4:54 p.m
/upgrades/config-upgrade.xml
Lines 34 (patched)
<https://reviews.apache.org/r/61000/#comment256490>
What if user has customized the port setting for rpc address different from
8020?
- Sid Wagle
On July 20, 2017, 4:54 p.m., Di Li
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60986/#review181014
---
Ship it!
Ship It!
- Sid Wagle
On July 20, 2017, 12:13 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60992/#review181013
---
Ship it!
Ship It!
- Sid Wagle
On July 20, 2017, 2:06 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60982/#review180979
---
Ship it!
Ship It!
- Sid Wagle
On July 19, 2017, 8:50 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60910/#review180691
---
Ship it!
Ship It!
- Sid Wagle
On July 17, 2017, 1:34 p.m
? What wouldbe
side effects of selecting those?
- Sid Wagle
On July 15, 2017, 12:20 a.m., Alejandro Fernandez wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
as long as it is the release
verified version.
- Sid Wagle
On July 14, 2017, 12:23 p.m., Attila Doroszlai wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60878/#review180583
---
Ship it!
Ship It!
- Sid Wagle
On July 14, 2017, 8:09 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60855/#review180489
---
Ship it!
Ship It!
- Sid Wagle
On July 13, 2017, 11:16 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60850/#review180472
---
Ship it!
Ship It!
- Sid Wagle
On July 13, 2017, 8:27 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60849/#review180457
---
Ship it!
Any unit test changes missed?
- Sid Wagle
On July
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60838/#review180433
---
Ship it!
Ship It!
- Sid Wagle
On July 13, 2017, 11:02 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60835/#review180391
---
Ship it!
Ship It!
- Sid Wagle
On July 13, 2017, 1:34 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60709/#review179959
---
Ship it!
Ship It!
- Sid Wagle
On July 7, 2017, 9:48 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60655/#review179883
---
Ship it!
Ship It!
- Sid Wagle
On July 6, 2017, 6:32 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60684/#review179788
---
Ship it!
Ship It!
- Sid Wagle
On July 6, 2017, 2:15 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60671/#review179742
---
Ship it!
Ship It!
- Sid Wagle
On July 6, 2017, 12:21 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60645/#review179594
---
Ship it!
Ship It!
- Sid Wagle
On July 5, 2017, 3:45 a.m
), 255 (patched)
<https://reviews.apache.org/r/60571/#comment254097>
This check could be removed entrirely.
- Sid Wagle
On June 30, 2017, 8:36 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60535/#review179393
---
Ship it!
Ship It!
- Sid Wagle
On June 30, 2017, 7:43 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60506/#review179129
---
Ship it!
Ship It!
- Sid Wagle
On June 28, 2017, 4:47 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60477/#review179041
---
Ship it!
Ship It!
- Sid Wagle
On June 27, 2017, 8:26 p.m
tomatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60477/
> ---
>
> (Updated June 27, 2017, 6:24 p.m.)
>
>
> Review request for Ambari, Dmytro Grinenko, Di Li, Dmitro Lisnichenko,
> Jonatha
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60475/#review179033
---
Ship it!
Ship It!
- Sid Wagle
On June 27, 2017, 7:41 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60365/#review178991
---
Ship it!
Ship It!
- Sid Wagle
On June 27, 2017, 4:08 p.m
/AmbariManagementControllerImpl.java
Lines 1639 (patched)
<https://reviews.apache.org/r/60365/#comment253245>
Lets use StringUtils.isEmpty here.
- Sid Wagle
On June 26, 2017, 1:06 p.m., Vitalyi Brodetskyi
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60435/#review178905
---
Ship it!
Ship It!
- Sid Wagle
On June 26, 2017, 4:44 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60399/#review178808
---
Ship it!
Ship It!
- Sid Wagle
On June 23, 2017, 7:42 p.m
p. How
will this work?
As long as we can do UUID -> host this should still be ok, however need to
measure performance of this query on a large dataset.
- Sid Wagle
On June 19, 2017, 1:56 p.m., Dmytro
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59648/#review178015
---
Ship it!
Ship It!
- Sid Wagle
On June 14, 2017, 6:22 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60045/#review177956
---
Ship it!
Ship It!
- Sid Wagle
On June 13, 2017, 11:57 a.m
> On June 9, 2017, 11:13 p.m., Sid Wagle wrote:
> > ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/discovery/TimelineMetricMetadataManager.java
> > Lines 436 (patched)
> > <https://re
/api/services/stackadvisor/StackAdvisorHelper.java
Line 113 (original), 132 (patched)
<https://reviews.apache.org/r/59948/#comment251176>
Instead of explict command type parameter passed down to invoke you could
create a Command objects of different kind.
- Sid Wagle
On June 10, 20
pecial chars. Wouldn't it increase entropy?
- Sid Wagle
On June 9, 2017, 6:52 p.m., Aravindan Vijayan wrote:
>
> ---
> This is an automatically generated e-mail. To
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59475/#review176689
---
Ship it!
Ship It!
- Sid Wagle
On June 1, 2017, 9:57 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59648/#review176376
---
Ship it!
Ship It!
- Sid Wagle
On May 30, 2017, 7:58 p.m
ection, I preserved the same
contract as the write to Phoenix.
- Sid
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59418/#review176007
----------
/ambari_server/dbConfiguration_linux.py
Lines 63 (patched)
<https://reviews.apache.org/r/59522/#comment249300>
Why not make this 1 second sleep and 30 tries?
- Sid Wagle
On May 24, 2017, 10:09 a.m., Andrew Onischuk
a
Line 1706 (original), 1712 (patched)
<https://reviews.apache.org/r/59475/#comment249104>
Lets add another line for changes configuration keys to indicate exact
properties that were changed by the user.
- Sid Wagle
On May 23, 2017, 1:36 a.m., Alejandro Fer
/diff/1/
Testing
---
Added unit tests.
Thanks,
Sid Wagle
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59416/#review175565
---
Ship it!
Ship It!
- Sid Wagle
On May 19, 2017, 7:57 p.m
not require HDFS
restart?
- Sid Wagle
On May 19, 2017, 3:36 p.m., Dmytro Sen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59401/#review175532
---
Ship it!
Ship It!
- Sid Wagle
On May 19, 2017, 3:36 p.m
to have a writeLock
for emptying the cache, +1 Aravindan's idea of simply cachce and empty and drop
on the floor if cannot submit.
- Sid Wagle
On April 28, 2017, 4:41 p.m., Dmytro Sen wrote:
>
> ---
> This is an automatically generat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58933/#review173658
---
Ship it!
Ship It!
- Sid Wagle
On May 2, 2017, 9:43 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58911/#review173652
---
Ship it!
Ship It!
- Sid Wagle
On May 2, 2017, 2:28 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58756/#review173494
---
Ship it!
Ship It!
- Sid Wagle
On April 27, 2017, 12:21 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58840/#review173430
---
Ship it!
Ship It!
- Sid Wagle
On April 28, 2017, 4:21 p.m
Server
but I would think we would need something like that to make sure deletes
succeed. Not an issue but more for understanding how deletes do not violate
constraints.
- Sid Wagle
On April 28, 2017, 4:21 p.m., Attila Doroszlai
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58800/#review173220
---
Ship it!
Ship It!
- Sid Wagle
On April 27, 2017, 2:54 p.m
es 23 (patched)
<https://reviews.apache.org/r/58424/#comment246165>
Again adding Raw vs aggreate will imprive readbility.
- Sid Wagle
On April 26, 2017, 4:44 p.m., Dmytro Sen wrote:
>
> ---
> This is an auto
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58713/#review172949
---
Ship it!
Ship It!
- Sid Wagle
On April 25, 2017, 4:37 p.m
apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/PhoenixHBaseAccessor.java
Lines 778 (patched)
<https://reviews.apache.org/r/58490/#comment245356>
Null check for instanceid?
- Sid Wagle
On April 18, 2017, 12:43 a.m., Aravindan V
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58407/#review172119
---
Ship it!
Ship It!
- Sid Wagle
On April 13, 2017, 12:45 a.m
--
>
> (Updated April 13, 2017, 4:54 p.m.)
>
>
> Review request for Ambari, Aravindan Vijayan and Sid Wagle.
>
>
> Bugs: AMBARI-20758
> https://issues.apache.org/jira/browse/AMBARI-20758
>
>
> Repository: ambari
>
>
> Desc
Can the kill have a timeout? So we have kill handler trying to flush for 2
secs before kill -9?
contrib/views/pig/src/main/java/org/apache/ambari/AggregatorWebService.java
Lines 1 (patched)
<https://reviews.apache.org/r/58424/#comment244892>
Why is this test code in cont
101 - 200 of 513 matches
Mail list logo
