---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58997/#review174148
---
Ship it!
Ship It!
- Ashwin Rajeev
On May 5, 2017, 9:12 a.m
/UpgradeCatalog250.java
Lines 692 (patched)
<https://reviews.apache.org/r/58997/#comment247267>
Does it need to be hardcoded ?
- Ashwin Rajeev
On May 5, 2017, 9:12 a.m., Nitiraj Rathore wrote:
>
> ---
> This is an automati
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57453/#review168915
---
Ship it!
Ship It!
- Ashwin Rajeev
On March 14, 2017, 1:59
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57453/#review168427
---
Ship it!
Ship It!
- Ashwin Rajeev
On March 9, 2017, 10 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57141/#review167094
---
Ship it!
Ship It!
- Ashwin Rajeev
On Feb. 28, 2017, 12:23
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57120/#review167007
---
Ship it!
Ship It!
- Ashwin Rajeev
On Feb. 28, 2017, 4:55
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56973/#review166491
---
Ship it!
Ship It!
- Ashwin Rajeev
On Feb. 23, 2017, 7:13
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55209/#review160690
---
Ship it!
Ship It!
- Ashwin Rajeev
On Jan. 5, 2017, 1:30 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55090/#review160375
---
Ship it!
Ship It!
- Ashwin Rajeev
On Jan. 3, 2017, 9:25 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54305/#review160181
---
Ship it!
Ship It!
- Ashwin Rajeev
On Dec. 27, 2016, 6:26
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55050/#review160180
---
Ship it!
Ship It!
- Ashwin Rajeev
On Dec. 27, 2016, 5:58
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53780/#review156192
---
Ship it!
Ship It!
- Ashwin Rajeev
On Nov. 15, 2016, 11:54
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52823/#review154505
---
Ship it!
Ship It!
- Ashwin Rajeev
On Oct. 13, 2016, 9:06
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50561/#review152475
---
Ship it!
Ship It!
- Ashwin Rajeev
On July 28, 2016, 11:22
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52822/#review152474
---
Ship it!
Ship It!
- Ashwin Rajeev
On Oct. 13, 2016, 8:56
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50691/#review144878
---
Ship it!
Reviewed earleier as a github PR
- Ashwin Rajeev
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50792/#review144753
---
Ship it!
Ship It!
- Ashwin Rajeev
On Aug. 4, 2016, 12:54
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50790/#review144751
---
Ship it!
Ship It!
- Ashwin Rajeev
On Aug. 4, 2016, 12:19
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50554/#review144061
---
Ship it!
Ship It!
- Ashwin Rajeev
On July 28, 2016, 11:37
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50328/#review143205
---
Ship it!
Ship It!
- Ashwin Rajeev
On July 22, 2016, 6:55
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50305/#review143126
---
Ship it!
Ship It!
- Ashwin Rajeev
On July 21, 2016, 6:38
fine
- Ashwin Rajeev
On June 17, 2016, 1:44 p.m., Aleksandr Kovalenko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50189/#review142735
---
Ship it!
Ship It!
- Ashwin Rajeev
On July 19, 2016, 12:13
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49750/#review142540
---
Ship it!
Ship It!
- Ashwin Rajeev
On July 7, 2016, 11:32
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50074/#review142367
---
Ship it!
Ship It!
- Ashwin Rajeev
On July 15, 2016, 11:43
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50031/#review142237
---
Ship it!
Ship It!
- Ashwin Rajeev
On July 14, 2016, 1:09
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49991/#review142228
---
Ship it!
Ship It!
- Ashwin Rajeev
On July 13, 2016, 4:37
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49495/#review140324
---
Ship it!
Ship It!
- Ashwin Rajeev
On July 1, 2016, 7:31 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49450/#review140166
---
Ship it!
Ship It!
- Ashwin Rajeev
On June 30, 2016, 1:57
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49433/#review140135
---
Ship it!
Ship It!
- Ashwin Rajeev
On June 30, 2016, 11 a.m
-
>
> (Updated June 29, 2016, 2:46 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav
> Kulshreshtha, Rohit Choudhary, and Ashwin Rajeev.
>
>
> Bugs: AMBARI-17480
> https://issues.apache.org/jira/browse/AMBARI-17480
>
>
> Repo
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48681/#review138162
---
Ship it!
Ship It!
- Ashwin Rajeev
On June 14, 2016, 10:20
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48032/#review135506
---
Ship it!
Ship It!
- Ashwin Rajeev
On May 30, 2016, 8:55 a.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47644/#review134146
---
Ship it!
Ship It!
- Ashwin Rajeev
On May 20, 2016, 10:15
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47525/#review134129
---
Ship it!
Ship It!
- Ashwin Rajeev
On May 20, 2016, 10:16
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47526/#review134100
---
Ship it!
Ship It!
- Ashwin Rajeev
On May 19, 2016, 10:22
/src/main/resources/ui/hive-web/app/components/file-upload.js
(line 30)
<https://reviews.apache.org/r/47525/#comment198744>
Remove logging
- Ashwin Rajeev
On May 19, 2016, 10:22 a.m., Nitiraj Rathore wrote:
>
> ---
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47524/#review134097
---
Ship it!
Ship It!
- Ashwin Rajeev
On May 19, 2016, 10:22
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47527/#review134096
---
Ship it!
Fix it then ship it
- Ashwin Rajeev
On May 19
r.java
(line 140)
<https://reviews.apache.org/r/47527/#comment198743>
Same here
- Ashwin Rajeev
On May 19, 2016, 10:23 a.m., Nitiraj Rathore wrote:
>
> ---
> This is an automatically generated e-mail. To
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47460/#review133998
---
Ship it!
Ship It!
- Ashwin Rajeev
On May 17, 2016, 3 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47604/#review133993
---
Ship it!
Fix it then ship it
- Ashwin Rajeev
On May 19
/controllers/ambariViews/ViewsEditCtrl.js
(line 446)
<https://reviews.apache.org/r/47604/#comment198658>
pls remove console.log
- Ashwin Rajeev
On May 19, 2016, 4:38 p.m., Pallav Kulshreshtha wrote:
>
> ---
> This is a
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46962/#review133929
---
Ship it!
Ship It!
- Ashwin Rajeev
On May 17, 2016, 10:10
-
>
> (Updated May 12, 2016, 12:51 p.m.)
>
>
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Pallav
> Kulshreshtha, and Ashwin Rajeev.
>
>
> Bugs: AMBARI-16422
> https://issues.apache.org/jira/browse/AMBARI-16422
&
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47294/#review132847
---
Ship it!
Ship It!
- Ashwin Rajeev
On May 12, 2016, 7:55 a.m
/resources/uploads/UploadService.java
(line 355)
<https://reviews.apache.org/r/47124/#comment196584>
Can inputFileType ever be null ?, if not then ignore this comment
- Ashwin Rajeev
On May 10, 2016, 9:47 a.m., Nitiraj Rathore
n/java/org/apache/ambari/server/controller/internal/RemoteClusterResourceProvider.java
(line 254)
<https://reviews.apache.org/r/47023/#comment195946>
If you want to , use Strings.isNullOrEmpty() - Guava
- Ashwin Rajeev
On May 5, 2016, 4:16 p.m., Gaurav
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46738/#review130774
---
Ship it!
Ship It!
- Ashwin Rajeev
On April 27, 2016, 12:49
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46689/#review130591
---
Ship it!
Ship It!
- Ashwin Rajeev
On April 26, 2016, 9:55
/resources/files/FileService.java
(line 207)
<https://reviews.apache.org/r/46689/#comment194416>
Possible NPE if filepath is null, I am not sure if this is ever possible.
just double check this
- Ashwin Rajeev
On April 26, 2016, 9:55 a.m., Gaurav Nagar
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46271/#review130300
---
Ship it!
Ship It!
- Ashwin Rajeev
On April 20, 2016, 7:47
52 matches
Mail list logo