Re: Review Request 49989: AMBARI-17682 : For hive and hbase two properties are present policy.grantrevoke.auth.users & policy.grant.revoke.auth.users
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49989/#review142175 --- Ship it! Ship It! - Srimanth Gunturi On July 13, 2016, 1:21 p.m., Gautam Borad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49989/ > --- > > (Updated July 13, 2016, 1:21 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Mahadev Konar, Sumit Mohanty, > Selvamohan Neethiraj, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-17682 > https://issues.apache.org/jira/browse/AMBARI-17682 > > > Repository: ambari > > > Description > --- > > Changed the names of the properties to be in sync with the right ones. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 6d304d496797a19701ecf4c74f054406f5ce2670 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 571eebdb3ac29555d2a12b72649c2b0338acfd86 > > Diff: https://reviews.apache.org/r/49989/diff/ > > > Testing > --- > > Tested on a local centos6 cluster with hbase and hive. > > > Thanks, > > Gautam Borad > >
Re: Review Request 49897: AMBARI-17617: Set default log level for Ranger KMS to INFO
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49897/#review142174 --- Ship it! Ship It! - Srimanth Gunturi On July 11, 2016, 2:39 p.m., Gautam Borad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49897/ > --- > > (Updated July 11, 2016, 2:39 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Sumit > Mohanty, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-17617 > https://issues.apache.org/jira/browse/AMBARI-17617 > > > Repository: ambari > > > Description > --- > > Kms log file is getting bigger till 18 GB , causing No space left on device > for inode. > Problem is : > 1. by default debug log is generated in the kms.log fle > 2. there is no split in log file if there is over flow of logs in kms.log > file like other access audit logs file and xa_portal logs. > > Fixed the above by setting default log level to INFO. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-log4j.xml > 61aede3 > > Diff: https://reviews.apache.org/r/49897/diff/ > > > Testing > --- > > Tested on a local centos6 cluster with kms and monitored the log file. > > > Thanks, > > Gautam Borad > >
Re: Review Request 49908: Storm Ambari View should provide a config page & make calls to Storm Rest API
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49908/#review142111 --- Ship it! Ship It! - Srimanth Gunturi On July 13, 2016, 4:12 p.m., Sriharsha Chintalapani wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49908/ > --- > > (Updated July 13, 2016, 4:12 p.m.) > > > Review request for Ambari and Srimanth Gunturi. > > > Bugs: AMBARI-17640 > https://issues.apache.org/jira/browse/AMBARI-17640 > > > Repository: ambari > > > Description > --- > > Storm Ambari View should provide a config page & make calls to Storm Rest API > > > Diffs > - > > contrib/views/storm/src/main/java/org/apache/ambari/storm/ProxyServlet.java > 6e6bea2 > contrib/views/storm/src/main/resources/WEB-INF/web.xml e406de1 > contrib/views/storm/src/main/resources/scripts/components/BarChart.jsx > PRE-CREATION > contrib/views/storm/src/main/resources/scripts/components/SearchLogs.jsx > PRE-CREATION > contrib/views/storm/src/main/resources/scripts/components/SpoutGraph.jsx > 94bad11 > contrib/views/storm/src/main/resources/scripts/components/TopologyGraph.jsx > 1b1baf7 > contrib/views/storm/src/main/resources/scripts/models/VTopology.js da0a26d > contrib/views/storm/src/main/resources/scripts/router/Router.js 1239b6f > contrib/views/storm/src/main/resources/scripts/utils/Overrides.js 7bb6b3f > contrib/views/storm/src/main/resources/scripts/utils/Utils.js 56a42a6 > > contrib/views/storm/src/main/resources/scripts/views/ComponentDetailView.jsx > 5d77bdf > contrib/views/storm/src/main/resources/scripts/views/TopologyDetailView.jsx > 7486948 > contrib/views/storm/src/main/resources/styles/style.css e4f5be2 > contrib/views/storm/src/main/resources/view.xml cbcf4ff > > Diff: https://reviews.apache.org/r/49908/diff/ > > > Testing > --- > > > Thanks, > > Sriharsha Chintalapani > >
Re: Review Request 49754: AMBARI-17607 Add localjecks support in ambari for Ranger and Ranger KMS services
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49754/#review141217 --- Ship it! Ship It! - Srimanth Gunturi On July 7, 2016, 1:02 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49754/ > --- > > (Updated July 7, 2016, 1:02 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan > Hurley, Jayush Luniya, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-17607 > https://issues.apache.org/jira/browse/AMBARI-17607 > > > Repository: ambari > > > Description > --- > > Currently, localjceks scheme is not supported for ranger installation through > Ambari. Ambari should use localjecks scheme to store, retrieve and list its > alias and values while installing ranger through Ambari. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > 85e04e7 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > a85bde0 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 5e675e6 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py > 0a8c7d3 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > dfcad32 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > ca000d1 > ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py > 247b978 > ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_usersync.py > 7b6e782 > ambari-server/src/test/python/stacks/2.5/RANGER_KMS/test_kms_server.py > 70e3d42 > > Diff: https://reviews.apache.org/r/49754/diff/ > > > Testing > --- > > Running tests for stack:2.5 service:RANGER > test_configure_default (test_ranger_admin.TestRangerAdmin) ... ok > test_configure_secured (test_ranger_admin.TestRangerAdmin) ... ok > test_start_default (test_ranger_admin.TestRangerAdmin) ... ok > test_start_secured (test_ranger_admin.TestRangerAdmin) ... ok > test_stop_default (test_ranger_admin.TestRangerAdmin) ... ok > test_configure_default (test_ranger_usersync.TestRangerUsersync) ... ok > test_configure_secured (test_ranger_usersync.TestRangerUsersync) ... ok > test_start_default (test_ranger_usersync.TestRangerUsersync) ... ok > test_stop_default (test_ranger_usersync.TestRangerUsersync) ... ok > test_configure_default (test_ranger_tagsync.TestRangerTagsync) ... ok > test_configure_secured (test_ranger_tagsync.TestRangerTagsync) ... ok > test_start_default (test_ranger_tagsync.TestRangerTagsync) ... ok > test_stop_default (test_ranger_tagsync.TestRangerTagsync) ... ok > > -- > Ran 13 tests in 0.337s > > OK > > > Running tests for stack:2.5 service:RANGER_KMS > test_configure_default (test_kms_server.TestRangerKMS) ... 2016-07-07 > 15:24:50,074 - Using hadoop conf dir: /usr/hdp/current/hadoop-client/conf > ok > test_configure_secured (test_kms_server.TestRangerKMS) ... 2016-07-07 > 15:24:50,096 - Using hadoop conf dir: /usr/hdp/current/hadoop-client/conf > ok > test_start_default (test_kms_server.TestRangerKMS) ... 2016-07-07 > 15:24:50,119 - Using hadoop conf dir: /usr/hdp/current/hadoop-client/conf > 2016-07-07 15:24:50,123 - Rangeradmin: Skip ranger admin if it's down ! > ok > test_start_secured (test_kms_server.TestRangerKMS) ... 2016-07-07 > 15:24:50,152 - Using hadoop conf dir: /usr/hdp/current/hadoop-client/conf > 2016-07-07 15:24:50,157 - RangeradminV2: Skip ranger admin if it's down ! > 2016-07-07 15:24:50,157 - KMS repository c1_kms exist > ok > test_stop_default (test_kms_server.TestRangerKMS) ... 2016-07-07 15:24:50,177 > - Using hadoop conf dir: /usr/hdp/current/hadoop-client/conf > ok > > -- > Ran 5 tests in 0.123s > > OK > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 49752: AMBARI-17000 Allow ranger admin credentials to be specified during cluster creation
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49752/#review141209 --- ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py (line 56) <https://reviews.apache.org/r/49752/#comment206624> Is changing password supported only during install? After install if this password changes, do we need to re-invoke this method? - Srimanth Gunturi On July 7, 2016, 12:54 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49752/ > --- > > (Updated July 7, 2016, 12:54 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam > Borad, Jonathan Hurley, Jayush Luniya, Srimanth Gunturi, and Velmurugan > Periasamy. > > > Bugs: AMBARI-17000 > https://issues.apache.org/jira/browse/AMBARI-17000 > > > Repository: ambari > > > Description > --- > > Problem: > Today when a cluster is created, ranger admin has the default password. Since > ranger defines all the authorization related policies, the first thing user > needs to do after creating a cluster is to change ranger admin default login > password in Ambari and Ranger manually. > > > Solution: > Update ranger admin password only at time of installation if password doesn't > match with default password. > > Executing below command: > python db_setup.py -changepassword userID, currentPassword, newPassword. > > This script if called multiple time wont change password on subsequent calls, > since a flag is maintained in the db. The flag is set on first password > change and wont allow further password change(using this script) > Also the password change will work in HA environment since it maintains a > lock in db before updating the record. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > 85e04e7 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > a85bde0 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py > c6e5b70 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 6b04075 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > ca000d1 > > Diff: https://reviews.apache.org/r/49752/diff/ > > > Testing > --- > > Ran 261 tests in 7.602s > > OK > -- > Total run:1015 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 49705: AMBARI-17586 : EU failed with errors during Kafka broker restart in Upgrade process
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49705/#review141195 --- Ship it! Ship It! - Srimanth Gunturi On July 7, 2016, 7:17 a.m., Gautam Borad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49705/ > --- > > (Updated July 7, 2016, 7:17 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Sumit Mohanty, Srimanth > Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-17586 > https://issues.apache.org/jira/browse/AMBARI-17586 > > > Repository: ambari > > > Description > --- > > While upgrading from HDP 2.3 to 2.4, Kafka broker fails on restart as it > doesn't get Keytabs / principals during upgrade. Handle Ranger service > creation with checks of principal / keytab. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 09ff522 > > Diff: https://reviews.apache.org/r/49705/diff/ > > > Testing > --- > > Verified upgrade of Kafka restart successfully after upgrade from Ambari. > > > Thanks, > > Gautam Borad > >
Re: Review Request 49193: AMBARI-16756 Update code for Ranger Service to use PID file for status and stop call
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49193/#review139635 --- Ship it! Ship It! - Srimanth Gunturi On June 27, 2016, 11:20 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49193/ > --- > > (Updated June 27, 2016, 11:20 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam > Borad, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-16756 > https://issues.apache.org/jira/browse/AMBARI-16756 > > > Repository: ambari > > > Description > --- > > Updated ambari Ranger and Ranger KMS code for stop and status call from stack > 2.5 onwards > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > be2a4c8 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/configuration/ranger-env.xml > 3187971 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > ab5be74 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_admin.py > 0d9ce5f > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_usersync.py > 8313b18 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > ad0ac60 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/status_params.py > 6cb69fb > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py > 5847984 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms_server.py > 9360e70 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > 452be86 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/status_params.py > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > 574264e > > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/kms-env.xml > ae45552 > ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_tagsync.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_usersync.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-default.json > PRE-CREATION > ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-secured.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/49193/diff/ > > > Testing > --- > > Testes Ranger and Ranger KMS on centos 6 > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 48507: AMBARI-17074: Expose Spark daemon memory in Spark2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48507/#review139301 --- Ship it! Ship It! - Srimanth Gunturi On June 22, 2016, 6:09 p.m., Weiqing Yang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48507/ > --- > > (Updated June 22, 2016, 6:09 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Sumit Mohanty, and Srimanth > Gunturi. > > > Bugs: AMBARI-17074 > https://issues.apache.org/jira/browse/AMBARI-17074 > > > Repository: ambari > > > Description > --- > > Expose Spark daemon memory in Spark2, so that the user can modify its size on > ambari web UI easily. The change is the same with the patch of jira > AMBARI-16757, which is for Spark 1.6.1. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml > 76c670a > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py > a0d91c7 > > Diff: https://reviews.apache.org/r/48507/diff/ > > > Testing > --- > > Tests manually passed. > > > Thanks, > > Weiqing Yang > >
Re: Review Request 48507: AMBARI-17074: Expose Spark daemon memory in Spark2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48507/#review138929 --- Ship it! Ship It! - Srimanth Gunturi On June 21, 2016, 6:18 p.m., Weiqing Yang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48507/ > --- > > (Updated June 21, 2016, 6:18 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Sumit Mohanty, and Srimanth > Gunturi. > > > Bugs: AMBARI-17074 > https://issues.apache.org/jira/browse/AMBARI-17074 > > > Repository: ambari > > > Description > --- > > Expose Spark daemon memory in Spark2, so that the user can modify its size on > ambari web UI easily. The change is the same with the patch of jira > AMBARI-16757, which is for Spark 1.6.1. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml > 76c670a > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py > 6925ab5 > > Diff: https://reviews.apache.org/r/48507/diff/ > > > Testing > --- > > Tests manually passed. > > > Thanks, > > Weiqing Yang > >
Re: Review Request 48827: AMBARI-17286 Service config links should use public host name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48827/#review138319 --- Ship it! Ship It! - Srimanth Gunturi On June 17, 2016, 9:08 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48827/ > --- > > (Updated June 17, 2016, 9:08 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Srimanth > Gunturi, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-17286 > https://issues.apache.org/jira/browse/AMBARI-17286 > > > Repository: ambari > > > Description > --- > > Service config links (e.g. tez.tez-ui.history-url.base) need to use the > Ambari server's public name / IP instead of the private one. (Since > tez.tez-ui.history-url.base is used to navigate from RM UI to Tez View.) > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > 038a6c3 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > c32306d > ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py > 318f184 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 1bd385f > > Diff: https://reviews.apache.org/r/48827/diff/ > > > Testing > --- > > Unit tests for stack advisor passed > Total run:162 > Total errors:0 > Total failures:0 > OK > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 48827: AMBARI-17286 Service config links should use public host name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48827/#review138316 --- ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py (line 778) <https://reviews.apache.org/r/48827/#comment203486> Would be more efficient to use 'server_host' variable instead of resolving fqdn from socket everytime. Similar comment to other calls. - Srimanth Gunturi On June 16, 2016, 11:43 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48827/ > --- > > (Updated June 16, 2016, 11:43 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Srimanth > Gunturi, Sid Wagle, and Yusaku Sako. > > > Bugs: AMBARI-17286 > https://issues.apache.org/jira/browse/AMBARI-17286 > > > Repository: ambari > > > Description > --- > > Service config links (e.g. tez.tez-ui.history-url.base) need to use the > Ambari server's public name / IP instead of the private one. (Since > tez.tez-ui.history-url.base is used to navigate from RM UI to Tez View.) > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > 038a6c3 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > c32306d > ambari-server/src/test/python/stacks/2.2/common/test_stack_advisor.py > 318f184 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 1bd385f > > Diff: https://reviews.apache.org/r/48827/diff/ > > > Testing > --- > > Unit tests for stack advisor passed > Total run:162 > Total errors:0 > Total failures:0 > OK > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
Re: Review Request 48507: AMBARI-17074: Expose Spark daemon memory in Spark2
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48507/#review138096 --- ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py (line 66) <https://reviews.apache.org/r/48507/#comment203310> Is it ok if 'spark_daemon_memory' will be empty when the if() condition will be false? It looks like in that case the spark2-env will have 'export SPARK_DAEMON_MEMORY=m' - Srimanth Gunturi On June 9, 2016, 8:11 p.m., Weiqing Yang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48507/ > --- > > (Updated June 9, 2016, 8:11 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Sumit Mohanty, and Srimanth > Gunturi. > > > Bugs: AMBARI-17074 > https://issues.apache.org/jira/browse/AMBARI-17074 > > > Repository: ambari > > > Description > --- > > Expose Spark daemon memory in Spark2, so that the user can modify its size on > ambari web UI easily. The change is the same with the patch of jira > AMBARI-16757, which is for Spark 1.6.1. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/configuration/spark2-env.xml > 255e990 > > ambari-server/src/main/resources/common-services/SPARK2/2.0.0/package/scripts/params.py > 6925ab5 > > Diff: https://reviews.apache.org/r/48507/diff/ > > > Testing > --- > > Tests manually passed. > > > Thanks, > > Weiqing Yang > >
Re: Review Request 48726: AMBARI-17247 : Populate audit to solr / hdfs properties for Atlas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48726/#review137869 --- Ship it! Ship It! - Srimanth Gunturi On June 15, 2016, 3:42 p.m., Gautam Borad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48726/ > --- > > (Updated June 15, 2016, 3:42 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Madhan > Neethiraj, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-17247 > https://issues.apache.org/jira/browse/AMBARI-17247 > > > Repository: ambari > > > Description > --- > > **Issue :** > If Ranger Atlas Plugin is enabled and audit to solr or hdfs are enabled from > Ranger then, need to populate solr / hdfs audit configurations in atlas > configs. > > > Diffs > - > > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-plugin-properties.xml > f3bdc2a > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 614f0b1 > > Diff: https://reviews.apache.org/r/48726/diff/ > > > Testing > --- > > Verified recommendations for audit to solr as well as hdfs for Atlas (if > enabled from Ranger configs) > > > Thanks, > > Gautam Borad > >
Re: Review Request 48547: AMBARI-17164 Handle Ranger upgrade scenario in Kerberized env
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48547/#review137079
---
Ship it!
Ship It!
- Srimanth Gunturi
On June 10, 2016, 12:50 p.m., Mugdha Varadkar wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48547/
> ---
>
> (Updated June 10, 2016, 12:50 p.m.)
>
>
> Review request for Ambari, Gautam Borad, Jonathan Hurley, Nate Cole, Srimanth
> Gunturi, and Velmurugan Periasamy.
>
>
> Bugs: AMBARI-17164
> https://issues.apache.org/jira/browse/AMBARI-17164
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Add this property to ranger-admin-site.xml:
> ranger.plugins.{component}.serviceuser=service_user
>
> Add spnego principal and keytab if cluster is kerberized to below properties:
> ranger.spnego.kerberos.principal
> ranger.spnego.kerberos.keytab
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculation.java
> PRE-CREATION
>
> ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-admin-site.xml
> 35910ee
>
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml
> f40f760
> ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml
> ea5ff5a
>
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml
> 7fb03dc
> ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml
> 7f988e3
> ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py
> df6c65c
>
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/RangerKerberosConfigCalculationTest.java
> PRE-CREATION
>
> Diff: https://reviews.apache.org/r/48547/diff/
>
>
> Testing
> ---
>
> Tested upgrade scenario from stack 2.4 to 2.5
>
>
> ---
> T E S T S
> ---
> Picked up _JAVA_OPTIONS: -Xmx2048m -XX:MaxPermSize=512m
> -Djava.awt.headless=true
> Running
> org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.586 sec -
> in
> org.apache.ambari.server.serveraction.upgrades.RangerKerberosConfigCalculationTest
>
> Results :
>
> Tests run: 1, Failures: 0, Errors: 0, Skipped: 0
>
>
> Thanks,
>
> Mugdha Varadkar
>
>
Re: Review Request 48273: AMBARI-17054 : Configure Atlas Ranger Plugin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48273/#review136656 --- Ship it! Ship It! - Srimanth Gunturi On June 6, 2016, 3:26 p.m., Gautam Borad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48273/ > --- > > (Updated June 6, 2016, 3:26 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jonathan Hurley, Srimanth > Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-17054 > https://issues.apache.org/jira/browse/AMBARI-17054 > > > Repository: ambari > > > Description > --- > > Patch contains changes to support Ranger Atlas Plugin from Ambari. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > 34d1a1a > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata_server.py > 1e9e7a7 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > a79a456 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/setup_ranger_atlas.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/status_params.py > 4c54214 > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-env.xml > 4db7f45 > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/themes/theme_version_3.json > 0f7b0c0 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > 8b669e8 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml > 98cbc30 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-audit.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-plugin-properties.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-policymgr-ssl.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/ranger-atlas-security.xml > PRE-CREATION > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 379c268 > > Diff: https://reviews.apache.org/r/48273/diff/ > > > Testing > --- > > Verified : > > 1) Enable / disable actions for Ranger Atlas Plugin > 2) Checked Ranger plugin comminication. > 3) Checked policy enforecements on Atlas based on Ranger's policies. > 4) Verified stack advisor recommendations to chnange following properties : > > atlas.authorizer.impl=org.apache.ranger.authorization.atlas.authorizer.RangerAtlasAuthorizer > ranger-atlas-plugin-enabled=yes > 5) Verified Ranger service creation (while enabling Ranger Atlas Plugin) > > > Thanks, > > Gautam Borad > >
Re: Review Request 48288: Microsoft-r install script should use Ambari libraries instead of direct shell calls
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48288/#review136385 --- Ship it! Ship It! - Srimanth Gunturi On June 6, 2016, 5:30 p.m., Balázs Bence Sári wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48288/ > --- > > (Updated June 6, 2016, 5:30 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Jayush Luniya, Srimanth > Gunturi, Sumit Gupta, and Yusaku Sako. > > > Bugs: AMBARI-17067 > https://issues.apache.org/jira/browse/AMBARI-17067 > > > Repository: ambari > > > Description > --- > > Made the following changes: > - Use Ambari Python API only > - Use new rpm's > - Cleaned up imports. > - Added supported HDP versions to the mpack > > > Diffs > - > > > contrib/management-packs/microsoft-r_mpack/src/main/resources/common-services/MICROSOFT_R/8.0.0/package/scripts/microsoft_r.py > 5b6e482 > contrib/management-packs/microsoft-r_mpack/src/main/resources/mpack.json > 17c2f54 > > Diff: https://reviews.apache.org/r/48288/diff/ > > > Testing > --- > > On a a single node cluster (CentOS 6.4, Ambari 2.2 upgraded to 2.4 snapshot > build, HDP 2.3), did the following testing: > - Built the management pack with mvn install > - Installed it on the Ambari Server by running this command: ambari-server > install-mpack --mpack microsoft-r_mpack-1.0.0.0-SNAPSHOT.tar.gz > - Restarted the Ambari Server > - On the UI, chose add service and selected Microsoft R. > - Install completed without errors. It had a warning due to missing service > check script (covered by another Jira ticket). > > > Thanks, > > Balázs Bence Sári > >
Re: Review Request 48125: AMBARI-16984 Add changes for Ranger Service to get previous_jdbc_jar_name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48125/#review136041 --- Ship it! Ship It! - Srimanth Gunturi On June 1, 2016, 12:59 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48125/ > --- > > (Updated June 1, 2016, 12:59 p.m.) > > > Review request for Ambari, Gautam Borad, Srimanth Gunturi, and Vitalyi > Brodetskyi. > > > Bugs: AMBARI-16984 > https://issues.apache.org/jira/browse/AMBARI-16984 > > > Repository: ambari > > > Description > --- > > Copying of jdbc jar for Ranger and Ranger KMS is only done at time of > installation and during upgrade of HDP. > This fix will update the latest jar set by user and delete the previous jar > at restart of Ranger and Ranger KMS > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py > 80e5664 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py > 3dc4914 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 665fa48 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py > e446c43 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > 03c1258 > > Diff: https://reviews.apache.org/r/48125/diff/ > > > Testing > --- > > Tested Ranger and Ranger KMS fresh installation of jdbc jar and then set a > newer version of jar and check everything is working fine. > Tested ambari upgrade. > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 48125: AMBARI-16984 Add changes for Ranger Service to get previous_jdbc_jar_name
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48125/#review135889 --- ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py (line 38) <https://reviews.apache.org/r/48125/#comment200913> Should it be "if params.driver_curl_source is not None and ..."? A similar change was made in "ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py". Same comment applies to other changes in this patch which use "driver_curl_source" - Srimanth Gunturi On June 1, 2016, 12:59 p.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48125/ > --- > > (Updated June 1, 2016, 12:59 p.m.) > > > Review request for Ambari, Gautam Borad, Srimanth Gunturi, and Vitalyi > Brodetskyi. > > > Bugs: AMBARI-16984 > https://issues.apache.org/jira/browse/AMBARI-16984 > > > Repository: ambari > > > Description > --- > > Copying of jdbc jar for Ranger and Ranger KMS is only done at time of > installation and during upgrade of HDP. > This fix will update the latest jar set by user and delete the previous jar > at restart of Ranger and Ranger KMS > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/setup_ranger_plugin_xml.py > 80e5664 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger.py > 3dc4914 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 665fa48 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/kms.py > e446c43 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/package/scripts/params.py > 03c1258 > > Diff: https://reviews.apache.org/r/48125/diff/ > > > Testing > --- > > Tested Ranger and Ranger KMS fresh installation of jdbc jar and then set a > newer version of jar and check everything is working fine. > Tested ambari upgrade. > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 47984: Make storm.topology.submission.notifier.plugin.class property optional
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47984/#review135731 --- Ship it! Ship It! - Srimanth Gunturi On May 28, 2016, 5:15 a.m., Sivaguru Chendamaraikannan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47984/ > --- > > (Updated May 28, 2016, 5:15 a.m.) > > > Review request for Ambari, Srimanth Gunturi and Tom Beerbower. > > > Bugs: AMBARI-16915 > https://issues.apache.org/jira/browse/AMBARI-16915 > > > Repository: ambari > > > Description > --- > > The commit, > https://github.com/apache/ambari/commit/89fd30b40f3108bfcbcc73eb2d74c94a2ba14a7a > which accidentally made the storm.topology.submission.notifier.plugin > property mandatory. If the storm defaults yaml config does not set the > property a " " value is set for the property. This causes storm startup to > fail with a Class Not Found exception when starting with Ambari. This change > fixes the stack advisor to not set the property when no value is specified > for it through command line or storm defaults. > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 79314f5 > > Diff: https://reviews.apache.org/r/47984/diff/ > > > Testing > --- > > mvn test > > > Thanks, > > Sivaguru Chendamaraikannan > >
Re: Review Request 47428: Changes to Phoenix QueryServer Kerberos configuration
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47428/#review135341 --- Ship it! Ship It! - Srimanth Gunturi On May 27, 2016, 10:42 p.m., Josh Elser wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47428/ > --- > > (Updated May 27, 2016, 10:42 p.m.) > > > Review request for Ambari, Jonathan Hurley, Nate Cole, Robert Levas, and > Srimanth Gunturi. > > > Bugs: AMBARI-16171 > https://issues.apache.org/jira/browse/AMBARI-16171 > > > Repository: ambari > > > Description > --- > > The up-coming version of Phoenix will contain some new functionality to > support Kerberos authentication of clients via SPNEGO with the Phoenix Query > Server (PQS). > > Presently, Ambari will configure PQS to use the hbase service keytab which > will result in the SPNEGO authentication failing as the RFC requires that the > "primary" component of the Kerberos principal for the server is "HTTP". Thus, > we need to ensure that we switch PQS over to use the spnego.service.keytab as > the keytab and "HTTP/_HOST@REALM" as the principal. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/AbstractUpgradeCatalog.java > 2e857ed > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 0deba5d > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json > c9536f8 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 6e506a0 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 8c5351f > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog240Test.java > 4dedc98 > ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py > 0066e1d > > Diff: https://reviews.apache.org/r/47428/diff/ > > > Testing > --- > > Unit testing, verified installation with trunk and proper kerberization. > > > Thanks, > > Josh Elser > >
Re: Review Request 47961: Web Client Requests Handled By Jetty Should Not Be Blocked By JMX Property Providers
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47961/#review135301
---
ambari-server/src/main/java/org/apache/ambari/server/controller/utilities/BufferedThreadPoolExecutorCompletionService.java
(line 107)
<https://reviews.apache.org/r/47961/#comment200325>
Small optimization: Returning here is going to make us NOT submit any of
the overflown requests till ALL of the already submitted ones are completed. So
if 10 threads + 10-queue got 22 requests, the 2 overflown requests will not be
executed till all 20 got executed. Optimization is to immediately submit the
overflown requests, when we know of completed requests.
- Srimanth Gunturi
On May 27, 2016, 7:18 p.m., Jonathan Hurley wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47961/
> ---
>
> (Updated May 27, 2016, 7:18 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Nate Cole, Robert Levas,
> Robert Nettleton, and Srimanth Gunturi.
>
>
> Bugs: AMBARI-16913
> https://issues.apache.org/jira/browse/AMBARI-16913
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Incoming requests from the web client (or from any REST API) will eventually
> be routed to the property provider / subresource framework. It is here were
> any JMX data is queried for within the context of the REST request. In large
> clusters, these requests can backup quite easily (even with a massive
> threadpool), causing UX degradations in the web client:
>
> ```
> Thread [qtp-ambari-client-38]
>
> JMXPropertyProvider(ThreadPoolEnabledPropertyProvider).populateResources(Set,
> Request, Predicate) line: 168
> JMXPropertyProvider.populateResources(Set, Request,
> Predicate) line: 156
> StackDefinedPropertyProvider.populateResources(Set, Request,
> Predicate) line: 200
> ClusterControllerImpl.populateResources(Type, Set, Request,
> Predicate) line: 155
> QueryImpl.queryForResources() line: 407
> QueryImpl.execute() line: 217
> ReadHandler.handleRequest(Request) line: 69
> GetRequest(BaseRequest).process() line: 145
> ```
>
> Consider one of the calls made by the web client:
> ```
> GET api/v1/clusters/c1/components/?
> ServiceComponentInfo/category=MASTER&
> fields=
> ServiceComponentInfo/service_name,
> host_components/HostRoles/display_name,
> host_components/HostRoles/host_name,
> host_components/HostRoles/state,
> host_components/HostRoles/maintenance_state,
> host_components/HostRoles/stale_configs,
> host_components/HostRoles/ha_state,
> host_components/HostRoles/desired_admin_state,
> host_components/metrics/jvm/memHeapUsedM,
> host_components/metrics/jvm/HeapMemoryMax,
> host_components/metrics/jvm/HeapMemoryUsed,
> host_components/metrics/jvm/memHeapCommittedM,
> host_components/metrics/mapred/jobtracker/trackers_decommissioned,
> host_components/metrics/cpu/cpu_wio,
> host_components/metrics/rpc/client/RpcQueueTime_avg_time,
> host_components/metrics/dfs/FSNamesystem/*,
> host_components/metrics/dfs/namenode/Version,
> host_components/metrics/dfs/namenode/LiveNodes,
> host_components/metrics/dfs/namenode/DeadNodes,
> host_components/metrics/dfs/namenode/DecomNodes,
> host_components/metrics/dfs/namenode/TotalFiles,
> host_components/metrics/dfs/namenode/UpgradeFinalized,
> host_components/metrics/dfs/namenode/Safemode,
> host_components/metrics/runtime/StartTime
> ```
>
> This query is essentially saying that for every {{MASTER}}, get metrics from
> them. The problem is that in a large cluster, there could be 100 masters, yet
> the metrics being asked for are only for NameNode. As a result, the JMX
> endpoints for all 100 masters are queried - *live* - as part of the request.
>
> There are two inherent flaws with this approach:
>
> - Even with millisecond JMX response times, multiplying this by 100's and
> then adding parsing overhead causes a noticeable delay in the web client as
> the federated requests are blocking the main UX request
>
> - Although there is a threadpool which scales up to service these requests -
> that only really works for 1 user. With multiple users logged in, you'd need
> 100's upon 100's of threads pulling in the same JMX data
>
> This data should never be queried for directly as part of the incoming REST
> requests. Instead, an autonomous pool of threads should be constantly
> retriev
Re: Review Request 47885: AMBARI-16894: Default Ranger repos for some services are not getting created
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47885/#review135279 --- Ship it! Ship It! - Srimanth Gunturi On May 27, 2016, 4:30 a.m., Gautam Borad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47885/ > --- > > (Updated May 27, 2016, 4:30 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Jayush Luniya, > Mahadev Konar, Sumit Mohanty, Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-16894 > https://issues.apache.org/jira/browse/AMBARI-16894 > > > Repository: ambari > > > Description > --- > > Fixed the logic of default repo creation that was broken due to previous > commits. > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/ranger_functions_v2.py > efb0819 > > Diff: https://reviews.apache.org/r/47885/diff/ > > > Testing > --- > > Tested on a local instance with different services. > > > Thanks, > > Gautam Borad > >
Re: Review Request 47722: AMBARI-16813 Ranger Usersync config to support Group Based Search for LDAP Sync Source
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47722/#review134919 --- Ship it! Ship It! - Srimanth Gunturi On May 25, 2016, 10:38 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47722/ > --- > > (Updated May 25, 2016, 10:38 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Gautam > Borad, Jaimin Jetly, Jayush Luniya, Mahadev Konar, Srimanth Gunturi, and > Velmurugan Periasamy. > > > Bugs: AMBARI-16813 > https://issues.apache.org/jira/browse/AMBARI-16813 > > > Repository: ambari > > > Description > --- > > Changes include > - Added two new properties under ranger-ugsync-site.xml to support Group > based search. > - quicklinks.json > - adding multiLine for property > hadoop.kms.authentication.kerberos.name.rules > - hdfs audit for KMS should pick up the fs.defaultFS from core-site.xml > - Add Proxy in kms-site.xml, hadoop.kms.proxyuser.ranger.users/groups/hosts > > > Diffs > - > > > ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py > e9c9507 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > d4418e0 > > ambari-server/src/main/resources/common-services/RANGER/0.5.0/quicklinks/quicklinks.json > 795e464 > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/ranger-ugsync-site.xml > 5298169 > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/configuration/tagsync-application-properties.xml > ea00fbe > > ambari-server/src/main/resources/common-services/RANGER/0.6.0/themes/theme_version_3.json > d5efca4 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/kms-site.xml > e559d92 > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-audit.xml > 7c98fb3 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 188479e > > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/configuration/dbks-site.xml > fca42b3 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/RANGER_KMS/themes/theme_version_2.json > cce73e0 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 11aac72 > ambari-server/src/test/python/stacks/2.3/common/test_stack_advisor.py > 6981205 > > Diff: https://reviews.apache.org/r/47722/diff/ > > > Testing > --- > > Tested Ranger installation on centos 6 > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 47785: Ambari install of Atlas should use external HBase and Logsearch SOLR
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47785/#review134876 --- ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py (line 143) <https://reviews.apache.org/r/47785/#comment199821> Just wanted to make sure if this always be true? - Srimanth Gunturi On May 25, 2016, 10:06 p.m., Tom Beerbower wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47785/ > --- > > (Updated May 25, 2016, 10:06 p.m.) > > > Review request for Ambari, John Speidel, Nate Cole, and Srimanth Gunturi. > > > Bugs: AMBARI-16853 and ATLAS-823 > https://issues.apache.org/jira/browse/AMBARI-16853 > https://issues.apache.org/jira/browse/ATLAS-823 > > > Repository: ambari > > > Description > --- > > To support this, add dependency from Atlas to LogSearch SOLR. Also remove > references to embedded SOLR and embedded HBase. > > Use solr_cloud_util to create indexes for Atlas install. > > See AMBARI-15865. > See Atlas-823. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/application-properties.xml > bf0467e > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-env.xml > dd4b3e2 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/configuration/atlas-hbase-site.xml > 3c4826d > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/metainfo.xml > f4115f7 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/atlas_client.py > 6b045ca > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/metadata.py > e305138 > > ambari-server/src/main/resources/common-services/ATLAS/0.1.0.2.3/package/scripts/params.py > f172b79 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/application-properties.xml > 0631b7d > > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/configuration/atlas-env.xml > 2a5f777 > ambari-server/src/main/resources/stacks/HDP/2.5/services/ATLAS/metainfo.xml > 15daeea > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > af812fe > ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py > 98fc678 > ambari-server/src/test/python/stacks/2.3/configs/default.json c8b418b > ambari-server/src/test/python/stacks/2.3/configs/secure.json 7ebcedf > ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 9d0f00c > ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py > 51c0d0c > ambari-server/src/test/python/stacks/2.5/configs/default.json e4a97f6 > > Diff: https://reviews.apache.org/r/47785/diff/ > > > Testing > --- > > Manual test of Atlas install. > > Updated unit tests. > > mvn clean test > > > Thanks, > > Tom Beerbower > >
Re: Review Request 47676: Spark History Server heap size is not exposed (History Server crashed with OOM)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47676/#review134867 --- Ship it! Ship It! - Srimanth Gunturi On May 25, 2016, 8:06 p.m., Weiqing Yang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47676/ > --- > > (Updated May 25, 2016, 8:06 p.m.) > > > Review request for Ambari, Sumit Mohanty and Srimanth Gunturi. > > > Bugs: AMBARI-16757 > https://issues.apache.org/jira/browse/AMBARI-16757 > > > Repository: ambari > > > Description > --- > > Ambari is not exposing the heap size parameter for Spark History Server. > The workaround is to modify spark-env and add "SPARK_DAEMON_MEMORY=2g" for > example. > The newer versions of Spark defaults this to 1g, but on the older versions, > it was defaulting to 512m it seems, and it was causing OOM. > So in the patch, "SPARK_DAEMON_MEMORY=1G" is added in the spark-env template > (default: 1G). > > > Diffs > - > > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml > 8a5117a > > Diff: https://reviews.apache.org/r/47676/diff/ > > > Testing > --- > > Tested all the versions of Spark on Ambari trunk build successfully. > > > Thanks, > > Weiqing Yang > >
Re: Review Request 47847: AMBARI-16755 Add spark.driver.extraLibraryPath
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47847/#review134864
---
ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-defaults.xml
(line 154)
<https://reviews.apache.org/r/47847/#comment199804>
WebHCat and Hive use "/usr/hdp/${hdp.version}" when specifying paths.
- Srimanth Gunturi
On May 25, 2016, 7:37 p.m., Weiqing Yang wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47847/
> ---
>
> (Updated May 25, 2016, 7:37 p.m.)
>
>
> Review request for Ambari, Sumit Mohanty and Srimanth Gunturi.
>
>
> Bugs: AMBARI-16755
> https://issues.apache.org/jira/browse/AMBARI-16755
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Add spark.driver.extraLibraryPath in spark-defaults.conf and
> spark-thrift-sparkconf.conf.
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-defaults.xml
> b507d5e
>
> ambari-server/src/main/resources/common-services/SPARK/1.5.2/configuration/spark-thrift-sparkconf.xml
> b5742ea
>
> Diff: https://reviews.apache.org/r/47847/diff/
>
>
> Testing
> ---
>
> Tests passed. WARNing messages about unable to load native-hadoop library are
> gone when users start sparkshell and submit application on Spark.
>
>
> Thanks,
>
> Weiqing Yang
>
>
Re: Review Request 47676: Spark History Server heap size is not exposed (History Server crashed with OOM)
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47676/#review134671 --- ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml (line 69) <https://reviews.apache.org/r/47676/#comment199530> I would recommend putting the unit of 'M' and the value as 1024. This will give user better ability to provide smaller and in-between values instead of providing fractions (1.5G or 1.75G etc) - which is not possible with unit of 'G'. - Srimanth Gunturi On May 24, 2016, 9:23 p.m., Weiqing Yang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47676/ > --- > > (Updated May 24, 2016, 9:23 p.m.) > > > Review request for Ambari, Sumit Mohanty and Srimanth Gunturi. > > > Bugs: AMBARI-16757 > https://issues.apache.org/jira/browse/AMBARI-16757 > > > Repository: ambari > > > Description > --- > > Ambari is not exposing the heap size parameter for Spark History Server. > The workaround is to modify spark-env and add "SPARK_DAEMON_MEMORY=2g" for > example. > The newer versions of Spark defaults this to 1g, but on the older versions, > it was defaulting to 512m it seems, and it was causing OOM. > So in the patch, "SPARK_DAEMON_MEMORY=1G" is added in the spark-env template > (default: 1G). > > > Diffs > - > > > ambari-server/src/main/resources/common-services/SPARK/1.2.1/configuration/spark-env.xml > 8a5117a > > Diff: https://reviews.apache.org/r/47676/diff/ > > > Testing > --- > > Tested all the versions of Spark on Ambari trunk build successfully. > > > Thanks, > > Weiqing Yang > >
Re: Review Request 47288: AMBARI-16225. Storm Ambari view should work with Firefox 25
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47288/#review133800 --- Ship it! Ship It! - Srimanth Gunturi On May 17, 2016, 5:51 a.m., Sriharsha Chintalapani wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47288/ > --- > > (Updated May 17, 2016, 5:51 a.m.) > > > Review request for Ambari and Srimanth Gunturi. > > > Bugs: AMBARI-16225 > https://issues.apache.org/jira/browse/AMBARI-16225 > > > Repository: ambari > > > Description > --- > > Storm Ambari view should work with Firefox 25 > > > Diffs > - > > > contrib/views/storm/src/main/resources/scripts/collections/BaseCollection.js > 29b1ce9 > contrib/views/storm/src/main/resources/scripts/components/Breadcrumbs.jsx > 75c2fa9 > contrib/views/storm/src/main/resources/scripts/components/Modal.jsx e37b734 > contrib/views/storm/src/main/resources/scripts/components/RadialChart.jsx > f28b08a > contrib/views/storm/src/main/resources/scripts/components/SpoutGraph.jsx > cec4c85 > contrib/views/storm/src/main/resources/scripts/components/Table.jsx 3b0ad50 > contrib/views/storm/src/main/resources/scripts/components/TopologyGraph.jsx > e74a251 > contrib/views/storm/src/main/resources/scripts/containers/NimbusSummary.jsx > ee901b9 > > contrib/views/storm/src/main/resources/scripts/containers/SupervisorSummary.jsx > e403b86 > > contrib/views/storm/src/main/resources/scripts/containers/TopologyConfiguration.jsx > dd2ad64 > > contrib/views/storm/src/main/resources/scripts/containers/TopologyDetailGraph.jsx > 64fdee1 > > contrib/views/storm/src/main/resources/scripts/containers/TopologyListing.jsx > 9ce19f0 > contrib/views/storm/src/main/resources/scripts/modules/Table/Pagination.jsx > 41a763c > contrib/views/storm/src/main/resources/scripts/router/Router.js 24fc1e0 > > contrib/views/storm/src/main/resources/scripts/views/ComponentDetailView.jsx > 14f7527 > contrib/views/storm/src/main/resources/scripts/views/ProfilingView.jsx > eb9d0d1 > contrib/views/storm/src/main/resources/scripts/views/RebalanceView.jsx > 96f01a6 > contrib/views/storm/src/main/resources/scripts/views/TopologyDetailView.jsx > bf66903 > > Diff: https://reviews.apache.org/r/47288/diff/ > > > Testing > --- > > > Thanks, > > Sriharsha Chintalapani > >
Re: Review Request 47456: Takeover config merge should handle AMS hbase configs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47456/#review133796 --- Ship it! Ship It! - Srimanth Gunturi On May 18, 2016, 3:06 p.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47456/ > --- > > (Updated May 18, 2016, 3:06 p.m.) > > > Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi. > > > Bugs: AMBARI-16703 > https://issues.apache.org/jira/browse/AMBARI-16703 > > > Repository: ambari > > > Description > --- > > hbase-site conflicts between cluster and AMS. > > Hard code the config path as /etc/ams-hbase/conf to be AMS HBase configs. > > > Diffs > - > > ambari-server/src/main/resources/scripts/takeover_config_merge.py f940f27 > ambari-server/src/main/resources/scripts/takeover_files_mapping.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/47456/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 47456: Takeover config merge should handle AMS hbase configs
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47456/#review133634 --- ambari-server/src/main/resources/scripts/takeover_files_mapping.json (line 2) <https://reviews.apache.org/r/47456/#comment198187> If we are creating a mapping file for file/path=>config-type, we should add other commonly used paths and map them to config-types. Files like 'log4j.properties' which maps to hdfs-log4j, yarn-log4j, etc... This file by default should have all the most common paths, and their correct config-types. - Srimanth Gunturi On May 17, 2016, 2:16 p.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47456/ > --- > > (Updated May 17, 2016, 2:16 p.m.) > > > Review request for Ambari, Sid Wagle and Vitalyi Brodetskyi. > > > Bugs: AMBARI-16703 > https://issues.apache.org/jira/browse/AMBARI-16703 > > > Repository: ambari > > > Description > --- > > hbase-site conflicts between cluster and AMS. > > Hard code the config path as /etc/ams-hbase/conf to be AMS HBase configs. > > > Diffs > - > > ambari-server/src/main/resources/scripts/takeover_config_merge.py f940f27 > ambari-server/src/main/resources/scripts/takeover_files_mapping.json > PRE-CREATION > > Diff: https://reviews.apache.org/r/47456/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 47331: AMBARI-16649 : RegionServer and Nimbus start failed on secure cluster due to Ranger stack changes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47331/#review133105 --- Ship it! Ship It! - Srimanth Gunturi On May 13, 2016, 9:46 a.m., Gautam Borad wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47331/ > --- > > (Updated May 13, 2016, 9:46 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Jaimin > Jetly, Mahadev Konar, Nate Cole, Robert Levas, Sumit Mohanty, Srimanth > Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-16649 > https://issues.apache.org/jira/browse/AMBARI-16649 > > > Repository: ambari > > > Description > --- > > Restart of Hbase and Storm fails on Kerberos env due to missing principals > for older stacks. > > > Diffs > - > > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > d3fc173 > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py > d715a25 > > Diff: https://reviews.apache.org/r/47331/diff/ > > > Testing > --- > > Verified Hbase and Storm enable / disable plugin for Ranger in Kerberos env. > > Verified normal Install / Restarts of Hbase and Storm as well (in Kerberos > env). > > > Thanks, > > Gautam Borad > >
Re: Review Request 47235: Takeover script on Paypal configs results in conflict message that look wrong
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47235/#review132678 --- Ship it! Ship It! - Srimanth Gunturi On May 11, 2016, 1:54 p.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47235/ > --- > > (Updated May 11, 2016, 1:54 p.m.) > > > Review request for Ambari, Srimanth Gunturi and Sid Wagle. > > > Bugs: AMBARI-16451 > https://issues.apache.org/jira/browse/AMBARI-16451 > > > Repository: ambari > > > Description > --- > > Attaching the zip file with configs and conflicts. > > * The conflicting configs seem to have a lot of duplicate info > mapred-site :: dfs.datanode.du.reserved > > * Unable to handle empty config files: > Had to hand edit and add try / catch at : > > > yaml.load(file).iteritems() > > > parsed_configurations_from_path, parsed_properties_attributes = > parser.read_data_to_map(path) > > > > > Traceback (most recent call last): > File "./takeover_config_merge.py", line 393, in > sys.exit(main()) > File "./takeover_config_merge.py", line 389, in main > return configMerge.perform_merge() > File "./takeover_config_merge.py", line 279, in perform_merge > parsed_configurations_from_path, parsed_properties_attributes = > parser.read_data_to_map(path) > File "./takeover_config_merge.py", line 86, in read_data_to_map > for name, value in yaml.load(file).iteritems(): > AttributeError: 'NoneType' object has no attribute 'iteritems' > > > _Instruction_ > > > > > ./takeover_config_merge.py -o blueprint -i files > > > Diffs > - > > ambari-server/src/main/resources/scripts/takeover_config_merge.py 1432e4b > > Diff: https://reviews.apache.org/r/47235/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 47048: Show background op window when Interactive query is enabled/disabled
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47048/#review131975 --- Ship it! Ship It! - Srimanth Gunturi On May 6, 2016, 12:16 a.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47048/ > --- > > (Updated May 6, 2016, 12:16 a.m.) > > > Review request for Ambari and Srimanth Gunturi. > > > Bugs: AMBARI-16269 > https://issues.apache.org/jira/browse/AMBARI-16269 > > > Repository: ambari > > > Description > --- > > STR: > Deploy a cluster with Hive service > Post deployment of the cluster, Enable interactive query on Hive service page > Click on save button to save configuration. > > Actual behavior: Confirmation popup about configurations successfully saved > is shown to user. Background ops blinks showing running requests > Expected behavior: On clicking "ok" on popup about configurations > successfully saved, background op window should come up showing running > requests. Thus making it explicit to the user about ongoing operations on > saving configurations. > > > Diffs > - > > ambari-web/app/mixins/common/configs/configs_saver.js 1f81ef1 > ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js > 080fff1 > > Diff: https://reviews.apache.org/r/47048/diff/ > > > Testing > --- > > Tested the patch to work manually on the cluster: > Verified that all ambari-web unit tests passes: > 27718 tests complete (37 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 47014: Blueprint processor should create ConfigGroup even with only one host registered
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47014/#review131871 --- Ship it! Ship It! - Srimanth Gunturi On May 5, 2016, 3:55 p.m., Sebastian Toader wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47014/ > --- > > (Updated May 5, 2016, 3:55 p.m.) > > > Review request for Ambari, Daniel Gergely, Laszlo Puskas, Sandor Magyari, > Srimanth Gunturi, and Sid Wagle. > > > Bugs: AMBARI-16270 > https://issues.apache.org/jira/browse/AMBARI-16270 > > > Repository: ambari > > > Description > --- > > When the first host for a host group registers with the cluster and is > assigned to host group Ambari checks if there is any config group to be > created for that host group. If it has to than create a config group and > assigning to it all hosts that are expected for the parent host group. > However it not checks is all of the expected hosts of the host group have > already been associated with the cluster thus the config group creation fails > as config groups can have only hosts added that already are associated with > the cluster. > > This has been changed to add only those hosts to config group that already > have been associated with the cluster and update the created config group > with the remaing hosts as these become available and register with the > cluster. > > > Diffs > - > > > ambari-server/src/main/java/org/apache/ambari/server/topology/AmbariContext.java > cf1a6ac > > ambari-server/src/test/java/org/apache/ambari/server/topology/AmbariContextTest.java > 1613d11 > > Diff: https://reviews.apache.org/r/47014/diff/ > > > Testing > --- > > Manual testing done. > > Unit test results: > Results : > > Tests run: 3568, Failures: 0, Errors: 0, Skipped: 36 > > > Thanks, > > Sebastian Toader > >
Re: Review Request 44210: AMBARI-15226 - The stack advisor should be pushed down to the services
> On April 22, 2016, 5:10 p.m., Srimanth Gunturi wrote: > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java, > > line 77 > > <https://reviews.apache.org/r/44210/diff/2/?file=1348336#file1348336line77> > > > > Trying to think if we really need to expose the 'advisor_name' and > > 'advisor_path' in the stack-service API response? The files will be at > > known locations anyways and used when available... similar to the stack's > > advisor_path/advisor_name. > > > > I am thinking this can work without adding these 2 properties to a > > stack-service. > > Tim Thorpe wrote: > The reason this works for the stack is because the stack_advisor.py in > the scripts directory attempts to load all the stack_advisor.py files. It > uses the stack name, stack version and parent versions to determine what to > load. It starts with the oldest version and keeps loading until the most > recent version. In order to do this for services, we'd need to know the some > sort of information to determine what to load from where. I could have added > something similar so that it would look into the stack versions and then > somehow look to common services if that was required. In my code I was > testing with HAWQ and PXF with their service advisor's being loaded from the > common-services directory. It seemed much easier to me at least to get the > service_advisor.py location and calculate the advisor name in the java code > when reading the stack and services (StackManager/StackModule/StackDirectory > etc...). This way I know exactly where to load the py file and exactly what > class name t o use. Yes, I agree that it makes it easy to determine location of files. But if you look at it from pure API perspective, it is not useful for any caller except ambari-server - None of the callers have access to those paths/files except ambari-server. It is ambari-server's internals exposed outside just for its own consumption. Also, like the stack's service-advisor.py, the service's files can be dynamically located and loaded. If it is a question of efficiency, we can cache the result so that for a stack-version's service we only determine this once. My vote would be to not have these properties on the stack service's response. - Srimanth --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44210/#review130123 --- On April 22, 2016, 6:27 p.m., Tim Thorpe wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44210/ > --- > > (Updated April 22, 2016, 6:27 p.m.) > > > Review request for Ambari, Alexander Denissov, bhuvnesh chaudhary, Jayush > Luniya, Oleksandr Diachenko, Sumit Mohanty, Srimanth Gunturi, and Yusaku Sako. > > > Bugs: AMBARI-15226 > https://issues.apache.org/jira/browse/AMBARI-15226 > > > Repository: ambari > > > Description > --- > > Currently the stack advisor is defined under each stack version such as > HDP/2.3. The problem with this is that it restricts the services that can be > added to the stack. If a custom service is to be added, they would need to > modify the stack advisor. If the configuration recommendation and validation > can be done at the service level then the custom service could just include > their own recommendations and validations separately. > > > Diffs > - > > ambari-server/src/main/assemblies/server.xml e1a4919 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/AmbariMetaInfo.java > df65010 > > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java > 00c8696 > > ambari-server/src/main/java/org/apache/ambari/server/controller/StackServiceResponse.java > ca1968e > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackServiceResourceProvider.java > 6c6fa91 > > ambari-server/src/main/java/org/apache/ambari/server/stack/CommonServiceDirectory.java > 636de37 > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceDirectory.java > d574d60 > > ambari-server/src/main/java/org/apache/ambari/server/stack/ServiceModule.java > b7e09a9 > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java > d27e52a > ambari-server/src/main/java/org/apache/ambari/serv
Re: Review Request 46500: Regenerating keytabs on re-imaged hosts results in error during 'Creating Principals'
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46500/#review129921
---
Ship it!
Ship It!
- Srimanth Gunturi
On April 21, 2016, 5:01 p.m., Robert Levas wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46500/
> ---
>
> (Updated April 21, 2016, 5:01 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley, Nate Cole, Oliver Szabo, Srimanth
> Gunturi, and Sid Wagle.
>
>
> Bugs: AMBARI-16009
> https://issues.apache.org/jira/browse/AMBARI-16009
>
>
> Repository: ambari
>
>
> Description
> ---
>
> We had a 1600 unsecured cluster initially, from which 700 nodes were
> destroyed. Though Ambari-server knew of 1600 hosts, only 900 were
> heartbeating. At this point we secured the cluster and everything was good.
> Then we brought back the 700 hosts, which started heartbeating with
> ambari-server.
>
> At this point we did 'Regenerate Keytabs' which failed at the 'Create
> Principals' step (image attached), as it was trying to re-create principal
> which is already existing with kadmin, and with ambari-server.
>
> #Create Principals
> Stderr:
> ```
> 2016-04-21 01:28:52,985 - Failed to create or update principal,
> HTTP/host1.example@example.com - Failed to create service principal for
> HTTP/host1.example@example.com
> STDOUT: Authenticating as principal admin/admin with password.
>
> STDERR: WARNING: no policy specified for HTTP/host1.example@example.com;
> defaulting to no policy
> add_principal: Principal or policy already exists while creating
> "HTTP/host1.example@example.com".
> {noformat}
>
> Stdout:
> {noformat}
> 2016-04-21 01:27:32,400 - Processing identities...
> 2016-04-21 01:28:29,874 - Processing principal,
> HTTP/host1.example@example.com
> ```
>
>
> Diffs
> -
>
>
> ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandler.java
> f48052f
>
> ambari-server/src/test/java/org/apache/ambari/server/serveraction/kerberos/MITKerberosOperationHandlerTest.java
> d15db17
>
> Diff: https://reviews.apache.org/r/46500/diff/
>
>
> Testing
> ---
>
> Manually tested enabling Kerberos and Regenerating Keytabs both having
> unexpected principals in or removed from the KDC as needed to attempt to
> generate the issue.
>
> #Local test results:
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 1:19:08.563s
> [INFO] Finished at: Thu Apr 21 12:45:33 EDT 2016
> [INFO] Final Memory: 60M/1866M
> [INFO]
>
>
> # Jenkins test results: PENDING
>
>
> Thanks,
>
> Robert Levas
>
>
Re: Review Request 45713: AMBARI-15700: Stack advisor - Component layout recommendation needs support for avoiding hosts in maintenance mode
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45713/#review129356 --- Ship it! Ship It! - Srimanth Gunturi On April 11, 2016, 5:36 p.m., Nahappan Somasundaram wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45713/ > --- > > (Updated April 11, 2016, 5:36 p.m.) > > > Review request for Ambari, Zhe (Joe) Wang, Sumit Mohanty, Srimanth Gunturi, > and Sid Wagle. > > > Bugs: AMBARI-15700 > https://issues.apache.org/jira/browse/AMBARI-15700 > > > Repository: ambari > > > Description > --- > > AMBARI-15700: Stack advisor - Component layout recommendation needs support > for avoiding hosts in maintenance mode > > ** Issue ** > Stack advisor script should ignore hosts in maintenance mode when > recommending or validating component layout > > ** Fix ** > Modified the stack advisor scripts to handle the case when one or more hosts > are in maintenance state while recommending or validating component layout > Added two test cases to validate the recommendation when one or more hosts > are in maintenance state. > > > Diffs > - > > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py > 53591cdcaed05713013be1ba7295b1c2b3ed64af > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 0130483d3e1f08afe495fb30b6341f6f825f145d > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py > b99c484b3e65de0c9186727064fc67a4bb1d8315 > ambari-server/src/main/resources/stacks/stack_advisor.py > 636de01ad6fc72d9dc397b754aa5e190d4d9c5ff > ambari-server/src/test/python/TestStackAdvisor.py > 149ae1dc7ea2e596680321dd70030dcfe060f6cf > > Diff: https://reviews.apache.org/r/45713/diff/ > > > Testing > --- > > ** 1. mvn clean install ** > > [INFO] > > [INFO] Reactor Summary: > [INFO] > [INFO] Ambari Main ... SUCCESS [8.744s] > [INFO] Apache Ambari Project POM . SUCCESS [0.041s] > [INFO] Ambari Web SUCCESS [25.392s] > [INFO] Ambari Views .. SUCCESS [1.375s] > [INFO] Ambari Admin View . SUCCESS [11.669s] > [INFO] ambari-metrics SUCCESS [0.375s] > [INFO] Ambari Metrics Common . SUCCESS [0.524s] > [INFO] Ambari Metrics Hadoop Sink SUCCESS [1.450s] > [INFO] Ambari Metrics Flume Sink . SUCCESS [0.662s] > [INFO] Ambari Metrics Kafka Sink . SUCCESS [0.685s] > [INFO] Ambari Metrics Storm Sink . SUCCESS [2.209s] > [INFO] Ambari Metrics Collector .. SUCCESS [7.115s] > [INFO] Ambari Metrics Monitor SUCCESS [2.137s] > [INFO] Ambari Metrics Grafana SUCCESS [0.980s] > [INFO] Ambari Metrics Assembly ... SUCCESS [1:18.948s] > [INFO] Ambari Server . SUCCESS [2:56.964s] > [INFO] Ambari Functional Tests ... SUCCESS [2.720s] > [INFO] Ambari Agent .. SUCCESS [24.955s] > [INFO] Ambari Client . SUCCESS [0.045s] > [INFO] Ambari Python Client .. SUCCESS [0.838s] > [INFO] Ambari Groovy Client .. SUCCESS [2.152s] > [INFO] Ambari Shell .. SUCCESS [0.054s] > [INFO] Ambari Python Shell ... SUCCESS [0.719s] > [INFO] Ambari Groovy Shell ... SUCCESS [1.118s] > [INFO] > > [INFO] BUILD SUCCESS > [INFO] > > [INFO] Total time: 5:54.648s > [INFO] Finished at: Thu Apr 07 16:59:26 PDT 2016 > [INFO] Final Memory: 261M/1301M > [INFO] > > > ** 2. mvn test -DskipSurefireTests ** > > -- > Ran 253 tests in 6.689s > > OK > --
Re: Review Request 46194: HDP 2.3.2.0: Changing hive tez container size (via ambari) should change tez.runtime.io.sort.mb as well
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46194/#review128918 --- Ship it! Ship It! - Srimanth Gunturi On April 14, 2016, 11:27 a.m., Andrew Onischuk wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46194/ > --- > > (Updated April 14, 2016, 11:27 a.m.) > > > Review request for Ambari and Srimanth Gunturi. > > > Bugs: AMBARI-15879 > https://issues.apache.org/jira/browse/AMBARI-15879 > > > Repository: ambari > > > Description > --- > > Observed this in HDP 2.3.2 > > Original hive tez container size: 24576 > Original tez.runtime.io.sort.mb: 14950 or around this value > > Changed hive tez container size to 16384. But tez.runtime.io.sort.mb remained > at 14 GB. Hive queries starts failing due to mem issue. > > Ideally, when hive tez container size is adjusted, tez.runtime.io.sort.mb > should also be auto-adjusted in ambari (or a warning would be useful). > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 3a65541 > > Diff: https://reviews.apache.org/r/46194/diff/ > > > Testing > --- > > mvn clean test > > > Thanks, > > Andrew Onischuk > >
Re: Review Request 46105: capacity-scheduler config blob is not a part of recommendation API when Hive Interactive query is turned ON
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46105/#review128492 --- Ship it! Ship It! - Srimanth Gunturi On April 12, 2016, 6:03 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/46105/ > --- > > (Updated April 12, 2016, 6:03 p.m.) > > > Review request for Ambari, Srimanth Gunturi, Swapan Shridhar, and Yusaku Sako. > > > Bugs: AMBARI-15846 > https://issues.apache.org/jira/browse/AMBARI-15846 > > > Repository: ambari > > > Description > --- > > capacity-scheduler config blob is part of recommendation API when any config > on YARN page is changed but now when any config on which capacity-scheduler > config depends is changed. > > > Diffs > - > > ambari-web/app/controllers/main/service/info/configs.js 738d235 > ambari-web/app/mixins/main/service/configs/component_actions_by_configs.js > 9909fd4 > > Diff: https://reviews.apache.org/r/46105/diff/ > > > Testing > --- > > Verified manually that patch resolves the issue > Verified that all ambari-web unit tests passes with the patch: > 25640 tests complete (26 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 45841: Restart LLAP action should be shown only when Hive Interactive Server is present in the cluster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45841/#review127508 --- Ship it! Ship It! - Srimanth Gunturi On April 6, 2016, 11:25 p.m., Jaimin Jetly wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45841/ > --- > > (Updated April 6, 2016, 11:25 p.m.) > > > Review request for Ambari, Srimanth Gunturi and Yusaku Sako. > > > Bugs: AMBARI-15748 > https://issues.apache.org/jira/browse/AMBARI-15748 > > > Repository: ambari > > > Description > --- > > Restart LLAP action should be shown only when Hive Interactive Server is > present in the cluster > > > Diffs > - > > ambari-web/app/views/main/service/item.js 790c0dc > ambari-web/test/views/main/service/item_test.js 3c0e6aa > > Diff: https://reviews.apache.org/r/45841/diff/ > > > Testing > --- > > Tested the patch on a cluster. > Verified that all ambari-web unit tests passes on the trunk with the patch: > > 25637 tests complete (28 seconds) > 154 tests pending > > > Thanks, > > Jaimin Jetly > >
Re: Review Request 45705: HAWQ segment percentage alert critical threshold should be 25%
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45705/#review127014 --- Ship it! Ship It! - Srimanth Gunturi On April 4, 2016, 9:48 p.m., Alexander Denissov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/45705/ > --- > > (Updated April 4, 2016, 9:48 p.m.) > > > Review request for Ambari, Alejandro Fernandez, bhuvnesh chaudhary, Goutam > Tadi, Lav Jain, Matt, Sumit Mohanty, and Srimanth Gunturi. > > > Bugs: AMBARI-15693 > https://issues.apache.org/jira/browse/AMBARI-15693 > > > Repository: ambari > > > Description > --- > > HAWQ segment percentage alert critical threshold should be 25% > > > Diffs > - > > ambari-server/src/main/resources/common-services/HAWQ/2.0.0/alerts.json > 8da5beb > ambari-web/app/views/main/dashboard/widgets.js 04be7bb > ambari-web/app/views/main/dashboard/widgets/hawqsegment_live.js c35d2b2 > > Diff: https://reviews.apache.org/r/45705/diff/ > > > Testing > --- > > manual, ran python tests: > > -- > Total run:933 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alexander Denissov > >
Re: Review Request 44880: AMBARI-15436 Supportability: Create 'Reset UI' button in Ambari's experimental page
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44880/#review124098 --- Ship it! Ship It! - Srimanth Gunturi On March 17, 2016, 8:52 p.m., Zhe (Joe) Wang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44880/ > --- > > (Updated March 17, 2016, 8:52 p.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Srimanth Gunturi, Xi > Wang, and Yusaku Sako. > > > Bugs: AMBARI-15436 > https://issues.apache.org/jira/browse/AMBARI-15436 > > > Repository: ambari > > > Description > --- > > Currently Ambari UI persists it's current state on the server. This helps > when a different user logs in, they end up in the same UI. Sometimes however, > UI's state persisted on server does not sync with cluster state, thereby > putting UI in a broken state with no recourse for the stuck user. > > Ambari UI should provide a _Reset UI_ button in the experimental page which > resets the UI state on server. > > > Diffs > - > > ambari-web/app/controllers/experimental.js 9fa6da5 > ambari-web/app/mappers/server_data_mapper.js 1e08161 > ambari-web/app/messages.js 9289fc2 > ambari-web/app/templates/experimental.hbs 2873679 > > Diff: https://reviews.apache.org/r/44880/diff/ > > > Testing > --- > > Local ambari-web test passed. > 24578 tests complete (23 seconds) > 145 tests pending > Manual testing done. > > > Thanks, > > Zhe (Joe) Wang > >
