Re: Review Request 53075: Fix JSHint errors in Workflow Manager view
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53075/#review153593 --- There are more changes we are working on (introducing Coordinator, bundle etc) and some further refactoring (the use of validator etc). Let me review thi a bit more carefully if there are intersections - Venkat Ranganathan On Oct. 21, 2016, 11:28 a.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53075/ > --- > > (Updated Oct. 21, 2016, 11:28 a.m.) > > > Review request for Ambari, Di Li, Venkat Ranganathan, and Yusaku Sako. > > > Bugs: AMBARI-18615 > https://issues.apache.org/jira/browse/AMBARI-18615 > > > Repository: ambari > > > Description > --- > > When you compile the Workflow Manager view, you see 94 JSHint errors. > > Fix includes: > > 1) Adding a .jshintrc file for applying /*jshint esversion: 6 */ to the whole > project to address errors similar to 'import' is only available in ES6 (use > 'esversion: 6'). > 2) Adding semi-colons where they are missing. > 3) Using dot notation instead of array > > The patch also fixes the error due to incorrect version of > org.apache.ambari.contrib.views. > > The test failure for this patch is caused by an existing issue unrelated to > this patch. > > Failed to execute goal org.apache.maven.plugins:maven-war-plugin:2.4:war > (default-war) on project oozie-ui: The specified web.xml file > '/home/jenkins/jenkins-slave/workspace/Ambari-trunk-test-patch/ambari/contrib/views/wfmanager/src/main/resources/ui/oozie-ambari-view/src/main/resources/WEB-INF/web.xml' > does not exist -> [Help 1] > > > Diffs > - > > contrib/views/wfmanager/.jshintrc PRE-CREATION > contrib/views/wfmanager/pom.xml 1e910e2 > contrib/views/wfmanager/src/main/resources/ui/README.md dcac346 > > contrib/views/wfmanager/src/main/resources/ui/app/components/flow-designer.js > bd2944b > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-parameters.js > 1f75e64 > > contrib/views/wfmanager/src/main/resources/ui/app/components/workflow-sla.js > dac325f > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_handler.js > PRE-CREATION > > contrib/views/wfmanager/src/main/resources/ui/app/domain/actionjob_hanlder.js > 33204ea > > contrib/views/wfmanager/src/main/resources/ui/app/domain/default-layout-manager.js > e208f83 > contrib/views/wfmanager/src/main/resources/ui/app/domain/layout-manager1.js > 0cd306a > contrib/views/wfmanager/src/main/resources/ui/app/domain/layout-manager2.js > d82b89e > contrib/views/wfmanager/src/main/resources/ui/app/domain/mapping-utils.js > 7cb82e1 > contrib/views/wfmanager/src/main/resources/ui/app/domain/node-handler.js > 49347d8 > contrib/views/wfmanager/src/main/resources/ui/app/domain/schema-versions.js > 9562ae8 > contrib/views/wfmanager/src/main/resources/ui/app/domain/sla-info.js > 76dffbd > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-importer.js > f29adb6 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow-xml-generator.js > 9fc791c > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js > 5908de5 > > contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow_xml_mapper.js > d5dc4da > contrib/views/wfmanager/src/main/resources/ui/app/routes/job.js d849609 > > contrib/views/wfmanager/src/main/resources/ui/app/services/property-extractor.js > 17ff9aa > > Diff: https://reviews.apache.org/r/53075/diff/ > > > Testing > --- > > Manual testing > > > File Attachments > > > JSHint errors > > https://reviews.apache.org/media/uploaded/files/2016/10/20/c6a88e6d-d789-4f80-a7ca-9ec7b319331e__buildOutputJSHint_error.txt > > > Thanks, > > Sangeeta Ravindran > >
Re: Review Request 51863: AMBARI-18383 : Oozie spark failed due to incomplete spark share-lib directory
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51863/#review148807
---
Ship it!
Ship It!
- Venkat Ranganathan
On Sept. 13, 2016, 2:56 p.m., Aravindan Vijayan wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51863/
> ---
>
> (Updated Sept. 13, 2016, 2:56 p.m.)
>
>
> Review request for Ambari, Andrew Onischuk, Laszlo Puskas, Sumit Mohanty, and
> Venkat Ranganathan.
>
>
> Bugs: AMBARI-18383
> https://issues.apache.org/jira/browse/AMBARI-18383
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Failed exception:
>
> "Failing Oozie Launcher, Main class
> [org.apache.oozie.action.hadoop.SparkMain], main()
> threw exception, Missing py4j and/or pyspark zip files. Please add them to
> the lib folder
> or to the Spark sharelib.
>
> org.apache.oozie.action.hadoop.OozieActionConfiguratorException: Missing py4j
> and/or
> pyspark zip files. Please add them to the lib folder or to the Spark
> sharelib."
>
>
> Those two files were not present in the share lib
> hrt_qa@hn0-3ad6fe:~$ hdfs dfs -ls /user/oozie/share/lib/spark/*.zip
> ls: `/user/oozie/share/lib/spark/*.zip': No such file or directory
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py
> ee97a89
> ambari-server/src/main/resources/scripts/Ambaripreupload.py 7c8c601
>
> Diff: https://reviews.apache.org/r/51863/diff/
>
>
> Testing
> ---
>
> Manually tested on sys-prepped cluster.
>
> Execution log
>
> 2016-09-13 21:17:32,590 - Execute[('mv',
> '/usr/hdp/2.5.1.0-16/oozie/share/lib/spark',
> '/usr/hdp/2.5.1.0-16/oozie/share/lib/spark-orig')] {'sudo': True}
> 2016-09-13 21:17:32,613 -
> Directory['/usr/hdp/2.5.1.0-16/oozie/share/lib/spark'] {'owner': 'oozie',
> 'create_parents': True}
> 2016-09-13 21:17:32,635 - Creating directory
> Directory['/usr/hdp/2.5.1.0-16/oozie/share/lib/spark'] since it doesn't exist.
> 2016-09-13 21:17:32,746 - Changing owner for
> /usr/hdp/2.5.1.0-16/oozie/share/lib/spark from 0 to oozie
> 2016-09-13 21:17:32,771 - Execute['cp -f
> /usr/hdp/2.5.1.0-16/oozie/share/lib/spark-orig/oozie-sharelib-spark*.jar
> /usr/hdp/2.5.1.0-16/oozie/share/lib/spark'] {'user': 'oozie'}
> 2016-09-13 21:17:32,804 - Execute['cp -P /usr/hdp/2.5.1.0-16/spark/lib/*.jar
> /usr/hdp/2.5.1.0-16/oozie/share/lib/spark'] {'user': 'oozie'}
> 2016-09-13 21:17:33,125 - Execute['find
> /usr/hdp/2.5.1.0-16/oozie/share/lib/spark/ -type l -delete'] {'user': 'oozie'}
> 2016-09-13 21:17:33,163 - Execute['rm -f
> /usr/hdp/2.5.1.0-16/oozie/share/lib/spark/spark-examples*.jar'] {'user':
> 'oozie'}
> 2016-09-13 21:17:33,220 - Execute['cp -f
> /usr/hdp/2.5.1.0-16/spark/python/lib/*.zip
> /usr/hdp/2.5.1.0-16/oozie/share/lib/spark'] {'user': 'oozie'}
> 2016-09-13 21:17:33,258 - Execute['cp -f
> /usr/hdp/2.5.1.0-16/spark/python/lib/*.jar
> /usr/hdp/2.5.1.0-16/oozie/share/lib/spark'] {'user': 'oozie'}
> No jar files found in Spark client python lib.
> 2016-09-13 21:17:33,293 - HdfsResource['/tmp/oozie/user/oozie/share']
> {'security_enabled': False, 'hadoop_conf_dir': '/etc/hadoop/conf', 'keytab':
> None, 'source': '/usr/hdp/2.5.1.0-16/oozie/share', 'default_fs':
> 'adl://oozie3hadl25.azuredatalakestore.net:443', 'user': 'hdfs',
> 'hdfs_resource_ignore_file':
> '/var/lib/ambari-agent/data/.hdfs_resource_ignore', 'hdfs_site':
> {'dfs.webhdfs.enabled': False}, 'kinit_path_local': None, 'principal_name':
> None, 'recursive_chmod': True, 'owner': 'oozie', 'hadoop_bin_dir':
> '/usr/hdp/2.5.1.0-16/hadoop/bin', 'type': 'directory', 'action':
> ['create_on_execute'], 'mode': 0755}
>
>
> Thanks,
>
> Aravindan Vijayan
>
>
Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install
> On Aug. 2, 2016, 1:58 a.m., Vitalyi Brodetskyi wrote: > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py, > > lines 200-217 > > <https://reviews.apache.org/r/50595/diff/7/?file=1459372#file1459372line200> > > > > I don't see here any condition, is it default db for falcon and user > > always should registrate/use jdbc for it? > > Vitalyi Brodetskyi wrote: > And one more, as i remember we set some special permissions for jdbc > which was downloaded because later you could have troubles with customized > users/permissions/non root user. > > Venkat Ranganathan wrote: > Yes. This is only one and it is really not a JDBC driver. We just use > the download mechanism > > Vitalyi Brodetskyi wrote: > Ok, but anyway i think it will be good to set correct permissions to > prevent related issues. Will create a new JIRA to fix this. Thanks - Venkat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50595/#review144468 ------- On Aug. 1, 2016, 2:21 p.m., Venkat Ranganathan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50595/ > --- > > (Updated Aug. 1, 2016, 2:21 p.m.) > > > Review request for Ambari and Alejandro Fernandez. > > > Bugs: AMBARI-17955 > https://issues.apache.org/jira/browse/AMBARI-17955 > > > Repository: ambari > > > Description > --- > > Enabled the registration of optionally downloaded berkeley db jar file. > Introduce Berekley DB as a jdbc-db (even though it is actually not. > Download je-5.0.73.jar if not already present and inform users on how to > register > > also, fixed Atlas integration changes with classname and packagename > > > Diffs > - > > ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c > ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py > d09bd77 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py > dd1cda0 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py > ebe3634 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 8d5cdc9 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > f8ba3e9 > ambari-server/src/test/python/TestAmbariServer.py 279a172 > ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py > 2dd0da9 > > Diff: https://reviews.apache.org/r/50595/diff/ > > > Testing > --- > > Tested downloading of the jar file by registering with ambari server > Tested Falcon/Atlas component names > > > Thanks, > > Venkat Ranganathan > >
Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install
> On Aug. 2, 2016, 2:01 a.m., Vitalyi Brodetskyi wrote: > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py, > > line 174 > > <https://reviews.apache.org/r/50595/diff/7/?file=1459373#file1459373line174> > > > > I don't think it's a good idea to use hard-coded names. Please take a > > look how it was done for Hive/Oozie. This will be the only version that we can support - Venkat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50595/#review144469 ----------- On Aug. 1, 2016, 2:21 p.m., Venkat Ranganathan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50595/ > --- > > (Updated Aug. 1, 2016, 2:21 p.m.) > > > Review request for Ambari and Alejandro Fernandez. > > > Bugs: AMBARI-17955 > https://issues.apache.org/jira/browse/AMBARI-17955 > > > Repository: ambari > > > Description > --- > > Enabled the registration of optionally downloaded berkeley db jar file. > Introduce Berekley DB as a jdbc-db (even though it is actually not. > Download je-5.0.73.jar if not already present and inform users on how to > register > > also, fixed Atlas integration changes with classname and packagename > > > Diffs > - > > ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c > ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py > d09bd77 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py > dd1cda0 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py > ebe3634 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 8d5cdc9 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > f8ba3e9 > ambari-server/src/test/python/TestAmbariServer.py 279a172 > ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py > 2dd0da9 > > Diff: https://reviews.apache.org/r/50595/diff/ > > > Testing > --- > > Tested downloading of the jar file by registering with ambari server > Tested Falcon/Atlas component names > > > Thanks, > > Venkat Ranganathan > >
Re: Review Request 51154: AMBARI-18169: Falcon log4j configuration should be configurable via Ambari
> On Aug. 16, 2016, 3:09 p.m., Sumit Mohanty wrote: > > Can you add it to > > https://github.com/apache/ambari/blob/trunk/ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/metainfo.xml#L120-L127 Thanks Sumit. Fixed the metainfo.xml to include the configuration file - Venkat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51154/#review145917 --- On Aug. 16, 2016, 4:19 p.m., Venkat Ranganathan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51154/ > --- > > (Updated Aug. 16, 2016, 4:19 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. > > > Bugs: AMBARI-18169 > https://issues.apache.org/jira/browse/AMBARI-18169 > > > Repository: ambari > > > Description > --- > > We should have falcon log4j.xml configurable via ambari > > > Diffs > - > > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/metainfo.xml > 0c49209 > > Diff: https://reviews.apache.org/r/51154/diff/ > > > Testing > --- > > Ran all unit tests and passed > > > -- > Ran 267 tests in 6.637s > > OK > -- > Total run:1120 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Venkat Ranganathan > >
Re: Review Request 51154: AMBARI-18169: Falcon log4j configuration should be configurable via Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51154/ --- (Updated Aug. 16, 2016, 4:19 p.m.) Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Changes --- Fixed review comments. Tested in a ambari installed cluster that new Falcon service installation allows log4j.xml to be configurable via Ambari Bugs: AMBARI-18169 https://issues.apache.org/jira/browse/AMBARI-18169 Repository: ambari Description --- We should have falcon log4j.xml configurable via ambari Diffs (updated) - ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml PRE-CREATION ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/metainfo.xml 0c49209 Diff: https://reviews.apache.org/r/51154/diff/ Testing --- Ran all unit tests and passed -- Ran 267 tests in 6.637s OK -- Total run:1120 Total errors:0 Total failures:0 OK Thanks, Venkat Ranganathan
Review Request 51154: AMBARI-18169: Falcon log4j configuration should be configurable via Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51154/ --- Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. Bugs: AMBARI-18169 https://issues.apache.org/jira/browse/AMBARI-18169 Repository: ambari Description --- We should have falcon log4j.xml configurable via ambari Diffs - ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-log4j.xml PRE-CREATION Diff: https://reviews.apache.org/r/51154/diff/ Testing --- Ran all unit tests and passed -- Ran 267 tests in 6.637s OK -- Total run:1120 Total errors:0 Total failures:0 OK Thanks, Venkat Ranganathan
Re: Review Request 51121: [PREVIEW] Oozie Hive actions fail when Atlas is installed since Atlas Hive Hooks need to be copied to Oozie Share Lib in HDFS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51121/#review145896 --- ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py (line 378) <https://reviews.apache.org/r/51121/#comment212258> we need to kinit if needed here - Venkat Ranganathan On Aug. 15, 2016, 5:40 p.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51121/ > --- > > (Updated Aug. 15, 2016, 5:40 p.m.) > > > Review request for Ambari, Sumit Mohanty and Venkat Ranganathan. > > > Bugs: AMBARI-18151 > https://issues.apache.org/jira/browse/AMBARI-18151 > > > Repository: ambari > > > Description > --- > > Whenever Oozie submits Hive actions, they fail and the application logs show > "Internal Error: > java.lang.ClassNotFoundException(org.apache.atlas.hive.hook.HiveHook" > > This is because whenever Atlas is installed, the Hive Hook (which is > installed via the Oozie RPM too, in /usr/$stack/$version/atlas/hook/hive/) > needs to be copied to the Oozie Share lib in HDFS (e.g., > hdfs:///user/oozie/share/lib/lib_$timestamp/hive) > > Further, need to save atlas-application.properties used for Hive in > /etc/oozie/conf/action-conf/hive > > Lastly, remove the atlas.rest.address property from hive-site.xml > > > Diffs > - > > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py > dd3a692 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py > e330cb5 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py > db048bb > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/configuration/hive-site.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/51121/diff/ > > > Testing > --- > > Verified on a live cluster with HDP 2.5 and Oozie, Hive, Atlas > > Python unit tests passed, > > OK > -- > Total run:1034 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > >
Re: Review Request 51121: [PREVIEW] Oozie Hive actions fail when Atlas is installed since Atlas Hive Hooks need to be copied to Oozie Share Lib in HDFS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51121/#review145894 --- ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py (line 313) <https://reviews.apache.org/r/51121/#comment212256> Currently we don't support propeties file for action config files. This needs to go to sharelib also - Venkat Ranganathan On Aug. 15, 2016, 5:40 p.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51121/ > --- > > (Updated Aug. 15, 2016, 5:40 p.m.) > > > Review request for Ambari, Sumit Mohanty and Venkat Ranganathan. > > > Bugs: AMBARI-18151 > https://issues.apache.org/jira/browse/AMBARI-18151 > > > Repository: ambari > > > Description > --- > > Whenever Oozie submits Hive actions, they fail and the application logs show > "Internal Error: > java.lang.ClassNotFoundException(org.apache.atlas.hive.hook.HiveHook" > > This is because whenever Atlas is installed, the Hive Hook (which is > installed via the Oozie RPM too, in /usr/$stack/$version/atlas/hook/hive/) > needs to be copied to the Oozie Share lib in HDFS (e.g., > hdfs:///user/oozie/share/lib/lib_$timestamp/hive) > > Further, need to save atlas-application.properties used for Hive in > /etc/oozie/conf/action-conf/hive > > Lastly, remove the atlas.rest.address property from hive-site.xml > > > Diffs > - > > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py > dd3a692 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py > e330cb5 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py > db048bb > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/configuration/hive-site.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/51121/diff/ > > > Testing > --- > > Verified on a live cluster with HDP 2.5 and Oozie, Hive, Atlas > > Python unit tests passed, > > OK > -- > Total run:1034 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > >
Re: Review Request 51121: [PREVIEW] Oozie Hive actions fail when Atlas is installed since Atlas Hive Hooks need to be copied to Oozie Share Lib in HDFS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51121/#review145893 --- ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py (line 410) <https://reviews.apache.org/r/51121/#comment212255> We should do this before Oozie is started or you should run the following command oozie admin -oozie -sharelibupdate - Venkat Ranganathan On Aug. 15, 2016, 5:40 p.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51121/ > --- > > (Updated Aug. 15, 2016, 5:40 p.m.) > > > Review request for Ambari, Sumit Mohanty and Venkat Ranganathan. > > > Bugs: AMBARI-18151 > https://issues.apache.org/jira/browse/AMBARI-18151 > > > Repository: ambari > > > Description > --- > > Whenever Oozie submits Hive actions, they fail and the application logs show > "Internal Error: > java.lang.ClassNotFoundException(org.apache.atlas.hive.hook.HiveHook" > > This is because whenever Atlas is installed, the Hive Hook (which is > installed via the Oozie RPM too, in /usr/$stack/$version/atlas/hook/hive/) > needs to be copied to the Oozie Share lib in HDFS (e.g., > hdfs:///user/oozie/share/lib/lib_$timestamp/hive) > > Further, need to save atlas-application.properties used for Hive in > /etc/oozie/conf/action-conf/hive > > Lastly, remove the atlas.rest.address property from hive-site.xml > > > Diffs > - > > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py > dd3a692 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py > e330cb5 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py > db048bb > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/configuration/hive-site.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/51121/diff/ > > > Testing > --- > > Verified on a live cluster with HDP 2.5 and Oozie, Hive, Atlas > > Python unit tests passed, > > OK > -- > Total run:1034 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > >
Re: Review Request 51121: [PREVIEW] Oozie Hive actions fail when Atlas is installed since Atlas Hive Hooks need to be copied to Oozie Share Lib in HDFS
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51121/#review145866 --- ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/configuration/hive-site.xml (line 24) <https://reviews.apache.org/r/51121/#comment212231> Why do we need this file? - Venkat Ranganathan On Aug. 15, 2016, 5:40 p.m., Alejandro Fernandez wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51121/ > --- > > (Updated Aug. 15, 2016, 5:40 p.m.) > > > Review request for Ambari, Sumit Mohanty and Venkat Ranganathan. > > > Bugs: AMBARI-18151 > https://issues.apache.org/jira/browse/AMBARI-18151 > > > Repository: ambari > > > Description > --- > > Whenever Oozie submits Hive actions, they fail and the application logs show > "Internal Error: > java.lang.ClassNotFoundException(org.apache.atlas.hive.hook.HiveHook" > > This is because whenever Atlas is installed, the Hive Hook (which is > installed via the Oozie RPM too, in /usr/$stack/$version/atlas/hook/hive/) > needs to be copied to the Oozie Share lib in HDFS (e.g., > hdfs:///user/oozie/share/lib/lib_$timestamp/hive) > > Further, need to save atlas-application.properties used for Hive in > /etc/oozie/conf/action-conf/hive > > Lastly, remove the atlas.rest.address property from hive-site.xml > > > Diffs > - > > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie.py > dd3a692 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/oozie_service.py > e330cb5 > > ambari-server/src/main/resources/common-services/OOZIE/4.0.0.2.0/package/scripts/params_linux.py > db048bb > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HDFS/configuration/hive-site.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/51121/diff/ > > > Testing > --- > > Verified on a live cluster with HDP 2.5 and Oozie, Hive, Atlas > > Python unit tests passed, > > OK > -- > Total run:1034 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > >
Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install
> On Aug. 2, 2016, 1:58 a.m., Vitalyi Brodetskyi wrote: > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py, > > lines 200-217 > > <https://reviews.apache.org/r/50595/diff/7/?file=1459372#file1459372line200> > > > > I don't see here any condition, is it default db for falcon and user > > always should registrate/use jdbc for it? > > Vitalyi Brodetskyi wrote: > And one more, as i remember we set some special permissions for jdbc > which was downloaded because later you could have troubles with customized > users/permissions/non root user. Yes. This is only one and it is really not a JDBC driver. We just use the download mechanism - Venkat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50595/#review144468 ------- On Aug. 1, 2016, 2:21 p.m., Venkat Ranganathan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50595/ > --- > > (Updated Aug. 1, 2016, 2:21 p.m.) > > > Review request for Ambari and Alejandro Fernandez. > > > Bugs: AMBARI-17955 > https://issues.apache.org/jira/browse/AMBARI-17955 > > > Repository: ambari > > > Description > --- > > Enabled the registration of optionally downloaded berkeley db jar file. > Introduce Berekley DB as a jdbc-db (even though it is actually not. > Download je-5.0.73.jar if not already present and inform users on how to > register > > also, fixed Atlas integration changes with classname and packagename > > > Diffs > - > > ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c > ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py > d09bd77 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py > dd1cda0 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py > ebe3634 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 8d5cdc9 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > f8ba3e9 > ambari-server/src/test/python/TestAmbariServer.py 279a172 > ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py > 2dd0da9 > > Diff: https://reviews.apache.org/r/50595/diff/ > > > Testing > --- > > Tested downloading of the jar file by registering with ambari server > Tested Falcon/Atlas component names > > > Thanks, > > Venkat Ranganathan > >
Re: Review Request 50691: AMBARI-17213: Worfklow designer initial contrib view
/transition-config-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/version-settings-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-action-editor-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-actions-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-credentials-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-designer-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-job-details-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-node-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-parameters-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-sla-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/test-helper.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/.gitkeep PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/controllers/dashboard-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/controllers/design-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/controllers/job-details-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/helpers/date-helper-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/initializers/init-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/models/jobs-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/routes/connection-error-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/routes/dashboard-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/routes/design-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/routes/job-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/file-browser-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/history-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/property-extractor-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/view.xml PRE-CREATION pom.xml 1af9e85 Diff: https://reviews.apache.org/r/50691/diff/ Testing --- All editors were tested and validated with a Oozie server Thanks, Venkat Ranganathan
Review Request 50691: AMBARI-17213: Worfklow designer initial contrib view
/integration/components/version-settings-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-action-editor-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-actions-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-credentials-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-designer-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-job-details-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-node-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-parameters-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/integration/components/workflow-sla-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/test-helper.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/.gitkeep PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/controllers/dashboard-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/controllers/design-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/controllers/job-details-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/helpers/date-helper-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/initializers/init-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/models/jobs-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/routes/connection-error-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/routes/dashboard-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/routes/design-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/routes/job-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/file-browser-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/history-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/ui/tests/unit/services/property-extractor-test.js PRE-CREATION contrib/views/wfmanager/src/main/resources/view.xml PRE-CREATION Diff: https://reviews.apache.org/r/50691/diff/ Testing --- All editors were tested and validated with a Oozie server Thanks, Venkat Ranganathan
Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50595/ --- (Updated Aug. 1, 2016, 2:21 p.m.) Review request for Ambari and Alejandro Fernandez. Changes --- Fixed another UT failure in ambariserver Bugs: AMBARI-17955 https://issues.apache.org/jira/browse/AMBARI-17955 Repository: ambari Description --- Enabled the registration of optionally downloaded berkeley db jar file. Introduce Berekley DB as a jdbc-db (even though it is actually not. Download je-5.0.73.jar if not already present and inform users on how to register also, fixed Atlas integration changes with classname and packagename Diffs (updated) - ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py d09bd77 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py dd1cda0 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py ebe3634 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 8d5cdc9 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py f8ba3e9 ambari-server/src/test/python/TestAmbariServer.py 279a172 ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 2dd0da9 Diff: https://reviews.apache.org/r/50595/diff/ Testing --- Tested downloading of the jar file by registering with ambari server Tested Falcon/Atlas component names Thanks, Venkat Ranganathan
Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50595/ --- (Updated Aug. 1, 2016, 11:38 a.m.) Review request for Ambari and Alejandro Fernandez. Changes --- Fixed a trailing blank Bugs: AMBARI-17955 https://issues.apache.org/jira/browse/AMBARI-17955 Repository: ambari Description --- Enabled the registration of optionally downloaded berkeley db jar file. Introduce Berekley DB as a jdbc-db (even though it is actually not. Download je-5.0.73.jar if not already present and inform users on how to register also, fixed Atlas integration changes with classname and packagename Diffs (updated) - ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py d09bd77 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py dd1cda0 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py ebe3634 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 8d5cdc9 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py f8ba3e9 ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 2dd0da9 Diff: https://reviews.apache.org/r/50595/diff/ Testing --- Tested downloading of the jar file by registering with ambari server Tested Falcon/Atlas component names Thanks, Venkat Ranganathan
Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50595/ --- (Updated Aug. 1, 2016, 11:35 a.m.) Review request for Ambari and Alejandro Fernandez. Changes --- Fixed UT Bugs: AMBARI-17955 https://issues.apache.org/jira/browse/AMBARI-17955 Repository: ambari Description --- Enabled the registration of optionally downloaded berkeley db jar file. Introduce Berekley DB as a jdbc-db (even though it is actually not. Download je-5.0.73.jar if not already present and inform users on how to register also, fixed Atlas integration changes with classname and packagename Diffs (updated) - ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py d09bd77 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py dd1cda0 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py ebe3634 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 8d5cdc9 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py f8ba3e9 ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 2dd0da9 Diff: https://reviews.apache.org/r/50595/diff/ Testing --- Tested downloading of the jar file by registering with ambari server Tested Falcon/Atlas component names Thanks, Venkat Ranganathan
Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install
> On July 31, 2016, 4:34 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py, line > > 1131 > > <https://reviews.apache.org/r/50595/diff/3/?file=1458154#file1458154line1131> > > > > We should remove the version from the jar name This is the only version supported - like what we have for sqljdbc4 - Venkat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50595/#review144291 --- On Aug. 1, 2016, 10:38 a.m., Venkat Ranganathan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50595/ > --- > > (Updated Aug. 1, 2016, 10:38 a.m.) > > > Review request for Ambari and Alejandro Fernandez. > > > Bugs: AMBARI-17955 > https://issues.apache.org/jira/browse/AMBARI-17955 > > > Repository: ambari > > > Description > --- > > Enabled the registration of optionally downloaded berkeley db jar file. > Introduce Berekley DB as a jdbc-db (even though it is actually not. > Download je-5.0.73.jar if not already present and inform users on how to > register > > also, fixed Atlas integration changes with classname and packagename > > > Diffs > - > > ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c > ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py > d09bd77 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py > dd1cda0 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py > ebe3634 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 8d5cdc9 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > f8ba3e9 > > Diff: https://reviews.apache.org/r/50595/diff/ > > > Testing > --- > > Tested downloading of the jar file by registering with ambari server > Tested Falcon/Atlas component names > > > Thanks, > > Venkat Ranganathan > >
Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50595/ --- (Updated Aug. 1, 2016, 10:38 a.m.) Review request for Ambari and Alejandro Fernandez. Changes --- Fixed review comments Bugs: AMBARI-17955 https://issues.apache.org/jira/browse/AMBARI-17955 Repository: ambari Description --- Enabled the registration of optionally downloaded berkeley db jar file. Introduce Berekley DB as a jdbc-db (even though it is actually not. Download je-5.0.73.jar if not already present and inform users on how to register also, fixed Atlas integration changes with classname and packagename Diffs (updated) - ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py d09bd77 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py dd1cda0 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py ebe3634 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 8d5cdc9 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py f8ba3e9 Diff: https://reviews.apache.org/r/50595/diff/ Testing --- Tested downloading of the jar file by registering with ambari server Tested Falcon/Atlas component names Thanks, Venkat Ranganathan
Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50595/ --- (Updated July 29, 2016, 1:14 p.m.) Review request for Ambari and Alejandro Fernandez. Changes --- Fixed tailing space and fixed HBase name Bugs: AMBARI-17955 https://issues.apache.org/jira/browse/AMBARI-17955 Repository: ambari Description --- Enabled the registration of optionally downloaded berkeley db jar file. Introduce Berekley DB as a jdbc-db (even though it is actually not. Download je-5.0.73.jar if not already present and inform users on how to register also, fixed Atlas integration changes with classname and packagename Diffs (updated) - ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py d09bd77 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py dd1cda0 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py ebe3634 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 8d5cdc9 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py f8ba3e9 Diff: https://reviews.apache.org/r/50595/diff/ Testing --- Tested downloading of the jar file by registering with ambari server Tested Falcon/Atlas component names Thanks, Venkat Ranganathan
Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install
> On July 29, 2016, 10:54 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py, line > > 1132 > > <https://reviews.apache.org/r/50595/diff/1/?file=1457506#file1457506line1132> > > > > What happens if the version changes? The version cannot change as that is the only version we can support - but I don't think this symlink is even needed - so can drop it > On July 29, 2016, 10:54 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py, line > > 1143 > > <https://reviews.apache.org/r/50595/diff/1/?file=1457506#file1457506line1143> > > > > Why is there a version number in this jar name? Will remove 5.0* but the only version we support is that. > On July 29, 2016, 10:54 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py, > > line 203 > > <https://reviews.apache.org/r/50595/diff/1/?file=1457507#file1457507line203> > > > > If there are any exceptions, please log it. Since we log exceptions in DonwloadSource did not do it. But it does not hurt to add it here also. will add > On July 29, 2016, 10:54 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py, > > line 211 > > <https://reviews.apache.org/r/50595/diff/1/?file=1457507#file1457507line211> > > > > Typo. will fix. thanks - Venkat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50595/#review144139 --- On July 29, 2016, 11:56 a.m., Venkat Ranganathan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50595/ > --- > > (Updated July 29, 2016, 11:56 a.m.) > > > Review request for Ambari and Alejandro Fernandez. > > > Bugs: AMBARI-17955 > https://issues.apache.org/jira/browse/AMBARI-17955 > > > Repository: ambari > > > Description > --- > > Enabled the registration of optionally downloaded berkeley db jar file. > Introduce Berekley DB as a jdbc-db (even though it is actually not. > Download je-5.0.73.jar if not already present and inform users on how to > register > > also, fixed Atlas integration changes with classname and packagename > > > Diffs > - > > ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c > ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py > d09bd77 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py > dd1cda0 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py > ebe3634 > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 8d5cdc9 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > f8ba3e9 > > Diff: https://reviews.apache.org/r/50595/diff/ > > > Testing > --- > > Tested downloading of the jar file by registering with ambari server > Tested Falcon/Atlas component names > > > Thanks, > > Venkat Ranganathan > >
Re: Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50595/ --- (Updated July 29, 2016, 11:56 a.m.) Review request for Ambari and Alejandro Fernandez. Changes --- Addressed review comments Bugs: AMBARI-17955 https://issues.apache.org/jira/browse/AMBARI-17955 Repository: ambari Description --- Enabled the registration of optionally downloaded berkeley db jar file. Introduce Berekley DB as a jdbc-db (even though it is actually not. Download je-5.0.73.jar if not already present and inform users on how to register also, fixed Atlas integration changes with classname and packagename Diffs (updated) - ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py d09bd77 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py dd1cda0 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py ebe3634 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 8d5cdc9 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py f8ba3e9 Diff: https://reviews.apache.org/r/50595/diff/ Testing --- Tested downloading of the jar file by registering with ambari server Tested Falcon/Atlas component names Thanks, Venkat Ranganathan
Review Request 50595: AMBARI-17955: Enabled download of berkeley DB jar file to be provisioned during install
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50595/ --- Review request for Ambari and Alejandro Fernandez. Bugs: AMBARI-17955 https://issues.apache.org/jira/browse/AMBARI-17955 Repository: ambari Description --- Enabled the registration of optionally downloaded berkeley db jar file. Introduce Berekley DB as a jdbc-db (even though it is actually not. Download je-5.0.73.jar if not already present and inform users on how to register also, fixed Atlas integration changes with classname and packagename Diffs - ambari-server/src/main/python/ambari_server/dbConfiguration.py fc68a4c ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py d09bd77 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py dd1cda0 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py ebe3634 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 8d5cdc9 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py f8ba3e9 Diff: https://reviews.apache.org/r/50595/diff/ Testing --- Tested downloading of the jar file by registering with ambari server Tested Falcon/Atlas component names Thanks, Venkat Ranganathan
Re: Review Request 50431: AMBARI-17896: Fix falcon hook classname and classpath for atlas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50431/ --- (Updated July 26, 2016, 6:07 p.m.) Review request for Ambari and Alejandro Fernandez. Changes --- Sorry - posted the patch without saving the files from the editor Bugs: AMBARI-17896 https://issues.apache.org/jira/browse/AMBARI-17896 Repository: ambari Description --- Fixed stack advisor for 2.5 and also the param_linux for setting the right conf path Diffs (updated) - ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py ebe3634 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 8d5cdc9 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py f8ba3e9 Diff: https://reviews.apache.org/r/50431/diff/ Testing --- Thanks, Venkat Ranganathan
Re: Review Request 50431: AMBARI-17896: Fix falcon hook classname and classpath for atlas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50431/ --- (Updated July 26, 2016, 1:05 p.m.) Review request for Ambari and Alejandro Fernandez. Changes --- Update with Review comments fixed Bugs: AMBARI-17896 https://issues.apache.org/jira/browse/AMBARI-17896 Repository: ambari Description --- Fixed stack advisor for 2.5 and also the param_linux for setting the right conf path Diffs (updated) - ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py ebe3634 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 8d5cdc9 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py f8ba3e9 Diff: https://reviews.apache.org/r/50431/diff/ Testing --- Thanks, Venkat Ranganathan
Re: Review Request 50431: AMBARI-17896: Fix falcon hook classname and classpath for atlas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50431/ --- (Updated July 25, 2016, 10:12 p.m.) Review request for Ambari and Alejandro Fernandez. Changes --- Modified patch to not duplicate code for falcon advisor Bugs: AMBARI-17896 https://issues.apache.org/jira/browse/AMBARI-17896 Repository: ambari Description --- Fixed stack advisor for 2.5 and also the param_linux for setting the right conf path Diffs (updated) - ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py ebe3634 ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py 8d5cdc9 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py f8ba3e9 Diff: https://reviews.apache.org/r/50431/diff/ Testing --- Thanks, Venkat Ranganathan
Review Request 50431: AMBARI-17896: Fix falcon hook classname and classpath for atlas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50431/ --- Review request for Ambari and Alejandro Fernandez. Bugs: AMBARI-17896 https://issues.apache.org/jira/browse/AMBARI-17896 Repository: ambari Description --- Fixed stack advisor for 2.5 and also the param_linux for setting the right conf path Diffs - ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py ebe3634 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 315020b Diff: https://reviews.apache.org/r/50431/diff/ Testing --- Thanks, Venkat Ranganathan
Re: Review Request 50287: AMBARI-17830 StackAdvisor fix for altas recommendation for stack 2.3
> On July 21, 2016, 8:56 a.m., Venkat Ranganathan wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py, > > line 331 > > <https://reviews.apache.org/r/50287/diff/1/?file=1449672#file1449672line331> > > > > Do we need this. Isn't OOZIE added in HDP21StackAdvisor whose > > dictionary is merged in succeeding child classes? I see that you are adding to child configuration. I fixed the oozie recommender config. Sorry about that. Ranger does not need to send Oozie config. - Venkat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50287/#review143089 --- On July 21, 2016, 3:19 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50287/ > --- > > (Updated July 21, 2016, 3:19 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, > Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-17830 > https://issues.apache.org/jira/browse/AMBARI-17830 > > > Repository: ambari > > > Description > --- > > Caused by: > org.apache.ambari.server.api.services.stackadvisor.StackAdvisorException: > Stack Advisor reported an error: KeyError: 'atlas.server.https.port' > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 19753e5 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 5e380d8 > > Diff: https://reviews.apache.org/r/50287/diff/ > > > Testing > --- > > Tested Atlas installation > > > Thanks, > > Mugdha Varadkar > >
Review Request 50309: AMBARI-17823: Increase default interval between retries for oozie actions
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50309/ --- Review request for Ambari and Alejandro Fernandez. Bugs: AMBARI-17823 https://issues.apache.org/jira/browse/AMBARI-17823 Repository: ambari Description --- Increaes the default retry interval to 30 Diffs - ambari-server/src/main/resources/stacks/HDP/2.5/services/OOZIE/configuration/oozie-site.xml PRE-CREATION Diff: https://reviews.apache.org/r/50309/diff/ Testing --- Validated the config Thanks, Venkat Ranganathan
Re: Review Request 50256: AMBARI-17798: RU/EU: Add falcon to as oozie admin user for 2.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50256/ --- (Updated July 21, 2016, 1:29 p.m.) Review request for Ambari and Alejandro Fernandez. Changes --- Removed unneded file. Also fixed the base stack advisor to have logger statements instead of prints and cleaned up a bit Bugs: AMBARI-17798 https://issues.apache.org/jira/browse/AMBARI-17798 Repository: ambari Description --- Support for fixing oozie admin user for Falcon when doing upgrades Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsers.java PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml 7be5a19 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 7f277fb ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml 2daa9b8 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 43c6265 ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 315020b ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsersTest.java PRE-CREATION Diff: https://reviews.apache.org/r/50256/diff/ Testing --- Added UT and successfully executed it Thanks, Venkat Ranganathan
Re: Review Request 50287: AMBARI-17830 StackAdvisor fix for altas recommendation for stack 2.3
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50287/#review143089 --- ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 331) <https://reviews.apache.org/r/50287/#comment208799> Do we need this. Isn't OOZIE added in HDP21StackAdvisor whose dictionary is merged in succeeding child classes? - Venkat Ranganathan On July 21, 2016, 3:19 a.m., Mugdha Varadkar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50287/ > --- > > (Updated July 21, 2016, 3:19 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jayush Luniya, > Srimanth Gunturi, and Velmurugan Periasamy. > > > Bugs: AMBARI-17830 > https://issues.apache.org/jira/browse/AMBARI-17830 > > > Repository: ambari > > > Description > --- > > Caused by: > org.apache.ambari.server.api.services.stackadvisor.StackAdvisorException: > Stack Advisor reported an error: KeyError: 'atlas.server.https.port' > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.3/services/stack_advisor.py > 19753e5 > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 5e380d8 > > Diff: https://reviews.apache.org/r/50287/diff/ > > > Testing > --- > > Tested Atlas installation > > > Thanks, > > Mugdha Varadkar > >
Re: Review Request 50256: AMBARI-17798: RU/EU: Add falcon to as oozie admin user for 2.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50256/ --- (Updated July 20, 2016, 11:46 a.m.) Review request for Ambari and Alejandro Fernandez. Changes --- Fixed the index check Bugs: AMBARI-17798 https://issues.apache.org/jira/browse/AMBARI-17798 Repository: ambari Description --- Support for fixing oozie admin user for Falcon when doing upgrades Diffs (updated) - ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsers.java PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml a7383a2 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 85ffb8c ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml 00dbaa7 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 78d22ab ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 68e8fc2 ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsersTest.java PRE-CREATION Diff: https://reviews.apache.org/r/50256/diff/ Testing --- Added UT and successfully executed it Thanks, Venkat Ranganathan
Review Request 50256: AMBARI-17798: RU/EU: Add falcon to as oozie admin user for 2.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50256/ --- Review request for Ambari and Alejandro Fernandez. Bugs: AMBARI-17798 https://issues.apache.org/jira/browse/AMBARI-17798 Repository: ambari Description --- Support for fixing oozie admin user for Falcon when doing upgrades Diffs - ambari-server/src/main/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsers.java PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml a7383a2 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml 85ffb8c ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml 00dbaa7 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.4.xml 78d22ab ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml 68e8fc2 ambari-server/src/test/java/org/apache/ambari/server/serveraction/upgrades/FixOozieAdminUsersTest.java PRE-CREATION Diff: https://reviews.apache.org/r/50256/diff/ Testing --- Added UT and successfully executed it Thanks, Venkat Ranganathan
Re: Review Request 50178: AMBARI-17783: Add falcon to as oozie admin user for 2.5
> On July 19, 2016, 11:01 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py, > > line 35 > > <https://reviews.apache.org/r/50178/diff/1/?file=1447035#file1447035line35> > > > > This will affect only a brand new cluster install. > > For a stack upgrade to HDP 2.5, do we need to make a similar change? Yes, we need to take care of RU/EU. But we will either have to hardcode the values in upgrade configs or do custom code. Will create a new bug to track this - Venkat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50178/#review142779 ------- On July 18, 2016, 7:03 p.m., Venkat Ranganathan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50178/ > --- > > (Updated July 18, 2016, 7:03 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Swapan Shridhar. > > > Bugs: AMBARI-17783 > https://issues.apache.org/jira/browse/AMBARI-17783 > > > Repository: ambari > > > Description > --- > > When Falcon is installed witn Oozie in HDP2.5, make falcon an admin user in > Oozie > > > Diffs > - > > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 0e455e9 > > Diff: https://reviews.apache.org/r/50178/diff/ > > > Testing > --- > > Implemented the changes in stack_advisor and ran a test to make sure the > configuration changes for admin user is forced > > > Thanks, > > Venkat Ranganathan > >
Review Request 50178: AMBARI-17783: Add falcon to as oozie admin user for 2.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50178/ --- Review request for Ambari, Alejandro Fernandez and Swapan Shridhar. Bugs: AMBARI-17783 https://issues.apache.org/jira/browse/AMBARI-17783 Repository: ambari Description --- When Falcon is installed witn Oozie in HDP2.5, make falcon an admin user in Oozie Diffs - ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 0e455e9 Diff: https://reviews.apache.org/r/50178/diff/ Testing --- Implemented the changes in stack_advisor and ran a test to make sure the configuration changes for admin user is forced Thanks, Venkat Ranganathan
Re: Review Request 49222: AMBARI-17436: Additional Ambari change for Falcon
> On June 25, 2016, 8:03 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py, > > line 149 > > <https://reviews.apache.org/r/49222/diff/1/?file=1430088#file1430088line149> > > > > Is falcon now creating this folder? We no longer use /apps/data-mirroring. Instead we use /mirroring as the directory - Venkat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49222/#review139471 --- On June 24, 2016, 6:27 p.m., Venkat Ranganathan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49222/ > --- > > (Updated June 24, 2016, 6:27 p.m.) > > > Review request for Ambari and Alejandro Fernandez. > > > Bugs: AMBARI-17436 > https://issues.apache.org/jira/browse/AMBARI-17436 > > > Repository: ambari > > > Description > --- > > Description > Add one new property to oozie-site.xml > change permissions for the extension folders > change the hive location from /apps/data-mirroring to > extensions-dir/mirroring/ > > > Diffs > - > > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py > 6cb4089 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/configuration/oozie-site.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/49222/diff/ > > > Testing > --- > > > Thanks, > > Venkat Ranganathan > >
Review Request 49222: AMBARI-17436: Additional Ambari change for Falcon
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49222/ --- Review request for Ambari and Alejandro Fernandez. Bugs: AMBARI-17436 https://issues.apache.org/jira/browse/AMBARI-17436 Repository: ambari Description --- Description Add one new property to oozie-site.xml change permissions for the extension folders change the hive location from /apps/data-mirroring to extensions-dir/mirroring/ Diffs - ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py 6cb4089 ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/configuration/oozie-site.xml PRE-CREATION Diff: https://reviews.apache.org/r/49222/diff/ Testing --- Thanks, Venkat Ranganathan
Re: Review Request 48609: AMBARI-17183: client.properties for Falcon should be configurable via Ambari
> On June 23, 2016, 9:24 a.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/package/scripts/falcon.py, > > line 42 > > <https://reviews.apache.org/r/48609/diff/3/?file=1428478#file1428478line42> > > > > Is this spaces or tabs? It is spaces only - no tabs - Venkat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48609/#review139267 --- On June 23, 2016, 12:05 a.m., Venkat Ranganathan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48609/ > --- > > (Updated June 23, 2016, 12:05 a.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-17183 > https://issues.apache.org/jira/browse/AMBARI-17183 > > > Repository: ambari > > > Description > --- > > Currently falcon-client.properties is generated without functionality for > user changes. We should fix it for users of mirroring etc > > > Diffs > - > > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py > b5b3a34 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py > 22fb691 > > ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/package/scripts/falcon.py > 9a72af1 > ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_client.py > fbf624a > ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py > 68dc7c9 > ambari-server/src/test/python/stacks/2.1/configs/default.json a6bcc24 > ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json > 7499cdf > > Diff: https://reviews.apache.org/r/48609/diff/ > > > Testing > --- > > UT passes > > > Thanks, > > Venkat Ranganathan > >
Re: Review Request 48609: AMBARI-17183: client.properties for Falcon should be configurable via Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48609/ --- (Updated June 23, 2016, 12:05 a.m.) Review request for Ambari. Changes --- Fixed UT failures with input/help from Alejandro Bugs: AMBARI-17183 https://issues.apache.org/jira/browse/AMBARI-17183 Repository: ambari Description --- Currently falcon-client.properties is generated without functionality for user changes. We should fix it for users of mirroring etc Diffs (updated) - ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py b5b3a34 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 22fb691 ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/package/scripts/falcon.py 9a72af1 ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_client.py fbf624a ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 68dc7c9 ambari-server/src/test/python/stacks/2.1/configs/default.json a6bcc24 ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json 7499cdf Diff: https://reviews.apache.org/r/48609/diff/ Testing (updated) --- UT passes Thanks, Venkat Ranganathan
Re: Review Request 48609: AMBARI-17183: client.properties for Falcon should be configurable via Ambari
> On June 13, 2016, 1:54 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.3/services/FALCON/configuration/falcon-client.properties.xml, > > line 28 > > <https://reviews.apache.org/r/48609/diff/1/?file=1416508#file1416508line28> > > > > Based on the latest code, we no longer need > > > > I believe you want, > > and take any other defaults. Thanks Fixed - Venkat --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48609/#review137377 ----------- On June 15, 2016, 10:51 a.m., Venkat Ranganathan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/48609/ > --- > > (Updated June 15, 2016, 10:51 a.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-17183 > https://issues.apache.org/jira/browse/AMBARI-17183 > > > Repository: ambari > > > Description > --- > > Currently falcon-client.properties is generated without functionality for > user changes. We should fix it for users of mirroring etc > > > Diffs > - > > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py > b5b3a34 > > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py > 22fb691 > > ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/package/scripts/falcon.py > 9a72af1 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/FALCON/configuration/falcon-client.properties.xml > PRE-CREATION > > Diff: https://reviews.apache.org/r/48609/diff/ > > > Testing > --- > > > Thanks, > > Venkat Ranganathan > >
Re: Review Request 48609: AMBARI-17183: client.properties for Falcon should be configurable via Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48609/ --- (Updated June 15, 2016, 10:51 a.m.) Review request for Ambari. Changes --- Updated patch with suggestions Bugs: AMBARI-17183 https://issues.apache.org/jira/browse/AMBARI-17183 Repository: ambari Description --- Currently falcon-client.properties is generated without functionality for user changes. We should fix it for users of mirroring etc Diffs (updated) - ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py b5b3a34 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 22fb691 ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/package/scripts/falcon.py 9a72af1 ambari-server/src/main/resources/stacks/HDP/2.3/services/FALCON/configuration/falcon-client.properties.xml PRE-CREATION Diff: https://reviews.apache.org/r/48609/diff/ Testing --- Thanks, Venkat Ranganathan
Review Request 48609: AMBARI-17183: client.properties for Falcon should be configurable via Ambari
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48609/ --- Review request for Ambari. Bugs: AMBARI-17183 https://issues.apache.org/jira/browse/AMBARI-17183 Repository: ambari Description --- Currently falcon-client.properties is generated without functionality for user changes. We should fix it for users of mirroring etc Diffs - ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py 5e25325 ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 8c2ad8e ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/package/scripts/falcon.py 9a72af1 ambari-server/src/main/resources/stacks/HDP/2.3/services/FALCON/configuration/falcon-client.properties.xml PRE-CREATION Diff: https://reviews.apache.org/r/48609/diff/ Testing --- Thanks, Venkat Ranganathan
Re: Review Request 48355: AMBARI-17051: Falcon startup properties changes for 2.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48355/ --- (Updated June 7, 2016, 2:43 p.m.) Review request for Ambari and Alejandro Fernandez. Changes --- Fixed startup properties, param_linux to refer to the startup property value for the extensions path and fix the right files for upgrades Bugs: AMBARI-17051 https://issues.apache.org/jira/browse/AMBARI-17051 Repository: ambari Description --- Added the startup.properties changes required for Lifecycle policies and extension support Diffs (updated) - ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py 22fb691 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml c72070b ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.5.xml 0a1bb40 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.5.xml a3a3c7d ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 60cac05 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/nonrolling-upgrade-2.5.xml 0f3bff4 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/upgrade-2.5.xml cadb3c7 ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/configuration/falcon-startup.properties.xml 0f542cc Diff: https://reviews.apache.org/r/48355/diff/ Testing --- Made sure the startup properties changes are valid manually Thanks, Venkat Ranganathan
Re: Review Request 48355: AMBARI-17051: Falcon startup properties changes for 2.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48355/ --- (Updated June 7, 2016, 2:13 p.m.) Review request for Ambari and Alejandro Fernandez. Changes --- Fixed typo in property name for services config Bugs: AMBARI-17051 https://issues.apache.org/jira/browse/AMBARI-17051 Repository: ambari Description --- Added the startup.properties changes required for Lifecycle policies and extension support Diffs (updated) - ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml c72070b ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 111b432 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 9365646 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 712241b ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 4187d64 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 60cac05 ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/configuration/falcon-startup.properties.xml 0f542cc Diff: https://reviews.apache.org/r/48355/diff/ Testing --- Made sure the startup properties changes are valid manually Thanks, Venkat Ranganathan
Re: Review Request 48355: AMBARI-17051: Falcon startup properties changes for 2.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48355/ --- (Updated June 7, 2016, 2 p.m.) Review request for Ambari and Alejandro Fernandez. Changes --- Addressed review comments Bugs: AMBARI-17051 https://issues.apache.org/jira/browse/AMBARI-17051 Repository: ambari Description --- Added the startup.properties changes required for Lifecycle policies and extension support Diffs (updated) - ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/.config-upgrade.xml.swp PRE-CREATION ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/config-upgrade.xml c72070b ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.3.xml 111b432 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/nonrolling-upgrade-2.4.xml 9365646 ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.3.xml 712241b ambari-server/src/main/resources/stacks/HDP/2.3/upgrades/upgrade-2.4.xml 4187d64 ambari-server/src/main/resources/stacks/HDP/2.4/upgrades/config-upgrade.xml 60cac05 ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/configuration/falcon-startup.properties.xml 0f542cc Diff: https://reviews.apache.org/r/48355/diff/ Testing --- Made sure the startup properties changes are valid manually Thanks, Venkat Ranganathan
Re: Review Request 48355: AMBARI-17051: Falcon startup properties changes for 2.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48355/ --- (Updated June 7, 2016, 12:10 p.m.) Review request for Ambari and Alejandro Fernandez. Changes --- Updated patch with review comments Bugs: AMBARI-17051 https://issues.apache.org/jira/browse/AMBARI-17051 Repository: ambari Description --- Added the startup.properties changes required for Lifecycle policies and extension support Diffs - ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/configuration/falcon-startup.properties.xml 0f542cc Diff: https://reviews.apache.org/r/48355/diff/ Testing (updated) --- Made sure the startup properties changes are valid manually Thanks, Venkat Ranganathan
Review Request 48355: AMBARI-17051: Falcon startup properties changes for 2.5
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48355/ --- Review request for Ambari and Alejandro Fernandez. Bugs: AMBARI-17051 https://issues.apache.org/jira/browse/AMBARI-17051 Repository: ambari Description --- Added the startup.properties changes required for Lifecycle policies and extension support Diffs - ambari-server/src/main/resources/stacks/HDP/2.5/services/FALCON/configuration/falcon-startup.properties.xml 0f542cc Diff: https://reviews.apache.org/r/48355/diff/ Testing --- Thanks, Venkat Ranganathan
Re: Review Request 47009: Falcon server start fails
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47009/#review132824
---
Ship it!
Ship It!
- Venkat Ranganathan
On May 11, 2016, 1:52 p.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47009/
> ---
>
> (Updated May 11, 2016, 1:52 p.m.)
>
>
> Review request for Ambari, Sumit Mohanty and Venkat Ranganathan.
>
>
> Bugs: AMBARI-16263
> https://issues.apache.org/jira/browse/AMBARI-16263
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Deployed HDP-2.5 and Falcon server failed to start.
>
>
> cat /var/log/falcon/falcon.out.20160504002*
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
>
>
> The command to start, in Ambari is:
>
>
> Execute['/usr/hdp/current/falcon-server/bin/falcon-start -port 15000']
> {'environment': {'HADOOP_HOME': '/usr/hdp/current/hadoop-client'}, 'path':
> ['/usr/hdp/current/hadoop-client/bin'], 'user': 'falcon'}
>
>
> Link falcon hook jars in falcon classpath - 'ln -s /hook/falcon/*
> /server/webapp/falcon/WEB-INF/lib/'
> is what is causing it. If falcon webapp is already exploded it will fail for
> falcon webapp itself. That step should not be done and we should change it to
> add falcon hook into webapp.jar itself post deployment like what we do for
> Oozie with prepare-war or added to server classpath explicitly
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
> 3fdf2e6
>
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
> bf7f437
>
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/setup_atlas_falcon.py
> 4b7c0c3
>
> Diff: https://reviews.apache.org/r/47009/diff/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 47009: Falcon server start fails
> On May 9, 2016, 2:49 p.m., Venkat Ranganathan wrote:
> >
We have committed a change as part of FALCON-1942 to add a environment variable
called FALCON_EXTRA_CLASS_PATH - this will be appended to the Falcon server
classpath. Please use it
> On May 9, 2016, 2:49 p.m., Venkat Ranganathan wrote:
> > ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml,
> > line 162
> > <https://reviews.apache.org/r/47009/diff/1/?file=1372978#file1372978line162>
> >
> > Don't we want the server classpath to be changed in falcon-config?
>
> Tom Beerbower wrote:
> Thanks for the review. I'm not familiar with falcon-config. Could you
> give more details?
I am thinking we should make Falcon server and client path to be customizable
so that we can accommodate the hook easily. This way the Atlas hook and
dependent jars can be in their own location and the path customized.
Let me work through the Falcon side of things. What needs to be done here is
in your customization of falcon-env.sh, instead of setting HADOOP_CLASSPATH,
you need to set a falcon env variable. Will update the variable after fixing
the falcon side of things
- Venkat
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47009/#review132337
---
On May 5, 2016, 5:07 a.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47009/
> ---
>
> (Updated May 5, 2016, 5:07 a.m.)
>
>
> Review request for Ambari, Sumit Mohanty and Venkat Ranganathan.
>
>
> Bugs: AMBARI-16263
> https://issues.apache.org/jira/browse/AMBARI-16263
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Deployed HDP-2.5 and Falcon server failed to start.
>
>
> cat /var/log/falcon/falcon.out.20160504002*
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
>
>
> The command to start, in Ambari is:
>
>
> Execute['/usr/hdp/current/falcon-server/bin/falcon-start -port 15000']
> {'environment': {'HADOOP_HOME': '/usr/hdp/current/hadoop-client'}, 'path':
> ['/usr/hdp/current/hadoop-client/bin'], 'user': 'falcon'}
>
>
> Link falcon hook jars in falcon classpath - 'ln -s /hook/falcon/*
> /server/webapp/falcon/WEB-INF/lib/'
> is what is causing it. If falcon webapp is already exploded it will fail for
> falcon webapp itself. That step should not be done and we should change it to
> add falcon hook into webapp.jar itself post deployment like what we do for
> Oozie with prepare-war or added to server classpath explicitly
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
> 3fdf2e6
>
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
> bf7f437
>
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/setup_atlas_falcon.py
> 4b7c0c3
>
> Diff: https://reviews.apache.org/r/47009/diff/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 47009: Falcon server start fails
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47009/#review132337
---
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
(line 162)
<https://reviews.apache.org/r/47009/#comment196515>
Don't we want the server classpath to be changed in falcon-config?
- Venkat Ranganathan
On May 5, 2016, 5:07 a.m., Tom Beerbower wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47009/
> ---
>
> (Updated May 5, 2016, 5:07 a.m.)
>
>
> Review request for Ambari, Sumit Mohanty and Venkat Ranganathan.
>
>
> Bugs: AMBARI-16263
> https://issues.apache.org/jira/browse/AMBARI-16263
>
>
> Repository: ambari
>
>
> Description
> ---
>
> Deployed HDP-2.5 and Falcon server failed to start.
>
>
> cat /var/log/falcon/falcon.out.20160504002*
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
> Error: Could not find or load main class org.apache.falcon.FalconServer
>
>
> The command to start, in Ambari is:
>
>
> Execute['/usr/hdp/current/falcon-server/bin/falcon-start -port 15000']
> {'environment': {'HADOOP_HOME': '/usr/hdp/current/hadoop-client'}, 'path':
> ['/usr/hdp/current/hadoop-client/bin'], 'user': 'falcon'}
>
>
> Link falcon hook jars in falcon classpath - 'ln -s /hook/falcon/*
> /server/webapp/falcon/WEB-INF/lib/'
> is what is causing it. If falcon webapp is already exploded it will fail for
> falcon webapp itself. That step should not be done and we should change it to
> add falcon hook into webapp.jar itself post deployment like what we do for
> Oozie with prepare-war or added to server classpath explicitly
>
>
> Diffs
> -
>
>
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/configuration/falcon-env.xml
> 3fdf2e6
>
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
> bf7f437
>
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/setup_atlas_falcon.py
> 4b7c0c3
>
> Diff: https://reviews.apache.org/r/47009/diff/
>
>
> Testing
> ---
>
> mvn clean test
>
>
> Thanks,
>
> Tom Beerbower
>
>
