Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

[Jayush Luniya]

> On April 20, 2016, 8:03 a.m., Jayush Luniya wrote:
> > Ship It!
> 
> Masahiro Tanaka wrote:
> Thank you, could you commit this?
> 
> Jayush Luniya wrote:
> Ok will commit today.

Committed. Can you please close the review?


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45676/#review129706
---


On April 22, 2016, 9:35 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45676/
> ---
> 
> (Updated April 22, 2016, 9:35 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, jun aoki, Jayush 
> Luniya, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-15678
> https://issues.apache.org/jira/browse/AMBARI-15678
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If yarn app state is not state or yarn app finalStatus is not succeeded, YARN 
> service check should fail.
> But in the YARN service_check.py, it doesn't fail because raise statement is 
> in try block and there is only `pass` in except block.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  e8d98ab 
> 
> Diff: https://reviews.apache.org/r/45676/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

[Masahiro Tanaka]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45676/
---

(Updated 4月 22, 2016, 9:35 a.m.)


Review request for Ambari, Andrew Onischuk, Jaimin Jetly, jun aoki, Jayush 
Luniya, and Vitalyi Brodetskyi.


Bugs: AMBARI-15678
https://issues.apache.org/jira/browse/AMBARI-15678


Repository: ambari


Description
---

If yarn app state is not state or yarn app finalStatus is not succeeded, YARN 
service check should fail.
But in the YARN service_check.py, it doesn't fail because raise statement is in 
try block and there is only `pass` in except block.


Diffs
-

  
ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
 e8d98ab 

Diff: https://reviews.apache.org/r/45676/diff/


Testing
---

mvn clean test


Thanks,

Masahiro Tanaka

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

[Jayush Luniya]

> On April 20, 2016, 8:03 a.m., Jayush Luniya wrote:
> > Ship It!
> 
> Masahiro Tanaka wrote:
> Thank you, could you commit this?

Ok will commit today.


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45676/#review129706
---


On April 19, 2016, 11:52 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45676/
> ---
> 
> (Updated April 19, 2016, 11:52 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, jun aoki, Jayush 
> Luniya, and Vitalyi Brodetskyi.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If yarn app state is not state or yarn app finalStatus is not succeeded, YARN 
> service check should fail.
> But in the YARN service_check.py, it doesn't fail because raise statement is 
> in try block and there is only `pass` in except block.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  e8d98ab 
> 
> Diff: https://reviews.apache.org/r/45676/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

[Masahiro Tanaka]

> On April 20, 2016, 8:03 a.m., Jayush Luniya wrote:
> > Ship It!

Thank you, could you commit this?


- Masahiro


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45676/#review129706
---


On April 19, 2016, 11:52 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45676/
> ---
> 
> (Updated April 19, 2016, 11:52 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, jun aoki, Jayush 
> Luniya, and Vitalyi Brodetskyi.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If yarn app state is not state or yarn app finalStatus is not succeeded, YARN 
> service check should fail.
> But in the YARN service_check.py, it doesn't fail because raise statement is 
> in try block and there is only `pass` in except block.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  e8d98ab 
> 
> Diff: https://reviews.apache.org/r/45676/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45676/#review129706
---


Ship it!




Ship It!

- Jayush Luniya


On April 19, 2016, 11:52 p.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45676/
> ---
> 
> (Updated April 19, 2016, 11:52 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, jun aoki, Jayush 
> Luniya, and Vitalyi Brodetskyi.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If yarn app state is not state or yarn app finalStatus is not succeeded, YARN 
> service check should fail.
> But in the YARN service_check.py, it doesn't fail because raise statement is 
> in try block and there is only `pass` in except block.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  e8d98ab 
> 
> Diff: https://reviews.apache.org/r/45676/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

[Jayush Luniya]

> On April 18, 2016, 5:33 a.m., Jayush Luniya wrote:
> > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py,
> >  line 137
> > 
> >
> > Add null checks and check reponse validity of  json_response before 
> > checking json_reponse['app']['state']
> 
> Masahiro Tanaka wrote:
> Thank you for review !
> I have a question, what do you mean `response validity of json_response` ?

I meant check that the json_response has ['app'] node and further has ['state'] 
node. 

Example:

json_response = { 'app' : { } }
json_response['app']['state']
Traceback (most recent call last):
  File "", line 1, in 
KeyError: 'state'


- Jayush


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45676/#review129295
---


On April 17, 2016, 4:56 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45676/
> ---
> 
> (Updated April 17, 2016, 4:56 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, jun aoki, Jayush 
> Luniya, and Vitalyi Brodetskyi.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If yarn app state is not state or yarn app finalStatus is not succeeded, YARN 
> service check should fail.
> But in the YARN service_check.py, it doesn't fail because raise statement is 
> in try block and there is only `pass` in except block.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  e8d98ab 
> 
> Diff: https://reviews.apache.org/r/45676/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

[Jayush Luniya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45676/#review129295
---




ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
 (line 134)


Add null checks and check reponse validity of  json_response before 
checking json_reponse['app']['state']


- Jayush Luniya


On April 17, 2016, 4:56 a.m., Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45676/
> ---
> 
> (Updated April 17, 2016, 4:56 a.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Jaimin Jetly, jun aoki, Jayush 
> Luniya, and Vitalyi Brodetskyi.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If yarn app state is not state or yarn app finalStatus is not succeeded, YARN 
> service check should fail.
> But in the YARN service_check.py, it doesn't fail because raise statement is 
> in try block and there is only `pass` in except block.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  e8d98ab 
> 
> Diff: https://reviews.apache.org/r/45676/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>

Re: Review Request 45676: AMBARI-15678: YARN service_check doesn't fail when application status is not reasonable

[Vitalyi Brodetskyi]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45676/#review126892
---


Ship it!




Ship It!

- Vitalyi Brodetskyi


On Квітень 4, 2016, 11:38 до полудня, Masahiro Tanaka wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45676/
> ---
> 
> (Updated Квітень 4, 2016, 11:38 до полудня)
> 
> 
> Review request for Ambari, jun aoki and Vitalyi Brodetskyi.
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> If yarn app state is not state or yarn app finalStatus is not succeeded, YARN 
> service check should fail.
> But in the YARN service_check.py, it doesn't fail because raise statement is 
> in try block and there is only `pass` in except block.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/service_check.py
>  e8d98ab 
> 
> Diff: https://reviews.apache.org/r/45676/diff/
> 
> 
> Testing
> ---
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Masahiro Tanaka
> 
>