Re: Review Request 45101: Configuration with tag 'TOPOLOGY_RESOLVED' exists for 'cluster-env' error when creating Kerberized cluster with Blueprints

[Robert Levas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45101/#review124555
---


Fix it, then Ship it!





ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 (lines 1437 - 1438)


I would have thought that the fix would have been somewhere within the 
blueprint processing code rather than here since it attempts to set the 
`cluster-env` config multiple times with the same tag.

If you skip the setting of this, wont you loose data?


- Robert Levas


On March 21, 2016, 10:23 a.m., Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45101/
> ---
> 
> (Updated March 21, 2016, 10:23 a.m.)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy, Robert Levas, and Sandor 
> Magyari.
> 
> 
> Bugs: AMBARI-15489
> https://issues.apache.org/jira/browse/AMBARI-15489
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The logic that determines if a new version has to be created for a 
> configuration should skip cluster wide config types when verifying current 
> desired config against service configs as these are not service configs.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  ac2fb22 
> 
> Diff: https://reviews.apache.org/r/45101/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> Unit tests results:
> Results :
> 
> Tests run: 3534, Failures: 0, Errors: 0, Skipped: 36
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 45101: Configuration with tag 'TOPOLOGY_RESOLVED' exists for 'cluster-env' error when creating Kerberized cluster with Blueprints

[Myroslav Papirkovskyy]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45101/#review124552
---




ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 (lines 1437 - 1438)


We chould not hardcode config types here.
Simple way to make this dynamic is to use following method:
org.apache.ambari.server.state.cluster.ClusterImpl#getServiceByConfigType

So after adding this method to Cluster interface check will look like 
following:

if ( cluster.getServiceByCOnfigType != null && 
clusterConfig.getServiceConfigVersions().isEmpty() )


- Myroslav Papirkovskyy


On Березень 21, 2016, 4:23 після полудня, Sebastian Toader wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45101/
> ---
> 
> (Updated Березень 21, 2016, 4:23 після полудня)
> 
> 
> Review request for Ambari, Myroslav Papirkovskyy, Robert Levas, and Sandor 
> Magyari.
> 
> 
> Bugs: AMBARI-15489
> https://issues.apache.org/jira/browse/AMBARI-15489
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> The logic that determines if a new version has to be created for a 
> configuration should skip cluster wide config types when verifying current 
> desired config against service configs as these are not service configs.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
>  ac2fb22 
> 
> Diff: https://reviews.apache.org/r/45101/diff/
> 
> 
> Testing
> ---
> 
> Manual testing done.
> 
> Unit tests results:
> Results :
> 
> Tests run: 3534, Failures: 0, Errors: 0, Skipped: 36
> 
> 
> Thanks,
> 
> Sebastian Toader
> 
>

Re: Review Request 45101: Configuration with tag 'TOPOLOGY_RESOLVED' exists for 'cluster-env' error when creating Kerberized cluster with Blueprints

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45101/
---

(Updated March 21, 2016, 3:23 p.m.)


Review request for Ambari, Myroslav Papirkovskyy, Robert Levas, and Sandor 
Magyari.


Changes
---

Added unit test results.


Bugs: AMBARI-15489
https://issues.apache.org/jira/browse/AMBARI-15489


Repository: ambari


Description
---

The logic that determines if a new version has to be created for a 
configuration should skip cluster wide config types when verifying current 
desired config against service configs as these are not service configs.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 ac2fb22 

Diff: https://reviews.apache.org/r/45101/diff/


Testing (updated)
---

Manual testing done.

Unit tests results:
Results :

Tests run: 3534, Failures: 0, Errors: 0, Skipped: 36


Thanks,

Sebastian Toader

Re: Review Request 45101: Configuration with tag 'TOPOLOGY_RESOLVED' exists for 'cluster-env' error when creating Kerberized cluster with Blueprints

[Sebastian Toader]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45101/
---

(Updated March 21, 2016, 3:15 p.m.)


Review request for Ambari, Myroslav Papirkovskyy, Robert Levas, and Sandor 
Magyari.


Changes
---

Linked apache jira to the review


Bugs: AMBARI-15489
https://issues.apache.org/jira/browse/AMBARI-15489


Repository: ambari


Description
---

The logic that determines if a new version has to be created for a 
configuration should skip cluster wide config types when verifying current 
desired config against service configs as these are not service configs.


Diffs
-

  
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
 ac2fb22 

Diff: https://reviews.apache.org/r/45101/diff/


Testing
---

Manual testing done.

Unit tests are running.


Thanks,

Sebastian Toader