Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/#review148773 --- Ship it! Verfied following scenarios 1. Add additional repo

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/#review148709 --- Ship it! Ship It! - Nate Cole On Sept. 13, 2016, 5:31 a.m.,

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

> On Sept. 7, 2016, 6:35 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackServiceDirectory.java, > > lines 42-43 > > > > > > Syntax. Fixed. > On Sept. 7, 2016, 6:35 p.m.,

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/ --- (Updated Sept. 13, 2016, 9:31 a.m.) Review request for Ambari, Jayush Luniya,

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

> On Sept. 7, 2016, 6:35 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/RepositoryInfo.java, > > lines 166-169 > > > > > > Objects.equals() for simplicity. Fixed. > On

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/ --- (Updated Sept. 13, 2016, 9:25 a.m.) Review request for Ambari, Jayush Luniya,

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

> On Sept. 7, 2016, 11:48 a.m., Tim Thorpe wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/StackModule.java, > > line 1133 > > > > > > This won't include extension services. You would need

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/ --- (Updated Sept. 12, 2016, 8:48 p.m.) Review request for Ambari, Jayush Luniya,

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

> On Aug. 29, 2016, 5:54 p.m., Jayush Luniya wrote: > > contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.0/repos/repoinfo.xml, > > line 24 > > > > > > A management pack

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

> On Aug. 29, 2016, 6:14 p.m., Jayush Luniya wrote: > > contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.0/repos/repoinfo.xml, > > line 24 > > > > > > Is it mandatory to

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

> On Aug. 29, 2016, 5:27 p.m., Nate Cole wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java, > > line 562 > > > > > > Weird that it's

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/#review148053 ---

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/#review148002 ---

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/ --- (Updated Sept. 5, 2016, 1:26 p.m.) Review request for Ambari, Jayush Luniya,

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

> On Aug. 29, 2016, 5:54 p.m., Jayush Luniya wrote: > > contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.0/repos/repoinfo.xml, > > line 24 > > > > > > A management pack

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

> On Sept. 1, 2016, 2:10 p.m., Tim Thorpe wrote: > > ambari-server/src/main/java/org/apache/ambari/server/stack/RepoUtil.java, > > line 138 > > > > > > The Optional class is only in JDK8. Currently Ambari is

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

> On Aug. 29, 2016, 5:27 p.m., Nate Cole wrote: > > I was under the impression that applying an m-pack would DIRECTLY update > > repoinfo.xml on the filesystem. Has the design changed since then? > > > > What is the purpose of carrying service version around with the repo? When > > updating

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/#review147557 ---

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

> On Aug. 29, 2016, 1:27 p.m., Nate Cole wrote: > > I was under the impression that applying an m-pack would DIRECTLY update > > repoinfo.xml on the filesystem. Has the design changed since then? > > > > What is the purpose of carrying service version around with the repo? When > > updating

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

> On Aug. 29, 2016, 5:27 p.m., Nate Cole wrote: > > I was under the impression that applying an m-pack would DIRECTLY update > > repoinfo.xml on the filesystem. Has the design changed since then? > > > > What is the purpose of carrying service version around with the repo? When > > updating

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

> On Aug. 29, 2016, 6:14 p.m., Jayush Luniya wrote: > > contrib/management-packs/microsoft-r_mpack/src/main/resources/custom-services/MICROSOFT_R/8.0.0/repos/repoinfo.xml, > > line 24 > > > > > > Is it mandatory to

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

> On Aug. 29, 2016, 6:11 p.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/VersionDefinitionResourceProvider.java, > > line 562 > > > > > > Why do we need to

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

> On Aug. 29, 2016, 5:58 p.m., Jayush Luniya wrote: > > A management pack for a custom service can be installed after a cluster is > > already deployed. Can you also test this scenario i.e. if installing a new > > management pack will it add this new repository for the cluster? Yes, it is

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

> On Aug. 29, 2016, 5:34 p.m., Nate Cole wrote: > > In addition, why not just keep repos with the service, then check for them > > when formulating the command. Seems easier than munging everything else. What exactly do you mean? - Balázs Bence

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

> On Aug. 29, 2016, 5:27 p.m., Nate Cole wrote: > > I was under the impression that applying an m-pack would DIRECTLY update > > repoinfo.xml on the filesystem. Has the design changed since then? > > > > What is the purpose of carrying service version around with the repo? When > > updating

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

> On Aug. 29, 2016, 5:27 p.m., Nate Cole wrote: > > I was under the impression that applying an m-pack would DIRECTLY update > > repoinfo.xml on the filesystem. Has the design changed since then? > > > > What is the purpose of carrying service version around with the repo? When > > updating

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/#review147173 ---

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/#review147170 --- A management pack for a custom service can be installed after a

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/#review147167 ---

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/#review147162 --- In addition, why not just keep repos with the service, then check

Re: Review Request 51238: Implementation for AMBARI-15538: Support service-specific repo for add-on services

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51238/#review147153 --- I was under the impression that applying an m-pack would DIRECTLY