Re: Review Request 62474: AMS: Add smart configs support for service

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62474/#review185920
---


Ship it!




Ship It!

- Aravindan Vijayan


On Sept. 21, 2017, 7:57 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62474/
> ---
> 
> (Updated Sept. 21, 2017, 7:57 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-22034
> https://issues.apache.org/jira/browse/AMBARI-22034
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mode, memory and some other settings are hard to hand edit and can use some 
> better UI tooling.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  44073ab 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilter.java
>  1446ec2 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilterTest.java
>  81da5c8 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
>  4d33661 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
>  9c4fc02 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml
>  2c9378e 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  1b085f6 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
>  43c3685 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/themes/theme.json
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62474/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 62474: AMS: Add smart configs support for service

[Sid Wagle]

> On Sept. 21, 2017, 7:37 p.m., Aravindan Vijayan wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
> > Lines 81 (patched)
> > 
> >
> > Should we allow minimum of 0? Or is that a normal practice in other 
> > services' enhanced configs?

Fixed


> On Sept. 21, 2017, 7:37 p.m., Aravindan Vijayan wrote:
> > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
> > Line 789 (original), 803 (patched)
> > 
> >
> > Unrelated query, but shouldnt this be in ams-env? We would ideally need 
> > restart of metrics collector and monitors for this change.

We need to open another Jira for this property to be handled correctly 
collector needs to tell the sink: Start writing to the monitor from now on.


- Sid


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62474/#review185913
---


On Sept. 21, 2017, 7:57 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62474/
> ---
> 
> (Updated Sept. 21, 2017, 7:57 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-22034
> https://issues.apache.org/jira/browse/AMBARI-22034
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mode, memory and some other settings are hard to hand edit and can use some 
> better UI tooling.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  44073ab 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilter.java
>  1446ec2 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilterTest.java
>  81da5c8 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
>  4d33661 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
>  9c4fc02 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml
>  2c9378e 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  1b085f6 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
>  43c3685 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/themes/theme.json
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62474/diff/2/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Re: Review Request 62474: AMS: Add smart configs support for service

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62474/
---

(Updated Sept. 21, 2017, 7:57 p.m.)


Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Jaimin Jetly.


Changes
---

Fixes based on comments.


Bugs: AMBARI-22034
https://issues.apache.org/jira/browse/AMBARI-22034


Repository: ambari


Description
---

Mode, memory and some other settings are hard to hand edit and can use some 
better UI tooling.


Diffs (updated)
-

  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
 44073ab 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilter.java
 1446ec2 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilterTest.java
 81da5c8 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
 4d33661 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
 9c4fc02 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml
 2c9378e 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 1b085f6 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
 43c3685 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/themes/theme.json
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62474/diff/2/

Changes: https://reviews.apache.org/r/62474/diff/1-2/


Testing
---

Manually tested.


Thanks,

Sid Wagle

Re: Review Request 62474: AMS: Add smart configs support for service

[Aravindan Vijayan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62474/#review185913
---




ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilter.java
Line 70 (original), 70 (patched)


The default whitelist file will be 
/etc/ambari-metrics-collector/conf/metrics_whitelist.



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
Lines 81 (patched)


Should we allow minimum of 0? Or is that a normal practice in other 
services' enhanced configs?



ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
Line 789 (original), 803 (patched)


Unrelated query, but shouldnt this be in ams-env? We would ideally need 
restart of metrics collector and monitors for this change.


- Aravindan Vijayan


On Sept. 21, 2017, 7:30 p.m., Sid Wagle wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62474/
> ---
> 
> (Updated Sept. 21, 2017, 7:30 p.m.)
> 
> 
> Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Jaimin Jetly.
> 
> 
> Bugs: AMBARI-22034
> https://issues.apache.org/jira/browse/AMBARI-22034
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Mode, memory and some other settings are hard to hand edit and can use some 
> better UI tooling.
> 
> 
> Diffs
> -
> 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
>  44073ab 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilter.java
>  1446ec2 
>   
> ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilterTest.java
>  81da5c8 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
>  4d33661 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
>  9c4fc02 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml
>  2c9378e 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
>  1b085f6 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
>  43c3685 
>   
> ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/themes/theme.json
>  PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/62474/diff/1/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> Sid Wagle
> 
>

Review Request 62474: AMS: Add smart configs support for service

[Sid Wagle]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62474/
---

Review request for Ambari, Aravindan Vijayan, Dmytro Sen, and Jaimin Jetly.


Bugs: AMBARI-22034
https://issues.apache.org/jira/browse/AMBARI-22034


Repository: ambari


Description
---

Mode, memory and some other settings are hard to hand edit and can use some 
better UI tooling.


Diffs
-

  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricConfiguration.java
 44073ab 
  
ambari-metrics/ambari-metrics-timelineservice/src/main/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilter.java
 1446ec2 
  
ambari-metrics/ambari-metrics-timelineservice/src/test/java/org/apache/hadoop/yarn/server/applicationhistoryservice/metrics/timeline/TimelineMetricsFilterTest.java
 81da5c8 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-env.xml
 4d33661 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-env.xml
 9c4fc02 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-site.xml
 2c9378e 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-site.xml
 1b085f6 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/metainfo.xml
 43c3685 
  
ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/themes/theme.json
 PRE-CREATION 


Diff: https://reviews.apache.org/r/62474/diff/1/


Testing
---

Manually tested.


Thanks,

Sid Wagle