Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-30 Thread Juanjo Marron
> On March 30, 2016, 1:44 a.m., Jayush Luniya wrote: > > Ship It! > > Jayush Luniya wrote: > Committed to trunk > commit 5b4e663f820390f7bc006509eb517c3477b8f453 > Author: Jayush Luniya > Date: Tue Mar 29 18:50:35 2016 -0700 > > AMBARI-14451: Stack Featurize HDFS

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-29 Thread Jayush Luniya
> On March 30, 2016, 1:44 a.m., Jayush Luniya wrote: > > Ship It! Committed to trunk commit 5b4e663f820390f7bc006509eb517c3477b8f453 Author: Jayush Luniya Date: Tue Mar 29 18:50:35 2016 -0700 AMBARI-14451: Stack Featurize HDFS service (Juanjo Marron via jluniya) - Jayush

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45328/#review126003 --- Ship it! Ship It! - Jayush Luniya On March 29, 2016, 8:06 p.

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-29 Thread Jayush Luniya
> On March 29, 2016, 4:24 p.m., Jayush Luniya wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py, > > line 58 > > > > > > This should be 2.3.0.0 and not 2.3.0.1 > > Ju

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-29 Thread Juanjo Marron
> On March 29, 2016, 4:17 p.m., Jayush Luniya wrote: > > Ship It! > > Jayush Luniya wrote: > @Juanjo > Please see my comments below. I noticed the issue after I +1'ed. Can you > revise the patch? Added new patch with the changes proposed and based on last trunk version - Juanjo ---

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-29 Thread Juanjo Marron
> On March 29, 2016, 4:24 p.m., Jayush Luniya wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/stack_features.py, > > line 58 > > > > > > This should be 2.3.0.0 and not 2.3.0.1 I chan

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-29 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45328/ --- (Updated March 29, 2016, 8:06 p.m.) Review request for Ambari, Alejandro Fernan

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45328/#review125904 --- ambari-common/src/main/python/resource_management/libraries/funct

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-29 Thread Jayush Luniya
> On March 29, 2016, 4:17 p.m., Jayush Luniya wrote: > > Ship It! @Juanjo Please see my comments below. I noticed the issue after I +1'ed. Can you revise the patch? - Jayush --- This is an automatically generated e-mail. To reply, visi

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45328/#review125898 --- ambari-common/src/main/python/resource_management/libraries/funct

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45328/#review125895 --- Ship it! Ship It! - Jayush Luniya On March 24, 2016, 11:26 p

Re: Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-24 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45328/#review125368 --- Ship it! Ship It! - Alejandro Fernandez On March 24, 2016, 1

Review Request 45328: AMBARI-14451: Stack Featurize HDFS service

2016-03-24 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45328/ --- Review request for Ambari, Alejandro Fernandez and Jayush Luniya. Bugs: AMBARI-