Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-11 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45972/
---

(Updated April 11, 2016, 8:24 p.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Robert Levas, and 
Sumit Mohanty.


Bugs: AMBARI-15785
https://issues.apache.org/jira/browse/AMBARI-15785


Repository: ambari


Description
---

HiveServerInteractive. Kerberos Support. 

- Needs to have hive keytabs on all nodemanagers.
- Hive Server Interactive needs same keytabs as HiveServer and Metastore.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 055296b 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 c7d57c0 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 5830a52 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
1812d05 

Diff: https://reviews.apache.org/r/45972/diff/


Testing
---

- Partially done.
- Python UT : PASSES.


Thanks,

Swapan Shridhar

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-11 Thread Alejandro Fernandez 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45972/#review128206
---


Fix it, then Ship it!





ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 96)


this needs to be raise Exception("...")


- Alejandro Fernandez


On April 11, 2016, 6:48 p.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45972/
> ---
> 
> (Updated April 11, 2016, 6:48 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Robert Levas, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15785
> https://issues.apache.org/jira/browse/AMBARI-15785
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HiveServerInteractive. Kerberos Support. 
> 
> - Needs to have hive keytabs on all nodemanagers.
> - Hive Server Interactive needs same keytabs as HiveServer and Metastore.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  055296b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  c7d57c0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  5830a52 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 1812d05 
> 
> Diff: https://reviews.apache.org/r/45972/diff/
> 
> 
> Testing
> ---
> 
> - Partially done.
> - Python UT : PASSES.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-11 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45972/
---

(Updated April 11, 2016, 6:22 p.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Robert Levas, and 
Sumit Mohanty.


Changes
---

Diffs updated.


Bugs: AMBARI-15785
https://issues.apache.org/jira/browse/AMBARI-15785


Repository: ambari


Description
---

HiveServerInteractive. Kerberos Support. 

- Needs to have hive keytabs on all nodemanagers.
- Hive Server Interactive needs same keytabs as HiveServer and Metastore.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 055296b 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 c7d57c0 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 5830a52 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
a3009ee 

Diff: https://reviews.apache.org/r/45972/diff/


Testing
---

- Partially done.
- Python UT : PASSES.


Thanks,

Swapan Shridhar

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-10 Thread Swapan Shridhar 


> On April 11, 2016, 5:18 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py,
> >  line 137
> > 
> >
> > why the check for params.current_version to be not None?

Fixed. Doesn't make sense there.


> On April 11, 2016, 5:18 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py,
> >  line 184
> > 
> >
> > Do not hard code path to folder .slider/keytabs/hive - hive. The 
> > setup_security() method is using {params.hive_user}. Use the same here as 
> > well.

Done.


> On April 11, 2016, 5:18 a.m., Sumit Mohanty wrote:
> > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py,
> >  line 504
> > 
> >
> > Remove the variable llap_local_dir

Removed. Not required till we decide on creating LLAP related work dirs.


- Swapan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45972/#review128067
---


On April 11, 2016, 5:03 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45972/
> ---
> 
> (Updated April 11, 2016, 5:03 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Robert Levas, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15785
> https://issues.apache.org/jira/browse/AMBARI-15785
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HiveServerInteractive. Kerberos Support. 
> 
> - Needs to have hive keytabs on all nodemanagers.
> - Hive Server Interactive needs same keytabs as HiveServer and Metastore.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  055296b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  c7d57c0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  5830a52 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> a3009ee 
> 
> Diff: https://reviews.apache.org/r/45972/diff/
> 
> 
> Testing
> ---
> 
> - Partially done.
> - Python UT : PASSES.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-10 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45972/
---

(Updated April 11, 2016, 5:03 a.m.)


Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Robert Levas, and 
Sumit Mohanty.


Changes
---

Removed '/hadoop/llap/local' di creation for Kerberized cluster.


Bugs: AMBARI-15785
https://issues.apache.org/jira/browse/AMBARI-15785


Repository: ambari


Description
---

HiveServerInteractive. Kerberos Support. 

- Needs to have hive keytabs on all nodemanagers.
- Hive Server Interactive needs same keytabs as HiveServer and Metastore.


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 055296b 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 c7d57c0 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 5830a52 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
a3009ee 

Diff: https://reviews.apache.org/r/45972/diff/


Testing
---

- Partially done.
- Python UT : PASSES.


Thanks,

Swapan Shridhar

Re: Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-09 Thread Sumit Mohanty 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45972/#review127987
---




ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 89)


Will this not always be true? What is the expected value of status to go in 
to the if condition



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 183)


--loglevel is probably default set to INFO. Do we need to pass that in 
explicitly?



ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 (line 240)


On which host should these directories be created? It seems to be needed on 
all hosts where llap is running - at least based on the name.

Also, we should be using the Directory construct to create the directories.



ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 (line 477)


Change the default to /hadoop/llap/local


- Sumit Mohanty


On April 9, 2016, 7:30 a.m., Swapan Shridhar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45972/
> ---
> 
> (Updated April 9, 2016, 7:30 a.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Robert Levas, 
> and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-15785
> https://issues.apache.org/jira/browse/AMBARI-15785
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> HiveServerInteractive. Kerberos Support. 
> 
> - Needs to have hive keytabs on all nodemanagers.
> - Hive Server Interactive needs same keytabs as HiveServer and Metastore.
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
>  055296b 
>   
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
>  c7d57c0 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
>  5830a52 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 9050092 
> 
> Diff: https://reviews.apache.org/r/45972/diff/
> 
> 
> Testing
> ---
> 
> - Partially done.
> - Currently blocked by : https://hortonworks.jira.com/browse/BUG-55791
> - 
> - Python UT : PASSES.
> 
> 
> Thanks,
> 
> Swapan Shridhar
> 
>

Review Request 45972: AMBARI-15785. HiveServerInteractive. Kerberos Support.

2016-04-09 Thread Swapan Shridhar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45972/
---

Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, Robert Levas, and 
Sumit Mohanty.


Bugs: AMBARI-15785
https://issues.apache.org/jira/browse/AMBARI-15785


Repository: ambari


Description
---

HiveServerInteractive. Kerberos Support. 

- Needs to have hive keytabs on all nodemanagers.
- Hive Server Interactive needs same keytabs as HiveServer and Metastore.


Diffs
-

  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py
 055296b 
  
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py
 c7d57c0 
  
ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-site.xml
 5830a52 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
9050092 

Diff: https://reviews.apache.org/r/45972/diff/


Testing
---

- Partially done.
- Currently blocked by : https://hortonworks.jira.com/browse/BUG-55791
- 
- Python UT : PASSES.


Thanks,

Swapan Shridhar