Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-16 Thread Juanjo Marron
> On May 14, 2016, 9:09 a.m., Jayush Luniya wrote: > > Ship It! > > Jayush Luniya wrote: > @Juanjo, > I have committed this to trunk. However, I think we can skip this for > branch-2.4 as it is not required for branch-2.4. Can you update the > fixVersion for the JIRA to Ambari 3.0 inst

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-14 Thread Jayush Luniya
> On May 14, 2016, 9:09 a.m., Jayush Luniya wrote: > > Ship It! @Juanjo, I have committed this to trunk. However, I think we can skip this for branch-2.4 as it is not required for branch-2.4. Can you update the fixVersion for the JIRA to Ambari 3.0 instead. - Jayush ---

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-14 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46853/#review133259 --- Ship it! Ship It! - Jayush Luniya On May 3, 2016, 6:12 p.m.,

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-11 Thread Juanjo Marron
> On April 29, 2016, 10:34 p.m., Jayush Luniya wrote: > > I think we need more testing on this apart from unit tests to ensure all > > imports are there. > > Juanjo Marron wrote: > Hi Jayush, > > Thanks for the review. > I'll add this couple of missing imports to ACCUMULO serv

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-11 Thread Jayush Luniya
> On April 29, 2016, 10:34 p.m., Jayush Luniya wrote: > > I think we need more testing on this apart from unit tests to ensure all > > imports are there. > > Juanjo Marron wrote: > Hi Jayush, > > Thanks for the review. > I'll add this couple of missing imports to ACCUMULO serv

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-09 Thread Juanjo Marron
> On April 29, 2016, 10:34 p.m., Jayush Luniya wrote: > > I think we need more testing on this apart from unit tests to ensure all > > imports are there. > > Juanjo Marron wrote: > Hi Jayush, > > Thanks for the review. > I'll add this couple of missing imports to ACCUMULO serv

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-03 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46853/ --- (Updated May 3, 2016, 6:12 p.m.) Review request for Ambari, Alejandro Fernandez

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-03 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46853/ --- (Updated May 3, 2016, 6:11 p.m.) Review request for Ambari, Alejandro Fernandez

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-03 Thread Juanjo Marron
> On May 3, 2016, 12:32 a.m., Matt wrote: > > Ship It! Waiting for Hadoop QA to have new patch available with installation and service checks tests performed Will upload it soon. Thanks for the review - Juanjo --- This is an automatica

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-02 Thread Matt
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46853/#review131430 --- Ship it! Ship It! - Matt On April 29, 2016, 5:51 p.m., Juanj

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-05-02 Thread Juanjo Marron
> On April 29, 2016, 10:34 p.m., Jayush Luniya wrote: > > I think we need more testing on this apart from unit tests to ensure all > > imports are there. > > Juanjo Marron wrote: > Hi Jayush, > > Thanks for the review. > I'll add this couple of missing imports to ACCUMULO serv

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-04-29 Thread Juanjo Marron
> On April 29, 2016, 10:34 p.m., Jayush Luniya wrote: > > I think we need more testing on this apart from unit tests to ensure all > > imports are there. Hi Jayush, Thanks for the review. I'll add this couple of missing imports to ACCUMULO service check I reviewed UTs, I did a fresh installat

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-04-29 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46853/ --- (Updated April 30, 2016, 12:51 a.m.) Review request for Ambari, Alejandro Ferna

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-04-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46853/#review131209 --- I think we need more testing on this apart from unit tests to ensu

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-04-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46853/#review131208 --- ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2

Re: Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-04-29 Thread Jayush Luniya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46853/#review131207 --- ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2

Review Request 46853: clean up import * : Accumulo, Ambari-metrics, Atlas, Falcon, Flume and Ganglia

2016-04-29 Thread Juanjo Marron
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46853/ --- Review request for Ambari, Alejandro Fernandez and Jayush Luniya. Bugs: AMBARI-