Re: Review Request 46949: PXF alert: change the message to make it more meaningful when both namenodes are down on Secured HA cluster.

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46949/#review131752
---


Ship it!




Ship It!

- Alexander Denissov


On May 4, 2016, 9:28 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46949/
> ---
> 
> (Updated May 4, 2016, 9:28 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16237
> https://issues.apache.org/jira/browse/AMBARI-16237
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PXF alerts shows "Configuration parameter 'fs_root' was not found in 
> configurations dictionary!" when both namnodes are down on secured NN HA 
> environment, which the error message is not too clear.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py
>  ee16c9b 
> 
> Diff: https://reviews.apache.org/r/46949/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46949: PXF alert: change the message to make it more meaningful when both namenodes are down on Secured HA cluster.

[jun aoki]

> On May 4, 2016, 4:45 p.m., Alexander Denissov wrote:
> > ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py,
> >  line 143
> > 
> >
> > The code in line 57 is:
> > 
> > raise Fail('No active NameNode was found.')
> > 
> > Should the same be done here for consistency ?

Modified.


- jun


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46949/#review131705
---


On May 4, 2016, 9:28 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46949/
> ---
> 
> (Updated May 4, 2016, 9:28 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16237
> https://issues.apache.org/jira/browse/AMBARI-16237
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PXF alerts shows "Configuration parameter 'fs_root' was not found in 
> configurations dictionary!" when both namnodes are down on secured NN HA 
> environment, which the error message is not too clear.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py
>  ee16c9b 
> 
> Diff: https://reviews.apache.org/r/46949/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46949: PXF alert: change the message to make it more meaningful when both namenodes are down on Secured HA cluster.

[jun aoki]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46949/
---

(Updated May 4, 2016, 9:28 p.m.)


Review request for Ambari.


Bugs: AMBARI-16237
https://issues.apache.org/jira/browse/AMBARI-16237


Repository: ambari


Description
---

PXF alerts shows "Configuration parameter 'fs_root' was not found in 
configurations dictionary!" when both namnodes are down on secured NN HA 
environment, which the error message is not too clear.


Diffs (updated)
-

  
ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py
 ee16c9b 

Diff: https://reviews.apache.org/r/46949/diff/


Testing
---

Manually tested.


Thanks,

jun aoki

Re: Review Request 46949: PXF alert: change the message to make it more meaningful when both namenodes are down on Secured HA cluster.

[Alexander Denissov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46949/#review131705
---




ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py
 (line 142)


The code in line 57 is:

raise Fail('No active NameNode was found.')

Should the same be done here for consistency ?


- Alexander Denissov


On May 3, 2016, 11:05 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46949/
> ---
> 
> (Updated May 3, 2016, 11:05 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16237
> https://issues.apache.org/jira/browse/AMBARI-16237
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PXF alerts shows "Configuration parameter 'fs_root' was not found in 
> configurations dictionary!" when both namnodes are down on secured NN HA 
> environment, which the error message is not too clear.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py
>  ee16c9b 
> 
> Diff: https://reviews.apache.org/r/46949/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46949: PXF alert: change the message to make it more meaningful when both namenodes are down on Secured HA cluster.

[Matt]

> On May 3, 2016, 4:14 p.m., Matt wrote:
> >

Discussed this in person:
This function is not used anywhere else, besides PXF service. Logging would be 
taken care of by PXF service component.


- Matt


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46949/#review131580
---


On May 3, 2016, 4:05 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46949/
> ---
> 
> (Updated May 3, 2016, 4:05 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16237
> https://issues.apache.org/jira/browse/AMBARI-16237
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PXF alerts shows "Configuration parameter 'fs_root' was not found in 
> configurations dictionary!" when both namnodes are down on secured NN HA 
> environment, which the error message is not too clear.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py
>  ee16c9b 
> 
> Diff: https://reviews.apache.org/r/46949/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> jun aoki
> 
>

Re: Review Request 46949: PXF alert: change the message to make it more meaningful when both namenodes are down on Secured HA cluster.

[Matt]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46949/#review131580
---


Ship it!





ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py
 (line 141)


Is there a possibility where active_namenodes can be an empty list? - A 
case where both namenodes are down?



ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py
 (line 143)


Do you need to log this explicitly using Logger.fail() or does it get 
logged automatically to std-err log, which shows up the UI?


- Matt


On May 3, 2016, 4:05 p.m., jun aoki wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46949/
> ---
> 
> (Updated May 3, 2016, 4:05 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-16237
> https://issues.apache.org/jira/browse/AMBARI-16237
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> PXF alerts shows "Configuration parameter 'fs_root' was not found in 
> configurations dictionary!" when both namnodes are down on secured NN HA 
> environment, which the error message is not too clear.
> 
> 
> Diffs
> -
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/namenode_ha_utils.py
>  ee16c9b 
> 
> Diff: https://reviews.apache.org/r/46949/diff/
> 
> 
> Testing
> ---
> 
> Manually tested.
> 
> 
> Thanks,
> 
> jun aoki
> 
>