Re: Review Request 48162: 16171 Addendum2 for stackadvisor with Phoenix Query Server kerberos configuration

2016-06-03 Thread Jonathan Hurley 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48162/#review136059
---


Ship it!




Ship It!

- Jonathan Hurley


On June 2, 2016, 12:38 p.m., Josh Elser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48162/
> ---
> 
> (Updated June 2, 2016, 12:38 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-16171
> https://issues.apache.org/jira/browse/AMBARI-16171
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix an issue where unsubstituted variables are being left in core-site.xml
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
>  f887f92 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/kerberos.json 
> 5cfe42d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 413a2f7 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> d61de7b 
> 
> Diff: https://reviews.apache.org/r/48162/diff/
> 
> 
> Testing
> ---
> 
> Deployed 2.4 with Kerberos and no PQS
> Deployed 2.4 with Kerberos and PQS
> (correct configs for both)
> Python UTs are passing locally
> java UTs still running locally
> 
> 
> Thanks,
> 
> Josh Elser
> 
>

Re: Review Request 48162: 16171 Addendum2 for stackadvisor with Phoenix Query Server kerberos configuration

2016-06-03 Thread Nate Cole 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48162/#review136057
---


Ship it!





ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
209)


%s % syntax is not the standard anymore, use "".format(...)


- Nate Cole


On June 2, 2016, 12:38 p.m., Josh Elser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48162/
> ---
> 
> (Updated June 2, 2016, 12:38 p.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley, Nate Cole, and Robert Levas.
> 
> 
> Bugs: AMBARI-16171
> https://issues.apache.org/jira/browse/AMBARI-16171
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix an issue where unsubstituted variables are being left in core-site.xml
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
>  f887f92 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/kerberos.json 
> 5cfe42d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 413a2f7 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> d61de7b 
> 
> Diff: https://reviews.apache.org/r/48162/diff/
> 
> 
> Testing
> ---
> 
> Deployed 2.4 with Kerberos and no PQS
> Deployed 2.4 with Kerberos and PQS
> (correct configs for both)
> Python UTs are passing locally
> java UTs still running locally
> 
> 
> Thanks,
> 
> Josh Elser
> 
>

Re: Review Request 48162: 16171 Addendum2 for stackadvisor with Phoenix Query Server kerberos configuration

2016-06-02 Thread Josh Elser 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48162/
---

(Updated June 2, 2016, 3:29 p.m.)


Review request for Ambari and Robert Levas.


Changes
---

Apply Robert's suggestions. Re-ran python tests.


Bugs: AMBARI-16171
https://issues.apache.org/jira/browse/AMBARI-16171


Repository: ambari


Description
---

Fix an issue where unsubstituted variables are being left in core-site.xml


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json 
f887f92 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/kerberos.json 
5cfe42d 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
413a2f7 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py d61de7b 

Diff: https://reviews.apache.org/r/48162/diff/


Testing
---

Deployed 2.4 with Kerberos and no PQS
Deployed 2.4 with Kerberos and PQS
(correct configs for both)
Python UTs are passing locally
java UTs still running locally


Thanks,

Josh Elser

Re: Review Request 48162: 16171 Addendum2 for stackadvisor with Phoenix Query Server kerberos configuration

2016-06-02 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48162/#review135914
---




ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
202)


I thing the following is a better check since the KERBEROS service may not 
be installed even though Keberos may be enabled.  This can happen if the 
`manual` option is selected rather than `MIT KDC` or `Active Directory`:

```
if "cluster-env" in services["configurations"] \
 and "security_enabled" in 
services["configurations"]["cluster-env"]["properties"] \
 and 
services["configurations"]["cluster-env"]["properties"]["security_enabled"].lower()
 == "true":
```


- Robert Levas


On June 2, 2016, 1:27 a.m., Josh Elser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48162/
> ---
> 
> (Updated June 2, 2016, 1:27 a.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-16171
> https://issues.apache.org/jira/browse/AMBARI-16171
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix an issue where unsubstituted variables are being left in core-site.xml
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
>  f887f92 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/kerberos.json 
> 5cfe42d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 413a2f7 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> d61de7b 
> 
> Diff: https://reviews.apache.org/r/48162/diff/
> 
> 
> Testing
> ---
> 
> Deployed 2.4 with Kerberos and no PQS
> Deployed 2.4 with Kerberos and PQS
> (correct configs for both)
> Python UTs are passing locally
> java UTs still running locally
> 
> 
> Thanks,
> 
> Josh Elser
> 
>

Re: Review Request 48162: 16171 Addendum2 for stackadvisor with Phoenix Query Server kerberos configuration

2016-06-02 Thread Robert Levas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48162/#review135906
---


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
197)


Do we want all this additional logging?  If you want to keep it, maybe 
downgrade the level?



ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
206)


Do we want all this additional logging?  If you want to keep it, maybe 
downgrade the level?



ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
208)


Do we want all this additional logging?  If you want to keep it, maybe 
downgrade the level?



ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
213)


Do we want all this additional logging?  If you want to keep it, maybe 
downgrade the level?



ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
(lines 220 - 223)


Do we want all this additional logging?  If you want to keep it, maybe 
downgrade the level?



ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py (line 
225)


Do we want all this additional logging?  If you want to keep it, maybe 
downgrade the level?



ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
(lines 229 - 230)


Do we want all this additional logging?  If you want to keep it, maybe 
downgrade the level?


- Robert Levas


On June 2, 2016, 1:27 a.m., Josh Elser wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48162/
> ---
> 
> (Updated June 2, 2016, 1:27 a.m.)
> 
> 
> Review request for Ambari and Robert Levas.
> 
> 
> Bugs: AMBARI-16171
> https://issues.apache.org/jira/browse/AMBARI-16171
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Fix an issue where unsubstituted variables are being left in core-site.xml
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json
>  f887f92 
>   
> ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/kerberos.json 
> 5cfe42d 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
> 413a2f7 
>   ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py 
> d61de7b 
> 
> Diff: https://reviews.apache.org/r/48162/diff/
> 
> 
> Testing
> ---
> 
> Deployed 2.4 with Kerberos and no PQS
> Deployed 2.4 with Kerberos and PQS
> (correct configs for both)
> Python UTs are passing locally
> java UTs still running locally
> 
> 
> Thanks,
> 
> Josh Elser
> 
>

Review Request 48162: 16171 Addendum2 for stackadvisor with Phoenix Query Server kerberos configuration

2016-06-01 Thread Josh Elser 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48162/
---

Review request for Ambari and Robert Levas.


Bugs: AMBARI-16171
https://issues.apache.org/jira/browse/AMBARI-16171


Repository: ambari


Description
---

Fix an issue where unsubstituted variables are being left in core-site.xml


Diffs
-

  
ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/kerberos.json 
f887f92 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/HBASE/kerberos.json 
5cfe42d 
  ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py 
413a2f7 
  ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py d61de7b 

Diff: https://reviews.apache.org/r/48162/diff/


Testing
---

Deployed 2.4 with Kerberos and no PQS
Deployed 2.4 with Kerberos and PQS
(correct configs for both)
Python UTs are passing locally
java UTs still running locally


Thanks,

Josh Elser