Re: Review Request 48609: AMBARI-17183: client.properties for Falcon should be configurable via Ambari

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48609/#review139285
---



Pushed to trunk, commit 4a3fb6ef1db5ef15c0caca958a7a72786b0fafd3
branch-2.4, commit 16d63dabf41f2dcb58a51d537ec9262e7f4a4f79

- Alejandro Fernandez


On June 23, 2016, 7:05 a.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48609/
> ---
> 
> (Updated June 23, 2016, 7:05 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-17183
> https://issues.apache.org/jira/browse/AMBARI-17183
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently falcon-client.properties is generated without functionality for 
> user changes.   We should fix it for users of mirroring etc
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  b5b3a34 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  22fb691 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/package/scripts/falcon.py
>  9a72af1 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_client.py 
> fbf624a 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 68dc7c9 
>   ambari-server/src/test/python/stacks/2.1/configs/default.json a6bcc24 
>   ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json 
> 7499cdf 
> 
> Diff: https://reviews.apache.org/r/48609/diff/
> 
> 
> Testing
> ---
> 
> UT passes
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 48609: AMBARI-17183: client.properties for Falcon should be configurable via Ambari

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48609/#review139267
---


Fix it, then Ship it!





ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/package/scripts/falcon.py
 (line 42)


Is this spaces or tabs?


- Alejandro Fernandez


On June 23, 2016, 7:05 a.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48609/
> ---
> 
> (Updated June 23, 2016, 7:05 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-17183
> https://issues.apache.org/jira/browse/AMBARI-17183
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently falcon-client.properties is generated without functionality for 
> user changes.   We should fix it for users of mirroring etc
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  b5b3a34 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  22fb691 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/package/scripts/falcon.py
>  9a72af1 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_client.py 
> fbf624a 
>   ambari-server/src/test/python/stacks/2.1/FALCON/test_falcon_server.py 
> 68dc7c9 
>   ambari-server/src/test/python/stacks/2.1/configs/default.json a6bcc24 
>   ambari-server/src/test/python/stacks/2.2/configs/falcon-upgrade.json 
> 7499cdf 
> 
> Diff: https://reviews.apache.org/r/48609/diff/
> 
> 
> Testing
> ---
> 
> UT passes
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 48609: AMBARI-17183: client.properties for Falcon should be configurable via Ambari

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48609/#review137814
---


Ship it!




Ship It!

- Alejandro Fernandez


On June 15, 2016, 5:51 p.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48609/
> ---
> 
> (Updated June 15, 2016, 5:51 p.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-17183
> https://issues.apache.org/jira/browse/AMBARI-17183
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently falcon-client.properties is generated without functionality for 
> user changes.   We should fix it for users of mirroring etc
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  b5b3a34 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  22fb691 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/package/scripts/falcon.py
>  9a72af1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/FALCON/configuration/falcon-client.properties.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48609/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Re: Review Request 48609: AMBARI-17183: client.properties for Falcon should be configurable via Ambari

[Venkat Ranganathan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48609/
---

(Updated June 15, 2016, 10:51 a.m.)


Review request for Ambari.


Changes
---

Updated patch with suggestions


Bugs: AMBARI-17183
https://issues.apache.org/jira/browse/AMBARI-17183


Repository: ambari


Description
---

Currently falcon-client.properties is generated without functionality for user 
changes.   We should fix it for users of mirroring etc


Diffs (updated)
-

  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 b5b3a34 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 22fb691 
  
ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/package/scripts/falcon.py
 9a72af1 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/FALCON/configuration/falcon-client.properties.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/48609/diff/


Testing
---


Thanks,

Venkat Ranganathan

Re: Review Request 48609: AMBARI-17183: client.properties for Falcon should be configurable via Ambari

[Alejandro Fernandez]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48609/#review137377
---



Has this been tested on an actual stack? These configs are being added to HDP 
2.3 or higher.
For an existing cluster with HDP 2.3 or higher, I believe ambari upgrade will 
add this as a new config type.


ambari-server/src/main/resources/stacks/HDP/2.3/services/FALCON/configuration/falcon-client.properties.xml
 (line 28)


Based on the latest code, we no longer need 

I believe you want,
 and take any other defaults.


- Alejandro Fernandez


On June 13, 2016, 4:02 a.m., Venkat Ranganathan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48609/
> ---
> 
> (Updated June 13, 2016, 4:02 a.m.)
> 
> 
> Review request for Ambari.
> 
> 
> Bugs: AMBARI-17183
> https://issues.apache.org/jira/browse/AMBARI-17183
> 
> 
> Repository: ambari
> 
> 
> Description
> ---
> 
> Currently falcon-client.properties is generated without functionality for 
> user changes.   We should fix it for users of mirroring etc
> 
> 
> Diffs
> -
> 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
>  5e25325 
>   
> ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
>  8c2ad8e 
>   
> ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/package/scripts/falcon.py
>  9a72af1 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3/services/FALCON/configuration/falcon-client.properties.xml
>  PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/48609/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Venkat Ranganathan
> 
>

Review Request 48609: AMBARI-17183: client.properties for Falcon should be configurable via Ambari

[Venkat Ranganathan]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48609/
---

Review request for Ambari.


Bugs: AMBARI-17183
https://issues.apache.org/jira/browse/AMBARI-17183


Repository: ambari


Description
---

Currently falcon-client.properties is generated without functionality for user 
changes.   We should fix it for users of mirroring etc


Diffs
-

  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/falcon.py
 5e25325 
  
ambari-server/src/main/resources/common-services/FALCON/0.5.0.2.1/package/scripts/params_linux.py
 8c2ad8e 
  
ambari-server/src/main/resources/stacks/HDP/2.1.GlusterFS/services/FALCON/package/scripts/falcon.py
 9a72af1 
  
ambari-server/src/main/resources/stacks/HDP/2.3/services/FALCON/configuration/falcon-client.properties.xml
 PRE-CREATION 

Diff: https://reviews.apache.org/r/48609/diff/


Testing
---


Thanks,

Venkat Ranganathan