Re: Review Request 49324: AMBARI-17352: A command line script to run pre-install checks and summarize the results

2016-06-29 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49324/#review140050 --- Ship it! Ship It! - Alejandro Fernandez On June 29, 2016,

Re: Review Request 49324: AMBARI-17352: A command line script to run pre-install checks and summarize the results

2016-06-29 Thread Di Li
> On June 29, 2016, 6:48 p.m., Alejandro Fernandez wrote: > > Hello Alejandro, Thanks for the review. I have renamed the non pythonic var name and added pydocstring as requested. The new patch is uploaded. Please review and let me know of any issues. Di. - Di

Re: Review Request 49324: AMBARI-17352: A command line script to run pre-install checks and summarize the results

2016-06-29 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49324/ --- (Updated June 29, 2016, 8:49 p.m.) Review request for Ambari, Alejandro

Re: Review Request 49324: AMBARI-17352: A command line script to run pre-install checks and summarize the results

2016-06-29 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49324/#review140035 ---

Review Request 49324: AMBARI-17352: A command line script to run pre-install checks and summarize the results

2016-06-28 Thread Di Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49324/ --- Review request for Ambari, Alejandro Fernandez and Yusaku Sako. Bugs: