Re: Review Request 49891: Restart indicator is not shown after modifying the configs

2016-07-19 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49891/#review142757 --- Ship it! Ship It! - Sid Wagle On July 19, 2016, 10:54 a.m.,

Re: Review Request 49891: Restart indicator is not shown after modifying the configs

2016-07-19 Thread Eugene Chekanskiy
> On July 15, 2016, 1:54 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java, > > line 76 > > > > > > Document why this lock is necessary/important. Done.

Re: Review Request 49891: Restart indicator is not shown after modifying the configs

2016-07-19 Thread Eugene Chekanskiy
> On July 18, 2016, 3:57 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java, > > line 76 > > > > > > Important to docuemnt why this is needed. Done. > On July 1

Re: Review Request 49891: Restart indicator is not shown after modifying the configs

2016-07-19 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49891/ --- (Updated July 19, 2016, 1:54 p.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 49891: Restart indicator is not shown after modifying the configs

2016-07-19 Thread Eugene Chekanskiy
> On July 18, 2016, 9:35 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/ConfigHelper.java, > > line 142 > > > > > > Have you considered using a ConcurrentHashMap instead? This

Re: Review Request 49891: Restart indicator is not shown after modifying the configs

2016-07-18 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49891/#review142643 --- ambari-server/src/main/java/org/apache/ambari/server/state/Config

Re: Review Request 49891: Restart indicator is not shown after modifying the configs

2016-07-18 Thread Sid Wagle
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49891/#review142569 --- ambari-server/src/main/java/org/apache/ambari/server/state/Config

Re: Review Request 49891: Restart indicator is not shown after modifying the configs

2016-07-18 Thread Myroslav Papirkovskyy
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49891/#review142542 --- Ship it! Ship It! - Myroslav Papirkovskyy On Липень 15, 2016

Re: Review Request 49891: Restart indicator is not shown after modifying the configs

2016-07-15 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49891/#review142373 --- Ship it! ambari-server/src/main/java/org/apache/ambari/server/

Re: Review Request 49891: Restart indicator is not shown after modifying the configs

2016-07-15 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49891/ --- (Updated July 15, 2016, 1:26 p.m.) Review request for Ambari, Andrew Onischuk,

Re: Review Request 49891: Restart indicator is not shown after modifying the configs

2016-07-11 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49891/#review141677 --- Ship it! Ship It! - Andrew Onischuk On July 11, 2016, 12:22

Review Request 49891: Restart indicator is not shown after modifying the configs

2016-07-11 Thread Dmitro Lisnichenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49891/ --- Review request for Ambari, Andrew Onischuk and Jonathan Hurley. Bugs: AMBARI-17