Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-20 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63916/#review191492 --- Thanks for reviews - Andrew Onischuk On Nov. 20, 2017, 10:35

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-20 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63916/ --- (Updated Nov. 20, 2017, 10:35 a.m.) Review request for Ambari, Attila

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-20 Thread Andrew Onischuk
> On Nov. 17, 2017, 4:25 p.m., Nate Cole wrote: > > Please also verify if BigInsight stacks are affected by this change. If > > that is the case, then a separate JIRA should be opened to address that. > > Jonathan Hurley wrote: > Great catch! Looks like it does: > >

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-18 Thread Andrew Onischuk
> On Nov. 17, 2017, 4:25 p.m., Nate Cole wrote: > > Please also verify if BigInsight stacks are affected by this change. If > > that is the case, then a separate JIRA should be opened to address that. > > Jonathan Hurley wrote: > Great catch! Looks like it does: > >

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-18 Thread Andrew Onischuk
> On Nov. 17, 2017, 4:15 p.m., Nate Cole wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py > > Lines 82-83 (patched) > > > > > > Any key checks we need here? Use

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-18 Thread Andrew Onischuk
> On Nov. 17, 2017, 4:15 p.m., Nate Cole wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py > > Lines 77-79 (patched) > > > > > > Is a zero-length possible? Should

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-18 Thread Andrew Onischuk
> On Nov. 17, 2017, 4:02 p.m., Jonathan Hurley wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/get_lzo_packages.py > > Lines 66-69 (patched) > > > > > > Out of curiousity, do we think

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-17 Thread Jonathan Hurley
> On Nov. 17, 2017, 11:25 a.m., Nate Cole wrote: > > Please also verify if BigInsight stacks are affected by this change. If > > that is the case, then a separate JIRA should be opened to address that. Great catch! Looks like it does:

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-17 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63916/#review191346 --- Please also verify if BigInsight stacks are affected by this

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-17 Thread Nate Cole
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63916/#review191345 --- We should add python tests for enabled and disabled LZO for

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-17 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63916/#review191344 --- Fix it, then Ship it!

Re: Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-17 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63916/#review191339 --- Added summary of changes to review description. Please read it

Review Request 63916: YARN, MapReduce2, Hive, and Oozie Should Conditionally Install LZO

2017-11-17 Thread Andrew Onischuk
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63916/ --- Review request for Ambari, Attila Doroszlai, Myroslav Papirkovskyy, Nate Cole,