Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

2015-04-15 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/#review80210 --- Ship it! lgtm modulo the style nit below

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

2015-04-15 Thread Stephan Erb
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32889/ --- (Updated April 15, 2015, 8:38 p.m.) Review request for Aurora, Joshua Cohen

Re: Review Request 32889: Only perform escalation wait when http teardown signal could be dispatched

2015-04-15 Thread Stephan Erb
On April 15, 2015, 6:48 p.m., Joshua Cohen wrote: src/test/python/apache/aurora/executor/test_thermos_task_runner.py, lines 226-227 https://reviews.apache.org/r/32889/diff/2/?file=924600#file924600line226 nit: our python style for continuations is: with

Review Request 33233: Updated mesos library to 0.22.0.

2015-04-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33233/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs:

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/ --- (Updated April 15, 2015, 7:05 p.m.) Review request for Aurora, Bill Farner and

Review Request 33243: Use explicit status update acknowledgements.

2015-04-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33243/ --- Review request for Aurora and Bill Farner. Bugs: AURORA-1228

Review Request 33244: Fixed the end-to-end tests.

2015-04-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33244/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora

Re: Review Request 33233: Updated mesos library to 0.22.0.

2015-04-15 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33233/ --- (Updated April 15, 2015, 10:42 p.m.) Review request for Aurora, Maxim

Re: Review Request 33244: Fixed the end-to-end tests.

2015-04-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33244/#review80277 --- This patch does not apply cleanly on master (b18dc44), do you need

Re: Review Request 33243: Use explicit status update acknowledgements.

2015-04-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33243/#review80276 --- Master (b18dc44) is red with this patch.

Re: Review Request 33243: Use explicit status update acknowledgements.

2015-04-15 Thread Ben Mahler
On April 15, 2015, 10:49 p.m., Aurora ReviewBot wrote: Master (b18dc44) is red with this patch. ./build-support/jenkins/build.sh :compileJavaNote: Writing file:/home/jenkins/jenkins-slave/workspace/AuroraBot/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-15 Thread Maxim Khutornenko
On April 15, 2015, 7:58 p.m., Bill Farner wrote: src/main/java/org/apache/aurora/scheduler/async/preemptor/PendingTaskProcessor.java, line 140 https://reviews.apache.org/r/32597/diff/4/?file=930944#file930944line140 How about ``` ImmutableSet.copyOf(Sets.union(

Re: Review Request 32597: Improving async preemptor efficiency.

2015-04-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/32597/#review80292 --- Ship it! Master (b18dc44) is green with this patch.

Re: Review Request 33244: Fixed the end-to-end tests.

2015-04-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33244/#review80291 --- I have already landed the fix in: