Re: Review Request 38288: Revert "Revert "Refer to shared task_configs table for job updates.""

2015-09-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38288/#review98561 --- Ship it! Master (4ee10b0) is green with this patch. ./build-suppo

Review Request 38288: Revert "Revert "Refer to shared task_configs table for job updates.""

2015-09-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38288/ --- Review request for Aurora and Maxim Khutornenko. Bugs: AURORA-647 https://i

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review98544 --- Ship it! Master (e57993b) is green with this patch. ./build-suppo

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38112/#review98543 --- Ship it! Master (e57993b) is green with this patch. ./build-suppo

Re: Review Request 38270: Remove redundancy between breadcrumbs and page headers. Also make job dashboard link more prominent.

2015-09-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38270/#review98542 --- Master (e57993b) is green with this patch. ./build-support/jenkins

Re: Review Request 38270: Remove redundancy between breadcrumbs and page headers. Also make job dashboard link more prominent.

2015-09-10 Thread Maxim Khutornenko
> On Sept. 11, 2015, 12:16 a.m., Maxim Khutornenko wrote: > > Please, adjust our docs to remove all refs to the old `example` cluster > > name. Otherwise, looks great, can't wait for it to land! > > Joshua Cohen wrote: > I didn't see any reference to the "example" cluster name in the docs.

Re: Review Request 38270: Remove redundancy between breadcrumbs and page headers. Also make job dashboard link more prominent.

2015-09-10 Thread Joshua Cohen
> On Sept. 11, 2015, 12:16 a.m., Maxim Khutornenko wrote: > > Please, adjust our docs to remove all refs to the old `example` cluster > > name. Otherwise, looks great, can't wait for it to land! I didn't see any reference to the "example" cluster name in the docs. Am I missing something? - J

Re: Review Request 38270: Remove redundancy between breadcrumbs and page headers. Also make job dashboard link more prominent.

2015-09-10 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38270/ --- (Updated Sept. 11, 2015, 2:23 a.m.) Review request for Aurora, David McLaughlin

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38112/ --- (Updated Sept. 10, 2015, 7:10 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-10 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/#review98518 --- .gitignore (line 14)

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38112/ --- (Updated Sept. 10, 2015, 5:36 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 38277: Adjusting /utilization and client to show correct consumption.

2015-09-10 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38277/#review98516 --- Ship it! Ship It! - Joe Smith On Sept. 10, 2015, 4:19 p.m., Maxi

Re: Review Request 38270: Remove redundancy between breadcrumbs and page headers. Also make job dashboard link more prominent.

2015-09-10 Thread David McLaughlin
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38270/#review98517 --- Ship it! Ship It! - David McLaughlin On Sept. 10, 2015, 11:56 p.

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38112/#review98515 --- This patch does not apply cleanly on master (98f692d), do you need t

Re: Review Request 38277: Adjusting /utilization and client to show correct consumption.

2015-09-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38277/#review98514 --- Ship it! Master (98f692d) is green with this patch. ./build-suppo

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38112/ --- (Updated Sept. 10, 2015, 5:28 p.m.) Review request for Aurora, Kevin Sweeney an

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-10 Thread Bill Farner
> On Sept. 10, 2015, 5:24 p.m., Maxim Khutornenko wrote: > > Any plans to get rid of mutable thrift objects in mybatis mappers? Yeah, i'd love to. I can take a crack at that after this change lands. > On Sept. 10, 2015, 5:24 p.m., Maxim Khutornenko wrote: > > src/test/java/org/apache/aurora/s

Review Request 38280: Restore build properties within Scheduler vars endpoint and snapshots

2015-09-10 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38280/ --- Review request for Aurora, Maxim Khutornenko and Bill Farner. Bugs: AURORA-1473

Re: Review Request 38112: Alter thrift wrapper generator to use default primitive values and empty collections.

2015-09-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38112/#review98503 --- Ship it! Any plans to get rid of mutable thrift objects in mybatis

Re: Review Request 38270: Remove redundancy between breadcrumbs and page headers. Also make job dashboard link more prominent.

2015-09-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38270/#review98509 --- This patch does not apply cleanly on master (98f692d), do you need t

Re: Review Request 38260: Print a traceback when MesosExecutorDriver fails to load.

2015-09-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38260/#review98508 --- Master (98f692d) is green with this patch. ./build-support/jenkins

Re: Review Request 38270: Remove redundancy between breadcrumbs and page headers. Also make job dashboard link more prominent.

2015-09-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38270/#review98505 --- Please, adjust our docs to remove all refs to the old `example` clus

Re: Review Request 38270: Remove redundancy between breadcrumbs and page headers. Also make job dashboard link more prominent.

2015-09-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38270/#review98504 --- Ship it! Ship It! - Bill Farner On Sept. 10, 2015, 4:56 p.m., Jo

Re: Review Request 38260: Print a traceback when MesosExecutorDriver fails to load.

2015-09-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38260/#review98501 --- Ship it! Ship It! - Maxim Khutornenko On Sept. 10, 2015, 11:53 p

Review Request 38270: Remove redundancy between breadcrumbs and page headers. Also make job dashboard link more prominent.

2015-09-10 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38270/ --- Review request for Aurora, David McLaughlin and Bill Farner. Bugs: AURORA-1474

Re: Review Request 38260: Print a traceback when MesosExecutorDriver fails to load.

2015-09-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38260/ --- (Updated Sept. 10, 2015, 4:53 p.m.) Review request for Aurora and Steve Niemitz

Re: Review Request 38260: Print a traceback when MesosExecutorDriver fails to load.

2015-09-10 Thread Bill Farner
> On Sept. 10, 2015, 10:05 a.m., Zameer Manji wrote: > > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py, line 43 > > > > > > I think this should go to stderr like logging and other diagnostic > >

Review Request 38277: Adjusting /utilization and client to show correct consumption.

2015-09-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38277/ --- Review request for Aurora, Joshua Cohen and Zameer Manji. Bugs: AURORA-1461

Re: Review Request 38210: [aurora-packaging] Adds Monit supervisor support for EL6

2015-09-10 Thread Joe Smith
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38210/#review98476 --- specs/rpm/SOURCES/aurora.monit (line 13)

Re: Review Request 38260: Print a traceback when MesosExecutorDriver fails to load.

2015-09-10 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38260/#review98422 --- Ship it! src/main/python/apache/aurora/executor/bin/thermos_execut

Re: Review Request 38260: Print a traceback when MesosExecutorDriver fails to load.

2015-09-10 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38260/#review98416 --- Master (98f692d) is green with this patch. ./build-support/jenkins

Re: Review Request 38260: Print a traceback when MesosExecutorDriver fails to load.

2015-09-10 Thread Bill Farner
> On Sept. 10, 2015, 9:36 a.m., Maxim Khutornenko wrote: > > src/main/python/apache/aurora/executor/bin/thermos_executor_main.py, line 43 > > > > > > why not using log instead? The log has not been set up at this poi

Re: Review Request 38260: Print a traceback when MesosExecutorDriver fails to load.

2015-09-10 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38260/#review98411 --- src/main/python/apache/aurora/executor/bin/thermos_executor_main.py

Review Request 38260: Print a traceback when MesosExecutorDriver fails to load.

2015-09-10 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/38260/ --- Review request for Aurora and Steve Niemitz. Repository: aurora Description -