Re: Review Request 39113: Use gradle 2.7 in builds.

2015-10-07 Thread Bill Farner
> On Oct. 7, 2015, 8:56 p.m., Joshua Cohen wrote: > > Mind adding a note to build.gradle in the aurora repo to update these as > > well whenever updating the gradle version (maybe point to this review as an > > example)? > > Bill Farner wrote: > The source of truth is in gradle/wrapper/gra

Re: Review Request 39114: Add a note about updating the aurora-packagine repo when changing the gradle version.

2015-10-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39114/#review101856 --- Ship it! Ship It! - Bill Farner On Oct. 7, 2015, 9:05 p.m., Jos

Re: Review Request 39113: Use gradle 2.7 in builds.

2015-10-07 Thread Joshua Cohen
> On Oct. 8, 2015, 3:56 a.m., Joshua Cohen wrote: > > Mind adding a note to build.gradle in the aurora repo to update these as > > well whenever updating the gradle version (maybe point to this review as an > > example)? > > Bill Farner wrote: > The source of truth is in gradle/wrapper/gra

Review Request 39114: Add a note about updating the aurora-packagine repo when changing the gradle version.

2015-10-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39114/ --- Review request for Aurora and Bill Farner. Repository: aurora Description ---

Re: Review Request 39113: Use gradle 2.7 in builds.

2015-10-07 Thread Bill Farner
> On Oct. 7, 2015, 8:56 p.m., Joshua Cohen wrote: > > Mind adding a note to build.gradle in the aurora repo to update these as > > well whenever updating the gradle version (maybe point to this review as an > > example)? The source of truth is in gradle/wrapper/gradle-wrapper.properties, which

Re: Review Request 39113: Use gradle 2.7 in builds.

2015-10-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39113/#review101853 --- Ship it! Mind adding a note to build.gradle in the aurora repo to

Review Request 39113: Use gradle 2.7 in builds.

2015-10-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39113/ --- Review request for Aurora and Joshua Cohen. Repository: aurora-packaging Desc

Re: Review Request 39095: Upgrade to gradle 2.7 and checkstyle 6.11.2.

2015-10-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39095/#review101796 --- Ship it! Master (d884680) is green with this patch. ./build-supp

Re: Review Request 39095: Upgrade to gradle 2.7 and checkstyle 6.11.2.

2015-10-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39095/#review101791 --- Ship it! Ship It! - Joshua Cohen On Oct. 7, 2015, 4:50 p.m., Bi

Re: Review Request 39095: Upgrade to gradle 2.7 and checkstyle 6.11.2.

2015-10-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39095/#review101788 --- Ship it! Ship It! - Maxim Khutornenko On Oct. 7, 2015, 4:50 p.m

Review Request 39095: Upgrade to gradle 2.7 and checkstyle 6.11.2.

2015-10-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39095/ --- Review request for Aurora and Joshua Cohen. Repository: aurora Description --

Re: Review Request 39089: Better handling of enums and constructor-only classes in test coverage check.

2015-10-07 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39089/#review101783 --- Ship it! Ship It! - Maxim Khutornenko On Oct. 7, 2015, 3:31 p.m

Re: Review Request 39089: Better handling of enums and constructor-only classes in test coverage check.

2015-10-07 Thread Joshua Cohen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39089/#review101777 --- Ship it! Ship It! - Joshua Cohen On Oct. 7, 2015, 3:31 p.m., Bi

Re: Review Request 39089: Better handling of enums and constructor-only classes in test coverage check.

2015-10-07 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39089/#review101770 --- Ship it! Master (33d7e21) is green with this patch. ./build-supp

Review Request 39089: Better handling of enums and constructor-only classes in test coverage check.

2015-10-07 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/39089/ --- Review request for Aurora and Maxim Khutornenko. Repository: aurora Descripti